RE: [PATCH] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
Hi Jani Nikula, thanks for reviewing, I'll use msleep instead, thanks! Xin > -Original Message- > From: Jani Nikula > Sent: Thursday, September 21, 2023 8:09 PM > To: Xin Ji ; Andrzej Hajda ; > Neil Armstrong ; Robert Foss ; > Laurent Pinchart ; Jonas Karlman > ; Jernej Skrabec ; David A

Re: [PATCH v5 04/11] PM / QoS: Decouple request alloc from dev_pm_qos_mtx

2023-09-22 Thread kernel test robot
e at: https://download.01.org/0day-ci/archive/20230922/202309221426.fb0fe750-oliver.s...@intel.com -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki

Re: [PATCH] fbdev: sh7760fb: require FB=y to build cleanly

2023-09-22 Thread Geert Uytterhoeven
Hi Randy, On Thu, Sep 21, 2023 at 10:43 PM Randy Dunlap wrote: > Fix build errors when CONFIG_FB=m and CONFIG_FB_SH7760=y: > > sh2-linux-ld: drivers/video/fbdev/sh7760fb.o: in function `sh7760fb_probe': > sh7760fb.c:(.text+0x374): undefined reference to `framebuffer_alloc' > sh2-linux-ld: sh7760f

Re: [PATCH v2] drm: renesas: rcar-du: use proper naming for R-Car

2023-09-22 Thread Geert Uytterhoeven
On Fri, Sep 22, 2023 at 2:58 AM Wolfram Sang wrote: > Not RCAR, but R-Car. > > Signed-off-by: Wolfram Sang > Reviewed-by: Kieran Bingham > --- > > Changes since v1: > * rebased to 6.6-rc2 > * added tag from Kieran (Thanks!) Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

[PATCH] drm: tilcdc: don't use devm_pinctrl_get_select_default() in probe

2023-09-22 Thread Wolfram Sang
Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from device core"), we can rely on device core for setting the default pins. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/til

Re: [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect()

2023-09-22 Thread Thomas Zimmermann
Hi Javier Am 20.09.23 um 10:01 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Only PowerPC's fb_pgprotect() needs the file argument, although the implementation does not use it. Pass NULL to the internal Can you please mention the function that's the implementati

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Laurentiu Palcu
Hi, On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanl

Re: [PATCH 2/3] kunit: Add kunit_move_action_to_top_or_reset() to reorder actions

2023-09-22 Thread David Gow
On Wed, 20 Sept 2023 at 14:12, Arthur Grillo wrote: > > On Kunit, if we allocate a resource A and B on this order, with its > deferred actions to free them. The resource stack would be something > like this: > > +-+ > | free(B) | > +-+ > | ...

[PATCH v5 1/5] fbdev: Avoid file argument in fb_pgprotect()

2023-09-22 Thread Thomas Zimmermann
Only PowerPC's fb_pgprotect() needs the file argument, although the implementation in either phys_mem_access_prot() or pci_phys_mem_access_prot() does not use it. Pass NULL to the internal helper in preparation of further updates. A later patch will remove the file parameter from fb_pgprotect(). W

[PATCH v5 0/5] ppc, fbdev: Clean up fbdev mmap helper

2023-09-22 Thread Thomas Zimmermann
Clean up and rename fb_pgprotect() to work without struct file. Then refactor the implementation for PowerPC. This change has been discussed at [1] in the context of refactoring fbdev's mmap code. The first two patches update fbdev and replace fbdev's fb_pgprotect() with pgprot_framebuffer() on al

[PATCH v5 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()

2023-09-22 Thread Thomas Zimmermann
Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). The helper sets VMA page-access flags for framebuffers in device I/O memory. Also clean up the helper's parameters and return value. Instead of the VMA instance, pass the individial parameters separately: existing page-access fla

[PATCH v5 3/5] arch/powerpc: Remove trailing whitespaces

2023-09-22 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Philippe Mathieu-Daudé --- arch/powerpc/include/asm/machdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/include/asm/machdep.h b/a

[PATCH v5 4/5] arch/powerpc: Remove file parameter from phys_mem_access_prot code

2023-09-22 Thread Thomas Zimmermann
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot and its implementation in pci_phys_mem_access_prot(). The file is not used on PowerPC. By removing it, a later patch can simplify fbdev's mmap code, which uses phys_mem_access_prot() on PowerPC. Signed-off-by: Thomas Zimmermann

[PATCH v5 5/5] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code

2023-09-22 Thread Thomas Zimmermann
Call __phys_mem_access_prot() from the fbdev mmap helper pgprot_framebuffer(). Allows to avoid the file argument of NULL. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann --- arch/powerpc/include/asm/fb.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/

WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-22 Thread Rafał Miłecki
Hi, backporting commit 187916e6ed9d ("drm/amdgpu: install stub fence into potential unused fence pointers") to stable kernels resulted in lots of WARNINGs on some devices. In my case I was getting 3 WARNINGs per second (~150 lines logged every second). Commit ended up being reverted for stable but

[PATCH] drm/gem: avoid potential dereference of error pointers

2023-09-22 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_gdp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti

[PATCH] drm/sti: avoid potential dereference of error pointers

2023-09-22 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_cursor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/d

Re: WARNING in amdgpu_sync_keep_later / dma_fence_is_later should be rate limited

2023-09-22 Thread Rafał Miłecki
On 21.09.2023 21:52, Deucher, Alexander wrote: backporting commit 187916e6ed9d ("drm/amdgpu: install stub fence into potential unused fence pointers") to stable kernels resulted in lots of WARNINGs on some devices. In my case I was getting 3 WARNINGs per second (~150 lines logged every second). C

Re: [PATCH v5 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()

2023-09-22 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). > The helper sets VMA page-access flags for framebuffers in device I/O > memory. > > Also clean up the helper's parameters and return value. Instead of > the VMA instance, pass the individial paramete

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Iddamsetty, Aravind
On 21-09-2023 17:18, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the newly added drm_print_memory_stats helper to show memory > utilisation of our objects in drm/driver specific fdinfo output. > > To collect the stats we walk the per memory regions object lists > and accumulate objec

[PATCH v2] drm/bridge: Add 200ms delay to wait FW HPD status stable

2023-09-22 Thread Xin Ji
For the no-interrupt design (sink device is panel, polling HPD status when chip power on), anx7625 FW has more than 200ms HPD de-bounce time in FW, for the safety to get HPD status, driver better to wait 200ms before HPD detection after OS resume back. Signed-off-by: Xin Ji --- drivers/gpu/drm/b

Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection

2023-09-22 Thread Jani Nikula
On Tue, 19 Sep 2023, Chen-Yu Tsai wrote: > On Tue, Sep 19, 2023 at 7:02 PM Jani Nikula wrote: >> >> On Fri, 15 Sep 2023, Chen-Yu Tsai wrote: >> > On Thu, Sep 14, 2023 at 11:53 PM Jani Nikula wrote: >> >> >> >> The sads returned by drm_edid_to_sad() needs to be freed. >> >> >> >> Fixes: e71a8ebb

Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks

2023-09-22 Thread Javier Martinez Canillas
"Maxime Ripard" writes: > On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote: >> The driver uses a naming convention where functions for struct drm_*_funcs >> callbacks are named ssd130x_$object_$operation, while the callbacks for >> struct drm_*_helper_funcs are named ssd130x_$ob

RE: [PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-22 Thread Ying Liu
On Friday, September 22, 2023 4:03 AM Lucas Stach wrote: > drm_atomic_helper_commit_tail_rpm makes it hard for drivers to follow > the documented encoder/bridge enable flow, as it commits all CRTC enables > before the planes are fully set up, so drivers that can't enable the > display link withou

Re: Decrypting tt maps in ttm

2023-09-22 Thread Christian König
Am 21.09.23 um 09:12 schrieb Thomas Hellström: On 9/21/23 05:51, Zack Rusin wrote: On Wed, 2023-09-20 at 21:22 +0200, Thomas Hellström wrote: !! External Email On 9/20/23 20:24, Zack Rusin wrote: On Wed, 2023-09-20 at 19:17 +0200, Thomas Hellström wrote: !! External Email Hi, Zack On 9

Re: [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:40, Tvrtko Ursulin wrote: >On 20/09/2023 00:34, Adrián Larumbe wrote: >> The drm-stats fdinfo tags made available to user space are drm-engine, >> drm-cycles, drm-max-freq and drm-curfreq, one per job slot. >> >> This deviates from standard practice in other DRM drivers, where a s

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Tvrtko Ursulin
On 22/09/2023 09:48, Iddamsetty, Aravind wrote: On 21-09-2023 17:18, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory reg

Re: [PATCH v6 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:53, Tvrtko Ursulin wrote: > >On 20/09/2023 00:34, Adrián Larumbe wrote: >> Some BO's might be mapped onto physical memory chunkwise and on demand, >> like Panfrost's tiler heap. In this case, even though the >> drm_gem_shmem_object page array might already be allocated, only a very

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Andi Shyti
Hi Tvrtko, On Thu, Sep 21, 2023 at 12:48:52PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use the newly added drm_print_memory_stats helper to show memory > utilisation of our objects in drm/driver specific fdinfo output. > > To collect the stats we walk the per memory regions objec

Re: [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-22 Thread Adrián Larumbe
On 20.09.2023 16:32, Tvrtko Ursulin wrote: > >On 20/09/2023 00:34, Adrián Larumbe wrote: >> The current implementation will try to pick the highest available size >> display unit as soon as the BO size exceeds that of the previous >> multiplier. That can lead to loss of precision in contexts of low

Re: [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-22 Thread Adrián Larumbe
On 21.09.2023 11:14, Tvrtko Ursulin wrote: > >On 20/09/2023 16:32, Tvrtko Ursulin wrote: >> >> On 20/09/2023 00:34, Adrián Larumbe wrote: >> > The current implementation will try to pick the highest available size >> > display unit as soon as the BO size exceeds that of the previous >> > multiplie

Re: [PATCH drm-misc-next v4 6/8] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:39 +0200 Danilo Krummrich wrote: > void drm_gpuvm_init(struct drm_gpuvm *gpuvm, struct drm_device *drm, > - const char *name, > + const char *name, enum drm_gpuva_flags flags, s/drm_gpuva_flags/drm_gpuvm_flags/gc

Re: [PATCH drm-misc-next v4 7/8] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:40 +0200 Danilo Krummrich wrote: > + /** > + * @DRM_GPUVM_RESV_PROTECTED: GPUVM is protected externally by the > + * GPUVM's &dma_resv lock I think we need to be more specific, and list the fields/operations that need to be externally protected when DRM_GP

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-22 Thread H. Nikolaus Schaller
Hi, I have tested this on an OMAP5 Pyra. > Am 21.09.2023 um 12:50 schrieb Tomi Valkeinen > : > > It's been reported that DSI host driver's detach can be called without > the attach ever happening: > > https://lore.kernel.org/all/20230412073954.20601-1-t...@atomide.com/ > This patch works equa

Re: [PATCH drm-misc-next v4 6/8] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm

2023-09-22 Thread Boris Brezillon
On Wed, 20 Sep 2023 16:42:39 +0200 Danilo Krummrich wrote: > +/** > + * enum drm_gpuvm_flags - flags for struct drm_gpuvm > + */ > +enum drm_gpuvm_flags { > + /** > + * @DRM_GPUVM_USERBITS: user defined bits > + */ > + DRM_GPUVM_USERBITS = (1 << 0), Nit: I tried declaring drive

Re: [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-22 Thread Maxime Ripard
On Thu, Sep 21, 2023 at 10:41:43AM +0300, Jani Nikula wrote: > On Wed, 13 Sep 2023, Mitul Golani > wrote: > > From: Ankit Nautiyal > > > > Add helper to get the DSC bits_per_pixel precision for the DP sink. > > > > Signed-off-by: Ankit Nautiyal > > Maarten, Maxime, Thomas, ack for merging this

Re: [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-22 Thread Jani Nikula
On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: > On 21-Sep-23 5:44 PM, Jani Nikula wrote: >> On Thu, 21 Sep 2023, "Sharma, Swati2" wrote: >>> On 21-Sep-23 1:30 PM, Jani Nikula wrote: On Wed, 13 Sep 2023, Mitul Golani wrote: > From: Swati Sharma > > DSC_Sink_BPP_Precision en

Re: [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Iddamsetty, Aravind
On 22-09-2023 16:27, Tvrtko Ursulin wrote: > > On 22/09/2023 09:48, Iddamsetty, Aravind wrote: >> >> >> On 21-09-2023 17:18, Tvrtko Ursulin wrote: >>> From: Tvrtko Ursulin >>> >>> Use the newly added drm_print_memory_stats helper to show memory >>> utilisation of our objects in drm/driver spec

[PATCH] drm/i915/gem: Make i915_gem_shrinker multi-gt aware

2023-09-22 Thread Nirmoy Das
From: Jonathan Cavitt Where applicable, use for_each_gt instead of to_gt in the i915_gem_shrinker functions to make them apply to more than just the primary GT. Specifically, this ensure i915_gem_shrink_all retires all requests across all GTs, and this makes i915_gem_shrinker_vmap unmap VMAs fro

Re: [Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support

2023-09-22 Thread Imre Deak
On Wed, Sep 13, 2023 at 11:35:58AM +0530, Mitul Golani wrote: > his patch series adds support for DSC fractional compressed bpp > for MTL+. The series starts with some fixes, followed by patches that > lay groundwork to iterate over valid compressed bpps to select the > 'best' compressed bpp with o

[PATCH] accel/ivpu: Add Arrow Lake pci id

2023-09-22 Thread Stanislaw Gruszka
Enable VPU on Arrow Lake CPUs. Reviewed-by: Krystian Pradzynski Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_drv.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/ac

[PATCH v7 0/6] fdinfo memory stats

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A short series to enable fdinfo memory stats for i915. I added tracking of most classes of objects (user objects, page tables, context state, ring buffers) which contribute to client's memory footprint and am accouting their memory use along the similar lines as in Rob's msm

[PATCH 4/6] drm/i915: Account ring buffer and context state storage

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_context.c | 14 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 +++

[PATCH 1/6] drm/i915: Add ability for tracking buffer objects per client

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold refere

[PATCH 3/6] drm/i915: Track page table backing store usage

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt

[PATCH 5/6] drm/i915: Add stable memory region names

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin At the moment memory region names are a bit too varied and too inconsistent to be used for ABI purposes, like for upcoming fdinfo memory stats. System memory can be either system or system-ttm. Local memory has the instance number appended, others do not. Not only incosisten

[PATCH 2/6] drm/i915: Record which client owns a VM

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11

[PATCH 6/6] drm/i915: Implement fdinfo memory stats printing

2023-09-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. v2:

Re: [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-22 Thread Tvrtko Ursulin
On 22/09/2023 11:57, Adrián Larumbe wrote: On 20.09.2023 16:40, Tvrtko Ursulin wrote: On 20/09/2023 00:34, Adrián Larumbe wrote: The drm-stats fdinfo tags made available to user space are drm-engine, drm-cycles, drm-max-freq and drm-curfreq, one per job slot. This deviates from standard prac

Re: [PATCH v4 0/7] drm: ci: fixes

2023-09-22 Thread Helen Koike
On 14/09/2023 05:54, Vignesh Raman wrote: The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. This series is intended for drm branch drm-next

Re: [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-22 Thread Tvrtko Ursulin
On 22/09/2023 12:03, Adrián Larumbe wrote: On 21.09.2023 11:14, Tvrtko Ursulin wrote: On 20/09/2023 16:32, Tvrtko Ursulin wrote: On 20/09/2023 00:34, Adrián Larumbe wrote: The current implementation will try to pick the highest available size display unit as soon as the BO size exceeds tha

[PATCH v6 03/16] dt-bindings: media: mediatek: mdp3: include common properties

2023-09-22 Thread Moudy Ho
To minimize duplication and standardize the document style, include the common properties for MT8183 RDMA. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-rdma.yaml| 43 ++- 1 file changed, 4 insertions(+), 39 deletions(-) diff --git a/Documentation/devicetree/b

[PATCH v6 00/16] introduce more MDP3 components in MT8195

2023-09-22 Thread Moudy Ho
Changes since v5: - Rebase on v6.6-rc2. - Dependent dtsi files: https://patchwork.kernel.org/project/linux-mediatek/list/?series=786511 - Depends on: Message ID = 20230911074233.31556-5-shawn.s...@mediatek.com - Split out common propertis for RDMA. - Split each component into independent patche

[PATCH v6 10/16] dt-bindings: media: mediatek: mdp3: add component TDSHP for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component TDSHP, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-tdshp.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/

[PATCH v6 08/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component STITCH, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-stitch.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/media

[PATCH v6 11/16] dt-bindings: display: mediatek: aal: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the AAL block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,a

[PATCH v6 01/16] dt-bindings: media: mediatek: mdp3: correct RDMA and WROT node with generic names

2023-09-22 Thread Moudy Ho
The DMA-related nodes RDMA/WROT in MDP3 should be changed to generic names. In addition, fix improper space indent in example. Fixes: 4ad7b39623ab ("media: dt-binding: mediatek: add bindings for MediaTek MDP3 components") Signed-off-by: Moudy Ho Acked-by: Rob Herring --- .../bindings/media/med

[PATCH v6 06/16] dt-bindings: media: mediatek: mdp3: add component FG for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component FG, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-fg.yaml | 61 +++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/med

RE: [PATCH v1] drm/dp/mst: fix missing modeset unlock for MST port detect

2023-09-22 Thread Ramya SR
Gentle Reminder. Please review the commit. -Original Message- From: Ramya SR (QUIC) Sent: Friday, September 15, 2023 10:25 AM To: David Airlie ; Daniel Vetter ; Lyude Paul ; Wayne Lin ; Jani Nikula ; Imre Deak ; Alex Deucher ; Jeff Layton ; dri-devel@lists.freedesktop.org; linux-ker.

[PATCH v6 13/16] dt-bindings: display: mediatek: merge: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the MERGE block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,merge.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek

[PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the COLOR block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek

[PATCH v6 04/16] dt-bindings: media: mediatek: mdp3: rename to MT8183 RDMA

2023-09-22 Thread Moudy Ho
The file was renamed to support future scalability in response to the changes in general properties separation. Signed-off-by: Moudy Ho --- .../{mediatek,mdp3-rdma.yaml => mediatek,mdp3-rdma-8183.yaml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename Documentation/devicetree/bindi

[PATCH v6 15/16] dt-bindings: display: mediatek: split: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the SPLIT block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,split.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek

[PATCH v6 16/16] dt-bindings: display: mediatek: padding: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the PAD block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../bindings/display/mediatek/mediatek,padding.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/med

[PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA

2023-09-22 Thread Moudy Ho
Support for MT8195 RDMA has been added, allowing for the configuration of multiple MDP3 pipes. Furthermore, this particular device does not require sharing SRAM with RSZ. Signed-off-by: Moudy Ho --- .../media/mediatek,mdp3-rdma-8195.yaml| 64 +++ 1 file changed, 64 insert

[PATCH v6 09/16] dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component STITCH, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-tcc.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/media

[PATCH v6 02/16] dt-bindings: media: mediatek: mdp3: split out general properties

2023-09-22 Thread Moudy Ho
In order to minimize duplication and standardize the document style, it is necessary to separate the general properties specific to MediaTek MDP3 RDMA. Signed-off-by: Moudy Ho --- .../media/mediatek,mdp3-rdma-common.yaml | 72 +++ 1 file changed, 72 insertions(+) create mod

[PATCH v6 14/16] dt-bindings: display: mediatek: ovl: add compatible for MT8195

2023-09-22 Thread Moudy Ho
Add a compatible string for the OVL block in MediaTek MT8195 that is controlled by MDP3. Signed-off-by: Moudy Ho --- .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,o

[PATCH v6 07/16] dt-bindings: media: mediatek: mdp3: add component HDR for MT8195

2023-09-22 Thread Moudy Ho
Add the fundamental hardware configuration of component HDR, which is controlled by MDP3 on MT8195. Signed-off-by: Moudy Ho --- .../bindings/media/mediatek,mdp3-hdr.yaml | 60 +++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/me

Re: [PATCH v2 3/6] drm: lcdif: rework runtime PM handling in the atomic commit

2023-09-22 Thread Lucas Stach
Am Freitag, dem 22.09.2023 um 09:51 + schrieb Ying Liu: > On Friday, September 22, 2023 4:03 AM Lucas Stach > wrote: > > drm_atomic_helper_commit_tail_rpm makes it hard for drivers to follow > > the documented encoder/bridge enable flow, as it commits all CRTC enables > > before the planes ar

Re: [1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-22 Thread Sui Jingfeng
Hi, The word 'prescision' in the commit title is a typo, perhaps it's more better correct it as 'precision' when merge. On 2023/9/13 14:05, Mitul Golani wrote: From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal Reviewed-b

Re: [PATCH 6/7] accel/qaic: Create a function to initialize BO

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:48 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:46AM -0600, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya This makes sure that we have a single place to initialize and re-initialize BO. Use this new API to cleanup release_dbc() We will need this for nex

Re: [3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj

Re: [PATCH 7/7] accel/qaic: Add QAIC_DETACH_SLICE_BO IOCTL

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:56 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:47AM -0600, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Once a BO is attached with slicing configuration that BO can only be used for that particular setting. With this new feature user can detach slicing

Re: [PATCH 0/7] accel/qaic: Extend uAPI to support undoing ATTACH_SLICE_BO

2023-09-22 Thread Jeffrey Hugo
On 9/17/2023 2:58 AM, Stanislaw Gruszka wrote: On Fri, Sep 01, 2023 at 11:22:40AM -0600, Jeffrey Hugo wrote: A BO for a QAIC device has two states - 1. Allocated 2. Sliced A BO can be allocated at any time, and is initialized in the allocated state. A BO can transition to the sliced state via A

Re: [RFC 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback

2023-09-22 Thread Jeffrey Hugo
On 9/19/2023 3:24 AM, Stanislaw Gruszka wrote: On Mon, Sep 11, 2023 at 09:19:03AM -0600, Jeffrey Hugo wrote: On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz gem->open() is called during handle creation for a gem object. It is called during prime import and in BO_CREATE

Re: [RFC 3/4] accel/ivpu: Remove support for uncached buffers

2023-09-22 Thread Jeffrey Hugo
On 9/19/2023 3:49 AM, Stanislaw Gruszka wrote: On Mon, Sep 11, 2023 at 09:24:42AM -0600, Jeffrey Hugo wrote: On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC. There is no functional benefit from DRM_IVPU

Re: [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-22 Thread Steven Price
On 22/09/2023 14:53, Tvrtko Ursulin wrote: > > On 22/09/2023 11:57, Adrián Larumbe wrote: >> On 20.09.2023 16:40, Tvrtko Ursulin wrote: >>> On 20/09/2023 00:34, Adrián Larumbe wrote: The drm-stats fdinfo tags made available to user space are drm-engine, drm-cycles, drm-max-freq and drm-c

Re: [PATCH] accel/ivpu: Add Arrow Lake pci id

2023-09-22 Thread Jeffrey Hugo
On 9/22/2023 7:22 AM, Stanislaw Gruszka wrote: Enable VPU on Arrow Lake CPUs. Reviewed-by: Krystian Pradzynski Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 1 + drivers/accel/ivpu/ivpu_drv.h | 2 ++ 2 files changed, 3 insertions(+) dif

Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support

2023-09-22 Thread Chris Morgan
On Fri, Aug 11, 2023 at 09:41:48AM -0500, Chris Morgan wrote: > On Thu, Aug 10, 2023 at 05:24:09PM -0600, Rob Herring wrote: > > On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Document the Anbernic RG351V panel, which appears to be identical to

Re: [PATCH v6 03/16] dt-bindings: media: mediatek: mdp3: include common properties

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:03PM +0800, Moudy Ho wrote: > To minimize duplication and standardize the document style, > include the common properties for MT8183 RDMA. Duplication that you created in the previous patch? Why not combine patches 2 & 3? Cheers, Conor. > > Signed-off-by: Moudy Ho

Re: [PATCH v6 04/16] dt-bindings: media: mediatek: mdp3: rename to MT8183 RDMA

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:04PM +0800, Moudy Ho wrote: > The file was renamed to support future scalability in response to > the changes in general properties separation. > > Signed-off-by: Moudy Ho Same with this, not all too sure why this is a commit of its own. > --- > .../{mediatek,mdp3

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Doug Anderson
Hi, On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu wrote: > > Hi, > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among o

Re: [PATCH v6 05/16] dt-bindings: media: mediatek: mdp3: add support MT8195 RDMA

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:05PM +0800, Moudy Ho wrote: > Support for MT8195 RDMA has been added, allowing for > the configuration of multiple MDP3 pipes. > Furthermore, this particular device does not require > sharing SRAM with RSZ. I'm sorry if I am going over past arguments, if this is 90% t

Re: [PATCH v6 11/16] dt-bindings: display: mediatek: aal: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:11PM +0800, Moudy Ho wrote: > Add a compatible string for the AAL block in MediaTek MT8195 that > is controlled by MDP3. > > Signed-off-by: Moudy Ho Acked-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml |

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > Add a compatible string for the COLOR block in MediaTek MT8195 that > is controlled by MDP3. > > Signed-off-by: Moudy Ho > --- > .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v6 12/16] dt-bindings: display: mediatek: color: add compatible for MT8195

2023-09-22 Thread Conor Dooley
On Fri, Sep 22, 2023 at 04:49:14PM +0100, Conor Dooley wrote: > On Fri, Sep 22, 2023 at 03:21:12PM +0800, Moudy Ho wrote: > > Add a compatible string for the COLOR block in MediaTek MT8195 that > > is controlled by MDP3. > > > > Signed-off-by: Moudy Ho > > --- > > .../devicetree/bindings/display

Re: [2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Ankit Nautiyal DSC parameter bits_per_pixel is stored in U6.4 format. The 4 bits represent the fractional part of the bpp. Currently we use compressed_bpp member of dsc structure to store only the integral part of the bits_per_pixel. To store

Re: [7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-22 Thread Sui Jingfeng
Hi, On 2023/9/13 14:06, Mitul Golani wrote: From: Swati Sharma DSC_Sink_BPP_Precision entry is added to i915_dsc_fec_support_show to depict sink's precision. Also, new debugfs entry is created to enforce fractional bpp. If Force_DSC_Fractional_BPP_en is set then while iterating over output bp

Re: [PATCH 0/7] accel/qaic: Extend uAPI to support undoing ATTACH_SLICE_BO

2023-09-22 Thread Jeffrey Hugo
On 9/1/2023 11:22 AM, Jeffrey Hugo wrote: A BO for a QAIC device has two states - 1. Allocated 2. Sliced A BO can be allocated at any time, and is initialized in the allocated state. A BO can transition to the sliced state via ATTACH_SLICE_BO. This prepares the BO for use with an active workloa

Re: [PATCH v4 5/7] drm: ci: Update xfails

2023-09-22 Thread Helen Koike
Hi o/ On 14/09/2023 05:54, Vignesh Raman wrote: Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the *-f

Re: [git pull] drm fixes for 6.6-rc3

2023-09-22 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Sep 2023 16:14:46 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-09-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b41b28366d3b176c8297961de4f095f2e392402d Thank you! -- Deet-doot-dot, I am a bot. https://k

[PATCH v2 0/2] drm/ci: Update Mesa and Introduce VKMS Support

2023-09-22 Thread Helen Koike
This patchset offers two enhancements to drm/ci: 1. Mesa Version Update. drm/ci re-uses components from Mesa project. A recent bug in MesaCI was fixed. The first patch updates drm/ci Mesa's version, re-allowing containers rebuilds when uncached, essencial for new runs. 2. VKMS Driver Testing, tog

[PATCH v2 1/2] drm/ci: uprev mesa version - fix container build

2023-09-22 Thread Helen Koike
When building containers, some rust packages were installed without locking the dependencies version, which got updated and started giving errors like: error: failed to compile `bindgen-cli v0.62.0`, intermediate artifacts can be found at `/tmp/cargo-installkNKRwf` Caused by: package `rustix v0

[PATCH v2 2/2] drm/ci: add tests on vkms

2023-09-22 Thread Helen Koike
Add job that runs igt on top of vkms. Signed-off-by: Helen Koike --- See pipeline: https://gitlab.freedesktop.org/helen.fornazier/linux/-/pipelines/990494 v2: - do not mv modules to /lib/modules in the job definition, leave it to crosvm-runner.sh --- MAINTAINERS

[PATCH 1/9] drm/amd/pm: Annotate struct smu10_voltage_dependency_table with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family funct

[PATCH 0/9] drm: Annotate structs with __counted_by

2023-09-22 Thread Kees Cook
Hi, This is a batch of patches touching drm for preparing for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CO

[PATCH 3/9] drm/i915/selftests: Annotate struct perf_series with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family funct

[PATCH 4/9] drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family funct

[PATCH 7/9] drm/virtio: Annotate struct virtio_gpu_object_array with __counted_by

2023-09-22 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family funct

  1   2   >