Re: [PATCH 1/2] kunit: Warn if tests are slow

2023-09-20 Thread Maxime Ripard
Hi, On Tue, Sep 19, 2023 at 03:48:55PM -0400, Rae Moar wrote: > On Mon, Sep 11, 2023 at 5:51 AM Maxime Ripard wrote: > > > > Kunit recently gained support to setup attributes, the first one being > > the speed of a given test, then allowing to filter out slow tests. > > > > A slow test is defined

Re: [PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-09-20 Thread Dmitry Baryshkov
On Wed, 20 Sept 2023 at 05:08, Bjorn Andersson wrote: > > On Thu, Aug 17, 2023 at 05:59:37PM +0300, Dmitry Baryshkov wrote: > > Declare the displayport controller present on the Qualcomm SM8250 SoC. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 +++

Re: Decrypting tt maps in ttm

2023-09-20 Thread Thomas Hellström
Hi, Zack, On 9/20/23 05:43, Zack Rusin wrote: On Tue, 2023-09-19 at 09:47 +0200, Christian König wrote: !! External Email Am 19.09.23 um 08:56 schrieb Thomas Hellström: On 9/19/23 07:39, Christian König wrote: Am 19.09.23 um 03:26 schrieb Zack Rusin: On Mon, 2023-09-18 at 16:21 -0400, Alex

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Thomas Hellström
Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21, Thomas Hellström wrote: Hi Christian On 9/19/23 14:07, Christian König wrote: Am 13.09.23 um 17:46 schrieb Danilo Krummrich: On 9/13/23 1

Re: [PATCH v2] drm/simpledrm: Add support for multiple "power-domains"

2023-09-20 Thread Sven Peter
Hi, On Mon, Sep 18, 2023, at 09:11, Thomas Zimmermann wrote: > Hi > > Am 12.09.23 um 22:22 schrieb Janne Grunau via B4 Relay: >> From: Janne Grunau >> >> Multiple power domains need to be handled explicitly in each driver. The >> driver core can not handle it automatically since it is not aware

Re: [PATCH] drm/virtio: clean out_fence on complete_submit

2023-09-20 Thread José Pekkarinen
On 2023-09-12 09:08, José Pekkarinen wrote: The removed line prevents the following cleanup function to execute a dma_fence_put on the out_fence to free its memory, producing the following output in kmemleak: unreferenced object 0x888126d8ee00 (size 128): comm "kwin_wayland", pid 981, jiff

Re: [PATCH v2] drm/atomic-helper: prevent uaf in wait_for_vblanks

2023-09-20 Thread José Pekkarinen
On 2023-09-19 08:26, José Pekkarinen wrote: Kasan reported the following in my system: [ 3935.321003] == [ 3935.321022] BUG: KASAN: slab-use-after-free in drm_atomic_helper_wait_for_vblanks.part.0+0x116/0x450 [drm_kms_helper] [ 3935

[PATCH] gpu: drm: amd: display: fix kernel-doc warnings

2023-09-20 Thread Swarup Laxman Kotiaklapudi
Fix kernel-doc warnings discovered in AMD gpu display driver. Fixes these warnings: ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:110: warning: Function parameter or member 'overlap_only' not described in 'mpcc_blnd_cfg'. ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:110: warning: Function paramet

[PATCH] drm/sti: avoid potential dereference of error pointers

2023-09-20 Thread Ma Ke
The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_cursor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/d

Re: [PATCH v4 1/5] fbdev: Avoid file argument in fb_pgprotect()

2023-09-20 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Only PowerPC's fb_pgprotect() needs the file argument, although > the implementation does not use it. Pass NULL to the internal Can you please mention the function that's the implementation for PowerPC ? If I'm looking at the code correctly, that functi

Re: [PATCH] drm/atomic-helper: prevent uaf in wait_for_vblanks

2023-09-20 Thread José Pekkarinen
On 2023-09-19 19:56, Michel Dänzer wrote: On 9/18/23 18:53, José Pekkarinen wrote: Kasan reported the following in my system: [ 3935.321003] == [ 3935.321022] BUG: KASAN: slab-use-after-free in drm_atomic_helper_wait_for_vblanks.

Re: [PATCH v10 03/16] drm/mediatek: gamma: Support SoC specific LUT size

2023-09-20 Thread AngeloGioacchino Del Regno
Il 18/09/23 04:30, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Fri, 2023-08-04 at 09:28 +0200, AngeloGioacchino Del Regno wrote: Newer SoCs support a bigger Gamma LUT table: wire up a callback to retrieve the correct LUT size for each different Gamma IP. Co-developed-by: Jason-JH.Lin Signed-off-by

Re: [PATCH v4 2/5] fbdev: Replace fb_pgprotect() with pgprot_framebuffer()

2023-09-20 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Rename the fbdev mmap helper fb_pgprotect() to pgprot_framebuffer(). > The helper sets VMA page-access flags for framebuffers in device I/O > memory. > I think this rename makes it more clear. > Also clean up the helper's parameters and return value. I

Re: PROBLEM: MT8192 panel_edp_probe trace despite recent eDP and aux-bus support patches

2023-09-20 Thread AngeloGioacchino Del Regno
Il 20/09/23 02:58, Leonard Lausen ha scritto: Dear AngeloGioacchino, Dear Maintainers, on MT8192 Asurada Spherion (Acer 514), I observe the following trace related to eDP and aux-bus during bootup with tags/mediatek-drm-next-6.6 merged to v6.5.4 as well as on plain v6.5.4. Despite the trace, the

Re: [PATCH] drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR

2023-09-20 Thread AngeloGioacchino Del Regno
Il 19/09/23 03:45, Ying Liu ha scritto: Hi Angelo, Thank you for the patch. On Monday, September 18, 2023 11:01 PM, AngeloGioacchino Del Regno wrote: When external bridges are attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR, the panel bridge may also get the same flag, but in the .attach() call

[PATCH v2] drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR

2023-09-20 Thread AngeloGioacchino Del Regno
When external bridges are attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR, the panel bridge may also get the same flag, but in the .attach() callback for the panel bridge a device link is added only when this flag is not present; To make things worse, the .detach() callback tries to delete the device

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Thomas Hellström
On 9/20/23 09:44, Thomas Hellström wrote: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21, Thomas Hellström wrote: Hi Christian On 9/19/23 14:07, Christian König wrote: Am 13.09.23 um 1

[PATCH] drm/i915: Zap some empty lines

2023-09-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Recent refactoring left an unsightly block of empty lines. Remove them. Signed-off-by: Tvrtko Ursulin Cc: Dnyaneshwar Bhadane Cc: Anusha Srivatsa Cc: Radhakrishna Sripada --- drivers/gpu/drm/i915/i915_drv.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drive

[PATCH v2] drm/mediatek: Add spinlock for setting vblank event in atomic_begin

2023-09-20 Thread Jason-JH . Lin
Add spinlock protection to avoid race condition on vblank event between mtk_drm_crtc_atomic_begin() and mtk_drm_finish_page_flip(). Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Jason-JH.Lin Suggested-by: AngeloGioacchino Del Regno Reviewed-by: Ale

Re: [Intel-gfx] [PATCH] drm/i915: Zap some empty lines

2023-09-20 Thread Jani Nikula
On Wed, 20 Sep 2023, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin > Cc: Dnyaneshwar Bhadane > Cc: Anusha Srivatsa > Cc: Radhakrishna Sripada One of the harder patches I've reviewed t

Re: [PATCH v2] drm/mediatek: Add spinlock for setting vblank event in atomic_begin

2023-09-20 Thread AngeloGioacchino Del Regno
Il 20/09/23 11:06, Jason-JH.Lin ha scritto: Add spinlock protection to avoid race condition on vblank event between mtk_drm_crtc_atomic_begin() and mtk_drm_finish_page_flip(). Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Jason-JH.Lin Suggested-by:

RE: [PATCH v2] drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR

2023-09-20 Thread Ying Liu
On Wednesday, September 20, 2023 4:27 PM AngeloGioacchino Del Regno wrote: > When external bridges are attached with > DRM_BRIDGE_ATTACH_NO_CONNECTOR, > the panel bridge may also get the same flag, but in the .attach() > callback for the panel bridge a device link is added only when this > flag i

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-09-20 Thread Hans de Goede
Hi, On 9/19/23 19:46, Julius Zint wrote: > > > On Wed, 6 Sep 2023, Hans de Goede wrote: > >> Hi Julius, >> >> On 9/4/23 21:02, Julius Zint wrote: >>> >>> >>> On Mon, 4 Sep 2023, Thomas Weißschuh wrote: >>> +Cc Hans who ins involved with the backlight subsystem Hi Julius, >>>

Re: (subset) [PATCH 01/31] dt-bindings: mfd: syscon: Add rockchip,rk3128-qos compatible

2023-09-20 Thread Lee Jones
On Tue, 29 Aug 2023 19:16:17 +0200, Alex Bee wrote: > Document Rockchip RK3128 SoC compatible for qos registers. > > Applied, thanks! [01/31] dt-bindings: mfd: syscon: Add rockchip,rk3128-qos compatible commit: 4c57b25b09932acf81ead78bd32019fc5d0ea913 -- Lee Jones [李琼斯]

[PATCH 3/5] drm: lcdif: remove superfluous setup of framebuffer DMA address

2023-09-20 Thread Lucas Stach
Now that the plane state is fully programmed into the hardware before the scanout is started there is no need to program the plane framebuffer DMA address from the CRTC atomic_enable anymore. Signed-off-by: Lucas Stach --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 10 -- 1 file changed, 10 del

[PATCH 5/5] drm: lcdif: force modeset when FB format changes

2023-09-20 Thread Lucas Stach
Force a modeset if the new FB has a different format than the currently active one. While it might be possible to change between compatible formats without a full modeset as the format control is also supposed to be double buffered, the colorspace conversion is not, so when the CSC changes we need

[PATCH 2/5] drm: lcdif: move controller enable into atomic_flush

2023-09-20 Thread Lucas Stach
Allow drm_atomic_helper_commit_tail_rpm to setup all the plane state before the scanout is started. Signed-off-by: Lucas Stach --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb

[PATCH 4/5] drm: lcdif: move pitch setup to plane atomic update

2023-09-20 Thread Lucas Stach
The buffer pitch may change when switching the buffer on a atomic update. As the register is double buffered it can be safely changed while the display is active. Signed-off-by: Lucas Stach --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 26 +- 1 file changed, 13 insertions(+), 1

[PATCH 0/5] imx-lcdif modeset changes

2023-09-20 Thread Lucas Stach
This changes the modeset flow in the imx-lcdif driver to work better with runtime PM and get rid of duplicate hardware setup. This series is a result of looking a bit more into the issue and feedback received on some earlier patches [1]. Regards, Lucas [1] https://lore.kernel.org/all/caockunwmu

[PATCH 1/5] drm: lcdif: improve burst size configuration comment

2023-09-20 Thread Lucas Stach
The comment regarding AXI bust size configuration is a bit hard to read. Improve the wording somewhat. Signed-off-by: Lucas Stach --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm

RE: [PATCH] drm/i915: Zap some empty lines

2023-09-20 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Tvrtko > Ursulin > Sent: Wednesday, September 20, 2023 2:27 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Bhadane, Dnyaneshwar > ; Sripada, Radhakrishna > ; Ursulin, Tvrtko > Subjec

Patch "drm/tests: helpers: Avoid a driver uaf" has been added to the 6.5-stable tree

2023-09-20 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/tests: helpers: Avoid a driver uaf to the 6.5-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: drm-tests-helper

Re: Decrypting tt maps in ttm

2023-09-20 Thread Christian König
Am 20.09.23 um 09:36 schrieb Thomas Hellström: Hi, Zack, On 9/20/23 05:43, Zack Rusin wrote: On Tue, 2023-09-19 at 09:47 +0200, Christian König wrote: !! External Email Am 19.09.23 um 08:56 schrieb Thomas Hellström: On 9/19/23 07:39, Christian König wrote: Am 19.09.23 um 03:26 schrieb Za

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Christian König
Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21, Thomas Hellström wrote: Hi Christian On 9/19/23 14:07, Christian König wrote: Am 13.09.23

Re: [PATCH 1/5] drm: lcdif: improve burst size configuration comment

2023-09-20 Thread Marco Felsch
On 23-09-20, Lucas Stach wrote: > The comment regarding AXI bust size configuration is a bit hard > to read. Improve the wording somewhat. > > Signed-off-by: Lucas Stach Reviewed-by: Marco Felsch

Re: [PATCH] dt-bindings: display: anx7814: Add definition for anx7816

2023-09-20 Thread Robert Foss
On Mon, 18 Sep 2023 23:49:44 +0200, Alicja Michalska wrote: > As requested by Robert Foss , this patch adds > definition for anx7816. It supplements the patch submitted to dri-devel. > > Applied, thanks! [1/1] dt-bindings: display: anx7814: Add definition for anx7816 https://cgit.freedesk

Re: [PATCH] drm/bridge/analogix/anx78xx: Add missing definition

2023-09-20 Thread Robert Foss
On Sat, 9 Sep 2023 04:37:53 +0200, Alicja Michalska wrote: > Analogix ANX78XX driver is missing definitions for anx7816. > It uses the same I2C register set as anx7818. > > Applied, thanks! [1/1] drm/bridge/analogix/anx78xx: Add missing definition https://cgit.freedesktop.org/drm/drm-misc

[PATCH] drm/i915: Remove unnecessary memory quiescing for aux inval

2023-09-20 Thread Nirmoy Das
i915 already does memory quiesce before signaling breadcrumb so remove extra memory quiescing for aux invalidation which can cause unnecessary side effects. Fixes: 78a6ccd65fa3 ("drm/i915/gt: Ensure memory quiesced before invalidation") Cc: Jonathan Cavitt Cc: Andi Shyti Cc: # v5.8+ Cc: Andrzej

Re: [PATCH] drm/i915: Fix aux invalidation with proper pipe_control flag

2023-09-20 Thread Nirmoy Das
Sent out https://patchwork.freedesktop.org/series/123975/ to replace this one as this not really fixing the issue. Thanks, Nirmoy On 9/19/2023 2:19 PM, Tapani Pälli wrote: On 19.9.2023 15.11, Andi Shyti wrote: Hi Nirmoy, On Tue, Sep 19, 2023 at 01:47:16PM +0200, Nirmoy Das wrote: The sug

[PATCH 0/8] drm: Reuse temporary memory for format conversion

2023-09-20 Thread Thomas Zimmermann
DRM's format-conversion helpers require temporary memory. Pass the buffer from the caller and keep it allocated over several calls. Allow the caller to preallocate the buffer memory. The motivation for this patchset is the recent work on a DRM panic handler. The panic handler requires format conve

[PATCH 1/8] drm/format-helper: Add struct drm_xfrm_buf to cache format conversion

2023-09-20 Thread Thomas Zimmermann
Hold temporary memory for format conversion in an instance of struct drm_xfrm_buf. Update internal helpers of DRM's format-conversion code accordingly. Drivers will later be able to keep this cache across display updates. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c |

[PATCH 4/8] drm/simpledrm: Preallocate xfrm buffer in plane's atomic_check

2023-09-20 Thread Thomas Zimmermann
Preallocate the xfrm buffer's storage in the plane's atomic_check function if a format conversion will be necessary. Allows the update to fail if no memory is available. Avoids the same allocation within atomic_update, which may not fail. Also inline drm_plane_helper_atomic_check() into the driver

[PATCH 3/8] drm/simpledrm: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct simpledrm_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Unloading the DRM device also releases the xfrm buffer. Signed-off-by: Thomas Zimmermann --- d

[PATCH 2/8] drm/format-helper: Pass xfrm buffer to format-conversion helpers

2023-09-20 Thread Thomas Zimmermann
Pass an instance of struct drm_xfrm_buf to DRM's format conversion helpers. Update all callers. Drivers will later be able to keep this cache across display updates. Signed-off-by: Thomas Zimmermann Cc: Noralf Trønnes Cc: Javier Martinez Canillas Cc: Gerd Hoffmann Cc: David Lechner --- drive

[PATCH 8/8] drm/ssd130x: Preallocate xfrm buffer in plane's atomic_check

2023-09-20 Thread Thomas Zimmermann
Preallocate the xfrm buffer's storage in the plane's atomic_check function if a format conversion will be necessary. Allows the update to fail if no memory is available. Avoids the same allocation within atomic_update, which may not fail. Also inline drm_plane_helper_atomic_check() into the driver

[PATCH 5/8] drm/ofdrm: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct ofdrm_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Unloading the DRM device also releases the xfrm buffer. Signed-off-by: Thomas Zimmermann --- drive

[PATCH 7/8] drm/ssd130x: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct ssd130x_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Unloading the DRM device also releases the xfrm buffer. Signed-off-by: Thomas Zimmermann --- dri

[PATCH 6/8] drm/ofdrm: Preallocate xfrm buffer in plane's atomic_check

2023-09-20 Thread Thomas Zimmermann
Preallocate the xfrm buffer's storage in the plane's atomic_check function if a format conversion will be necessary. Allows the update to fail if no memory is available. Avoids the same allocation within atomic_update, which may not fail. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny

Re: [PATCH 8/8] drm/ssd130x: Preallocate xfrm buffer in plane's atomic_check

2023-09-20 Thread Thomas Zimmermann
Am 20.09.23 um 13:10 schrieb Thomas Zimmermann: [...] if (!fi) @@ -619,6 +629,15 @@ static int ssd130x_primary_plane_helper_atomic_check(struct drm_plane *plane, pitch = drm_format_info_min_pitch(fi, 0, ssd130x->width); + if (new_plane_state->fb->format != fi) { +

Re: [PATCH 2/8] drm/format-helper: Pass xfrm buffer to format-conversion helpers

2023-09-20 Thread Jani Nikula
On Wed, 20 Sep 2023, Thomas Zimmermann wrote: > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c > b/drivers/gpu/drm/tests/drm_format_helper_test.c > index 1a6bd291345de..c6deabb6c64e5 100644 > --- a/drivers/gpu/drm/tests/drm_format_helper_test.c > +++ b/drivers/gpu/drm/tests/drm_forma

[PATCH 6.5 205/211] drm/tests: helpers: Avoid a driver uaf

2023-09-20 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Hellström commit 139a27854bf5ce93ff9805f9f7683b88c13074dc upstream. when using __drm_kunit_helper_alloc_drm_device() the driver may be dereferenced by device-managed resources up until t

Re: [Intel-gfx] [PATCH] drm/i915: Do not disable preemption for resets

2023-09-20 Thread Tvrtko Ursulin
On 13/09/2023 18:04, Valentin Schneider wrote: On Wed, 13 Sept 2023 at 18:48, Sebastian Andrzej Siewior wrote: On 2023-07-05 10:30:25 [+0100], Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit ade8a0f59844 ("drm/i915: Make all GPU resets atomic") added a preempt disable section over the h

Re: [PATCH v4 00/12] drm/bridge: tc358768: Fixes and timings improvements

2023-09-20 Thread Robert Foss
On Wed, 06 Sep 2023 09:50:47 +0300, Tomi Valkeinen wrote: > This series contains various fixes and cleanups for TC358768. The target > of this work is to get TC358768 working on Toradex's AM62 based board, > which has the following display pipeline: > > AM62 DPI -> TC358768 -> LT8912B -> HDMI conn

[PATCH 4.14 123/186] drm/ast: Fix DRAM init on AST2200

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 4cfe75f0f14f044dae66ad0e6eea812d038465d9 upstream. Fix the test for the AST2200 in the DRAM initialization. The value in ast->chip has to be compared against an enum c

[PATCH 4.14 105/186] backlight/gpio_backlight: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 7b91d017f77c1bda56f27c2f4bbb70de7c6eca08 upstream. Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_

[PATCH 4.14 106/186] backlight/bd6107: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 992bdddaabfba19bdc77c1c7a4977b2aa41ec891 upstream. Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backli

[PATCH 4.14 107/186] backlight/lv5207lp: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 1ca8819320fd84e7d95b04e7668efc5f9fe9fa5c upstream. Struct lv5207lp_platform_data refers to a platform device within the Linux device hierarchy. The test in lv5207lp_ba

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Thomas Hellström
On 9/20/23 12:51, Christian König wrote: Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21, Thomas Hellström wrote: Hi Christian On 9/19/23

[PATCH 4.19 176/273] backlight/bd6107: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 992bdddaabfba19bdc77c1c7a4977b2aa41ec891 upstream. Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backli

[PATCH 4.19 175/273] backlight/gpio_backlight: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 7b91d017f77c1bda56f27c2f4bbb70de7c6eca08 upstream. Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_

[PATCH 4.19 177/273] backlight/lv5207lp: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 1ca8819320fd84e7d95b04e7668efc5f9fe9fa5c upstream. Struct lv5207lp_platform_data refers to a platform device within the Linux device hierarchy. The test in lv5207lp_ba

[PATCH 4.19 200/273] drm/ast: Fix DRAM init on AST2200

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 4cfe75f0f14f044dae66ad0e6eea812d038465d9 upstream. Fix the test for the AST2200 in the DRAM initialization. The value in ast->chip has to be compared against an enum c

[PATCH v3 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-20 Thread Philipp Stanner
Currently, user array duplications are sometimes done without an overflow check. Sometimes the checks are done manually; sometimes the array size is calculated with array_size() and sometimes by calculating n * size directly in code. Introduce wrappers for arrays for memdup_user() and vmemdup_user

[PATCH v3 0/5] Introduce new wrappers to copy user-arrays

2023-09-20 Thread Philipp Stanner
Hi! David Airlie suggested that we could implement new wrappers around (v)memdup_user() for duplicating user arrays. This small patch series first implements the two new wrapper functions memdup_array_user() and vmemdup_array_user(). They calculate the array-sizes safely, i.e., they return an err

Re: [PATCH] drm/i915: Remove unnecessary memory quiescing for aux inval

2023-09-20 Thread Tapani Pälli
I tested this first against tests that were failing for Mesa and it fixes all of the regressed cases (TGL LP). Also did a full run of all KHR-GLES31* and KHR-GLES32* test groups in the Khronos CTS suite, no regressions observed. Tested-by: Tapani Pälli On 20.9.2023 14.11, Nirmoy Das wrote:

[PATCH v3 2/5] kernel: kexec: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Acked-by: Baoquan He Reviewed-by: Kees Cook Reviewed-by: Zack Rusi

[PATCH v3 3/5] kernel: watch_queue: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin --- kernel/watch_q

[PATCH v3 4/5] drm_lease.c: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin --- drivers/gpu/dr

[PATCH 5.4 214/367] backlight/gpio_backlight: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 7b91d017f77c1bda56f27c2f4bbb70de7c6eca08 upstream. Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_b

[PATCH v3 5/5] drm: vmgfx_surface.c: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin --- drivers/gpu/dr

[PATCH 5.4 216/367] backlight/lv5207lp: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 1ca8819320fd84e7d95b04e7668efc5f9fe9fa5c upstream. Struct lv5207lp_platform_data refers to a platform device within the Linux device hierarchy. The test in lv5207lp_bac

[PATCH 5.4 215/367] backlight/bd6107: Compare against struct fb_info.device

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 992bdddaabfba19bdc77c1c7a4977b2aa41ec891 upstream. Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlig

[PATCH 5.4 245/367] drm/ast: Fix DRAM init on AST2200

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 4cfe75f0f14f044dae66ad0e6eea812d038465d9 upstream. Fix the test for the AST2200 in the DRAM initialization. The value in ast->chip has to be compared against an enum co

Re: PROBLEM: MT8192 panel_edp_probe trace due to Unknown panel CMN 0x142b

2023-09-20 Thread Leonard Lausen
> Hello Leonard, > thanks for sending me this snippet. > > This is not in any way connected to my eDP/aux-bus patch series, infact this > warning happens because your machine has got a new/different panel, read > below: > > if (WARN_ON(!panel->detected_panel)) { >     dev_warn(dev, >    

[PATCH 1/2] Revert "drm/tidss: Annotate dma-fence critical section in commit path"

2023-09-20 Thread Tomi Valkeinen
This reverts commit 4d56a4f08391857ba93465de489707b66adad114. The DMA-fence annotations cause a lockdep warning (see below). As per https://patchwork.freedesktop.org/patch/462170/ it sounds like the annotations don't work correctly. == WARNING:

[PATCH 0/2] drm: Revert dma-fence annotations from omapdrm and tidss

2023-09-20 Thread Tomi Valkeinen
_drv.c | 9 - drivers/gpu/drm/tidss/tidss_kms.c | 4 2 files changed, 4 insertions(+), 9 deletions(-) --- base-commit: 9fc75c40faa29df14ba16066be6bdfaea9f39ce4 change-id: 20230920-dma-fence-annotation-revert-166d0efab368 Best regards, -- Tomi Valkeinen

[PATCH 2/2] Revert "drm/omapdrm: Annotate dma-fence critical section in commit path"

2023-09-20 Thread Tomi Valkeinen
This reverts commit 250aa22920cd5d956a5d3e9c6a43d671c2bae217. The DMA-fence annotations cause a lockdep warning (see below). As per https://patchwork.freedesktop.org/patch/462170/ it sounds like the annotations don't work correctly. == WARNING:

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Christian König
Am 20.09.23 um 14:06 schrieb Thomas Hellström: On 9/20/23 12:51, Christian König wrote: Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21,

Re: [PATCH v2] drm: Update file owner during use

2023-09-20 Thread Tvrtko Ursulin
On 28/08/2023 20:58, Rob Clark wrote: On Wed, Jun 21, 2023 at 2:48 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server opens the file descriptor and then hands it over to the client(*), we were showing stale data in debugfs. Fix it by updating the

Re: [PATCH v2] drm: Update file owner during use

2023-09-20 Thread Christian König
Am 20.09.23 um 15:21 schrieb Tvrtko Ursulin: On 28/08/2023 20:58, Rob Clark wrote: On Wed, Jun 21, 2023 at 2:48 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server opens the file descriptor and then hands it over to the client(*), we were showing

Re: [PATCH] gpu: drm: amd: display: fix kernel-doc warnings

2023-09-20 Thread Alex Deucher
Applied. Thanks! On Tue, Sep 19, 2023 at 5:54 PM Randy Dunlap wrote: > > Hi, > > On 9/19/23 02:33, Swarup Laxman Kotiaklapudi wrote: > > Fix kernel-doc warnings discovered in AMD gpu display driver. > > Fixes these warnings: > > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:110: warning: > > Fun

Re: (subset) [PATCH v5 1/8] mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller

2023-09-20 Thread Lee Jones
On Fri, 15 Sep 2023 16:18:42 +0530, Manikandan Muralidharan wrote: > Add compatible for sam9x75 XLCD controller. > > Applied, thanks! [1/8] mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller commit: c743c12c79ff716e081095c5a2ba360e42b39d78 -- Lee Jones [李琼斯]

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Thomas Hellström
On 9/20/23 15:06, Christian König wrote: Am 20.09.23 um 14:06 schrieb Thomas Hellström: On 9/20/23 12:51, Christian König wrote: Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16,

Re: [PATCH v2 14/15] dt-bindings: gpu: mali-valhall-csf: Add initial bindings for panthor driver

2023-09-20 Thread Liviu Dudau
Hi Krzysztof, Thanks for taking the time to review this patch. I'm about to update it to address your comments and I need some clarifications from you. On Sun, Aug 20, 2023 at 10:01:25AM +0200, Krzysztof Kozlowski wrote: > On 09/08/2023 18:53, Boris Brezillon wrote: > > From: Liviu Dudau > > >

Re: [PATCH] drm/meson: fix memory leak on ->hpd_notify callback

2023-09-20 Thread Neil Armstrong
Hi, On Thu, 14 Sep 2023 16:10:15 +0300, Jani Nikula wrote: > The EDID returned by drm_bridge_get_edid() needs to be freed. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes) [1/1] drm/meson: fix memory leak on ->hpd_notify callback https://cgit

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Christian König
Am 20.09.23 um 15:38 schrieb Thomas Hellström: On 9/20/23 15:06, Christian König wrote: Am 20.09.23 um 14:06 schrieb Thomas Hellström: On 9/20/23 12:51, Christian König wrote: Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:37, Christian König wrote: Am 19.09.23 um 17:2

Re: [PATCH v2 14/15] dt-bindings: gpu: mali-valhall-csf: Add initial bindings for panthor driver

2023-09-20 Thread Krzysztof Kozlowski
On 20/09/2023 15:41, Liviu Dudau wrote: >>> +properties: >>> + $nodename: >>> +pattern: '^gpu@[a-f0-9]+$' >>> + >>> + compatible: >>> +oneOf: >> >> Drop oneOf. > > The idea was to allow for future compatible strings to be added later, but > I guess we can re-introduce the oneOf entry lat

Re: [PATCH v2 14/15] dt-bindings: gpu: mali-valhall-csf: Add initial bindings for panthor driver

2023-09-20 Thread Boris Brezillon
On Wed, 20 Sep 2023 14:41:05 +0100 Liviu Dudau wrote: > > > > Please describe also power domains - constrains and names. > > I'm not sure the power domains and how to handle them have been > entirely settled for Rockchip, hence why they were not included. Will > check with Collabora to see if

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Thomas Hellström
Hi On 9/20/23 15:48, Christian König wrote: Am 20.09.23 um 15:38 schrieb Thomas Hellström: On 9/20/23 15:06, Christian König wrote: Am 20.09.23 um 14:06 schrieb Thomas Hellström: On 9/20/23 12:51, Christian König wrote: Am 20.09.23 um 09:44 schrieb Thomas Hellström: Hi, On 9/20/23 07:3

Re: [PATCH v2 14/15] dt-bindings: gpu: mali-valhall-csf: Add initial bindings for panthor driver

2023-09-20 Thread Liviu Dudau
On Wed, Sep 20, 2023 at 03:56:24PM +0200, Boris Brezillon wrote: > On Wed, 20 Sep 2023 14:41:05 +0100 > Liviu Dudau wrote: > > > > > > > Please describe also power domains - constrains and names. > > > > I'm not sure the power domains and how to handle them have been > > entirely settled for

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-20 Thread Christian König
Am 20.09.23 um 16:02 schrieb Thomas Hellström: [SNIP] Do you by "relocation" list refer to what gpuvm calls "evict" list or something else? Like the relocaton/validation list that used to be sent from user-space for non-VM_BIND vms? The BOs send into the kernel with each command submission on

[PATCH v2 0/5] drm: Reuse temporary memory for format conversion

2023-09-20 Thread Thomas Zimmermann
DRM's format-conversion helpers require temporary memory. Pass the buffer from the caller and keep it allocated over several calls. Allow the caller to preallocate the buffer memory. The motivation for this patchset is the recent work on a DRM panic handler. The panic handler requires format conve

[PATCH v2 1/5] drm/format-helper: Add struct drm_xfrm_buf to cache format conversion

2023-09-20 Thread Thomas Zimmermann
Hold temporary memory for format conversion in an instance of struct drm_xfrm_buf. Update internal helpers of DRM's format-conversion code accordingly. Drivers will later be able to keep this cache across display updates. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c |

[PATCH v2 4/5] drm/ofdrm: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct ofdrm_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Instead preallocate temporary memory during initialization. Releasing the DRM device also releases th

[PATCH v2 3/5] drm/simpledrm: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct simpledrm_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Instead preallocate temporary memory during initialization. Releasing the DRM device also release

[PATCH v2 2/5] drm/format-helper: Pass xfrm buffer to format-conversion helpers

2023-09-20 Thread Thomas Zimmermann
Pass an instance of struct drm_xfrm_buf to DRM's format conversion helpers. Update all callers. Drivers will later be able to keep this cache across display updates. Signed-off-by: Thomas Zimmermann Cc: Noralf Trønnes Cc: Javier Martinez Canillas Cc: Gerd Hoffmann Cc: David Lechner --- drive

Re: [PATCH v2 14/15] dt-bindings: gpu: mali-valhall-csf: Add initial bindings for panthor driver

2023-09-20 Thread Liviu Dudau
On Wed, Sep 20, 2023 at 03:51:36PM +0200, Krzysztof Kozlowski wrote: > On 20/09/2023 15:41, Liviu Dudau wrote: > >>> +properties: > >>> + $nodename: > >>> +pattern: '^gpu@[a-f0-9]+$' > >>> + > >>> + compatible: > >>> +oneOf: > >> > >> Drop oneOf. > > > > The idea was to allow for future

[PATCH v2 5/5] drm/ssd130x: Store xfrm buffer in device instance

2023-09-20 Thread Thomas Zimmermann
Store and instance of struct drm_xfrm_buf in struct ssd130x_device and keep the allocated memory allocated across display updates. Avoid possibly reallocating temporary memory on each display update. Instead preallocate temporary memory during initialization. Releasing the DRM device also releases

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-09-20 Thread Tvrtko Ursulin
On 24/08/2023 12:35, Upadhyay, Tejas wrote: -Original Message- From: Intel-gfx On Behalf Of Tvrtko Ursulin Sent: Friday, July 7, 2023 6:32 PM To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats pr

[PATCH RFC v2 00/37] drm/connector: Create HDMI Connector infrastructure

2023-09-20 Thread Maxime Ripard
Hi, Here's a series that creates a subclass of drm_connector specifically targeted at HDMI controllers. The idea behind this series came from a recent discussion on IRC during which we discussed infoframes generation of i915 vs everything else. Infoframes generation code still requires some dec

  1   2   3   >