Fwd: Kernel 6.6-rc1 fails to reboot or shutdown Ryzen 5825U

2023-09-14 Thread Bagas Sanjaya
Hi, I notice a regression report on Bugzilla [1]. Quoting from it: > The Kernel stalls at boot very long with a drm-amdgpu message, but fails to > restart or shutdown with secure boot enabled or not. Magic key works to exit. > Nothing wrong in the Kernel 6.5 cycle. Later, the reporter (Cc'ed)

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 07:02:52 +0300 Dmitry Osipenko wrote: > On 9/13/23 10:48, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 03:56:14 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/5/23 11:03, Boris Brezillon wrote: > * But > + * acquiring the obj lo

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023 07:02:52 +0300 > Dmitry Osipenko wrote: > >> On 9/13/23 10:48, Boris Brezillon wrote: >>> On Wed, 13 Sep 2023 03:56:14 +0300 >>> Dmitry Osipenko wrote: >>> On 9/5/23 11:03, Boris Brezillon wrote: >>* But

Re: drm/vkms: deadlock between dev->event_lock and timer

2023-09-14 Thread Daniel Vetter
On Thu, Sep 14, 2023 at 03:33:41PM +0900, Tetsuo Handa wrote: > On 2023/09/14 6:08, Thomas Gleixner wrote: > > Maybe the VKMS people need to understand locking in the first place. The > > first thing I saw in this code is: > > > > static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *ti

Re: [RFT PATCH 03/15] drm/ingenic: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 09:23:29AM -0700, Doug Anderson wrote: > On Wed, Sep 6, 2023 at 1:39 AM Maxime Ripard wrote: > > On Tue, Sep 05, 2023 at 01:16:08PM -0700, Doug Anderson wrote: > > > > > This commit is only compile-time tested. > > > > > > > > > > NOTE: this patch touches a lot more th

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Boris Brezillon
On Wed, 13 Sep 2023 15:22:56 +0200 Thomas Hellström wrote: > On 9/13/23 13:33, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 12:39:01 +0200 > > Thomas Hellström wrote: > > > >> Hi, > >> > >> On 9/13/23 09:19, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 17:05:42 +1000 > >>> Dave Airlie

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 10:50:32 +0300 Dmitry Osipenko wrote: > On 9/14/23 10:36, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 07:02:52 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/13/23 10:48, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 03:56:14 +0300 > >>> Dmitry Osipenko wrote: > >

[PATCH v4 0/7] drm: ci: fixes

2023-09-14 Thread Vignesh Raman
The patch series contains improvements, enabling new ci jobs which enables testing for Mediatek MT8173, Qualcomm APQ 8016 and VirtIO GPU, fixing issues with the ci jobs and updating the expectation files. This series is intended for drm branch drm-next. v2: - Use fdtoverlay command to merge over

[PATCH v4 1/7] drm: ci: igt_runner: Remove todo

2023-09-14 Thread Vignesh Raman
/sys/kernel/debug/dri/*/state exist for every atomic KMS driver. We do not test non-atomic drivers, so remove the todo. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - No changes v4: - No changes --- drivers/gpu/drm/ci/igt_runner.sh | 1 - 1 file change

[PATCH v4 2/7] drm: ci: Force db410c to host mode

2023-09-14 Thread Vignesh Raman
Force db410c to host mode to fix network issue which results in failure to mount root fs via NFS. See https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/cb72a629b8c15c80a54dda510743cefd1c4b65b8 Use apq8016-sbc-usb-host.dtb which allows the USB controllers to work in host mode. Acked-by: Helen

[PATCH v4 3/7] drm: ci: virtio: Update ci variables

2023-09-14 Thread Vignesh Raman
Update ci variables to fix the below error, ERROR - Igt error: malloc(): corrupted top size ERROR - Igt error: Received signal SIGABRT. ERROR - Igt error: Stack trace: ERROR - Igt error: #0 [fatal_sig_handler+0x17b] Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3:

[PATCH v4 4/7] drm: ci: Enable regulator

2023-09-14 Thread Vignesh Raman
Enable CONFIG_REGULATOR_DA9211=y to fix mt8173 boot issue. Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - No changes v3: - Remove CONFIG_RTC_DRV_MT6397=y as it is already enabled in defconfig v4: - No changes --- drivers/gpu/drm/ci/arm64.config | 1 + 1 file changed, 1 i

[PATCH v4 5/7] drm: ci: Update xfails

2023-09-14 Thread Vignesh Raman
Update amdgpu-stoney-fails, mediatek-mt8173-flakes, mediatek-mt8173-fails, rockchip-rk3399-fails, rockchip-rk3399-flakes, rockchip-rk3288-flakes, i915-cml-fails, i915-cml-flakes, msm-apq8016-flakes files. Add tests that fail sometimes into the *-flakes file and tests that are failing into the *-fa

[PATCH v4 6/7] drm: ci: Enable new jobs

2023-09-14 Thread Vignesh Raman
Enable the following jobs, as the issues noted in the TODO comments have been resolved. This will ensure that these jobs are now included and executed as part of the CI/CD pipeline. msm:apq8016: TODO: current issue: it is not fiding the NFS root. Fix and remove this rule. mediatek:mt8173: TODO: c

[PATCH v4 7/7] drm: ci: Use scripts/config to enable/disable configs

2023-09-14 Thread Vignesh Raman
Instead of modifying files in git to enable/disable configs, use scripts/config on the .config file which will be used for building the kernel. Suggested-by: Jani Nikula Acked-by: Helen Koike Signed-off-by: Vignesh Raman --- v2: - Added a new patch in the series to use scripts/config to enab

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Heikki Krogerus
Hi Dmitry, On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > wrote: > > > > On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: > > > Hi Heikki, > > > > > > On Wed, 13 Sept 2023 at 12:27, Heikki Krogerus > > > wrote

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Neil Armstrong
On 14/09/2023 11:26, Heikki Krogerus wrote: Hi Dmitry, On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus wrote: On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: Hi Heikki, On Wed, 13 Sept 2023 at 12:27, Heikki

[PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Cong Liu
This patch fixes a memory leak in the amdgpu_ras_feature_enable() function. The leak occurs when the function sends a command to the firmware to enable or disable a RAS feature for a GFX block. If the command fails, the kfree() function is not called to free the info memory. Fixes: bf7aa8bea9cb ("

RE: [PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Cong Liu Sent: Thursday, September 14, 2023 17:46 To: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Yang, Stanley ; Zhang, Hawking Cc: Cong

Re: [PATCH v11] drm: Add initial ci/ subdirectory

2023-09-14 Thread Maxime Ripard
Hi, On Tue, Sep 12, 2023 at 02:16:41PM +0100, Daniel Stone wrote: > Hopefully less mangled formatting this time: turns out Thunderbird + > plain text is utterly unreadable, so that's one less MUA that is > actually usable to send email to kernel lists without getting shouted > at. Sorry if it fel

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Dmitry Baryshkov
On Thu, 14 Sept 2023 at 12:35, Neil Armstrong wrote: > > On 14/09/2023 11:26, Heikki Krogerus wrote: > > Hi Dmitry, > > > > On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > >> On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > >> wrote: > >>> > >>> On Wed, Sep 13, 2023 at 01:26:1

Re: [PATCH 6/9] dma-buf: heaps: mtk_sec_heap: Add tee service call for buffer allocating/freeing

2023-09-14 Thread kernel test robot
Hi Yong, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on robh/for-next linus/master v6.6-rc1 next-20230914] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v10 11/16] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-09-14 Thread AngeloGioacchino Del Regno
indings are matching the current devicetree node in mt8195.dtsi, and the node has compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-disp-gamma"; so, no devicetree and/or bindings modification is needed. https://git.kernel.org/pub/scm/linux/ke

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Dmitry Baryshkov
On Thu, 14 Sept 2023 at 12:26, Heikki Krogerus wrote: > > Hi Dmitry, > > On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > > On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > > wrote: > > > > > > On Wed, Sep 13, 2023 at 01:26:14PM +0300, Dmitry Baryshkov wrote: > > > > Hi Heikki,

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On 9/14/23 10:20, Boris Brezillon wrote: On Wed, 13 Sep 2023 15:22:56 +0200 Thomas Hellström wrote: On 9/13/23 13:33, Boris Brezillon wrote: On Wed, 13 Sep 2023 12:39:01 +0200 Thomas Hellström wrote: Hi, On 9/13/23 09:19, Boris Brezillon wrote: On Wed, 13 Sep 2023 17:05:42 +1000 Dave

[PATCH] Revert "drm/vkms: Fix race-condition between the hrtimer and the atomic commit"

2023-09-14 Thread Maíra Canal
This reverts commit a0e6a017ab56936c0405fe914a793b241ed25ee0. Unlocking a mutex in the context of a hrtimer callback is violating mutex locking rules, as mutex_unlock() from interrupt context is not permitted. Links: https://lore.kernel.org/dri-devel/ZQLAc%2FFwkv%2FGiVoK@phenom.ffwll.local/T/#t

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma-resv locks, neat! However, what if two tasks are trying to lock the VA space concurrently? What do we do when the drm_gpuvm_bo's refcount drops to zero in drm_gpuva_unlink()? Are we guaranteed th

[PATCH] drm/edid: Fixup h/vsync_end instead of h/vtotal

2023-09-14 Thread Ville Syrjala
From: Ville Syrjälä There are some weird EDIDs floating around that have the sync pulse extending beyond the end of the blanking period. On the currently problemtic machine (HP Omni 120) EDID reports the following mode: "1600x900": 60 108000 1600 1780 1860 1800 900 910 913 1000 0x40 0x5 which is

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On 9/14/23 12:57, Danilo Krummrich wrote: On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma-resv locks, neat! However, what if two tasks are trying to lock the VA space concurrently? What do we do when the drm_gpuvm_bo's refcount drops to zer

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 11:27, Boris Brezillon wrote: > On Thu, 14 Sep 2023 10:50:32 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 10:36, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 07:02:52 +0300 >>> Dmitry Osipenko wrote: >>> On 9/13/23 10:48, Boris Brezillon wrote: > On Wed, 13 Sep 2023

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 12:45:44 +0200 Thomas Hellström wrote: > On 9/14/23 10:20, Boris Brezillon wrote: > > On Wed, 13 Sep 2023 15:22:56 +0200 > > Thomas Hellström wrote: > > > >> On 9/13/23 13:33, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 12:39:01 +0200 > >>> Thomas Hellström wrote: >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 14:36:23 +0300 Dmitry Osipenko wrote: > On 9/14/23 11:27, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 10:50:32 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/14/23 10:36, Boris Brezillon wrote: > >>> On Thu, 14 Sep 2023 07:02:52 +0300 > >>> Dmitry Osipenko wrote: > >

Re: (subset) [PATCH v3 1/2] drm/tests: helpers: Avoid a driver uaf

2023-09-14 Thread Maxime Ripard
On Thu, 07 Sep 2023 15:53:38 +0200, Thomas Hellström wrote: > when using __drm_kunit_helper_alloc_drm_device() the driver may be > dereferenced by device-managed resources up until the device is > freed, which is typically later than the kunit-managed resource code > frees it. Fix this by simply ma

Re: [PATCH] drm/tests: provide exit function

2023-09-14 Thread Maxime Ripard
On Wed, Sep 13, 2023 at 07:35:57PM +0300, José Pekkarinen wrote: > On 2023-09-13 17:41, mrip...@kernel.org wrote: > > On Wed, Sep 13, 2023 at 05:01:40PM +0300, José Pekkarinen wrote: > > > On 2023-09-13 12:50, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Wed, Sep 13, 2023 at 11:32:23AM +0300

[PULL] drm-misc-fixes

2023-09-14 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2023-09-14: Short summary of fixes pull: * radeon: Uninterruptible fence waiting * tests: Fix use-after-free bug * vkms: Revert hrtimer fix The following changes since commit afaf2b38025ab327c85e

[PULL] drm-intel-fixes

2023-09-14 Thread Rodrigo Vivi
Hi Dave and Daniel, Only a fix for blank-screen regression on Chromebooks, targeting stable 6.5. Here goes drm-intel-fixes-2023-09-14: - Only check eDP HPD when AUX CH is shared. (Ville) Thanks, Rodrigo. The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux 6.6-r

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 14:58, Boris Brezillon wrote: > On Thu, 14 Sep 2023 14:36:23 +0300 > Dmitry Osipenko wrote: > >> On 9/14/23 11:27, Boris Brezillon wrote: >>> On Thu, 14 Sep 2023 10:50:32 +0300 >>> Dmitry Osipenko wrote: >>> On 9/14/23 10:36, Boris Brezillon wrote: > On Thu, 14 Sep 2023

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Maxime Ripard
Hi, On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: > static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { > .mode_valid = ssd130x_crtc_helper_mode_valid, > - .atomic_check = drm_crtc_helper_atomic_check, > + .atomic_check = ssd130x_crtc_

[PATCH] drm/meson: fix memory leak on ->hpd_notify callback

2023-09-14 Thread Jani Nikula
The EDID returned by drm_bridge_get_edid() needs to be freed. Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") Cc: Neil Armstrong Cc: Sam Ravnborg Cc: Martin Blumenstingl Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: dri-devel@list

[PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path

2023-09-14 Thread Jani Nikula
Setting new_edid to NULL leaks the buffer. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Cc: Markus Schneider-Pargmann Cc: Guillaume Ranquet Cc: Bo-Chen Chen Cc: CK Hu Cc: AngeloGioacchino Del Regno Cc: Dmitry Osipenko Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc:

[PATCH] drm: bridge: it66121: ->get_edid callback must not return err pointers

2023-09-14 Thread Jani Nikula
The drm stack does not expect error valued pointers for EDID anywhere. Fixes: e66856508746 ("drm: bridge: it66121: Set DDC preamble only once before reading EDID") Cc: Paul Cercueil Cc: Robert Foss Cc: Phong LE Cc: Neil Armstrong Cc: Andrzej Hajda Cc: Robert Foss Cc: Laurent Pinchart Cc: J

[PATCH] MAINTAINERS: add drm_bridge_connector.[ch] files under bridge chips

2023-09-14 Thread Jani Nikula
Clearly this should be under bridge chips. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Signed-off-by: Jani Nikula --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 354ac7ef553d..c331f2ea89d7 100644 --- a/MAINTAINERS +++ b/MAINTAINER

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: >> static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { >> .mode_valid = ssd130x_crtc_helper_mode_valid, >> -.atomic_check = drm_crtc_helper_atomic

Re: [PATCH 2/2] drm/tests: Flag slow tests as such

2023-09-14 Thread Maxime Ripard
Hi Sima, (For some reason, it looks like your mailer sets up the headers to reply to every recipient but you) On Tue, Sep 12, 2023 at 09:36:12AM +0200, Daniel Vetter wrote: > On Mon, Sep 11, 2023 at 11:51:06AM +0200, Maxime Ripard wrote: > > Kunit recently gained a speed attribute that allows to

[PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly

2023-09-14 Thread Jani Nikula
Make drm_bridge_get_edid() the one place to call the hook. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_bridge_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly

2023-09-14 Thread Jani Nikula
Make drm_bridge_get_edid() the one place to call the hook. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Jani Nikula --- UNTESTED --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 16:01:37 +0300 Dmitry Osipenko wrote: > On 9/14/23 14:58, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 14:36:23 +0300 > > Dmitry Osipenko wrote: > > > >> On 9/14/23 11:27, Boris Brezillon wrote: > >>> On Thu, 14 Sep 2023 10:50:32 +0300 > >>> Dmitry Osipenko wrote: > >

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 15:27:03 +0200 Boris Brezillon wrote: > You should drop the '&& refcount_read(&shmem->pages_use_count)', > otherwise you'll never enter this branch (sgt allocation retained > a ref, so pages_use_count > 0 when ->sgt != NULL). Sorry for the brain fart. You can drop this extra

Re: [PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback error path

2023-09-14 Thread Guillaume Ranquet
On Thu, 14 Sep 2023 15:10, Jani Nikula wrote: >Setting new_edid to NULL leaks the buffer. > >Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") >Cc: Markus Schneider-Pargmann >Cc: Guillaume Ranquet >Cc: Bo-Chen Chen >Cc: CK Hu >Cc: AngeloGioacchino Del Regno >Cc: Dmi

Re: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA

2023-09-14 Thread David Hildenbrand
I think it makes sense to have a generic (non-GUP) version of check_and_migrate_movable_pages() available in migration.h that drivers can use to ensure that they don't break memory hotunplug accidentally. Definately not. Either use the VMA and pin_user_pages(), or implement pin_user_pages_fd()

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
Hi, Danilo Some additional minor comments as xe conversion progresses. On 9/9/23 17:31, Danilo Krummrich wrote: So far the DRM GPUVA manager offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to their backing buffers and perform more compl

Re: [PATCH v16 15/20] drm/shmem-helper: Add memory shrinker

2023-09-14 Thread Dmitry Osipenko
On 9/14/23 16:27, Boris Brezillon wrote: ... > If you added this pages_use_count > 0 check to deal with the > 'free-partially-imported-GEM' case, I keep thinking this is not > the right fix. You should just assume that obj->import_attach == NULL > means not-a-prime-buffer, and then make sure > part

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Maxime Ripard
On Thu, Sep 14, 2023 at 03:23:53PM +0200, Javier Martinez Canillas wrote: > Maxime Ripard writes: > > Hello Maxime, > > > Hi, > > > > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: > >> static const struct drm_crtc_helper_funcs ssd130x_crtc_helper_funcs = { > >>.m

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
Hi, On 9/14/23 13:54, Boris Brezillon wrote: On Thu, 14 Sep 2023 12:45:44 +0200 Thomas Hellström wrote: On 9/14/23 10:20, Boris Brezillon wrote: On Wed, 13 Sep 2023 15:22:56 +0200 Thomas Hellström wrote: On 9/13/23 13:33, Boris Brezillon wrote: On Wed, 13 Sep 2023 12:39:01 +0200 Thomas

Re: [PATCH 00/19] drm/i915: prepare for xe driver display integration

2023-09-14 Thread Rodrigo Vivi
On Tue, Sep 12, 2023 at 02:06:27PM +0300, Jani Nikula wrote: > The upcoming drm/xe driver [1][2] will reuse the drm/i915 display code, > initially by compiling the relevant compilation units separately as part > of the xe driver. This series prepares for that in i915 side. > > The first patch defi

Re: [RFC PATCH v1 01/12] Revert "drm/sysfs: Link DRM connectors to corresponding Type-C connectors"

2023-09-14 Thread Heikki Krogerus
Hi guys, On Thu, Sep 14, 2023 at 01:40:49PM +0300, Dmitry Baryshkov wrote: > On Thu, 14 Sept 2023 at 12:26, Heikki Krogerus > wrote: > > > > Hi Dmitry, > > > > On Wed, Sep 13, 2023 at 04:47:12PM +0300, Dmitry Baryshkov wrote: > > > On Wed, 13 Sept 2023 at 16:15, Heikki Krogerus > > > wrote: > >

[Bug 217910] New: AMD Radeon RX 6600 XT: redraw artifacts around gui elements on primary monitor if TearFree disabled

2023-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217910 Bug ID: 217910 Summary: AMD Radeon RX 6600 XT: redraw artifacts around gui elements on primary monitor if TearFree disabled Product: Drivers Version: 2.5 Hardware: AMD

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/14/23 13:32, Thomas Hellström wrote: On 9/14/23 12:57, Danilo Krummrich wrote: On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma-resv locks, neat! However, what if two tasks are trying to lock the VA space concurrently? What do we do whe

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Boris Brezillon
On Thu, 14 Sep 2023 15:33:50 +0200 Thomas Hellström wrote: > Hi, > > On 9/14/23 13:54, Boris Brezillon wrote: > > On Thu, 14 Sep 2023 12:45:44 +0200 > > Thomas Hellström wrote: > > > >> On 9/14/23 10:20, Boris Brezillon wrote: > >>> On Wed, 13 Sep 2023 15:22:56 +0200 > >>> Thomas Hellström

Re: [PATCH v3 03/13] drm/sched: Move schedule policy to scheduler / entity

2023-09-14 Thread Matthew Brost
On Thu, Sep 14, 2023 at 12:23:35AM -0400, Luben Tuikov wrote: > On 2023-09-14 00:18, Luben Tuikov wrote: > > On 2023-09-11 22:16, Matthew Brost wrote: > >> Rather than a global modparam for scheduling policy, move the scheduling > >> policy to scheduler / entity so user can control each scheduler /

Re: [PATCH v3 03/13] drm/sched: Move schedule policy to scheduler / entity

2023-09-14 Thread Matthew Brost
On Thu, Sep 14, 2023 at 12:18:11AM -0400, Luben Tuikov wrote: > On 2023-09-11 22:16, Matthew Brost wrote: > > Rather than a global modparam for scheduling policy, move the scheduling > > policy to scheduler / entity so user can control each scheduler / entity > > policy. > > > > v2: > > - s/DRM_

[PATCH] drm/mediatek/dp: fix memory leak on ->get_edid callback audio detection

2023-09-14 Thread Jani Nikula
The sads returned by drm_edid_to_sad() needs to be freed. Fixes: e71a8ebbe086 ("drm/mediatek: dp: Audio support for MT8195") Cc: Guillaume Ranquet Cc: Bo-Chen Chen Cc: AngeloGioacchino Del Regno Cc: Dmitry Osipenko Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: dri-devel@lists

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/14/23 15:48, Thomas Hellström wrote: Hi, Danilo Some additional minor comments as xe conversion progresses. On 9/9/23 17:31, Danilo Krummrich wrote: So far the DRM GPUVA manager offers common infrastructure to track GPU VA allocations and mappings, generically connect GPU VA mappings to t

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Thu, Sep 14, 2023 at 03:23:53PM +0200, Javier Martinez Canillas wrote: >> Maxime Ripard writes: >> >> Hello Maxime, >> >> > Hi, >> > >> > On Wed, Sep 13, 2023 at 07:29:25AM +0200, Javier Martinez Canillas wrote: >> >> static const struct drm_crtc_helper_funcs ssd130

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On Thu, 2023-09-14 at 17:27 +0200, Danilo Krummrich wrote: > On 9/14/23 13:32, Thomas Hellström wrote: > > > > On 9/14/23 12:57, Danilo Krummrich wrote: > > > On 9/13/23 14:16, Danilo Krummrich wrote: > > > > > > > > > > > > > > > And validate() can remove it while still holding all dma- > > >

Re: [Nouveau] [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/14/23 19:13, Thomas Hellström wrote: On Thu, 2023-09-14 at 17:27 +0200, Danilo Krummrich wrote: On 9/14/23 13:32, Thomas Hellström wrote: On 9/14/23 12:57, Danilo Krummrich wrote: On 9/13/23 14:16, Danilo Krummrich wrote: And validate() can remove it while still holding all dma- resv

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On Thu, 2023-09-14 at 18:36 +0200, Danilo Krummrich wrote: > On 9/14/23 15:48, Thomas Hellström wrote: > > Hi, Danilo > > > > Some additional minor comments as xe conversion progresses. > > > > On 9/9/23 17:31, Danilo Krummrich wrote: > > > So far the DRM GPUVA manager offers common infrastructur

[RFC] drm/msm/rd: Check PT_PTRACED for cmdstream dumping

2023-09-14 Thread Rob Clark
From: Rob Clark So, when you want to get a cmdstream trace of some deqp or piglit test, but you happen to be running it on the same laptop with full desktop env, the current dump-everything firehose of `cat $debugfs/dri/n/rd` is quite a bit too much. Ptrace seemed kind of a natural way to contro

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Danilo Krummrich
On 9/14/23 19:21, Thomas Hellström wrote: On Thu, 2023-09-14 at 18:36 +0200, Danilo Krummrich wrote: On 9/14/23 15:48, Thomas Hellström wrote: Hi, Danilo Some additional minor comments as xe conversion progresses. On 9/9/23 17:31, Danilo Krummrich wrote: So far the DRM GPUVA manager offers c

Re: [PATCH v3 10/13] drm/sched: Add helper to set TDR timeout

2023-09-14 Thread Matthew Brost
On Wed, Sep 13, 2023 at 10:38:24PM -0400, Luben Tuikov wrote: > On 2023-09-11 22:16, Matthew Brost wrote: > > Add helper to set TDR timeout and restart the TDR with new timeout > > value. This will be used in XE, new Intel GPU driver, to trigger the TDR > > to cleanup drm_sched_entity that encounte

Re: [PATCH v3 09/13] drm/sched: Submit job before starting TDR

2023-09-14 Thread Matthew Brost
On Wed, Sep 13, 2023 at 10:56:10PM -0400, Luben Tuikov wrote: > On 2023-09-11 22:16, Matthew Brost wrote: > > If the TDR is set to a value, it can fire before a job is submitted in > > drm_sched_main. The job should be always be submitted before the TDR > > fires, fix this ordering. > > > > v2: >

[PATCH] drm/amd/display: fix the ability to use lower resolution modes on eDP

2023-09-14 Thread Hamza Mahfooz
On eDP we can receive invalid modes from dm_update_crtc_state() for entirely new streams for which drm_mode_set_crtcinfo() shouldn't be called on. So, instead of calling drm_mode_set_crtcinfo() from within create_stream_for_sink() we can instead call it from amdgpu_dm_connector_mode_valid(). Since,

[PATCH] drm/modes: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
ame[DRM_DISPLAY_MODE_LEN-1] = 0; + strscpy(out->name, in->name, DRM_DISPLAY_MODE_LEN); /* Clearing picture aspect ratio bits from out flags, * as the aspect-ratio information is not stored in --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230

Re: [PATCH v4] drm/ssd130x: Store the HW buffer in the driver-private CRTC state

2023-09-14 Thread Javier Martinez Canillas
Maxime Ripard writes: [...] > > Acked-by: Maxime Ripard > Pushed to drm-misc (drm-misc-next). Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

[PATCH] drm/etnaviv: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
gnal->iter++; if (signal->iter == dom->nr_signals) --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-gpu-drm-etnaviv-etnaviv_perfmon-c-dd095491dfde Best regards, -- Justin Stitt

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-14 Thread Thomas Hellström
On Thu, 2023-09-14 at 19:25 +0200, Danilo Krummrich wrote: > On 9/14/23 19:21, Thomas Hellström wrote: > > On Thu, 2023-09-14 at 18:36 +0200, Danilo Krummrich wrote: > > > On 9/14/23 15:48, Thomas Hellström wrote: > > > > Hi, Danilo > > > > > > > > Some additional minor comments as xe conversion p

[Bug 217910] AMD Radeon RX 6600 XT: redraw artifacts around gui elements on primary monitor if TearFree disabled

2023-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217910 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[PATCH v3 13/25] drm/dp_mst: Add a way to calculate PBN values with FEC overhead

2023-09-14 Thread Imre Deak
Add a way for drivers to calculate the MST PBN values with FEC overhead. This is required by 8b/10b links both for DSC and non-DSC (the latter needed if there are both DSC and non-DSC streams on the same MST link). Also add a kunit test case for PBN values calculated with FEC overhead. v2: - Reba

[PATCH v3 14/25] drm/dp_mst: Add helper to determine if an MST port is downstream of another port

2023-09-14 Thread Imre Deak
Add drm_dp_mst_port_downstream_of_parent() required by the i915 driver in a follow-up patch to resolve a BW overallocation of MST streams going through a given MST port. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Reviewed-by: Lyude Paul Signed-off-by: Imre Deak --- drivers/gpu/drm/disp

[PATCH v3 15/25] drm/dp_mst: Factor out a helper to check the atomic state of a topology manager

2023-09-14 Thread Imre Deak
Factor out a helper to check the atomic state for one MST topology manager, returning the MST port where the BW limit check has failed. This will be used in a follow-up patch by the i915 driver to improve the BW sharing between MST streams. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Revie

[PATCH v3 16/25] drm/dp_mst: Swap the order of checking root vs. non-root port BW limitations

2023-09-14 Thread Imre Deak
drm_dp_mst_atomic_check_mgr() should check for BW limitation starting from sink ports continuing towards the root port, so that drivers can use the @failing_port returned to resolve a BW overallocation in an ideal way. For instance from streams A,B,C in a topology A,B going through @failing_port an

[PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks

2023-09-14 Thread Javier Martinez Canillas
The driver uses a naming convention where functions for struct drm_*_funcs callbacks are named ssd130x_$object_$operation, while the callbacks for struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation. The idea is that this helper_ prefix in the function names denote that are for s

Re: [RFC PATCH 5/8] drm/panel: nv3052c: Allow specifying registers per panel

2023-09-14 Thread Jessica Zhang
On 9/13/2023 9:09 PM, John Watts wrote: On Wed, Sep 13, 2023 at 02:34:38PM -0700, Jessica Zhang wrote: Hi John, Having a separate panel_regs_len field seems a bit unnecessary to me. Looks like it's only being called in the panel prepare() and I don't seen any reason why we shouldn't just ca

Re: [RFC PATCH 1/8] drm/panel: nv3052c: Document known register names

2023-09-14 Thread Jessica Zhang
On 9/13/2023 9:12 PM, John Watts wrote: On Wed, Sep 13, 2023 at 02:43:43PM -0700, Jessica Zhang wrote: Hi John, Just curious, what do you mean by these registers being mostly unknown? I do see them specified in the online specs -- some even seem to map to existing MIPI_DCS_* enums (ex. 0x01

Re: [PATCH] drm/amd/display: fix the ability to use lower resolution modes on eDP

2023-09-14 Thread Harry Wentland
On 2023-09-14 13:53, Hamza Mahfooz wrote: > On eDP we can receive invalid modes from dm_update_crtc_state() for > entirely new streams for which drm_mode_set_crtcinfo() shouldn't be > called on. So, instead of calling drm_mode_set_crtcinfo() from within > create_stream_for_sink() we can instead cal

Re: [PATCH] fix a memory leak in amdgpu_ras_feature_enable

2023-09-14 Thread Alex Deucher
Applied. Thanks! On Thu, Sep 14, 2023 at 5:53 AM Zhang, Hawking wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Hawking Zhang > > Regards, > Hawking > -Original Message- > From: Cong Liu > Sent: Thursday, September 14, 2023 17:46 > To: Deucher, Alexander ; Koenig, Christi

[PATCH] drm/gma500: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
chan->base.dev.parent = dev->dev; --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-drivers-gpu-drm-gma500-oaktrail_lvds_i2c-c-a53c6d8bd62f Best regards, -- Justin Stitt

Re: [PATCH] drm/amd/display: fix the ability to use lower resolution modes on eDP

2023-09-14 Thread Hamza Mahfooz
On 9/14/23 16:40, Harry Wentland wrote: On 2023-09-14 13:53, Hamza Mahfooz wrote: On eDP we can receive invalid modes from dm_update_crtc_state() for entirely new streams for which drm_mode_set_crtcinfo() shouldn't be called on. So, instead of calling drm_mode_set_crtcinfo() from within create

Re: [PATCH] drm/amd/display: fix the ability to use lower resolution modes on eDP

2023-09-14 Thread Hamza Mahfooz
On 9/14/23 17:04, Hamza Mahfooz wrote: On 9/14/23 16:40, Harry Wentland wrote: On 2023-09-14 13:53, Hamza Mahfooz wrote: On eDP we can receive invalid modes from dm_update_crtc_state() for entirely new streams for which drm_mode_set_crtcinfo() shouldn't be called on. So, instead of calling d

[PATCH] drm/i915: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
ppgtt = mock_ppgtt(i915, name); if (!ppgtt) --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142 Best regards, -- Justin Stitt

Re: [PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-09-14 Thread Laurent Pinchart
Hi Neil, Sorry about the delay, the series got burried in my inbox. On Tue, Aug 22, 2023 at 04:27:37PM +0200, Neil Armstrong wrote: > On 22/08/2023 16:19, Laurent Pinchart wrote: > > On Tue, Aug 22, 2023 at 05:17:37PM +0300, Laurent Pinchart wrote: > >> On Thu, Aug 17, 2023 at 05:55:13PM +0300, D

[PATCH] drm/nouveau/nvif: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
sizeof(args), --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-gpu-drm-nouveau-nvif-client-c-82b023c36953 Best regards, -- Justin Stitt

[PATCH] drm/nouveau/core: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
device->chip->name, sizeof(cname)); i = strlen(cname); while (i) { --i; --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-gpu-drm-nouveau-nvkm-core-firmware-c-791223838b72 Best regards, -- Justin Stitt

Re: [PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-09-14 Thread Laurent Pinchart
Hi Dmitry, On Mon, Sep 04, 2023 at 12:02:18AM +0300, Dmitry Baryshkov wrote: > On Tue, 22 Aug 2023 at 17:17, Laurent Pinchart wrote: > > On Thu, Aug 17, 2023 at 05:55:13PM +0300, Dmitry Baryshkov wrote: > > > Supporting DP/USB-C can result in a chain of several transparent > > > bridges (PHY, redr

Re: [PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-09-14 Thread Dmitry Baryshkov
On Fri, 15 Sept 2023 at 00:44, Laurent Pinchart wrote: > > Hi Dmitry, > > On Mon, Sep 04, 2023 at 12:02:18AM +0300, Dmitry Baryshkov wrote: > > On Tue, 22 Aug 2023 at 17:17, Laurent Pinchart wrote: > > > On Thu, Aug 17, 2023 at 05:55:13PM +0300, Dmitry Baryshkov wrote: > > > > Supporting DP/USB-C

Re: [PATCH v2 1/1] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-09-14 Thread Balasubrawmanian, Vivaik
On 9/13/2023 3:57 PM, Alan Previn wrote: Debugging PXP issues can't even begin without understanding precedding sequence of events. Add drm_dbg into the most important PXP events. v2 : - remove __func__ since drm_dbg covers that (Jani). - add timeout of the restart from front-end (Alan)

Re: [PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-09-14 Thread Dmitry Baryshkov
On Fri, 15 Sept 2023 at 00:23, Laurent Pinchart wrote: > > Hi Neil, > > Sorry about the delay, the series got burried in my inbox. > > On Tue, Aug 22, 2023 at 04:27:37PM +0200, Neil Armstrong wrote: > > On 22/08/2023 16:19, Laurent Pinchart wrote: > > > On Tue, Aug 22, 2023 at 05:17:37PM +0300, La

[PATCH] drm/nouveau/pm: refactor deprecated strncpy

2023-09-14 Thread Justin Stitt
} if (++si < source_nr) { --- base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec change-id: 20230914-strncpy-drivers-gpu-drm-nouveau-nvkm-engine-pm-base-c-38bf9c78bc0f Best regards, -- Justin Stitt

Re: [PATCH v5 1/3] drm/i915/pxp/mtl: Update pxp-firmware response timeout

2023-09-14 Thread Balasubrawmanian, Vivaik
On 9/9/2023 3:38 PM, Alan Previn wrote: Update the max GSC-fw response time to match updated internal fw specs. Because this response time is an SLA on the firmware, not inclusive of i915->GuC->HW handoff latency, when submitting requests to the GSC fw via intel_gsc_uc_heci_cmd_submit helpers, st

Re: [PATCH v4 2/3] drm/i915/pxp/mtl: Update pxp-firmware packet size

2023-09-14 Thread Balasubrawmanian, Vivaik
On 9/6/2023 5:15 PM, Alan Previn wrote: Update the GSC-fw input/output HECI packet size to match updated internal fw specs. Signed-off-by: Alan Previn --- drivers/gpu/drm/i915/pxp/intel_pxp_cmd_interface_43.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

  1   2   >