[PATCH] drm/display/dp: Add the remaining Square PHY patterns DPCD register definitions

2023-09-01 Thread Khaled Almahallawy
DP Scope may send requests for all Square PHY pattern configuration during automation. Add them instead of failing these tests. Cc: Jani Nikula Cc: Lee Shawn C Signed-off-by: Khaled Almahallawy --- include/drm/display/drm_dp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/

[PULL] drm-misc-next-fixes

2023-09-01 Thread Thomas Zimmermann
Hi Dave and Daniel, here are two more fixes that have been sitting in drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2023-09-01: Short summary of fixes pull: * ivpu: Replace strncpy * nouveau: Fix fence state in nouveau_fence_emit() The following changes since commit cdf4100eaa1

[PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-09-01 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6316 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c |

[PATCH 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-09-01 Thread Mauro Carvalho Chehab
As an example for the new documentation tool, add a documentation for drm_buddy_test. I opted to place this on a completely different directory, in order to make easier to test the feature with: $ make SPHINXDIRS="tests" htmldocs Acked-by: Christian König Reviewed-by: Arunpravin Paneer

Re: [PATCH RFC 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-09-01 Thread Mauro Carvalho Chehab
Hi Rae, Em Thu, 13 Jul 2023 17:31:19 -0400 Rae Moar escreveu: > On Wed, Jul 12, 2023 at 10:29 AM Mauro Carvalho Chehab > wrote: > > > As an example for the new documentation tool, add a documentation > > for drm_buddy_test. > > > > I opted to place this on a completely different directory, in

Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-09-01 Thread Christian König
Am 01.09.23 um 09:02 schrieb Jiapeng Chong: No functional modification involved. drivers/gpu/drm/amd/amdgpu/nbio_v7_11.c:34 nbio_v7_11_get_rev_id() warn: inconsistent indenting. We should probably not have a printk here in the first place. Christian. Reported-by: Abaci Robot Closes: htt

Re: [PATCH 0/6] drm, cec and edid updates

2023-09-01 Thread Maxime Ripard
On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: > > Avoid accessing the raw edid directly. Pre-parse the source physical > > address during normal EDID parsing and use that for CEC. > > > > Jani Nikula (6): > > drm/edid: add drm_edid_is_digi

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi Javier, > > another idea about this patch: why not just keep the allocation in the > plane's atomic check, but store the temporary buffers in a plane struct. > You'd only grow the arrays length in atomic_check and later fetch the > pointers in atomic_update. It n

[GIT PULL] fbdev fixes and updates for v6.6-rc1

2023-09-01 Thread Helge Deller
Hi Linus, please pull some fbdev fixes & updates for kernel 6.6-rc1. Remove the mx3fb driver and various smaller cleanups. Thanks! Helge -- The following changes since commit 87dfd85c38923acd9517e8df4afc908565df0961: Merge tag 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-09-01 Thread Maxime Ripard
On Thu, Aug 31, 2023 at 11:18:49AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Aug 31, 2023 at 12:38 AM Maxime Ripard wrote: > > > > If so, then I think we can implement everything by doing something like: > > > > - Implement enable and disable refcounting in panels. > > drm_panel_prepare

Re: [PATCH 5/7] fbdev/core: Build fb_logo iff CONFIG_LOGO has been selected

2023-09-01 Thread Helge Deller
On 8/29/23 16:15, Thomas Zimmermann wrote: Only build fb_logo.c if CONFIG_LOGO has been selected. Otherwise provide empty implementations of the contained interfaces and avoid using the exported variables. Signed-off-by: Thomas Zimmermann ... diff --git a/drivers/video/fbdev/core/fbcon.c b/dr

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
Hi, On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > .atomic_check() callback") moved the allocation of the intermediate and > HW buffers from the encoder's .atomic_enable callback to primary plane's

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 09:48:09AM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > Hi Javier, > > > > another idea about this patch: why not just keep the allocation in the > > plane's atomic check, but store the temporary buffers in a plane struct. > > You'd only grow

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > > .atomic_check() callback") moved the allocation of the intermediate and > > HW

Re: [PATCH 1/5] drm/debugfs: drop debugfs_init() for the render and accel node v2

2023-09-01 Thread Tomer Tayar
Hi Christian, On 29/08/2023 14:01, Christian König wrote: > We want to remove per minor debugfs directories. Start by stopping > drivers from adding anything inside of those in the mid layer callback. > > v2: drop it for the accel node as well > > Signed-off-by: Christian König > Tested-by: Stani

Re: [PATCH 0/6] drm, cec and edid updates

2023-09-01 Thread Jani Nikula
On Fri, 01 Sep 2023, Maxime Ripard wrote: > On Thu, Aug 31, 2023 at 09:51:24PM +0300, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Jani Nikula wrote: >> > Avoid accessing the raw edid directly. Pre-parse the source physical >> > address during normal EDID parsing and use that for CEC. >> > >> > Jan

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Jai Luthra
Hi Nishanth, Helen, Thanks for the review. On Aug 31, 2023 at 07:25:31 -0500, Nishanth Menon wrote: > On 16:35-20230828, Helen Mae Koike Fornazier wrote: > > On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote: > > > > > Fix the NULL pointer dereference when no monitor is connected, and the

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Maxime Ripard writes: > On Fri, Sep 01, 2023 at 09:48:09AM +0200, Javier Martinez Canillas wrote: >> Thomas Zimmermann writes: >> >> > Hi Javier, >> > >> > another idea about this patch: why not just keep the allocation in the >> > plane's atomic check, but store the temporary buffers in a pla

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Maxime, > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: >> On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: >> > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's >> > .atomic_check() callback") moved the alloc

[PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Jai Luthra
Fix the NULL pointer dereference when no monitor is connected, and the sound card is opened from userspace. Instead return an empty buffer (of zeroes) as the EDID information to the sound framework if there is no connector attached. Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support")

Re: [PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2023-09-01 Thread Marius Vlad
Hi Brandon, You can now add https://lists.freedesktop.org/archives/igt-dev/2023-September/060717.html as part of this series. On Tue, Aug 29, 2023 at 05:30:52AM +, Brandon Pollack wrote: > Since Jim is busy with other work and I'm working on some things that > rely on this, I've taken up the

Re: [PATCH v6 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-09-01 Thread Marius Vlad
Hi Brandon, Small nit-pick at the end. On Tue, Aug 29, 2023 at 05:30:54AM +, Brandon Pollack wrote: > From: Jim Shargo > > This change supports multiple CRTCs, encoders, connectors instead of one > of each per device. > > Since ConfigFS-based devices will support multiple crtcs, it's usefu

Re: [PATCH] dma_buf/sync_file: Enable signaling for fences when querying status

2023-09-01 Thread Mikko Perttunen
On 7/25/23 10:46, Mikko Perttunen wrote: From: Mikko Perttunen dma_fence_get_status is not guaranteed to return valid information on if the fence has been signaled or not if SW signaling has not been enabled for the fence. To ensure valid information is reported, enable SW signaling for fences

[PATCH v3 00/11] accel/ivpu: Update for -next 2023.08.25

2023-09-01 Thread Stanislaw Gruszka
Update for -next: - various cleanups - begin preparation for conversion to GEM SHMEM - print information about used workarounds v3: - fix commit messages - split patch 2 into separate patches v2: - fix compilation without CONFIG_PM Jacek Lawrynowicz (4): accel/ivpu: Remove duplicated err

[PATCH v3 01/11] accel/ivpu: Move set autosuspend delay to HW specific code

2023-09-01 Thread Stanislaw Gruszka
From: Krystian Pradzynski Configure autosuspend values per HW generation and per platform. For non silicon platforms disable autosuspend for now, for silicon reduce it to 10 ms. Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo Signed-off-by: Stanisl

[PATCH v3 02/11] accel/ivpu: Remove duplicated error messages

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Reduce the number of error messages per single failure in ivpu_dev_init() and ivpu_probe(). Most error messages are already printed by functions called from ivpu_dev_init(). Add missed error prints in ivpu_ipc_init() and ivpu_mmu_context_init(). Signed-off-by: Jacek Lawr

[PATCH v3 03/11] accel/ivpu: Make ivpu_pm_init() void

2023-09-01 Thread Stanislaw Gruszka
ivpu_pm_init() does not return any error, make it void. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 +--- drivers/accel/ivpu/ivpu_fw.c | 2 +- drivers/accel/ivpu/ivpu_pm.c | 4 +--- drivers/accel/ivpu/ivpu_pm.h | 2 +- 4 files changed,

[PATCH v3 04/11] accel/ivpu: Add information about context on failure

2023-09-01 Thread Stanislaw Gruszka
Add additional ctx number to error messages on mmu context initialization failures. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_mmu_context.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_mmu_context

[PATCH v3 05/11] accel/ivpu: Print information about used workarounds

2023-09-01 Thread Stanislaw Gruszka
Use ivpu_dbg(MISC) to print information about workarounds. Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers/accel/ivpu/ivpu_hw_37xx.c | 5 + drivers/accel/ivpu/ivpu_hw_40xx.c | 4 3 files c

[PATCH v3 06/11] accel/ivpu: Initialize context with SSID = 1

2023-09-01 Thread Stanislaw Gruszka
From: Karol Wachowski Context with SSID = 1 is reserved and accesses on that context happen only when context is uninitialized on the VPU side. Such access triggers MMU fault (0xa) "Invalid CD Fetch", which doesn't contain any useful information besides context ID. This commit will change that s

[PATCH v3 07/11] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz ivpu_fw_load() doesn't have to be called separately in ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 drivers/accel/ivpu/ivpu_fw.c

[PATCH v3 08/11] accel/ivpu: Add ivpu_bo_vaddr() and ivpu_bo_size()

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use: - ivpu_bo_vaddr(bo) instead of bo->kvaddr - ivpu_bo_size(bo) instead of bo->base.size This is a preparation for switch to a drm_gem_shmem_object as a base for ivpu_bo, where: - bo->kvaddr becomes bo->base.vaddr - bo->base.size becomes bo->base.base.size Usin

[PATCH v3 09/11] accel/ivpu/37xx: Change register rename leftovers

2023-09-01 Thread Stanislaw Gruszka
Change remaining MTL_VPU_ register names to generation based names. Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx.c | 68 - drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 72 +

[PATCH v3 10/11] accel/ivpu/37xx: White space cleanup

2023-09-01 Thread Stanislaw Gruszka
No functional change, adjust code formatting so that defines line up nicely to improve code readability. Reviewed-by: Karol Wachowski Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 100 +- 1 file changed, 50 insert

[PATCH v3 11/11] accel/ivpu: Move MMU register definitions to ivpu_mmu.c

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz MMU registers are not platform specific so they should be defined separate to platform regs. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 33 ---

[PATCH v2 2/2] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2023-09-01 Thread Michael Walle
mtk_drm_find_possible_crtc_by_comp() assumed that the main path will always have the CRTC with id 0, the ext id 1 and the third id 2. This is only true if the paths are all available. But paths are optional (see also comment in mtk_drm_kms_init()), e.g. the main path might not be enabled or availab

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-09-01 Thread Michael Walle
Hi, I was just curious if you know of any development for that (or similar) in the kernel. This is probably because support for this SoC began with Chromebooks, which have fixed and defined uses for the pipelines. I suspect that what you are working on is much more flexible. Yes. that is co

[PATCH v2 1/2] drm/mediatek: fix kernel oops if no crtc is found

2023-09-01 Thread Michael Walle
drm_crtc_from_index(0) might return NULL if there are no CRTCs registered at all which will lead to a kernel oops in mtk_drm_crtc_dma_dev_get(). Add the missing return value check. Fixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195") Signed-off-by: Michael Walle Reviewe

[RFC] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: switch to drm_do_get_edid()

2023-09-01 Thread Jani Nikula
The driver was originally added in commit fcfa0ddc18ed ("drm/bridge: Drivers for megachips-stdp-ge-b850v3-fw (LVDS-DP++)"). I tried to look up the discussion, but didn't find anyone questioning the EDID reading part. Why does it not use drm_get_edid() or drm_do_get_edid()? I don't know where

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Thomas Zimmermann
Hi Am 01.09.23 um 09:48 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hi Javier, another idea about this patch: why not just keep the allocation in the plane's atomic check, but store the temporary buffers in a plane struct. You'd only grow the arrays length in atomic_check and

[PATCH 1/3] gpu: host1x: Add locking in channel allocation

2023-09-01 Thread Mikko Perttunen
From: Mikko Perttunen Add locking around channel allocation to avoid race conditions. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/channel.c | 7 +++ drivers/gpu/host1x/channel.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/ho

[PATCH 3/3] gpu: host1x: Enable system suspend callbacks

2023-09-01 Thread Mikko Perttunen
From: Mikko Perttunen With the previous CDMA stop fix, executing runtime PM ops around system suspend now makes channel submissions work after system suspend, so do that. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 2/3] gpu: host1x: Stop CDMA before suspending

2023-09-01 Thread Mikko Perttunen
From: Mikko Perttunen Before going into suspend, wait all CDMA to go idle and stop it. This will ensure no channel is still active while we enter suspend, and ensures the driver doesn't think that CDMA is still active when coming back from suspend (as HW state has been reset). Signed-off-by: Mik

Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Aradhya Bhatia
On 01-Sep-23 15:01, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an empty buffer (of zeroes) as the EDID information to > the sound framework if there is no connector attached. > > Fixes: e0

[PATCH] gpu: host1x: Syncpoint interrupt sharding

2023-09-01 Thread Mikko Perttunen
From: Mikko Perttunen Support sharded syncpoint interrupts on Tegra234+. This feature allows specifying one of eight interrupt lines for each syncpoint to lower processing latency of syncpoint threshold interrupts. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c| 28 +++

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Jai Luthra
Hi Aradhya, Thanks for the comments. On Aug 28, 2023 at 16:34:30 +0530, Aradhya Bhatia wrote: > Hi Jai, > > Thanks for debugging the issue. > > On 25-Aug-23 16:32, Jai Luthra wrote: > > Fix the NULL pointer dereference when no monitor is connected, and the > > sound card is opened from userspac

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi > > Am 01.09.23 um 09:48 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> Hi Javier, >>> >>> another idea about this patch: why not just keep the allocation in the >>> plane's atomic check, but store the temporary buffers in a p

RE: [PATCH v10 0/4] Add RZ/{G2L, G2LC} and RZ/V2L Display Unit support

2023-09-01 Thread Biju Das
Hi All, Gentle ping. This patch[1] is posted around 2 months now. Please let me know is there any dependency/blockers for accepting this patch series? https://lore.kernel.org/all/20230704090447.27420-1-biju.das...@bp.renesas.com/ Cheers, Biju > -Original Message- > From: Biju Das >

[PATCH 1/2] gpu: host1x: Correct allocated size for contexts

2023-09-01 Thread Mikko Perttunen
From: Johnny Liu Original implementation over allocates the memory size for the contexts list. The size of memory for the contexts list is based on the number of iommu groups specified in the device tree. Fixes: 8aa5bcb61612 ("gpu: host1x: Add context device management code") Signed-off-by: John

[PATCH 2/2] drm/tegra: Zero-initialize iosys_map

2023-09-01 Thread Mikko Perttunen
From: Mikko Perttunen UBSAN reports an invalid load for bool, as the iosys_map is read later without being initialized. Zero-initialize it to avoid this. Reported-by: Ashish Mhetre Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Maxime Ripard
On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > Hi Maxime, > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > > The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's > > >

Re: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-09-01 Thread kernel test robot
3] drm/ttm/tests: Add tests for ttm_bo functions config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20230901/202309011935.bbpezbuq-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230901/20

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Geert Uytterhoeven
Hi Maxime, On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: > On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: > > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: > > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier Martinez Canillas wrote: > > > > The commit 45b5866

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-09-01 Thread Danilo Krummrich
On Fri, Sep 01, 2023 at 07:59:21AM +0200, Thomas Hellström (Intel) wrote: > > On 8/31/23 21:07, Danilo Krummrich wrote: > > On Thu, Aug 31, 2023 at 06:53:01PM +0200, Thomas Hellström (Intel) wrote: > > > Hi, > > > > > > On 8/31/23 13:18, Danilo Krummrich wrote: > > > > On Thu, Aug 31, 2023 at 11:

Re: [RFC PATCH] drm/ssd130x: Allocate buffer in the CRTC's .atomic_check() callback

2023-09-01 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Fri, Sep 1, 2023 at 2:00 PM Maxime Ripard wrote: >> On Fri, Sep 01, 2023 at 10:36:17AM +0200, Geert Uytterhoeven wrote: >> > On Fri, Sep 1, 2023 at 10:22 AM Maxime Ripard wrote: >> > > On Wed, Aug 30, 2023 at 08:25:08AM +0200, Javier

Re: [Intel-gfx] [PATCH 0/4] drm/amd/display: stop using drm_edid_override_connector_update()

2023-09-01 Thread Jani Nikula
On Thu, 31 Aug 2023, Alex Hung wrote: > On 2023-08-30 01:29, Jani Nikula wrote: >> On Tue, 29 Aug 2023, Alex Hung wrote: >>> There is a patch under internal reviews. It removes calls edid_override >>> and drm_edid_override_connector_update as intended in this patchset but >>> does not remove the

Re: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-09-01 Thread Karolina Stolarek
link: https://lore.kernel.org/r/d914169aee773ee20c0b730b38d42a1fd7613bb6.1693479161.git.karolina.stolarek%40intel.com patch subject: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20230901/202309011935.bbpezbuq-...@intel.c

Re: [PATCH] MAINTAINERS: Add Jessica as a reviewer for drm/panel

2023-09-01 Thread neil . armstrong
On 01/09/2023 00:57, Jessica Zhang wrote: As I participate more actively in the drm/panel subsystem, I would like to get notified about new changes in this area. Since I have contributed and continue to contribute to drm/panel, add myself as a reviewer for the DRM panel drivers to help the revie

Re: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-09-01 Thread Christian König
t patch link: https://lore.kernel.org/r/d914169aee773ee20c0b730b38d42a1fd7613bb6.1693479161.git.karolina.stolarek%40intel.com patch subject: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20230901/202309011935.bbpezbuq-...@intel.com/config) compiler: or1k-linux-g

[drm-misc:drm-misc-next 1/3] include/drm/drm_drv.h:587:13: error: unused function 'drm_debugfs_dev_init'

2023-09-01 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 8e455145d8f163aefa6b9cc29478e0a9f82276e6 commit: 0b30d57acafcaa5374756d314ee54f80d0bcc860 [1/3] drm/debugfs: rework debugfs directory creation v5 config: arm-randconfig-r021-20230901 (https://download.01.org/0day-ci/archive

Re: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-09-01 Thread Karolina Stolarek
atch subject: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20230901/202309011935.bbpezbuq-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.

[drm-misc:drm-misc-next 1/3] include/drm/drm_drv.h:587:13: warning: 'drm_debugfs_dev_init' defined but not used

2023-09-01 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 8e455145d8f163aefa6b9cc29478e0a9f82276e6 commit: 0b30d57acafcaa5374756d314ee54f80d0bcc860 [1/3] drm/debugfs: rework debugfs directory creation v5 config: parisc-randconfig-r033-20230901 (https://download.01.org/0day-ci

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-09-01 Thread Doug Anderson
Hi, On Fri, Sep 1, 2023 at 1:15 AM Maxime Ripard wrote: > > On Thu, Aug 31, 2023 at 11:18:49AM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Aug 31, 2023 at 12:38 AM Maxime Ripard wrote: > > > > > > If so, then I think we can implement everything by doing something like: > > > > > > - Im

Re: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-09-01 Thread Christian König
intel.com patch subject: [PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20230901/202309011935.bbpezbuq-...@intel.com/config) compiler: or1k-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://downloa

Re: [PATCH v2 02/15] drm/panthor: Add uAPI

2023-09-01 Thread Liviu Dudau
Hi Boris, On Wed, Aug 09, 2023 at 06:53:15PM +0200, Boris Brezillon wrote: > Panthor follows the lead of other recently submitted drivers with > ioctls allowing us to support modern Vulkan features, like sparse memory > binding: > > - Pretty standard GEM management ioctls (BO_CREATE and BO_MMAP_O

[PATCH 2/2] drm: Schedule the HPD poll work on the system unbound workqueue

2023-09-01 Thread Imre Deak
On some i915 platforms at least the HPD poll work involves I2C bit-banging using udelay()s to probe for monitor EDIDs. This in turn may trigger the workqueue: output_poll_execute [drm_kms_helper] hogged CPU for >1us 4 times, consider switching to WQ_UNBOUND warning. Fix this by scheduling d

Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

2023-09-01 Thread Nishanth Menon
On 17:01-20230901, Aradhya Bhatia wrote: > On 01-Sep-23 15:01, Jai Luthra wrote: > > Fix the NULL pointer dereference when no monitor is connected, and the > > sound card is opened from userspace. > > > > Instead return an empty buffer (of zeroes) as the EDID i

Re: [PATCH v3 02/11] accel/ivpu: Remove duplicated error messages

2023-09-01 Thread Jeffrey Hugo
On 9/1/2023 3:49 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Reduce the number of error messages per single failure in ivpu_dev_init() and ivpu_probe(). Most error messages are already printed by functions called from ivpu_dev_init(). Add missed error prints in ivpu_ipc_init() and ivp

[PATCH] drm/msm/dp: skip validity check for DP CTS EDID checksum

2023-09-01 Thread Jani Nikula
The DP CTS test for EDID last block checksum expects the checksum for the last block, invalid or not. Skip the validity check. For the most part (*), the EDIDs returned by drm_get_edid() will be valid anyway, and there's the CTS workaround to get the checksum for completely invalid EDIDs. See comm

Re: [PATCH v3 03/11] accel/ivpu: Make ivpu_pm_init() void

2023-09-01 Thread Jeffrey Hugo
On 9/1/2023 3:49 AM, Stanislaw Gruszka wrote: ivpu_pm_init() does not return any error, make it void. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 +--- drivers/accel/ivpu/ivpu_fw.c | 2 +- drivers/accel/ivpu/ivpu_pm.c | 4 +--- dri

[PATCH 0/4] ppc, fbdev: Clean up fbdev mmap helper

2023-09-01 Thread Thomas Zimmermann
Refactor fb_pgprotect() in PowerPC to work without struct file. Then clean up and rename fb_pgprotect(). This change has been discussed at [1] in the context of refactoring fbdev's mmap code. The first three patches adapt PowerPC's internal interfaces to provide a phys_mem_access_prot() that works

[PATCH 4/4] fbdev: Replace fb_pgprotect() with fb_pgprot_device()

2023-09-01 Thread Thomas Zimmermann
Rename the fbdev mmap helper fb_pgprotect() to fb_pgprot_device(). The helper sets VMA page-access flags for framebuffers in device I/O memory. The new name follows pgprot_device(), which does the same for arbitrary devices. Also clean up the helper's parameters and return value. Instead of the VM

[PATCH 1/4] arch/powerpc: Remove trailing whitespaces

2023-09-01 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- arch/powerpc/include/asm/machdep.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h index 4f6e7d7ee388..933465ed4c4

[PATCH 3/4] arch/powerpc: Call internal __phys_mem_access_prot() in fbdev code

2023-09-01 Thread Thomas Zimmermann
Call __phys_mem_access_prot() from the fbdev mmap helper fb_pgprotect(). Allows us to avoid the file argument, which can then be removed from fB_pgprotect() entirely. No other architecture uses the parameter. Signed-off-by: Thomas Zimmermann --- arch/powerpc/include/asm/fb.h | 6 +++--- 1 file c

[PATCH 2/4] arch/powerpc: Remove file parameter from phys_mem_access_prot code

2023-09-01 Thread Thomas Zimmermann
Remove 'file' parameter from struct machdep_calls.phys_mem_access_prot and its implementation in pci_phys_mem_access_prot(). The file is not used on PowerPC. By removing it, a later patch can simplify fbdev's mmap code, which uses phys_mem_access_prot() on PowerPC. Signed-off-by: Thomas Zimmermann

Re: [V11 3/8] wifi: mac80211: Add support for WBRF features

2023-09-01 Thread Jeff Johnson
On 8/30/2023 11:20 PM, Evan Quan wrote: To support the WBRF mechanism, Wifi adapters utilized in the system must Since this is the first mention of WBRF in the core wireless code IMO you should indicate what this is an acronym for and briefly describe it (or add a lore link). I'm wondering i

Re: [PATCH v3 03/11] accel/ivpu: Make ivpu_pm_init() void

2023-09-01 Thread Stanislaw Gruszka
On Fri, Sep 01, 2023 at 08:22:07AM -0600, Jeffrey Hugo wrote: > On 9/1/2023 3:49 AM, Stanislaw Gruszka wrote: > > ivpu_pm_init() does not return any error, make it void. > > > > Reviewed-by: Karol Wachowski > > Signed-off-by: Stanislaw Gruszka > > --- > > drivers/accel/ivpu/ivpu_drv.c | 4 +---

Re: [RFC] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: switch to drm_do_get_edid()

2023-09-01 Thread Jani Nikula
On Fri, 01 Sep 2023, Jani Nikula wrote: > The driver was originally added in commit fcfa0ddc18ed ("drm/bridge: > Drivers for megachips-stdp-ge-b850v3-fw (LVDS-DP++)"). I tried to > look up the discussion, but didn't find anyone questioning the EDID > reading part. > > Why does it not use drm_g

Re: [PATCH v3 04/11] accel/ivpu: Add information about context on failure

2023-09-01 Thread Jeffrey Hugo
On 9/1/2023 3:49 AM, Stanislaw Gruszka wrote: Add additional ctx number to error messages on mmu context initialization failures. Looking at this for the first time, the "why" doesn't seem obvious. Based on my understanding, I suggest - "Identify the mmu context that failed to initialize in

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-09-01 Thread Chen-Yu Tsai
On Fri, Sep 1, 2023 at 6:00 PM Michael Walle wrote: > > Hi, > > >> I was just curious if you know of any development for that (or > >> similar) > >> in the kernel. > > > > This is probably because support for this SoC began with Chromebooks, > > which have fixed and defined uses for the pipelines.

Re: [PATCH v2 02/15] drm/panthor: Add uAPI

2023-09-01 Thread Boris Brezillon
On Wed, 9 Aug 2023 18:53:15 +0200 Boris Brezillon wrote: > +/** > + * DOC: MMIO regions exposed to userspace. > + * > + * .. c:macro:: DRM_PANTHOR_USER_MMIO_OFFSET > + * > + * File offset for all MMIO regions being exposed to userspace. Don't use > + * this value directly, use DRM_PANTHOR_USER__

[PATCH] accel/qaic: Register for PCI driver at the beginning of module init

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya As qaic drivers base device is connected to host via PCI framework, it makes sense to register in PCI framework at the beginning of module init. Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Carl Vanderlip Reviewed-by: Jeffrey Hugo Signed-off-by

[PATCH] accel/qaic: Use devm_drm_dev_alloc() instead of drm_dev_alloc()

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Since drm_dev_alloc() is deprecated it is recommended to use devm_drm_dev_alloc() instead. Update the driver to start using devm_drm_dev_alloc(). Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Carl Vanderlip Reviewed-by: Jeffrey Hugo Signed-off-b

Re: [PATCH v2 2/2] drm/mediatek: dpi/dsi: fix possible_crtcs calculation

2023-09-01 Thread Nícolas F . R . A . Prado
On Fri, Sep 01, 2023 at 11:59:16AM +0200, Michael Walle wrote: > mtk_drm_find_possible_crtc_by_comp() assumed that the main path will > always have the CRTC with id 0, the ext id 1 and the third id 2. This > is only true if the paths are all available. But paths are optional (see > also comment in

[RFC 0/4] accel/ivpu: Use GEM shmem

2023-09-01 Thread Stanislaw Gruszka
Use GEM shmem for buffer management code Jacek Lawrynowicz (4): accel/ivpu: Allocate vpu_addr in gem->open() callback accel/ivpu: Fix locking in ivpu_bo_remove_all_bos_from_context() accel/ivpu: Remove support for uncached buffers accel/ivpu: Use GEM shmem helper for all buffers drivers/

[RFC 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz gem->open() is called during handle creation for a gem object. It is called during prime import and in BO_CREATE ioctl. Signed-off-by: Jacek Lawrynowicz Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_gem.c | 66 --- drivers

[RFC 2/4] accel/ivpu: Fix locking in ivpu_bo_remove_all_bos_from_context()

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz ivpu_bo_remove_all_bos_from_context() could race with ivpu_bo_free() when prime buffer was closed after vpu device was closed. Move the bo_list from context to vdev and use a dedicated lock to sync it. This list is not modified when BO is added/removed from a context. Al

[RFC 3/4] accel/ivpu: Remove support for uncached buffers

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC. There is no functional benefit from DRM_IVPU_BO_UNCACHED if these buffers are never mapped to host VM. This allows to cut the buffer handling code in the kernel driver by half. Signed-off-by: Jacek Lawr

[RFC 4/4] accel/ivpu: Use GEM shmem helper for all buffers

2023-09-01 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use struct drm_gem_shmem_object as a base for struct ivpu_bo. This cuts by 50% the buffer management code. Signed-off-by: Jacek Lawrynowicz Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/Kconfig| 2 +- drivers/accel/ivpu/TODO | 1 - drivers/accel

[PATCH] drm/tests: Add KUnit tests for drm_fb_blit()

2023-09-01 Thread Arthur Grillo
rt_xrgb_gen_params), KUNIT_CASE_PARAM(drm_test_fb_swab, convert_xrgb_gen_params), + KUNIT_CASE_PARAM(drm_test_fb_xrgb_to_xbgr, convert_xrgb_gen_params), + KUNIT_CASE_PARAM(drm_test_fb_xrgb_to_abgr, convert_xrgb_gen_params), KUNIT_CASE_PARAM(drm_test_fb_clip_offset, clip_offset_gen_params), KUNIT_CASE_PARAM(drm_test_fb_build_fourcc_list, fb_build_fourcc_list_gen_params), KUNIT_CASE_PARAM(drm_test_fb_memcpy, fb_memcpy_gen_params), --- base-commit: 8e455145d8f163aefa6b9cc29478e0a9f82276e6 change-id: 20230901-final-gsoc-395a84443c8f Best regards, -- Arthur Grillo

Re: [GIT PULL] fbdev fixes and updates for v6.6-rc1

2023-09-01 Thread pr-tracker-bot
The pull request you sent on Fri, 1 Sep 2023 10:04:04 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.6-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b84acc11b1c9552c9ca3a099b1610a6018619332 Thank you! -- Deet-

Re: [PATCH] fbdev: Update fbdev source file paths

2023-09-01 Thread Jonathan Neuschäfer
On Thu, Aug 31, 2023 at 11:49:47PM +0200, Helge Deller wrote: > On 8/31/23 11:02, Helge Deller wrote: > > On 8/31/23 10:51, Daniel Vetter wrote: > > > On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote: > > > > On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: > >

[PATCH 0/7] accel/qaic: Extend uAPI to support undoing ATTACH_SLICE_BO

2023-09-01 Thread Jeffrey Hugo
A BO for a QAIC device has two states - 1. Allocated 2. Sliced A BO can be allocated at any time, and is initialized in the allocated state. A BO can transition to the sliced state via ATTACH_SLICE_BO. This prepares the BO for use with an active workload. Currently a BO in the sliced state can o

[PATCH 1/7] accel/qaic: Remove ->size field from struct qaic_bo

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya ->size field in struct qaic_bo stores user requested buffer size for allocate path or size of the dmabuf(PRIME). Now for allocate path driver allocates a BO of size which is PAGE_SIZE aligned, this size is already stored in base BO structure (struct drm_gem_obj

[PATCH 2/7] accel/qaic: Update BO metadata in a central location

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Update/Clean up BO metadata in a central location, this will help maintain the code and looks cleaner. Use qaic_unprepare_bo() to cleanup release_dbc() Next few patches will be implementing detach IOCTL which will leverage this patch. Signed-off-by: Pranjal

[PATCH 3/7] accel/qaic: Declare BO 'sliced' after all the operations are complete

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Once the BO is declared 'sliced' by setting bo->sliced to true we can perform DMA (QAIC_EXECUTE_BO) operation on that BO. Hence we should declare a BO sliced after completing all the operations. Adding BO to its respective DBC list in qaic_attach_slicing_bo()

[PATCH 5/7] accel/qaic: Clean up BO during flushing of transfer list

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Variables that are set while adding the corresponding BO in transfer list should be cleaned when flushing them out of transfer list prematurely. After this patch we do not need some of the cleanup done in release_dbc() This patch would also pave the way to ha

[PATCH 6/7] accel/qaic: Create a function to initialize BO

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya This makes sure that we have a single place to initialize and re-initialize BO. Use this new API to cleanup release_dbc() We will need this for next patch to detach slicing to a BO. Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Jeffrey Hugo Sig

[PATCH 4/7] accel/qaic: Undo slicing setup done in qaic_attach_slicing_bo()

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya qaic_attach_slicing_bo() updates slicing config on BO. Use the existing function qaic_free_slices_bo() to remove slicing config done in qaic_attach_slicing_bo(). Use qaic_free_slices_bo() to cleanup release_dbc() This would be helpful when we introduce a new

[PATCH 7/7] accel/qaic: Add QAIC_DETACH_SLICE_BO IOCTL

2023-09-01 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Once a BO is attached with slicing configuration that BO can only be used for that particular setting. With this new feature user can detach slicing configuration off an already sliced BO and attach new slicing configuration using QAIC_ATTACH_SLICE_BO. This wi

  1   2   >