Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-08-31 Thread Chen-Yu Tsai
On Wed, Aug 30, 2023 at 7:11 PM Michael Walle wrote: > > >> While digging through the code I realized that all the outputs and > >> pipelines > >> are harcoded. Doh. For all the mediatek SoCs. Looks like major > >> restriction > >> to > >> me. E.g. there is also DSI and HDMI output on the mt8195.

Re: [PATCH] drm/mediatek: Add spinlock for setting vblank event in atomic_begin

2023-08-31 Thread Fei Shao
On Tue, Aug 22, 2023 at 10:27 PM Jason-JH.Lin wrote: > > Add spinlock protection to avoid race condition on vblank event > between mtk_drm_crtc_atomic_begin() and mtk_drm_finish_page_flip(). > > Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") > Signed-off-by: Jason-JH

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-31 Thread Maxime Ripard
On Wed, Aug 30, 2023 at 04:10:20PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Aug 29, 2023 at 1:38 AM Maxime Ripard wrote: > > > > On Mon, Aug 28, 2023 at 09:06:29AM -0700, Doug Anderson wrote: > > > > > Shutdown is called any time you reboot a device. That means that if a > > > > > DRM driver

Re: [PATCH v2 1/8] drm/dumb-buffers: Fix drm_mode_create_dumb() for bpp < 8

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: drm_mode_create_dumb() calculates the number of characters per pixel from the number of bits per pixel by rounding up, which is not correct as the actual value of cpp may be non-integer. While we do not need to care here about complex formats

Re: [PATCH v2 1/8] drm/dumb-buffers: Fix drm_mode_create_dumb() for bpp < 8

2023-08-31 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Aug 31, 2023 at 9:40 AM Thomas Zimmermann wrote: > Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: > > drm_mode_create_dumb() calculates the number of characters per pixel > > from the number of bits per pixel by rounding up, which is not correct > > as the actual value of cpp

Re: [git pull] drm CI integration

2023-08-31 Thread Daniel Vetter
On Thu, 31 Aug 2023 at 03:00, Dave Airlie wrote: > > Hey Linus, > > This is a PR to add drm-ci support files to the upstream tree. > This is a bunch of ci integration for the freedesktop gitlab instance > where we currently do upstream userspace testing on diverse sets of GPU > hardware. From my p

Re: [PATCH v2 4/8] drm/ssd130x: Add support for DRM_FORMAT_R1

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: The native display format is monochrome light-on-dark (R1). Hence add support for R1, so monochrome applications not only look better, but also avoid the overhead of back-and-forth conversions between R1 and XR24. Do not allocate the intermedi

Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display

2023-08-31 Thread Daniel Vetter
On Thu, 31 Aug 2023 at 08:33, Mikko Perttunen wrote: > > On 8/30/23 13:19, Thomas Zimmermann wrote: > > Hi > > > > Am 25.08.23 um 15:22 schrieb Thierry Reding: > >> From: Thierry Reding > >> > >> Tegra DRM doesn't support display on Tegra234 and later, so make sure > >> not to remove any existing

Re: [PATCH v4 3/4] drm/mediatek: Fix unintentional integer overflow in multiplying different types

2023-08-31 Thread Fei Shao
On Fri, Jul 14, 2023 at 6:59 PM Jason-JH.Lin wrote: > > 1. Instead of multiplying 2 variable of different types. Change to > assign a value of one variable and then multiply the other variable. > > 2. Add a int variable for multiplier calculation instead of calculating > different types multiplier

[PATCH v6 0/4] Drop ID table and conditionals around of_node pointers

2023-08-31 Thread Biju Das
This patch series aims to drop ID table and conditionals around of_node pointers for anx78xx driver. While at it, drop CONFIG_OF conditionals around of_node pointers from drm_bridge.h and all the drm/bridge drivers. v5->v6: * Dropped CONFIG_OF conditionals from all bridge drivers. * Added Rb ta

[PATCH v6 1/4] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-31 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das Reviewed-

[PATCH v6 2/4] drm/bridge: Drop conditionals around of_node pointers

2023-08-31 Thread Biju Das
This patch is based on commit c9e358dfc4a8 ("driver-core: remove conditionals around devicetree pointers"). Having conditional around the of_node pointer of the drm_bridge structure turns out to make driver code use ugly #ifdef blocks. Drop the conditionals to simplify drivers. While this slightly

[PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Biju Das
Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das Reviewed-by: Douglas Anderson --- v5->v6: * Added Rb tag from Douglas Anderson. * Dropped conditionals

[PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

2023-08-31 Thread Biju Das
Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and drmm_of_get_bridge() as it is guarded with #if..#else blocks in drm_bridge.h. Signed-off-by: Biju Das --- v6: * New patch. --- drivers/gpu/drm/bridge/panel.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/

Re: [PATCH v2 5/8] drm/client: Convert drm_client_buffer_addfb() to drm_mode_addfb2()

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:22 schrieb Geert Uytterhoeven: Hi Daniel, On Thu, Aug 24, 2023 at 5:12 PM Daniel Stone wrote: On Thu, 24 Aug 2023 at 16:09, Geert Uytterhoeven wrote: struct drm_client_dev *client = buffer->client; - struct drm_mode_fb_cmd fb_req = { }; - const stru

Re: [PATCH v2 4/8] drm/ssd130x: Add support for DRM_FORMAT_R1

2023-08-31 Thread Geert Uytterhoeven
Hi Thomas, On Thu, Aug 31, 2023 at 10:01 AM Thomas Zimmermann wrote: > Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: > > The native display format is monochrome light-on-dark (R1). > > Hence add support for R1, so monochrome applications not only look > > better, but also avoid the overhead of

Re: [PATCH v2 6/8] drm/fb-helper: Pass buffer format via drm_fb_helper_surface_size

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: drm_fb_helper_single_fb_probe() first calls drm_fb_helper_find_sizes(), followed by drm_fbdev_generic_helper_fb_probe(): - The former tries to find a suitable buffer format, taking into account limitations of the whole display pipeline,

Re: [PATCH 1/4] drm/doc/rfc: No STAGING out of drivers/staging.

2023-08-31 Thread Daniel Vetter
On Tue, Aug 29, 2023 at 12:30:01PM -0400, Rodrigo Vivi wrote: > Also the uapi should be reviewed and scrutinized before xe > is accepted upstream and we shouldn't cause regression. > > Link: > https://lore.kernel.org/all/20230630100059.122881-1-thomas.hellst...@linux.intel.com > Signed-off-by: Ro

Re: [PATCH] fbdev: Update fbdev source file paths

2023-08-31 Thread Daniel Vetter
On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote: > On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer: > > > The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and > > > fbcmap.c were move

Re: [PATCH v2 7/8] drm/fb-helper: Add support for DRM_FORMAT_R1

2023-08-31 Thread Thomas Zimmermann
Hi Am 24.08.23 um 17:08 schrieb Geert Uytterhoeven: Add support for the monochrome light-on-dark buffer format (R1) to the fb helper, so this format can be used for fbdev emulation and for the text console. This avoids the overhead of using XR24 and the associated conversions on display hardwar

Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-08-31 Thread Andy Shevchenko
On Wed, Aug 30, 2023 at 10:15 PM wrote: > On Wed, 2023-08-30 at 17:29 +0300, Andy Shevchenko wrote: > > On Wed, Aug 30, 2023 at 5:19 PM wrote: > > > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > > > > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner > > > > > > > > wrote: ... > >

Re: [PATCH] fbdev: Update fbdev source file paths

2023-08-31 Thread Helge Deller
On 8/31/23 10:51, Daniel Vetter wrote: On Thu, Aug 31, 2023 at 08:44:59AM +0200, Jonathan Neuschäfer wrote: On Wed, Aug 30, 2023 at 09:10:26AM +0200, Thomas Zimmermann wrote: Hi Am 29.08.23 um 22:02 schrieb Jonathan Neuschäfer: The files fbmem.c, fb_defio.c, fbsysfs.c, fbmon.c, modedb.c, and

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Intel
Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote: On 8/30/23 14:49, Danilo Krummrich wrote: Hi Thomas, thanks for having a look! On Wed, Aug 30, 2023 at 09:27:45AM +0200, Thomas Hellström (Intel) wrote: Hi, Danilo. Some

Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das >

Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

2023-08-31 Thread Laurent Pinchart
On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote: > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() and > drmm_of_get_bridge() as it is guarded with #if..#else blocks in > drm_bridge.h. This will increase the kernel size on non-OF system, to add functions that are no

Re: nouveau bug in linux/6.1.38-2

2023-08-31 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux kernel regression tracking. See link in footer if these mails annoy you.] On 04.08.23 14:02, Thorsten Leemhuis wrote: > On 02.08.23 23:28, Olaf Skibbe wrote: >> Dear Maintainers, >> >> Hereby I would like to report an apparent bug in the nouveau dri

Re: [PATCH v3 0/4] cleanups for lockless slab shrink

2023-08-31 Thread Qi Zheng
On 2023/8/24 11:35, Qi Zheng wrote: Hi all, This series is some cleanups split from the previous patchset[1], I dropped the [PATCH v2 5/5] which is more related to the main lockless patch. This series is based on the next-20230823. Comments and suggestions are welcome. [1]. https://lore.k

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Christian König
Am 30.08.23 um 20:53 schrieb Chia-I Wu: On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to update page tables, vm update fences are unused. Install stub fence into these fence pointers instead of NUL

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Wed, Aug 30, 2023 at 11:53:29AM -0700, Chia-I Wu wrote: > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > > From: Lang Yu > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > When using cpu to update page tables, vm update fences are unused. > > Install stub fe

Re: [Intel-gfx] [PATCH 10/12] drm/i915/hdmi: Nuke hdmi->ddc_bus

2023-08-31 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the mostly redundant hdmi->ddc_bus. The only thing that needs > it anymore is get_encoder_by_ddc_bus(), but that can be replaced with > a slight detour through attached_connector+intel_gmbus_get_adapter(). > > Signed-off-b

Re: [Intel-gfx] [PATCH 11/12] drm/i915/hdmi: Remove old i2c symlink

2023-08-31 Thread Jani Nikula
On Tue, 29 Aug 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Remove the i915 specific i2c-N symlink from HDMI connectors. > This was added to sort of mirror the DP connectors that alreayd > had their aux ch based i2c adapter sitting beneath them in the > sysfs hierarchy. But now that we ha

[PATCH v2 03/12] drm/i915: Call the DDC bus i2c adapter "ddc"

2023-08-31 Thread Ville Syrjala
From: Ville Syrjälä Rename the various names we've used for the DDC bus i2c adapter ("i2c", "adapter", etc.) to just "ddc". This differentiates it from the various other i2c busses we might have (DSI panel stuff, DVO control bus, etc.). v2: Don't add a bogus drm_get_edid() call (Jani) Reviewed-

RE: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

2023-08-31 Thread Biju Das
Hi Laurent Pinchart, > Subject: Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional > around *_of_get_bridge() > > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote: > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() > > and > > drmm_of_get_bridge() as

[PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Jani Nikula
In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Jani Nikula --- v2: rephrase comments, in par

Re: [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Jani Nikula
On Wed, 30 Aug 2023, Hans Verkuil wrote: > On 24/08/2023 15:46, Jani Nikula wrote: >> In the drm subsystem, the source physical address is, in most cases, >> available without having to parse the EDID again. Add notes about >> preferring to use the pre-parsed address instead. >> >> Cc: Hans Verku

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > From: Lang Yu > > > > > > [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] > > > > > > When using cpu to update pag

[PATCH 0/3] Improve test coverage of TTM

2023-08-31 Thread Karolina Stolarek
Add tests for building blocks of the TTM subsystem, such as ttm_resource, ttm_resource_manager, ttm_tt and ttm_buffer_object. This series covers basic functions such as initialization, allocation and clean-up of each struct. Testing of ttm_buffer_object also includes locking and unlocking the objec

[PATCH 3/3] drm/ttm/tests: Add tests for ttm_bo functions

2023-08-31 Thread Karolina Stolarek
Test reservation and release of TTM buffer objects. Add tests to check pin and unpin operations. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 616 ++ drivers/gpu/drm/ttm/tests/ttm_kunit

[PATCH 1/3] drm/ttm/tests: Add tests for ttm_resource and ttm_sys_man

2023-08-31 Thread Karolina Stolarek
Test initialization of ttm_resource using different memory domains. Add tests for a system memory manager and functions that can be tested without a fully-featured resource manager. Update ttm_bo_kunit_init() to initialize BO's kref and reservation object. Signed-off-by: Karolina Stolarek --- dr

[PATCH 2/3] drm/ttm/tests: Add tests for ttm_tt

2023-08-31 Thread Karolina Stolarek
Test initialization, creation and destruction of ttm_tt instances. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Makefile| 1 + drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 20 ++ drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 277 ++ 3 files c

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Danilo Krummrich
On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: > Hi! > > On 8/30/23 17:00, Danilo Krummrich wrote: > > On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote: > > > On 8/30/23 14:49, Danilo Krummrich wrote: > > > > Hi Thomas, > > > > > > > > thanks for

Re: [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Hans Verkuil
On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-of

[PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

2023-08-31 Thread Geert Uytterhoeven
The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo are flags that can have only two possible values: 0 and 1. Reduce kernel size by changing their types from int to bool. Signed-off-by: Geert Uytterhoeven --- drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1 file changed, 2 inser

Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-08-31 Thread Philipp Stanner
On Thu, 2023-08-31 at 11:59 +0300, Andy Shevchenko wrote: > On Wed, Aug 30, 2023 at 10:15 PM wrote: > > On Wed, 2023-08-30 at 17:29 +0300, Andy Shevchenko wrote: > > > On Wed, Aug 30, 2023 at 5:19 PM wrote: > > > > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > > > > > On Wed, Aug 30

Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-08-31 Thread Philipp Stanner
On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner > wrote: > > > > Currently, user array duplications are sometimes done without an > > overflow check. Sometimes the checks are done manually; sometimes > > the > > array size is calculated

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-31 Thread Nishanth Menon
On 16:35-20230828, Helen Mae Koike Fornazier wrote: > On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote: > > > Fix the NULL pointer dereference when no monitor is connected, and the > > sound card is opened from userspace. > > > > Instead return an error as EDID information cannot be provid

Re: [PATCH] accel/habanalabs: refactor deprecated strncpy to strscpy_pad

2023-08-31 Thread Oded Gabbay
On Sat, Aug 26, 2023 at 1:13 AM Kees Cook wrote: > > On Fri, Aug 25, 2023 at 10:09:51PM +, Justin Stitt wrote: > > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > > > We see that `prop->cpucp_info.card_name` is supposed to be > > NUL-terminated based on its usage

Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 3:22 PM Philipp Stanner wrote: > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner > > wrote: ... > > I'm wondering if this has no side-effects as string.h/string.c IIRC > > is used also for early stages where s

Re: [PATCH 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 4:16 PM Andy Shevchenko wrote: > On Thu, Aug 31, 2023 at 3:22 PM Philipp Stanner wrote: > > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > > > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner > > > wrote: ... > > > I'm wondering if this has no side-effects a

Re: [PATCH v2 15/15] drm/panthor: Add an entry to MAINTAINERS

2023-08-31 Thread Liviu Dudau
Hi Boris, On Wed, Aug 09, 2023 at 06:53:28PM +0200, Boris Brezillon wrote: > Add an entry for the Panthor driver to the MAINTAINERS file. > > v2: > - New commit > > Signed-off-by: Boris Brezillon > --- > > If anyone from Arm wants to volunteer to become a co-maintainer, that > would be highly

Re: [PATCH v2 15/15] drm/panthor: Add an entry to MAINTAINERS

2023-08-31 Thread Boris Brezillon
On Thu, 31 Aug 2023 14:18:42 +0100 Liviu Dudau wrote: > Hi Boris, > > On Wed, Aug 09, 2023 at 06:53:28PM +0200, Boris Brezillon wrote: > > Add an entry for the Panthor driver to the MAINTAINERS file. > > > > v2: > > - New commit > > > > Signed-off-by: Boris Brezillon > > --- > > > > If anyon

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Christian König
Am 31.08.23 um 12:56 schrieb Greg KH: On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: Am 30.08.23 um 20:53 schrieb Chia-I Wu: On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: From: Lang Yu [ Upstream commit 187916e6ed9d0c3b3abc27429f7a5f8c936bd1f0 ] When using cpu to upd

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-31 Thread Andi Shyti
Hi, > > > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > index a0e3ef1c65d2..600388c849f7 100644 > > > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c > > > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc

Re: [PATCH v2 0/2] Merge all debug module parameters

2023-08-31 Thread Helen Koike
Hi André, Thanks for your patches. On 30/08/2023 19:08, André Almeida wrote: As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: Maybe we can overload the amdgpu_gpu_recovery module option with this. Or even be

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Greg KH
On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > Am 31.08.23 um 12:56 schrieb Greg KH: > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > On Sun, Jul 23, 2023 at 6:24 PM Sasha Levin wrote: > > > > > From: Lan

Re: [PATCH v2 12/15] drm/panthor: Add the driver frontend block

2023-08-31 Thread Steven Price
On 29/08/2023 18:46, Boris Brezillon wrote: > On Mon, 21 Aug 2023 12:31:29 +0100 > Steven Price wrote: > >> On 09/08/2023 17:53, Boris Brezillon wrote: [...] >>> + * // Collect signal operations on all jobs, such that each job can pick >>> + * // from it for its dependencies and update the fenc

Re: [PATCH v2] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-31 Thread Steven Price
On 22/08/2023 06:25, Dmitry Osipenko wrote: > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyssa, who left Coll

RE: [PATCH v1 2/2] backlight: mp3309c: Add support for MPS MP3309C

2023-08-31 Thread Flavio Suligoi
HI Daniel, > -Original Message- > From: Daniel Thompson > Sent: Tuesday, August 29, 2023 6:28 PM > To: Flavio Suligoi > Cc: Lee Jones ; Jingoo Han ; Helge > Deller ; Pavel Machek ; Rob Herring > ; Krzysztof Kozlowski > ; Conor Dooley ; > dri-devel@lists.freedesktop.org; linux-l...@vger.k

Re: [RFC PATCH v2 02/11] netdev: implement netlink api to bind dma-buf to netdevice

2023-08-31 Thread Yunsheng Lin
On 2023/8/10 9:57, Mina Almasry wrote: ... > + > +int netdev_bind_dmabuf_to_queue(struct net_device *dev, unsigned int > dmabuf_fd, > + u32 rxq_idx, struct netdev_dmabuf_binding **out) > +{ > + struct netdev_dmabuf_binding *binding; > + struct netdev_rx_queue

RE: [PATCH v1 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-08-31 Thread Flavio Suligoi
Hi Krzysztof, ... > >>> + > >>> + reg: > >>> +maxItems: 1 > >>> + > >>> + mps,dimming-mode: > >>> +description: The dimming mode (PWM or analog by I2C commands). > >>> +$ref: '/schemas/types.yaml#/definitions/string' > >> > >> Drop quotes, you should see warnings for this. > >> > >>

[PATCH] drm/amd/pm: Replace 1-element arrays with flexible array members

2023-08-31 Thread Samuel Holland
Since commit df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"), UBSAN_BOUNDS no longer pretends 1-element arrays are unbounded. The bounds check is tripped in smu7_get_pp_table_entry_callback_func_v1(), while reading from mclk_dep_table. For consistency, fix all affected struct definitions in

[PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Dembskiy Igor
It does not make sense to compare a pointer to array element with NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable fbc") Signed-off-by: Dembskiy Igor --- drivers/gpu/drm/amd/display/dc/dce110/d

Refcounting in drm_exec

2023-08-31 Thread Thomas Hellström
Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? I'm asking because refcounting appears only strictly necessary for contended- and prelocked objects, and callers would otherwis

Re: Refcounting in drm_exec

2023-08-31 Thread Christian König
Hi Thomas, Am 31.08.23 um 17:12 schrieb Thomas Hellström: Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? Yes, that's one of the motivations for this component. I'm asking

[PATCH v3 0/2] Merge all debug module parameters

2023-08-31 Thread André Almeida
As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: > Maybe we can overload the amdgpu_gpu_recovery module option with this. > Or even better merge all the developer module parameter into a > amdgpu_debug option.

[PATCH v3 1/2] drm/amdgpu: Merge debug module parameters

2023-08-31 Thread André Almeida
Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida Reviewed-by: Christian König --- v3: - move from include/amd_shared.h to amdgpu/a

[PATCH v3 2/2] drm/amdgpu: Create an option to disable soft recovery

2023-08-31 Thread André Almeida
Create a module option to disable soft recoveries on amdgpu, making every recovery go through the device reset path. This option makes easier to force device resets for testing and debugging purposes. Signed-off-by: André Almeida Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgp

Re: Refcounting in drm_exec

2023-08-31 Thread Thomas Hellström
On 8/31/23 17:19, Christian König wrote: Hi Thomas, Am 31.08.23 um 17:12 schrieb Thomas Hellström: Hi, Christian, Danilo Looking at the drm_exec code it seems we refcount *all* locked objects until drm_exec_fini(). Are callers supposed to be able to *rely* on this? Yes, that's one of the

Re: [PATCH v2 1/6] drm/panfrost: Add cycle count GPU register definitions

2023-08-31 Thread Steven Price
On 24/08/2023 02:34, Adrián Larumbe wrote: > These GPU registers will be used when programming the cycle counter, which > we need for providing accurate fdinfo drm-cycles values to user space. > > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfros

Re: [PATCH v2 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-08-31 Thread Steven Price
On 24/08/2023 02:34, Adrián Larumbe wrote: > The drm-stats fdinfo tags made available to user space are drm-engine, > drm-cycles, drm-max-freq and drm-curfreq, one per job slot. > > This deviates from standard practice in other DRM drivers, where a single > set of key:value pairs is provided for t

[PATCH v2] drm/amd/display: enable cursor degamma for DCN3+ DRM legacy gamma

2023-08-31 Thread Melissa Wen
For DRM legacy gamma, AMD display manager applies implicit sRGB degamma using a pre-defined sRGB transfer function. It works fine for DCN2 family where degamma ROM and custom curves go to the same color block. But, on DCN3+, degamma is split into two blocks: degamma ROM for pre-defined TFs and `gam

Re: [PATCH v6 4/4] drm/bridge: panel: Drop CONFIG_OF conditional around *_of_get_bridge()

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 10:47:24AM +, Biju Das wrote: > > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote: ... > > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() > > > and > > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in > > > drm_bridge

Re: [PATCH v6 3/4] drm/bridge: Drop CONFIG_OF conditionals around of_node pointers

2023-08-31 Thread Andy Shevchenko
On Thu, Aug 31, 2023 at 09:09:37AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. ... > anx78xx->bridge.of_node = client->dev.of_node; > panel_bridge->bridge.of_node = p

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Intel
Hi, On 8/31/23 13:18, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote: On 8/30/23 14:49, Danilo Krummrich wrote: Hi Thomas

Re: [PATCH 1/6] drm/edid: add drm_edid_is_digital()

2023-08-31 Thread Ville Syrjälä
On Thu, Aug 24, 2023 at 04:46:02PM +0300, Jani Nikula wrote: > Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to > deserve a helper that also lets us abstract the raw EDID a bit better. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Thomas Hellström
On 8/31/23 18:53, Thomas Hellström (Intel) wrote: Hi, On 8/31/23 13:18, Danilo Krummrich wrote: On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: Hi! On 8/30/23 17:00, Danilo Krummrich wrote: On Wed, Aug 30, 2023 at 03:42:08PM +0200, Thomas Hellström (Intel) wrote:

Re: [Intel-gfx] [PATCH 2/6] drm/i915/display: use drm_edid_is_digital()

2023-08-31 Thread Ville Syrjälä
On Thu, Aug 24, 2023 at 04:46:03PM +0300, Jani Nikula wrote: > Reduce the use of struct edid and drm_edid_raw(). > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_crt.c | 11 --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 9 - > drivers/gpu/drm/i915/d

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : > Hi, > > there's a per-architecture function called fb_pgprotect() that sets > VMA's vm_page_prot for mmaped framebuffers. Most architectures use a > simple implementation based on pgprot_writecomine() [1] or > pgprot_noncached(). [2] > > O

Re: [PATCH] fbdev: ssd1307fb: Use bool for ssd1307fb_deviceinfo flags

2023-08-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > The .need_pwm and .need_chargepump fields in struct ssd1307fb_deviceinfo > are flags that can have only two possible values: 0 and 1. > Reduce kernel size by changing their types from int to bool. > > Signed-off-by: Geert Uytterhoeven > --- Acked-by: Javier Martinez

Re: Framebuffer mmap on PowerPC

2023-08-31 Thread Christophe Leroy
Le 31/08/2023 à 19:38, Christophe Leroy a écrit : > > > Le 31/08/2023 à 16:41, Thomas Zimmermann a écrit : >> Hi, >> >> there's a per-architecture function called fb_pgprotect() that sets >> VMA's vm_page_prot for mmaped framebuffers. Most architectures use a >> simple implementation based on

Re: [PATCH v2 1/2] drm/amdgpu: Merge debug module parameters

2023-08-31 Thread Felix Kuehling
On 2023-08-30 18:08, André Almeida wrote: Merge all developer debug options available as separated module parameters in one, making it obvious that are for developers. Drop the obsolete module options in favor of the new ones. Signed-off-by: André Almeida --- v2: - drop old module params - u

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-31 Thread Doug Anderson
Hi, On Thu, Aug 31, 2023 at 12:38 AM Maxime Ripard wrote: > > If so, then I think we can implement everything by doing something like: > > - Implement enable and disable refcounting in panels. > drm_panel_prepare and drm_panel_enable would increase it, > drm_panel_unprepare and drm_pane

Re: [PATCH v7 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper

2023-08-31 Thread Alex Williamson
On Thu, 31 Aug 2023 07:04:10 -0700 Christoph Hellwig wrote: > On Thu, Aug 31, 2023 at 01:51:11PM +, Ankit Agrawal wrote: > > Hi Christoph, > > > > >Whats the actual consumer running in a qemu VM here? > > The primary use case in the VM is to run the open source Nvidia > > driver (https:/

Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Harry Wentland
On 2023-08-30 10:01, Dembskiy Igor wrote: > It does not make sense to compare a pointer to array element with NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 65d38262b3e8 ("drm/amd/display: fbc state could not reach while enable > fbc") > Signed-off-by: Dem

mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

2023-08-31 Thread Sudip Mukherjee (Codethink)
Hi All, The latest mainline kernel branch fails to build mips jazz_defconfig with the error: drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM_OPS'? 115 | FB_DEFAULT_IOMEM_HELPERS, | ^

Re: [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Jani Nikula
On Thu, 24 Aug 2023, Jani Nikula wrote: > Avoid accessing the raw edid directly. Pre-parse the source physical > address during normal EDID parsing and use that for CEC. > > Jani Nikula (6): > drm/edid: add drm_edid_is_digital() > drm/i915/display: use drm_edid_is_digital() > drm/edid: parse

Re: [PATCH AUTOSEL 5.10 13/22] drm/amdgpu: install stub fence into potential unused fence pointers

2023-08-31 Thread Chia-I Wu
On Thu, Aug 31, 2023 at 7:01 AM Greg KH wrote: > > On Thu, Aug 31, 2023 at 03:26:28PM +0200, Christian König wrote: > > Am 31.08.23 um 12:56 schrieb Greg KH: > > > On Thu, Aug 31, 2023 at 12:27:27PM +0200, Christian König wrote: > > > > Am 30.08.23 um 20:53 schrieb Chia-I Wu: > > > > > On Sun, Jul

Re: mainline build failure due to 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")

2023-08-31 Thread Linus Torvalds
On Thu, 31 Aug 2023 at 11:48, Sudip Mukherjee (Codethink) wrote: > The latest mainline kernel branch fails to build mips jazz_defconfig with > the error: > > drivers/video/fbdev/g364fb.c:115:9: error: 'FB_DEFAULT_IOMEM_HELPERS' > undeclared here (not in a function); did you mean 'FB_DEFAULT_IOMEM

Re: [PATCH drm-misc-next 2/3] drm/gpuva_mgr: generalize dma_resv/extobj handling and GEM validation

2023-08-31 Thread Danilo Krummrich
On Thu, Aug 31, 2023 at 06:53:01PM +0200, Thomas Hellström (Intel) wrote: > Hi, > > On 8/31/23 13:18, Danilo Krummrich wrote: > > On Thu, Aug 31, 2023 at 11:04:06AM +0200, Thomas Hellström (Intel) wrote: > > > Hi! > > > > > > On 8/30/23 17:00, Danilo Krummrich wrote: > > > > On Wed, Aug 30, 2023

Re: [PATCH 1/4] drm/doc/rfc: No STAGING out of drivers/staging.

2023-08-31 Thread Rodrigo Vivi
On Thu, Aug 31, 2023 at 10:31:07AM +0200, Daniel Vetter wrote: > On Tue, Aug 29, 2023 at 12:30:01PM -0400, Rodrigo Vivi wrote: > > Also the uapi should be reviewed and scrutinized before xe > > is accepted upstream and we shouldn't cause regression. > > > > Link: > > https://lore.kernel.org/all/2

Re: [PATCH 3/4] drm/doc/rfc: Mark DRM_VM_BIND as complete.

2023-08-31 Thread Rodrigo Vivi
On Tue, Aug 29, 2023 at 12:30:03PM -0400, Rodrigo Vivi wrote: > The consensus is for individual drivers VM_BIND uapis with > the GPUVA helpers that are already implemented and merged > upstream. > > The merged GPUVA documentation also establish some overall > rules for the locking to be followed b

Re: [PATCH] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Harry Wentland
On 2023-08-29 16:10, Hamza Mahfooz wrote: > This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e. > This isn't a straight-up revert. Please split it into a revert (git revert), followed by a patch to limit the revert to < DCN_VERSION_3_1. Harry > We still need to call dcn20_adjust_frees

Re: [PATCH 4/4] drm/doc/rfc: Mark GPU VA as complete.

2023-08-31 Thread Rodrigo Vivi
On Tue, Aug 29, 2023 at 12:30:04PM -0400, Rodrigo Vivi wrote: > Nouveau has landed the GPU VA helpers, support and documentation > already and Xe is already using the upstream GPU VA. Danilo, although this is more on the Xe side and I wouldn't ask you to review our code entirely, I'd like to get y

Re: [PATCH v2] Documentation/gpu: VM_BIND locking document

2023-08-31 Thread Rodrigo Vivi
On Wed, Aug 16, 2023 at 11:15:47AM +0200, Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and for userptr

Re: [PATCH] drm/amd/display: remove useless check in should_enable_fbc()

2023-08-31 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 31, 2023 at 2:48 PM Harry Wentland wrote: > > On 2023-08-30 10:01, Dembskiy Igor wrote: > > It does not make sense to compare a pointer to array element with NULL. > > > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > > > Fixes: 65d38262

[PATCH v2 1/2] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Hamza Mahfooz
This reverts commit 3a31e8b89b7240d9a17ace8a1ed050bdcb560f9e. We still need to call dcn20_adjust_freesync_v_startup() for older DCN3+ ASICs otherwise it can cause DP to HDMI 2.1 PCONs to fail to light up. Cc: sta...@vger.kernel.org Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2809 Signed

[PATCH v2 2/2] drm/amd/display: limit the v_startup workaround for ASICs older than DCN3.1

2023-08-31 Thread Hamza Mahfooz
Since, calling dcn20_adjust_freesync_v_startup() on DCN3.1+ ASICs can cause the display to flicker and underflow to occur we shouldn't call it for them. So, ensure that the DCN version is less than DCN_VERSION_3_1 before calling dcn20_adjust_freesync_v_startup(). Cc: sta...@vger.kernel.org Signed-

Re: [PATCH v2] drm/amd/display: enable cursor degamma for DCN3+ DRM legacy gamma

2023-08-31 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 31, 2023 at 12:12 PM Melissa Wen wrote: > > For DRM legacy gamma, AMD display manager applies implicit sRGB degamma > using a pre-defined sRGB transfer function. It works fine for DCN2 > family where degamma ROM and custom curves go to the same color block. > B

Re: [PATCH v2 1/2] Revert "drm/amd/display: Remove v_startup workaround for dcn3+"

2023-08-31 Thread Zuo, Jerry
[AMD Official Use Only - General] Series is: Reviewed-By: Fangzhi Zuo 发件人: Mahfooz, Hamza 发送时间: 星期四, 八月 31, 2023 3:39:04 下午 收件人: amd-...@lists.freedesktop.org 抄送: Zuo, Jerry ; Mahfooz, Hamza ; sta...@vger.kernel.org ; Wentland, Harry ; Li, Sun peng (Leo) ;

Re: [RFC PATCH 06/10] drm/sched: Submit job before starting TDR

2023-08-31 Thread Luben Tuikov
On 2023-07-31 03:26, Boris Brezillon wrote: > +the PVR devs > > On Mon, 31 Jul 2023 01:00:59 + > Matthew Brost wrote: > >> On Thu, May 04, 2023 at 01:23:05AM -0400, Luben Tuikov wrote: >>> On 2023-04-03 20:22, Matthew Brost wrote: If the TDR is set to a value, it can fire before a job

  1   2   >