Re: [PATCH v3] drm/plane: Add documentation about software color conversion.

2023-08-28 Thread Pekka Paalanen
On Fri, 25 Aug 2023 16:04:18 +0200 Jocelyn Falempe wrote: > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-28 Thread Maxime Ripard
On Fri, Aug 25, 2023 at 02:58:02PM -0700, Doug Anderson wrote: > Maxime, > > On Sun, Aug 6, 2023 at 11:41 PM Maxime Ripard wrote: > > > > Hi Doug, > > > > Thanks for working on this :) > > > > On Fri, Aug 04, 2023 at 02:06:07PM -0700, Douglas Anderson wrote: > > > The goal of this file is to cont

[PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Xueshi Hu
In folio_mark_dirty(), it can automatically fallback to noop_dirty_folio() if a_ops->dirty_folio is not registered. As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove them too. Signed-off-by: Xueshi Hu --- Changes in v2: - make noop_dirty_folio() inline as suggested by Matt

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-28 Thread Maxime Ripard
On Fri, Aug 25, 2023 at 05:07:58PM +0200, Frank Oltmanns wrote: > Thank you for your feedback, Maxime! > > On 2023-08-25 at 10:13:53 +0200, Maxime Ripard wrote: > > [[PGP Signed Part:Undecided]] > > Hi, > > > > On Fri, Aug 25, 2023 at 07:36:36AM +0200, Frank Oltmanns wrote: > >> I would like to m

[v5,0/7] Adds support for ConfigFS to VKMS!

2023-08-28 Thread Brandon Pollack
Since Jim is busy with other work and I'm working on some things that rely on this, I've taken up the task of doing the iterations. I've addressed the comments as best I can (those replies are to each individual change) and here is the patch set to go with those. I added my own signoff to each co

[PATCH v5 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signe

[PATCH v5 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change supports multiple CRTCs, encoders, connectors instead of one of each per device. Since ConfigFS-based devices will support multiple crtcs, it's useful to move all of the writeback/composition data from being per-"output" to being per-CRTC. Since there's still only e

[PATCH v5 3/7] drm/vkms: Provide platform data when creating VKMS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c| 14 -- drivers/gpu/drm/vkms/vkms_drv.h| 9 ++--- drivers/gpu/drm/v

[PATCH v5 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change adds the basic scaffolding for ConfigFS, including setting up the default directories. It does not allow for the registration of configfs-backed devices, which is complex and provided in a follow-up commit. This CL includes docs about using ConfigFS with VKMS, but I'

[PATCH v5 6/7] drm/vkms: Add a module param to enable/disable the default device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the only one that exists. The param, enable_default, is defaulted to tru

[PATCH v5 7/7] drm/vkms Add hotplug support via configfs to VKMS.

2023-08-28 Thread Brandon Pollack
This change adds the ability to read or write a "1" or a "0" to the newly added "connected" attribute of a connector in the vkms entry in configfs. A write will trigger a call to drm_kms_helper_hotplug_event, causing a hotplug uevent. With this we can write virtualized multidisplay tests that inv

[PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_configfs.c | 37

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-28 Thread Pekka Paalanen
On Fri, 25 Aug 2023 13:29:44 -0100 Melissa Wen wrote: > On 08/22, Pekka Paalanen wrote: > > On Thu, 10 Aug 2023 15:02:59 -0100 > > Melissa Wen wrote: > > > > > The next patch adds pre-blending degamma to AMD color mgmt pipeline, but > > > pre-blending degamma caps (DPP) is currently in use to

[PATCH v5 0/7] Adds support for ConfigFS to VKMS!

2023-08-28 Thread Brandon Pollack
Since Jim is busy with other work and I'm working on some things that rely on this, I've taken up the task of doing the iterations. I've addressed the comments as best I can (those replies are to each individual change) and here is the patch set to go with those. I added my own signoff to each co

[PATCH v5 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signe

[PATCH v5 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change supports multiple CRTCs, encoders, connectors instead of one of each per device. Since ConfigFS-based devices will support multiple crtcs, it's useful to move all of the writeback/composition data from being per-"output" to being per-CRTC. Since there's still only e

[PATCH v5 3/7] drm/vkms: Provide platform data when creating VKMS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c| 14 -- drivers/gpu/drm/vkms/vkms_drv.h| 9 ++--- drivers/gpu/drm/v

[PATCH v5 6/7] drm/vkms: Add a module param to enable/disable the default device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the only one that exists. The param, enable_default, is defaulted to tru

[PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_configfs.c | 37

[PATCH v5 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change adds the basic scaffolding for ConfigFS, including setting up the default directories. It does not allow for the registration of configfs-backed devices, which is complex and provided in a follow-up commit. This CL includes docs about using ConfigFS with VKMS, but I'

[PATCH v5 7/7] drm/vkms Add hotplug support via configfs to VKMS.

2023-08-28 Thread Brandon Pollack
This change adds the ability to read or write a "1" or a "0" to the newly added "connected" attribute of a connector in the vkms entry in configfs. A write will trigger a call to drm_kms_helper_hotplug_event, causing a hotplug uevent. With this we can write virtualized multidisplay tests that inv

Re: [PATCH v2 31/34] drm/amd/display: set stream gamut remap matrix to MPC for DCN301

2023-08-28 Thread Pekka Paalanen
On Fri, 25 Aug 2023 13:37:08 -0100 Melissa Wen wrote: > On 08/22, Pekka Paalanen wrote: > > On Thu, 10 Aug 2023 15:03:11 -0100 > > Melissa Wen wrote: > > > > > dc->caps.color.mpc.gamut_remap says there is a post-blending color block > > > for gamut remap matrix for DCN3 HW family and newer ve

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-28 Thread Maxime Ripard
On Sat, Aug 26, 2023 at 11:12:16AM +0200, Frank Oltmanns wrote: > > On 2023-08-25 at 17:07:58 +0200, Frank Oltmanns wrote: > > Thank you for your feedback, Maxime! > > > > On 2023-08-25 at 10:13:53 +0200, Maxime Ripard wrote: > >> [[PGP Signed Part:Undecided]] > >> Hi, > >> > >> On Fri, Aug 25,

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-28 Thread Joshua Ashton
Degamma has always been on the plane on AMD. CRTC DEGAMMA_LUT has actually just been applying it to every plane pre-blend. Degamma makes no sense after blending anyway. The entire point is for it to happen before blending to blend in linear space. Otherwise DEGAMMA_LUT and REGAMMA_LUT are the exac

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-28 Thread neil . armstrong
Hi Jessica, On 25/08/2023 20:37, Jessica Zhang wrote: On 8/21/2023 3:01 AM, neil.armstr...@linaro.org wrote: Hi Maxime, On 21/08/2023 10:17, Maxime Ripard wrote: Hi, On Fri, Aug 18, 2023 at 10:25:48AM +0200, neil.armstr...@linaro.org wrote: On 17/08/2023 20:35, Dmitry Baryshkov wrote: On

Re: [PATCH 00/11] fbdev/sbus: Initializers for struct fb_ops

2023-08-28 Thread Thomas Zimmermann
Hi Sam Am 07.08.23 um 19:11 schrieb Sam Ravnborg: ... Reviewed-by: Sam Ravnborg I completely missed your review. Thanks a lot. I've now pushed the patches to drm-misc-next. Best regards Thomas Sam -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany G

Re: [PATCH v2 01/15] drm/shmem-helper: Make pages_use_count an atomic_t

2023-08-28 Thread Boris Brezillon
On Sat, 19 Aug 2023 05:13:06 +0300 Dmitry Osipenko wrote: > On 8/11/23 16:08, Steven Price wrote: > > On 09/08/2023 17:53, Boris Brezillon wrote: > >> This way we can grab a pages ref without acquiring the resv lock when > >> pages_use_count > 0. Need to implement asynchronous map using the >

Re: [PATCH v15 10/23] locking/refcount, kref: Add kref_put_ww_mutex()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:36 +0300 Dmitry Osipenko wrote: > Introduce kref_put_ww_mutex() helper that will handle the wait-wound > mutex auto-locking on kref_put(). This helper is wanted by DRM drivers > that extensively use dma-reservation locking which in turns uses ww-mutex. > > Signed-off-by

Re: [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:38 +0300 Dmitry Osipenko wrote: > Add separate pages_pin_count for tracking of whether drm-shmem pages are > moveable or not. With the addition of memory shrinker support to drm-shmem, > the pages_use_count will no longer determine whether pages are hard-pinned > in memo

[PATCH v2 0/9] accel/ivpu: Update for -next 2023.08.25

2023-08-28 Thread Stanislaw Gruszka
Update for -next: - various cleanups - begin preparation for conversion to GEM SHMEM - print information about used workarounds v2: Fix compilation without CONFIG_PM Jacek Lawrynowicz (4): accel/ivpu: Remove duplicated error messages accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init() acce

[PATCH v2 1/9] accel/ivpu: Move set autosuspend delay to HW specific code

2023-08-28 Thread Stanislaw Gruszka
From: Krystian Pradzynski Configure autosuspend values per HW generation and per platform. For non silicon platforms disable autosuspend for now, for silicon reduce it to 10 ms. Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/ac

[PATCH v2 2/9] accel/ivpu: Remove duplicated error messages

2023-08-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Reduce the number of error messages per single failure in ivpu_dev_init(). Error messages are already printed by functions called from ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/i

[PATCH v2 3/9] accel/ivpu: Print information about used workarounds

2023-08-28 Thread Stanislaw Gruszka
Use ivpu_dbg(MISC) to print information about workarounds. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.h | 5 + drivers/accel/ivpu/ivpu_hw_37xx.c | 5 + drivers/accel/ivpu/ivpu_hw_40xx.c | 4 3 files changed, 14 insertions(+) d

[PATCH v2 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()

2023-08-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz ivpu_fw_load() doesn't have to be called separately in ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 drivers/accel/ivpu/ivpu_fw.c | 6 +++--- drivers/accel

[PATCH v2 4/9] accel/ivpu: Initialize context with SSID = 1

2023-08-28 Thread Stanislaw Gruszka
From: Karol Wachowski Context with SSID = 1 is reserved and accesses on that context happen only when context is uninitialized on the VPU side. Such access triggers MMU fault (0xa) "Invalid CD Fetch", which doesn't contain any useful information besides context ID. This commit will change that s

[PATCH v2 7/9] accel/ivpu/37xx: Change register rename leftovers

2023-08-28 Thread Stanislaw Gruszka
Change remaining MTL_VPU_ register names to generation based names. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx.c | 68 - drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 72 +-- 2 files changed, 70

[PATCH v2 8/9] accel/ivpu/37xx: White space cleanup

2023-08-28 Thread Stanislaw Gruszka
No functional change, adjust code formatting after previous changes. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 100 +- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_

[PATCH v2 9/9] accel/ivpu: Move MMU register definitions to ivpu_mmu.c

2023-08-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz MMU registers are not platform specific so they should be defined separate to platform regs. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_hw_37xx_reg.h | 33 drivers/accel/ivpu/i

[PATCH v2 6/9] accel/ivpu: Add ivpu_bo_vaddr() and ivpu_bo_size()

2023-08-28 Thread Stanislaw Gruszka
From: Jacek Lawrynowicz Use: - ivpu_bo_vaddr(bo) instead of bo->kvaddr - ivpu_bo_size(bo) instead of bo->base.size This is a preparation for switch to a drm_gem_shmem_object as a base for ivpu_bo, where: - bo->kvaddr becomes bo->base.vaddr - bo->base.size becomes bo->base.base.size Usin

Re: [PATCH v15 16/23] drm/shmem-helper: Use kref for vmap_use_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:42 +0300 Dmitry Osipenko wrote: > Use kref helper for vmap_use_count to make refcounting consistent with > pages_use_count and pages_pin_count that use kref. This will allow to > optimize unlocked vmappings by skipping reservation locking if refcnt > 1. The core is taki

Re: [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:43 +0300 Dmitry Osipenko wrote: > In a preparation of adding drm-shmem memory shrinker, move all reservation > locking lockdep checks to use new drm_gem_shmem_resv_assert_held() that > will resolve spurious lockdep warning about wrong locking order vs > fs_reclam code pa

Re: [PATCH v15 11/23] dma-resv: Add kref_put_dma_resv()

2023-08-28 Thread Christian König
Am 27.08.23 um 19:54 schrieb Dmitry Osipenko: Add simple kref_put_dma_resv() helper that wraps around kref_put_ww_mutex() for drivers that needs to lock dma-resv on kref_put(). It's not possible to easily add this helper to kref.h because of the headers inclusion dependency, hence add it to dma-

[PATCH 6.4 073/129] drm/i915: Fix HPD polling, reenabling the output poll work as needed

2023-08-28 Thread Greg Kroah-Hartman
6.4-stable review patch. If anyone has any objections, please let me know. -- From: Imre Deak commit 1dcc437427bbcebc8381226352f7ade08a271191 upstream. After the commit in the Fixes: line below, HPD polling stopped working on i915, since after that change calling drm_kms_helpe

[PATCH 6.4 069/129] drm: Add an HPD poll helper to reschedule the poll work

2023-08-28 Thread Greg Kroah-Hartman
6.4-stable review patch. If anyone has any objections, please let me know. -- From: Imre Deak commit a94e7ccfc400c024976f3c2f31689ed843498b7c upstream. Add a helper to reschedule drm_mode_config::output_poll_work after polling has been enabled for a connector (and needing a re

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-28 Thread Pekka Paalanen
On Mon, 28 Aug 2023 09:45:44 +0100 Joshua Ashton wrote: > Degamma has always been on the plane on AMD. CRTC DEGAMMA_LUT has actually > just been applying it to every plane pre-blend. I've never seen that documented anywhere. It has seemed obvious, that since we have KMS objects for planes and C

Re: [PATCH v15 02/23] drm/shmem-helper: Use flag for tracking page count bumped by get_pages_sgt()

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:28 +0300 Dmitry Osipenko wrote: > Use separate flag for tracking page count bumped by shmem->sgt to avoid > imbalanced page counter during of drm_gem_shmem_free() time. It's fragile > to assume that populated shmem->pages at a freeing time means that the > count was bump

Re: [PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Jan Kara
On Mon 28-08-23 15:54:49, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. > > Signed-off-by: Xueshi Hu Looks good to

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-28 Thread Aradhya Bhatia
Hi Jai, Thanks for debugging the issue. On 25-Aug-23 16:32, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is no

Re: [PATCH 1/2] dt-bindings: display/panel: Add AUO G156HAN04.0 LVDS display

2023-08-28 Thread Krzysztof Kozlowski
On 28/08/2023 11:49, Elmar Albert wrote: > From: Elmar Albert > > Document support for the AUO G156HAN04.0 LVDS display. > > G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of > a TFT LCD panel, a driver circuit, and LED backlight system. The screen > format is intended to s

Re: [PATCH v15 01/23] drm/shmem-helper: Fix UAF in error path when freeing SGT of imported GEM

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:27 +0300 Dmitry Osipenko wrote: > Freeing drm-shmem GEM right after creating it using > drm_gem_shmem_prime_import_sg_table() frees SGT of the imported dma-buf > and then dma-buf frees this SGT second time. > > The v3d_prime_import_sg_table() is example of a error code

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-28 Thread Andy Shevchenko
On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. ... > -#ifdef CONFIG_OF > /** @of_node: device node pointer to the bridge */ > struct de

Re: [PATCH v4 1/2] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-28 Thread Andy Shevchenko
On Sat, Aug 26, 2023 at 08:19:00AM +0100, Biju Das wrote: > The driver has an ID table, but it uses the wrong API for retrieving match > data and that will lead to a crash, if it is instantiated by user space or > using ID. From this, there is no user for the ID table and let's drop it > from the d

Re: [PATCH v15 03/23] drm/gem: Change locked/unlocked postfix of drm_gem_v/unmap() function names

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:29 +0300 Dmitry Osipenko wrote: > Make drm/gem API function names consistent by having locked function > use the _locked postfix in the name, while the unlocked variants don't > use the _unlocked postfix. Rename drm_gem_v/unmap() function names to > make them consistent

Re: [PATCH v15 04/23] drm/gem: Add _locked postfix to functions that have unlocked counterpart

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:30 +0300 Dmitry Osipenko wrote: > Add _locked postfix to drm_gem functions that have unlocked counterpart > functions to make GEM functions naming more consistent and intuitive in > regards to the locking requirements. > > Suggested-by: Boris Brezillon > Signed-off-by:

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-28 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. > > Suggested-by: Douglas Anderson > Signed-off-by: Biju Das >

Re: [PATCH v15 08/23] drm/shmem-helper: Refactor locked/unlocked functions

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:34 +0300 Dmitry Osipenko wrote: > Add locked and remove unlocked postfixes from drm-shmem function names, > making names consistent with the drm/gem core code. > > Suggested-by: Boris Brezillon > Signed-off-by: Dmitry Osipenko Reviewed-by: Boris Brezillon > --- >

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-28 Thread Laurent Pinchart
On Mon, Aug 28, 2023 at 02:17:02PM +0300, Andy Shevchenko wrote: > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > Having conditional around the of_node pointers turns out to make driver > > code use ugly #ifdef and #if blocks. So drop the conditionals. > > ... > > > -#ifdef CONFIG_

Re: [PATCH v15 09/23] drm/shmem-helper: Remove obsoleted is_iomem test

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:35 +0300 Dmitry Osipenko wrote: > Everything that uses the mapped buffer should by agnostic to is_iomem. ^be > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now tha

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-28 Thread Andy Shevchenko
On Mon, Aug 28, 2023 at 02:29:21PM +0300, Laurent Pinchart wrote: > On Mon, Aug 28, 2023 at 02:17:02PM +0300, Andy Shevchenko wrote: > > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > > Having conditional around the of_node pointers turns out to make driver > > > code use ugly #ifdef

Re: [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Boris Brezillon
On Sun, 27 Aug 2023 20:54:38 +0300 Dmitry Osipenko wrote: > Add separate pages_pin_count for tracking of whether drm-shmem pages are > moveable or not. With the addition of memory shrinker support to drm-shmem, > the pages_use_count will no longer determine whether pages are hard-pinned > in memo

Re: [PATCH v4 1/2] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-28 Thread Helen Mae Koike Fornazier
On Saturday, August 26, 2023 04:19 -03, Biju Das wrote: > The driver has an ID table, but it uses the wrong API for retrieving match > data and that will lead to a crash, if it is instantiated by user space or > using ID. From this, there is no user for the ID table and let's drop it > from the

Re: [PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Matthew Wilcox
On Mon, Aug 28, 2023 at 03:54:49PM +0800, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. > > Signed-off-by: Xueshi Hu

[PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Arvind Yadav
AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an interface to set/reset these power profiles based on the submitted job. The driver can dynamically switch the power profiles based on sub

[PATCH v3 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-28 Thread Arvind Yadav
The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. v3: - Addressed review comment to change 'power_profile_work' instead of 'smu_delayed_work'. Cc: Christian Koenig Cc: Alex Deuch

[PATCH v3 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-28 Thread Arvind Yadav
This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches. - Addressed review comment. v3: - Adressed all t

[PATCH v3 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-28 Thread Arvind Yadav
This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Power profile once job finished. - Here, the *_workload_profile_set function will set the GPU

[PATCH v3 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-28 Thread Arvind Yadav
This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. v3: - Adressed the review comment. - Now clearing all the profile in work handler. Cc: Shashank Sharma Cc: Christian Koenig Cc:

[PATCH v3 5/7] drm/amdgpu: Set/Reset GPU workload profile

2023-08-28 Thread Arvind Yadav
This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. v3: - Addressed the review comment about changing the function name from *_set() to *_get(). Cc: Christian Koenig Cc: Alex Deucher Reviewed-by: Shashank

[PATCH v3 6/7] drm/amdgpu: switch workload context to/from compute

2023-08-28 Thread Arvind Yadav
This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. v3: - Addressed the review comment about changing the function name from *_set() to *_get(). Cc: Christian Koenig Signed-off-by: Alex Deucher Reviewed-by: Shashank Sharma Signed-off-by: Arvind

[PATCH v3 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-28 Thread Arvind Yadav
This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_workload_profile* api is added to switch on/off profile mode. These new api will allow to change the GPU power profile based on a submitted job. Cc: Christian Koenig Cc: Alex Deucher Acked-by: Shashank

[PATCH -next] drm/i915/gvt: Use list_for_each_entry() helper

2023-08-28 Thread Jinjie Ruan
Convert list_for_each() to list_for_each_entry() so that the pos list_head pointer and list_entry() call are no longer needed, which can reduce a few lines of code. No functional changed. Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/i915/gvt/dmabuf.c | 8 ++-- 1 file changed, 2 insertions(

Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-28 Thread Helen Mae Koike Fornazier
Hello! Thanks for the patch. On Saturday, August 26, 2023 04:19 -03, Biju Das wrote: > Having conditional around the of_node pointers turns out to make driver > code use ugly #ifdef and #if blocks. So drop the conditionals. It would be nice to explain why those ifdev/if conditionals are not r

Re: [PATCH v5 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-28 Thread kernel test robot
Hi Brandon, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20230828] [cannot apply to linus/master v6.5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH 1/8] fbdev/smscufx: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to the generated functions with fbdev initializer macros. Signed-off-by: Thomas Zimmermann Cc: Steve Glendinning --- drivers/video/fbdev/smscufx.c | 85 +

[PATCH 2/8] fbdev/udlfb: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to the generated functions with fbdev initializer macros. Signed-off-by: Thomas Zimmermann Cc: Bernie Thompson --- drivers/video/fbdev/udlfb.c | 89 +

[PATCH 0/8] fbdev: Use helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Here's another patchset for deferred-I/O helpers. Update a number of fbdev drivers with deferred I/O to use fbdev's helper macros and Kconfig tokens. Generating and initializing via helpers macros will later allow for a fine-grained setup, depending on Kconfig options. For example, it will be poss

[PATCH 4/8] fbdev/hyperv_fb: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_IOMEM_OPS(). Initialize struct fb_ops to the generated functions with fbdev initializer macros. The hyperv_fb driver is incomplete in its handling of deferred I/O and damage framebuffers. Write operations do

[PATCH 5/8] hid: Remove trailing whitespace

2023-08-28 Thread Thomas Zimmermann
Fix coding style in Kconfig. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jiri Kosina Cc: Benjamin Tissoires --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index e11c1c803676..b50054a41c10 100

[PATCH 7/8] staging/fbtft: Initialize fb_op struct as static const

2023-08-28 Thread Thomas Zimmermann
Replace dynamic allocation of the fb_ops instance with static allocation. Initialize the fields at module-load time. The owner field changes to THIS_MODULE, as in all other fbdev drivers. Signed-off-by: Thomas Zimmermann --- drivers/staging/fbtft/fbtft-core.c | 30 +-

[PATCH 8/8] staging/fbtft: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to the generated functions with an fbdev initializer macro. Signed-off-by: Thomas Zimmermann --- drivers/staging/fbtft/Kconfig | 6 +-- drivers/staging/fbtft/fb

[PATCH 6/8] hid/picolcd: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Thomas Zimmermann
Generate callback functions for struct fb_ops with the fbdev macro FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to the generated functions with an fbdev initializer macro. Signed-off-by: Thomas Zimmermann Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: "Bruno Prémont" --- drivers

[PATCH 3/8] fbdev: Add Kconfig macro FB_IOMEM_HELPERS_DEFERRED

2023-08-28 Thread Thomas Zimmermann
The new Kconfig macro FB_IOMEM_HELPERS_DEFERRED selects fbdev's helpers for device I/O memory and deferred I/O. Drivers should use it if they perform damage updates on device I/O memory. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/Kconfig | 6 ++ 1 file changed, 6 insertion

Re: [PATCH v2 19/34] drm/amd/display: decouple steps for mapping CRTC degamma to DC plane

2023-08-28 Thread Melissa Wen
On 08/28, Pekka Paalanen wrote: > On Mon, 28 Aug 2023 09:45:44 +0100 > Joshua Ashton wrote: > > > Degamma has always been on the plane on AMD. CRTC DEGAMMA_LUT has actually > > just been applying it to every plane pre-blend. > > I've never seen that documented anywhere. > > It has seemed obviou

Re: [PATCH v5 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-28 Thread Marius Vlad
Hi Brandon, See a bottom comment about writeback connectors creation/initalization. On Mon, Aug 28, 2023 at 08:17:04AM +, Brandon Pollack wrote: > From: Jim Shargo > > This change supports multiple CRTCs, encoders, connectors instead of one > of each per device. > > Since ConfigFS-based de

Re: [PATCH v5 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Marius Vlad
Hi Brandon, See some minor missing rmdirs for connector_other and encoder_other. On Mon, Aug 28, 2023 at 08:17:06AM +, Brandon Pollack wrote: > From: Jim Shargo > > This change adds the basic scaffolding for ConfigFS, including setting > up the default directories. It does not allow for the

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-28 Thread Frank Oltmanns
On 2023-08-28 at 10:25:01 +0200, Maxime Ripard wrote: > On Sat, Aug 26, 2023 at 11:12:16AM +0200, Frank Oltmanns wrote: >> >> On 2023-08-25 at 17:07:58 +0200, Frank Oltmanns wrote: >> > Thank you for your feedback, Maxime! >> > >> > On 2023-08-25 at 10:13:53 +0200, Maxime Ripard wrote: >> >> [

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-28 Thread Frank Oltmanns
On 2023-08-28 at 10:04:51 +0200, Maxime Ripard wrote: > On Fri, Aug 25, 2023 at 05:07:58PM +0200, Frank Oltmanns wrote: >> Thank you for your feedback, Maxime! >> >> On 2023-08-25 at 10:13:53 +0200, Maxime Ripard wrote: >> > [[PGP Signed Part:Undecided]] >> > Hi, >> > >> > On Fri, Aug 25, 2023

Re: [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko wrote: > This series: > > 1. Adds common drm-shmem memory shrinker > 2. Enables shrinker for VirtIO-GPU driver > 3. Switches Panfrost driver to the common shrinker Hi Dmitry, Would you mind testing with drm-ci? We virt-io tests ther

Re: [PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Al Viro
On Mon, Aug 28, 2023 at 03:54:49PM +0800, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. I'd put the last sentence as

Re: [PATCH 7/8] staging/fbtft: Initialize fb_op struct as static const

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:23PM +0200, Thomas Zimmermann wrote: > Replace dynamic allocation of the fb_ops instance with static > allocation. Initialize the fields at module-load time. The owner > field changes to THIS_MODULE, as in all other fbdev drivers. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH 8/8] staging/fbtft: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:24PM +0200, Thomas Zimmermann wrote: > Generate callback functions for struct fb_ops with the fbdev macro > FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to > the generated functions with an fbdev initializer macro. > > Signed-off-by: Thomas Zimmerman

Re: [PATCH v2 6/6] drm/drm-file: Allow size unit selection in drm_show_memory_stats

2023-08-28 Thread Rob Clark
On Wed, Aug 23, 2023 at 6:36 PM Adrián Larumbe wrote: > > The current implementation will try to pick the highest available > unit. This is rather unflexible, and allowing drivers to display BO size > statistics through fdinfo in units of their choice might be desirable. > > The new argument to dr

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Lazar, Lijo
[AMD Official Use Only - General] As mentioned with an older version of this series, this is an 'abuse' of power profile interface. This series is oversimplifying what PMFW algorithms are supposed to be doing. Whatever this series is doing, FW can do it better. To explain in simpler terms - it

Re: [PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2023-08-28 Thread Rob Herring
On Fri, 25 Aug 2023 14:11:40 +0200, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual-link panel ICs. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Re-phrase description of binding and ports (Laurent) > v3: > https://lore.kernel.org/

Re: [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Monday, August 28, 2023 11:37 -03, "Helen Mae Koike Fornazier" wrote: > On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko > wrote: > > > This series: > > > > 1. Adds common drm-shmem memory shrinker > > 2. Enables shrinker for VirtIO-GPU driver > > 3. Switches Panfrost driver to

Re: [PATCH] spi: tegra: Fix missing IRQ check in tegra_slink_probe()

2023-08-28 Thread Helen Mae Koike Fornazier
On Saturday, August 26, 2023 07:02 -03, Zhang Shurong wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > > Fix this by st

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-28 Thread Helen Mae Koike Fornazier
On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is no connector attached. >

Re: [PATCH] drm/prime: Support page array >= 4GB

2023-08-28 Thread Felix Kuehling
On 2023-08-21 16:02, Philip Yang wrote: Without unsigned long typecast, the size is passed in as zero if page array size >= 4GB, nr_pages >= 0x10, then sg list converted will have the first and the last chunk lost. Signed-off-by: Philip Yang The patch looks reasonable to me. I don't have

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Helen Mae Koike Fornazier
On Monday, August 28, 2023 09:26 -03, Arvind Yadav wrote: > AMDGPU SOCs supports dynamic workload based power profiles, which can > provide fine-tuned performance for a particular type of workload. > This patch series adds an interface to set/reset these power profiles > based on the submitted jo

  1   2   >