[PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Cc: Alex Deucher Cc: amd-...@lists.freedesktop.org Cc: Ben Skeggs Cc: "Christian König" Cc: Daniel Vetter Cc: Danilo Krummrich Cc: David Airlie

[PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable] Signed-off-by: Lee J

[PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' drivers/gp

[PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Signed-off-by: Lee Jones --- Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude

[PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment

[PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was f

[PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for drm_kunit_helper_context_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead Signed-off-by: Lee Jones --- Cc: David Airlie Cc: Daniel Vetter C

[PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6

[PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’: drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable] Signed-off-by: Lee Jones --- Cc: Alex Deucher Cc: "Christian Kö

[PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/

[PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' Signed-off-by: Lee Jones --- Cc: Luben Tuikov Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian

[PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Function parameter or member 'doorbell_index' not described in 'amdgpu_doorbell_index_on_bar' drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell_mgr.c:123: warning: Excess function paramete

[PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc' Signed-off-by: Lee Jones --- Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie

[PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead Signed-off-by: Lee Jones --- Cc: David Airlie Cc: Daniel Vett

[PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Lee Jones
When converting from int to string, we must allow for up to 10-chars (2147483647). Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’: drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing

[PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Lee Jones
When converting from int to string, we must allow for up to 10-chars (2147483647). Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/imx/ipuv3/imx-ldb.c: In function ‘imx_ldb_probe’: drivers/gpu/drm/imx/ipuv3/imx-ldb.c:659:39: warning: ‘_sel’ directive writing 4 bytes into a re

[PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member 'supported_colorspaces' not described in 'drm_mode_create_hdmi_colorspace_property' drivers/gpu/drm/drm_connector.c:2239: warning: Function parameter or member 'support

[PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_sysfs_create’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ directive output may be truncated writing 10 bytes into a region of size between 1 and 32 [-Wf

[PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function ‘amdgpu_sdma_init_microcode’: drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive output may be truncated writing 4 bytes into a region of size between 0 and 32 [-Wfor

[PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’: drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Signed-off-by: Lee Jones --- Cc: Maarten Lankhorst Cc: Maxime Rip

[PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/imu_v11_0.c: In function ‘imu_v11_0_init_microcode’: drivers/gpu/drm/amd/amdgpu/imu_v11_0.c:52:54: warning: ‘_imu.bin’ directive output may be truncated writing 8 bytes into a region of size between 4 and 33 [-Wformat-

[PATCH v2 10/22] drm/dp_mst: Add a way to calculate PBN values with FEC overhead

2023-08-24 Thread Imre Deak
Add a way for drivers to calculate the MST PBN values with FEC overhead. This is required by 8b/10b links both for DSC and non-DSC (the latter needed if there are both DSC and non-DSC streams on the same MST link). Also add kunit test cases for PBN values calculated with FEC overhead. Cc: Lyude P

[PATCH v2 11/22] drm/dp_mst: Add helper to determine if an MST port is downstream of another port

2023-08-24 Thread Imre Deak
Add drm_dp_mst_port_downstream_of_parent() required by the i915 driver in a follow-up patch to resolve a BW overallocation of MST streams going through a given MST port. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c

[PATCH v2 09/22] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-08-24 Thread Imre Deak
For fractional bpp values passed to the function in a .4 fixed point format, the fractional part is currently ignored due to scaling bpp too early. Fix this by scaling the overhead factor instead and to avoid an overflow multiplying bpp with the overhead factor instead of the clock rate. While at

[PATCH v2 12/22] drm/dp_mst: Factor out a helper to check the atomic state of a topology manager

2023-08-24 Thread Imre Deak
Factor out a helper to check the atomic state for one MST topology manager, returning the MST port where the BW limit check has failed. This will be used in a follow-up patch by the i915 driver to improve the BW sharing between MST streams. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signe

[PATCH v2 13/22] drm/dp_mst: Swap the order of checking root vs. non-root port BW limitations

2023-08-24 Thread Imre Deak
drm_dp_mst_atomic_check_mgr() should check for BW limitation starting from sink ports continuing towards the root port, so that drivers can use the @failing_port returned to resolve a BW overallocation in an ideal way. For instance from streams A,B,C in a topology A,B going through @failing_port an

Re: [PATCH v5 00/17] Imagination Technologies PowerVR DRM driver

2023-08-24 Thread Sarah Walker
On Thu, 2023-08-24 at 07:31 +0900, Masahiro Yamada wrote: > On Fri, Aug 18, 2023 at 4:35 AM Sarah Walker wrote: > > This patch series adds the initial DRM driver for Imagination Technologies > > PowerVR > > GPUs, starting with those based on our Rogue architecture. It's worth > > pointing > > ou

Re: [PATCH v5 00/17] Imagination Technologies PowerVR DRM driver

2023-08-24 Thread Sarah Walker
On Thu, 2023-08-24 at 09:08 +0100, Sarah Walker wrote: > On Thu, 2023-08-24 at 07:31 +0900, Masahiro Yamada wrote: > > On Fri, Aug 18, 2023 at 4:35 AM Sarah Walker > > wrote: > > > This patch series adds the initial DRM driver for Imagination > > > Technologies PowerVR > > > GPUs, starting with

RE: [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index'

2023-08-24 Thread Sharma, Shashank
[AMD Official Use Only - General] Reviewed-by: : Shashank Sharma Regards Shashank -Original Message- From: Lee Jones Sent: Thursday, August 24, 2023 9:37 AM To: l...@kernel.org Cc: linux-ker...@vger.kernel.org; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Dani

[PULL] drm-misc-fixes

2023-08-24 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2023-08-24: A samsung-dsim initialization fix, a devfreq fix for panfrost, a DP DSC define fix, a recursive lock fix for dma-buf, a shader validation fix and a reference counting fix for vmwgfx The following changes since commit 50b6f2

Re: [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: w

Re: [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/gpu

Re: [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > > Signed-off

Re: [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

2023-08-24 Thread Karol Herbst
On Thu, Aug 24, 2023 at 9:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts > with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/gpu/drm/nou

[PATCH v4 0/7] Adds support for ConfigFS to VKMS!

2023-08-24 Thread Brandon Pollack
Since Jim is busy with other work and I'm working on some things that rely on this, I've taken up the task of doing the iterations. I've addressed the comments as best I can (those replies are to each individual change) and here is the patch set to go with those. I added my own signoff to each co

[PATCH v4 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects

2023-08-24 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signe

[PATCH v4 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-24 Thread Brandon Pollack
From: Jim Shargo This change supports multiple CRTCs, encoders, connectors instead of one of each per device. Since ConfigFS-based devices will support multiple crtcs, it's useful to move all of the writeback/composition data from being per-"output" to being per-CRTC. Since there's still only e

[PATCH v4 3/7] drm/vkms: Provide platform data when creating VKMS devices

2023-08-24 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c| 14 -- drivers/gpu/drm/vkms/vkms_drv.h| 9 ++--- drivers/gpu/drm/v

[PATCH v4 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-24 Thread Brandon Pollack
From: Jim Shargo This change adds the basic scaffolding for ConfigFS, including setting up the default directories. It does not allow for the registration of configfs-backed devices, which is complex and provided in a follow-up commit. This CL includes docs about using ConfigFS with VKMS, but I'

[PATCH v4 6/7] drm/vkms: Add a module param to enable/disable the default device

2023-08-24 Thread Brandon Pollack
From: Jim Shargo In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the only one that exists. The param, enable_default, is defaulted to tru

[PATCH v4 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-24 Thread Brandon Pollack
From: Jim Shargo VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_configfs.c | 37

[PATCH v4 7/7] drm/vkms Add hotplug support via configfs to VKMS.

2023-08-24 Thread Brandon Pollack
This change adds the ability to read or write a "1" or a "0" to the newly added "connected" attribute of a connector in the vkms entry in configfs. A write will trigger a call to drm_kms_helper_hotplug_event, causing a hotplug uevent. With this we can write virtualized multidisplay tests that inv

Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'

2023-08-24 Thread Maxime Ripard
Hi, On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype > for ddrm_kunit_helper_acquire_ctx_alloc(). Prototype was for > drm_kunit_helper_acquire_ctx_alloc(

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Cc: Alex Deucher > Cc: amd-...@lists.freedesktop.org > Cc: Ben Skeggs > Cc: "Christ

Re: (subset) [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces'

2023-08-24 Thread Maxime Ripard
On Thu, 24 Aug 2023 08:37:01 +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/drm_connector.c:2215: warning: Function parameter or member > 'supported_colorspaces' not described in > 'drm_mode_create_hdmi_colorspace_property' > drivers/gpu/drm/drm_

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
Hi, On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote: > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Cc: A

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Jani Nikula
On Thu, 24 Aug 2023, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. The next question is, how do we keep it W=1 clean going forward? Most people don't use W=1 because it'

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Maxime Ripard
On Thu, Aug 24, 2023 at 12:03:20PM +0300, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do w

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Thierry Reding
On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote: > When converting from int to string, we must allow for up to 10-chars > (2147483647). > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’: > drivers/gpu/drm/tegra

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-24 Thread Lisovskiy, Stanislav
On Wed, Aug 23, 2023 at 05:24:25PM +0530, Ankit Nautiyal wrote: > Edid specific BPC constraints are stored in limits->max_bpp. Honor these > limits while computing the input bpp for DSC. > > Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy That is kind of funny, I can see this pa

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Jani Nikula
On Thu, 24 Aug 2023, Thierry Reding wrote: > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote: >> When converting from int to string, we must allow for up to 10-chars >> (2147483647). >> >> Fixes the following W=1 kernel build warning(s): >> >> drivers/gpu/drm/tegra/hub.c: In function

Re: [Linaro-mm-sig] [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result'

2023-08-24 Thread Christian König
Am 24.08.23 um 09:36 schrieb Lee Jones: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done' Signed-off-by: Lee Jones Reviewed-by: Christian König --- Cc: Luben

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-24 Thread Jani Nikula
On Wed, 23 Aug 2023, Ankit Nautiyal wrote: > Edid specific BPC constraints are stored in limits->max_bpp. Honor these > limits while computing the input bpp for DSC. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 d

Re: [PATCH 1/2] drm/display/dp: Default 8 bpc support when DSC is supported

2023-08-24 Thread Jani Nikula
On Thu, 24 Aug 2023, Ankit Nautiyal wrote: > As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah. > Apparently some panels that do support DSC, are not setting the bit for > 8bpc. > > So always assume 8bpc support by DSC decoder, when DSC is claimed to be > supported. > > v2: Use h

Re: [PATCH v14 RESEND 1/6] dt-bindings: display: imx: Add i.MX8qxp/qm DPU binding

2023-08-24 Thread Maxime Ripard
On Wed, Aug 23, 2023 at 08:47:51AM +, Ying Liu wrote: > > > This dt-binding just follows generic dt-binding rule to describe the DPU > > > IP > > > hardware, not the software implementation. DPU internal units do not > > > constitute separate devices. > > > > I mean, your driver does split t

Re: [PATCH v2 0/6] drm/i915/dp_link_training: Define a final failure state when link training fails

2023-08-24 Thread Jani Nikula
On Thu, 24 Aug 2023, Gil Dekel wrote: > Next version of https://patchwork.freedesktop.org/series/122643/ > > Reorganize into: > 1) Add for final failure state for SST and MST link training fallback. > 2) Add a DRM helper for setting downstream MST ports' link-status state. > 3) Make handling SST a

Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-24 Thread Andy Shevchenko
On Wed, Aug 23, 2023 at 9:39 PM Doug Anderson wrote: > On Wed, Aug 23, 2023 at 10:10 AM Andy Shevchenko > wrote: > > > > > No. Please, do not remove the I2C ID table. It had already been > > > discussed a few years ago. > > > > > > > Yes, it make sense, as it saves some memory > > > > Okay, readi

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #27 from popus_czy_to_ty (pentelja...@o2.pl) --- @alex, as i renember it was remote shell accessible from suspending (on LLVMPIPE) [rest banned], but it didnt go deep sleep anyway as far i renember(?) @mario formatted 3x with changin

RE: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-24 Thread Biju Das
Hi Andy Shevchenko, > Subject: Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support > for ID table > > On Wed, Aug 23, 2023 at 9:39 PM Doug Anderson > wrote: > > On Wed, Aug 23, 2023 at 10:10 AM Andy Shevchenko > > wrote: > > > > > > > No. Please, do not remove the I2C ID table. I

Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-24 Thread Marek Behún
On Thu, 24 Aug 2023 12:59:19 +0300 Andy Shevchenko wrote: > On Wed, Aug 23, 2023 at 9:39 PM Doug Anderson wrote: > > On Wed, Aug 23, 2023 at 10:10 AM Andy Shevchenko > > wrote: > > > > > > > No. Please, do not remove the I2C ID table. It had already been > > > > discussed a few years ago. >

Re: [PATCH v2 5/6] drm/panfrost: Implement generic DRM object RSS reporting function

2023-08-24 Thread kernel test robot
Hi Adrián, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.5-rc7 next-20230824] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH v4 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-24 Thread kernel test robot
Hi Brandon, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20230824] [cannot apply to linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v7] drm/doc: Document DRM device reset expectations

2023-08-24 Thread Pekka Paalanen
On Fri, 18 Aug 2023 17:06:42 -0300 André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > > --- > > v7 changes: > - s/application/graphical API contex/ in the robustness part (Michel) >

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-24 Thread Nautiyal, Ankit K
Thanks Stan for the review. Regards, Ankit On 8/24/2023 2:59 PM, Lisovskiy, Stanislav wrote: On Wed, Aug 23, 2023 at 05:24:25PM +0530, Ankit Nautiyal wrote: Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. Signed-off-by: A

RE: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats printing

2023-08-24 Thread Upadhyay, Tejas
> -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: Friday, July 7, 2023 6:32 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 5/5] drm/i915: Implement fdinfo memory stats > printing > > From: Tvrtko Ursuli

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-24 Thread Nautiyal, Ankit K
On 8/24/2023 3:14 PM, Jani Nikula wrote: On Wed, 23 Aug 2023, Ankit Nautiyal wrote: Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- 1

Re: [PATCH 1/2] drm/display/dp: Default 8 bpc support when DSC is supported

2023-08-24 Thread Nautiyal, Ankit K
Thanks Jani for the corrections and suggestions. I agree to them and will fix them in next version. Now that I see the commit subject line also should have been "Assume 8 bpc support when DSC is supported", will change that too. Regards, Ankit On 8/24/2023 3:15 PM, Jani Nikula wrote: On Th

Re: [Intel-xe] [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-24 Thread Christian König
Am 24.08.23 um 01:12 schrieb Matthew Brost: On Wed, Aug 23, 2023 at 01:26:09PM -0400, Rodrigo Vivi wrote: On Wed, Aug 23, 2023 at 11:41:19AM -0400, Alex Deucher wrote: On Wed, Aug 23, 2023 at 11:26 AM Matthew Brost wrote: On Wed, Aug 23, 2023 at 09:10:51AM +0200, Christian König wrote: Am 23

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-24 Thread Bas Nieuwenhuizen
On Tue, Aug 22, 2023 at 6:55 PM Faith Ekstrand wrote: > On Tue, Aug 22, 2023 at 4:51 AM Christian König > wrote: > >> Am 21.08.23 um 21:46 schrieb Faith Ekstrand: >> >> On Mon, Aug 21, 2023 at 1:13 PM Christian König >> wrote: >> >>> [SNIP] >>> So as long as nobody from userspace comes and says

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Thierry Reding wrote: > > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote: > >> When converting from int to string, we must allow for up to 10-chars > >> (2147483647). > >> > >> Fixes the following W=1 kernel build warning

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Jani Nikula wrote: > On Thu, 24 Aug 2023, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > The next question is, how do we keep it W=1 clean

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled with > > > niggly little warnings. > >

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Maxime Ripard wrote: > Hi, > > On Thu, Aug 24, 2023 at 10:59:54AM +0200, Maxime Ripard wrote: > > On Thu, 24 Aug 2023 08:36:45 +0100, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly

Re: [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc'

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Maxime Ripard wrote: > Hi, > > On Thu, Aug 24, 2023 at 08:36:58AM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting > > prototype for ddrm_kunit_helper_acquire_ctx_alloc().

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Hamza Mahfooz
On 8/24/23 08:07, Lee Jones wrote: On Thu, 24 Aug 2023, Jani Nikula wrote: On Thu, 24 Aug 2023, Lee Jones wrote: This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. The next question is, how

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-24 Thread Lee Jones
On Thu, 24 Aug 2023, Hamza Mahfooz wrote: > > On 8/24/23 08:07, Lee Jones wrote: > > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > > > On Thu, 24 Aug 2023, Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhel

[PULL] drm-intel-next-fixes

2023-08-24 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes our next-fixes targeting 6.6-rc1. Please notice that we have 2 drm level patches there, one to fix the display HPD polling and one dependency introducing a helper to reschedule the poll work. drm-intel-next-fixes-2023-08-24: - Fix TLB invalidation (Alan) - Fix Disp

[PULL] drm-intel-fixes

2023-08-24 Thread Rodrigo Vivi
Hi Dave and Daniel, And this is our fixes targeting 6.5 (rc8?). I'm again covering for Tvrtko at this round. Please also notice that here we also have the drm patches fixing the HPD polling that I had mentioned in our next-fixes. One is the fix itself and the other is a dependency to add the hel

Re: [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev'

2023-08-24 Thread Danilo Krummrich
Hi Lee, On 8/24/23 09:37, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_gpuva_mgr.c: In function ‘__drm_gpuva_sm_map’: drivers/gpu/drm/drm_gpuva_mgr.c:1079:39: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] Thanks for fixing

[PATCH 0/2] eDP DSC fixes

2023-08-24 Thread Ankit Nautiyal
Assume 8bpc is supported if Sink claims DSC support. Also consider bpc constraint coming from EDID while computing input BPC for DSC. Rev2: Fix check for dsc support. Rev3: Minor styling and typos fix. Ankit Nautiyal (2): drm/display/dp: Assume 8 bpc support when DSC is supported drivers/drm/

[PATCH 1/2] drm/display/dp: Assume 8 bpc support when DSC is supported

2023-08-24 Thread Ankit Nautiyal
As per DP v1.4, a DP DSC Sink device shall support 8bpc in DPCD 6Ah. Apparently some panels that do support DSC, are not setting the bit for 8bpc. So always assume 8bpc support by DSC decoder, when DSC is claimed to be supported. v2: Use helper to get check dsc support. (Ankit) v3: Fix styling an

[PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

2023-08-24 Thread Ankit Nautiyal
Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. v2: Use int instead of u8 for computations. (Jani) Add closes tag. (Ankit) Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9161 Signed-off-by: Ankit Nautiyal Reviewed-

[PATCH] drm/amd/display: enable cursor degamma for DCN3+ DRM legacy gamma

2023-08-24 Thread Melissa Wen
For DRM legacy gamma, AMD display manager applies implicit sRGB degamma using a pre-defined sRGB transfer function. It works fine for DCN2 family where degamma ROM and custom curves go to the same color block. But, on DCN3+, degamma is split into two blocks: degamma ROM for pre-defined TFs and `gam

Re: [PATCH 15/20] drm/tegra/hub: Increase buffer size to ensure all possible values can be stored

2023-08-24 Thread Thierry Reding
On Thu, Aug 24, 2023 at 01:01:24PM +0100, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: > > > On Thu, 24 Aug 2023, Thierry Reding wrote: > > > On Thu, Aug 24, 2023 at 08:37:00AM +0100, Lee Jones wrote: > > >> When converting from int to string, we must allow for up to 10-chars > > >

[PATCH 0/6] drm, cec and edid updates

2023-08-24 Thread Jani Nikula
Avoid accessing the raw edid directly. Pre-parse the source physical address during normal EDID parsing and use that for CEC. Jani Nikula (6): drm/edid: add drm_edid_is_digital() drm/i915/display: use drm_edid_is_digital() drm/edid: parse source physical address drm/cec: add drm_dp_cec_att

[PATCH 2/6] drm/i915/display: use drm_edid_is_digital()

2023-08-24 Thread Jani Nikula
Reduce the use of struct edid and drm_edid_raw(). Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_crt.c | 11 --- drivers/gpu/drm/i915/display/intel_hdmi.c | 9 - drivers/gpu/drm/i915/display/intel_sdvo.c | 7 ++- 3 files changed, 10 insertions(+), 17 del

[PATCH 1/6] drm/edid: add drm_edid_is_digital()

2023-08-24 Thread Jani Nikula
Checking edid->input & DRM_EDID_INPUT_DIGITAL is common enough to deserve a helper that also lets us abstract the raw EDID a bit better. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 17 +++-- include/drm/drm_edid.h | 1 + 2 files changed, 16 insertions(+), 2 delet

[PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-24 Thread Jani Nikula
Connectors have source physical address available in display info. There's no need to parse the EDID again for this. Add drm_dp_cec_attach() to do this. Seems like the set_edid/unset_edid naming is a bit specific now that there's no need to pass the EDID at all, so aim for attach/detach going forw

[PATCH 3/6] drm/edid: parse source physical address

2023-08-24 Thread Jani Nikula
CEC needs the source physical address. Parsing it is trivial with the existing EDID CEA DB infrastructure. Default to CEC_PHYS_ADDR_INVALID (0x) instead of 0 to cater for easier CEC usage. Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_e

[PATCH 5/6] drm/i915/cec: switch to setting physical address directly

2023-08-24 Thread Jani Nikula
Avoid parsing the EDID again for source physical address. Also gets rids of a few remaining raw EDID usages. Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 7 ++- drivers/gpu/drm/i915/display/intel_hdmi.c | 5 ++---

[PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-24 Thread Jani Nikula
In the drm subsystem, the source physical address is, in most cases, available without having to parse the EDID again. Add notes about preferring to use the pre-parsed address instead. Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/media/cec/core/cec-ada

Re: [PATCH AUTOSEL 6.4 10/11] drm/amdkfd: disable IOMMUv2 support for KV/CZ

2023-08-24 Thread Alex Deucher
On Tue, Aug 22, 2023 at 7:36 AM Sasha Levin wrote: > > From: Alex Deucher > > [ Upstream commit 616f92d188ee7142a95a52068efdbea82645f859 ] > > Use the dGPU path instead. There were a lot of platform > issues with IOMMU in general on these chips due to windows > not enabling IOMMU at the time. T

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-24 Thread Alex Deucher
On Tue, Aug 22, 2023 at 9:35 AM Somalapuram, Amaranath wrote: > > > On 8/21/2023 6:30 PM, Shashank Sharma wrote: > > + Amar should be able to help. > > > > Amar, > > > > Can you please check this patch (series if required) with a few IGTs > > and probably with Xonotic as well ? > > > Tested patch

Re: [Intel-xe] [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-24 Thread Matthew Brost
On Thu, Aug 24, 2023 at 01:44:41PM +0200, Christian König wrote: > Am 24.08.23 um 01:12 schrieb Matthew Brost: > > On Wed, Aug 23, 2023 at 01:26:09PM -0400, Rodrigo Vivi wrote: > > > On Wed, Aug 23, 2023 at 11:41:19AM -0400, Alex Deucher wrote: > > > > On Wed, Aug 23, 2023 at 11:26 AM Matthew Brost

Re: [PATCH][next] drm/amd: Fix spelling mistake "throtting" -> "throttling"

2023-08-24 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 23, 2023 at 5:50 AM Wang, Yang(Kevin) wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Yang Wang > > Best Regards, > Kevin > > -Original Message- > From: dri-devel On Behalf Of Colin > Ian King > Sent: Wednesday, August 23, 2023 5:03 PM

Re: [PATCH v2 0/9] DRM scheduler changes for Xe

2023-08-24 Thread Danilo Krummrich
On 8/24/23 05:23, Matthew Brost wrote: On Thu, Aug 24, 2023 at 02:08:59AM +0200, Danilo Krummrich wrote: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: As a prerequisite to merging the new Intel Xe DRM driver [1] [2], we have been asked to merge our common DRM scheduler patches first. This a

Re: [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()

2023-08-24 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 24, 2023 at 3:37 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’: > drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but > not used [-Wunused-but-

Re: [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id'

2023-08-24 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 24, 2023 at 3:38 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:516: warning: Function parameter > or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc' > > Signed-off-by: Lee Jones >

Re: [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values

2023-08-24 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 24, 2023 at 3:38 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function > ‘amdgpu_ras_sysfs_create’: > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1406:20: warning: ‘_err_count’ > directive ou

Re: [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values

2023-08-24 Thread Alex Deucher
Applied. Thanks! On Thu, Aug 24, 2023 at 3:38 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c: In function > ‘amdgpu_sdma_init_microcode’: > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c:217:64: warning: ‘.bin’ directive > outp

  1   2   >