Re: [PATCH] drm/ast: Avoid possible NULL dereference

2023-08-21 Thread Christophe JAILLET
Le 21/08/2023 à 08:22, Su Hui a écrit : smatch error: drivers/gpu/drm/ast/ast_dp501.c:227 ast_launch_m68k() error: we previously assumed 'ast->dp501_fw' could be null (see line 223) when "!ast->dp501_fw" and "ast_load_dp501_microcode(dev) >= 0" is true, there will be a NULL dereference of 'ast->

Re: [Intel-gfx] [PATCH v3] drm/i915: Fix Kconfig error for CONFIG_DRM_I915

2023-08-21 Thread Jani Nikula
On Sun, 20 Aug 2023, Wang Jinchao wrote: > When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE > is set to 'm', we encountered an ld.lld error during the build process: > > ld.lld: error: undefined symbol: backlight_device_get_by_name > >>> referenced by intel_backligh

Re: [PATCH] drm/ast: Avoid possible NULL dereference

2023-08-21 Thread Su Hui
On 2023/8/21 15:04, Christophe JAILLET wrote: Le 21/08/2023 à 08:22, Su Hui a écrit : smatch error: drivers/gpu/drm/ast/ast_dp501.c:227 ast_launch_m68k() error: we previously assumed 'ast->dp501_fw' could be null (see line 223) when "!ast->dp501_fw" and "ast_load_dp501_microcode(dev) >= 0" is t

[PATCH v2] drm/amdgpu: Avoid possible buffer overflow

2023-08-21 Thread Su Hui
smatch error: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1257 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use. change the assignment order to avoid buffer overflow. Fixes: c40bdfb2ffa4 ("drm/amdgpu: fix incorrect VCN revision in SRIOV") Signed-o

[Intel-gfx] [PATCH v3] drm/i915: Fix Kconfig error for CONFIG_DRM_I915

2023-08-21 Thread Wang Jinchao
When CONFIG_DRM_I915 is set to 'y' and CONFIG_BACKLIGHT_CLASS_DEVICE is set to 'm', we encountered an ld.lld error during the build process: ld.lld: error: undefined symbol: backlight_device_get_by_name >>> referenced by intel_backlight.c:955 >>> vmlinux.o:(in

Re: (subset) [PATCH] drm/bridge: Fix kernel-doc typo in desc of output_bus_cfg in drm_bridge_state

2023-08-21 Thread Maxime Ripard
On Thu, 17 Aug 2023 09:48:09 -0700, Douglas Anderson wrote: > There's an obvious copy-paste error in the description of > output_bus_cfg. Fix it. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-21 Thread Maxime Ripard
Hi, On Fri, Aug 18, 2023 at 10:25:48AM +0200, neil.armstr...@linaro.org wrote: > On 17/08/2023 20:35, Dmitry Baryshkov wrote: > > On 16/08/2023 10:51, neil.armstr...@linaro.org wrote: > > > Sending HS commands will always work on any controller, it's all > > > about LP commands. The Samsung panels

Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-21 Thread Donald Robson
Hi Danilo, Thanks for the feedback. On the subject of locking, I have dma_resv locking in another branch where I'm trying to enable bind queues, but I didn't think I needed locking for the single, synchronous operations seen here. Would a mutex on the gem object wrapper suffice? Thanks, Donald O

Re: [PATCH] drm/doc: document DRM_IOCTL_MODE_CREATE_DUMB

2023-08-21 Thread Pekka Paalanen
On Thu, 03 Aug 2023 10:00:44 + Simon Ser wrote: > The main motivation is to repeat that dumb buffers should not be > abused for anything else than basic software rendering with KMS. > User-space devs are more likely to look at the IOCTL docs than to > actively search for the driver-oriented "

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-08-21 Thread Alistair Popple
"Kasireddy, Vivek" writes: > Hi Jason, > >> > > >> > > > No, adding HMM_PFN_REQ_WRITE still doesn't help in fixing the issue. >> > > > Although, I do not have THP enabled (or built-in), shmem does not evict >> > > > the pages after hole punch as noted in the comment in >> shmem_fallocate(): >>

Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-08-21 Thread Geert Uytterhoeven
Hi Christian, On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven wrote: > On Fri, Jul 7, 2023 at 2:06 PM Christian König > wrote: > > Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven: > > > On 32-bit: > > > > > > ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’: > > > ../tests/amd

Re: [REGRESSION] HDMI connector detection broken in 6.3 on Intel(R) Celeron(R) N3060 integrated graphics

2023-08-21 Thread Maxime Ripard
On Tue, Aug 15, 2023 at 11:12:46AM +0300, Jani Nikula wrote: > On Mon, 14 Aug 2023, Imre Deak wrote: > > On Sun, Aug 13, 2023 at 03:41:30PM +0200, Linux regression tracking > > (Thorsten Leemhuis) wrote: > > Hi, > > > >> On 11.08.23 20:10, Mikhail Rudenko wrote: > >> > On 2023-08-11 at 08:45 +02,

Re: [PATCH v2] drm/amdgpu: Avoid possible buffer overflow

2023-08-21 Thread Christian König
Am 21.08.23 um 09:37 schrieb Su Hui: smatch error: drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1257 amdgpu_discovery_reg_base_init() error: testing array offset 'adev->vcn.num_vcn_inst' after use. change the assignment order to avoid buffer overflow. Fixes: c40bdfb2ffa4 ("drm/amdgpu: fix inc

Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-08-21 Thread Christian König
Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven: Hi Christian, On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven wrote: On Fri, Jul 7, 2023 at 2:06 PM Christian König wrote: Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven: On 32-bit: ../tests/amdgpu/amdgpu_stress.c: In function ‘allo

Re: [PATCH v2 2/4] drm/amdgpu: Allow explicit sync for VM ops.

2023-08-21 Thread Christian König
Am 21.08.23 um 08:20 schrieb Tatsuyuki Ishi: From: Bas Nieuwenhuizen This should be okay because moves themselves use KERNEL usage and hence still sync with BOOKKEEP usage. Then any later submits still wait on any pending VM operations. (i.e. we only made VM ops not wait on BOOKKEEP submits, n

Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-08-21 Thread Geert Uytterhoeven
Hi Christian, On Mon, Aug 21, 2023 at 11:34 AM Christian König wrote: > Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven: > > On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven > > wrote: > >> On Fri, Jul 7, 2023 at 2:06 PM Christian König > >> wrote: > >>> Am 06.07.23 um 10:36 schrieb Geert Uyt

Re: [PATCH drm-misc-next 1/3] drm: drm_exec: build always builtin

2023-08-21 Thread Christian König
Am 20.08.23 um 23:53 schrieb Danilo Krummrich: drm_exec must always be builtin for the DRM GPUVA manager to depend on it. You should probably go the other way around and not always build in the GPUVA manager. We have intentionally and with quite a bit of work moved the DRM_EXEC and DRM_BUDD

[PATCH] dma-buf/heaps: map CMA all pages for user

2023-08-21 Thread Hsia-Jun Li
Page fault would raise a CPU interrupt, it is not a good idea. Signed-off-by: Hsia-Jun(Randy) Li --- drivers/dma-buf/heaps/cma_heap.c | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_hea

RE: [PATCH v5 06/11] drm/radeon: Use RMW accessors for changing LNKCTL

2023-08-21 Thread Ilpo Järvinen
On Fri, 18 Aug 2023, Deucher, Alexander wrote: > [Public] > > > -Original Message- > > From: Ilpo Järvinen > > Sent: Monday, July 17, 2023 8:05 AM > > To: linux-...@vger.kernel.org; Bjorn Helgaas ; Lorenzo > > Pieralisi ; Rob Herring ; > > Krzysztof Wilczyński ; Emmanuel Grumbach > > ; R

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-21 Thread neil . armstrong
Hi Maxime, On 21/08/2023 10:17, Maxime Ripard wrote: Hi, On Fri, Aug 18, 2023 at 10:25:48AM +0200, neil.armstr...@linaro.org wrote: On 17/08/2023 20:35, Dmitry Baryshkov wrote: On 16/08/2023 10:51, neil.armstr...@linaro.org wrote: Sending HS commands will always work on any controller, it's

[PATCH 1/3] drm/buddy: Fix contiguous memory allocation issues

2023-08-21 Thread Arunpravin Paneer Selvam
The way now contiguous requests are implemented such that the size rounded up to power of 2 and the corresponding order block picked from the freelist. In addition to the older method, the new method will rounddown the size to power of 2 and the corresponding order block picked from the freelist.

[PATCH 2/3] drm/amdgpu: Remove the contiguous computation and trim

2023-08-21 Thread Arunpravin Paneer Selvam
As we have implemented a new method for contiguous allocation which requires actual size and actual min_block_size, hence we have moved the roundup and alignment size computation to buddy allocator. This way gpu drivers pass the required size and alignment to buddy allocator and rest of the operati

[PATCH 3/3] drm/i915: Remove the contiguous computation and trim

2023-08-21 Thread Arunpravin Paneer Selvam
As we have implemented a new method for contiguous allocation which requires actual size and actual min_block_size, hence we have moved the roundup and alignment size computation to buddy allocator. This way gpu drivers pass the required size and alignment to buddy allocator and rest of the operati

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread Christian König
Am 20.08.23 um 11:51 schrieb Christophe JAILLET: This serie simplifies amdgpu_bo_list_create() and usage of the 'struct amdgpu_bo_list'. Oh, yes please. That's something I always wanted to cleanup as well. It is compile tested only. That bothers me a bit. Arun, Vitaly, Shashank can anybody

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Robin Murphy
On 2023-08-18 22:32, Jason Gunthorpe wrote: It turns out several drivers are calling of_dma_configure() outside the expected bus_type.dma_configure op. This ends up being mis-locked and triggers a lockdep assertion, or instance: iommu_probe_device_locked+0xd4/0xe4 of_iommu_configure+0x10c/

Re: [PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-08-21 Thread Christian König
Am 21.08.23 um 11:48 schrieb Geert Uytterhoeven: Hi Christian, On Mon, Aug 21, 2023 at 11:34 AM Christian König wrote: Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven: On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven wrote: On Fri, Jul 7, 2023 at 2:06 PM Christian König wrote: Am 06.07.2

Re: [PATCH] fs: clean up usage of noop_dirty_folio

2023-08-21 Thread Jan Kara
On Sat 19-08-23 20:42:25, Xueshi Hu wrote: > In folio_mark_dirty(), it will automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. > > Signed-off-by: Xueshi Hu Yeah, looks s

Re: [PATCH 1/3] drm/buddy: Fix contiguous memory allocation issues

2023-08-21 Thread Christian König
Am 21.08.23 um 12:14 schrieb Arunpravin Paneer Selvam: The way now contiguous requests are implemented such that the size rounded up to power of 2 and the corresponding order block picked from the freelist. In addition to the older method, the new method will rounddown the size to power of 2 and

Re: (subset) [PATCH -next RESEND] backlight: led_bl: Remove redundant of_match_ptr()

2023-08-21 Thread Lee Jones
On Fri, 18 Aug 2023 09:23:08 +0800, Ruan Jinjie wrote: > The driver depends on CONFIG_OF, it is not necessary to use > of_match_ptr() here. > > Applied, thanks! [1/1] backlight: led_bl: Remove redundant of_match_ptr() commit: a4464092f2c514a7f0788906d340f0bab59fdd73 -- Lee Jones [李琼斯]

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-21 Thread Dave Stevenson
Hi Dmitry On Fri, 18 Aug 2023 at 11:27, Dmitry Baryshkov wrote: > > On 18/08/2023 11:25, neil.armstr...@linaro.org wrote: > > Hi Dmitry, > > > > On 17/08/2023 20:35, Dmitry Baryshkov wrote: > >> On 16/08/2023 10:51, neil.armstr...@linaro.org wrote: > >>> Hi Abhinav, > >>> > >>> On 14/08/2023 20:0

Re: [PATCH v2 12/15] drm/panthor: Add the driver frontend block

2023-08-21 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > This is the last piece missing to expose the driver to the outside > world. > > This is basically a wrapper between the ioctls and the other logical > blocks. > > v2: > - Rename the driver (pancsf -> panthor) > - Change the license (GPL2 -> MIT + GPL2

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-21 Thread Maxime Ripard
On Mon, Aug 21, 2023 at 12:01:19PM +0200, neil.armstr...@linaro.org wrote: > Hi Maxime, > > On 21/08/2023 10:17, Maxime Ripard wrote: > > Hi, > > > > On Fri, Aug 18, 2023 at 10:25:48AM +0200, neil.armstr...@linaro.org wrote: > > > On 17/08/2023 20:35, Dmitry Baryshkov wrote: > > > > On 16/08/2023

Patch "Revert "drm/edid: Fix csync detailed mode parsing"" has been added to the 6.4-stable tree

2023-08-21 Thread gregkh
This is a note to let you know that I've just added the patch titled Revert "drm/edid: Fix csync detailed mode parsing" to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: reve

Re: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-21 Thread Laurent Pinchart
Hi Biju, On Mon, Aug 14, 2023 at 09:06:46AM +, Biju Das wrote: > Hi Laurent Pinchart, > > Thanks for the feedback. > > > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > > tables > > > > Hi Biju, > > > > Thank you for the patch. > > > > On Sun, Aug 13, 2023 at 09:0

RE: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-21 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > tables > > Hi Biju, > > On Mon, Aug 14, 2023 at 09:06:46AM +, Biju Das wrote: > > Hi Laurent Pinchart, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH] drm

Re: [PATCH] fs: clean up usage of noop_dirty_folio

2023-08-21 Thread Matthew Wilcox
On Mon, Aug 21, 2023 at 01:16:43PM +0200, Jan Kara wrote: > On Sat 19-08-23 20:42:25, Xueshi Hu wrote: > > In folio_mark_dirty(), it will automatically fallback to > > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames emp

Re: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-21 Thread Laurent Pinchart
Hi Biju, On Mon, Aug 21, 2023 at 12:20:39PM +, Biju Das wrote: > > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > > tables > > On Mon, Aug 14, 2023 at 09:06:46AM +, Biju Das wrote: > > > > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF >

Re: [PATCH v3 1/2] drm: bridge: it66121: Extend match support for OF tables

2023-08-21 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Fri, Aug 18, 2023 at 08:18:16PM +0100, Biju Das wrote: > The driver has OF match table, still it uses ID lookup table for > retrieving match data. Currently the driver is working on the > assumption that a I2C device registered via OF will always match a > leg

Re: [PATCH v3 2/2] drm: bridge: it66121: Simplify probe()

2023-08-21 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Fri, Aug 18, 2023 at 08:18:17PM +0100, Biju Das wrote: > Simplify probe() by replacing of_device_get_match_data() and ID lookup > for retrieving match data by i2c_get_match_data(). > > Signed-off-by: Biju Das > Reviewed-by: Andy Shevchenko Reviewed-by: Lau

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Joerg Roedel
On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > The solution is to drop those locking patches entirely and rethink the whole > thing. Agreed, that was exactly what I thought when looking at this patch. I dropped the original 10 patches and the 4 fixes on-top from the IOMMU tree. T

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-21 Thread Steven Price
On 09/08/2023 17:53, Boris Brezillon wrote: > Now that all blocks are available, we can add/update Kconfig/Makefile > files to allow compilation. > > v2: > - Rename the driver (pancsf -> panthor) > - Change the license (GPL2 -> MIT + GPL2) > - Split the driver addition commit > - Add new dependenc

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Jason Gunthorpe
On Mon, Aug 21, 2023 at 02:27:47PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > > The solution is to drop those locking patches entirely and rethink the whole > > thing. > > Agreed, that was exactly what I thought when looking at this patch. > > I d

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Jason Gunthorpe
On Mon, Aug 21, 2023 at 12:06:40PM +0100, Robin Murphy wrote: > On 2023-08-18 22:32, Jason Gunthorpe wrote: > > It is subtle and was never documented or enforced, but there has always > > been an assumption that of_dma_configure_id() is not concurrent. It makes > > several calls into the iommu laye

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread Shashank Sharma
+ Amar should be able to help. Amar, Can you please check this patch (series if required) with a few IGTs and probably with Xonotic as well ? Regards Shashank On 21/08/2023 13:03, Christian König wrote: Am 20.08.23 um 11:51 schrieb Christophe JAILLET: This serie simplifies amdgpu_bo_list

Re: [EXTERNAL] Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-21 Thread Danilo Krummrich
On 8/21/23 10:30, Donald Robson wrote: Hi Danilo, Thanks for the feedback. On the subject of locking, I have dma_resv locking in another branch where I'm trying to enable bind queues, but I didn't think I needed locking for the single, synchronous operations seen here. Would a mutex on the gem

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by:

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches. - Add

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-21 Thread Christian König
Am 18.08.23 um 15:13 schrieb Matthew Brost: On Fri, Aug 18, 2023 at 07:27:33AM +0200, Christian König wrote: Am 17.08.23 um 19:54 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 03:39:40PM +0200, Christian König wrote: Am 11.08.23 um 04:31 schrieb Matthew Brost: Rather than call free_job and r

[PATCH v2] drm/doc: document DRM_IOCTL_MODE_CREATE_DUMB

2023-08-21 Thread Simon Ser
The main motivation is to repeat that dumb buffers should not be abused for anything else than basic software rendering with KMS. User-space devs are more likely to look at the IOCTL docs than to actively search for the driver-oriented "Dumb Buffer Objects" section. v2: reference DRM_CAP_DUMB_BUFF

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-21 Thread Christian König
Hi Mirsad, well this is a false positive. That drm_sched_entity_is_ready() doesn't see the data written by drm_sched_entity_push_job() is part of the logic here. Regards, Christian. Am 18.08.23 um 15:44 schrieb Mirsad Todorovac: On 8/17/23 21:54, Mirsad Todorovac wrote: Hi, This is your f

Re: [PATCH v2 2/2] doc: uapi: Add document describing dma-buf semantics

2023-08-21 Thread Daniel Vetter
On Thu, Aug 03, 2023 at 04:47:29PM +0100, Daniel Stone wrote: > Since there's a lot of confusion around this, document both the rules > and the best practice around negotiating, allocating, importing, and > using buffers when crossing context/process/device/subsystem boundaries. > > This ties up a

Re: [RFC][PATCH 0/2] drm/panic: Add a drm panic handler

2023-08-21 Thread Jocelyn Falempe
On 13/08/2023 04:20, nerdopolis wrote: On Wednesday, August 9, 2023 3:17:27 PM EDT Jocelyn Falempe wrote: This introduces a new drm panic handler, which displays a message when a panic occurs. So when fbcon is disabled, you can still see a kernel panic. This is one of the missing feature, when

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Chr

Re: [PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-08-21 Thread Rob Herring
On Mon, Jul 17, 2023 at 3:17 AM Dmitry Osipenko wrote: > > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyssa,

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Power profile once job finished. - Here, the *_work

Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yad

Re: [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/a

Re: [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_am

Re: [PATCH v2 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-21 Thread Shashank Sharma
Someone from MM should also confirm on this, but: Acked-by: Shashank Sharma On 21/08/2023 08:47, Arvind Yadav wrote: This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_workload_profile* api is added to switch on/off profile mode. These new api will a

Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:13 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koen

Re: [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:16 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signe

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new

Re: [PATCH v2 00/15] drm: Add a driver for FW-based Mali GPUs

2023-08-21 Thread Rob Herring
On Thu, Aug 10, 2023 at 10:44 AM Boris Brezillon wrote: > > Hello Rob, > > On Wed, 9 Aug 2023 14:22:59 -0600 > Rob Herring wrote: > > > On Wed, Aug 9, 2023 at 10:53 AM Boris Brezillon > > wrote: > > > > > > I tried to Cc anyone that was involved in any development of the code > > > I picked from

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Christian König
Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your driver crash because you accidentally overwrite

Re: [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-21 Thread Andi Shyti
Hi Zhanjun, On Fri, Aug 11, 2023 at 11:20:11AM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed > work and intel_gt_reset. > When intel_gt_reset was called, task will hold a lock. > To cacel delayed work here, the _sync version will also acquire

Re: [PATCH -next v2 1/2] drm/panfrost: Do not check for 0 return after calling platform_get_irq_byname()

2023-08-21 Thread Steven Price
On 03/08/2023 05:03, Ruan Jinjie wrote: > It is not possible for platform_get_irq_byname() to return 0. > Use the return value from platform_get_irq_byname(). > > Signed-off-by: Ruan Jinjie Reviewed-by: Steven Price I'll push this to drm-misc-next. Thanks, Steve > --- > drivers/gpu/drm/pan

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:24 PM, Shashank Sharma wrote: On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splittin

Re: [PATCH v5 2/5] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Signed-off-by: André Almeida --- v5: no change v4

Re: [PATCH v5 3/5] drm/amdgpu: Encapsulate all device reset info

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: To better organize struct amdgpu_device, keep all reset information related fields together in a separated struct. Signed-off-by: André Almeida --- v5: new patch, as requested by Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34 +

Re: [PATCH v5 4/5] drm/amdgpu: Move coredump code to amdgpu_reset file

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Giving that we use codedump just for device resets, move it's functions and structs to a more semantic file, the amdgpu_reset.{c, h}. Signed-off-by: André Almeida --- v5: no change --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 --- drivers/gp

Re: [PATCH v5 5/5] drm/amdgpu: Create version number for coredumps

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: Even if there's nothing currently parsing amdgpu's coredump files, if we eventually have such tools they will be glad to find a version field to properly read the file. Create a version number to be displayed on top of coredump file, to be incremented

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 16:12, Yadav, Arvind wrote: On 8/21/2023 7:24 PM, Shashank Sharma wrote: On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup funct

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-21 Thread Mirsad Todorovac
Hi Christian, Thank you for the update. Should I continue reporting what KCSAN gives? I will try to filter these to save your time for evaluation ... Kind regards, Mirsad On 8/21/23 15:20, Christian König wrote: Hi Mirsad, well this is a false positive. That drm_sched_entity_is_ready() doe

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-21 Thread Dmitry Baryshkov
On Fri, 18 Aug 2023 at 16:55, Pekka Paalanen wrote: > > On Fri, 18 Aug 2023 14:03:14 +0300 > Dmitry Baryshkov wrote: > > > On 18/08/2023 13:51, Pekka Paalanen wrote: > > > On Fri, 4 Aug 2023 16:59:00 +0300 > > > Dmitry Baryshkov wrote: > > > > > >> On Fri, 4 Aug 2023 at 16:44, Sebastian Wick >

Re: [PATCH v2] drm/doc: document DRM_IOCTL_MODE_CREATE_DUMB

2023-08-21 Thread Pekka Paalanen
On Mon, 21 Aug 2023 13:15:56 + Simon Ser wrote: > The main motivation is to repeat that dumb buffers should not be > abused for anything else than basic software rendering with KMS. > User-space devs are more likely to look at the IOCTL docs than to > actively search for the driver-oriented "

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Joerg Roedel
On Mon, Aug 21, 2023 at 09:51:13AM -0300, Jason Gunthorpe wrote: > So now that Joerg has dropped it - what is your big idea to make the > locking actually work right? I am not opposed to the general idea. When putting it into the tree I wasn't aware how many users still need to be adapted to prope

Re: [PATCH] iommu: Remove the device_lock_assert() from __iommu_probe_device()

2023-08-21 Thread Jason Gunthorpe
On Mon, Aug 21, 2023 at 04:36:49PM +0200, Joerg Roedel wrote: > On Mon, Aug 21, 2023 at 09:51:13AM -0300, Jason Gunthorpe wrote: > > So now that Joerg has dropped it - what is your big idea to make the > > locking actually work right? > > I am not opposed to the general idea. Well, I think Robin

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 7:09 PM, Shashank Sharma wrote: On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a function which will clear the GPU power profile after job finished. This is how it works: - schedular will set the GPU power profile based on ring_type. - Schedular will clear the GPU Powe

Re: [PATCH] drm/panfrost: Skip speed binning on EOPNOTSUPP

2023-08-21 Thread Steven Price
On 16/08/2023 10:45, Steven Price wrote: > On 16/08/2023 02:42, David Michael wrote: >> Encountered on an ARM Mali-T760 MP4, attempting to read the nvmem >> variable can also return EOPNOTSUPP instead of ENOENT when speed >> binning is unsupported. >> >> Cc: >> Fixes: 7d690f936e9b ("drm/panfrost:

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
> -Original Message- > From: dri-devel On Behalf Of Dave > Airlie > Sent: August 20, 2023 6:21 PM > To: Zeng, Oak > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; Welty, Brian ; dri- > de...@lists.freedesktop.org; intel...@lists.freedesktop.org; Vishwanathapura

RE: Implement svm without BO concept in xe driver

2023-08-21 Thread Zeng, Oak
Accidently deleted Brian. Add back. Thanks, Oak > -Original Message- > From: Zeng, Oak > Sent: August 21, 2023 11:07 AM > To: Dave Airlie > Cc: Brost, Matthew ; Thomas Hellström > ; Philip Yang ; Felix > Kuehling ; dri-devel@lists.freedesktop.org; intel- > x...@lists.freedesktop.org; Vis

Re: [PATCH 1/1] drm/fourcc: Add documentation about software color conversion.

2023-08-21 Thread Maxime Ripard
Hi Pekka, Thanks for answering On Fri, Aug 18, 2023 at 04:24:15PM +0300, Pekka Paalanen wrote: > On Thu, 10 Aug 2023 09:45:27 +0200 > Maxime Ripard wrote: > > On Mon, Aug 07, 2023 at 03:45:15PM +0200, Jocelyn Falempe wrote: > > > After discussions on IRC, the consensus is that the DRM drivers sh

Re: [PATCH 1/2] drm/panfrost: Add fdinfo support to Panfrost

2023-08-21 Thread Steven Price
On 08/08/2023 23:22, Adrián Larumbe wrote: > We calculate the amount of time the GPU spends on a job with ktime samples, > and then add it to the cumulative total for the open DRM file, which is > what will be eventually exposed through the 'fdinfo' DRM file descriptor. > > Signed-off-by: Adrián L

Re: [PATCH 2/2] drm/panfrost: Add drm memory stats display through fdinfo

2023-08-21 Thread Steven Price
On 08/08/2023 23:22, Adrián Larumbe wrote: > For drm_show_memory_stats to produce a more accurate report, provide a new > Panfrost DRM object callback that decides whether an object is resident in > memory or eligible for purging. > > Signed-off-by: Adrián Larumbe > --- > drivers/gpu/drm/panfros

Re: [PATCH v2 05/15] drm/panthor: Add the GPU logical block

2023-08-21 Thread Robin Murphy
On 2023-08-14 11:54, Steven Price wrote: [...] +/** + * panthor_gpu_l2_power_on() - Power-on the L2-cache + * @ptdev: Device. + * + * Return: 0 on success, a negative error code otherwise. + */ +int panthor_gpu_l2_power_on(struct panthor_device *ptdev) +{ + u64 core_mask = U64_MAX; + +

Re: [PATCH v3 2/5] dt-bindings: display: tegra: nvidia,tegra20-dc: Add parallel RGB output port node

2023-08-21 Thread Rob Herring
On Mon, Aug 07, 2023 at 05:35:12PM +0300, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Either this node, which is optional, or the nvidia,panel property can be > present. > > Signed-off-by: Maxim Schwalm > Signed-off-by: Svyatoslav Ryhel > --- > .../display/tegra/nvidia,tegra20-dc.yaml

Re: [PATCH] gpu: drm: i915: fix documentation style

2023-08-21 Thread Jani Nikula
On Mon, 21 Aug 2023, "Ricardo B. Marliere" wrote: > This patch fixes the following sphinx warnings in the htmldocs make target: > > Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/intel_huc.c:29: > ERROR: Unexpected indentation. > Documentation/gpu/i915:546: ./drivers/gpu/drm/i915/gt/uc/

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Alex Deucher
On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: > > This patch adds a function which will change the GPU > power profile based on a submitted job. This can optimize > the power performance when the workload is on. > > v2: > - Splitting workload_profile_set and workload_profile_put > into two

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-08-21 Thread Daniel Thompson
On Sun, Aug 20, 2023 at 11:41:18AM +0200, Julius Zint wrote: > The HID spec defines the following Usage IDs (p. 345 ff): > > - Monitor Page (0x80) -> Monitor Control (0x01) > - VESA Virtual Controls Page (0x82) -> Brightness (0x10) > > Apple made use of them in their Apple Studio Display and most l

Re: [PATCH 3/6] dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'

2023-08-21 Thread Rob Herring
On Thu, Aug 10, 2023 at 04:44:48PM +0200, Alexander Stein wrote: > Although defined in synopsys,dw-hdmi.yaml, they need to explicitly allowed > in fsl,imx6-hdmi.yaml. Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: hdmi@12: 'interrupts', > 'reg' do not match any of the regexes:

Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

2023-08-21 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote: > MAC address can be provided by a nvmem-cell, thus allow referencing a > source for the address. Fixes the warning: > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names', > 'nvmem-cells' do not match any of the reg

Re: [PATCH 5/6] dt-bindings: timer: add imx7d compatible

2023-08-21 Thread Rob Herring
On Thu, 10 Aug 2023 16:44:50 +0200, Alexander Stein wrote: > Currently the dtbs_check for imx6ul generates warnings like this: > > ['fsl,imx7d-gpt', 'fsl,imx6sx-gpt'] is too long > > The driver has no special handling for fsl,imx7d-gpt, so fsl,imx6sx-gpt is > used. Therefore make imx7d GPT comp

Re: [PATCH v2 2/2] doc: uapi: Add document describing dma-buf semantics

2023-08-21 Thread Simon Ser
Pushed to drm-misc-next with minor edits. Thanks!

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread Bjorn Helgaas
On Fri, Aug 18, 2023 at 09:48:46AM +0800, suijingfeng wrote: > On 2023/8/18 06:08, Bjorn Helgaas wrote: > > > + if (resource_type(res) != IORESOURCE_MEM) > > > + continue; > > > + > > > + if (!res->start || !res->end) > > > + continue; > > > + > > > +

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-21 Thread Bjorn Helgaas
On Fri, Aug 18, 2023 at 12:09:29PM +0800, suijingfeng wrote: > On 2023/8/18 06:08, Bjorn Helgaas wrote: > > On Wed, Aug 16, 2023 at 06:05:27AM +0800, Sui Jingfeng wrote: > > > Currently, the vga_is_firmware_default() function only works on x86 and > > > ia64, it is a no-op on ARM, ARM64, PPC, RISC-

Re: [PATCH 1/3] drm/buddy: Fix contiguous memory allocation issues

2023-08-21 Thread Matthew Auld
Hi, On 21/08/2023 11:14, Arunpravin Paneer Selvam wrote: The way now contiguous requests are implemented such that the size rounded up to power of 2 and the corresponding order block picked from the freelist. In addition to the older method, the new method will rounddown the size to power of 2

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Yadav, Arvind
On 8/21/2023 9:52 PM, Alex Deucher wrote: On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: This patch adds a function which will change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. v2: - Splitting workload_profile_set and

Re: [PATCH v2 13/15] drm/panthor: Allow driver compilation

2023-08-21 Thread Robin Murphy
On 2023-08-14 12:18, Steven Price wrote: On 11/08/2023 20:26, Robin Murphy wrote: On 2023-08-11 17:56, Daniel Stone wrote: Hi, On 11/08/2023 17:35, Robin Murphy wrote: On 2023-08-09 17:53, Boris Brezillon wrote: +obj-$(CONFIG_DRM_PANTHOR) += panthor.o FWIW I still think it would be nice to

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-21 Thread Danilo Krummrich
On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your drive

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Alex Deucher
On Mon, Aug 21, 2023 at 2:55 AM Arvind Yadav wrote: > > This patch adds a function which will change the GPU > power profile based on a submitted job. This can optimize > the power performance when the workload is on. > > v2: > - Splitting workload_profile_set and workload_profile_put > into two

  1   2   >