Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-26 Thread Dave Chinner
On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: > Currently, the shrinker instances can be divided into the following three > types: > > a) global shrinker instance statically defined in the kernel, such as >workingset_shadow_shrinker. > > b) global shrinker instance statically defi

Re: [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 25/07/2023 13:46, Marijn Suijten wrote: > On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >> Example DTS should not have 'status' property. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml | 6 -- > > This is not needed: it h

Re: [PATCH v2 08/47] erofs: dynamically allocate the erofs-shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the erofs-shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-26 Thread Muchun Song
On 2023/7/24 17:43, Qi Zheng wrote: Currently, the shrinker instances can be divided into the following three types: a) global shrinker instance statically defined in the kernel, such as workingset_shadow_shrinker. b) global shrinker instance statically defined in the kernel modules, suc

Re: [PATCH][next] accel/qaic: remove redundant assignment to pointer pexec

2023-07-26 Thread Carl Vanderlip
On 7/25/2023 4:40 AM, Colin Ian King wrote: Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King Reviewed-by: Carl Vanderlip

Re: [PATCH v2 09/47] f2fs: dynamically allocate the f2fs-shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the f2fs-shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

[PATCH] drm: Fix format error

2023-07-26 Thread wuyonggang001
Fix the error(s): ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Yonggang Wu --- drivers/gpu/drm/drm_legacy.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_legacy.h b/drivers/gpu/drm/drm_legacy.h index 70c9dba114a6..f098a48cbdf4 100644 ---

Re: [PATCH v2 10/47] gfs2: dynamically allocate the gfs2-glock shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the gfs2-glock shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

Re: [PATCH v2 22/47] drm/i915: dynamically allocate the i915_gem_mm shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the i915_gem_mm shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Roger Sewell
Thomas, Thank you for your reply. >> Table 10 in the following document says that 1440x900@60Hz is >> supported: >> https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf > > That manual says that the resolution is only

Re: [PATCH v2 16/47] ubifs: dynamically allocate the ubifs-slab shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the ubifs-slab shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 04/47] kvm: mmu: dynamically allocate the x86-mmu shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the x86-mmu shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

Re: [PATCH v2 15/47] quota: dynamically allocate the dquota-cache shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the dquota-cache shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 21/47] mm: workingset: dynamically allocate the mm-shadow shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the mm-shadow shrinker. > > Signed-off-by: Qi Zheng > --- > mm/workingset.c | 26 ++ > 1 file changed, 14 insertions(+), 12 deletions(-) > > diff --git a/mm/workingset.c b/mm/working

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-26 Thread wuyonggang001
Fix the error(s): ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Yonggang Wu --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1940bb26d..93acb0e42bd6 100644

Re: [PATCH v2 11/47] gfs2: dynamically allocate the gfs2-qd shrinker

2023-07-26 Thread Muchun Song
On 2023/7/24 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the gfs2-qd shrinker. Signed-off-by: Qi Zheng --- fs/gfs2/main.c | 6 +++--- fs/gfs2/quota.c | 26 -- fs/gfs2/quota.h | 3 ++- 3 files changed, 25 insertions(+), 10 deletions(-) diff --g

Re: [PATCH v2 06/47] drm/ttm: dynamically allocate the drm-ttm_pool shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the drm-ttm_pool shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

Re: [PATCH v2 14/47] nfsd: dynamically allocate the nfsd-filecache shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the nfsd-filecache shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 26/47] dm zoned: dynamically allocate the dm-zoned-meta shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the dm-zoned-meta shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical sectio

Re: [PATCH v2 07/47] xenbus/backend: dynamically allocate the xen-backend shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the xen-backend shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.

Re: [PATCH v2 12/47] NFSv4.2: dynamically allocate the nfs-xattr shrinkers

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the nfs-xattr shrinkers. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 18/47] rcu: dynamically allocate the rcu-kfree shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-kfree shrinker. > > Signed-off-by: Qi Zheng > --- > kernel/rcu/tree.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/t

Re: [PATCH v2 20/47] sunrpc: dynamically allocate the sunrpc_cred shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the sunrpc_cred shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 25/47] dm: dynamically allocate the dm-bufio shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the dm-bufio shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section whe

Re: [PATCH v2 27/47] md/raid5: dynamically allocate the md-raid5 shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the md-raid5 shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section whe

Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the rcu-lazy shrinker. > > Signed-off-by: Qi Zheng > --- > kernel/rcu/tree_nocb.h | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/kernel/rcu/tree_nocb.h b/kerne

Re: [PATCH v2 19/47] mm: thp: dynamically allocate the thp-related shrinkers

2023-07-26 Thread Muchun Song
On 2023/7/24 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the thp-zero and thp-deferred_split shrinkers. Signed-off-by: Qi Zheng --- mm/huge_memory.c | 69 +++- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/mm/hu

Re: [PATCH v2 13/47] nfs: dynamically allocate the nfs-acl shrinker

2023-07-26 Thread Muchun Song
> On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > Use new APIs to dynamically allocate the nfs-acl shrinker. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song

Re: [PATCH v2 23/47] drm/msm: dynamically allocate the drm-msm_gem shrinker

2023-07-26 Thread Muchun Song
On 2023/7/24 17:43, Qi Zheng wrote: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-msm_gem shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-side critical section when releasing the

Re: [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 26/07/2023 09:27, Krzysztof Kozlowski wrote: > On 25/07/2023 13:46, Marijn Suijten wrote: >> On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >>> Example DTS should not have 'status' property. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> .../devicetree/bindings/display/msm/qcom,sm6

Re: [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Dmitry Baryshkov
On 26/07/2023 10:31, Krzysztof Kozlowski wrote: On 26/07/2023 09:27, Krzysztof Kozlowski wrote: On 25/07/2023 13:46, Marijn Suijten wrote: On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: Example DTS should not have 'status' property. Signed-off-by: Krzysztof Kozlowski --- .../devicetree

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-26 Thread Timur Kristóf
On Tue, 2023-07-25 at 19:00 +0200, Michel Dänzer wrote: > On 7/25/23 17:05, Marek Olšák wrote: > > On Tue, Jul 25, 2023 at 4:03 AM Michel Dänzer > > wrote: > > > On 7/25/23 04:55, André Almeida wrote: > > > > Hi everyone, > > > > > > > > It's not clear what we should do about non-robust OpenGL ap

Re: [PATCH] drm/shmem-helper: Reset vma->vm_ops before calling dma_buf_mmap()

2023-07-26 Thread Boris Brezillon
On Tue, 25 Jul 2023 20:50:43 +0200 Thomas Zimmermann wrote: > Hi > > Am 24.07.23 um 13:26 schrieb Boris Brezillon: > > The dma-buf backend is supposed to provide its own vm_ops, but some > > implementation just have nothing special to do and leave vm_ops > > untouched, probably expecting this fi

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-07-26 Thread Benjamin Tissoires
On Jul 25 2023, Doug Anderson wrote: > Hi, > > On Mon, Jul 17, 2023 at 11:15 AM Doug Anderson wrote: > > > > Benjamin, > > > > On Mon, Jun 26, 2023 at 3:49 PM Doug Anderson wrote: > > > > > > Benjamin, > > > > > > On Thu, Jun 8, 2023 at 8:37 AM Benjamin Tissoires > > > wrote: > > > > > > > > >

Re: Non-robust apps and resets (was Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations)

2023-07-26 Thread Michel Dänzer
On 7/25/23 15:02, André Almeida wrote: > Em 25/07/2023 05:03, Michel Dänzer escreveu: >> On 7/25/23 04:55, André Almeida wrote: >>> Hi everyone, >>> >>> It's not clear what we should do about non-robust OpenGL apps after GPU >>> resets, so I'll try to summarize the topic, show some options and my

Re: [PATCH v2 44/47] mm: shrinker: make global slab shrink lockless

2023-07-26 Thread Dave Chinner
On Mon, Jul 24, 2023 at 05:43:51PM +0800, Qi Zheng wrote: > The shrinker_rwsem is a global read-write lock in shrinkers subsystem, > which protects most operations such as slab shrink, registration and > unregistration of shrinkers, etc. This can easily cause problems in the > following cases. > >

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 25/07/2023 21:37, Thomas Zimmermann wrote: Hi Roger, thanks for all the information. Am 24.07.23 um 22:57 schrieb Roger Sewell: Thomas, Hello, I'm the user who reported the issue. Definitely happy to help you sort this out if I can, though my response speed will decrease when term restarts

Re: [drm-misc:for-linux-next 2/2] drivers/gpu/drm/drm_debugfs.c:212:33: sparse: sparse: non size-preserving pointer to integer cast

2023-07-26 Thread Boris Brezillon
On Wed, 26 Jul 2023 00:25:36 +0200 Danilo Krummrich wrote: > On 7/24/23 09:27, Boris Brezillon wrote: > > On Fri, 21 Jul 2023 02:06:16 +0800 > > kernel test robot wrote: > > > >> tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next > >> head: c7a472297169156252a50d76965eb36b081

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 25/07/2023 23:31, Roger Sewell wrote: Thomas, Thank you for your reply. Table 10 in the following document says that 1440x900@60Hz is supported: https://www.intel.com/content/dam/support/us/en/documents/motherboards/server/s5520ur/sb/e44031012_s5520ur_s5520urt_tps_r1_9.pdf That manual s

[PATCH v3 0/6] drm/mediatek: Small mtk-dpi cleanups

2023-07-26 Thread AngeloGioacchino Del Regno
Changes in v3: - Fixed removal of mtk_dpi pointer in mtk_dpi_remove on patch [1/6] instead of patch [3/6]; thanks CK Hu! Changes in v2: - Removed drm_bridge_remove() call in patch 1 - Added dev_err_probe print to devm_drm_of_get_bridge() call error handling - Switched to devm_platform_io

[PATCH v3 1/6] drm/mediatek: mtk_dpi: Simplify with devm_drm_bridge_add()

2023-07-26 Thread AngeloGioacchino Del Regno
Change drm_bridge_add() to its devm variant to slightly simplify the probe function. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_d

[PATCH v3 6/6] drm/mediatek: mtk_dpi: Compress struct of_device_id entries

2023-07-26 Thread AngeloGioacchino Del Regno
Reduce line count by compressing the entries of struct of_device_id; while at it, also add the usual /* sentinel */ comment to the last entry. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/medi

[PATCH v3 2/6] drm/mediatek: mtk_dpi: Simplify with dev_err_probe()

2023-07-26 Thread AngeloGioacchino Del Regno
Use dev_err_probe() across the entire probe function of this driver to shrink the size. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 44 ++ 1 file changed, 14 insertions(+), 30 deletions

[PATCH v3 3/6] drm/mediatek: mtk_dpi: Switch to devm_drm_of_get_bridge()

2023-07-26 Thread AngeloGioacchino Del Regno
Function drm_of_find_panel_or_bridge() is marked as deprecated: since the usage of that in this driver exactly corresponds to the new function devm_drm_of_get_bridge(), switch to it. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao --- drivers/gpu/drm/mediatek/mtk_dpi.c | 8

[PATCH v3 4/6] drm/mediatek: mtk_dpi: Switch to .remove_new() void callback

2023-07-26 Thread AngeloGioacchino Del Regno
The .remove() callback cannot fail: switch to .remove_new() and change mtk_dpi_remove() to void. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_dpi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/

[PATCH v3 5/6] drm/mediatek: mtk_dpi: Use devm_platform_ioremap_resource()

2023-07-26 Thread AngeloGioacchino Del Regno
Instead of the open-coded platform_get_resource, devm_ioremap_resource switch to devm_platform_ioremap_resource(), also dropping the useless struct resource pointer, which becomes unused. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Fei Shao Reviewed-by: CK Hu --- drivers/gpu/drm/me

Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB

2023-07-26 Thread Sam Ravnborg
On Tue, Jul 25, 2023 at 09:53:16PM +0200, Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > Hi > > > > [...] > > >> > >> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to > >> source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends > >>

Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB

2023-07-26 Thread Javier Martinez Canillas
Sam Ravnborg writes: > On Tue, Jul 25, 2023 at 09:53:16PM +0200, Javier Martinez Canillas wrote: >> Thomas Zimmermann writes: >> >> > Hi >> > >> >> [...] >> >> >> >> >> Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to >> >> source its Kconfig from drivers/fbdev/core

Re: [PATCH v6 1/2] drm/ast: Add BMC virtual connector

2023-07-26 Thread Jocelyn Falempe
On 13/07/2023 15:41, Jocelyn Falempe wrote: Most aspeed devices have a BMC, which allows to remotely see the screen. Also in the common use case, those servers don't have a display connected. So add a Virtual connector, to reflect that even if no display is connected, the framebuffer can still be

Re: [PATCH v3 08/10] HID: i2c-hid: Support being a panel follower

2023-07-26 Thread Benjamin Tissoires
On Jul 25 2023, Douglas Anderson wrote: > As talked about in the patch ("drm/panel: Add a way for other devices > to follow panel state"), we really want to keep the power states of a > touchscreen and the panel it's attached to in sync with each other. In > that spirit, add support to i2c-hid to b

Re: [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Marijn Suijten
On 2023-07-26 10:42:24, Dmitry Baryshkov wrote: > On 26/07/2023 10:31, Krzysztof Kozlowski wrote: > > On 26/07/2023 09:27, Krzysztof Kozlowski wrote: > >> On 25/07/2023 13:46, Marijn Suijten wrote: > >>> On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: > Example DTS should not have 'status'

Re: [PATCH v2 44/47] mm: shrinker: make global slab shrink lockless

2023-07-26 Thread Qi Zheng
Hi Dave, On 2023/7/26 16:08, Dave Chinner wrote: On Mon, Jul 24, 2023 at 05:43:51PM +0800, Qi Zheng wrote: The shrinker_rwsem is a global read-write lock in shrinkers subsystem, which protects most operations such as slab shrink, registration and unregistration of shrinkers, etc. This can easil

Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker

2023-07-26 Thread Qi Zheng
Hi Dave, On 2023/7/26 15:26, Dave Chinner wrote: On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: Currently, the shrinker instances can be divided into the following three types: a) global shrinker instance statically defined in the kernel, such as workingset_shadow_shrinker. b)

Re: [PATCH v2 11/47] gfs2: dynamically allocate the gfs2-qd shrinker

2023-07-26 Thread Qi Zheng
On 2023/7/26 14:49, Muchun Song wrote: On 2023/7/24 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the gfs2-qd shrinker. Signed-off-by: Qi Zheng ---   fs/gfs2/main.c  |  6 +++---   fs/gfs2/quota.c | 26 --   fs/gfs2/quota.h |  3 ++-   3 files changed, 2

Re: [PATCH v2 17/47] rcu: dynamically allocate the rcu-lazy shrinker

2023-07-26 Thread Qi Zheng
On 2023/7/26 15:04, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the rcu-lazy shrinker. Signed-off-by: Qi Zheng --- kernel/rcu/tree_nocb.h | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/kernel

Re: [PATCH v2 19/47] mm: thp: dynamically allocate the thp-related shrinkers

2023-07-26 Thread Qi Zheng
On 2023/7/26 15:10, Muchun Song wrote: On 2023/7/24 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the thp-zero and thp-deferred_split shrinkers. Signed-off-by: Qi Zheng ---   mm/huge_memory.c | 69 +++-   1 file changed, 45 insertio

Re: [PATCH v2 21/47] mm: workingset: dynamically allocate the mm-shadow shrinker

2023-07-26 Thread Qi Zheng
On 2023/7/26 15:13, Muchun Song wrote: On Jul 24, 2023, at 17:43, Qi Zheng wrote: Use new APIs to dynamically allocate the mm-shadow shrinker. Signed-off-by: Qi Zheng --- mm/workingset.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/mm/w

Re: [PATCH v2 23/47] drm/msm: dynamically allocate the drm-msm_gem shrinker

2023-07-26 Thread Qi Zheng
On 2023/7/26 15:24, Muchun Song wrote: On 2023/7/24 17:43, Qi Zheng wrote: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the drm-msm_gem shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read

Re: [PATCH v2 28/47] bcache: dynamically allocate the md-bcache shrinker

2023-07-26 Thread Qi Zheng
On 2023/7/26 15:32, Muchun Song wrote: On 2023/7/24 17:43, Qi Zheng wrote: In preparation for implementing lockless slab shrink, use new APIs to dynamically allocate the md-bcache shrinker, so that it can be freed asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU read-s

Re: [PATCH v3] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-26 Thread Simon Ser
Overall looks pretty good to me, a few comments below. On Friday, July 21st, 2023 at 20:50, Erik Kurzinger wrote: > diff --git a/lib/igt_syncobj.h b/lib/igt_syncobj.h > index e6725671d..01f5f062b 100644 > --- a/lib/igt_syncobj.h > +++ b/lib/igt_syncobj.h > @@ -34,7 +34,9 @@ int __syncobj_handle

Re: [PATCH v3] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-26 Thread Simon Ser
On Wednesday, July 26th, 2023 at 11:41, Simon Ser wrote: > Overall looks pretty good to me, a few comments below. Ooops, that reply was meant for IGT… Re-sending it there.

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Maxime Ripard
On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: > > --- a/drivers/gpu/drm/solomon/ssd130x.c > > +++ b/drivers/gpu/drm/solomon/ssd130x.c > > @@ -141,12 +141,26 @@ const struct ssd130x_deviceinfo ssd130x_variants[] = { > > }; > > EXPORT_SYMBOL_NS_GPL(ssd130x_variants, DRM_SSD130

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-26 Thread Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone. What's the status wrt to this regression (caused by 8ddce13ae69 from Marek)? It looks like things are stalled and the regression still is unresolved, but I ask because I migh

Re: [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Maarten Lankhorst
Hey, On 2023-07-22 00:21, Tejun Heo wrote: On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote: $ cat drm.memory.stat card0 region=system total=12898304 shared=0 active=0 resident=12111872 purgeable=167936 card0 region=stolen-system total=0 shared=0 active=0 resident=0 purg

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: >> > --- a/drivers/gpu/drm/solomon/ssd130x.c >> > +++ b/drivers/gpu/drm/solomon/ssd130x.c >> > @@ -141,12 +141,26 @@ const struct ssd130x_deviceinfo ssd130x_variants[] = >> > { >> > }; >>

[PATCH v5 1/2] drm/ssd130x: Inline the ssd130x_buf_{alloc, free}() function helpers

2023-07-26 Thread Javier Martinez Canillas
There is only a single caller for both helper functions and these don't do much other than allocate and free two buffers, so let's just inline them. Suggested-by: Geert Uytterhoeven Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/solomon/ssd130x.c | 55 ++

[PATCH v5 2/2] drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback

2023-07-26 Thread Javier Martinez Canillas
Drivers are not allowed to fail after drm_atomic_helper_swap_state() has been called and the new atomic state is stored into the current sw state. Since the struct ssd130x_device .data_array is allocated in the encoder's .atomic_enable callback, the operation can fail and this is after the new sta

Re: [PATCH -next] drm/bridge: fix -Wunused-const-variable= warning

2023-07-26 Thread Uwe Kleine-König
[Cc += Arnd, Andy who did similar changes in the past] Hello, On Wed, Jul 26, 2023 at 06:06:26PM +0800, Zhu Wang wrote: > When building with W=1, the following warning occurs. > > drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c:48:17: warning: > ‘anx781x_i2c_addresses’ defined but not used [

Re: [PATCH v5 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-26 Thread Krzysztof Kozlowski
On 13/07/2023 18:52, Amit Pundir wrote: > Add and document the reserved memory region property in the > mdss-common schema. > > For now (sdm845-db845c), it points to a framebuffer memory > region reserved by the bootloader for splash screen. > > Signed-off-by: Amit Pundir > --- Acked-by: Krzysz

Re: [PATCH v5 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
On 13/07/2023 18:52, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > Signed-off-by: Amit Pundir > --- I think your commit msg misses describing the actual problem, impact to users and finally cc-stable. B

Re: [PATCH -next] drm/bridge: fix -Wunused-const-variable= warning

2023-07-26 Thread Arnd Bergmann
On Wed, Jul 26, 2023, at 12:54, Uwe Kleine-König wrote: > On Wed, Jul 26, 2023 at 06:06:26PM +0800, Zhu Wang wrote: >> >> Fixes: 5d97408e0d70 ("drm/bridge: move ANA78xx driver to analogix >> subdirectory") This is the wrong commit, the driver was just in a different place before that, and the bug

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Jocelyn Falempe
On 26/07/2023 12:11, Roger Sewell wrote: Jocelyn, How can I check for sure whether I am using 24 or 32 bits per pixel ? The easiest solution if you already rebuilt your kernel is to print the variable bpp here: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/mgag200/mgag200_m

Re: [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-26 Thread Tvrtko Ursulin
On 26/07/2023 11:14, Maarten Lankhorst wrote: Hey, On 2023-07-22 00:21, Tejun Heo wrote: On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote:    $ cat drm.memory.stat    card0 region=system total=12898304 shared=0 active=0 resident=12111872 purgeable=167936    card0 region=stolen

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Jul 26, 2023 at 12:00 PM Maxime Ripard wrote: > On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: > > > --- a/drivers/gpu/drm/solomon/ssd130x.c > > > +++ b/drivers/gpu/drm/solomon/ssd130x.c > > > @@ -141,12 +141,26 @@ const struct ssd130x_deviceinfo ssd130x_va

Re: [PATCH v5 2/2] drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback

2023-07-26 Thread Geert Uytterhoeven
Hi Javier, On Wed, Jul 26, 2023 at 12:55 PM Javier Martinez Canillas wrote: > Drivers are not allowed to fail after drm_atomic_helper_swap_state() has > been called and the new atomic state is stored into the current sw state. > > Since the struct ssd130x_device .data_array is allocated in the en

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Wed, Jul 26, 2023 at 12:00 PM Maxime Ripard wrote: >> On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: >> > > --- a/drivers/gpu/drm/solomon/ssd130x.c >> > > +++ b/drivers/gpu/drm/solomon/ssd130x.c >> > > @@ -141,12 +

Re: [PATCH v5 2/2] drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback

2023-07-26 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Javier, > > On Wed, Jul 26, 2023 at 12:55 PM Javier Martinez Canillas > wrote: >> Drivers are not allowed to fail after drm_atomic_helper_swap_state() has >> been called and the new atomic state is stored into the current sw state. >> >> Since the struct ssd130x_d

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Geert Uytterhoeven
Hi Javier, On Wed, Jul 26, 2023 at 2:22 PM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Wed, Jul 26, 2023 at 12:00 PM Maxime Ripard wrote: > >> On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: > >> > > --- a/drivers/gpu/drm/solomon/ssd130x.c > >> > > ++

Re: [PATCH v3 02/10] drm/panel: Check for already prepared/enabled in drm_panel

2023-07-26 Thread Maxime Ripard
Hi, On Tue, Jul 25, 2023 at 01:34:37PM -0700, Douglas Anderson wrote: > NOTE: arguably, the right thing to do here is actually to skip this > patch and simply remove all the extra checks from the individual > drivers. Perhaps the checks were needed at some point in time in the > past but maybe the

Re: [PATCH v5 1/2] drm/ssd130x: Inline the ssd130x_buf_{alloc, free}() function helpers

2023-07-26 Thread Geert Uytterhoeven
On Wed, Jul 26, 2023 at 12:55 PM Javier Martinez Canillas wrote: > There is only a single caller for both helper functions and these don't do > much other than allocate and free two buffers, so let's just inline them. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Javier Martinez Canillas

Re: [PATCH v3 00/10] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-07-26 Thread Maxime Ripard
On Tue, 25 Jul 2023 13:34:35 -0700, Douglas Anderson wrote: > > The big motivation for this patch series is mostly described in the patch > ("drm/panel: Add a way for other devices to follow panel state"), but to > quickly summarize here: for touchscreens that are connected to a panel we > need th

[PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-26 Thread Amit Pundir
Add and document the reserved memory region property in the mdss-common schema. For now (sdm845-db845c), it points to a framebuffer memory region reserved by the bootloader for splash screen. Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring Signed-off-by: Amit Pundir --- v6: Re-sending w

[PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Amit Pundir
Adding a reserved memory region for the framebuffer memory (the splash memory region set up by the bootloader). It fixes a kernel panic (arm-smmu: Unhandled context fault at this particular memory region) reported on DB845c running v5.10.y. Cc: sta...@vger.kernel.org # v5.10+ Reviewed-by: Caleb C

Re: [PATCH] drm/i915: Do not disable preemption for resets

2023-07-26 Thread Sebastian Andrzej Siewior
On 2023-07-05 10:30:25 [+0100], Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit ade8a0f59844 ("drm/i915: Make all GPU resets atomic") added a > preempt disable section over the hardware reset callback to prepare the > driver for being able to reset from atomic contexts. > … This looks l

Re: [PATCH][next] accel/qaic: remove redundant assignment to pointer pexec

2023-07-26 Thread Pranjal Ramajor Asha Kanojiya
On 7/26/2023 8:30 AM, Jeffrey Hugo wrote: On 7/25/2023 5:40 AM, Colin Ian King wrote: Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King ---   drivers/accel/qaic/qaic_data.c | 1 -   1 file changed,

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Maxime Ripard
Hi, On Wed, Jul 26, 2023 at 01:52:37PM +0200, Geert Uytterhoeven wrote: > On Wed, Jul 26, 2023 at 12:00 PM Maxime Ripard wrote: > > On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: > > > > --- a/drivers/gpu/drm/solomon/ssd130x.c > > > > +++ b/drivers/gpu/drm/solomon/ssd130x.c >

Re: [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
On 26/07/2023 15:27, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > It fixes a kernel panic (arm-smmu: Unhandled context fault > at this particular memory region) reported on DB845c running > v5.10.y. > >

Re: [PATCH][next] accel/qaic: remove redundant assignment to pointer pexec

2023-07-26 Thread Colin King (gmail)
On 26/07/2023 14:38, Pranjal Ramajor Asha Kanojiya wrote: On 7/26/2023 8:30 AM, Jeffrey Hugo wrote: On 7/25/2023 5:40 AM, Colin Ian King wrote: Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King ---

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Maxime Ripard
On Wed, Jul 26, 2023 at 02:33:06PM +0200, Geert Uytterhoeven wrote: > > >> Also, Javier pointed me to a discussion you had on IRC about using devm > > >> allocation here. We can't really do that. KMS devices are only freed > > >> once the last userspace application closes its fd to the device file,

[PATCH][V2][next] accel/qaic: remove redundant pointer pexec

2023-07-26 Thread Colin Ian King
Pointer pexec is being assigned a value however it is never read. The assignment is redundant and can be removed. Replace sizeof(*pexec) with sizeof the type and remove the declaration of pointer pexec. Signed-off-by: Colin Ian King --- V2: completely remove the declaration of pexec and replace

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Geert Uytterhoeven
Hi Maxime, On Wed, Jul 26, 2023 at 3:54 PM Maxime Ripard wrote: > On Wed, Jul 26, 2023 at 02:33:06PM +0200, Geert Uytterhoeven wrote: > > > >> Also, Javier pointed me to a discussion you had on IRC about using devm > > > >> allocation here. We can't really do that. KMS devices are only freed > >

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, > Hi, > > On Wed, Jul 26, 2023 at 01:52:37PM +0200, Geert Uytterhoeven wrote: >> On Wed, Jul 26, 2023 at 12:00 PM Maxime Ripard wrote: >> > On Tue, Jul 25, 2023 at 09:21:52PM +0200, Geert Uytterhoeven wrote: [...] >> The second buffer (containing the hardwa

Re: [PATCH v4] drm/ssd130x: Allocate buffers in the plane's .atomic_check callback

2023-07-26 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Maxime, > > On Wed, Jul 26, 2023 at 3:54 PM Maxime Ripard wrote: >> On Wed, Jul 26, 2023 at 02:33:06PM +0200, Geert Uytterhoeven wrote: >> > > >> Also, Javier pointed me to a discussion you had on IRC about using >> > > >> devm >> > > >> allocation

Re: [PATCH v5 1/2] drm/ssd130x: Inline the ssd130x_buf_{alloc,free}() function helpers

2023-07-26 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > On Wed, Jul 26, 2023 at 12:55 PM Javier Martinez Canillas > wrote: >> There is only a single caller for both helper functions and these don't do >> much other than allocate and free two buffers, so let's just inline them. >> >> Suggested-by: Geert Uytterhoeven >> Si

Re: [PATCH v5 2/2] drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback

2023-07-26 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Drivers are not allowed to fail after drm_atomic_helper_swap_state() has > been called and the new atomic state is stored into the current sw state. > > Since the struct ssd130x_device .data_array is allocated in the encoder's > .atomic_enable callback, the oper

Re: [PATCH v2] gpu: drm: Use dev_err_probe instead of dev_err

2023-07-26 Thread Laurent Pinchart
Hi Wang, Thank you for the patch. On Wed, Jul 26, 2023 at 07:57:56PM +0800, Wang Ming wrote: > It is possible that dma_request_chan will return EPROBE_DEFER, > which means that disp->dev is not ready yet. In this case, > dev_err(disp->dev), there will be no output. This patch fixes the bug. It's

Re: [PATCH v3 02/10] drm/panel: Check for already prepared/enabled in drm_panel

2023-07-26 Thread Doug Anderson
Hi, On Wed, Jul 26, 2023 at 5:41 AM Maxime Ripard wrote: > > Hi, > > On Tue, Jul 25, 2023 at 01:34:37PM -0700, Douglas Anderson wrote: > > NOTE: arguably, the right thing to do here is actually to skip this > > patch and simply remove all the extra checks from the individual > > drivers. Perhaps

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Thomas Zimmermann
Hi Am 26.07.23 um 12:11 schrieb Roger Sewell: Jocelyn, How can I check for sure whether I am using 24 or 32 bits per pixel ? The easiest solution if you already rebuilt your kernel is to print the variable bpp here: https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/mgag200/mgag

Re: [PATCH v4 04/17] dt-bindings: display/msm: Remove DSI1 ports from SM6350/SM6375 example

2023-07-26 Thread Rob Herring
On Sun, 23 Jul 2023 18:08:42 +0200, Marijn Suijten wrote: > Both SM6350 and SM6375 support only a single DSI link, and don't have a > corresponding dsi1 node in DTS. Their examples should not suggest an > output interface port on the display-controller node to this inexistant > DSI host, with a

Re: [PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-26 Thread Thomas Zimmermann
Hi Jocelyn Am 26.07.23 um 10:10 schrieb Jocelyn Falempe: [...] So the old kernel already did the right thing. In the *new* code the nearest-named function I could see issys/class/drm/card1-eDP-1/modes mgag200_mode_config_mode_valid, which returns MODE_OK at the end of the function if the ba

  1   2   >