[PATCH v2 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-20 Thread Ying Liu
Hi, This series aims to add MIPI DSI support for Freescale i.MX93 SoC. There is a Synopsys DesignWare MIPI DSI host controller and a Synopsys Designware MIPI DPHY embedded in i.MX93. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Add a DRM bridge for i.MX93

[PATCH v2 1/9] drm/bridge: synopsys: dw-mipi-dsi: Add dw_mipi_dsi_get_bridge() helper

2023-07-20 Thread Ying Liu
Add dw_mipi_dsi_get_bridge() helper so that it can be used by vendor drivers which implement vendor specific extensions to Synopsys DW MIPI DSI. Signed-off-by: Liu Ying --- v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++ include/drm/bridge/dw_mipi_dsi.h

[PATCH v2 2/9] drm/bridge: synopsys: dw-mipi-dsi: Add input bus format negotiation support

2023-07-20 Thread Ying Liu
Introduce ->get_input_bus_fmts() callback to struct dw_mipi_dsi_plat_data so that vendor drivers can implement specific methods to get input bus formats for Synopsys DW MIPI DSI. While at it, implement a generic callback for ->atomic_get_input_bus_fmts(), where we try to get the input bus formats

[PATCH v2 3/9] drm/bridge: synopsys: dw-mipi-dsi: Force input bus flags

2023-07-20 Thread Ying Liu
The DATAEN_ACTIVE_LOW bit in DSI_DPI_CFG_POL register is set to zero, so set the DRM_BUS_FLAG_DE_HIGH flag in input_bus_cfg.flags. It appears that the DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE flag also makes sense, so set it in input_bus_cfg.flags too. With this patch, the flags set by drm_atomic_brid

[PATCH v2 4/9] drm/bridge: synopsys: dw-mipi-dsi: Add mode fixup support

2023-07-20 Thread Ying Liu
Vendor drivers may need to fixup mode due to pixel clock tree limitation, so introduce the ->mode_fixup() callcack to struct dw_mipi_dsi_plat_data and call it at atomic check stage if available. Signed-off-by: Liu Ying --- v1->v2: * No change. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 14

[PATCH v2 5/9] drm/bridge: synopsys: dw-mipi-dsi: Use pixel clock rate to calculate lbcc

2023-07-20 Thread Ying Liu
To get better accuration, use pixel clock rate to calculate lbcc instead of lane_mbps since the pixel clock rate is in KHz while lane_mbps is in MHz. Without this, distorted image can be seen on a HDMI monitor connected with i.MX93 11x11 EVK through ADV7535 DSI to HDMI bridge in 1920x1080p@60 video

[PATCH v2 6/9] drm/bridge: synopsys: dw-mipi-dsi: Set minimum lane byte clock cycles for HSA and HBP

2023-07-20 Thread Ying Liu
According to Synopsys support channel, each region of HSA, HBP and HFP must have minimum number of 10 bytes where constant 4 bytes are for HSS or HSE and 6 bytes are for blanking packet(header + CRC). Hence, the below table comes in. ++--+---+ | data lanes | min lbcc | byt

[PATCH v2 7/9] drm/bridge: synopsys: dw-mipi-dsi: Disable HSTX and LPRX timeout check

2023-07-20 Thread Ying Liu
According to Synopsys DW MIPI DSI host databook, HSTX and LPRX timeout contention detections are measured in TO_CLK_DIVISION cycles. However, the current driver programs magic values to TO_CLK_DIVISION, HSTX_TO_CNT and LPRX_TO_CNT register fields, which makes timeout error event wrongly happen for

[PATCH v2 8/9] dt-bindings: display: bridge: Document Freescale i.MX93 MIPI DSI

2023-07-20 Thread Ying Liu
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Signed-off-by: Liu Ying Reviewed-by: Rob Herring --- v1->v2: * Add Rob's R-b tag. .../display/bri

[PATCH v2 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-20 Thread Ying Liu
Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host controller and a Synopsys Designware MIPI DPHY. Some configurations and extensions to them are controlled by i.MX93 media blk-ctrl. Add a DRM bridge for i.MX93 MIPI DSI by using existing DW MIPI DSI bridge helpers and implementing i.

Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-20 Thread Alexandru Ardelean
On Wed, Jul 19, 2023 at 9:02 AM Alexandru Ardelean wrote: > > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial su

[PATCH] drm/i915: fix application of sizeof to pointer

2023-07-20 Thread sunran001
The coccinelle check report: ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application of sizeof to pointer Signed-off-by: Ran Sun --- drivers/gpu/drm/i915/i915_syncmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_syncmap.c b/drivers/gp

Re: [PATCH v3 02/15] arm64: dts: qcom: sm6125: Sort spmi_bus node numerically by reg

2023-07-20 Thread AngeloGioacchino Del Regno
Il 19/07/23 23:54, Marijn Suijten ha scritto: On 2023-07-19 01:02:56, Dmitry Baryshkov wrote: On 19/07/2023 00:24, Marijn Suijten wrote: This node has always resided in the wrong spot, making it somewhat harder to contribute new node entries while maintaining proper sorting around it. Move the

RE: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-07-20 Thread Kasireddy, Vivek
Hi Alistair, > > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 64a3239b6407..1f2f0209101a 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -6096,8 +6096,12 @@ vm_fault_t hugetlb_fault(struct mm_struct > *mm, struct vm_area_struct *vma, > > * hugetlb_no_page will dro

Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-20 Thread Frieder Schrempf
On 19.07.23 08:01, Alexandru Ardelean wrote: > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7

Re: [PATCH v2] drm/mediatek: fix uninitialized symbol

2023-07-20 Thread 胡俊光

[PULL] drm-misc-fixes

2023-07-20 Thread Maxime Ripard
Hi, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2023-07-20: Memory leak fixes in drm/client, memory access/leak fixes for accel/qaic, another leak fix in dma-buf and three nouveau fixes around hotplugging. The following changes since commit 835a65f51790e1f72b1ab106ec89db9ac15b47d6:

Re: [PATCH 00/11] drm: kunit: Switch to kunit actions

2023-07-20 Thread Maxime Ripard
Hi, On Mon, Jul 17, 2023 at 11:24:13PM +0800, suijingfeng wrote: > On 2023/7/10 15:47, Maxime Ripard wrote: > > Hi, > > > > Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests > > resources much easier to cleanup. > > > > This series converts the existing tests to use those

Re: [PATCH v2,2/2] drm/mediatek: dp: Add the audio control to mtk_dp_data struct

2023-07-20 Thread 李水静
On Thu, 2023-07-06 at 12:26 +0200, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Il 06/07/23 04:14, Shuijing Li ha scritto: > Mainly add the following two flag: Hi Angelo This patch is for MT8

[PULL] drm-intel-fixes

2023-07-20 Thread Tvrtko Ursulin
Hi Dave, Daniel, Only two fixes for the 6.5 rc window this week - one perf/OA use after free on Xe_HP platforms and one defconfig build fix for GCC versions older than 8. Regards, Tvrtko drm-intel-fixes-2023-07-20: - Add sentinel to xehp_oa_b_counters [perf] (Andrzej Hajda) - Revert "drm/i915:

Re: [PATCH v2, 2/2] drm/mediatek: dp: Add the audio control to mtk_dp_data struct

2023-07-20 Thread 李水静

[PATCH v3,0/3] Add compatible to increase MT8188 audio control

2023-07-20 Thread Shuijing Li
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. Mainly add the following two flag: 1.The audio packet arrangement function is to only arrange audio packets into the Hblanking area. In order to align with the HW default setting of g1200, this function needs to be turned off. 2.Due t

[PATCH v3, 1/3] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2023-07-20 Thread Shuijing Li
Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Reviewed-by: AngeloGioacchino Del Regno Acked-by: Krzysztof Kozlowski --- Changes in v2: add a mediatek,mt8188-edp-tx compatible per suggestion from the previous thread: https://

[PATCH v3, 3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread Shuijing Li
Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi --- Changes in v3: Separate these two things into two different patches. per suggestion from the previous thread: https://lore.kernel.org/lkml/e2ad22bcba31797f38a12a488d4246a01bf0c

[PATCH v3, 2/3] drm/mediatek: dp: Add the audio packet flag to mtk_dp_data struct

2023-07-20 Thread Shuijing Li
The audio packet arrangement function is to only arrange audio. packets into the Hblanking area. In order to align with the HW default setting of mt8195, this function needs to be turned off. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi --- Changes in v3: Separate these two things into tw

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-20 Thread Kefeng Wang
On 2023/7/19 23:25, Paul Moore wrote: On Wed, Jul 19, 2023 at 6:23 AM Kefeng Wang wrote: On 2023/7/19 17:02, Christian Göttsche wrote: On Wed, 19 Jul 2023 at 09:40, Kefeng Wang wrote: Use the helpers to simplify code. Cc: Paul Moore Cc: Stephen Smalley Cc: Eric Paris Acked-by: Paul M

Re: [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-20 Thread Tvrtko Ursulin
On 18/07/2023 22:44, Nathan Chancellor wrote: A proposed update to clang's -Wconstant-logical-operand to warn when the left hand side is a constant shows the following instance in nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ, such as CONFIG_HZ=300: drivers/gpu/drm/i9

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-20 Thread Javier Martinez Canillas
Simon Ser writes: Hello Simon, > On Thursday, July 20th, 2023 at 07:03, Zack Rusin wrote: > >> I'll give this series a few more hours on the list and if no one objects >> I'll push >> it to drm-misc later today. Thanks! > > Sorry, but this doesn't seem to be enough to satisfy the DRM merge > r

Re: [PATCH 01/11] drm/tests: helpers: Switch to kunit actions

2023-07-20 Thread Maxime Ripard
Hi Javier, Thanks for reviewing the series On Wed, Jul 19, 2023 at 08:42:51PM +0200, Javier Martinez Canillas wrote: > > diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c > > b/drivers/gpu/drm/tests/drm_kunit_helpers.c > > index 4df47071dc88..38211fea9ae6 100644 > > --- a/drivers/gpu/drm/te

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-07-20 Thread Alistair Popple
"Kasireddy, Vivek" writes: > Hi Alistair, > >> >> > diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> > index 64a3239b6407..1f2f0209101a 100644 >> > --- a/mm/hugetlb.c >> > +++ b/mm/hugetlb.c >> > @@ -6096,8 +6096,12 @@ vm_fault_t hugetlb_fault(struct mm_struct >> *mm, struct vm_area_struct *vma, >>

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-20 Thread Simon Ser
On Thursday, July 20th, 2023 at 10:50, Javier Martinez Canillas wrote: > > On Thursday, July 20th, 2023 at 07:03, Zack Rusin za...@vmware.com wrote: > > > > > I'll give this series a few more hours on the list and if no one objects > > > I'll push > > > it to drm-misc later today. Thanks! > >

Re: [PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

2023-07-20 Thread Lisovskiy, Stanislav
On Thu, Jul 13, 2023 at 04:03:33PM +0530, Ankit Nautiyal wrote: > Currently we assume 2 Pixels Per Clock (PPC) while computing > plane cdclk and min_cdlck. In cases where DSC single engine > is used the throughput is 1 PPC. > > So account for the above case, while computing cdclk. > > v2: Use hel

Re: [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection

2023-07-20 Thread Sui Jingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: drm/amdgpu: Implement the is_primary_gpu callback of vga_client_register() drm/radeon: Add an implement for the is_primary_gpu function callback drm/i915: Add an implement for the is_primary_gpu hook drm/ast: Register as a vga client

Re: [PATCH v5 2/9] drm/atomic: Add support for mouse hotspots

2023-07-20 Thread Simon Ser
On Wednesday, July 19th, 2023 at 03:42, Zack Rusin wrote: > From: Zack Rusin > > Atomic modesetting code lacked support for specifying mouse cursor > hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting > the hotspot but the functionality was not implemented in the new atomic

Re: [PATCH 07/19] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-07-20 Thread Lisovskiy, Stanislav
On Thu, Jul 13, 2023 at 04:03:34PM +0530, Ankit Nautiyal wrote: > As per Bsepc:49259, Bigjoiner BW check puts restriction on the > compressed bpp for a given CDCLK, pixelclock in cases where > Bigjoiner + DSC are used. > > Currently compressed bpp is computed first, and it is ensured that > the bp

Re: [PATCH v3,2/3] drm/mediatek: dp: Add the audio packet flag to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 10:26, Shuijing Li ha scritto: The audio packet arrangement function is to only arrange audio. packets into the Hblanking area. In order to align with the HW default setting of mt8195, this function needs to be turned off. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Revie

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 10:26, Shuijing Li ha scritto: Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-07-20 Thread Lisovskiy, Stanislav
On Thu, Jul 13, 2023 at 04:03:32PM +0530, Ankit Nautiyal wrote: > In Bigjoiner check for DSC, bigjoiner interface bits for DP for > DISPLAY > 13 is 36 (Bspec: 49259). > > v2: Corrected Display ver to 13. > > v3: Follow convention for conditional statement. (Ville) > > v4: Fix check for display v

Re: [PATCH 13/19] drm/i915/dp: Avoid left shift of DSC output bpp by 4

2023-07-20 Thread Lisovskiy, Stanislav
On Thu, Jul 13, 2023 at 04:03:40PM +0530, Ankit Nautiyal wrote: > To make way for fractional bpp support, avoid left shifting the > output_bpp by 4 in helper intel_dp_dsc_get_output_bpp. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 10 +++--- > driv

Re: [PATCH v3,2/3] drm/mediatek: dp: Add the audio packet flag to mtk_dp_data struct

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 20/07/2023 10:26, Shuijing Li wrote: The audio packet arrangement function is to only arrange audio. packets into the Hblanking area. In order to align with the HW default setting of mt8195, this function needs to be turned off. -- Regards, Alexandre

[PATCH v3] drm/i915: Fix premature release of request's reusable memory

2023-07-20 Thread Janusz Krzysztofik
Infinite waits for completion of GPU activity have been observed in CI, mostly inside __i915_active_wait(), triggered by igt@gem_barrier_race or igt@perf@stress-open-close. Root cause analysis, based of ftrace dumps generated with a lot of extra trace_printk() calls added to the code, revealed loo

Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-20 Thread Simon Ser
On Wednesday, July 19th, 2023 at 19:05, Erik Kurzinger wrote: > These new ioctls perform a task similar to > DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD/FD_TO_HANDLE with the > IMPORT/EXPORT_SYNC_FILE flag set, except that they allow specifying the > timeline point to import or export the fence to or from on

Re: [PATCH v5 1/9] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-07-20 Thread Simon Ser
On Wednesday, July 19th, 2023 at 03:42, Zack Rusin wrote: > From: Zack Rusin > > Cursor planes on virtualized drivers have special meaning and require > that the clients handle them in specific ways, e.g. the cursor plane > should react to the mouse movement the way a mouse cursor would be > ex

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-20 Thread Simon Ser
On Wednesday, July 19th, 2023 at 03:42, Zack Rusin wrote: > +/** > + * DOC: hotspot properties > + * > + * HOTSPOT_X: property to set mouse hotspot x offset. > + * HOTSPOT_Y: property to set mouse hotspot y offset. > + * > + * When the plane is being used as a cursor image to display a mouse poin

Re: [PATCH v5 8/9] drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT

2023-07-20 Thread Simon Ser
On Wednesday, July 19th, 2023 at 03:42, Zack Rusin wrote: > From: Zack Rusin > > Virtualized drivers place additional restrictions on the cursor plane > which breaks the contract of universal planes. To allow atomic > modesettings with virtualized drivers the clients need to advertise > that th

Re: [PATCH 4/9] drm/verisilicon: Add gem driver for JH7110 SoC

2023-07-20 Thread Keith Zhao
On 2023/6/19 21:18, Thomas Zimmermann wrote: > > > Am 02.06.23 um 09:40 schrieb Keith Zhao: >> This patch implements gem related APIs for JH7100 SoC. >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Makefile |   3 +- >>   drivers/gpu/drm/verisilicon/vs_drv.c |   6 + >>

Re: [PATCH v3] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-20 Thread Maxime Ripard
Hi, On Mon, Jul 17, 2023 at 06:30:22PM +0200, Javier Martinez Canillas wrote: > Geert reports that the following NULL pointer dereference happens for him > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > plane update"): > > [drm] Initialized ssd130x 1.0.0 20220131 fo

Re: [05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-20 Thread Maxime Ripard
On Wed, Jul 19, 2023 at 09:12:14PM +0200, Javier Martinez Canillas wrote: > suijingfeng writes: > > > Hi, > > > > On 2023/7/10 15:47, Maxime Ripard wrote: > > [...] > > >> + > >> +/** > >> + * drm_kunit_helper_context_alloc - Allocates an acquire context > >> + * @test: The test context object

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread Alexandre Mergnat
On 20/07/2023 10:26, Shuijing Li wrote: Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi --- Changes in v3: Separate these two things into two different patches. per suggestion from the previous thread: https://lore.kernel.o

Re: [05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-20 Thread suijingfeng
Hi, On 2023/7/20 18:07, Maxime Ripard wrote: On Wed, Jul 19, 2023 at 09:12:14PM +0200, Javier Martinez Canillas wrote: suijingfeng writes: Hi, On 2023/7/10 15:47, Maxime Ripard wrote: [...] + +/** + * drm_kunit_helper_context_alloc - Allocates an acquire context + * @test: The test cont

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-20 Thread Christian Göttsche
On Wed, 19 Jul 2023 at 09:40, Kefeng Wang wrote: > > Use the helpers to simplify code. > > Cc: Paul Moore > Cc: Stephen Smalley > Cc: Eric Paris > Acked-by: Paul Moore > Signed-off-by: Kefeng Wang > --- > security/selinux/hooks.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-)

[PATCH 1/2] dt-bindings: ili9881c: Add TDO TL050HDV35 LCD panel

2023-07-20 Thread Matus Gajdos
Add support for TDO TL050HDV35-H1311A LCD panel. Signed-off-by: Matus Gajdos --- .../devicetree/bindings/display/panel/ilitek,ili9881c.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml b/Documentation/devicetree/

[PATCH 2/2] drm/panel: ilitek-ili9881c: Add TDO TL050HDV35 LCD panel

2023-07-20 Thread Matus Gajdos
Add support for TDO TL050HDV35-H1311A LCD panel. Signed-off-by: Matus Gajdos --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 194 ++ 1 file changed, 194 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c

Re: [PATCH v2 3/4] selinux: use vma_is_initial_stack() and vma_is_initial_heap()

2023-07-20 Thread Paul Moore
On Wed, Jul 19, 2023 at 6:23 AM Kefeng Wang wrote: > On 2023/7/19 17:02, Christian Göttsche wrote: > > On Wed, 19 Jul 2023 at 09:40, Kefeng Wang > > wrote: > >> > >> Use the helpers to simplify code. > >> > >> Cc: Paul Moore > >> Cc: Stephen Smalley > >> Cc: Eric Paris > >> Acked-by: Paul Moo

[PATCH 0/2] drm/panel: ilitek-ili9881c: Add TDO TL050HDV35-H1311A LCD panel

2023-07-20 Thread Matus Gajdos
The first patch updates the DT documentation and the second is the update of the ilitek ili9881c driver. Matus Gajdos (2): dt-bindings: ili9881c: Add TDO TL050HDV35 LCD panel drm/panel: ilitek-ili9881c: Add TDO TL050HDV35 LCD panel .../display/panel/ilitek,ili9881c.yaml| 1 + drive

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-20 Thread Konstantin Ryabitsev
July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: > > > Not sure about other drivers--they can speak for themselves and the CC > > > list > > > should include them--please use "dim add-missing-cc" and make sure > > > that the Git commit description contains the Cc tags--then git send-email > > >

[PATCH v2 0/2] drm/mipi-dbi: Allow using same the D/C GPIO for multiple displays

2023-07-20 Thread Otto Pflüger
When multiple displays are connected to the same SPI bus, the data/command switch is sometimes considered part of the bus and is shared among the displays. This series adds the GPIO_FLAGS_BIT_NONEXCLUSIVE flag for this GPIO and SPI bus locking to the panel-mipi-dbi/drm_mipi_dbi drivers to support

[PATCH v2 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

2023-07-20 Thread Otto Pflüger
Multiple displays may be connected to the same bus and share a D/C GPIO, so the display driver needs exclusive access to the bus to ensure that it can control the D/C GPIO safely. Signed-off-by: Otto Pflüger --- drivers/gpu/drm/drm_mipi_dbi.c | 17 + drivers/gpu/drm/tiny/ili9225.

[PATCH v2 2/2] drm/tiny: panel-mipi-dbi: Allow sharing the D/C GPIO

2023-07-20 Thread Otto Pflüger
Displays that are connected to the same SPI bus may share the D/C GPIO. Use GPIOD_FLAGS_BIT_NONEXCLUSIVE to allow access to the same GPIO for multiple panel-mipi-dbi instances. Exclusive access to the GPIO during transfers is ensured by the locking in drm_mipi_dbi.c. Signed-off-by: Otto Pflüger -

Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

2023-07-20 Thread Daniel Vetter
On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote: > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar wrote: > > > > On 09/06/2023 15:06, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Two functions got added with normal prototypes for debugfs, but not > > > alternative when build

[PATCH] drm/ioctl: turn on -Woverride-init for IOCTL table

2023-07-20 Thread Simon Ser
Recently two patches [1] [2] have hit a case of mistakenly picking an IOCTL number which was already in-use. This is hard to debug because the last definition wins and there is no indication that there is a conflict. Fix this by enabling -Werror=override-init for the IOCTL table. When there is a d

Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

2023-07-20 Thread Oded Gabbay
On Thu, Jul 20, 2023 at 1:29 PM Daniel Vetter wrote: > > On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote: > > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar wrote: > > > > > > On 09/06/2023 15:06, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > Two functions got added wi

Re: [PATCH v3] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-20 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, Thanks a lot for your feedback. > Hi, > > On Mon, Jul 17, 2023 at 06:30:22PM +0200, Javier Martinez Canillas wrote: >> Geert reports that the following NULL pointer dereference happens for him >> after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers

Re: [PATCH drm-misc-next v8 01/12] drm: manager to keep track of GPUs VA mappings

2023-07-20 Thread Steven Price
On 20/07/2023 01:14, Danilo Krummrich wrote: > Add infrastructure to keep track of GPU virtual address (VA) mappings > with a decicated VA space manager implementation. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace applications to

Re: [PATCH drm-misc-next v8 02/12] drm: debugfs: provide infrastructure to dump a DRM GPU VA space

2023-07-20 Thread Steven Price
On 20/07/2023 01:14, Danilo Krummrich wrote: > This commit adds a function to dump a DRM GPU VA space and a macro for > drivers to register the struct drm_info_list 'gpuvas' entry. > > Most likely, most drivers might maintain one DRM GPU VA space per struct > drm_file, but there might also be driv

Re: [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-20 Thread Tvrtko Ursulin
Hi, On 19/07/2023 21:31, T.J. Mercier wrote: On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin wrote: drm.memory.stat A nested file containing cumulative memory statistics for the whole sub-hierarchy, broken down into separate GPUs and separate memory regions supp

[PATCH] accel/habanalabs/gaudi2: prepare to remove cpu_rst_status

2023-07-20 Thread Oded Gabbay
From: Igor Grinberg The soft reset has transitioned to CPUCP packet instead of plain register write and is about to be removed from the struct cpu_dyn_regs. As a preparation for removing the cpu_rst_status field from struct cpu_dyn_regs, switch to use the plain macro - this keeps the backward com

Re: [09/11] drm/vc4: tests: pv-muxing: Switch to managed locking init

2023-07-20 Thread Maxime Ripard
On Tue, Jul 18, 2023 at 01:24:29AM +0800, suijingfeng wrote: > On 2023/7/10 15:47, Maxime Ripard wrote: > > The new helper to init the locking context allows to remove some > > boilerplate. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 42 > >

[PATCH v2 00/11] drm: kunit: Switch to kunit actions

2023-07-20 Thread Maxime Ripard
Hi, Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests resources much easier to cleanup. This series converts the existing tests to use those new actions where relevant. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v2: - Fix some typos -

[PATCH v2 01/11] drm/tests: helpers: Switch to kunit actions

2023-07-20 Thread Maxime Ripard
Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/tests/drm_kunit_helpers.

[PATCH v2 02/11] drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device()

2023-07-20 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_client_modeset_test.c | 8

[PATCH v2 04/11] drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device()

2023-07-20 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 --

[PATCH v2 03/11] drm/tests: modes: Remove call to drm_kunit_helper_free_device()

2023-07-20 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_modes_test.c | 8 1 f

[PATCH v2 05/11] drm/tests: helpers: Create a helper to allocate a locking ctx

2023-07-20 Thread Maxime Ripard
As we get more and more tests, the locking context initialisation creates more and more boilerplate, both at creation and destruction. Let's create a helper that will allocate, initialise a context, and register kunit actions to clean up once the test is done. Reviewed-by: Javier Martinez Canilla

[PATCH v2 09/11] drm/vc4: tests: pv-muxing: Switch to managed locking init

2023-07-20 Thread Maxime Ripard
The new helper to init the locking context allows to remove some boilerplate. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 42 -- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/dr

[PATCH v2 06/11] drm/tests: helpers: Create a helper to allocate an atomic state

2023-07-20 Thread Maxime Ripard
As we gain more tests, boilerplate to allocate an atomic state and free it starts to be there more and more as well. In order to reduce the allocation boilerplate, we can create a helper to create that atomic state, and call an action when the test is done. This will also clean up the exit path.

[PATCH v2 08/11] drm/vc4: tests: mock: Use a kunit action to unregister DRM device

2023-07-20 Thread Maxime Ripard
The *_mock_device functions allocate a DRM device that needs to be released using drm_dev_unregister. Now that we have a kunit release action API, we can switch to it and don't require any kind of garbage collection from the caller. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Rip

[PATCH v2 10/11] drm/vc4: tests: Switch to atomic state allocation helper

2023-07-20 Thread Maxime Ripard
Now that we have a helper that takes care of an atomic state allocation and cleanup, we can migrate to it to simplify our tests. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 55 -- 1 file changed,

[PATCH v2 07/11] drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device()

2023-07-20 Thread Maxime Ripard
Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 4

[PATCH v2 11/11] drm/vc4: tests: pv-muxing: Document test scenario

2023-07-20 Thread Maxime Ripard
We've had a couple of tests that weren't really obvious, nor did they document what they were supposed to test. Document that to make it hopefully more obvious. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_test_pv_muxing.c | 22 +++

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Daniel Thompson
On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > Bootloader may leave gpio direction as input and gpio value as logical low. > It hints that initial backlight power state should be FB_BLANK_POWERDOWN > since the gpio value is literally logical low. To be honest this probably "hints" tha

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing Li wrote: Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi --- Changes in v3: Separate these two things into two different patches. per suggestio

[LINUX KERNEL PATCH v3 1/1] virtgpu: init vq during resume and notify qemu guest status

2023-07-20 Thread Jiqian Chen
This patch solves two problem: First, when we suspended guest VM, it called into Qemu to call virtio_reset->__virtio_queue_reset, this cleared all virtuqueue information of virtgpu on Qemu end. As a result, after guest resumed, guest sended ctrl/cursor requests to Qemu through virtqueue, but Qemu

[LINUX KERNEL PATCH v3 0/1] add S3 support for virtgpu

2023-07-20 Thread Jiqian Chen
v3: Hi all, Thanks for Gerd Hoffmann's advice. V3 makes below changes: * Use enum for freeze mode, so this can be extended with more modes in the future. * Rename functions and paratemers with "_S3" postfix. And no functional changes. Best regards, Jiqian Chen. v2: Hi all, Thanks to Marc-Andr

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread Alexandre Mergnat
On 20/07/2023 13:54, AngeloGioacchino Del Regno wrote: Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing Li wrote: Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi --- Changes in v3: Separate

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 14:07, Alexandre Mergnat ha scritto: On 20/07/2023 13:54, AngeloGioacchino Del Regno wrote: Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing Li wrote: Due to the difference of HW, different dividers need to be set. Signed-off-by: Shuijing Li Sign

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread Alexandre Mergnat
On 20/07/2023 14:08, AngeloGioacchino Del Regno wrote: Il 20/07/23 14:07, Alexandre Mergnat ha scritto: On 20/07/2023 13:54, AngeloGioacchino Del Regno wrote: Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing Li wrote: Due to the difference of HW, different

Re: [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Nirmoy Das
Some of the patches are needed to be backported to v5.8 so I wonder if you should do the refactoring later in the series. I guess best way is to check if you can apply the series in v5.8 On 7/19/2023 1:07 PM, Andi Shyti wrote: Just a trivial refactoring for reducing the number of code duplic

Re: [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Nirmoy Das
Hi Andi, On 7/19/2023 1:07 PM, Andi Shyti wrote: Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonat

[PATCH next] drm/loongson: Fix error handling in lsdc_pixel_pll_setup()

2023-07-20 Thread Harshit Mogalapalli
There are two problems in lsdc_pixel_pll_setup() 1. If kzalloc() fails then call iounmap() to release the resources. 2. Both kzalloc and ioremap doesnot return error pointers on failure, so using IS_ERR_OR_NULL() checks is a bit confusing and not very right, fix this by changing those to NULL

[PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-20 Thread Viktar Simanenka
Add device tree binding documentation for PCD8544 LCD display controller. Signed-off-by: Viktar Simanenka --- v3:add a little more description to the exposed vendor properties add commit message finally v2 link: https://lore.kernel.org/linux-devicetree/20230719154450.620410-1-viteo...@gmail.c

[PATCH v3 2/2] drm/tiny: add display driver for philips pcd8544 display controller

2023-07-20 Thread Viktar Simanenka
Add support for monochrome LCD SPI displays (such as Nokia 5110/3310 LCD) based on PCD8544 LCD display controller. Signed-off-by: Viktar Simanenka --- v3:nothing changed from v2 v2:checked and fixed with sparse and smatch changed param prefixes v2 link: https://lore.kernel.org/linux-devicetre

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 14:29, Alexandre Mergnat ha scritto: On 20/07/2023 14:08, AngeloGioacchino Del Regno wrote: Il 20/07/23 14:07, Alexandre Mergnat ha scritto: On 20/07/2023 13:54, AngeloGioacchino Del Regno wrote: Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing

[PATCH v2 3/5] drm/i915: Fix HPD polling, reenabling the output poll work as needed

2023-07-20 Thread Imre Deak
After the commit in the Fixes: line below, HPD polling stopped working on i915, since after that change calling drm_kms_helper_poll_enable() doesn't restart drm_mode_config::output_poll_work if the work was stopped (no connectors needing polling) and enabling polling for a connector (during runtime

[PATCH v2 2/5] drm: Add an HPD poll helper to reschedule the poll work

2023-07-20 Thread Imre Deak
Add a helper to reschedule drm_mode_config::output_poll_work after polling has been enabled for a connector (and needing a reschedule, since previously polling was disabled for all connectors and hence output_poll_work was not running). This is needed by the next patch fixing HPD polling on i915.

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > Bootloader may leave gpio direction as input and gpio value as logical low. > > It hints that initial backlight power state should be FB_BLANK_POWERDOWN > > since the gpio value

Re: [PATCH v6 06/11] drm/mediatek: dp: Enable event interrupt only when bridge attached

2023-07-20 Thread Alexandre Mergnat
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: It is useless and error-prone to enable the DisplayPort event interrupt before finishing to probe and install the driver, as the DP training cannot happen before the entire pipeline is correctly set up, as the interrupt handler also requir

Re: [PATCH v6 07/11] drm/mediatek: dp: Avoid mutex locks if audio is not supported/enabled

2023-07-20 Thread Alexandre Mergnat
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: If a controller (usually, eDP!) does not support audio, or audio is not enabled because the endpoint has no audio support, it's useless to lock a mutex only to unlock it right after because there's no .plugged_cb(). Check if the audio is

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Daniel Thompson
On Thu, Jul 20, 2023 at 02:56:32PM +0200, Bartosz Golaszewski wrote: > On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson > wrote: > > > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > > Bootloader may leave gpio direction as input and gpio value as logical > > > low. > > > It hints

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 3:10 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 02:56:32PM +0200, Bartosz Golaszewski wrote: > > On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson > > wrote: > > > > > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > > > Bootloader may leave gpio di

  1   2   >