Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Nuno Sá
On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote: > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial

[PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

2023-07-18 Thread Dan Carpenter
The lsdc_bo_create() function can fail so add a check for that. Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/loongson/lsdc_ttm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/loongson/lsdc_ttm

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-18 Thread Robert Foss
On Mon, Jul 17, 2023 at 4:27 PM Rob Herring wrote: > > On Sun, Jul 16, 2023 at 3:26 AM Heiko Stuebner wrote: > > > > Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > > > The DT of_device.h and of_platform.h date back to the separate > > > of_platform_bus_type before it as merged in

[PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-18 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL. ASPM policy changes can trigger write to LNKCTL outside of driver's control. And in the case of upstream bridge, the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper lockin

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-18 Thread Rob Herring
On Sun, Jul 16, 2023 at 3:26 AM Heiko Stuebner wrote: > > Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As part of that merge prepping

[PATCH v5 06/11] drm/radeon: Use RMW accessors for changing LNKCTL

2023-07-18 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL. ASPM policy changes can trigger write to LNKCTL outside of driver's control. And in the case of upstream bridge, the driver does not even own the device it's changing the registers for. Use RMW capability accessors which do proper lockin

[PATCH] drm/amd/display: Allow building DC with clang on RISC-V

2023-07-18 Thread Samuel Holland
clang on RISC-V appears to be unaffected by the bug causing excessive stack usage in calculate_bandwidth(). clang 16 with -fstack-usage reports a 304 byte stack frame size with CONFIG_ARCH_RV32I, and 512 bytes with CONFIG_ARCH_RV64I. Signed-off-by: Samuel Holland --- drivers/gpu/drm/amd/display

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-18 Thread Kieran Bingham
Quoting Rob Herring (2023-07-14 18:45:34) > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also inclu

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-18 Thread Liviu Dudau
On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each oth

Re: [PATCH 4/5] selinux: use vma_is_stack() and vma_is_heap()

2023-07-18 Thread Paul Moore
On Wed, Jul 12, 2023 at 10:25 AM Kefeng Wang wrote: > > Use the helpers to simplify code. > > Signed-off-by: Kefeng Wang > --- > security/selinux/hooks.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 4e

Re: [PATCH 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Alexander Stein
Hi, Am Montag, 17. Juli 2023, 08:18:22 CEST schrieb Liu Ying: > Hi, > > This series aims to add MIPI DSI support for Freescale i.MX93 SoC. > > There is a Synopsys DesignWare MIPI DSI host controller and a Synopsys > Designware MIPI DPHY embedded in i.MX93. Some configurations and > extensions t

Re: [PATCH v5 01/10] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-18 Thread 胡俊光

Re: [PATCH v5 01/10] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-18 Thread Chen-Yu Tsai
Hi CK, On Tue, Jul 18, 2023 at 3:40 PM CK Hu (胡俊光) wrote: > > Hi, Angelo: > > On Thu, 2023-07-13 at 11:01 +0200, AngeloGioacchino Del Regno wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > Everytime we run br

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Alexander Stein
Hi, thanks for the patch. Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > controller and a Synopsys Designware MIPI DPHY. Some configurations > and extensions to them are controlled by i.MX93 media blk-ctrl. > > Add a

Re: [PATCH v6 02/11] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-18 Thread 胡俊光

Re: [PATCH v6 01/11] drm/mediatek: dp: Add missing error checks in mtk_dp_parse_capabilities

2023-07-18 Thread 胡俊光

[PATCH v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it. Signed-off-by: Raphael Gallais-Pou --- drivers/staging/fbtft/fb_ili9341.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fb

Re: [PATCH v1 3/8] drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl()

2023-07-18 Thread Lucas Stach
Hi Jingfeng, Am Dienstag, dem 18.07.2023 um 02:34 +0800 schrieb suijingfeng: > Hi,  Lucas > > > Thanks for you guidance! > > > On 2023/7/17 17:51, Lucas Stach wrote: > > Hi Jingfeng, > > > > Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > > > From: Sui Jingfeng > > > > > >

[PATCH] drm/msm/dsi: add missing put_device()

2023-07-18 Thread sunran001
The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following ERROR: ./drivers/gpu/drm/msm/dsi/dsi.c:50:1-7: ERROR: missing put_device; call of_find_device_by_node on line 32, but without a correspond

[PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it. Changes in v2: - dropped MODULE_ALIAS changes - changed commit log for more accurate description Signed-off-by: Raphael Gallais-Pou --- drivers

Re: [PATCH] drm/msm/dsi: add missing put_device()

2023-07-18 Thread Dmitry Baryshkov
On 18/07/2023 11:13, sunran...@208suo.com wrote: The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following ERROR: ./drivers/gpu/drm/msm/dsi/dsi.c:50:1-7: ERROR: missing put_device; call of_find_d

Re: [PATCH 2/3] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-07-18 Thread Pekka Paalanen
On Mon, 17 Jul 2023 17:55:04 +0200 Christian König wrote: > Am 15.07.23 um 16:14 schrieb aly...@rosenzweig.io: ... > > Lina has been polite and accommodating while AMD calls her code > > "outright nonsense" and gets "outright NAK"s, and puts her into an > > impossible catch-22 where no matter w

[PATCH] drm/msm/dsi: add missing put_device()

2023-07-18 Thread sunran001
The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following ERROR: ./drivers/gpu/drm/msm/dsi/dsi.c:50:1-7: ERROR: missing put_device; call of_find_device_by_node on line 32, but without a correspond

Re: [PATCH] dma-buf: remove unintended hyphen in the sysfs path

2023-07-18 Thread Luc Ma
Hi, On Tue, 18 Jul 2023 at 14:39, Javier Martinez Canillas wrote: > > Luc Ma writes: > > > From: Luc Ma > > > > Signed-off-by: Luc Ma > > --- > > Even when is a trivial change I would add something as commit message, i.e: > > "The kernel-doc mentions /sys/kernel/dma-buf/buffers but the correc

Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Alexandru Ardelean
On Tue, Jul 18, 2023 at 10:00 AM Nuno Sá wrote: > > On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote: > > From: Bogdan Togorean > > > > For ADV7533 and ADV7535 low refresh rate is selected using > > bits [3:2] of 0x4a main register. > > So depending on ADV model write 0xfb or 0x4a regi

Re: [PATCH] drm/msm/dsi: add missing put_device()

2023-07-18 Thread Dmitry Baryshkov
On 18/07/2023 11:33, sunran...@208suo.com wrote: The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Detected by coccinelle with the following ERROR: ./drivers/gpu/drm/msm/dsi/dsi.c:50:1-7: ERROR: missing put_device; call of_find_d

Re: [PATCH] TinyDRM display driver for Philips PCD8544 display controller

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 10:07, Viktar Simanenka wrote: > Support for common monochrome LCD displays based on PCD8544 (such as Nokia > 5110/3310 LCD) SPI controlled displays. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixi

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-18 Thread Javier Martinez Canillas
Pekka Paalanen writes: Hello folks, > On Mon, 10 Jul 2023 10:46:56 -0700 > Michael Banack wrote: > >> On 7/10/23 01:17, Pekka Paalanen wrote: >> > On Fri, 7 Jul 2023 13:54:21 -0700 >> > Michael Banack wrote: > > ... > >> >> So I guess I would vote for trying to include something to that effect

[PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Alexandru Ardelean
From: Bogdan Togorean For ADV7533 and ADV7535 low refresh rate is selected using bits [3:2] of 0x4a main register. So depending on ADV model write 0xfb or 0x4a register. Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533") Reviewed-by: Nuno Sa Signed-off-by: Bogdan Togorean

[PATCH 1/1] dt-bindings: display: bridge: tc358867: Add interrupt property

2023-07-18 Thread Alexander Stein
This bridge has an interrupt line for event signaling. Add the corresponding property. Signed-off-by: Alexander Stein --- This fixes warnings like: imx93-tqma9352-mba93xxla.dtb: dp-bridge@f: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: htt

[PATCH v2 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-07-18 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Mike Kra

[PATCH v2 2/2] udmabuf: Add back support for mapping hugetlb pages (v2)

2023-07-18 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to

[PATCH v2 0/2] udmabuf: Add back support for mapping hugetlb pages (v2)

2023-07-18 Thread Vivek Kasireddy
The first patch ensures that the mappings needed for handling mmap operation would be managed by using the pfn instead of struct page. The second patch restores support for mapping hugetlb pages where subpages of a hugepage are not directly used anymore (main reason for revert) and instead the huge

Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Robert Foss
On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean wrote: > > From: Bogdan Togorean > > For ADV7533 and ADV7535 low refresh rate is selected using > bits [3:2] of 0x4a main register. > So depending on ADV model write 0xfb or 0x4a register. > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial s

[RFC v1 2/3] udmabuf: Replace pages when there is FALLOC_FL_PUNCH_HOLE in memfd

2023-07-18 Thread Vivek Kasireddy
When a hole is punched in the memfd or when a page is replaced for any reason, the udmabuf driver needs to get notified in order to update its list of pages with the new page. To accomplish this, we first identify the vma ranges where pages associated with a given udmabuf are mapped to and then reg

[RFC v1 0/3] udmabuf: Replace pages when there is FALLOC_FL_PUNCH_HOLE in memfd

2023-07-18 Thread Vivek Kasireddy
This patch series attempts to solve the coherency problem seen when a hole is punched in the region(s) of the mapping (associated with the memfd) that overlaps with pages registered with a udmabuf fd. The first patch introduces a new mmu notifier to let drivers know when a new page is faulted into

[RFC v1 3/3] selftests/dma-buf/udmabuf: Add tests for huge pages and FALLOC_FL_PUNCH_HOLE

2023-07-18 Thread Vivek Kasireddy
The new tests added in this patch try to mimic the situation that happens when a hole is punched in the memfd associated with Guest RAM that is managed by a VMM such as Qemu. The main goal of these tests is to ensure that the udmabuf driver updates its list of pages when newer Guest writes overlap

[RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

2023-07-18 Thread Vivek Kasireddy
Currently, there does not appear to be any mechanism for letting drivers or other kernel entities know about updates made in a mapping particularly when a new page is faulted in. Providing notifications for such situations is really useful when using memfds backed by ram-based filesystems such as s

RE: [PATCH 0/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 3:40 PM Alexander Stein wrote: > > Hi, Hi, > > Am Montag, 17. Juli 2023, 08:18:22 CEST schrieb Liu Ying: > > Hi, > > > > This series aims to add MIPI DSI support for Freescale i.MX93 SoC. > > > > There is a Synopsys DesignWare MIPI DSI host controller and a Synopsys

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 3:49 PM Alexander Stein wrote: > > Hi, Hi, > > thanks for the patch. Thanks for your review. > > Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > controller and a Synopsys Designware MIP

Re: [PATCH v6 03/11] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer()

2023-07-18 Thread 胡俊光

Re: [PATCH] TinyDRM display driver for Philips PCD8544 display controller

2023-07-18 Thread Rob Herring
On Tue, 18 Jul 2023 11:07:27 +0300, Viktar Simanenka wrote: > Support for common monochrome LCD displays based on PCD8544 (such as Nokia > 5110/3310 LCD) SPI controlled displays. > > Signed-off-by: Viktar Simanenka > --- > .../bindings/display/philips,pcd8544.yaml | 92 > drivers/gp

[PATCH] TinyDRM display driver for Philips PCD8544 display controller

2023-07-18 Thread Viktar Simanenka
Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays. Signed-off-by: Viktar Simanenka --- .../bindings/display/philips,pcd8544.yaml | 92 drivers/gpu/drm/tiny/Kconfig | 11 + drivers/gpu/drm/tiny/pcd8544.c

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-18 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Pekka Paalanen writes: > > Hello folks, > >> On Mon, 10 Jul 2023 10:46:56 -0700 >> Michael Banack wrote: >> >>> On 7/10/23 01:17, Pekka Paalanen wrote: >>> > On Fri, 7 Jul 2023 13:54:21 -0700 >>> > Michael Banack wrote: >> >> ... >> >>> >> So I guess I would

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Alexander Stein
Hi, Am Dienstag, 18. Juli 2023, 11:00:25 CEST schrieb Ying Liu: > On Tuesday, July 18, 2023 3:49 PM Alexander Stein wrote: > > Hi, > > Hi, > > > thanks for the patch. > > Thanks for your review. > > > Am Montag, 17. Juli 2023, 08:18:31 CEST schrieb Liu Ying: > > > Freescale i.MX93 SoC embeds

Re: [PATCH v6 04/11] drm/mediatek: dp: Use devm variant of drm_bridge_add()

2023-07-18 Thread 胡俊光

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Jagan Teki
On Tue, Jul 18, 2023 at 8:28 AM Ying Liu wrote: > > Hi Jagan, > > On Monday, July 17, 2023 2:44 PM Jagan Teki > wrote: > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > > controller and a Synopsys Designware MIPI

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 5:35 PM Jagan Teki wrote: > > > > > Hi Jagan, > > > > On Monday, July 17, 2023 2:44 PM Jagan Teki > wrote: > > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > > > Freescale i.MX93 SoC embeds a Synopsys Designware MIPI DSI host > > > > controller and a Sy

Re: Consider switching to WQ_UNBOUND messages (was: Re: [PATCH v2 6/7] workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism)

2023-07-18 Thread Geert Uytterhoeven
Hi Tejun, On Tue, Jul 18, 2023 at 1:03 AM Tejun Heo wrote: > Can you please the following patch and see how many reports you get? Looking > back at your reports, I think some of them probably should be converted to > UNBOUND but we should have a better idea with the adjusted threshold. > > Thanks

RE: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Ying Liu
On Tuesday, July 18, 2023 5:31 PM Alexander Stein wrote: > > Hi, Hi, > > Am Dienstag, 18. Juli 2023, 11:00:25 CEST schrieb Ying Liu: > > On Tuesday, July 18, 2023 3:49 PM Alexander Stein > group.com> wrote: > > > Hi, > > > > Hi, > > > > > thanks for the patch. > > > > Thanks for your review. >

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-18 Thread Pekka Paalanen
On Tue, 18 Jul 2023 10:41:32 +0200 Javier Martinez Canillas wrote: > Pekka Paalanen writes: > > Hello folks, > > > On Mon, 10 Jul 2023 10:46:56 -0700 > > Michael Banack wrote: > > > >> On 7/10/23 01:17, Pekka Paalanen wrote: > >> > On Fri, 7 Jul 2023 13:54:21 -0700 > >> > Michael Banack

Re: [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-18 Thread Su Hui
On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->oversample=1 and (!tv_mode->progressive)=1,

Re: [PULL] drm-misc-next

2023-07-18 Thread Daniel Vetter
On Thu, 13 Jul 2023 at 11:08, Thomas Zimmermann wrote: > > Hi Dave and Daniel, > > this is the main pull request for drm-misc-next for what will become > Linux v6.6. Some noteworthy changes are: > > * GEM got execution contexts that help with locking multiple GEM >objects at once. > > * All

Re: [PATCH 1/1] dt-bindings: display: bridge: tc358867: Add interrupt property

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 10:44, Alexander Stein wrote: > This bridge has an interrupt line for event signaling. Add the > corresponding property. > > Signed-off-by: Alexander Stein Best regards, Krzysztof

RE: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Quan, Evan
[AMD Official Use Only - General] Personally I would like to treat the wbrf core as a water pool. Any stream can flow in. Also any needed can drain water from it at any time. The way to allow producers to report only when there is consumer existing does not work. Since the consumer might come af

Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support

2023-07-18 Thread Jagan Teki
Hi, On Tue, Jul 18, 2023 at 3:19 PM Ying Liu wrote: > > On Tuesday, July 18, 2023 5:35 PM Jagan Teki > wrote: > > > > > > > > Hi Jagan, > > > > > > On Monday, July 17, 2023 2:44 PM Jagan Teki > > wrote: > > > > On Mon, Jul 17, 2023 at 11:44 AM Liu Ying wrote: > > > > > > > > > > Freescale i.M

Re: [PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-18 Thread Hans Verkuil
Hi Thomas, On 15/07/2023 20:51, Thomas Zimmermann wrote: > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by kzalloc(). So do not > set it. > > Flags should signal differences from the default values. After cleaning > up all occurrences of

[PATCH v13] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-07-18 Thread Chen-Yu Tsai
-off-by: Chen-Yu Tsai --- Changes since v12: - Rebase onto next-20230718 as requested Changes since v11: - Rebase onto v6.5-rc1 - Converted one more instance in anx7625_attach_dsi() introduced by 1464e48d69ab drm/bridge: anx7625: Prevent endless probe loop Splitting this patch out of its original

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Conor, Thank you for your feedback (comments below). On Sat, 2023-07-15 at 11:40 +0100, Conor Dooley wrote: > Hey Sarah, > > Your series does not appear to be threaded. `git send-email` can be > passed, for example, a directory containing a whole series & will set > the correct in-reply-to he

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:08, Frank Binns wrote: >> And this >> items: >> - const: gpu >> can just be >> const: gpu >> >> Although, if there is only one interrupt this is probably not >> particularly helpful. Are there other implementations of this IP that >> have more interrupts? > > No, all our current

[PATCH v2] dma-buf: Fix the typo in DMA-BUF statistics doc

2023-07-18 Thread Luc Ma
From: Luc Ma The kernel-doc for DMA-BUF statistics mentions /sys/kernel/dma-buf/buffers but the correct path is /sys/kernel/dmabuf/buffers instead. Signed-off-by: Luc Ma Reviewed-by: Javier Martinez Canillas --- drivers/dma-buf/dma-buf-sysfs-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread mrip...@kernel.org
Hi, To expand on what Krzysztof said On Tue, Jul 18, 2023 at 01:10:14PM +0200, Krzysztof Kozlowski wrote: > On 18/07/2023 13:08, Frank Binns wrote: > >> And this > >> items: > >> - const: gpu > >> can just be > >> const: gpu > >> > >> Although, if there is only one interrupt this is probably no

Re: [PATCH] drm/i915/tv: avoid possible division by zero

2023-07-18 Thread Andrzej Hajda
On 18.07.2023 12:10, Su Hui wrote: On 2023/7/18 13:39, Dan Carpenter wrote: On Mon, Jul 17, 2023 at 04:52:51PM +0200, Andrzej Hajda wrote: On 17.07.2023 08:22, Su Hui wrote: Clang warning: drivers/gpu/drm/i915/display/intel_tv.c: line 991, column 22 Division by zero. Assuming tv_mode->over

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > + clocks: > > +minItems: 1 > > +maxItems: 3 > >

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote: > On 18/07/2023 13:08, Frank Binns wrote: > > > And this > > > items: > > > - const: gpu > > > can just be > > > const: gpu > > > > > > Although, if there is only one interrupt this is probably not > > > particularly he

Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Alexandru Ardelean
On Tue, Jul 18, 2023 at 11:50 AM Robert Foss wrote: > > On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean wrote: > > > > From: Bogdan Togorean > > > > For ADV7533 and ADV7535 low refresh rate is selected using > > bits [3:2] of 0x4a main register. > > So depending on ADV model write 0xfb or 0x

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > +additionalProperties: false > > + > > +examples: > > +

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:36, Frank Binns wrote: > Hi Krzysztof, > > On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote: >> On 18/07/2023 13:08, Frank Binns wrote: And this items: - const: gpu can just be const: gpu Although, if there is only one interrupt thi

Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

2023-07-18 Thread Frank Binns
Hi Krzysztof, On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:30, Sarah Walker wrote: > > Add the Series AXE GPU node to the AM62 device tree. > > > > Signed-off-by: Sarah Walker > > --- > > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 + > > 1 file

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:47, Frank Binns wrote: > Hi Krzysztof, > > On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote: >> On 14/07/2023 16:25, Sarah Walker wrote: >>> Add the device tree binding documentation for the Series AXE GPU used in >>> TI AM62 SoCs. >>> >> >> ... >> >>> + >>> +additiona

Re: [Intel-gfx] [PATCH] drm/i915: Fix an error handling path in igt_write_huge()

2023-07-18 Thread Andrzej Hajda
On 17.07.2023 20:49, Christophe JAILLET wrote: All error handling paths go to 'out', except this one. Be consistent and also branch to 'out' here. Fixes: c10a652e239e ("drm/i915/selftests: Rework context handling in hugepages selftests") Signed-off-by: Christophe JAILLET For me seems correc

Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5

2023-07-18 Thread Nuno Sá
On Tue, 2023-07-18 at 14:45 +0300, Alexandru Ardelean wrote: > On Tue, Jul 18, 2023 at 11:50 AM Robert Foss wrote: > > > > On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean > > wrote: > > > > > > From: Bogdan Togorean > > > > > > For ADV7533 and ADV7535 low refresh rate is selected using >

Re: [PATCH 2/2] modules/firmware: add a new option to denote a firmware group to choose one.

2023-07-18 Thread Lucas De Marchi
On Tue, Jul 18, 2023 at 10:52:47AM +1000, David Airlie wrote: On Tue, Jul 18, 2023 at 5:41 AM Lucas De Marchi wrote: On Fri, Jul 07, 2023 at 11:41:48AM -0700, Luis Chamberlain wrote: >On Tue, Jul 04, 2023 at 12:50:50PM +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds two tags th

Re: [PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

2023-07-18 Thread suijingfeng
Hi, Thanks for the patch. The commit title generally should be 'drm/looongson: Add a check for lsdc_bo_create() errors' not 'drm: loongson: ' On 2023/7/18 15:01, Dan Carpenter wrote: The lsdc_bo_create() function can fail so add a check for that. Fixes: f39db26c5428 ("drm: Add kms d

Re: [PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

2023-07-18 Thread suijingfeng
"drm/loongson: Add a check for lsdc_bo_create() errors" On 2023/7/18 15:01, Dan Carpenter wrote: The lsdc_bo_create() function can fail so add a check for that. Fixes: f39db26c5428 ("drm: Add kms driver for loongson display controller") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/loo

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-18 Thread Krzysztof Kozlowski
On 18/07/2023 13:32, Frank Binns wrote: > Hi Krzysztof, > > On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote: >> On 14/07/2023 16:25, Sarah Walker wrote: >>> Add the device tree binding documentation for the Series AXE GPU used in >>> TI AM62 SoCs. >>> >> >> ... >> >>> + >>> + clocks:

Re: [PATCH] drm/amdgpu: allow secure submission on VCN4 ring

2023-07-18 Thread Leo Liu
Reviewed-by: Leo Liu On 2023-07-17 13:27, sguttula wrote: This patch will enable secure decode playback on VCN4_0_2 Signed-off-by: sguttula --- Changes in v2: -updated commit message only enabling for VCN402 -updated the logic as per Leo's feedback --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c

Re: [PATCH] drm/amdgpu: Enabling FW workaround through shared memory for VCN4_0_2

2023-07-18 Thread Leo Liu
Reviewed-by: Leo Liu On 2023-07-17 23:20, sguttula wrote: This patch will enable VCN FW workaround using DRM KEY INJECT WORKAROUND method, which is helping in fixing the secure playback. Signed-off-by: sguttula --- Changes in v2: -updated commit message as per veera's feedback Changes in v

[PATCH] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-18 Thread Marek Szyprowski
Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain command transfer FIFO before transfer"). Fixes

Re: [PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

2023-07-18 Thread Dan Carpenter
Basically everything in this email was wrong to a kind of shocking degree. For example, ignoring kmalloc() failure is a bug so the fixes tag is definitely warranted. But then you called me "bare brained" which seems like a personal attack so I'm going to report this as a code of conduct violation

Re: [PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2023 at 10:17:59AM +0200, Raphael Gallais-Pou wrote: > Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This > ultimately causes a warning when the module probes. Fixes it. > > Changes in v2: > - dropped MODULE_ALIAS changes > - changed commit log fo

Re: [PATCH drm-next v7 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-18 Thread Danilo Krummrich
On 7/17/23 12:00, Donald Robson wrote: Hi Danilo, The below part of the documentation is out of date now. Thanks, Donald Thanks Donald for pointing this out. If there aren't any further objections in general I will fix up the comment and then push the GPUVA Manager parts of the series to drm

[PATCH v5 0/9] Update AUX invalidation sequence

2023-07-18 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[PATCH v5 1/9] drm-tip: 2023y-07m-17d-16h-04m-53s UTC integration manifest

2023-07-18 Thread Andi Shyti
From: Robert Foss --- integration-manifest | 24 1 file changed, 24 insertions(+) create mode 100644 integration-manifest diff --git a/integration-manifest b/integration-manifest new file mode 100644 index 0..8642016b34817 --- /dev/null +++ b/integration-ma

[PATCH v5 3/9] drm/i915: Add the has_aux_ccs device property

2023-07-18 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS. Signed

[PATCH v5 2/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-18 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist and

[PATCH v5 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-18 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper --- drivers/gpu/drm/i9

[PATCH v5 5/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-18 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTR

[PATCH v5 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-18 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v5 4/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-18 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by: Nir

[PATCH v5 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-18 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v5 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-18 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

Re: [PATCH v5 1/9] drm-tip: 2023y-07m-17d-16h-04m-53s UTC integration manifest

2023-07-18 Thread Andi Shyti
Sorry! wrong format-patch :) Please ignore patch 1. Andi On Tue, Jul 18, 2023 at 03:38:28PM +0200, Andi Shyti wrote: > From: Robert Foss > > --- > integration-manifest | 24 > 1 file changed, 24 insertions(+) > create mode 100644 integration-manifest > > diff --git a

Re: [PATCH] drm: loongson: Add a check for lsdc_bo_create() errors

2023-07-18 Thread Dan Carpenter
People have suggested that I misread this and that "bare brain" means through code review instead of testing. In context that seems to make sense. Sorry. Anyway, the fixes tag is warranted. > > Even if the fail happened, your patch is not fixing the root problem. What is the correct fix then?

[PATCH v2] drm/i915: Refactor PAT/object cache handling

2023-07-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") has introduced PAT indices to i915 internal APIs, partially replacing the usage of driver internal cache_level, but has also added a few questionable design decisions which this patch tries to improve upon

Re: [PATCH] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-18 Thread Marek Vasut
On 7/18/23 15:18, Marek Szyprowski wrote: Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain com

Re: [PATCH v5 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-18 Thread Nirmoy Das
Hi Andi, On 7/18/2023 3:38 PM, Andi Shyti wrote: Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jona

Re: [PATCH V6 1/9] drivers core: Add support for Wifi band RF mitigations

2023-07-18 Thread Andrew Lunn
> The wbrf_supported_producer and wbrf_supported_consumer APIs seem > unnecessary for the generic implementation. I'm happy with these, once the description is corrected. As i said in another comment, 'can' should be replaced with 'should'. The device itself knows if it can, only the core knows if

Re: [PATCH] drm/panel: simple: Initialize unprepared_time in probe

2023-07-18 Thread Doug Anderson
Hi, On Sun, Jul 9, 2023 at 6:52 AM Marek Vasut wrote: > > The unprepared_time has to be initialized during probe to probe time > ktime, otherwise panel_simple_resume() panel_simple_wait() call may > wait too short time, or no time at all, which would violate the panel > timing specification. Init

Re: [PATCH v3] drm/arm/komeda: Remove component framework and add a simple encoder

2023-07-18 Thread Liviu Dudau
On Wed, Jul 12, 2023 at 12:19:37PM +0530, Faiz Abbas wrote: > The Komeda driver always expects the remote connector node to initialize > an encoder. It uses the component aggregator framework which consists > of component->bind() calls used to initialize the remote encoder and attach > it to the cr

  1   2   3   >