[PATCH] drm/bridge: panel: Add a device link between drm device and panel device

2023-07-17 Thread Liu Ying
Add the device link when panel bridge is attached and delete the link when panel bridge is detached. The drm device is the consumer while the panel device is the supplier. This makes sure that the drm device suspends eariler and resumes later than the panel device, hence resolves problems where t

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
Hi Dmitry, On Mon, 17 Jul 2023 09:52:54 +0300 Dmitry Osipenko wrote: > Panfrost IRQ handler may stuck for a long time, for example this happens > when there is a bad HDMI connection and HDMI handler takes a long time to > finish processing, holding Panfrost. Make Panfrost's job timeout handler >

Re: [PATCH 1/1] drm/bridge: Fix handling of bridges with pre_enable_prev_first flag

2023-07-17 Thread Frieder Schrempf
On 14.07.23 19:16, Dave Stevenson wrote: > Hi Frieder > > On Mon, 10 Jul 2023 at 08:46, Frieder Schrempf > wrote: >> >> On 07.07.23 21:00, Vladimir Lypak wrote: >>> [Sie erhalten nicht häufig E-Mails von vladimir.ly...@gmail.com. Weitere >>> Informationen, warum dies wichtig ist, finden Sie unte

Re: [net-next v9 00/11] Brcm ASP 2.0 Ethernet Controller

2023-07-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 13 Jul 2023 15:18:55 -0700 you wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. > > Florian Fainelli (2): > dt-bindings: net: Brcm ASP 2.0 Ethernet

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-17 Thread Heiko Stuebner
Am Freitag, 14. Juli 2023, 19:45:34 CEST schrieb Rob Herring: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each ot

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-17 Thread Sam Ravnborg
Hi Rob, On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Dmitry Osipenko
Hi, On 7/17/23 10:05, Boris Brezillon wrote: > Hi Dmitry, > > On Mon, 17 Jul 2023 09:52:54 +0300 > Dmitry Osipenko wrote: > >> Panfrost IRQ handler may stuck for a long time, for example this happens >> when there is a bad HDMI connection and HDMI handler takes a long time to >> finish processi

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-07-17 Thread Krzysztof Kozlowski
On 14/07/2023 16:25, Sarah Walker wrote: > Add the device tree binding documentation for the Series AXE GPU used in > TI AM62 SoCs. > ... > + > + clocks: > +minItems: 1 > +maxItems: 3 > + > + clock-names: > +items: > + - const: core > + - const: mem > + - const: sys

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Emil Velikov
On Fri, 14 Jul 2023 at 11:32, Simon Ser wrote: > > (cc Daniel Vetter and Pekka because this change has uAPI repercussions) > > On Friday, June 30th, 2023 at 13:56, James Zhu wrote: > > > From: Christian König > > > > This makes room for up to 128 DRM devices. > > > > Signed-off-by: Christian Kön

Re: [PATCH v4 3/4] drm/mediatek: Fix unintentional integer overflow in multiplying different types

2023-07-17 Thread AngeloGioacchino Del Regno
Il 14/07/23 11:49, Jason-JH.Lin ha scritto: 1. Instead of multiplying 2 variable of different types. Change to assign a value of one variable and then multiply the other variable. 2. Add a int variable for multiplier calculation instead of calculating different types multiplier with dma_addr_t v

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 10:20:02 +0300 Dmitry Osipenko wrote: > Hi, > > On 7/17/23 10:05, Boris Brezillon wrote: > > Hi Dmitry, > > > > On Mon, 17 Jul 2023 09:52:54 +0300 > > Dmitry Osipenko wrote: > > > >> Panfrost IRQ handler may stuck for a long time, for example this happens > >> when there

[PATCH v7 0/7] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2023-07-17 Thread Sandor Yu
The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge drivers and Cadence HDP-TX PHY(HDMI/DP) drivers for Freescale i.MX8MQ. The patch set compose of DRM bridge drivers and PHY drivers. Both of them need the followed two patches to pass build. drm: bridge: Cadence: convert mailbox

[PATCH v7 2/7] phy: Add HDMI configuration options

2023-07-17 Thread Sandor Yu
Allow HDMI PHYs to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are based on HDMI PHY implementation practices. The current set of parameters should cover the potential users. Signed-off-by: Sandor Yu --- include/l

[PATCH v7 3/7] dt-bindings: display: bridge: Add Cadence MHDP850

2023-07-17 Thread Sandor Yu
Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge.. Signed-off-by: Sandor Yu --- .../display/bridge/cdns,mhdp8501.yaml | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml diff --git

[PATCH v7 1/7] drm: bridge: Cadence: convert mailbox functions to macro functions

2023-07-17 Thread Sandor Yu
MHDP8546 mailbox access functions will be share to other mhdp driver and Cadence HDP-TX HDMI/DP PHY drivers. Move those functions to head file include/drm/bridge/cdns-mhdp-mailbox.h and convert them to macro functions. Signed-off-by: Sandor Yu --- .../drm/bridge/cadence/cdns-mhdp8546-core.c |

[PATCH v7 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2023-07-17 Thread Sandor Yu
Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and activated by SOC's ROM code. Bootload binary incl

[PATCH v7 5/7] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY

2023-07-17 Thread Sandor Yu
Add bindings for Freescale iMX8MQ DP and HDMI PHY. Signed-off-by: Sandor Yu --- .../bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml | 53 +++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/fsl,imx8mq-dp-hdmi-phy.yaml diff --git a/Documentat

[PATCH v7 6/7] phy: freescale: Add DisplayPort PHY driver for i.MX8MQ

2023-07-17 Thread Sandor Yu
Add Cadence HDP-TX DisplayPort PHY driver for i.MX8MQ Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. DisplayPort PHY mode is configurated in the driver. Signed-off-by: Sandor Yu --- drivers/phy/freescale/Kconfig | 9 + drivers/phy/

[PATCH v7 7/7] phy: freescale: Add HDMI PHY driver for i.MX8MQ

2023-07-17 Thread Sandor Yu
Add Cadence HDP-TX HDMI PHY driver for i.MX8MQ. Cadence HDP-TX PHY could be put in either DP mode or HDMI mode base on the configuration chosen. HDMI PHY mode is configurated in the driver. Signed-off-by: Sandor Yu --- drivers/phy/freescale/Kconfig | 9 + drivers/phy/freescale/M

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Steven Price
On 17/07/2023 08:49, Boris Brezillon wrote: > On Mon, 17 Jul 2023 10:20:02 +0300 > Dmitry Osipenko wrote: > >> Hi, >> >> On 7/17/23 10:05, Boris Brezillon wrote: >>> Hi Dmitry, >>> >>> On Mon, 17 Jul 2023 09:52:54 +0300 >>> Dmitry Osipenko wrote: >>> Panfrost IRQ handler may stuck for a

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Geert Uytterhoeven
Hi Javier, On Sun, Jul 16, 2023 at 3:30 PM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > The native display format of ssd1306 OLED displays is monochrome > > light-on-dark (R1). This patch series adds support for the R1 buffer > > format to both the ssd130x DRM driver and the

Re: [PATCH v4 04/17] drm/imagination: Add skeleton PowerVR driver

2023-07-17 Thread Maxime Ripard
On Fri, 14 Jul 2023 15:26:02 +0100, Sarah Walker wrote: > This adds the basic skeleton of the driver. The driver registers > itself with DRM on probe. Ioctl handlers are currently implemented > as stubs. > > Changes since v3: > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 05/17] drm/imagination: Get GPU resources

2023-07-17 Thread Maxime Ripard
On Fri, 14 Jul 2023 15:26:18 +0100, Sarah Walker wrote: > Acquire clock and register resources, and enable/map as appropriate. > > Changes since v3: > - Remove regulator resource (not used on supported platform) > - Use devm helpers > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

[PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-07-17 Thread Dmitry Osipenko
Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead developer of the Panfrost Mesa driver and main developer behind the upcoming Panthor kernel driver that will serve next-gen Mali GPUs. Remove Tomeu and Alyssa, who left Collabora and stepped down from working on Panfrost. Sign

Re: [PATCH v4 07/17] drm/imagination: Add GPU ID parsing and firmware loading

2023-07-17 Thread Maxime Ripard
On Fri, Jul 14, 2023 at 03:27:00PM +0100, Sarah Walker wrote: > +/** > + * pvr_device_gpu_fini() - GPU-specific deinitialization for a PowerVR device > + * @pvr_dev: Target PowerVR device. > + */ > +static void > +pvr_device_gpu_fini(struct pvr_device *pvr_dev) > +{ > + release_firmware(pvr_dev

Re: [PATCH v4 09/17] drm/imagination: Implement power management

2023-07-17 Thread Maxime Ripard
On Fri, 14 Jul 2023 15:27:34 +0100, Sarah Walker wrote: > Add power management to the driver, using runtime pm. The power off > sequence depends on firmware commands which are not implemented in this > patch. > > Changes since v3: > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 16/17] drm/imagination: Add driver documentation

2023-07-17 Thread Maxime Ripard
On Fri, 14 Jul 2023 15:30:15 +0100, Sarah Walker wrote: > Add documentation for the UAPI and for the virtual memory design. > > Signed-off-by: Sarah Walker Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

2023-07-17 Thread Maxime Ripard
Hi, On Fri, Jul 14, 2023 at 03:30:33PM +0100, Sarah Walker wrote: > Add the Series AXE GPU node to the AM62 device tree. > > Signed-off-by: Sarah Walker Checkpatch complains about that one because you indented the node with spaces instead of tabs. Once fixed: Reviewed-by: Maxime Ripard Maxim

Re: [PATCH v1 0/8] drm/etnaviv: Various cleanup

2023-07-17 Thread suijingfeng
Hi, Dear etnaviv folks Would you like to review this cleanup patch set ? I am asking because I'm wondering that if I should re-spin my other patch from the code base which *with* this series applied or from the code base *without* this series applied. I think this series looks fine, is it

Re: [PATCH] drm: Explicitly include correct DT includes

2023-07-17 Thread Steven Price
On 14/07/2023 18:45, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include

Re: [PATCH 0/2] eventfd: simplify signal helpers

2023-07-17 Thread Grzegorz Jaszczyk
pt., 14 lip 2023 o 09:05 Christian Brauner napisał(a): > > On Thu, Jul 13, 2023 at 11:10:54AM -0600, Alex Williamson wrote: > > On Thu, 13 Jul 2023 12:05:36 +0200 > > Christian Brauner wrote: > > > > > Hey everyone, > > > > > > This simplifies the eventfd_signal() and eventfd_signal_mask() helper

Re: [PATCH 1/2] backlight: lp855x: Initialize PWM state on first brightness change

2023-07-17 Thread Daniel Thompson
On Fri, Jul 14, 2023 at 02:14:39PM +0200, Artur Weber wrote: > As pointed out by Uwe Kleine-König[1], the changes introduced in > commit c1ff7da03e16 ("video: backlight: lp855x: Get PWM for PWM mode > during probe") caused the PWM state set up by the bootloader to be > re-set when the driver is pro

Re: [PATCH 2/2] backlight: lp855x: Catch errors when changing brightness

2023-07-17 Thread Daniel Thompson
On Fri, Jul 14, 2023 at 02:14:40PM +0200, Artur Weber wrote: > The lp855x_bl_update_status function's return type is int, but > it always returns 0, without checking for the results of the > write_byte/pwm_ctrl functions called within. > > Make this function return the return values of the function

Re: [PATCH 2/4] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-07-17 Thread Maxime Ripard
Hi, On Fri, Jul 14, 2023 at 03:06:17PM -0300, Carlos Eduardo Gallo Filho wrote: > Add a parametrized test for the drm_framebuffer_check_src_coords function. > > Signed-off-by: Carlos Eduardo Gallo Filho > --- > drivers/gpu/drm/tests/drm_framebuffer_test.c | 107 +++ > 1 file cha

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Thomas Zimmermann
Hi Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each plane update"): [drm] Initialized ssd130x 1.0.0 20220131 for 0-003c on minor 0 ss

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 09:06:56 +0100 Steven Price wrote: > On 17/07/2023 08:49, Boris Brezillon wrote: > > On Mon, 17 Jul 2023 10:20:02 +0300 > > Dmitry Osipenko wrote: > > > >> Hi, > >> > >> On 7/17/23 10:05, Boris Brezillon wrote: > >>> Hi Dmitry, > >>> > >>> On Mon, 17 Jul 2023 09:52:54 +0

Re: [PATCH v1] MAINTAINERS: Add Boris Brezillon as Panfrost driver maintainer

2023-07-17 Thread Boris Brezillon
On Mon, 17 Jul 2023 11:15:44 +0300 Dmitry Osipenko wrote: > Add Boris Brezillon as Panfrost driver maintainer. Boris is a new lead > developer of the Panfrost Mesa driver and main developer behind the > upcoming Panthor kernel driver that will serve next-gen Mali GPUs. > > Remove Tomeu and Alyss

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Steven Price
On 17/07/2023 09:49, Boris Brezillon wrote: > On Mon, 17 Jul 2023 09:06:56 +0100 > Steven Price wrote: > >> On 17/07/2023 08:49, Boris Brezillon wrote: >>> On Mon, 17 Jul 2023 10:20:02 +0300 >>> Dmitry Osipenko wrote: >>> Hi, On 7/17/23 10:05, Boris Brezillon wrote: > Hi

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Hi > > Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: [...] >> >> +static const struct drm_mode_config_helper_funcs >> ssd130x_mode_config_helpers = { >> +.atomic_commit_tail = drm_atomic_helper_commit_tail_rpm, >> +}; >> + > > After so

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann wrote: > Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: > > Geert reports that the following NULL pointer dereference happens for him > > after commit 49d7d581ceaf ("drm/ssd130x: Don't allocate buffers on each > > plane update"

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Hi Javier, > > On Sun, Jul 16, 2023 at 3:30 PM Javier Martinez Canillas > wrote: >> Geert Uytterhoeven writes: >> > The native display format of ssd1306 OLED displays is monochrome >> > light-on-dark (R1). This patch series adds support for the R1 buf

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Geert Uytterhoeven
Hi Javier, On Mon, Jul 17, 2023 at 11:13 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > On Sun, Jul 16, 2023 at 3:30 PM Javier Martinez Canillas > > wrote: > >> Geert Uytterhoeven writes: > >> > The native display format of ssd1306 OLED displays is monochrome > >> > light-

[PATCH 1/1] drm/imx/dcss: Use dev_err_probe

2023-07-17 Thread Alexander Stein
This helps identifying problems with downstream pipeline devices, like HDMI/DP output. Signed-off-by: Alexander Stein --- drivers/gpu/drm/imx/dcss/dcss-drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c b/drivers/gpu/drm/imx/dcss/dcss-drv.c index 4f229

[PATCH] drm/doc: document drm_event and its types

2023-07-17 Thread Simon Ser
Convert struct drm_event to a kernel doc comment. Link to the generic DRM event types. Add a basic description of each event type. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- include/uapi/drm/drm.h | 45 -- 1 file changed, 35 insert

Re: [PATCH v7 0/7] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2023-07-17 Thread Alexander Stein
Hi Sandor, Am Montag, 17. Juli 2023, 10:03:46 CEST schrieb Sandor Yu: > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge > drivers and Cadence HDP-TX PHY(HDMI/DP) drivers for Freescale i.MX8MQ. > > The patch set compose of DRM bridge drivers and PHY drivers. > > Both of them ne

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Javier, [...] >> >> penguin in test004 is not displayed correctly. I was expecting that to be >> >> working correctly since you mentioned to be using the Linux logo on boot. >> > >> > Linux has logos for displays using 2, 16, and 256 colors. Note that the >> > de

Re: [PATCH v7 3/7] dt-bindings: display: bridge: Add Cadence MHDP850

2023-07-17 Thread Alexander Stein
Am Montag, 17. Juli 2023, 10:03:49 CEST schrieb Sandor Yu: > > Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen, > dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie > die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weite

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert and Thomas, > Hi Thomas, > > On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann > wrote: [...] >> >> After some discussion on IRC, I'd suggest to allocate the buffer >> somewhere within probe. So it will always be there when the plane code runs. >> >> A

Re: [PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages

2023-07-17 Thread Lucas Stach
Hi Jingfeng, Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng > > Because the etnaviv_gem_new_private() function receives the size_t argument > for the number of pages. And the number of pages should be unsigned. > > Note that Most 32-bit architectures use "u

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Simon Ser
On Monday, July 17th, 2023 at 09:30, Emil Velikov wrote: > > I'm worried what might happen with old user-space, especially old libdrm. > > I also share the same concern. Although the bigger issue is not libdrm > - since we can update it and prod distributions to update it. > The biggest concern

Re: [PATCH v1 3/8] drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl()

2023-07-17 Thread Lucas Stach
Hi Jingfeng, Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng > > Because it is not used by the etnaviv_gem_new_impl() function, > no functional change. > I think it would make sense to move into the opposite direction: in both callsites of etnaviv_gem_new_im

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-17 Thread suijingfeng
Hi, On 2023/7/11 21:43, Sui Jingfeng wrote: From: Sui Jingfeng Currently, vgaarb only cares about PCI VGA-compatible class devices. While vga_arbiter_del_pci_device() gets called unbalanced when some PCI device is about to be removed. This happens even during the boot process. Another reason

Re: [PATCH v1 4/8] drm/etnaviv: Remove surplus else after return

2023-07-17 Thread Lucas Stach
Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng > > Because the 'else' is not generally useful after the 'return'. While your cleanup is a correct rewrite of the function, the current code in this function is bogus, as we need to check for the bidirectional (

Re: [PATCH drm-next v7 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-17 Thread Donald Robson
Hi Danilo, The below part of the documentation is out of date now. Thanks, Donald On Thu, 2023-07-13 at 19:03 +0200, Danilo Krummrich wrote: > > + > +/** > + * DOC: Locking > + * > + * Generally, the GPU VA manager does not take care of locking itself, it is > + * the drivers responsibility to ta

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Geert Uytterhoeven
Hi Javier, On Mon, Jul 17, 2023 at 11:33 AM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > >> >> penguin in test004 is not displayed correctly. I was expecting that to > >> >> be > >> >> working correctly since you mentioned to be using the Linux logo on > >> >> boot. > >> > >

Re: [PATCH v1 8/8] drm/etnaviv: Add a helper to get a pointer to the first available node

2023-07-17 Thread Lucas Stach
Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng > > This make the code in etnaviv_pdev_probe() less twisted, drop the reference > to device node after finished. Also kill a double blank line. > I can't spot the double blank line you claim to remove. > Signed

Re: [PATCH v1 0/8] drm/etnaviv: Various cleanup

2023-07-17 Thread Lucas Stach
Hi Jingfeng, Am Montag, dem 17.07.2023 um 16:36 +0800 schrieb suijingfeng: > Hi, Dear etnaviv folks > > > Would you like to review this cleanup patch set ? > > I am asking because I'm wondering that > > if I should re-spin my other patch from the code base > > which *with* this series applied

Re: [PATCH 0/8] drm: fb-helper/ssd130x: Add support for DRM_FORMAT_R1

2023-07-17 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: > Hi Javier, > > On Mon, Jul 17, 2023 at 11:33 AM Javier Martinez Canillas > wrote: >> Geert Uytterhoeven writes: >> >> >> penguin in test004 is not displayed correctly. I was expecting that to >> >> >> be >> >> >> working correctly since you mentioned to be using th

Re: [PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages

2023-07-17 Thread Sui Jingfeng
Hi On 2023/7/17 17:43, Lucas Stach wrote: Hi Jingfeng, Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: From: Sui Jingfeng Because the etnaviv_gem_new_private() function receives the size_t argument for the number of pages. And the number of pages should be unsigned. Note tha

Re: [PATCH v1 8/8] drm/etnaviv: Add a helper to get a pointer to the first available node

2023-07-17 Thread suijingfeng
Hi, On 2023/7/17 18:07, Lucas Stach wrote: Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: From: Sui Jingfeng This make the code in etnaviv_pdev_probe() less twisted, drop the reference to device node after finished. Also kill a double blank line. I can't spot the double bla

Re: [PATCH 2/5] mm: use vma_is_stack() and vma_is_heap()

2023-07-17 Thread David Hildenbrand
On 12.07.23 16:38, Kefeng Wang wrote: Use the helpers to simplify code. Signed-off-by: Kefeng Wang --- fs/proc/task_mmu.c | 24 fs/proc/task_nommu.c | 15 +-- 2 files changed, 5 insertions(+), 34 deletions(-) Please squash patch #1 and this patch an

Re: [PATCH 1/5] mm: introduce vma_is_stack() and vma_is_heap()

2023-07-17 Thread David Hildenbrand
On 12.07.23 16:38, Kefeng Wang wrote: Introduce the two helpers for general use. Signed-off-by: Kefeng Wang --- include/linux/mm.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 1462cf15badf..0bbeb31ac750 100644 --- a/include/l

Re: [PATCH v1 8/8] drm/etnaviv: Add a helper to get a pointer to the first available node

2023-07-17 Thread Sui Jingfeng
Hi, On 2023/7/17 18:07, Lucas Stach wrote: Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: From: Sui Jingfeng This make the code in etnaviv_pdev_probe() less twisted, drop the reference to device node after finished. Also kill a double blank line. I can't spot the double bla

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: > Geert Uytterhoeven writes: > > Hello Geert and Thomas, > >> Hi Thomas, >> >> On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann >> wrote: > > [...] > >>> >>> After some discussion on IRC, I'd suggest to allocate the buffer >>> somewhere within probe. So it wi

Re: [PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages

2023-07-17 Thread Lucas Stach
Am Montag, dem 17.07.2023 um 18:12 +0800 schrieb Sui Jingfeng: > Hi > > On 2023/7/17 17:43, Lucas Stach wrote: > > Hi Jingfeng, > > > > Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: > > > From: Sui Jingfeng > > > > > > Because the etnaviv_gem_new_private() function receives th

Re: [RFC 2/2] drm/i915: Remove PAT hack from i915_gem_object_can_bypass_llc

2023-07-17 Thread Tvrtko Ursulin
On 15/07/2023 01:20, Matt Roper wrote: On Fri, Jul 14, 2023 at 11:11:30AM +0100, Tvrtko Ursulin wrote: On 14/07/2023 06:43, Yang, Fei wrote: From: Tvrtko Ursulin According to the comment in i915_gem_object_can_bypass_llc the purpose of the function is to return false if the platform/object

Re: [PATCH] drm/doc: document drm_event and its types

2023-07-17 Thread Pekka Paalanen
On Mon, 17 Jul 2023 09:30:39 + Simon Ser wrote: > Convert struct drm_event to a kernel doc comment. Link to the > generic DRM event types. Add a basic description of each event > type. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > --- > include/uapi/drm/drm.h |

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Thomas Zimmermann
Hi Am 17.07.23 um 11:04 schrieb Geert Uytterhoeven: Hi Thomas, On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann wrote: Am 13.07.23 um 18:32 schrieb Javier Martinez Canillas: Geert reports that the following NULL pointer dereference happens for him after commit 49d7d581ceaf ("drm/ssd130x: D

[PATCH v2] drm/i915: Fix premature release of request's reusable memory

2023-07-17 Thread Janusz Krzysztofik
Infinite waits for completion of GPU activity have been observed in CI, mostly inside __i915_active_wait(), triggered by igt@gem_barrier_race or igt@perf@stress-open-close. Root cause analysis, based of ftrace dumps generated with a lot of extra trace_printk() calls added to the code, revealed loo

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Geert Uytterhoeven
Hi Javier, On Mon, Jul 17, 2023 at 12:37 PM Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > >> On Mon, Jul 17, 2023 at 10:48 AM Thomas Zimmermann > >> wrote: > >>> After some discussion on IRC, I'd suggest to allocate the buffer > >>> somewhere within probe. So it will alw

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-07-17 Thread Oded Gabbay
On Wed, Jun 21, 2023 at 8:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 6:21 PM Aravind Iddamsetty > wrote: > > > > Our hardware supports RAS(Reliability, Availability, Serviceability) by > > exposing a set of error counters which can be used by observability > > tools to take correctiv

[PATCH v3 0/5] Update AUX invalidation sequence

2023-07-17 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[PATCH v3 2/5] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu

[PATCH v3 3/5] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-17 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: # v5.

[PATCH v3 1/5] drm/i915/gt: Cleanup aux invalidation registers

2023-07-17 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist. S

[PATCH v3 4/5] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-17 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v3 5/5] drm/i915/gt: Support aux invalidation on all engines

2023-07-17 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

[PATCH] drm/doc: add warning about connector_type_id stability

2023-07-17 Thread Simon Ser
Mention that the connector_type_id is not stable: it depends on driver and device probe order. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- include/uapi/drm/drm_mode.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm

[PATCH v3] drm/bridge_connector: Handle drm_connector_init_with_ddc() failures

2023-07-17 Thread Geert Uytterhoeven
drm_connector_init_with_ddc() can fail, but the call in drm_bridge_connector_init() does not check that. Fix this by adding the missing error handling. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Reviewed-by: Maxime Ripard --- v3: - Add Reviewed-by, v2: - Move declarat

[PATCH v2] drm/udl: Convert to drm_crtc_helper_atomic_check()

2023-07-17 Thread Geert Uytterhoeven
Use the drm_crtc_helper_atomic_check() helper instead of open-coding the same operation. Signed-off-by: Geert Uytterhoeven Reviewed-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- Compile-tested only. v2: - Add Reviewed-by. --- drivers/gpu/drm/udl/udl_modeset.c | 13 ++--- 1 fil

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-17 Thread Sui Jingfeng
Hi, On 2023/7/17 17:51, suijingfeng wrote: Hi, On 2023/7/11 21:43, Sui Jingfeng wrote: From: Sui Jingfeng Currently, vgaarb only cares about PCI VGA-compatible class devices. While vga_arbiter_del_pci_device() gets called unbalanced when some PCI device is about to be removed. This happens

RE: [PATCH v3 3/4] drm/mediatek: Add casting before assign

2023-07-17 Thread David Laight
From: Jason-JH Lin > Sent: 14 July 2023 07:46 > > Hi CK, > > Thanks for the reviews. > > On Fri, 2023-07-14 at 05:45 +, CK Hu (胡俊光) wrote: > > Hi, Jason: > > > > On Wed, 2023-06-21 at 18:22 +0800, Jason-JH.Lin wrote: > > > 1. Add casting before assign to avoid the unintentional integer > > >

[PATCH v2] drm: Spelling s/sempahore/semaphore/

2023-07-17 Thread Geert Uytterhoeven
Fix misspellings of "semaphore". Signed-off-by: Geert Uytterhoeven Reviewed-by: Hamza Mahfooz --- v2: - Add Reviewed-by. --- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/radeon/cik.c| 2 +- drivers/gpu/drm/radeon/r600.c | 2 +- include/drm/task_barrier.h

[PATCH v3] drm: Spelling s/randevouz/rendez-vous/

2023-07-17 Thread Geert Uytterhoeven
Fix a misspelling of "rendez-vous". Signed-off-by: Geert Uytterhoeven Reviewed-by: Hamza Mahfooz --- v3: - Add Reviewed-by, v2: - s/vouz/vous/. --- include/drm/task_barrier.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/task_barrier.h b/include/drm/task_b

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Emil Velikov
On Mon, 17 Jul 2023 at 10:45, Simon Ser wrote: > > On Monday, July 17th, 2023 at 09:30, Emil Velikov > wrote: > > > > I'm worried what might happen with old user-space, especially old libdrm. > > > > I also share the same concern. Although the bigger issue is not libdrm > > - since we can update

[PATCH v2 resend 2] drm/armada: Fix off-by-one error in armada_overlay_get_property()

2023-07-17 Thread Geert Uytterhoeven
As ffs() returns one more than the index of the first bit set (zero means no bits set), the color key mode value is shifted one position too much. Fix this by using FIELD_GET() instead. Fixes: c96103b6c49ff9a8 ("drm/armada: move colorkey properties into overlay plane state") Signed-off-by: Geert

Re: [PATCH] drm/ssd130x: Fix an oops when attempting to update a disabled plane

2023-07-17 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, Thanks for your review! > Hi Javier, [...] >> - ssd130x->buffer = kcalloc(pitch, ssd130x->height, GFP_KERNEL); >> - if (!ssd130x->buffer) >> - return -ENOMEM; >> + ssd130x->buffer = devm_kcalloc(ssd130x->dev, pitc

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-17 Thread suijingfeng
On 2023/7/17 21:17, Sui Jingfeng wrote: So without we can craft something new easily without significant change. Therefore, We can *NOT* craft something new easily without significant change. Especially userspace changes. So my current patch choose to keep the original behavior. At the sa

Re: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler

2023-07-17 Thread Dmitry Osipenko
17.07.2023 11:59, Steven Price пишет: > On 17/07/2023 09:49, Boris Brezillon wrote: >> On Mon, 17 Jul 2023 09:06:56 +0100 >> Steven Price wrote: >> >>> On 17/07/2023 08:49, Boris Brezillon wrote: On Mon, 17 Jul 2023 10:20:02 +0300 Dmitry Osipenko wrote: > Hi, > > On

[PATCH] drm/mgag200: Increase bandwidth for G200se A rev1

2023-07-17 Thread Jocelyn Falempe
A G200SE_A rev 1 user reported that prior to v6.0, he was able to get Xorg working at 1440x900@60Hz. This somehow bypassed the bandwidth test in the driver. After v6.0, and the driver refactor, it's no longer possible. So increase the bandwidth, as the hardware is able to do it. In mgag200_calcula

Re: [PATCH v1 1/8] drm/etnaviv: Using the size_t variable to store the number of pages

2023-07-17 Thread Sui Jingfeng
Hi, On 2023/7/17 18:38, Lucas Stach wrote: Am Montag, dem 17.07.2023 um 18:12 +0800 schrieb Sui Jingfeng: Hi On 2023/7/17 17:43, Lucas Stach wrote: Hi Jingfeng, Am Freitag, dem 23.06.2023 um 18:08 +0800 schrieb Sui Jingfeng: From: Sui Jingfeng Because the etnaviv_gem_new_private() function

[PATCH resend] drm/panel: simple: Simplify matching using of_device_get_match_data()

2023-07-17 Thread Geert Uytterhoeven
Both the patform_driver and mipi_dsi_driver structures contain pointers to the match table used, so the custom code to obtain match and match data can be replaced by calls to of_device_get_match_data(). Signed-off-by: Geert Uytterhoeven --- drivers/gpu/drm/panel/panel-simple.c | 15 ++---

Re: [PATCH] drm: support up to 128 drm devices

2023-07-17 Thread Simon Ser
On Monday, July 17th, 2023 at 15:24, Emil Velikov wrote: > > > For going forward, here is one way we can shave this yak: > > > - update libdrm to max 64 nodes > > > - roll libdrm release, nag distributions to update to it // could be > > > folded with the next release below > > > - update lib

Re: [PATCH 01/39] dt-bindings: display: Add Renesas SH-Mobile LCDC bindings

2023-07-17 Thread Geert Uytterhoeven
Hi Rob, Thanks for your review! On Thu, Jun 22, 2023 at 4:52 PM Rob Herring wrote: > On Thu, Jun 22, 2023 at 11:21:13AM +0200, Geert Uytterhoeven wrote: > > Add device tree bindings for the LCD Controller (LCDC) found in Renesas > > SuperH SH-Mobile and ARM SH/R-Mobile SOCs. > > > > Based on a p

Re: [PATCH] drm/doc: add warning about connector_type_id stability

2023-07-17 Thread Pekka Paalanen
On Mon, 17 Jul 2023 13:13:09 + Simon Ser wrote: > Mention that the connector_type_id is not stable: it depends on > driver and device probe order. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > --- > include/uapi/drm/drm_mode.h | 3 +++ > 1 file changed, 3 insert

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-17 Thread suijingfeng
Hi, Fixes: f6b1772b2555 ('vgaarb: remove the unused irq_set_state argument to vga_client_register') Because after applied that patch, there have only one callback mechanism we can use, not two anymore. On 2023/7/12 00:43, Sui Jingfeng wrote: From: Sui Jingfeng Currently, the strategy

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-17 Thread Nirmoy Das
On 7/17/2023 2:51 PM, Andi Shyti wrote: Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc:

Re: [PATCH v3 2/5] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-17 Thread Nirmoy Das
On 7/17/2023 2:51 PM, Andi Shyti wrote: From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by:

Re: [PATCH] char: Explicitly include correct DT includes

2023-07-17 Thread Jarkko Sakkinen
On Fri Jul 14, 2023 at 5:43 PM UTC, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. Th

[PATCH v6 00/11] MediaTek DisplayPort: support eDP and aux-bus

2023-07-17 Thread AngeloGioacchino Del Regno
) - Rebased over next-20230717 Changes in v5: - Added .wait_hpd_asserted() callback for aux-bus - Avoid enabling and registering HPD interrupt + handlers for eDP case only (keeps HPD interrupts enabled for full DP case) - Support not always-on eDP panels (boot with regulator off, suspend with

  1   2   3   >