Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Jammy Huang
Hi Jocelyn, Thanks for your work. On 2023/7/13 下午 02:40, Jocelyn Falempe wrote: Aspeed always report the display port as "connected", because it doesn't set a .detect_ctx callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the following regression: S

Re: [PATCH] drm/ast: Do not enable PCI resources multiple times

2023-07-13 Thread Jocelyn Falempe
On 12/07/2023 15:08, Thomas Zimmermann wrote: Remove ast_init_pci_config() as the ast driver already enables the PCI resources by calling pcim_enable_device(). Suggested-by: Sui Jingfeng Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_main.c | 21 - 1 file c

Re: [PATCH] drm/doc: document that PRIME import/export is always supported

2023-07-13 Thread Simon Ser
On Thursday, July 13th, 2023 at 07:09, Thomas Zimmermann wrote: > > + * Starting from kernel version 6.6, both &DRM_PRIME_CAP_IMPORT and > > + * &DRM_PRIME_CAP_EXPORT are always advertised. > > + * > > When people port these changes into their trees the version becomes > meaningless. There are

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Thierry Reding
Shortening the absurdly long recipient list, Google won't let me send this otherwise. On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated abou

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-13 Thread Frieder Schrempf
Hi Tim, On 13.07.23 00:34, Tim Harvey wrote: > On Wed, May 3, 2023 at 9:33 AM Frieder Schrempf wrote: >> >> From: Frieder Schrempf >> >> According to the documentation [1] the proper enable flow is: >> >> 1. Enable DSI link and keep data lanes in LP-11 (stop state) >> 2. Disable stop state to br

[PULL] drm-intel-fixes

2023-07-13 Thread Tvrtko Ursulin
Hi Dave, Daniel, Just a few small fixes for the 6.5 RC this week - one functional fixup for reading of perf/OA buffers and some code cleanups elsewhere. Regards, Tvrtko drm-intel-fixes-2023-07-13: - Don't preserve dpll_hw_state for slave crtc in Bigjoiner (Stanislav Lisovskiy) - Consider OA buf

Re: [PATCH 0/4] drm/mediatek: Small mtk-dpi cleanups

2023-07-13 Thread AngeloGioacchino Del Regno
Il 12/04/23 13:52, AngeloGioacchino Del Regno ha scritto: This is a small cleanup of the mtk-dpi driver, switching it to devm variants where possible and where it made sense, and reducing lines while retaining and improving human readability. AngeloGioacchino Del Regno (4): drm/mediatek: mtk_

Re: [Intel-gfx] [PATCH v4] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-13 Thread Tvrtko Ursulin
On 12/07/2023 18:49, Teres Alexis, Alan Previn wrote: On Wed, 2023-07-12 at 10:19 +0100, Tvrtko Ursulin wrote: On 11/07/2023 23:02, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gs

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Uwe Kleine-König
Hello Jani, On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer variables being named "dev" > > because with t

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Sean Paul
On Wed, Jul 12, 2023 at 10:52 AM Jani Nikula wrote: > > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > Hello, > > > > while I debugged an issue in the imx-lcdc driver I was constantly > > irritated about struct drm_device pointer variables being named "dev" > > because with that name I usually

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Geert Uytterhoeven
Hi Uwe, Let's add some fuel to keep the thread alive ;-) On Wed, Jul 12, 2023 at 6:13 PM Uwe Kleine-König wrote: > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > > On Wed, 12 Jul 2023, Uwe Kleine-König > > wrote: > > > Hello, > > > > > > while I debugged an issue in the imx-lcd

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Krzysztof Kozlowski
On 12/07/2023 20:31, Sean Paul wrote: >>> 216 struct drm_device *ddev >>> 234 struct drm_device *drm_dev >>> 611 struct drm_device *drm >>>4190 struct drm_device *dev >>> >>> This series starts with renaming struct drm_crtc::dev to drm_dev. If >>> it's not only me and others like th

[PATCH] drm/vmwgfx: "foo* const bar" should be "foo * const bar"\ that ope- n brace { should be on the previous line

2023-07-13 Thread liubin001
(1)The standard format for declaring a pointer is to add a space bet- ween the type name and the * symbol, as well as between the * symbol and the variable name. (2) that open brace { should be on the previous line Signed-off-by: Bin Liu --- drivers/gpu/drm/vmwgfx/vmwgfx_msg.c | 2 +- 1 file

Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-13 Thread Luben Tuikov
On 2023-07-12 09:53, Christian König wrote: > Am 12.07.23 um 15:38 schrieb Uwe Kleine-König: >> Hello Maxime, >> >> On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote: >>> On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-König wrote: > Background is that this makes merge conflict

[BUG]: Getting a unique connector name when identical displays are connected

2023-07-13 Thread SUNIDHI DIXIT
Hello all, This is regarding an issue I have encountered recently in drm. When I connect two identical HDMI display(with same resolution) there is no way to distinguish them uniquely. I looked into that and found that the connector id, and connector_type_id can be changed based on which connector

Re: [PATCH] drm/doc: document that PRIME import/export is always supported

2023-07-13 Thread Thomas Zimmermann
Am 13.07.23 um 09:17 schrieb Simon Ser: On Thursday, July 13th, 2023 at 07:09, Thomas Zimmermann wrote: + * Starting from kernel version 6.6, both &DRM_PRIME_CAP_IMPORT and + * &DRM_PRIME_CAP_EXPORT are always advertised. + * When people port these changes into their trees the version bec

Re: [PATCH v5 6/6] drm/doc: Define KMS atomic state set

2023-07-13 Thread Pekka Paalanen
On Tue, 11 Jul 2023 10:57:57 +0200 Daniel Vetter wrote: > On Fri, Jul 07, 2023 at 07:40:59PM -0300, André Almeida wrote: > > From: Pekka Paalanen > > > > Specify how the atomic state is maintained between userspace and > > kernel, plus the special case for async flips. > > > > Signed-off-by: P

Re: [PATCH 1/4] drm/mediatek: mtk_dpi: Simplify with devm_drm_bridge_add()

2023-07-13 Thread Fei Shao
Hi Angelo, On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno wrote: > > Change drm_bridge_add() to its devm variant to slightly simplify the > probe function. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 5 +++-- > 1 file changed, 3 inse

Re: [PATCH 2/4] drm/mediatek: mtk_dpi: Simplify with dev_err_probe()

2023-07-13 Thread Fei Shao
On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno wrote: > > Use dev_err_probe() across the entire probe function of this driver > to shrink the size. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Fei Shao

Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Jocelyn Falempe
On 13/07/2023 09:00, Jammy Huang wrote: Hi Jocelyn, Thanks for your work. On 2023/7/13 下午 02:40, Jocelyn Falempe wrote: Aspeed always report the display port as "connected", because it doesn't set a .detect_ctx callback. Fix this by providing the proper detect callback for astdp and dp501. Th

[PULL] drm-misc-fixes

2023-07-13 Thread Maxime Ripard
Hi, Sending again because I had to send it by hand and forgot to add all the recipients in Cc. Here's this week drm-misc-fixes PR, plus last week as well that got dropped for some reason. Thanks! Maxime The following changes since commit 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5: Linux 6.5-rc

Re: [PATCH 1/4] drm/doc: use cross-references for macros

2023-07-13 Thread Pekka Paalanen
On Wed, 12 Jul 2023 13:57:26 + Simon Ser wrote: > These will show up as monospace, and will get linkified as soon as > we document the macro they point to. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel Vetter > --- > Documentation/gpu/drm-uapi.rst | 8 > 1 file

Re: [PATCH 2/4] drm/doc: document interactions between PAGE_FLIP_EVENT and atomic

2023-07-13 Thread Pekka Paalanen
On Wed, 12 Jul 2023 13:57:28 + Simon Ser wrote: > Explain which CRTCs get an event, and uAPI requirements. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel Vetter > --- > include/uapi/drm/drm_mode.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/

Re: [RFC PATCH 3/4] drm/doc: document PAGE_FLIP_EVENT | PAGE_FLIP_ASYNC

2023-07-13 Thread Pekka Paalanen
On Wed, 12 Jul 2023 13:57:32 + Simon Ser wrote: > Explain what the event looks like when both flags are specified. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel Vetter > Cc: Ville Syrjälä > Cc: Lyude Paul > Cc: Christian König > --- > > Driver developers: please confi

Re: [PATCH 4/4] drm/doc: document front-buffer rendering

2023-07-13 Thread Pekka Paalanen
On Wed, 12 Jul 2023 13:57:34 + Simon Ser wrote: > Explain how to perform front-buffer rendering. > > Signed-off-by: Simon Ser > Cc: Pekka Paalanen > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_blend.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/drm_blen

Re: [PATCH 3/4] drm/mediatek: mtk_dpi: Switch to devm_drm_of_get_bridge()

2023-07-13 Thread Fei Shao
Hi Angelo, On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno wrote: > > Function drm_of_find_panel_or_bridge() is marked as deprecated: since > the usage of that in this driver exactly corresponds to the new function > devm_drm_of_get_bridge(), switch to it. > > Signed-off-by: AngeloGioa

[PATCH 17/17] drm/vblank_crtc: Rename struct drm_vblank_crtc::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_vblank.c | 4 ++-- drivers/gpu/drm/drm_vblank_work.c | 18 +---

[PATCH 12/17] drm/master: Rename struct drm_master::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_auth.c | 4 ++-- drivers/gpu/drm/drm_lease.c | 32

[PATCH 06/17] drm/debugfs_entry: Rename struct drm_debugfs_entry::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- drivers/gpu/drm/drm_atomic.c | 2 +- dr

[PATCH 03/17] drm/client_dev: Rename struct drm_client_dev::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/armada/armada_fbdev.c | 4 ++-- drivers/gpu/drm/drm_client.c |

[PATCH 16/17] drm/property: Rename struct drm_property::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_atomic_uapi.c | 5 +++-- drivers/gpu/drm/drm_mode_object.c

[PATCH 02/17] drm/bridge: Rename struct drm_bridge::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/bridge/analogix/anal

[PATCH 15/17] drm/property_blob: Rename struct drm_property_blob::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_property.c | 8 include/drm/drm_property.h | 4 ++-- 2 files ch

[PATCH 10/17] drm/framebuffer: Rename struct drm_framebuffer::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 16 +++ .../arm/display/komeda/komeda_frameb

[PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello, after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev to drm_dev"[1] was positive in principle, here comes a new series. I didn't call it v2 as it is different enough to stand on its own. The motivation is that "dev" (at least in my bubble) usually is a struct device *,

[PATCH 11/17] drm/gem_object: Rename struct drm_gem_object::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/accel/ivpu/ivpu_gem.c | 2 +- drivers/accel/ivpu/ivpu_gem.h

[PATCH 09/17] drm/fb_helper: Rename struct drm_fb_helper::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/drm_fb_helper.c|

[PATCH 01/17] drm/atomic_state: Rename struct drm_atomic_state::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 58 +- .../amd/display/amdgpu_dm

[PATCH 13/17] drm/minor: Rename struct drm_minor::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- drivers/accel/drm_accel.c | 16 +++--- drivers/accel/ivpu/ivpu_debug

[PATCH 07/17] drm/dp_mst_topology_mgr: Rename struct drm_dp_mst_topology_mgr::dev to drm

2023-07-13 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Replace it by "drm" and adapt all users. Signed-off-by: Uwe Kleine-König --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/display/drm_dp_mst_topol

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Michel Dänzer
On 7/12/23 17:25, Jocelyn Falempe wrote: > On 12/07/2023 17:05, Sui Jingfeng wrote: >> On 2023/7/10 16:07, Jocelyn Falempe wrote: >> >>> On the other hand, are there any drawback to present a BMC connector even >>> when the hardware doesn't have it ? >> >> If not properly setting up, I think you w

Re: [PATCH 4/4] drm/mediatek: mtk_dpi: Use devm_platform_get_and_ioremap_resource()

2023-07-13 Thread Fei Shao
Hi Angelo, On Wed, Apr 12, 2023 at 7:53 PM AngeloGioacchino Del Regno wrote: > > Instead of the open-coded platform_get_resource, devm_ioremap_resource > switch to devm_platform_get_and_ioremap_resource(), doing exactly the > same. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > driver

Re: [PATCH v2 8/8] arm64: dts: qcom: sm8450: provide MDSS cfg interconnect

2023-07-13 Thread Konrad Dybcio
On 12.07.2023 14:11, Dmitry Baryshkov wrote: > Add support for the MDSS cfg-cpu bus vote on the SM8450 platform. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 10:32 schrieb Michel Dänzer: On 7/12/23 17:25, Jocelyn Falempe wrote: On 12/07/2023 17:05, Sui Jingfeng wrote: On 2023/7/10 16:07, Jocelyn Falempe wrote: On the other hand, are there any drawback to present a BMC connector even when the hardware doesn't have it ? If not

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Thomas Zimmermann
Hi Am 12.07.23 um 17:05 schrieb Sui Jingfeng: Hi, I'm here join to the discussion. Because I know a little about aspeed BMC. On 2023/7/10 16:07, Jocelyn Falempe wrote: On 07/07/2023 09:30, Thomas Zimmermann wrote: Hi Am 06.07.23 um 18:37 schrieb Jocelyn Falempe: [...] You could out-comm

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Jocelyn Falempe
On 13/07/2023 10:32, Michel Dänzer wrote: On 7/12/23 17:25, Jocelyn Falempe wrote: On 12/07/2023 17:05, Sui Jingfeng wrote: On 2023/7/10 16:07, Jocelyn Falempe wrote: On the other hand, are there any drawback to present a BMC connector even when the hardware doesn't have it ? If not proper

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Michel Dänzer
On 7/13/23 10:49, Thomas Zimmermann wrote: > Am 13.07.23 um 10:32 schrieb Michel Dänzer: >> On 7/12/23 17:25, Jocelyn Falempe wrote: >>> On 12/07/2023 17:05, Sui Jingfeng wrote: On 2023/7/10 16:07, Jocelyn Falempe wrote: > On the other hand, are there any drawback to present a BMC con

Re: [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-13 Thread Liviu Dudau
Hello, On Thu, Jul 13, 2023 at 10:05:56AM +0800, Gaosheng Cui wrote: > The komeda_pipeline_get_state() returns an ERR_PTR() on failure, we should > use IS_ERR() to check the return value. While reviewing the change I've realised that komeda_pipeline_get_state_and_set_crtc() is also mishandling t

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Michel Dänzer
On 7/13/23 10:53, Jocelyn Falempe wrote: > On 13/07/2023 10:32, Michel Dänzer wrote: >> On 7/12/23 17:25, Jocelyn Falempe wrote: >>> On 12/07/2023 17:05, Sui Jingfeng wrote: On 2023/7/10 16:07, Jocelyn Falempe wrote: > On the other hand, are there any drawback to present a BMC connect

[PATCH] drm/ssd130x: Change pixel format used to compute the buffer size

2023-07-13 Thread Javier Martinez Canillas
The commit e254b584dbc0 ("drm/ssd130x: Remove hardcoded bits-per-pixel in ssd130x_buf_alloc()") used a pixel format info instead of a hardcoded bpp to calculate the size of the buffer allocated to store the native pixels. But that wrongly used the DRM_FORMAT_C1 fourcc pixel format, which is for co

Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Jocelyn Falempe
On 13/07/2023 10:17, Jocelyn Falempe wrote: On 13/07/2023 09:00, Jammy Huang wrote: Hi Jocelyn, Thanks for your work. On 2023/7/13 下午 02:40, Jocelyn Falempe wrote: Aspeed always report the display port as "connected", because it doesn't set a .detect_ctx callback. Fix this by providing the pr

[PATCH v5 02/10] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer()

2023-07-13 Thread AngeloGioacchino Del Regno
Change logging from drm_{err,info}() to dev_{err,info}() in functions mtk_dp_aux_transfer() and mtk_dp_aux_do_transfer(): this will be essential to avoid getting NULL pointer kernel panics if any kind of error happens during AUX transfers happening before the bridge is attached. This may potential

[PATCH v5 01/10] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-13 Thread AngeloGioacchino Del Regno
Everytime we run bridge detection and/or EDID read we run a poweron and poweroff sequence for both the AUX and the panel; moreover, this is also done when enabling the bridge in the .atomic_enable() callback. Move this power on/off sequence to a new mtk_dp_aux_panel_poweron() function as to common

[PATCH v5 00/10] MediaTek DisplayPort: support eDP and aux-bus

2023-07-13 Thread AngeloGioacchino Del Regno
Changes in v5: - Added .wait_hpd_asserted() callback for aux-bus - Avoid enabling and registering HPD interrupt + handlers for eDP case only (keeps HPD interrupts enabled for full DP case) - Support not always-on eDP panels (boot with regulator off, suspend with regulator off) for power sa

[PATCH v5 04/10] drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings()

2023-07-13 Thread AngeloGioacchino Del Regno
Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply mode to function mtk_dp_initialize_aux_settings(), as this is effectively part of the DPTX AUX setup sequence. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/mediatek/mtk_dp.c | 9 +---

[PATCH v5 06/10] drm/mediatek: dp: Avoid mutex locks if audio is not supported/enabled

2023-07-13 Thread AngeloGioacchino Del Regno
If a controller (usually, eDP!) does not support audio, or audio is not enabled because the endpoint has no audio support, it's useless to lock a mutex only to unlock it right after because there's no .plugged_cb(). Check if the audio is supported and enabled before locking the mutex in mtk_dp_upd

[PATCH v5 10/10] drm/mediatek: dp: Don't register HPD interrupt handler for eDP case

2023-07-13 Thread AngeloGioacchino Del Regno
The interrupt handler for HPD is useful only if a display is actually supposed to be hotpluggable, as that manages the machinery to perform cable (un)plug detection, debouncing and setup for re-training. Since eDP panels are not supposed to be hotpluggable we can avoid using the HPD interrupts alt

[PATCH v5 07/10] drm/mediatek: dp: Move PHY registration to new function

2023-07-13 Thread AngeloGioacchino Del Regno
In preparation for adding support for eDP, move the PHY registration code to a new mtk_dp_register_phy() function for better readability. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dp.c | 43 +++--

[PATCH v5 05/10] drm/mediatek: dp: Enable event interrupt only when bridge attached

2023-07-13 Thread AngeloGioacchino Del Regno
It is useless and error-prone to enable the DisplayPort event interrupt before finishing to probe and install the driver, as the DP training cannot happen before the entire pipeline is correctly set up, as the interrupt handler also requires the full hardware to be initialized by mtk_dp_bridge_atta

[PATCH v5 08/10] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-07-13 Thread AngeloGioacchino Del Regno
For the eDP case we can support using aux-bus on MediaTek DP: this gives us the possibility to declare our panel as generic "panel-edp" which will automatically configure the timings and available modes via the EDID that we read from it. To do this, move the panel parsing at the end of the probe f

[PATCH v5 09/10] drm/mediatek: dp: Add .wait_hpd_asserted() for AUX bus

2023-07-13 Thread AngeloGioacchino Del Regno
In order to support usecases in which the panel regulator can be switched on and off to save power, and usecases in which the panel regulator is off at boot, add a .wait_hpd_asserted() callback for the AUX bus: this will make sure to wait until the panel is fully ready after power-on before trying

[PATCH v5 03/10] drm/mediatek: dp: Use devm variant of drm_bridge_add()

2023-07-13 Thread AngeloGioacchino Del Regno
In preparation for adding support for aux-bus, which will add a code path that may fail after the drm_bridge_add() call, change that to devm_drm_bridge_add() to simplify failure paths later. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/mediatek/mtk_dp.c

Re: [PATCH v2 8/8] arm64: dts: qcom: sm8450: provide MDSS cfg interconnect

2023-07-13 Thread Dmitry Baryshkov
On Thu, 13 Jul 2023 at 11:41, Konrad Dybcio wrote: > > On 12.07.2023 14:11, Dmitry Baryshkov wrote: > > Add support for the MDSS cfg-cpu bus vote on the SM8450 platform. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 9 +++-- > > 1 file changed, 7

Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Jammy Huang
Hi Jocelyn, On 2023/7/13 下午 04:17, Jocelyn Falempe wrote: On 13/07/2023 09:00, Jammy Huang wrote: Hi Jocelyn, Thanks for your work. On 2023/7/13 下午 02:40, Jocelyn Falempe wrote: Aspeed always report the display port as "connected", because it doesn't set a .detect_ctx callback. Fix this by p

[PATCH v2 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

2023-07-13 Thread Alexandre Mergnat
The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. Reviewed-by: Conor Dooley Signed-off-by: Alexandre Mergnat --- .../display/panel/startek,kd070fhfid015.yaml | 69 ++ 1 file changed, 69 insertions(+) diff --git a/Documentat

[PATCH v2 0/3] Add startek-kd070fhfid015 display support

2023-07-13 Thread Alexandre Mergnat
Add the support of the Startek KD070FHFID015 panel. It's a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. This serie come from a bigger one [1]. Then I addressed the previous comments for the related commits here. [1]: https://lore.kernel.org/all/20230220-display-v1-0-45cbc68e1..

[PATCH v2 3/3] arm64: defconfig: enable STARTEK KD070FHFID015 panel

2023-07-13 Thread Alexandre Mergnat
Build Startek KD070FHFID015 panel driver. This MIPI-DSI display can be used for the mt8365-evk board for example. Signed-off-by: Alexandre Mergnat --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig inde

[PATCH v2 2/3] drm/panel: Support for startek-kd070fhfid015 MIPI-DSI panel

2023-07-13 Thread amergnat
From: Guillaume La Roque This driver support the Startek KD070FHFID015, which is a 7-inch TFT LCD display using MIPI DSI interface. Signed-off-by: Guillaume La Roque Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile

[PULL] drm-misc-next

2023-07-13 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the main pull request for drm-misc-next for what will become Linux v6.6. Some noteworthy changes are: * GEM got execution contexts that help with locking multiple GEM objects at once. * All DRM drivers can now self-import their own dma-bufs by default. This en

Re: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
Reviewed-by: Karol Herbst On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/bus

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 10:53 schrieb Michel Dänzer: On 7/13/23 10:49, Thomas Zimmermann wrote: Am 13.07.23 um 10:32 schrieb Michel Dänzer: On 7/12/23 17:25, Jocelyn Falempe wrote: On 12/07/2023 17:05, Sui Jingfeng wrote: On 2023/7/10 16:07, Jocelyn Falempe wrote: On the other hand, are there an

Re: [PATCH] drm/nouveau/pci: ERROR: "foo * bar" should be "foo *bar"

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/gk104.c

Re: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by:Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++- > 1 file change

Re: [PATCH] drm/nouveau/i2c: do not use assignment in if condition

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 9:23 AM wrote: > > Assignments in if condition are less readable and error-prone. Fixes > also checkpatch warning: > > ERROR: do not use assignment in if condition > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/nouveau/nvkm/subdev/i2c/aux.c | 3 ++- > 1 file change

Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 11:05 schrieb Jammy Huang: [...] For the BMC connector patch, you know if there is a register setting I can check to see if a BMC is present or not ? I think you can use VGA CRD0[7] whose definition is as below: DRAM Initial Selection (see note 1) 0: VBIOS Initial the DRA

Re: [PATCH] drm/nouveau/iccsense:

2023-07-13 Thread Karol Herbst
On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote: > > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote: > > Fixed error: 'do not use assignment in if condition' > > > > This patch fixes error: 'do not use assignment in if condition' > > in drm/nouveau/iccsense > > I guess t

Re: [PATCH] drm/nouveau/iccsense:

2023-07-13 Thread Karol Herbst
On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst wrote: > > On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya wrote: > > > > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran...@208suo.com wrote: > > > Fixed error: 'do not use assignment in if condition' > > > > > > This patch fixes error: 'do not use a

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Jani Nikula
On Thu, 13 Jul 2023, Uwe Kleine-König wrote: > Hello, > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > to drm_dev"[1] was positive in principle, here comes a new series. I find it obnoxious to send a new series within 24 hours of the first, while the discussion is st

Re: [PATCH v5 2/2] drm/ast: report connection status on Display Port.

2023-07-13 Thread Jocelyn Falempe
On 13/07/2023 11:12, Thomas Zimmermann wrote: Hi Am 13.07.23 um 11:05 schrieb Jammy Huang: [...] For the BMC connector patch, you know if there is a register setting I can check to see if a BMC is present or not ? I think you can use VGA CRD0[7] whose definition is as below: DRAM Initial

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-13 Thread Michel Dänzer
On 7/13/23 11:09, Thomas Zimmermann wrote: > Am 13.07.23 um 10:53 schrieb Michel Dänzer: >> On 7/13/23 10:49, Thomas Zimmermann wrote: >>> Am 13.07.23 um 10:32 schrieb Michel Dänzer: On 7/12/23 17:25, Jocelyn Falempe wrote: > On 12/07/2023 17:05, Sui Jingfeng wrote: >> On 2023/7/10 16:

Re: [PATCH RFC 2/2] drm: add documentation for drm_buddy_test kUnit test

2023-07-13 Thread Arunpravin Paneer Selvam
Looks good, Feel free to add Reviewed-by: Arunpravin Paneer Selvam Regards, Arun. On 7/13/2023 12:09 PM, Christian König wrote: [Adding Arun] Am 12.07.23 um 16:28 schrieb Mauro Carvalho Chehab: As an example for the new documentation tool, add a documentation for drm_buddy_test. I opted to

Re: [PATCH v2 3/3] drm/komeda: Fix IS_ERR() vs NULL check in komeda_component_get_avail_scaler()

2023-07-13 Thread cuigaosheng
Thanks for taking time to review this patch. Maybe we can submit another separate patch to fix ERR_CAST(st), because I'm not sure which commit should be used as a fixes-tag. Also, Maybe we should fix ERR_CAST(st) in komeda_pipeline_get_state_and_set_crtc() and komeda_component_get_state_and_set

Re: [PATCH v5 00/10] MediaTek DisplayPort: support eDP and aux-bus

2023-07-13 Thread Chen-Yu Tsai
On Thu, Jul 13, 2023 at 5:01 PM AngeloGioacchino Del Regno wrote: > > Changes in v5: > - Added .wait_hpd_asserted() callback for aux-bus > - Avoid enabling and registering HPD interrupt + handlers for >eDP case only (keeps HPD interrupts enabled for full DP case) > - Support not always-on e

Re: [PATCH] drm/ssd130x: Change pixel format used to compute the buffer size

2023-07-13 Thread Geert Uytterhoeven
On Thu, Jul 13, 2023 at 10:59 AM Javier Martinez Canillas wrote: > The commit e254b584dbc0 ("drm/ssd130x: Remove hardcoded bits-per-pixel in > ssd130x_buf_alloc()") used a pixel format info instead of a hardcoded bpp > to calculate the size of the buffer allocated to store the native pixels. > > B

Re: [PATCH v5 00/10] MediaTek DisplayPort: support eDP and aux-bus

2023-07-13 Thread AngeloGioacchino Del Regno
Il 13/07/23 11:54, Chen-Yu Tsai ha scritto: On Thu, Jul 13, 2023 at 5:01 PM AngeloGioacchino Del Regno wrote: Changes in v5: - Added .wait_hpd_asserted() callback for aux-bus - Avoid enabling and registering HPD interrupt + handlers for eDP case only (keeps HPD interrupts enabled for f

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-13 Thread Frieder Schrempf
Hi Tim, On 13.07.23 09:18, Frieder Schrempf wrote: > Hi Tim, > > On 13.07.23 00:34, Tim Harvey wrote: >> On Wed, May 3, 2023 at 9:33 AM Frieder Schrempf wrote: >>> >>> From: Frieder Schrempf >>> >>> According to the documentation [1] the proper enable flow is: >>> >>> 1. Enable DSI link and kee

Re: [PATCH v5 00/10] MediaTek DisplayPort: support eDP and aux-bus

2023-07-13 Thread Chen-Yu Tsai
On Thu, Jul 13, 2023 at 5:57 PM AngeloGioacchino Del Regno wrote: > > Il 13/07/23 11:54, Chen-Yu Tsai ha scritto: > > On Thu, Jul 13, 2023 at 5:01 PM AngeloGioacchino Del Regno > > wrote: > >> > >> Changes in v5: > >> - Added .wait_hpd_asserted() callback for aux-bus > >> - Avoid enabling and

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Thomas Zimmermann
Hi Am 13.07.23 um 10:23 schrieb Uwe Kleine-König: Hello, after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev to drm_dev"[1] was positive in principle, here comes a new series. I didn't call it v2 as it is different enough to stand on its own. To me, it didn't seel as if t

[PATCH 0/2] eventfd: simplify signal helpers

2023-07-13 Thread Christian Brauner
Hey everyone, This simplifies the eventfd_signal() and eventfd_signal_mask() helpers by removing the count argument which is effectively unused. --- --- base-commit: 6be357f00aad4189130147fdc6f568cf776a4909 change-id: 20230713-vfs-eventfd-signal-0b0d167ad6ec

[PATCH 2/2] eventfd: simplify eventfd_signal_mask()

2023-07-13 Thread Christian Brauner
The eventfd_signal_mask() helper was introduced for io_uring and similar to eventfd_signal() it always passed 1 for @n. So don't bother with that argument at all. Signed-off-by: Christian Brauner --- drivers/gpu/drm/i915/gvt/interrupt.c | 2 +- fs/eventfd.c | 9 +

[PATCH 1/2] eventfd: simplify eventfd_signal()

2023-07-13 Thread Christian Brauner
Ever since the evenfd type was introduced back in 2007 in commit e1ad7468c77d ("signal/timer/event: eventfd core") the eventfd_signal() function only ever passed 1 as a value for @n. There's no point in keeping that additional argument. Signed-off-by: Christian Brauner --- arch/x86/kvm/hyperv.c

Re: [PATCH] drm/ssd130x: Change pixel format used to compute the buffer size

2023-07-13 Thread Thomas Zimmermann
Am 13.07.23 um 10:58 schrieb Javier Martinez Canillas: The commit e254b584dbc0 ("drm/ssd130x: Remove hardcoded bits-per-pixel in ssd130x_buf_alloc()") used a pixel format info instead of a hardcoded bpp to calculate the size of the buffer allocated to store the native pixels. But that wrongly

Re: [PATCH 00/17] drm: rename various struct members "dev" -> "drm"

2023-07-13 Thread Uwe Kleine-König
Hello, On Thu, Jul 13, 2023 at 12:04:26PM +0200, Thomas Zimmermann wrote: > Am 13.07.23 um 10:23 schrieb Uwe Kleine-König: > > after most feedback for my series "drm/crtc: Rename struct drm_crtc::dev > > to drm_dev"[1] was positive in principle, here comes a new series. I > > didn't call it v2 as

[PATCH 00/19] DSC misc fixes

2023-07-13 Thread Ankit Nautiyal
This series is an attempt to address multiple issues with DSC, scattered in separate existing series. Patches 1-3 are DSC fixes from series to Handle BPC for HDMI2.1 PCON https://patchwork.freedesktop.org/series/107550/ Patches 4-5 are from series DSC fixes for Bigjoiner: https://patchwork.freede

[PATCH 01/19] drm/i915/dp: Consider output_format while computing dsc bpp

2023-07-13 Thread Ankit Nautiyal
While using DSC the compressed bpp is computed assuming RGB output format. Consider the output_format and compute the compressed bpp during mode valid and compute config steps. For DP-MST we currently use RGB output format only, so continue using RGB while computing compressed bpp for MST case. v

[PATCH 02/19] drm/i915/dp: Move compressed bpp check with 420 format inside the helper

2023-07-13 Thread Ankit Nautiyal
Move the check for limiting compressed bite_per_pixel for 420,422 formats in the helper to compute bits_per_pixel. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 03/19] drm/i915/dp_mst: Use output_format to get the final link bpp

2023-07-13 Thread Ankit Nautiyal
The final link bpp used to calculate the m_n values depend on the output_format. Though the output_format is set to RGB for MST case and the link bpp will be same as the pipe bpp, for the sake of semantics, lets calculate the m_n values with the link bpp, instead of pipe_bpp. Signed-off-by: Ankit

[PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-07-13 Thread Ankit Nautiyal
In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Ville) v4: Fix check for display ver. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- dri

[PATCH 04/19] drm/i915/dp: Use consistent name for link bpp and compressed bpp

2023-07-13 Thread Ankit Nautiyal
Currently there are many places where we use output_bpp for link bpp and compressed bpp. Lets use consistent naming: output_bpp : The intermediate value taking into account the output_format chroma subsampling. compressed_bpp : target bpp for the DSC encoder. link_bpp : final bpp used in the link.

[PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

2023-07-13 Thread Ankit Nautiyal
Currently we assume 2 Pixels Per Clock (PPC) while computing plane cdclk and min_cdlck. In cases where DSC single engine is used the throughput is 1 PPC. So account for the above case, while computing cdclk. v2: Use helper to get the adjusted pixel rate. Signed-off-by: Ankit Nautiyal --- drive

  1   2   3   4   >