[PATCH] drm/nouveau: remove spaces after '*'

2023-07-12 Thread sunran001
Fix four occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b/drivers/gpu/drm/nouveau

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-12 Thread Pekka Paalanen
On Tue, 11 Jul 2023 15:42:28 -0700 Abhinav Kumar wrote: > On 7/11/2023 3:19 PM, Dmitry Baryshkov wrote: > > On 12/07/2023 01:07, Jessica Zhang wrote: > >> > >> > >> On 7/10/2023 1:11 PM, Dmitry Baryshkov wrote: > >>> On 10/07/2023 22:51, Jessica Zhang wrote: > > > On 6/30/202

Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

2023-07-12 Thread Alexandre Mergnat
Hi Krzysztof, Thanks for your review On 12/07/2023 07:32, Krzysztof Kozlowski wrote: On 11/07/2023 17:36, Alexandre Mergnat wrote: The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution snip + + dcdc-gpios: true From where does this come? Which schema defines it? It'

Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support

2023-07-12 Thread Krzysztof Kozlowski
On 12/07/2023 10:01, Alexandre Mergnat wrote: > Hi Krzysztof, > > Thanks for your review > > On 12/07/2023 07:32, Krzysztof Kozlowski wrote: >> On 11/07/2023 17:36, Alexandre Mergnat wrote: >>> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution > > snip > >>> + >>> + dcdc-

Re: Consider switching to WQ_UNBOUND messages (was: Re: [PATCH v2 6/7] workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism)

2023-07-12 Thread Peter Zijlstra
On Tue, Jul 11, 2023 at 11:39:17AM -1000, Tejun Heo wrote: > I wonder whether the right thing to do here is somehow scaling the threshold > according to the relative processing power. It's difficult to come up with a > threshold which works well across the latest & fastest and really tiny CPUs. >

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Christian König
Am 11.07.23 um 23:34 schrieb André Almeida: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Verry big NAK to this. The problem is that memory

[PATCH v3 1/2] drm/ast: Add BMC virtual connector

2023-07-12 Thread Jocelyn Falempe
Most aspeed devices have a BMC, which allows to remotely see the screen. Also in the common use case, those servers don't have a display connected. So add a Virtual connector, to reflect that even if no display is connected, the framebuffer can still be seen remotely. This prepares the work to impl

[PATCH v3 2/2] drm/ast: report connection status on Display Port.

2023-07-12 Thread Jocelyn Falempe
Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the following regression: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP") The d

Re: [PATCH 2/6] drm/amdgpu: Mark contexts guilty for causing soft recoveries

2023-07-12 Thread Christian König
Am 11.07.23 um 23:34 schrieb André Almeida: If a DRM fence is set to -ENODATA, that means that this context was a cause of a soft reset, but is never marked as guilty. Flag it as guilty and log to user that this context won't accept more submissions. Signed-off-by: André Almeida --- driver

[PATCH 1/7] vgacon: switch vgacon_scrolldelta() and vgacon_restore_screen()

2023-07-12 Thread Jiri Slaby (SUSE)
Switch vgacon_scrolldelta() and vgacon_restore_screen() positions, so that the former is not needed to be forward-declared. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/console/vgacon.c | 12 ++--

[PATCH 2/7] vgacon: remove unneeded forward declarations

2023-07-12 Thread Jiri Slaby (SUSE)
Most of the forward declarations in vgacon are not needed. Drop them. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/console/vgacon.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --

[PATCH 4/7] vgacon: let vgacon_doresize() return void

2023-07-12 Thread Jiri Slaby (SUSE)
The return value is neither used, nor vgacon_doresize() returns an error. So change the reurn type to void. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/console/vgacon.c | 3 +-- 1 file changed, 1 inserti

[PATCH 3/7] vgacon: remove unused xpos from vgacon_set_cursor_size()

2023-07-12 Thread Jiri Slaby (SUSE)
xpos is unused, remove it. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/console/vgacon.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/video/conso

[PATCH 6/7] sticon: make sticon_set_def_font() void and remove op parameter

2023-07-12 Thread Jiri Slaby (SUSE)
sticon_set_def_font() always returns 0, so make it void. And remove an unused 'op' parameter. Signed-off-by: Jiri Slaby (SUSE) Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-par...@vger.kernel.org Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/cons

[PATCH 5/7] vgacon: cache vc_cell_height in vgacon_cursor()

2023-07-12 Thread Jiri Slaby (SUSE)
There are many places c->vc_cell_height is used in the code of vgacon_cursor(). Caching the value to a local variable makes the code much easier to follow. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/con

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Lucas Stach
Am Mittwoch, dem 12.07.2023 um 10:37 +0200 schrieb Christian König: > Am 11.07.23 um 23:34 schrieb André Almeida: > > Instead of storing coredump information inside amdgpu_device struct, > > move if to a proper separated struct and allocate it dynamically. This > > will make it easier to further ex

[PATCH 7/7] fbcon: remove unused display (p) from fbcon_redraw()

2023-07-12 Thread Jiri Slaby (SUSE)
The parameter is unused. Signed-off-by: Jiri Slaby (SUSE) Cc: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org --- drivers/video/fbdev/core/fbcon.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/c

Re: [PATCH] drm/virtio: remove some redundant code

2023-07-12 Thread Dan Carpenter
On Wed, Jul 12, 2023 at 09:18:42AM +0800, Su Hui wrote: > On 2023/7/11 19:13, Dan Carpenter wrote: > > On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote: > > > virtio_gpu_get_vbuf always be successful, > > > so remove the error judgment. > > > > > No, just ignore the static checker false posi

Re: Consider switching to WQ_UNBOUND messages (was: Re: [PATCH v2 6/7] workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism)

2023-07-12 Thread Geert Uytterhoeven
Hoi Peter, On Wed, Jul 12, 2023 at 10:05 AM Peter Zijlstra wrote: > On Tue, Jul 11, 2023 at 11:39:17AM -1000, Tejun Heo wrote: > > I wonder whether the right thing to do here is somehow scaling the threshold > > according to the relative processing power. It's difficult to come up with a > > thre

Re: [Intel-gfx] [PATCH v4] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-12 Thread Tvrtko Ursulin
On 11/07/2023 23:02, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 drive

[PATCH RFC v1 05/52] drm/arm: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- .../gpu/drm/arm/display/komeda/komeda_crtc.c | 24 +-- .../gpu/drm/arm/display/komed

[PATCH RFC v1 04/52] drm/armada: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/armada/armada_crtc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH RFC v1 07/52] drm/ast: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/ast/ast_dp.c | 2 +- drivers/gpu/drm/ast/ast_mode.c | 26 +

[PATCH RFC v1 11/52] drm/gma500: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +

[PATCH RFC v1 12/52] drm/gud: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/gud/gud_pipe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

[PATCH RFC v1 14/52] drm/hyperv: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH RFC v1 16/52] drm/imx: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/imx/dcss/dcss-crtc.c | 20 ++-- drivers/gpu/drm/imx/ipuv3/ipuv3-crt

[PATCH RFC v1 21/52] drm/mediatek: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 22 +++--- 1 file changed, 11 insertions(+)

[PATCH RFC v1 33/52] drm/rockchip: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8 drivers/gpu/drm/rockchip/rockchip_drm_vop

[PATCH RFC v1 25/52] drm/mxsfb: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/mxsfb/lcdif_kms.c | 18 +- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 16 +++

[PATCH RFC v1 50/52] drm/xen: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH RFC v1 18/52] drm/kmb: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/kmb/kmb_crtc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH RFC v1 10/52] drm/fsl-dcu: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 16 1 file changed, 8 insertions(+), 8

[PATCH RFC v1 01/52] drm/crtc: Start renaming struct drm_crtc::dev to drm_dev

2023-07-12 Thread Uwe Kleine-König
"dev" is usually used for struct device pointers. Using it for struct drm_device pointers is irritating (for me at least). Introduce a "drm_dev" as an alias with the intention to remove "dev" once all drivers are adapted. Signed-off-by: Uwe Kleine-König --- include/drm/drm_crtc.h | 12 ++

[PATCH RFC v1 17/52] drm/ingenic: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH RFC v1 27/52] drm/omapdrm: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/omapdrm/omap_crtc.c | 56 ++--- drivers/gpu/drm/omapdrm/omap_

[PATCH RFC v1 28/52] drm/panel-ili9341: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-

[PATCH RFC v1 39/52] drm/tegra: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tegra/dc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH RFC v1 23/52] drm/mgag200: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/mgag200/mgag200_g200.c | 4 ++-- drivers/gpu/drm/mgag200/mgag200_g200eh.c | 2 +-

[PATCH RFC v1 45/52] drm/vboxvideo: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) di

[PATCH RFC v1 19/52] drm/logicvc: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/logicvc/logicvc_crtc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deleti

[PATCH RFC v1 44/52] drm/udl: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/udl/udl_modeset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH RFC v1 36/52] drm/sti: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/sti/sti_crtc.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[PATCH RFC v1 40/52] drm/tidss: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tidss/tidss_crtc.c | 19 ++- drivers/gpu/drm/tidss/tidss_irq.c | 4

[PATCH RFC v1 34/52] drm/solomon: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/solomon/ssd130x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH RFC v1 20/52] drm/mcde: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/mcde/mcde_display.c | 18 +- 1 file changed, 9 insertions(+), 9 delet

[PATCH RFC v1 22/52] drm/meson: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/meson/meson_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH RFC v1 02/52] drm/core: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_atomic.c | 22 ++--- drivers/gpu/drm/drm_atomic_helper.c

[PATCH RFC v1 29/52] drm/pl111: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/pl111/pl111_display.c | 16 1 file changed, 8 insertions(+), 8 delet

[PATCH RFC v1 43/52] drm/tve200: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tve200/tve200_display.c | 14 +++--- 1 file changed, 7 insertions(+), 7 delet

[PATCH RFC v1 41/52] drm/tilcdc: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 43 ++-- 1 file changed, 22 insertions

[PATCH RFC v1 32/52] drm/renesas: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- .../gpu/drm/renesas/rcar-du/rcar_du_crtc.c| 14 ++--- .../gpu/drm/renesas/shmobile/shmob_

[PATCH RFC v1 46/52] drm/vc4: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/vc4/vc4_crtc.c | 38 +- drivers/gpu/drm/vc4/vc4_hdmi.

[PATCH RFC v1 35/52] drm/sprd: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/sprd/sprd_dpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH RFC v1 49/52] drm/vmwgfx: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 10 +-

[PATCH RFC v1 09/52] drm/exynos: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 8 drivers/gpu/drm/exynos/exynos_drm_plane.c | 4

[PATCH RFC v1 37/52] drm/stm: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/stm/ltdc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH RFC v1 08/52] drm/atmel-hlcdc: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 10 +- 1 file changed, 5 insertions(+), 5 de

[PATCH RFC v1 48/52] drm/vkms: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/vkms/vkms_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH RFC v1 38/52] drm/sun4i: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH RFC v1 06/52] drm/aspeed: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/aspeed/aspeed_gfx_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH RFC v1 47/52] drm/virtio: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/virtio/virtgpu_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH RFC v1 26/52] drm/nouveau: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 58 +++-- drivers/gpu/drm/nouveau/dispn

[PATCH RFC v1 30/52] drm/qxl: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/qxl/qxl_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH RFC v1 31/52] drm/radeon: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/radeon/atombios_crtc.c | 54 ++--- drivers/gpu/drm/radeon/radeon

[PATCH RFC v1 52/52] drm/crtc: Complete renaming struct drm_crtc::dev to drm_dev

2023-07-12 Thread Uwe Kleine-König
Now that all drivers use the new and better name, the old one can be dropped. Signed-off-by: Uwe Kleine-König --- include/drm/drm_crtc.h | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 66b65108024e..33a6e90f8d19

[PATCH RFC v1 51/52] drm/xlnx: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH RFC v1 13/52] drm/hisilicon: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- .../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c| 20 +-- .../gpu/drm/hisilicon/kirin/k

[PATCH RFC v1 03/52] drm/amd: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 18 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_km

[PATCH RFC v1 24/52] drm/msm: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 6 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

[PATCH RFC v1 42/52] drm/tiny: Use struct drm_crtc::drm_dev instead of struct drm_crtc::dev

2023-07-12 Thread Uwe Kleine-König
Prepare dropping the alias "dev" for struct drm_crtc::drm_dev. "drm_dev" is the better name as "dev" is usually a struct device pointer. No semantic changes. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/tiny/bochs.c | 6 +++--- drivers/gpu/drm/tiny/cirrus.c | 2 +- drive

Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver

2023-07-12 Thread Bruno Prémont
On Mon, 10 Jul 2023 14:50:14 +0200 Thomas Zimmermann wrote: > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do > not set it. > > Flags should signal differences from the default values. After cleaning > up all oc

Re: Consider switching to WQ_UNBOUND messages (was: Re: [PATCH v2 6/7] workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism)

2023-07-12 Thread Geert Uytterhoeven
Hi Tejun, On Wed, Jul 12, 2023 at 2:30 AM Tejun Heo wrote: > On Tue, Jul 11, 2023 at 11:39:17AM -1000, Tejun Heo wrote: > > On Tue, Jul 11, 2023 at 04:06:22PM +0200, Geert Uytterhoeven wrote: > > > On Tue, Jul 11, 2023 at 3:55 PM Geert Uytterhoeven > > > wrote: > ... > > > workqueue: neigh_mana

[Bug 217664] New: Laptop doesnt wake up from suspend mode.

2023-07-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 Bug ID: 217664 Summary: Laptop doesnt wake up from suspend mode. Product: Drivers Version: 2.5 Hardware: All OS: Linux Status: NEW Severity: normal

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-07-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #1 from popus_czy_to_ty (pentelja...@o2.pl) --- second card. somehow didnt add it, cant edit. 01:00.0 VGA compatible controller: NVIDIA Corporation GA107M [GeForce RTX 3050 Mobile] (rev a1) (prog-if 00 [VGA controller]) Subsys

Re: [Intel-gfx] [PATCH] drm/i915/huc: check HuC and GuC version compatibility on MTL

2023-07-12 Thread Andrzej Hajda
On 11.07.2023 22:31, Daniele Ceraolo Spurio wrote: Due to a change in the auth flow on MTL, GuC 70.7.0 and newer will only be able to authenticate HuC 8.5.1 and newer. The plan is to update the 2 binaries sinchronously in linux-firmware so that the fw repo always has a matching pair that works; s

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-07-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #2 from popus_czy_to_ty (pentelja...@o2.pl) --- second card. somehow didnt add it, cant edit. 01:00.0 VGA compatible controller: NVIDIA Corporation GA107M [GeForce RTX 3050 Mobile] (rev a1) (prog-if 00 [VGA controller]) Subsys

Re: [PATCH] drm/virtio: remove some redundant code

2023-07-12 Thread Su Hui
On 2023/7/12 14:36, Dan Carpenter wrote: On Wed, Jul 12, 2023 at 09:18:42AM +0800, Su Hui wrote: On 2023/7/11 19:13, Dan Carpenter wrote: On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote: virtio_gpu_get_vbuf always be successful, so remove the error judgment. No, just ignore the stati

Re: [PATCH v3 2/2] drm/ast: report connection status on Display Port.

2023-07-12 Thread Thomas Zimmermann
Hi Am 12.07.23 um 10:35 schrieb Jocelyn Falempe: Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the following regression: Since commit fae7d186403e ("drm/probe

Re: [PATCH v2 5/5] drm/ssd130x: Remove hardcoded bits-per-pixel in ssd130x_buf_alloc()

2023-07-12 Thread Geert Uytterhoeven
Hi Javier, Thanks for your patch! On Fri, Jun 9, 2023 at 7:09 PM Javier Martinez Canillas wrote: > The driver only supports OLED controllers that have a native DRM_FORMAT_C1 DRM_FORMAT_R1 (colormap is fixed to white-on-black). > pixel format and that is why it has harcoded a division of the wi

Re: (subset) [PATCH v3 0/4] Qualcomm REFGEN regulator

2023-07-12 Thread Mark Brown
On Mon, 03 Jul 2023 20:15:53 +0200, Konrad Dybcio wrote: > Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator > responsible for providing a reference voltage to some on-SoC IPs (like DSI > or PHYs). It can be turned off when unused to save power. > > This series introduces

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Christian König
Am 12.07.23 um 10:59 schrieb Lucas Stach: Am Mittwoch, dem 12.07.2023 um 10:37 +0200 schrieb Christian König: Am 11.07.23 um 23:34 schrieb André Almeida: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This w

Re: [PATCH v3 1/2] drm/ast: Add BMC virtual connector

2023-07-12 Thread Thomas Zimmermann
Hi, thanks for this patch. Am 12.07.23 um 10:35 schrieb Jocelyn Falempe: Most aspeed devices have a BMC, which allows to remotely see the screen. Also in the common use case, those servers don't have a display connected. So add a Virtual connector, to reflect that even if no display is connecte

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Lucas Stach
Am Mittwoch, dem 12.07.2023 um 12:39 +0200 schrieb Christian König: > Am 12.07.23 um 10:59 schrieb Lucas Stach: > > Am Mittwoch, dem 12.07.2023 um 10:37 +0200 schrieb Christian König: > > > Am 11.07.23 um 23:34 schrieb André Almeida: > > > > Instead of storing coredump information inside amdgpu_dev

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Lucas Stach
Sorry, accidentally hit sent on the previous mail. Am Mittwoch, dem 12.07.2023 um 12:39 +0200 schrieb Christian König: > Am 12.07.23 um 10:59 schrieb Lucas Stach: > > Am Mittwoch, dem 12.07.2023 um 10:37 +0200 schrieb Christian König: > > > Am 11.07.23 um 23:34 schrieb André Almeida: > > > > Inste

Re: [PATCH 3/6] drm/amdgpu: Rework coredump to use memory dynamically

2023-07-12 Thread Christian König
Am 12.07.23 um 12:56 schrieb Lucas Stach: Sorry, accidentally hit sent on the previous mail. Am Mittwoch, dem 12.07.2023 um 12:39 +0200 schrieb Christian König: Am 12.07.23 um 10:59 schrieb Lucas Stach: Am Mittwoch, dem 12.07.2023 um 10:37 +0200 schrieb Christian König: Am 11.07.23 um 23:34 s

[RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This series contains a proposal for a DRM cgroup controller which implements a weight based hierarchical GPU usage budget based controller similar in concept to some of the existing controllers and also exposes GPU memory usage as a read- only field. Motivation mostly comes

[PATCH 01/17] drm/i915: Add ability for tracking buffer objects per client

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In order to show per client memory usage lets add some infrastructure which enables tracking buffer objects owned by clients. We add a per client list protected by a new per client lock and to support delayed destruction (post client exit) we make tracked objects hold refere

[PATCH 04/17] drm/i915: Account ring buffer and context state storage

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_context.c | 14 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 +++

[PATCH 03/17] drm/i915: Track page table backing store usage

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt

[PATCH 05/17] drm/i915: Implement fdinfo memory stats printing

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

[PATCH 06/17] drm: Update file owner during use

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the typical model where the display server opens the file descriptor and then hands it over to the client(*), we were showing stale data in debugfs. Fix it by updating the drm_file->pid on ioctl access from a different process. The field is also made RCU protected to a

[PATCH 02/17] drm/i915: Record which client owns a VM

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11

[PATCH 07/17] cgroup: Add the DRM cgroup controller

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Skeleton controller without any functionality. Signed-off-by: Tvrtko Ursulin --- include/linux/cgroup_drm.h| 9 ++ include/linux/cgroup_subsys.h | 4 +++ init/Kconfig | 7 kernel/cgroup/Makefile| 1 + kernel/cgroup/drm.c

[PATCH 08/17] drm/cgroup: Track DRM clients per cgroup

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To enable propagation of settings from the cgroup DRM controller to DRM and vice-versa, we need to start tracking to which cgroups DRM clients belong. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 6 include/drm/drm_file.h | 6 include/linu

[PATCH 09/17] drm/cgroup: Add ability to query drm cgroup GPU time

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a driver callback and core helper which allow querying the time spent on GPUs for processes belonging to a group. Signed-off-by: Tvrtko Ursulin --- include/drm/drm_drv.h | 28 kernel/cgroup/drm.c | 20 2 files changed

[PATCH 11/17] drm/cgroup: Only track clients which are providing drm_cgroup_ops

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To reduce the number of tracking going on, especially with drivers which will not support any sort of control from the drm cgroup controller side, lets express the funcionality as opt-in and use the presence of drm_cgroup_ops as activation criteria. Signed-off-by: Tvrtko Urs

[PATCH 13/17] drm/i915: Wire up with drm controller GPU time query

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Implement the drm_cgroup_ops->active_time_us callback. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_driver.c | 8 ++ drivers/gpu/drm/i915/i915_drm_client.c | 116 ++--- drivers/gpu/drm/i915/i915_drm_client.h | 2 + 3 files changed

[PATCH 10/17] drm/cgroup: Add over budget signalling callback

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add a new callback via which the drm cgroup controller is notifying the drm core that a certain process is above its allotted GPU time. Signed-off-by: Tvrtko Ursulin --- include/drm/drm_drv.h | 8 kernel/cgroup/drm.c | 16 2 files changed, 24 i

[PATCH 12/17] cgroup/drm: Introduce weight based drm cgroup control

2023-07-12 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to CPU scheduling, implement a concept of weight in the drm cgroup controller. Uses the same range and default as the CPU controller - CGROUP_WEIGHT_MIN, CGROUP_WEIGHT_DFL and CGROUP_WEIGHT_MAX. Later each cgroup is assigned a time budget proportionaly based on the

  1   2   3   >