Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > On 05/07/2023 19:53, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: > > > On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > > > > > > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmi

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 0

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
Daniel Thompson writes: > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> The condition for the initial power state based on the default >> brightness value is reversed. Fix it. >> >> Furthermore, use the actual state of the LEDs rather than the default >> brightness specified

[PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Mans Rullgard
The condition for the initial power state based on the default brightness value is reversed. Fix it. Furthermore, use the actual state of the LEDs rather than the default brightness specified in the devicetree as the latter should not cause the backlight to be automatically turned on. If the bac

Re: [PATCH v3 07/17] drm/imagination: Add GPU ID parsing and firmware loading

2023-07-06 Thread Marek Vasut
On 7/5/23 15:13, Frank Binns wrote: On Mon, 2023-06-26 at 10:38 -0500, Adam Ford wrote: On Mon, Jun 26, 2023 at 8:22 AM Frank Binns wrote: Hi Adam, On Sat, 2023-06-17 at 07:48 -0500, Adam Ford wrote: On Tue, Jun 13, 2023 at 10:20 AM Sarah Walker wrote: Read the GPU ID register at probe tim

[PATCH v1] gpu: i915: display: Replace define function

2023-07-06 Thread Minjie Du
Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE. Signed-off-by: Minjie Du --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 56c1

[PATCH v2] drm/i915/gt: Convert to use time_before macro

2023-07-06 Thread Zehao Zhang
Use time_before macro instead of open it for readability. Signed-off-by: Zehao Zhang --- v2: -update subject drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/g

[PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring

2023-07-06 Thread Yang Rong
The files drivers/net/virtio_net.c, drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were modified to fix warnings. Specifically, the opportunities for max() and min() were utilized to address the warnings. Signed-off-by: Yang Rong --- drivers/gpu/drm/amd/display/dc/dc_dm

Re: [PATCH] backlight: led_bl: fix initial power state

2023-07-06 Thread Måns Rullgård
Daniel Thompson writes: > On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: >> Daniel Thompson writes: >> >> > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> >> The condition for the initial power state based on the default >> >> brightness value is reversed. Fix

[PATCH] Covert to use time_before macro

2023-07-06 Thread Zehao Zhang
Use time_before macro instead of open it for readability. Signed-off-by: Zehao Zhang --- drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c b/drivers/gpu/drm/i915/gt/intel_gt_buffer_po

[PATCH v1] drivers: dcn315: remove duplicate assignments

2023-07-06 Thread Minjie Du
make clk_mgr_base->clks.zstate_support avoid double assignment. It looks like the value of new_clocks is unchanged, so there may be no need for repeated assignments. Signed-off-by: Minjie Du --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 1 - 1 file changed, 1 deletion(-)

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: > On 06/07/2023 09:24, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > > > On 05/07/2023 19:53, Maxime Ripard wrote: > > > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote:

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

2023-07-06 Thread Pekka Paalanen
On Wed, 5 Jul 2023 09:08:07 -0700 Michael Banack wrote: > On 7/4/23 01:08, Pekka Paalanen wrote: > > On Mon, 3 Jul 2023 14:06:56 -0700 > > Michael Banack wrote: > > > >> Hi, I can speak to the virtual mouse/console half of this from the > >> VMware-side. > >> > >> I believe Zack's preparing a

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:59, Maxime Ripard wrote: On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #56 from Harald Judt (h.j...@gmx.at) --- I think that the issue with VT-switching is not fixed by the commit, but by another measure, that is switching to a text console before hibernating (the script I use has an option to do this). T

Re: [PATCH v1] gpu: i915: display: Replace define function

2023-07-06 Thread Jani Nikula
On Thu, 06 Jul 2023, Minjie Du wrote: > Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE. The subject prefix should be "drm/i915/psr: ". Please try git log on the file to see what is commonly used. The subject should say what's being done. "Replace define function" is way too generi

[PULL] drm-intel-next-fixes

2023-07-06 Thread Tvrtko Ursulin
Hi Dave, Daniel, A weekly collection of fixes for the drm-next/6.5 merge window. Mostly small display fixups, one for GuC/SLPC and one header file tidy. I see last week did not get pulled so this week contains those ones plus two more fixups - one code tidy actually and one fixup. Regards, Tvr

[PATCH libdrm v2] amdgpu: Use PRI?64 to format uint64_t

2023-07-06 Thread Geert Uytterhoeven
On 32-bit: ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’: ../tests/amdgpu/amdgpu_stress.c:178:49: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Wformat=] fprintf(stdout, "Allocated B

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-06 Thread Intel
Hi, Danilo Some review comments below: On 6/30/23 00:25, Danilo Krummrich wrote: Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, al

Re: [PATCH v2, 1/2] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2023-07-06 Thread Krzysztof Kozlowski
On 06/07/2023 04:14, Shuijing Li wrote: > Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. > > Signed-off-by: Shuijing Li > Signed-off-by: Jitao Shi > --- > Changes in v2: > add a mediatek,mt8188-edp-tx compatible per suggestion from the previous > thread: > https://lore.kernel.or

Re: [PATCH] Covert to use time_before macro

2023-07-06 Thread Zehao Zhang
Correct the format of the Subject in v2: https://lore.kernel.org/all/20230706072924.2562-1-zhangze...@vivo.com/

Re: [PATCH v3 4/4] drm/panel: ili9882t: Break out function for switching page

2023-07-06 Thread cong yang
Hi, On Mon, Jul 3, 2023 at 9:22 PM Linus Walleij wrote: > > The ILI9882t has similarities with other Ilitek panels, such > as the characteristic internal page switching code that uses > the model number (0x98, 0x82) as parameter. > > We can clearly abstract out the page switching sequence from >

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Jocelyn Falempe
On 04/07/2023 18:45, Jocelyn Falempe wrote: On 04/07/2023 16:54, Jani Nikula wrote: On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no   EDID on DP") The default resolution is now 640x480 when no monitor is connected. But Aspeed g

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

2023-07-06 Thread Amit Pundir
On Wed, 5 Jul 2023 at 11:09, Dmitry Baryshkov wrote: > > [Adding freedreno@ to cc list] > > On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: > > > > Hi Amit, > > > > On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: > > > > > > Hi Marek, > > > > > > On Wed, 5 Jul 2023 at 01:48, Marek Vasut wrote

[PATCH] drm/imx/lcdc: Fix double-free of driver data

2023-07-06 Thread Uwe Kleine-König
The struct imx_lcdc driver data is allocated using devm_drm_dev_alloc() so it must not be explicitly kfree()d. Also drm_kms_helper_poll_fini() should not be called as there is no matching drm_kms_helper_poll_init(). So drop the release function completely. Fixes: c87e859cdeb5 ("drm/imx/lcdc: Impl

[drm-rerere] nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Jani Nikula
We used to have the sound branches be part of drm-tip to help development of DP and HDMI audio. However, we always used to run into problems with the sound branches merging Linus' master at non-tagged random commits, wreaking havoc especially during the merge windows. We only ever want to have tagg

[Bug 217636] Commit edcfed8671 disables previously supported video resolutions (on AMD Rembrandt)

2023-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217636 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Bisected commit-id||aa9704d5127f06c9ffedb0

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Jani Nikula
On Thu, 06 Jul 2023, Jocelyn Falempe wrote: > On 04/07/2023 18:45, Jocelyn Falempe wrote: >> On 04/07/2023 16:54, Jani Nikula wrote: >>> On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no   EDID on DP") The default res

[PATCH v2] drm/ast: report connection status on Display Port.

2023-07-06 Thread Jocelyn Falempe
Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the following regression: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP") The

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Jocelyn Falempe
On 06/07/2023 11:32, Jani Nikula wrote: On Thu, 06 Jul 2023, Jocelyn Falempe wrote: On 04/07/2023 18:45, Jocelyn Falempe wrote: On 04/07/2023 16:54, Jani Nikula wrote: On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no   EDID

Re: [PATCH v2, 1/2] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2023-07-06 Thread AngeloGioacchino Del Regno
Il 06/07/23 04:14, Shuijing Li ha scritto: Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. Signed-off-by: Shuijing Li Signed-off-by: Jitao Shi Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Jani Nikula
On Thu, 06 Jul 2023, Jocelyn Falempe wrote: > Yes, so maybe a better way would be to add a remote/bmc connector, with > proper default resolution ? > That will better reflect what the hardware does. I'm afraid I don't know enough about the hardware or use case to say. BR, Jani. -- Jani Nikul

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Thomas Zimmermann
Hi Am 06.07.23 um 11:16 schrieb Jocelyn Falempe: On 04/07/2023 18:45, Jocelyn Falempe wrote: On 04/07/2023 16:54, Jani Nikula wrote: On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no   EDID on DP") The default resolution is now

Re: [PATCH v2,2/2] drm/mediatek: dp: Add the audio control to mtk_dp_data struct

2023-07-06 Thread AngeloGioacchino Del Regno
Il 06/07/23 04:14, Shuijing Li ha scritto: Mainly add the following two flag: 1.The audio packet arrangement function is to only arrange audio packets into the Hblanking area. In order to align with the HW default setting of g1200, this function needs to be turned off. 2.Due to the difference o

[PATCH v2 2/4] fbdev/sm712fb: Do not include

2023-07-06 Thread Thomas Zimmermann
Sm712fb's dependency on is artificial in that it only uses struct screen_info for its internals. Replace the use of struct screen_info with a custom data structure and remove the include of . Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Cc: Sudip Mukherjee Cc: Teddy W

[PATCH v2 4/4] staging/sm750fb: Do not include

2023-07-06 Thread Thomas Zimmermann
The sm750fb driver does not need anything from . Remove the include statements. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Cc: Sudip Mukherjee Cc: Teddy Wang --- drivers/staging/sm750fb/sm750.c| 1 - drivers/staging/sm750fb/sm750_accel.c | 1 - drivers/sta

[PATCH v2 0/4] Remove unnecessary includes of

2023-07-06 Thread Thomas Zimmermann
(was: arch,fbdev: Move screen_info into arch/) Remove include statements of The patches have been reviewed as part of the patchset at [1]. Patch 1 has a fix to make it build on loongarch. v2: * update loongarch [1] https://patchwork.freedesktop.org/series/120010/#rev1 Thomas Zimmerman

[PATCH v2 1/4] efi: Do not include from EFI header

2023-07-06 Thread Thomas Zimmermann
The header file does not need anything from . Declare struct screen_info and remove the include statements. Update a number of source files that require struct screen_info's definition. v2: * update loongarch (Jingfeng) Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canil

[PATCH v2 3/4] sysfb: Do not include from sysfb header

2023-07-06 Thread Thomas Zimmermann
The header file does not need anything from . Declare struct screen_info and remove the include statements. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Reviewed-by: Sui Jingfeng Cc: Ard Biesheuvel Cc: Hans de Goede Cc: Javier Martinez Canillas --- include/linux/s

Re: [PATCH] drm/i915: Remove some dead "code"

2023-07-06 Thread Tvrtko Ursulin
On 05/07/2023 13:08, Jani Nikula wrote: On Wed, 05 Jul 2023, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 2caffbf11762 ("drm/i915: Revoke mmaps and prevent access to fence registers across reset") removed the temporary implementation of a reset under stop machine but forgot to remove t

[PULL] drm-misc-next-fixes

2023-07-06 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2023-07-06: Short summary of fixes pull: * panel: Fix mode on Starry-ili9882t The following changes since commit 861c249cd782cb9f2d5a881bbb32e8da7f0c1192: arch/sparc: Add module license

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

2023-07-06 Thread Jocelyn Falempe
On 06/07/2023 12:26, Thomas Zimmermann wrote: Hi Am 06.07.23 um 11:16 schrieb Jocelyn Falempe: On 04/07/2023 18:45, Jocelyn Falempe wrote: On 04/07/2023 16:54, Jani Nikula wrote: On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if

Re: [PATCH v2 2/4] fbdev/sm712fb: Do not include

2023-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2023, at 12:42, Thomas Zimmermann wrote: > Sm712fb's dependency on is artificial in that > it only uses struct screen_info for its internals. Replace the use of > struct screen_info with a custom data structure and remove the include > of . > > Signed-off-by: Thomas Zimmermann > Re

Re: [PATCH v2 1/4] efi: Do not include from EFI header

2023-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2023, at 12:42, Thomas Zimmermann wrote: > The header file does not need anything from > . Declare struct screen_info and remove > the include statements. Update a number of source files that > require struct screen_info's definition. > > v2: > * update loongarch (Jingfeng) >

Re: [PATCH v2 3/4] sysfb: Do not include from sysfb header

2023-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2023, at 12:42, Thomas Zimmermann wrote: > The header file does not need anything from > . Declare struct screen_info and remove > the include statements. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Javier Martinez Canillas > Reviewed-by: Sui Jingfeng > Cc: Ard Biesheuvel

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Matthias Brugger
On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Alexandre Mergnat
On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Reviewed-by: Alexandre Mergnat -- Regards, Alexandre

[PATCH v4 1/9] drm/mediatek: dp: Cache EDID for eDP panel

2023-07-06 Thread AngeloGioacchino Del Regno
Since eDP panels are not removable it is safe to cache the EDID: this will avoid a relatively long read transaction at every PM resume that is unnecessary only in the "special" case of eDP, hence speeding it up a little, as from now on, as resume operation, we will perform only link training. Sign

[PATCH v4 0/9] MediaTek DisplayPort: support eDP and aux-bus

2023-07-06 Thread AngeloGioacchino Del Regno
X7625) on some other SoCs (MT8192 and others) - Rebased over next-20230706 - Dropped Chen-Yu's T-b tag on last patch as some logic changed (before, I wasn't using the .done_probing() callback). Changes in v3: - Added DPTX AUX block initialization before trying to communicate

[PATCH v4 3/9] drm/mediatek: dp: Always return connected status for eDP in .detect()

2023-07-06 Thread AngeloGioacchino Del Regno
If this is an eDP panel it's not removable, hence it's always connected: as a shortcut, always return connector_status_connected in the .detect() callback for eDP connector, avoiding a poweron, a check for sink count and a poweroff. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Ts

[PATCH v4 5/9] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer()

2023-07-06 Thread AngeloGioacchino Del Regno
Change logging from drm_{err,info}() to dev_{err,info}() in functions mtk_dp_aux_transfer() and mtk_dp_aux_do_transfer(): this will be essential to avoid getting NULL pointer kernel panics if any kind of error happens during AUX transfers happening before the bridge is attached. This may potential

[PATCH v4 8/9] drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings()

2023-07-06 Thread AngeloGioacchino Del Regno
Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply mode to function mtk_dp_initialize_aux_settings(), as this is effectively part of the DPTX AUX setup sequence. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/mediatek/mtk_dp.c | 9 +---

[PATCH v4 4/9] drm/mediatek: dp: Always set cable_plugged_in at resume for eDP panel

2023-07-06 Thread AngeloGioacchino Del Regno
eDP panels are not removable: at PM resume, the cable will obviously still be plugged in. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/mediatek/mtk_dp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/

[PATCH v4 6/9] drm/mediatek: dp: Enable event interrupt only when bridge attached

2023-07-06 Thread AngeloGioacchino Del Regno
In preparation for implementing support for aux-bus in this driver, add a IRQ_NOAUTOEN flag to the event interrupt that we request at probe time and manage the enablement of the ISR at bridge_attach and detach time. When aux-bus will be implemented, enabling the interrupt before attaching the brid

[PATCH v4 7/9] drm/mediatek: dp: Use devm variant of drm_bridge_add()

2023-07-06 Thread AngeloGioacchino Del Regno
In preparation for adding support for aux-bus, which will add a code path that may fail after the drm_bridge_add() call, change that to devm_drm_bridge_add() to simplify failure paths later. Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai --- drivers/gpu/drm/mediatek/mtk_dp.c

[PATCH v4 2/9] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-06 Thread AngeloGioacchino Del Regno
Everytime we run bridge detection and/or EDID read we run a poweron and poweroff sequence for both the AUX and the panel; moreover, this is also done when enabling the bridge in the .atomic_enable() callback. Move this power on/off sequence to a new mtk_dp_aux_panel_poweron() function as to common

[PATCH v4 9/9] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-07-06 Thread AngeloGioacchino Del Regno
For the eDP case we can support using aux-bus on MediaTek DP: this gives us the possibility to declare our panel as generic "panel-edp" which will automatically configure the timings and available modes via the EDID that we read from it. To do this, move the panel parsing at the end of the probe f

[PATCH v2] dma-buf: fix an error pointer vs NULL bug

2023-07-06 Thread Dan Carpenter
Smatch detected potential error pointer dereference. drivers/gpu/drm/drm_syncobj.c:888 drm_syncobj_transfer_to_timeline() error: 'fence' dereferencing possible ERR_PTR() The error pointer comes from dma_fence_allocate_private_stub(). One caller expected error pointers and one expected NU

Re: [PATCH] dma-buf: fix an error pointer vs NULL bug

2023-07-06 Thread Dan Carpenter
On Thu, Jul 06, 2023 at 08:21:35AM +0200, Christian König wrote: > Am 06.07.23 um 07:52 schrieb Dan Carpenter: > > The __dma_fence_unwrap_merge() function is supposed to return NULL on > > error. But the dma_fence_allocate_private_stub() returns error pointers > > so check for that and covert the

Re: [PATCH 04/10] drm/tegra: Set fbdev flags

2023-07-06 Thread Thomas Zimmermann
Hi Am 05.07.23 um 11:34 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: [...] + info->flags |= FBINFO_VIRTFB; I see that all fbdev drivers just do: info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB Guess you are doing in two assignments to be consistent with drm_fbd

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, Thanks a lot! On 2023/7/6 19:39, Matthias Brugger wrote: On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng ---   drivers/gpu/drm/mediatek/mtk_drm_gem.c | 6

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, thanks a lot! On 2023/7/6 20:13, Alexandre Mergnat wrote: On 26/06/2023 20:58, Sui Jingfeng wrote: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Reviewed-by: Alexandre Mergnat

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread AngeloGioacchino Del Regno
Il 26/06/23 20:58, Sui Jingfeng ha scritto: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng This commit needs a Fixes tag. Please add the relevant one and resend. Thanks, Angelo --- drivers/gpu/dr

[PATCH v2 00/11] drm: Improve fbdev emulation for DMA-able framebuffers

2023-07-06 Thread Thomas Zimmermann
Add fbdev helpers for framebuffers in DMA-able memory and update fbdev emulation in the respective DRM drivers. DMA memory used to handled as system memory. Improve this and prepare for possible future changes. Patch 1 adds initializer macros for struct fb_ops and a Kconfig token for framebuffers

[PATCH v2 01/11] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory

2023-07-06 Thread Thomas Zimmermann
Add initializer macros for struct fb_ops for framebuffers in DMA-able memory areas. Also add a corresponding Kconfig token. As of now, this is equivalent to system framebuffers and mostly useful for labeling drivers correctly. A later patch may add a generic DMA-specific mmap operation. Linux offe

[PATCH v2 02/11] drm/fbdev-dma: Use fbdev DMA helpers

2023-07-06 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev-dma. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/drm

[PATCH v2 03/11] drm/tegra: Use fbdev DMA helpers

2023-07-06 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev emulation. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/

[PATCH v2 07/11] drm/omapdrm: Set VM flags in GEM-object mmap function

2023-07-06 Thread Thomas Zimmermann
Use the mmap callback in struct drm_gem_object_funcs to set the VM flags. Replace a number of mmap helpers in omapdrm with their GEM helper counterparts. Generate DRM's file-operations instance with GEM's DEFINE_DRM_GEM_FOPS. The omapdrm driver uses DRM's drm_gem_mmap() helper to prepare the VMA s

[PATCH v2 05/11] drm/exynos: Use fbdev DMA helpers

2023-07-06 Thread Thomas Zimmermann
Use fbdev's DMA helpers for fbdev emulation. The driver previously used the I/O-memory helpers, while allocating DMA-able system memory. This could (in theory) result in bus errors from accessing the memory range. This bug has been present since the exynos driver was first added. v2: * dr

[PATCH v2 06/11] drm/exynos: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_FLAG_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Inki Dae Cc:

[PATCH v2 04/11] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Thierry Reding Cc

[PATCH v2 10/11] fbdev: Remove FB_DEFAULT_SYS_OPS

2023-07-06 Thread Thomas Zimmermann
Remove the initializer macro FB_DEFAULT_SYS_OPS and its helper macro __FB_DEFAULT_SYS_OPS_MMAP. There are no users. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Helge Deller (maintainer:FRAMEBUFFER LAYER) --- include/linux/fb.h | 8 ---

[PATCH v2 08/11] drm/omapdrm: Use GEM mmap for fbdev emulation

2023-07-06 Thread Thomas Zimmermann
The fbdev emulation currently uses fbdev's default mmap code, which has been written for I/O memory. Provide an mmap that uses GEM's mmap infrastructure. Utilize fine-grained fbdev macros to initialize struct fb_ops. The macros set the read/write and the draw callbacks for DMA memory. Set the fb_m

[PATCH v2 11/11] fbdev: Harmonize some comments in

2023-07-06 Thread Thomas Zimmermann
Make the comments for I/O, system and DMA memory say the same. Makes the header file's structure more obvious. Signed-off-by: Thomas Zimmermann Suggested-by: Javier Martinez Canillas --- include/linux/fb.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/include

[PATCH v2 09/11] drm/omapdrm: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thomas Zimmermann
Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_DEFAULT Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Acked-by: Maxime Ripard Cc: Tomi Valkeinen --

Re: [PATCH v2] dma-buf: fix an error pointer vs NULL bug

2023-07-06 Thread Christian König
Am 06.07.23 um 14:37 schrieb Dan Carpenter: Smatch detected potential error pointer dereference. drivers/gpu/drm/drm_syncobj.c:888 drm_syncobj_transfer_to_timeline() error: 'fence' dereferencing possible ERR_PTR() The error pointer comes from dma_fence_allocate_private_stub(). One ca

Re: [PATCH v2] drm/ast: report connection status on Display Port.

2023-07-06 Thread Linux regression tracking (Thorsten Leemhuis)
On 06.07.23 11:58, Jocelyn Falempe wrote: > Aspeed always report the display port as "connected", because it > doesn't set a .detect callback. > Fix this by providing the proper detect callback for astdp and dp501. > > This also fixes the following regression: > Since commit fae7d186403e ("drm/pro

Re: [PATCH v2 11/11] fbdev: Harmonize some comments in

2023-07-06 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, > Make the comments for I/O, system and DMA memory say the same. > Makes the header file's structure more obvious. > > Signed-off-by: Thomas Zimmermann > Suggested-by: Javier Martinez Canillas > --- Looks good to me. Thanks! Reviewed-by: Javier Martine

[PATCH v2] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread Sui Jingfeng
Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Fixes: 3df64d7b0a4f ("drm/mediatek: Implement gem prime vmap/vunmap function") Reviewed-by: Matthias Brugger Reviewed-by: Alexandre Mergnat Signed-off-by: Sui Jingfeng --- drivers/gp

Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail

2023-07-06 Thread suijingfeng
Hi, On 2023/7/6 20:47, AngeloGioacchino Del Regno wrote: Il 26/06/23 20:58, Sui Jingfeng ha scritto: Also return -ENOMEM if such a failure happens, the implement should take responsibility for the error handling. Signed-off-by: Sui Jingfeng This commit needs a Fixes tag. Please add the rele

Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring

2023-07-06 Thread Alex Deucher
On Thu, Jul 6, 2023 at 3:37 AM Yang Rong wrote: > > The files drivers/net/virtio_net.c, > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were > modified to fix warnings. > Specifically, the opportunities for max() and min() were utilized to address > the warnings. Please

Re: [drm-rerere] nightly.conf: drop sound tree from drm-tip altogether

2023-07-06 Thread Alex Deucher
On Thu, Jul 6, 2023 at 5:29 AM Jani Nikula wrote: > > We used to have the sound branches be part of drm-tip to help > development of DP and HDMI audio. However, we always used to run into > problems with the sound branches merging Linus' master at non-tagged > random commits, wreaking havoc especi

Re: [PATCH] Fix max/min warnings in virtio_net, amd/display, and io_uring

2023-07-06 Thread Michael S. Tsirkin
On Thu, Jul 06, 2023 at 10:06:16AM +0800, Yang Rong wrote: > The files drivers/net/virtio_net.c, > drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c, and io_uring/io_uring.c were > modified to fix warnings. what warnings? the point of the warning is to analyze it not "fix" it blindly. > Specifically

Re: [PATCH v2] dma-buf: fix an error pointer vs NULL bug

2023-07-06 Thread Sumit Semwal
On Thu, 6 Jul 2023 at 18:24, Christian König wrote: > > Am 06.07.23 um 14:37 schrieb Dan Carpenter: > > Smatch detected potential error pointer dereference. > > > > drivers/gpu/drm/drm_syncobj.c:888 drm_syncobj_transfer_to_timeline() > > error: 'fence' dereferencing possible ERR_PTR() >

Re: [PATCH v2 04/11] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thierry Reding
On Thu, Jul 06, 2023 at 02:46:42PM +0200, Thomas Zimmermann wrote: > Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is > in DMA-able memory and should be accessed with the CPU's regular > memory ops. > > v2: > * drop FBINFO_DEFAULT > > Signed-off-by: Thomas Zimmermann > Rev

Re: [PATCH v2 04/11] drm/tegra: Set fbdev FBINFO_VIRTFB flag

2023-07-06 Thread Thomas Zimmermann
Hi Am 06.07.23 um 16:31 schrieb Thierry Reding: On Thu, Jul 06, 2023 at 02:46:42PM +0200, Thomas Zimmermann wrote: Mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. v2: * drop FBINFO_DEFAULT S

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #57 from Alex Deucher (alexdeuc...@gmail.com) --- Does this patch help? https://gitlab.freedesktop.org/drm/amd/uploads/64dc2a05039b583e89da17309969fa50/0001-client-register-fix-plus-fbdev-debug-noise-2.patch It's pretty noisy. The me

[Bug 216119] 087451f372bf76d breaks hibernation on amdgpu Radeon R9 390

2023-07-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216119 --- Comment #58 from Alex Deucher (alexdeuc...@gmail.com) --- Nevermind, sorry, wrong bug. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-07-06 Thread Danilo Krummrich
Hi Boris, On 6/30/23 10:02, Boris Brezillon wrote: Hi Danilo, On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: + * int driver_gpuva_remap(struct drm_gpuva_op *op, void *__ctx) + * { + * struct driver_context *ctx = __ctx; + * + * drm_gpuva_remap(ctx-

[PATCH 00/10] fbdev: Generate deferred-I/O helpers

2023-07-06 Thread Thomas Zimmermann
Generate the I/O callbacks for drivers with deferred I/O. As in the old, opencoded functions, the generated functions operate on system memory and trigger damage handling if necessary. Also bring the drivers' Kconfig options up to date. Generating and initializing via helpers macros will later all

[PATCH 04/10] fbdev/hecubafb: Generate deferred I/O ops

2023-07-06 Thread Thomas Zimmermann
Use the existing generator macros to create deferred-I/O helpers for hecubafb and set them in the fb_ops structure. Functions for damage handling on memory ranges and areas are provided by the driver. Hecubafb's implementation of fb_write writes to system memory, so the generated code can use the

[PATCH 02/10] fbdev/broadsheetfb: Generate deferred I/O ops

2023-07-06 Thread Thomas Zimmermann
Use the existing generator macros to create deferred-I/O helpers for broadsheetfb and set them in the fb_ops structure. Functions for damage handling on memory ranges and areas are provided by the driver. Broadsheedfb's implementation of fb_write writes to system memory, so the generated code can

[PATCH 05/10] fbdev/metronomefb: Select FB_SYS_HELPERS_DEFERRED

2023-07-06 Thread Thomas Zimmermann
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_METRONOME in favor of the existing identical selection. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/Kconfig | 6 +- 1 file changed, 1 i

[PATCH 08/10] fbdev/ssd1307fb: Generate deferred I/O ops

2023-07-06 Thread Thomas Zimmermann
Use the existing generator macros to create deferred-I/O helpers for ssd1307fb and set them in the fb_ops structure. Functions for damage handling on memory ranges and areas are provided by the driver. Ssd1307fb's implementation of fb_write writes to system memory, so the generated code can use th

[PATCH 07/10] fbdev/ssd1307fb: Select FB_SYS_HELPERS_DEFERRED

2023-07-06 Thread Thomas Zimmermann
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_SSD1307 in favor of the existing identical selection. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/Kconfig | 6 +- 1 file changed, 1 ins

[PATCH 03/10] fbdev/hecubafb: Select FB_SYS_HELPERS_DEFERRED

2023-07-06 Thread Thomas Zimmermann
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_HECUBA. Deferred I/O helpers were previously selected by n411, which builds upon hecubafb. Remove these select statements in favor of the new one. N411 do

[PATCH 06/10] fbdev/metronomefb: Generate deferred I/O ops

2023-07-06 Thread Thomas Zimmermann
Use the existing generator macros to create deferred-I/O helpers for metronomefb and set them in the fb_ops structure. Functions for damage handling on memory ranges and areas are provided by the driver. Metronomefb's implementation of fb_write writes to system memory, so the generated code can us

[PATCH 10/10] fbdev/xen-fbfront: Generate deferred I/O ops

2023-07-06 Thread Thomas Zimmermann
Use the existing generator macros to create deferred-I/O helpers for xen-fbfront and set them in the fb_ops structure. Functions for damage handling on memory ranges and areas are provided by the driver. Xen-fbfront's implementation of fb_write writes to system memory, so the generated code can us

[PATCH 01/10] fbdev/broadsheetfb: Select FB_SYS_HELPERS_DEFERRED

2023-07-06 Thread Thomas Zimmermann
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from FB_BROADSHEET in favor of the existing identical selection. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/Kconfig | 6 +- 1 file changed, 1

[PATCH 09/10] fbdev/xen-fbfront: Select FB_SYS_HELPERS_DEFERRED

2023-07-06 Thread Thomas Zimmermann
The Kconfig token FB_SYS_HELPERS_DEFERRED selects everything that is required for deferred I/O on system-memory framebuffers. Select it from XEN_FBDEV_FRONTEND in favor of the existing identical selection. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/Kconfig | 6 +- 1 file change

  1   2   >