Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

On 6/30/23 22:32, Marek Olšák wrote: > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > wrote: >> On 6/30/23 16:59, Alex Deucher wrote: >>> On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick >>> mailto:sebastian.w...@redhat.com>> wrote: On Tue, Jun 27, 2023 at

Re: [PATCH v6 5/9] drm/meson: gate px_clk when setting rate

On 30/06/2023 20:10, George Stark wrote: Hello Neil On 6/30/23 19:29, Neil Armstrong wrote: Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver")

Re: [PATCH] drm: bridge: samsung-dsim: Drain command transfer FIFO before transfer

On 15/06/2023 22:15, Marek Vasut wrote: Wait until the command transfer FIFO is empty before loading in the next command. The previous behavior where the code waited until command transfer FIFO was not full suffered from transfer corruption, where the last command in the FIFO could be overwritten

Re: [PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property

On Fri, 30 Jun 2023 11:26:49 +0300 Pekka Paalanen wrote: > On Thu, 29 Jun 2023 17:25:06 -0700 > Jessica Zhang wrote: > > > Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to > > determine if the plane is solid fill. In addition drop the DPU plane > > color_fill field as we

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

Thomas Zimmermann writes: Hello Thomas, Thanks for your review. > Hi > > Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas: [...] >> >> +menuconfig FB_CORE >> +tristate "Core support for frame buffer devices" > > With the text, this is visible; as others noted. > Yes, I misremembe

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

Hi Am 03.07.23 um 09:46 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Thanks for your review. Hi Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas: [...] +menuconfig FB_CORE + tristate "Core support for frame buffer devices" With the text, th

[RFC v3 0/3] Introduce KUnit tests for TTM subsystem

This series introduces KUnit[1] tests for TTM (Translation Table Manager) subsystem, a memory manager used by graphics drivers to create and manage memory buffers across different memory domains, such as system memory or VRAM. Unit tests implemented here cover two data structures: - ttm_device -

[RFC v3 1/3] drm/ttm: Introduce KUnit tests

Add the initial version of unit tests for ttm_device struct, together with helper functions. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig | 15 + drivers/gpu/drm/ttm/Makefile | 1 + drivers/gpu/drm/ttm/tests/.kunitconfig| 4 ++

[RFC v3 2/3] drm/ttm/tests: Add tests for ttm_device

Test initialization and cleanup of the ttm_device struct, including some error paths. Verify the creation of page pools if use_dma_alloc param is true. Signed-off-by: Karolina Stolarek Acked-by: Christian König --- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 159 1 file c

[RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Mak

[PATCH 1/2] accel/ivpu: Fix VPU register access in irq disable

From: Karol Wachowski Incorrect REGB_WR32() macro was used to access VPUIP register. Use correct REGV_WR32(). Fixes: 35b137630f08 ("accel/ivpu: Introduce a new DRM driver for Intel VPU") Cc: sta...@vger.kernel.org # 6.3.x Signed-off-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka --- dri

[PATCH 2/2] accel/ivpu: Clear specific interrupt status bits on C0

From: Karol Wachowski MTL C0 stepping fixed issue related to butrress interrupt status clearing, to clear an interrupt status it is required to write 1 to specific status bit field. This allows to execute read, modify and write routine. Writing 0 will not clear the interrupt and will cause inter

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

On Fri, Jun 30, 2023 at 10:29:20PM +0200, Javier Martinez Canillas wrote: > Andy Shevchenko writes: > > On Fri, Jun 30, 2023 at 07:38:01PM +0200, Javier Martinez Canillas wrote: > >> Andy Shevchenko writes: > >> > On Fri, Jun 30, 2023 at 12:51:02AM +0200, Javier Martinez Canillas wrote: > >> >> T

Re: [PATCH v4 6/6] drm/doc: Define KMS atomic state set

On Fri, 30 Jun 2023 23:09:17 -0300 André Almeida wrote: > Specify how the atomic state is maintained between userspace and > kernel, plus the special case for async flips. > > Signed-off-by: André Almeida > --- > v4: new patch > --- > Documentation/gpu/drm-uapi.rst | 19 +++ >

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

Andy Shevchenko writes: > On Fri, Jun 30, 2023 at 10:29:20PM +0200, Javier Martinez Canillas wrote: >> Andy Shevchenko writes: >> > On Fri, Jun 30, 2023 at 07:38:01PM +0200, Javier Martinez Canillas wrote: >> >> Andy Shevchenko writes: >> >> > On Fri, Jun 30, 2023 at 12:51:02AM +0200, Javier Ma

Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

Thomas Zimmermann writes: [...] config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + select FB_CORE >>> >>> This should depend on FB_CORE. >>> >> >> Yes, already fixed in v3 too. I did a select to prevent symbol circular >> dependencies bu

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

On Mon, 3 Jul 2023 09:12:29 +0200 Michel Dänzer wrote: > On 6/30/23 22:32, Marek Olšák wrote: > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer > > wrote: > >> On 6/30/23 16:59, Alex Deucher wrote: > >>> On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > >>

Re: [PATCH] drm: bridge: samsung-dsim: Drain command transfer FIFO before transfer

On 7/3/23 09:27, Neil Armstrong wrote: On 15/06/2023 22:15, Marek Vasut wrote: Wait until the command transfer FIFO is empty before loading in the next command. The previous behavior where the code waited until command transfer FIFO was not full suffered from transfer corruption, where the last

Re: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts

Hi Javier Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas: The current text were not changed since the original Linux-2.6.12-rc2 git import. Let's improve it and make that more aligned with the DRM/KMS docs. Suggested-by: Geert Uytterhoeven Signed-off-by: Javier Martinez Canillas --- (

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, 2 Jul 2023 at 19:23, Krzysztof Kozlowski wrote: > > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bindings/arm/arm,

Re: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts

Thomas Zimmermann writes: > Hi Javier > > Am 02.07.23 um 21:15 schrieb Javier Martinez Canillas: [...] >> - Kernel-level support for the Direct Rendering Infrastructure (DRI) >> - introduced in XFree86 4.0. If you say Y here, you need to select >> - the module that's right for yo

[PATCH v10 rebased on v6.4 01/25] llist: Move llist_{head, node} definition to types.h

llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH v10 rebased on v6.4 02/25] dept: Implement Dept(Dependency Tracker)

CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v10 rebased on v6.4 06/25] dept: Add proc knobs to show stats and dependency graph

It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 +++- kernel/dependency/dept_internal.h | 26 ++

[PATCH v10 rebased on v6.4 04/25] dept: Add lock dependency tracker APIs

Wrapped the base APIs for easier annotation on typical lock. Signed-off-by: Byungchul Park --- include/linux/dept_ldt.h | 77 1 file changed, 77 insertions(+) create mode 100644 include/linux/dept_ldt.h diff --git a/include/linux/dept_ldt.h b/include/li

[PATCH v10 rebased on v6.4 07/25] dept: Apply sdt_might_sleep_{start, end}() to wait_for_completion()/complete()

Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/include/linux/completion.h b/include/linux/completion.h inde

[PATCH v10 rebased on v6.4 00/25] DEPT(Dependency Tracker)

>From now on, I can work on LKML again! I'm wondering if DEPT has been helping kernel debugging well even though it's a form of patches yet. I'm happy to see that DEPT reports a real problem in practice. See: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a4856...@i-love.sakura.ne.j

[PATCH v10 rebased on v6.4 05/25] dept: Tie to Lockdep and IRQ tracing

Yes. How to place Dept in here looks so ugly. But it's inevitable as long as relying on Lockdep. The way should be enhanced gradually. 1. Basically relies on Lockdep to track typical locks and IRQ things. 2. Dept fails to recognize IRQ situation so it generates false alarms when raw_l

[PATCH v10 rebased on v6.4 03/25] dept: Add single event dependency tracker APIs

Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate (the simplest way): 1. Initaialize a map for the interesting wait. /*

[PATCH v10 rebased on v6.4 13/25] dept: Distinguish each work from another

Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH v10 rebased on v6.4 08/25] dept: Apply sdt_might_sleep_{start, end}() to PG_{locked, writeback} wait

Makes Dept able to track dependencies by PG_{locked,writeback} waits. Signed-off-by: Byungchul Park --- mm/filemap.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/mm/filemap.c b/mm/filemap.c index 83dda76d1fc3..eed64dc88e43 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -44,6

[PATCH v10 rebased on v6.4 22/25] dept: Apply timeout consideration to dma fence wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

[PATCH v10 rebased on v6.4 10/25] dept: Apply sdt_might_sleep_{start, end}() to waitqueue wait

Makes Dept able to track dependencies by waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index a0307b516b09..ff349e609da7 100644 --- a/include/linux/wait.h +++ b/include/lin

[PATCH v10 rebased on v6.4 19/25] dept: Apply timeout consideration to swait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v10 rebased on v6.4 20/25] dept: Apply timeout consideration to waitqueue wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to waitqueue wait, assuming an input 'ret' in ___wait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v10 rebased on v6.4 16/25] dept: Apply sdt_might_sleep_{start, end}() to dma fence wait

Makes Dept able to track dma fence waits. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index f177c56269bb..ad2d7a94c868 100644 --- a/drivers/dma-buf/dma-fence.c +++

[PATCH v10 rebased on v6.4 09/25] dept: Apply sdt_might_sleep_{start, end}() to swait

Makes Dept able to track dependencies by swaits. Signed-off-by: Byungchul Park --- include/linux/swait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b8c2a5..02848211cef5 100644 --- a/include/linux/swait.h +++ b/include/linux/sw

[PATCH v10 rebased on v6.4 25/25] dept: Track the potential waits of PG_{locked, writeback}

Currently, Dept only tracks the real waits of PG_{locked,writeback} that actually happened having gone through __schedule() to avoid false positives. However, it ends in limited capacity for deadlock detection, because anyway there might be still way more potential dependencies by the waits that ha

[PATCH v10 rebased on v6.4 24/25] dept: Make Dept able to work with an external wgen

There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH v10 rebased on v6.4 14/25] dept: Add a mechanism to refill the internal memory pools on running out

Dept engine works in a constrained environment. For example, Dept cannot make use of dynamic allocation e.g. kmalloc(). So Dept has been using static pools to keep memory chunks Dept uses. However, Dept would barely work once any of the pools gets run out. So implemented a mechanism for the refill

[PATCH v10 rebased on v6.4 17/25] dept: Track timeout waits separately with a new Kconfig

Waits with valid timeouts don't actually cause deadlocks. However, Dept has been reporting the cases as well because it's worth informing the circular dependency for some cases where, for example, timeout is used to avoid a deadlock but not meant to be expired. However, yes, there are also a lot o

[PATCH v10 rebased on v6.4 12/25] dept: Distinguish each syscall context from another

It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH v10 rebased on v6.4 21/25] dept: Apply timeout consideration to hashed-waitqueue wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to hashed-waitqueue wait, assuming an input 'ret' in ___wait_var_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v10 rebased on v6.4 15/25] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, fal

[PATCH v10 rebased on v6.4 11/25] dept: Apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

Makes Dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 7725b7579b78..fe89282c3e96 100644 --- a/include/linux/wait_

[PATCH v10 rebased on v6.4 18/25] dept: Apply timeout consideration to wait_for_completion()/complete()

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 4 ++-- kernel/sched/completion.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v10 rebased on v6.4 23/25] dept: Record the latest one out of consecutive waits of the same class

The current code records all the waits for later use to track relation between waits and events in each context. However, since the same class is handled the same way, it'd be okay to record only one on behalf of the others if they all have the same class. Even though it's the ideal to search the

Re: [PATCH v2 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

On 16/06/2023 10:08, Thomas Zimmermann wrote: Hi Am 15.06.23 um 19:15 schrieb Jocelyn Falempe: On 15/06/2023 16:24, Thomas Zimmermann wrote: Hi Jocelyn Am 31.05.23 um 11:21 schrieb Jocelyn Falempe: Even if the transfer is not faster, it brings significant improvement in latencies and CPU usa

Re: [PATCH 0/1] Backlight driver for the Apple Studio Display

On Sat, Jul 01, 2023 at 02:08:02PM +0200, Julius Zint wrote: > I have been using and testing this as a DKMS for 6 months now without > any known issues. It bothers me, that it needs to be part of the > initramfs instead of just working out of the box. Maybe someone else > here knows, how to tell th

Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool

Am 03.07.23 um 09:58 schrieb Karolina Stolarek: Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by:

Re: [PATCH v2 08/15] drm/msm/hdmi: move the alt_iface clock to the hpd list

On 25.06.2023 13:42, Dmitry Baryshkov wrote: > According to the vendor kernel [1] , the alt_iface clock should be > enabled together with the rest of HPD clocks, to make HPD to work > properly. > > [1] > https://git.codelinaro.org/clo/la/kernel/msm-3.18/-/commit/e07a5487e521e57f76083c0a6e2f995414

Re: [PATCH] dma-buf: keep the signaling time of merged fences v3

Am 30.06.23 um 19:19 schrieb Luben Tuikov: On 2023-06-30 08:00, Christian König wrote: [SNIP] --- Silly question perhaps: Could we not have returned an existing (signalled) fence with the wanted timestamp (when count == 0), as opposed to allocating a stub? Maybe allocation should be avoid

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

On Fri, Jun 30, 2023 at 11:27 PM Jessica Zhang wrote: > > > > On 6/30/2023 7:43 AM, Sebastian Wick wrote: > > On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >> documentation. > >> > >> This enum property will al

Re: [PATCH v2] drm/i915: Refactor PAT/cache handling

On 30/06/2023 07:55, Yang, Fei wrote: > From: Tvrtko Ursulin > > Informal commit message for now. > > I got a bit impatient and curious to see if the idea we discussed would > work so sketched something out. I think it is what I was describing back > then.. > > So high level idea is t

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, 2 Jul 2023 20:23:08 +0200 Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > For the IIO one. Acked-by: Jonathan Cameron Thanks for tidying these up. Jonathan > --- > > Rob, > > Maybe this could go via

Re: [PATCH] accel: make accel_class a static const structure

On 20/06/2023 21:25, Greg Kroah-Hartman wrote: > From: Ivan Orlov > > Now that the driver core allows for struct class to be in read-only > memory, move the accel_class structure to be declared at build time > placing it into read-only memory, instead of having to be dynamically > allocated at boo

Re: [PATCH v2 03/24] drm/gud: use vmalloc_array and vcalloc

Am 27.06.23 um 16:43 schrieb Julia Lawall: Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "

Re: [PATCH] accel: make accel_class a static const structure

On Mon, Jul 3, 2023 at 3:09 PM Tomer Tayar wrote: > > On 20/06/2023 21:25, Greg Kroah-Hartman wrote: > > From: Ivan Orlov > > > > Now that the driver core allows for struct class to be in read-only > > memory, move the accel_class structure to be declared at build time > > placing it into read-on

Re: [PATCH] habanalabs/gaudi: Add MODULE_FIRMWARE macros

On Fri, Jun 16, 2023 at 3:16 PM Juerg Haefliger wrote: > > The module loads firmware so add MODULE_FIRMWARE macros to provide that > information via modinfo. > > Signed-off-by: Juerg Haefliger > --- > drivers/accel/habanalabs/gaudi/gaudi.c | 4 > 1 file changed, 4 insertions(+) > > diff --g

[PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1344:18: error: result of comparison of constant 4294967296 with expression of type 'resource_size_t' (aka 'unsigned int') is alw

[PATCH v3 0/4] Fix up the boe-tv101wum-nl6 panel driver

This is two patches fixing things I would normally complain about in reviews, but alas I missed this one, so I go in and fix it up myself. Discovering that a completely unrelated driver has been merged into this panel driver I had to bite the bullet and break it out. I am pretty suspicious of the

[PATCH v3 2/4] drm/panel: boe-tv101wum-nl6: Drop surplus prepare tracking

The DRM panel core already keeps track of if the panel is already prepared so do not reimplement this. Reviewed-by: Sam Ravnborg Signed-off-by: Linus Walleij --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/panel

[PATCH v3 1/4] drm/panel: boe-tv101wum-nl6: Drop macros and open code sequences

The boe-tv101wum-nl6 is reinventing the mechanism to send command sequences that we usually nix during review, but I missed this one so fixing it up myself. Also use the explicit function calls to mipi_dsi_dcs_exit_sleep_mode() and mipi_dsi_dcs_set_display_on() instead of reimplementing them with

[PATCH v3 4/4] drm/panel: ili9882t: Break out function for switching page

The ILI9882t has similarities with other Ilitek panels, such as the characteristic internal page switching code that uses the model number (0x98, 0x82) as parameter. We can clearly abstract out the page switching sequence from the initialization code. Signed-off-by: Linus Walleij --- drivers/gp

[PATCH v3 3/4] drm/panel: ili9882t: Break out as separate driver

The Starry ILI9882t-based panel should never have been part of the boe tv101wum driver, it is clearly based on the Ilitek ILI9882t display controller and if you look at the custom command sequences for the panel these clearly contain the signature Ilitek page switch (0xff) commands. The hardware ha

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On 02/07/2023 20:23, Krzysztof Kozlowski wrote: The DTS code coding style expects spaces around '=' sign. Signed-off-by: Krzysztof Kozlowski --- Rob, Maybe this could go via your tree? Rebased on your for-next: v6.4-rc2-45-gf0ac35049606 --- .../bindings/arm/arm,coresight-cti.yaml|

Re: [PATCH] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

On Sun, Jul 02, 2023 at 03:05:25PM +0200, Raphaël Gallais-Pou wrote: > Hi, > > Le 02/07/2023 à 14:02, Greg Kroah-Hartman a écrit : > > On Sun, Jul 02, 2023 at 10:03:24AM +0200, Raphael Gallais-Pou wrote: > > > Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This > > > ultimate

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

Em 03/07/2023 05:49, Pekka Paalanen escreveu: On Mon, 3 Jul 2023 09:12:29 +0200 Michel Dänzer wrote: On 6/30/23 22:32, Marek Olšák wrote: On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer mailto:michel.daen...@mailbox.org>> wrote: On 6/30/23 16:59, Alex Deucher wrote: On Fri, Jun 30, 2023 a

Re: [PATCH v4 08/19] drm/msm/dpu: drop zero features from dpu_ctl_cfg data

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: Drop useless zero assignments to the dpu_ctl_cfg::features field. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [PATCH v4 09/19] drm/msm/dpu: correct indentation for CTL definitions

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: Shift dpu_ctl_cfg contents to correct the indentation of CTL blocks. This is done in preparation to expanding the rest of hardware block defines, so that all blocks have similar indentation. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bin

Re: [PATCH v4 10/19] drm/msm/dpu: inline SSPP_BLK macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- I checke

Re: [PATCH v4 11/19] drm/msm/dpu: inline DSPP_BLK macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [PATCH v4 6/6] drm/doc: Define KMS atomic state set

Em 03/07/2023 05:38, Pekka Paalanen escreveu: On Fri, 30 Jun 2023 23:09:17 -0300 André Almeida wrote: Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: André Almeida [...] If you want to take these and need

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH 24/29] mm: vmscan: make global slab shrink lockless

On Fri, Jun 23, 2023 at 04:29:39PM +1000, Dave Chinner wrote: > On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: > > On 6/22/23 10:53, Qi Zheng wrote: > > > @@ -1067,33 +1068,27 @@ static unsigned long shrink_slab(gfp_t gfp_mask, > > > int nid, > > > if (!mem_cgroup_disabled() &&

Re: [PATCH v7 2/8] PCI/VGA: Deal only with VGA class devices

Hi, On 2023/6/16 22:34, Alex Deucher wrote: On Fri, Jun 16, 2023 at 10:22 AM Sui Jingfeng wrote: On 2023/6/16 21:41, Alex Deucher wrote: On Fri, Jun 16, 2023 at 3:11 AM Sui Jingfeng wrote: Hi, On 2023/6/16 05:11, Alex Deucher wrote: On Wed, Jun 14, 2023 at 6:50 AM Sui Jingfeng wrote: H

[PATCH v3 0/4] Qualcomm REFGEN regulator

Recent Qualcomm SoCs have a REFGEN (reference voltage generator) regulator responsible for providing a reference voltage to some on-SoC IPs (like DSI or PHYs). It can be turned off when unused to save power. This series introduces the driver for it and lets the DSI driver consume it. Signed-off-b

[PATCH v3 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. It's controlled through MMIO and we can toggle it or read its state back. Describe it. Signed-off-by: Konrad Dybcio --- .../regulator/qcom,sdm845-refgen-regulator.ya

[PATCH v3 2/4] regulator: Introduce Qualcomm REFGEN regulator driver

Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. Add a driver to support toggling that regulator. Signed-off-by: Konrad Dybcio --- drivers/regulator/Kconfig | 11 +++ drivers/regulator/Makefile

[PATCH v3 3/4] dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply

DSI host needs REFGEN to be enabled (if it's present on a given platform). Allow consuming it. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devi

[PATCH v3 4/4] drm/msm/dsi: Hook up refgen regulator

Consume the refgen supply on configurations that may use it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 8a5fb6df7210..1f98ff74ceb0 100644 ---

Re: [PATCH v3 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

On 3.07.2023 20:15, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Signed-off-by: Konrad Dyb

Re: [PATCH v3 0/7] Fix ctx workarounds for non-masked regs

On Fri, Jun 30, 2023 at 05:41:21PM -0700, Kenneth Graunke wrote: On Friday, June 30, 2023 1:35:02 PM PDT Lucas De Marchi wrote: v3 of https://patchwork.freedesktop.org/series/119766/ Changes from v2: - Do not rmw if (clr | set) covers all bits - Add patch to make sure the set b

Re: [PATCH 3/9] drm/verisilicon: Add basic drm driver

Hello Keith, While compiling this driver as a module, a error happens: drivers/gpu/drm/verisilicon/vs_drm: struct of_device_id is 200 bytes.  The last of 1 is: 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00

Re: [PATCH v4 12/19] drm/msm/dpu: inline LM_BLK macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Same com

Re: [PATCH v4 13/19] drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros

On 6/27/2023 1:29 AM, Marijn Suijten wrote: On 2023-06-20 00:25:13, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten

Re: [PATCH v4] drm/vkms: Add support to 1D gamma LUT

On 02/07/23 18:37, Maira Canal wrote: > On 6/27/23 05:12, Pekka Paalanen wrote: >> On Mon, 26 Jun 2023 14:35:25 -0300 >> Maira Canal wrote: >> >>> Hi Pekka, >>> >>> On 6/26/23 05:17, Pekka Paalanen wrote: On Sat, 24 Jun 2023 18:48:08 -0300 Maira Canal wrote: > Hi Arthur,

Re: [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- the valu

Re: [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

On Mon, 3 Jul 2023 at 23:29, Abhinav Kumar wrote: > > > > On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: > > To simplify making changes to the hardware block definitions, expand > > corresponding macros. This way making all the changes are more obvious > > and visible in the source files. > > > > T

Re: [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

On 7/3/2023 1:58 PM, Dmitry Baryshkov wrote: On Mon, 3 Jul 2023 at 23:29, Abhinav Kumar wrote: On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and vis

Re: [PATCH v4 15/19] drm/msm/dpu: inline various PP_BLK_* macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [PATCH v4 16/19] drm/msm/dpu: inline WB_BLK macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [PATCH v4 17/19] drm/msm/dpu: inline INTF_BLK and INTF_BLK_DSI_TE macros

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: To simplify making changes to the hardware block definitions, expand corresponding macros. This way making all the changes are more obvious and visible in the source files. Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

Hi, I can speak to the virtual mouse/console half of this from the VMware-side. I believe Zack's preparing a new set of comments here that can speak to most of your concerns, but I'll answer some of the other questions directly. On 6/29/23 01:03, Pekka Paalanen wrote: Is it really required

Re: [PATCH v4 18/19] drm/msm/dpu: drop empty features mask MERGE_3D_SM8150_MASK

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: The MERGE_3D_SM8150_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [PATCH v4 19/19] drm/msm/dpu: drop empty features mask INTF_SDM845_MASK

On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: The INTF_SDM845_MASK features mask is zero. Drop it completely. Reviewed-by: Marijn Suijten Tested-by: Marijn Suijten Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 4 drivers/gpu/drm/msm/d

Re: [PATCH v4 2/8] drm/atomic: Add support for mouse hotspots

On 6/29/23 01:16, Pekka Paalanen wrote: On Wed, 28 Jun 2023 16:26:37 + Zack Rusin wrote: An argument could be made that crtc x/y properties should be removed on the cursor plane in drivers for para-virtualized hardware and instead replaced with mouse_position x/y properties that do exa

Re: [PATCH 1/8] drm/msm/dpu: drop enum dpu_core_perf_data_bus_id

On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: Drop the leftover of bus-client -> interconnect conversion, the enum dpu_core_perf_data_bus_id. Fixes: cb88482e2570 ("drm/msm/dpu: clean up references of DPU custom bus scaling") Signed-off-by: Dmitry Baryshkov --- It seems unused, hence Revi

Re: [PATCH 2/8] drm/msm/dpu: drop performance tuning modes

On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: DPU performance module contains code to change performance state calculations. In addition to normal (sum plane and CRTC requirements), it can work in 'minimal' or 'fixed' modes. Both modes are impractical, since they can easily end up with the dis

  1   2   >