[LINUX KERNEL PATCH v2 0/1] add S3 support for virtgpu

2023-06-30 Thread Jiqian Chen
v2: Hi all, Thanks to Marc-André Lureau, Robert Beckett and Gerd Hoffmann for their advice and guidance. V2 makes below changes: * Change VIRTIO_CPU_CMD_STATUS_FREEZING to 0x0400 (<0x1000) * Add a new feature flag VIRTIO_GPU_F_FREEZING, so that guest and host can negotiate whenever freezing is

[LINUX KERNEL PATCH v2 1/1] virtgpu: init vq during resume and notify qemu guest status

2023-06-30 Thread Jiqian Chen
This patch solves two problem: First, when we suspended guest VM, it called into Qemu to call virtio_reset->__virtio_queue_reset, this cleared all virtuqueue information of virtgpu on Qemu end. As a result, after guest resumed, guest sended ctrl/cursor requests to Qemu through virtqueue, but Qemu

Re: [LINUX KERNEL PATCH v2 0/1] add S3 support for virtgpu

2023-06-30 Thread Chen, Jiqian
Hi all, V2 patch of kernel is https://lore.kernel.org/lkml/20230630073448.842767-1-jiqian.c...@amd.com/T/#t. On 2023/6/30 15:34, Jiqian Chen wrote: > v2: > > Hi all, > > Thanks to Marc-André Lureau, Robert Beckett and Gerd Hoffmann for > their advice and guidance. V2 makes below changes: > >

Re: [PATCH 07/12] arch/x86: Declare edid_info in

2023-06-30 Thread Thomas Zimmermann
Hi Am 29.06.23 um 15:21 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 15:01, Thomas Zimmermann wrote: Am 29.06.23 um 14:35 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: The global variable edid_info contains the firmware's EDID information as an extension t

Recall: [LINUX KERNEL PATCH v2 0/1] add S3 support for virtgpu

2023-06-30 Thread Chen, Jiqian
Chen, Jiqian would like to recall the message, "[LINUX KERNEL PATCH v2 0/1] add S3 support for virtgpu".

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-06-30 Thread Boris Brezillon
Hi Danilo, On Fri, 30 Jun 2023 00:25:18 +0200 Danilo Krummrich wrote: > + * int driver_gpuva_remap(struct drm_gpuva_op *op, void *__ctx) > + * { > + * struct driver_context *ctx = __ctx; > + * > + * drm_gpuva_remap(ctx->prev_va, ctx->next_va, &op->remap); > + * > + *

Re: [PATCH] drm: bridge: samsung-dsim: Drain command transfer FIFO before transfer

2023-06-30 Thread Jagan Teki
On Fri, Jun 16, 2023 at 1:45 AM Marek Vasut wrote: > > Wait until the command transfer FIFO is empty before loading in the next > command. The previous behavior where the code waited until command transfer > FIFO was not full suffered from transfer corruption, where the last command > in the FIFO

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-06-30 Thread Boris Brezillon
On Fri, 30 Jun 2023 10:02:52 +0200 Boris Brezillon wrote: > Hi Danilo, > > On Fri, 30 Jun 2023 00:25:18 +0200 > Danilo Krummrich wrote: > > > + * int driver_gpuva_remap(struct drm_gpuva_op *op, void *__ctx) > > + * { > > + * struct driver_context *ctx = __ctx; > > + * > > + * d

Re: [PATCH RFC v4 6/7] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-06-30 Thread Pekka Paalanen
On Fri, 30 Jun 2023 03:52:37 +0300 Dmitry Baryshkov wrote: > On 30/06/2023 03:25, Jessica Zhang wrote: > > Since solid fill planes allow for a NULL framebuffer in a valid commit, > > add NULL framebuffer checks to atomic commit calls within DPU. > > > > Signed-off-by: Jessica Zhang > > --- > >

Re: [PATCH RFC v4 7/7] drm/msm/dpu: Use DRM solid_fill property

2023-06-30 Thread Pekka Paalanen
On Thu, 29 Jun 2023 17:25:06 -0700 Jessica Zhang wrote: > Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to > determine if the plane is solid fill. In addition drop the DPU plane > color_fill field as we can now use drm_plane_state.solid_fill instead, > and pass in drm_plane

Re: [PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property

2023-06-30 Thread Pekka Paalanen
On Thu, 29 Jun 2023 17:25:00 -0700 Jessica Zhang wrote: > Document and add support for solid_fill property to drm_plane. In > addition, add support for setting and getting the values for solid_fill. > > To enable solid fill planes, userspace must assign a property blob to > the "solid_fill" plan

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-30 Thread Pekka Paalanen
On Fri, 30 Jun 2023 03:42:28 +0300 Dmitry Baryshkov wrote: > On 30/06/2023 03:25, Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > > documentation. > > > > This enum property will allow user to specify a pixel source for the > > plane. Possible pixel sour

Re: [PATCH 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2023, at 00:51, Javier Martinez Canillas wrote: > Currently the CONFIG_FB option has to be enabled even if no legacy fbdev > drivers are needed (e.g: only to have support for framebuffer consoles). > > The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB > and so

Re: [PATCH drm-next v6 02/13] drm: manager to keep track of GPUs VA mappings

2023-06-30 Thread Boris Brezillon
On Fri, 30 Jun 2023 10:02:52 +0200 Boris Brezillon wrote: > In practice, I don't expect things to deadlock, because the VM resv is > not supposed to be taken outside the VM context and the locking order > is always the same (VM lock first, and then each shared BO > taken/released independently),

Re: [PATCH] drm/panel: simple: Add Powertip PH800480T013 drm_display_mode flags

2023-06-30 Thread Neil Armstrong
Hi, On Thu, 15 Jun 2023 22:16:02 +0200, Marek Vasut wrote: > Add missing drm_display_mode DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC > flags. Those are used by various bridges in the pipeline to correctly > configure its sync signals polarity. > > Thanks, Applied to https://anongit.freedesktop

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-30 Thread Helge Deller
On 6/27/23 16:58, Thomas Zimmermann wrote: Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers on sparc. Fixes the following error: ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o Reported-by: Guenter Roeck Closes: https://lore.kernel.org/dri-devel/c525adc9-66

Re: [PATCH v2 0/2] Fix up the boe-tv101wum-nl6 panel driver

2023-06-30 Thread Neil Armstrong
Hi Linus, On 16/06/2023 23:07, Linus Walleij wrote: This is two patches fixing things I would normally complain about in reviews, but alas I missed this one, so I go in and fix it up myself. The serie doesn't apply cleanly on drm-misc-next. Thanks, Neil Signed-off-by: Linus Walleij --- Ch

[PATCH 1/4] PCI/VGA: Use unsigned type for the io_state variable

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type. Cc: Bjorn Helg

[PATCH 3/4] PCI/VGA: Tidy up the code and comment format

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng This patch replaces the leading space with a tab and removes the double blank line, no functional change. Cc: Bjorn Helgaas Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Signed-off-by: Sui Jingfeng Reviewed-by: Andi Shy

[PATCH 2/4] PCI/VGA: Deal only with PCI VGA class devices

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng VGAARB should only care about PCI VGA class devices (pdev->class == 0x0300) since only those devices might have VGA routed to them.      PCI_CLASS_DISPLAY_3D and PCI_CLASS_DISPLAY_OTHER are used to annotate the render-only GPU. Render-only GPUs shouldn't decode the fixed VGA ad

[PATCH 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Cc: David Airlie Cc: Daniel Vetter Cc: Maarten Lankhors

Re: [PATCH RFC v4 1/7] drm: Introduce solid fill DRM plane property

2023-06-30 Thread Dmitry Baryshkov
On 30/06/2023 03:25, Jessica Zhang wrote: Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing th

[PATCH V5 0/9] Enable Wifi RFI interference mitigation feature support

2023-06-30 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise th

[PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-06-30 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[PATCH V5 2/9] driver core: add ACPI based WBRF mechanism introduced by AMD

2023-06-30 Thread Evan Quan
AMD has introduced an ACPI based mechanism to support WBRF for some platforms with AMD dGPU + WLAN. This needs support from BIOS equipped with necessary AML implementations and dGPU firmwares. For those systems without the ACPI mechanism and developing solutions, user can use the generic WBRF solu

[PATCH V5 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-06-30 Thread Evan Quan
The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index

[PATCH V5 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-06-30 Thread Evan Quan
To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated APCI calls. So that, other drivers responding to the frequencies can take proper actions to mitigate p

[PATCH V5 5/9] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-06-30 Thread Evan Quan
Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw

[PATCH V5 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-06-30 Thread Evan Quan
With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan Reviewed-by: Mario

[PATCH V5 7/9] drm/amd/pm: add flood detection for wbrf events

2023-06-30 Thread Evan Quan
To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 30 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH V5 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-06-30 Thread Evan Quan
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 + .../gpu/d

[PATCH V5 9/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-06-30 Thread Evan Quan
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

RE: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-30 Thread Quan, Evan
[AMD Official Use Only - General] Hi Rafael & Andrew, I just posted a new V5 series based on the discussions here and offline discussions with Mario. Please share your comments/insights there. Thanks, Evan > -Original Message- > From: Rafael J. Wysocki > Sent: Saturday, June 24, 2023 1

Re: [PATCH 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-06-30 Thread Javier Martinez Canillas
"Arnd Bergmann" writes: Hello Arnd, Thanks for your review! > On Fri, Jun 30, 2023, at 00:51, Javier Martinez Canillas wrote: >> Currently the CONFIG_FB option has to be enabled even if no legacy fbdev >> drivers are needed (e.g: only to have support for framebuffer consoles). >> >> The DRM sub

[PATCH v1 1/4] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-06-30 Thread Sui Jingfeng
This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately due to the fact that apertures list will be freed dynamically, the location and size information of the firmware fb will be lost after dedicated drivers call aperture_remove_conflicting_devices(), ape

[PATCH v1 0/4] PCI/VGA: Improve the default VGA device selection

2023-06-30 Thread Sui Jingfeng
Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM Bar. 4) It is device-ag

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-30 Thread Thomas Zimmermann
Hi Helge Am 30.06.23 um 11:43 schrieb Helge Deller: On 6/27/23 16:58, Thomas Zimmermann wrote: Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers on sparc. Fixes the following error: ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o Reported-by: Guenter Roeck

[PATCH v1 2/4] PCI/VGA: Improve the default VGA device selection

2023-06-30 Thread Sui Jingfeng
Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM Bar. 4) It is device-ag

[PATCH v1 1/4] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately due to the fact that apertures list will be freed dynamically, the location and size information of the firmware fb will be lost after dedicated drivers call aperture_remove_confl

[PATCH v1 0/4] PCI/VGA: Improve the default VGA device selection

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM Ba

[PATCH v1 2/4] PCI/VGA: Improve the default VGA device selection

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng Currently, the default VGA device selection is not perfect. Potential problems are: 1) This function is a no-op on non-x86 architectures. 2) It does not take the PCI Bar may get relocated into consideration. 3) It is not effective for the PCI device without a dedicated VRAM Ba

[PATCH v1 3/4] drm/amdgpu: Implement the is_boot_device callback function

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards. bec

[PATCH v1 4/4] drm/radeon: Implement the is_boot_device callback function

2023-06-30 Thread Sui Jingfeng
From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wrong even if we remove the #ifdef and #endif guards. bec

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-30 Thread Helge Deller
On 6/30/23 12:58, Thomas Zimmermann wrote: Hi Helge Am 30.06.23 um 11:43 schrieb Helge Deller: On 6/27/23 16:58, Thomas Zimmermann wrote: Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers on sparc. Fixes the following error: ERROR: modpost: missing MODULE_LICENSE() in arch/sparc

Re: [RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-30 Thread Karolina Stolarek
Hi Christian, I'm taking a second look at this, and I wonder what would be the benefit of combining the initialization of device and ttm_device. (drm_)device can be initialized indepedently from the test params, so we can utilize .init and .exit callbacks offered by KUnit[1] to prepare and rel

Re: [RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-30 Thread Christian König
Am 30.06.23 um 13:09 schrieb Karolina Stolarek: Hi Christian, I'm taking a second look at this, and I wonder what would be the benefit of combining the initialization of device and ttm_device. (drm_)device can be initialized indepedently from the test params, so we can utilize .init and .exit

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-06-30 Thread Thomas Zimmermann
Hi Javier Am 30.06.23 um 00:51 schrieb Javier Martinez Canillas: This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still having the the core fbdev support needed for the CONFIG_DRM

Re: [PATCH 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2023, at 12:51, Javier Martinez Canillas wrote: > "Arnd Bergmann" writes: > >>> @@ -59,7 +71,7 @@ config FIRMWARE_EDID >>> >>> config FB_DEVICE >>> bool "Provide legacy /dev/fb* device" >>> - depends on FB >>> + depends on FB_CORE >>> default y >>> help >>>

[PATCH] drm: support up to 128 drm devices

2023-06-30 Thread James Zhu
From: Christian König This makes room for up to 128 DRM devices. Signed-off-by: Christian König Signed-off-by: James Zhu --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 73b845a75d52..

Re: [PATCH 07/12] arch/x86: Declare edid_info in

2023-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2023, at 09:46, Thomas Zimmermann wrote: > Am 29.06.23 um 15:21 schrieb Arnd Bergmann: >> On Thu, Jun 29, 2023, at 15:01, Thomas Zimmermann wrote: >>> Am 29.06.23 um 14:35 schrieb Arnd Bergmann: On Thu, Jun 29, 2023, at 13:45, Thomas Zimmermann wrote: > >>> >>> FIRMWARE_EDID is

Re: [PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-06-30 Thread Thomas Zimmermann
Hi Am 02.06.23 um 09:40 schrieb Keith Zhao: Add crtc driver which implements crtc related operation functions. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 1 + drivers/gpu/drm/verisilicon/vs_crtc.c | 388 ++ drivers/gpu/drm/verisilicon/vs

[PATCH] drm: support up to 128 drm devices

2023-06-30 Thread James Zhu
From: Christian König This makes room for up to 128 DRM devices. Signed-off-by: Christian König Signed-off-by: James Zhu --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 73b845a75d52..

[PATCH] dma-buf: keep the signaling time of merged fences v3

2023-06-30 Thread Christian König
Some Android CTS is testing if the signaling time keeps consistent during merges. v2: use the current time if the fence is still in the signaling path and the timestamp not yet available. v3: improve comment, fix one more case to use the correct timestamp Signed-off-by: Christian König --- driv

Re: [PATCH 7/9] drm/verisilicon: Add drm plane funcs

2023-06-30 Thread Thomas Zimmermann
Am 02.06.23 um 09:40 schrieb Keith Zhao: Implement plane functions for the DRM driver. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_plane.c | 440 + drivers/gpu/drm/verisilicon/vs_plane.h | 74 +

Re: [PATCH 1/2] fbdev: Split frame buffer support in FB and FB_CORE symbols

2023-06-30 Thread Javier Martinez Canillas
"Arnd Bergmann" writes: > On Fri, Jun 30, 2023, at 12:51, Javier Martinez Canillas wrote: >> "Arnd Bergmann" writes: >> @@ -59,7 +71,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + depends on FB_CORE

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-06-30 Thread Javier Martinez Canillas
Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your review. > Hi Javier > > Am 30.06.23 um 00:51 schrieb Javier Martinez Canillas: >> This patch series splits the fbdev core support in two different Kconfig >> symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to >

Re: [RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-30 Thread Karolina Stolarek
On 30.06.2023 13:18, Christian König wrote: Am 30.06.23 um 13:09 schrieb Karolina Stolarek: Hi Christian, I'm taking a second look at this, and I wonder what would be the benefit of combining the initialization of device and ttm_device. (drm_)device can be initialized indepedently from the te

Re: [PATCH 0/2] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-06-30 Thread Thomas Zimmermann
Hi Am 30.06.23 um 14:33 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: Hello Thomas, Thanks a lot for your review. Hi Javier Am 30.06.23 um 00:51 schrieb Javier Martinez Canillas: This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE

[PATCH 00/19] DSC misc fixes

2023-06-30 Thread Ankit Nautiyal
This series is an attempt to address multiple issues with DSC, scattered in separate existing series. Patches 1-3 are DSC fixes from series to Handle BPC for HDMI2.1 PCON https://patchwork.freedesktop.org/series/107550/ Patches 4-5 are from series DSC fixes for Bigjoiner: https://patchwork.freede

[PATCH 01/19] drm/i915/dp: Consider output_format while computing dsc bpp

2023-06-30 Thread Ankit Nautiyal
While using DSC the compressed bpp is computed assuming RGB output format. Consider the output_format and compute the compressed bpp during mode valid and compute config steps. For DP-MST we currently use RGB output format only, so continue using RGB while computing compressed bpp for MST case. v

[PATCH 03/19] drm/i915/dp_mst: Use output_format to get the final link bpp

2023-06-30 Thread Ankit Nautiyal
The final link bpp used to calculate the m_n values depend on the output_format. Though the output_format is set to RGB for MST case and the link bpp will be same as the pipe bpp, for the sake of semantics, lets calculate the m_n values with the link bpp, instead of pipe_bpp. Signed-off-by: Ankit

[PATCH 02/19] drm/i915/dp: Move compressed bpp check with 420 format inside the helper

2023-06-30 Thread Ankit Nautiyal
Move the check for limiting compressed bite_per_pixel for 420,422 formats in the helper to compute bits_per_pixel. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH 04/19] drm/i915/dp: Use consistent name for link bpp and compressed bpp

2023-06-30 Thread Ankit Nautiyal
Currently there are many places where we use output_bpp for link bpp and compressed bpp. Lets use consistent naming: output_bpp : The intermediate value taking into account the output_format chroma subsampling. compressed_bpp : target bpp for the DSC encoder. link_bpp : final bpp used in the link.

[PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-06-30 Thread Ankit Nautiyal
In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Ville) v4: Fix check for display ver. (Ville) Signed-off-by: Ankit Nautiyal Reviewed-by: Ville Syrjälä --- dri

[PATCH 07/19] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-06-30 Thread Ankit Nautiyal
As per Bsepc:49259, Bigjoiner BW check puts restriction on the compressed bpp for a given CDCLK, pixelclock in cases where Bigjoiner + DSC are used. Currently compressed bpp is computed first, and it is ensured that the bpp will work at least with the max CDCLK freq. Since the CDCLK is computed l

[PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

2023-06-30 Thread Ankit Nautiyal
Currently we assume 2 Pixels Per Clock (PPC) while computing plane cdclk and min_cdlck. In cases where DSC single engine is used the throughput is 1 PPC. So account for the above case, while computing cdclk. v2: Use helper to get the adjusted pixel rate. Signed-off-by: Ankit Nautiyal --- drive

[PATCH 08/19] drm/i915/dp: Remove extra logs for printing DSC info

2023-06-30 Thread Ankit Nautiyal
DSC compressed bpp and slice counts are already getting printed at the end of dsc compute config. Remove extra logs. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/

[PATCH 09/19] drm/display/dp: Fix the DP DSC Receiver cap size

2023-06-30 Thread Ankit Nautiyal
DP DSC Receiver Capabilities are exposed via DPCD 60h-6Fh. Fix the DSC RECEIVER CAP SIZE accordingly. Fixes: ffddc4363c28 ("drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT") Cc: Anusha Srivatsa Cc: Manasi Navare Cc: # v5.0+ Signed-off-by: Ankit Nautiyal --- include

[PATCH 14/19] drm/i915/dp: Rename helper to get DSC max pipe_bpp

2023-06-30 Thread Ankit Nautiyal
The helper intel_dp_dsc_compute_bpp gives the maximum pipe bpp that is allowed with DSC. Rename the this to reflect that it returns max pipe bpp supported with DSC. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.

[PATCH 10/19] drm/i915/dp: Avoid forcing DSC BPC for MST case

2023-06-30 Thread Ankit Nautiyal
For MST the bpc is hardcoded to 8, and pipe bpp to 24. So avoid forcing DSC bpc for MST case. v2: Warn and ignore the debug flag than to bail out. (Jani) v3: Fix dbg message to mention forced bpc instead of bpp. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 11

[PATCH 12/19] drm/i915/dp: Check min bpc DSC limits for dsc_force_bpc also

2023-06-30 Thread Ankit Nautiyal
For DSC the min BPC is 8 for ICL+ and so the min pipe_bpp is 24. Check this condition for cases where bpc is forced by debugfs flag dsc_force_bpc. If the check fails, then WARN and ignore the debugfs flag. For MST case the pipe_bpp is already computed (hardcoded to be 24), and this check is not re

[PATCH 11/19] drm/i915/dp: Add functions to get min/max src input bpc with DSC

2023-06-30 Thread Ankit Nautiyal
Separate out functions for getting maximum and minimum input BPC based on platforms, when DSC is used. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 38 +++-- 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/dis

[PATCH 13/19] drm/i915/dp: Avoid left shift of DSC output bpp by 4

2023-06-30 Thread Ankit Nautiyal
To make way for fractional bpp support, avoid left shifting the output_bpp by 4 in helper intel_dp_dsc_get_output_bpp. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- 2 files changed, 4 insertions

[PATCH 15/19] drm/i915/dp: Separate out functions for edp/DP for computing DSC bpp

2023-06-30 Thread Ankit Nautiyal
Refactor code to separate functions for eDP and DP for computing pipe_bpp/compressed bpp when DSC is involved. This will help to optimize the link configuration for DP later. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 189 1 file changed

[PATCH 16/19] drm/i915/dp: Add DSC BPC/BPP constraints while selecting pipe bpp with DSC

2023-06-30 Thread Ankit Nautiyal
Currently we check if pipe_bpp is max the min DSC bpc requirements. Add checks for max DSC BPC/BPP constraints while computing the pipe_bpp when DSC is in use. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 34 + 1 file changed, 24 insertions(

[PATCH 17/19] drm/i915/dp: Separate out function to get compressed bpp with joiner

2023-06-30 Thread Ankit Nautiyal
Pull the code to get joiner constraints on maximum compressed bpp into separate function. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 49 ++--- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_d

[PATCH 18/19] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-06-30 Thread Ankit Nautiyal
Currently, we take the max lane, rate and pipe bpp, to get the maximum compressed bpp possible. We then set the output bpp to this value. This patch provides support to have max bpp, min rate and min lanes, that can support the min compressed bpp. v2: -Avoid ending up with compressed bpp, same as

[PATCH 19/19] drm/i915: Query compressed bpp properly using correct DPCD and DP Spec info

2023-06-30 Thread Ankit Nautiyal
From: Stanislav Lisovskiy Currently we seem to be using wrong DPCD register for reading compressed bpps, reading min/max input bpc instead of compressed bpp. Fix that, so that we now apply min/max compressed bpp limitations we get from DP Spec Table 2-157 DP v2.0 and/or correspondent DPCD registe

Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

2023-06-30 Thread Simon Horman
On Fri, Jun 30, 2023 at 06:32:32PM +0800, Evan Quan wrote: ... > diff --git a/include/linux/wbrf.h b/include/linux/wbrf.h > new file mode 100644 > index ..3ca95786cef5 > --- /dev/null > +++ b/include/linux/wbrf.h > @@ -0,0 +1,65 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + *

Re: [PATCH V5 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-06-30 Thread kernel test robot
Hi Evan, kernel test robot noticed the following build errors: [auto build test ERROR on wireless-next/main] [also build test ERROR on wireless/main linus/master v6.4] [cannot apply to drm-misc/drm-misc-next next-20230630] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH V5 7/9] drm/amd/pm: add flood detection for wbrf events

2023-06-30 Thread kernel test robot
Hi Evan, kernel test robot noticed the following build warnings: [auto build test WARNING on wireless-next/main] [also build test WARNING on wireless/main v6.4] [cannot apply to drm-misc/drm-misc-next linus/master next-20230630] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. > > This enum property will allow user to specify a pixel source for the > plane. Possible pixel sources will be defined in the > drm_plane_pixel_source enum. >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/20230626183347.55118-1-andreal

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Alex Deucher
On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick wrote: > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida > >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Michel Dänzer
On 6/30/23 16:59, Alex Deucher wrote: > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: >> On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: >>> >>> +Robustness >>> +-- >>> + >>> +The only way to try to keep an application working after a reset is if it >>> +complies with the

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 4:59 PM Alex Deucher wrote: > > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: > > > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida > > wrote: > > > > > > Create a section that specifies how to deal with DRM device resets for > > > kernel and userspace drivers

[PATCH] drm/nouveau/disp/g94: enable HDMI

2023-06-30 Thread Karol Herbst
Cc: Ben Skeggs Cc: Lyude Paul Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods") Signed-off-by: Karol Herbst --- drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/

[PATCH] drm/msm/a6xx: Fix misleading comment

2023-06-30 Thread Rob Clark
From: Rob Clark The range is actually len+1. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index eea2e60ce3b7..edf76a4b16b

[PATCH] MAINTAINERS: Remove Laura Abbott from DMA-BUF HEAPS FRAMEWORK

2023-06-30 Thread John Stultz
Laura's email address has not been valid for quite awhile now, so wanted to clean up the reviewer list here. I reached out to Laura who said it made sense to drop her from the list, so this patch does that. I do want to recognize Laura's long time contribution to this area and her previous ION ma

[PATCH v6 0/9] drm/meson: add support for MIPI DSI Display

2023-06-30 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI glue on the same Amlogic SoCs. This is a follow-up of v5 now the DRM patches are applied, the clk & DT changes remains

[PATCH v6 3/9] clk: meson: add vclk driver

2023-06-30 Thread Neil Armstrong
The VCLK and VCLK_DIV clocks have supplementary bits. The VCLK has a "SOFT RESET" bit to toggle after the whole VCLK sub-tree rate has been set, this is implemented in the gate enable callback. The VCLK_DIV clocks as enable and reset bits used to disable and reset the divider, associated with CLK

[PATCH v6 2/9] clk: meson: g12a: add CTS_ENCL & CTS_ENCL_SEL clocks

2023-06-30 Thread Neil Armstrong
Add new CTS_ENCL & CTS_ENCL_SEL clocks for the G12A compatible SoCs, they are used to feed the VPU LCD Pixel encoder used for DSI display purposes. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.c | 40 1 file changed, 40 insertions(+) diff --g

[PATCH v6 1/9] dt-bindings: clk: g12a-clkc: add CTS_ENCL clock ids

2023-06-30 Thread Neil Armstrong
Add new CLK ids for the CTS_ENCL and CTS_ENCL_SEL clocks on G12A compatible SoCs. Signed-off-by: Neil Armstrong --- include/dt-bindings/clock/g12a-clkc.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/dt-bindings/clock/g12a-clkc.h b/include/dt-bindings/clock/g12a-clkc.h index 387

[PATCH v6 4/9] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-06-30 Thread Neil Armstrong
In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2 - vclk_div1 - vclk2_div2_en - vclk2_div4_en - vclk2_div6_en - vclk2_div12_en - vclk2_div2 - vclk2_div4 -

[PATCH v6 7/9] DONOTMERGE: arm64: meson: khadas-vim3l: add DSI panel

2023-06-30 Thread Neil Armstrong
This add nodes to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- .../boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 76 ++ .../boot/dts/amlogic/meson-sm1-khadas-

[PATCH v6 5/9] drm/meson: gate px_clk when setting rate

2023-06-30 Thread Neil Armstrong
Disable the px_clk when setting the rate to recover a fully configured and correctly reset VCLK clock tree after the rate is set. Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_mipi_dsi.c | 7 +++ 1 fil

[PATCH v6 6/9] arm64: meson: g12-common: add the MIPI DSI nodes

2023-06-30 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH v6 8/9] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2023-06-30 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bin

[PATCH v6 9/9] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2023-06-30 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 388 ++

Re: [PATCH v2 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator

2023-06-30 Thread Rob Herring
On Thu, 29 Jun 2023 22:35:41 +0200, Konrad Dybcio wrote: > Modern Qualcomm SoCs have a REFGEN (reference voltage generator) > regulator, providing reference voltage to on-chip IP, like PHYs. > It's controlled through MMIO and we can toggle it or read its state back. > > Describe it. > > Signed-

  1   2   >