[drm/bridge]: possible buffer overrun in cdns-mhdp8546-core.c

2023-06-27 Thread yguoaz
In the file drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c, the function cdns_mhdp_print_lt_status has the following code: char vs[8] = "0/0/0/0"; char pe[8] = "0/0/0/0"; unsigned int i; for (i = 0; i < mhdp->link.num_lanes; i++) { vs[i * 2] = '0' + phy_cfg->dp.voltage[i]; pe[i * 2]

Re: [PATCH v1 0/2] udmabuf: Add back support for mapping hugetlb pages

2023-06-27 Thread David Hildenbrand
On 27.06.23 08:37, Kasireddy, Vivek wrote: Hi David, Hi! sorry for taking a bit longer to reply lately. [...] Sounds right, maybe it needs to go back to the old GUP solution, though, as mmu notifiers are also mm-based not fd-based. Or to be explicit, I think it'll be pin_user_pages(FOLL_LO

Re: [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 08:54, Marijn Suijten wrote: > On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: >> On 26/06/2023 20:53, Marijn Suijten wrote: >>> On 2023-06-26 20:51:38, Marijn Suijten wrote: >>> > Not really, binding also defines the list of clocks - their order and > specific entries. Th

Re: [PATCH v4 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 15:33:47 -0300 André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Signed-off-by: André Almeida > --- > Documentation/gpu/drm-uapi.rst | 68 ++ > 1 file changed, 68

Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Marijn Suijten
On 2023-06-27 09:29:53, Krzysztof Kozlowski wrote: > On 27/06/2023 08:54, Marijn Suijten wrote: > > On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: > >> On 26/06/2023 20:53, Marijn Suijten wrote: > >>> On 2023-06-26 20:51:38, Marijn Suijten wrote: > >>> > > Not really, binding also defines

Re: [PATCH v3 0/3] Add additional YUV420 bus format check for dw-meson's bridge enable

2023-06-27 Thread Neil Armstrong
Hi, On Sun, 25 Jun 2023 15:17:14 +0100, Adrián Larumbe wrote: > This is a belated follow-up on > https://lore.kernel.org/dri-devel/20220515204412.2733803-1-adrian.laru...@collabora.com > > Commit e67f6037ae1be34b2b68 ("drm/meson: split out encoder from > meson_dw_hdmi") > broke 4K display modes

Re: [RFC PATCH 0/3] Support for Solid Fill Planes

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 16:02:50 -0700 Jessica Zhang wrote: > On 11/7/2022 11:37 AM, Ville Syrjälä wrote: > > On Fri, Oct 28, 2022 at 03:59:49PM -0700, Jessica Zhang wrote: > >> Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT > >> properties. When the color fill value is set, and the

Re: [PATCH v4] drm/vkms: Add support to 1D gamma LUT

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 14:35:25 -0300 Maira Canal wrote: > Hi Pekka, > > On 6/26/23 05:17, Pekka Paalanen wrote: > > On Sat, 24 Jun 2023 18:48:08 -0300 > > Maira Canal wrote: > > > >> Hi Arthur, > >> > >> Thanks for working on this feature for the VKMS! > >> > >> On 6/21/23 16:41, Arthur Grillo

Re: [PATCH v3 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 23:58:32 -0400 Zack Rusin wrote: > From: Zack Rusin > > Cursor planes on virtualized drivers have special meaning and require > that the clients handle them in specific ways, e.g. the cursor plane > should react to the mouse movement the way a mouse cursor would be > expecte

Re: [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 09:49, Marijn Suijten wrote: > On 2023-06-27 09:29:53, Krzysztof Kozlowski wrote: >> On 27/06/2023 08:54, Marijn Suijten wrote: >>> On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: On 26/06/2023 20:53, Marijn Suijten wrote: > On 2023-06-26 20:51:38, Marijn Suijten wrote: >>

Re: [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 23:58:33 -0400 Zack Rusin wrote: > From: Zack Rusin > > Atomic modesetting code lacked support for specifying mouse cursor > hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting > the hotspot but the functionality was not implemented in the new atomic > pa

Re: [PATCH v3 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: Hello Zack, > From: Zack Rusin > > Cursor planes on virtualized drivers have special meaning and require > that the clients handle them in specific ways, e.g. the cursor plane > should react to the mouse movement the way a mouse cursor would be > expected to and the client is

Re: [PATCH v4 13/19] drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2 macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:13, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov You

[RFC v2 0/3] Introduce KUnit tests for TTM subsystem

2023-06-27 Thread Karolina Stolarek
This series introduces KUnit[1] tests for TTM (Translation Table Manager) subsystem, a memory manager used by graphics drivers to create and manage memory buffers across different memory domains, such as system memory or VRAM. Unit tests implemented here cover two data structures: - ttm_device -

[RFC v2 1/3] drm/ttm: Introduce KUnit tests

2023-06-27 Thread Karolina Stolarek
Add the initial version of unit tests for ttm_device struct, together with helper functions. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/Kconfig | 15 + drivers/gpu/drm/ttm/Makefile | 1 + drivers/gpu/drm/ttm/tests/.kunitconfig| 4 ++

[RFC v2 2/3] drm/ttm/tests: Add tests for ttm_device

2023-06-27 Thread Karolina Stolarek
Test initialization and cleanup of the ttm_device struct, including some error paths. Verify the creation of page pools if use_dma_alloc param is true. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/ttm_device_test.c | 159 1 file changed, 159 insertions(+)

[RFC v2 3/3] drm/ttm/tests: Add tests for ttm_pool

2023-06-27 Thread Karolina Stolarek
Add KUnit tests that exercise page allocation using page pools and freeing pages, either by returning them to the pool or freeing them. Add a basic test for ttm_pool cleanup. Introduce helpers to create a dummy ttm_buffer_object. Signed-off-by: Karolina Stolarek --- drivers/gpu/drm/ttm/tests/Mak

Re: [PATCH v4 10/19] drm/msm/dpu: inline SSPP_BLK macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:10, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 11/19] drm/msm/dpu: inline DSPP_BLK macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:11, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 12/19] drm/msm/dpu: inline LM_BLK macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:12, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 14/19] drm/msm/dpu: inline MERGE_3D_BLK macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:14, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 15/19] drm/msm/dpu: inline various PP_BLK_* macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:15, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 16/19] drm/msm/dpu: inline WB_BLK macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:16, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v4 17/19] drm/msm/dpu: inline INTF_BLK and INTF_BLK_DSI_TE macros

2023-06-27 Thread Marijn Suijten
On 2023-06-20 00:25:17, Dmitry Baryshkov wrote: > To simplify making changes to the hardware block definitions, expand > corresponding macros. This way making all the changes are more obvious > and visible in the source files. > > Tested-by: Marijn Suijten > Signed-off-by: Dmitry Baryshkov Vali

Re: [PATCH v3 8/8] drm: Introduce DRM_CLIENT_CAP_VIRTUALIZED_CURSOR_PLANE

2023-06-27 Thread Pekka Paalanen
On Mon, 26 Jun 2023 23:58:39 -0400 Zack Rusin wrote: > From: Zack Rusin > > Virtualized drivers place additional restrictions on the cursor plane > which breaks the contract of universal planes. To allow atomic > modesettings with virtualized drivers the clients need to advertise > that they're

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/26 15:56, Thomas Zimmermann wrote: Hi Am 25.06.23 um 07:09 schrieb Sui Jingfeng: As this function can be replaced with drm_dev_unregister() + drm_dev_put(), it is already marked as deprecated, so remove it. No functional change. Signed-off-by: Sui Jingfeng ---   drivers/gpu/dr

Why does kgd2kfd_interrupt() have to schedule work on a specific CPU?

2023-06-27 Thread Philipp Stanner
Hello folks, I'm currently trying to learn more about DRM and discovered the following code sequence: drivers/gpu/drm/amd/amdkfd/kfd_device.c, Line 824 on 6.4-rc7 static inline void kfd_queue_work(struct workqueue_struct *wq, struct work_struct *work) {

Re: [PATCH 09/15] drm/msm/mdss: Add SM6125 support

2023-06-27 Thread Dmitry Baryshkov
On 24/06/2023 03:41, Marijn Suijten wrote: SM6125's UBWC hardware decoder is version 3.0, and supports decoding UBWC 1.0. I think it's UBWC encoder version, see https://git.codelinaro.org/clo/la/platform/vendor/opensource/display-drivers/-/blob/display-kernel.lnx.5.15.1.r17-rel/msm/sde/sde_hw_

Re: [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting code lacked support for specifying mouse cursor > hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting > the hotspot but the functionality was not implemented in the new atomic > paths. > > Due to the lack of hotspot

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/26 21:20, Sui Jingfeng wrote: Hi, On 2023/6/26 20:32, Maxime Ripard wrote: Hi, On Tue, Jun 20, 2023 at 06:18:31PM +0200, Thomas Zimmermann wrote: Am 20.06.23 um 18:06 schrieb Sui Jingfeng: Hi, On 2023/6/20 22:43, Thomas Zimmermann wrote: Hi Am 20.06.23 um 06:08 schrieb Sui

Re: [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots

2023-06-27 Thread Javier Martinez Canillas
Pekka Paalanen writes: > On Mon, 26 Jun 2023 23:58:33 -0400 > Zack Rusin wrote: > >> From: Zack Rusin >> >> Atomic modesetting code lacked support for specifying mouse cursor >> hotspots. The legacy kms DRM_IOCTL_MODE_CURSOR2 had support for setting >> the hotspot but the functionality was not

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-27 Thread Thomas Zimmermann
Hi Am 26.06.23 um 14:32 schrieb Maxime Ripard: Hi, On Tue, Jun 20, 2023 at 06:18:31PM +0200, Thomas Zimmermann wrote: Am 20.06.23 um 18:06 schrieb Sui Jingfeng: Hi, On 2023/6/20 22:43, Thomas Zimmermann wrote: Hi Am 20.06.23 um 06:08 schrieb Sui Jingfeng: ping ? On 2023/3/14 20:53, Sui J

Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Marijn Suijten
On 2023-06-27 10:21:12, Krzysztof Kozlowski wrote: > On 27/06/2023 09:49, Marijn Suijten wrote: > > On 2023-06-27 09:29:53, Krzysztof Kozlowski wrote: > >> On 27/06/2023 08:54, Marijn Suijten wrote: > >>> On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: > On 26/06/2023 20:53, Marijn Suijten

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/26 15:48, Jani Nikula wrote: On Sun, 25 Jun 2023, Sui Jingfeng wrote: As this function can be replaced with drm_dev_unregister() + drm_dev_put(), it is already marked as deprecated, so remove it. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_drv.c

Re: [PATCH v2 0/4] drm/ttm: Fixes around resources and bulk moves

2023-06-27 Thread Thomas Hellström
On 6/26/23 11:14, Thomas Hellström wrote: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A couple of ttm fixes for issues that either were hit while developing the xe driver or, for the resource leak patches, discovered during code inspection. v2: -

Re: [PATCH 09/15] drm/msm/mdss: Add SM6125 support

2023-06-27 Thread Marijn Suijten
On 2023-06-27 11:49:07, Dmitry Baryshkov wrote: > On 24/06/2023 03:41, Marijn Suijten wrote: > > SM6125's UBWC hardware decoder is version 3.0, and supports decoding > > UBWC 1.0. > > I think it's UBWC encoder version, see > https://git.codelinaro.org/clo/la/platform/vendor/opensource/display-dri

Re: [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 11:02, Marijn Suijten wrote: > So deleting a new item at the end does not matter. But what if I respin > this patch to add the new clock _at the end_, which will then be at the > same index as the previous GCC_DISP_AHB_CLK? I think you know the answer, right? Wh

Re: [PATCH 03/15] dt-bindings: clock: qcom,dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Marijn Suijten
On 2023-06-27 11:07:22, Krzysztof Kozlowski wrote: > On 27/06/2023 11:02, Marijn Suijten wrote: > > So deleting a new item at the end does not matter. But what if I respin > > this patch to add the new clock _at the end_, which will then be at the > > same index as the previous GCC_DIS

Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/27 17:00, Thomas Zimmermann wrote: Hi Am 26.06.23 um 14:32 schrieb Maxime Ripard: Hi, On Tue, Jun 20, 2023 at 06:18:31PM +0200, Thomas Zimmermann wrote: Am 20.06.23 um 18:06 schrieb Sui Jingfeng: Hi, On 2023/6/20 22:43, Thomas Zimmermann wrote: Hi Am 20.06.23 um 06:08 schri

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Jani Nikula
On Tue, 27 Jun 2023, Sui Jingfeng wrote: > Hi, > > On 2023/6/26 15:48, Jani Nikula wrote: >> On Sun, 25 Jun 2023, Sui Jingfeng wrote: >>> As this function can be replaced with drm_dev_unregister() + drm_dev_put(), >>> it is already marked as deprecated, so remove it. No functional change. >>> >>>

Re: [PATCH v3 3/8] drm/vmwgfx: Use the hotspot properties from cursor planes

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting got support for mouse hotspots via the hotspot > properties. Port the legacy kms hotspot handling to the new properties > on cursor planes. > > Signed-off-by: Zack Rusin > Cc: Martin Krastev > Cc: Maaz Mombasawala > --- Reviewed-by

Re: [PATCH v3 4/8] drm/qxl: Use the hotspot properties from cursor planes

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting got support for mouse hotspots via the hotspot > properties. Port the legacy kms hotspot handling to the new properties > on cursor planes. > > Signed-off-by: Zack Rusin > Reviewed-by: Gerd Hoffmann > Cc: Dave Airlie > Cc: Daniel Ve

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
Hi On 2023/6/27 17:33, Jani Nikula wrote: On Tue, 27 Jun 2023, Sui Jingfeng wrote: Hi, On 2023/6/26 15:48, Jani Nikula wrote: On Sun, 25 Jun 2023, Sui Jingfeng wrote: As this function can be replaced with drm_dev_unregister() + drm_dev_put(), it is already marked as deprecated, so remove i

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
On 2023/6/27 16:41, Sui Jingfeng wrote: if the ->probe() failed, then the ->remove will be get called. if the ->probe() failed, then the ->remove()  will *NOT* get called. -- Jingfeng

Re: [PATCH v3 5/8] drm/vboxvideo: Use the hotspot properties from cursor planes

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting got support for mouse hotspots via the hotspot > properties. Port the legacy kms hotspot handling to the new properties > on cursor planes. > > Signed-off-by: Zack Rusin > Cc: Hans de Goede > Cc: David Airlie > Cc: Daniel Vetter >

Re: [PATCH v3 6/8] drm/virtio: Use the hotspot properties from cursor planes

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting got support for mouse hotspots via the hotspot > properties. Port the legacy kms hotspot handling to the new properties > on cursor planes. > > Signed-off-by: Zack Rusin > Reviewed-by: Gerd Hoffmann > Cc: David Airlie > Cc: Gurcheta

Re: [PATCH v3 7/8] drm: Remove legacy cursor hotspot code

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Atomic modesetting support mouse cursor offsets via the hotspot > properties that are creates on cursor planes. All drivers which s/creates/created ? Can also be fixed when applying. > support hotspot are atomic and the legacy code has been implemente

Re: [PATCH v3 8/8] drm: Introduce DRM_CLIENT_CAP_VIRTUALIZED_CURSOR_PLANE

2023-06-27 Thread Javier Martinez Canillas
Zack Rusin writes: > From: Zack Rusin > > Virtualized drivers place additional restrictions on the cursor plane > which breaks the contract of universal planes. To allow atomic > modesettings with virtualized drivers the clients need to advertise > that they're capable of dealing with those extr

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/27 17:33, Jani Nikula wrote: On Tue, 27 Jun 2023, Sui Jingfeng wrote: Hi, On 2023/6/26 15:48, Jani Nikula wrote: On Sun, 25 Jun 2023, Sui Jingfeng wrote: As this function can be replaced with drm_dev_unregister() + drm_dev_put(), it is already marked as deprecated, so remove

Re: [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots

2023-06-27 Thread Pekka Paalanen
On Tue, 27 Jun 2023 10:56:39 +0200 Javier Martinez Canillas wrote: > Pekka Paalanen writes: > > > On Mon, 26 Jun 2023 23:58:33 -0400 > > Zack Rusin wrote: > > > >> From: Zack Rusin > >> > >> Atomic modesetting code lacked support for specifying mouse cursor > >> hotspots. The legacy kms DR

Re: [PATCH v3 2/8] drm/atomic: Add support for mouse hotspots

2023-06-27 Thread Javier Martinez Canillas
Pekka Paalanen writes: > On Tue, 27 Jun 2023 10:56:39 +0200 > Javier Martinez Canillas wrote: > [...] >> > Hi Zack, >> > >> > where is the UAPI documentation for these new properties? I mean >> > something ending up in the HTML docs like what other properties have in >> > e.g. >> > https://ww

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-06-27 Thread Geert Uytterhoeven
Hi Dmitry, On Mon, Jun 26, 2023 at 6:11 PM Dmitry Osipenko wrote: > On 6/25/23 18:36, Geert Uytterhoeven wrote: > > On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko > > wrote: > >> On 6/25/23 11:47, Geert Uytterhoeven wrote: > >>> On Sun, Apr 16, 2023 at 1:55 PM Dmitry Osipenko > >>> wrote: > >>

Re: [PATCH v3 3/8] drm/vmwgfx: Use the hotspot properties from cursor planes

2023-06-27 Thread Martin Krastev (VMware)
From: Martin Krastev Looks good. Reviewed-by: Martin Krastev Regards, Martin On 27.06.23 г. 6:58 ч., Zack Rusin wrote: From: Zack Rusin Atomic modesetting got support for mouse hotspots via the hotspot properties. Port the legacy kms hotspot handling to the new properties on cursor pl

[PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread André Almeida
Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida --- v4: https://lore.kernel.org/lkml/20230626183347.55118-1-andrealm...@igalia.com/ Changes: - Grammar fixes (Randy) Documentation/gpu/d

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Jani Nikula
On Tue, 09 May 2023, fei.y...@intel.com wrote: > From: Fei Yang > > This patch is a preparation for replacing enum i915_cache_level with PAT > index. Caching policy for buffer objects is set through the PAT index in > PTE, the old i915_cache_level is not sufficient to represent all caching > modes

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Tvrtko Ursulin
On 27/06/2023 14:28, Jani Nikula wrote: On Tue, 09 May 2023, fei.y...@intel.com wrote: From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not suffici

Re: [PATCH] drm: Remove the deprecated drm_put_dev() function

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/27 16:41, Sui Jingfeng wrote: I have verified that if the ->probe() failed, then the ->remove will be get called. Sorry, if the ->probe() failed, then the ->remove() will *NOT* get called. I'm doing the test by add a line before the drm_dev_alloc() I do the test by adding

Re: [PATCH v7 8/8] drm/radeon: Implement the is_boot_device callback function

2023-06-27 Thread Sui Jingfeng
PING ? On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui Jingfeng [why] The vga_is_firmware_default() defined in drivers/pci/vgaarb.c is arch-dependent, it's a dummy on non-x86 architectures currently. This made VGAARB lost an important condition for the arbitration. It could still be wron

Re: [PATCH v7 5/8] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-06-27 Thread Sui Jingfeng
 PING ? On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately due to the fact that apertures list will be freed dynamically, the location and size information of the firmware fb will be lost

Re: XDC 2023: Registration & Call for Proposals now open!

2023-06-27 Thread Ricardo Garcia
This is a reminder that the XDC 2023 Registration and the Call for Proposals are still open and will be open for about 2 more weeks. Do not forget to submit your proposals before the deadline (July 17)! The conference will take place in A Coruña this year, from October 17 to 19. You can find more

Re: [PATCH v7 6/8] PCI/VGA: Introduce is_boot_device function callback to vga_client_register

2023-06-27 Thread Sui Jingfeng
PING ? On 2023/6/13 11:01, Sui Jingfeng wrote: From: Sui Jingfeng The vga_is_firmware_default() function is arch-dependent, it's probably wrong if we simply remove the arch guard. As the VRAM BAR which contains firmware framebuffer may move, while the lfb_base and lfb_size members of the scree

Re: [25/39] drm: renesas: shmobile: Rename shmob_drm_crtc.crtc

2023-06-27 Thread Sui Jingfeng
On 2023/6/22 17:21, Geert Uytterhoeven wrote: Rename the "crtc" member of the shmob_drm_crtc subclass structure to "base", to improve readability. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Reviewed-by: Sui Jingfeng --- .../gpu/drm/renesas/shmobile/shmob_drm_crtc

Re: [26/39] drm: renesas: shmobile: Rename shmob_drm_connector.connector

2023-06-27 Thread Sui Jingfeng
On 2023/6/22 17:21, Geert Uytterhoeven wrote: Rename the "connector" member of the shmob_drm_connector subclass structure to "base", to improve readability. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/renesas/shmobile/s

Re: [27/39] drm: renesas: shmobile: Rename shmob_drm_plane.plane

2023-06-27 Thread Sui Jingfeng
On 2023/6/22 17:21, Geert Uytterhoeven wrote: Rename the "plane" member of the shmob_drm_plane subclass structure to "base", to improve readability. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/renesas/shmobile/shmob_drm

[PATCH v2 00/24] use vmalloc_array and vcalloc

2023-06-27 Thread Julia Lawall
The functions vmalloc_array and vcalloc were introduced in commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions") but are not used much yet. This series introduces uses of these functions, to protect against multiplication overflows. The changes were done using the following

[PATCH v2 15/24] habanalabs: use vmalloc_array and vcalloc

2023-06-27 Thread Julia Lawall
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown"

[PATCH v2 06/24] dma-buf: system_heap: use vmalloc_array and vcalloc

2023-06-27 Thread Julia Lawall
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown"

[PATCH v2 03/24] drm/gud: use vmalloc_array and vcalloc

2023-06-27 Thread Julia Lawall
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown"

[PATCH v2 16/24] drm/i915/gvt: use vmalloc_array and vcalloc

2023-06-27 Thread Julia Lawall
Use vmalloc_array and vcalloc to protect against multiplication overflows. The changes were done using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let rename alloc = match alloc with "vmalloc" -> "vmalloc_array" | "vzalloc" -> "vcalloc" | _ -> failwith "unknown"

Re: [32/39] drm: renesas: shmobile: Shutdown the display on remove

2023-06-27 Thread Sui Jingfeng
Hi On 2023/6/22 17:21, Geert Uytterhoeven wrote: When the device is unbound from the driver, the display may be active. Make sure it gets shut down. would you mind to give a short description why this is necessary. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- drive

[PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-27 Thread Thomas Zimmermann
Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers on sparc. Fixes the following error: ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o Reported-by: Guenter Roeck Closes: https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c931156...@roeck-us.net/ Sugge

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Andi Shyti
Hi Jani and Tvrtko, > > > This patch is a preparation for replacing enum i915_cache_level with PAT > > > index. Caching policy for buffer objects is set through the PAT index in > > > PTE, the old i915_cache_level is not sufficient to represent all caching > > > modes supported by the hardware. >

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Jani Nikula
On Tue, 27 Jun 2023, Andi Shyti wrote: > Tvrtko wrote: >> I'd simply suggest having a local static const table for the mock device. It >> should be trivial once i915->__info becomes a pointer so in that series I >> guess. That's a great idea, thanks! > Fei... do you have bandwidth to look into t

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Yang, Fei
> Hi Jani and Tvrtko, > This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. >>>

Re: [PATCH v15 1/2] drm: Add kms driver for loongson display controller

2023-06-27 Thread Sui Jingfeng
Hi, On 2023/6/19 18:19, Huacai Chen wrote: Single patch is more easy to manage. The first patch of this driver should comes a whole. Benchmarks and debugfs are not the very basic parts. In the V2, Thomas told me that if we implement our own TTM-based memory manager, we will also have the p

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-27 Thread Randy Dunlap
On 6/27/23 07:58, Thomas Zimmermann wrote: > Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers > on sparc. Fixes the following error: > > ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o > > Reported-by: Guenter Roeck > Closes: > https://lore.kernel.org/dri-

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-27 Thread Arnd Bergmann
On Tue, Jun 27, 2023, at 16:58, Thomas Zimmermann wrote: > Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers > on sparc. Fixes the following error: > > ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o > > Reported-by: Guenter Roeck > Closes: > https://lore.kernel

Re: [PATCH v8 1/2] drm/i915: preparation for using PAT index

2023-06-27 Thread Yang, Fei
> On 27/06/2023 14:28, Jani Nikula wrote: >> On Tue, 09 May 2023, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> This patch is a preparation for replacing enum i915_cache_level with >>> PAT index. Caching policy for buffer objects is set through the PAT >>> index in PTE, the old i915_cache_l

Re: [PATCH v15 1/2] drm: Add kms driver for loongson display controller

2023-06-27 Thread Sui Jingfeng
On 2023/6/27 23:27, Sui Jingfeng wrote: Hi, On 2023/6/19 18:19, Huacai Chen wrote: Single patch is more easy to manage. The first patch of this driver should comes a whole. Benchmarks and debugfs are not the very basic parts. In the V2, Thomas told me that if we implement our own TTM-bas

Re: Why does kgd2kfd_interrupt() have to schedule work on a specific CPU?

2023-06-27 Thread Alex Deucher
+Felix, Philip On Tue, Jun 27, 2023 at 4:42 AM Philipp Stanner wrote: > > Hello folks, > > I'm currently trying to learn more about DRM and discovered the > following code sequence: > > > drivers/gpu/drm/amd/amdkfd/kfd_device.c, Line 824 on 6.4-rc7 > > static inline void kfd_queue_work(struct wor

Re: [PATCH v1 0/2] udmabuf: Add back support for mapping hugetlb pages

2023-06-27 Thread Jason Gunthorpe
On Mon, Jun 26, 2023 at 03:04:21PM -0400, Peter Xu wrote: > On Mon, Jun 26, 2023 at 03:18:48PM -0300, Jason Gunthorpe wrote: > > On Mon, Jun 26, 2023 at 08:14:27PM +0200, David Hildenbrand wrote: > > > > > So we might have to implement the same page migration as gup does on > > > FOLL_LONGTERM her

Re: [PATCH v1 0/2] udmabuf: Add back support for mapping hugetlb pages

2023-06-27 Thread Peter Xu
On Tue, Jun 27, 2023 at 12:52:34PM -0300, Jason Gunthorpe wrote: > On Mon, Jun 26, 2023 at 03:04:21PM -0400, Peter Xu wrote: > > On Mon, Jun 26, 2023 at 03:18:48PM -0300, Jason Gunthorpe wrote: > > > On Mon, Jun 26, 2023 at 08:14:27PM +0200, David Hildenbrand wrote: > > > > > > > So we might have

Re: [PATCH v1 0/2] udmabuf: Add back support for mapping hugetlb pages

2023-06-27 Thread Jason Gunthorpe
On Tue, Jun 27, 2023 at 12:00:38PM -0400, Peter Xu wrote: > On Tue, Jun 27, 2023 at 12:52:34PM -0300, Jason Gunthorpe wrote: > > On Mon, Jun 26, 2023 at 03:04:21PM -0400, Peter Xu wrote: > > > On Mon, Jun 26, 2023 at 03:18:48PM -0300, Jason Gunthorpe wrote: > > > > On Mon, Jun 26, 2023 at 08:14:27P

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Randy Dunlap
Hi André, I have just a few more below: On 6/27/23 06:23, André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/202

Re: [PATCH v2 00/24] use vmalloc_array and vcalloc

2023-06-27 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 27 Jun 2023 16:43:15 +0200 you wrote: > The functions vmalloc_array and vcalloc were introduced in > > commit a8749a35c399 ("mm: vmalloc: introduce array allocation functions") > > but are not used much yet

[PATCH][next] drm/edid: make read-only const array static

2023-06-27 Thread Colin Ian King
Don't populate the const array on the stack, instead make it static. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index e0dbd9140726..39b13417b749 100644 --

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-06-27 Thread Rob Clark
On Fri, May 12, 2023 at 2:23 PM Gurchetan Singh wrote: > > > > On Thu, May 11, 2023 at 7:33 PM Dmitry Osipenko > wrote: >> >> On 5/12/23 03:17, Gurchetan Singh wrote: >> ... >> > Can we get one of the Mesa MRs reviewed first? There's currently no >> > virtio-intel MR AFAICT, and the amdgpu one

Re: [PATCH 20/26] drm/vmwgfx: use array_size

2023-06-27 Thread Julia Lawall
On Fri, 23 Jun 2023, Julia Lawall wrote: > Use array_size to protect against multiplication overflows. > > The changes were done using the following Coccinelle semantic patch: > > // > @@ > size_t e1,e2; > expression COUNT; > identifier alloc = {vmalloc,vzalloc,kvmalloc,kvzalloc};

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Christian König
Am 27.06.23 um 15:23 schrieb André Almeida: Create a section that specifies how to deal with DRM device resets for kernel and userspace drivers. Acked-by: Pekka Paalanen Signed-off-by: André Almeida --- v4: https://lore.kernel.org/lkml/20230626183347.55118-1-andrealm...@igalia.com/ Changes:

Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

2023-06-27 Thread Sam Ravnborg
On Tue, Jun 27, 2023 at 04:58:20PM +0200, Thomas Zimmermann wrote: > Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers > on sparc. Fixes the following error: > > ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o > > Reported-by: Guenter Roeck > Closes: > https:/

[PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-06-27 Thread Carlos Eduardo Gallo Filho
The functions drm_framebuffer_plane{width,height} and fb_plane_{width,height} do exactly the same job of its equivalents drm_format_info_plane_{width,height} from drm_fourcc. The only reason to have these functions on drm_framebuffer would be if they would added a abstraction layer to call it just

Re: [PATCH v2 6/6] drm/i915/gt: Remove bogus comment on IVB_FBC_RT_BASE_UPPER

2023-06-27 Thread Kenneth Graunke
On Saturday, June 24, 2023 10:17:57 AM PDT Lucas De Marchi wrote: > The comment on the parameter being 0 to avoid the read back doesn't > apply as this is not a call to wa_mcr_add(), but rather to > wa_mcr_clr_set(). So, this register is actually checked and it's > according to the Bspec that the r

Re: [PATCH v2 3/6] drm/i915/gt: Fix context workarounds with non-masked regs

2023-06-27 Thread Kenneth Graunke
On Saturday, June 24, 2023 10:17:54 AM PDT Lucas De Marchi wrote: > Most of the context workarounds tweak masked registers, but not all. For > masked registers, when writing the value it's sufficient to just write > the wa->set_bits since that will take care of both the clr and set bits > as well a

Re: [PATCH v2 06/24] dma-buf: system_heap: use vmalloc_array and vcalloc

2023-06-27 Thread John Stultz
On Tue, Jun 27, 2023 at 7:44 AM Julia Lawall wrote: > > Use vmalloc_array and vcalloc to protect against > multiplication overflows. > > The changes were done using the following Coccinelle > semantic patch: > > // > @initialize:ocaml@ > @@ > > let rename alloc = > match alloc with > "vmall

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-27 Thread Marek Olšák
On Tue, Jun 27, 2023, 09:23 André Almeida wrote: > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/20230626183347.55118-1-andrealm...@i

Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug

2023-06-27 Thread Belgaumkar, Vinay
On 6/26/2023 11:43 PM, Dixit, Ashutosh wrote: On Mon, 26 Jun 2023 21:02:14 -0700, Belgaumkar, Vinay wrote: On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote: On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote: GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_li

[PATCH v2] drm/i915/guc: Dump perf_limit_reasons for debug

2023-06-27 Thread Vinay Belgaumkar
GuC load takes longer sometimes due to GT frequency not ramping up. Add perf_limit_reasons to the existing warn print to see if frequency is being throttled. v2: Review comments (Ashutosh) Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 8 +--- 1 file changed

[PATCH v2 00/15] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-06-27 Thread Marijn Suijten
Bring up the SM6125 DPU now that all preliminary series (such as INTF TE) have been merged (for me to test the hardware properly), and most other conflicting work (barring ongoing catalog *improvements*) has made its way in as well or is still being discussed. The second part of the series complem

[PATCH v2 04/15] dt-bindings: clock: qcom,dispcc-sm6125: Allow power-domains property

2023-06-27 Thread Marijn Suijten
On SM6125 the dispcc block is gated behind VDDCX: allow this domain to be configured. Acked-by: Krzysztof Kozlowski Signed-off-by: Marijn Suijten --- Documentation/devicetree/bindings/clock/qcom,dispcc-sm6125.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetr

[PATCH v2 05/15] dt-bindings: display/msm: dsi-controller-main: Document SM6125

2023-06-27 Thread Marijn Suijten
Document general compatibility of the DSI controller on SM6125. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Marijn Suijten --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/disp

  1   2   >