Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Geert and Javier Am 08.06.23 um 01:07 schrieb Javier Martinez Canillas: Geert Uytterhoeven writes: Hello Geert and Thomas, Hi Thomas, On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmerma

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

On 08/06/2023 19:26, Laurent Pinchart wrote: Hi Doug, On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: this patch series adapts the platform drivers below dri

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

Hi, On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > > Hello, > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > this patch series adapts the platform drivers below drivers/gpu/drm > > to use the .remove_new() callback. Compared to the traditional .remove() > > call

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

Hi Doug, On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > > this patch series adapts the platform drivers below drivers/gpu/drm > > > to use the .remove_

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

Hi, On Thu, Jun 8, 2023 at 10:19 AM Tomi Valkeinen wrote: > > On 08/06/2023 19:26, Laurent Pinchart wrote: > > Hi Doug, > > > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > >> On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > >>> On Sun, May 07, 2023 at 06:25:23PM +0200

[PULL] drm-misc-fixes, try 2.

Hi Dave, Daniel, Same pull request, just verifying tooling works as intended now. :-) drm-misc-fixes for v6.4-rc6. Seems to be mostly small fixes, just a few more for ivpu. ~Maarten drm-misc-fixes-2023-06-08: drm-misc-fixes for v6.4-rc6: - resume and modeset fixes for ast. - Fill in fb-helper

[PATCH] udmabuf: revert 'Add support for mapping hugepages (v4)'

This effectively reverts commit 16c243e99d33 ("udmabuf: Add support for mapping hugepages (v4)"). Recently, Junxiao Chang found a BUG with page map counting as described here [1]. This issue pointed out that the udmabuf driver was making direct use of subpages of hugetlb pages. This is not a goo

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

Hi, On Thu, Jun 8, 2023 at 9:26 AM Laurent Pinchart wrote: > > > The following ones appeared to apply to the top of drm-misc-next, but > > I didn't apply them since get_maintainer didn't say they were part of > > drm-misc-next: > > > > drm/tiny: Convert to platform remove callback returning void

Re: [PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files

Hi Sam, thanks for reviewing. Am 07.06.23 um 21:38 schrieb Sam Ravnborg: Hi Thomas, On Mon, Jun 05, 2023 at 04:48:07PM +0200, Thomas Zimmermann wrote: Move framebuffer and backlight helpers into separate files. Leave fbsysfs.c to sysfs-related code. No functional changes. The framebuffer hel

[PATCH V2 0/7] Support Wifi RFI interference mitigation feature

Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise th

[PATCH V2 1/7] drivers/acpi: Add support for Wifi band RF mitigations

From: Mario Limonciello Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced an

[PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

From: Mario Limonciello To support AMD's WBRF interference mitigation mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated APCI calls. So that, other drivers responding to the frequencies can take pr

[PATCH V2 3/7] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw_if/smu_v13_0_0_ppsmc.h | 3 +

[PATCH V2 4/7] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). To make WBRF feature functional, the kernel n

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Thomas, On Fri, Jun 9, 2023 at 9:09 AM Thomas Zimmermann wrote: > Am 08.06.23 um 01:07 schrieb Javier Martinez Canillas: > > Geert Uytterhoeven writes: > >> On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann > >> wrote: > >>> Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: > On Mon, Jun

[PATCH V2 5/7] drm/amd/pm: add flood detection for wbrf events

To protect PMFW from being overloaded. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 28 --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgp

[PATCH V2 6/7] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 + .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.

[PATCH V2 7/7] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Am 09.06.23 um 09:29 schrieb Geert Uytterhoeven: Hi Thomas, On Fri, Jun 9, 2023 at 9:09 AM Thomas Zimmermann wrote: Am 08.06.23 um 01:07 schrieb Javier Martinez Canillas: Geert Uytterhoeven writes: On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: Am 07.06.23 um 10:48 schrieb Ge

[PATCH][next] drm/connector: Fix spelling mistake "provded" -> "provided"

There are two spelling mistakes in drm_err messages. Fix them. Signed-off-by: Colin Ian King --- drivers/gpu/drm/drm_connector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 3ed4cfcb350c..63370c4a6

[RESEND 00/15] Rid W=1 warnings from GPU

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (15): drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train

[RESEND 01/15] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'blend' not described in 'zynqmp_disp' drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or member 'avbuf' not described in 'zynqmp_disp' drivers/gp

[RESEND 02/15] drm/xlnx/zynqmp_dp: Fix function name zynqmp_dp_link_train() -> zynqmp_dp_train()

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/xlnx/zynqmp_dp.c:793: warning: expecting prototype for zynqmp_dp_link_train(). Prototype was for zynqmp_dp_train() instead Cc: Hyun Kwon Cc: Laurent Pinchart Cc: David Airlie Cc: Daniel Vetter Cc: Michal Simek Cc: Philipp Zab

[RESEND 04/15] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal' drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'regs' not described in 'mtk_disp_aal' dri

[RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'regs' not described in 'mtk_disp_cco

[RESEND 03/15] drm/vkms/vkms_composer: Fix a few different kerneldoc formatting

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Function parameter or member 'frame_info' not described in 'pre_mul_alpha_blend' drivers/gpu/drm/vkms/vkms_composer.c:41: warning: Excess function parameter 'src_frame_info' description in 'pre_m

[RESEND 07/15] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function parameter or member 'init' not described in 'init_reserved' drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: warning: expecting prototype for INIT_DONE(). Prototype was f

[RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ‘nvkm_acr_lsfw_load_sig_image_desc_v2’: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ‘loc’ set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs Cc:

[RESEND 09/15] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: David Airlie Cc: Da

[RESEND 08/15] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:62: warning: This comment

[RESEND 10/15] drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block()

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous prototype for ‘tu102_gr_load’ [-Wmissing-prototypes] Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop

[RESEND 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/nouveau/dispnv04/crtc.c:629: warning: This comment starts with '/

[RESEND 14/15] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move()

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_ttm.c: In function ‘radeon_bo_move’: drivers/gpu/drm/radeon/radeon_ttm.c:201:27: warning: variable ‘rbo’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: D

[RESEND 11/15] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:48:22: warning: ‘SYNAPTICS_DEVICE_ID’ defined but not used [-Wunused-const-variable=] Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: "Christian König

[RESEND 15/15] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6

[RESEND 13/15] drm/nouveau/nvkm/engine/gr/tu102: Completely remove unused function ‘tu102_gr_load’

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: ‘tu102_gr_load’ defined but not used [-Wunused-function] Cc: Ben Skeggs Cc: Karol Herbst Cc: Lyude Paul Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc:

Re: [PATCH] drm/i915/dp: Cable type identification for DP2.1

On Fri, 09 Jun 2023, Animesh Manna wrote: > For DP alt mode display driver get the information > about cable speed and cable type through TCSS_DDI_STATUS > register which will be updated by type-c platform driver. > Accodingly Update dpcd 0x110 with cable information before > link training start.

Re: [RESEND 04/15] drm/mediatek/mtk_disp_aal: Remove half completed incorrect struct header

Il 09/06/23 10:17, Lee Jones ha scritto: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or member 'clk' not described in 'mtk_disp_aal' drivers/gpu/drm/mediatek/mtk_disp_aal.c:39: warning: Function parameter or membe

Re: [RESEND 05/15] drm/mediatek/mtk_disp_ccorr: Remove half completed incorrect struct header

Il 09/06/23 10:17, Lee Jones ha scritto: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or member 'clk' not described in 'mtk_disp_ccorr' drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:47: warning: Function parameter or

RE: [PATCH v4] drm/dp_mst: Clear MSG_RDY flag before sending new message

>> > bool *handled) >> > +int drm_dp_mst_hpd_irq_handle_event(struct drm_dp_mst_topology_mgr >> *mgr, const u8 *esi, >> > + u8 *ack, bool *handled) >> > { >> > int ret = 0; >> > int sc; >> > @@ -4078,18 +4089,47 @@ int drm_dp_mst_hpd_irq(struct >> drm_dp_mst_t

Re: [PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

On Fri, 2023-06-09 at 15:28 +0800, Evan Quan wrote: > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -5551,6 +5551,10 @@ struct wiphy { > > u16 hw_timestamp_max_peers; > > +#ifdef CONFIG_ACPI_WBRF > + bool wbrf_supported; > +#endif This should be in some private st

Re: [PATCH] drm/edid: Add quirk for OSVR HDK 2.0

On Thu, 08 Jun 2023, Ralph Campbell wrote: > The OSVR virtual reality headset HDK 2.0 uses a different EDID > vendor and device identifier than the HDK 1.1 - 1.4 headsets. > Add the HDK 2.0 vendor and device identifier to the quirks table so > that window managers do not try to display the desktop

Re: [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

On 8.06.2023 22:58, Rob Herring wrote: > On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: >> >> >> On 30.05.2023 14:26, Krzysztof Kozlowski wrote: >>> On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Thomas, On Fri, Jun 9, 2023 at 10:00 AM Thomas Zimmermann wrote: > Am 09.06.23 um 09:29 schrieb Geert Uytterhoeven: > > On Fri, Jun 9, 2023 at 9:09 AM Thomas Zimmermann > > wrote: > >> Am 08.06.23 um 01:07 schrieb Javier Martinez Canillas: > >>> Geert Uytterhoeven writes: > On Wed, Jun

RE: [PATCH v4] drm/dp_mst: Clear MSG_RDY flag before sending new message

[Public] > -Original Message- > From: Jani Nikula > Sent: Friday, June 9, 2023 4:53 PM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-...@lists.freedesktop.org > Cc: ly...@redhat.com; ville.syrj...@linux.intel.com; imre.d...@intel.com; > Wentland, Harry ; Zuo, Jerry > ; sta...@

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

On Thu, Jun 8, 2023 at 6:43 PM Doug Anderson wrote: > > Hi, > > On Thu, Jun 8, 2023 at 8:37 AM Benjamin Tissoires > wrote: > > > > > > On Jun 07 2023, Douglas Anderson wrote: > > > > > > As talked about in the patch ("drm/panel: Add a way for other devices > > > to follow panel state"), we really

Re: [PATCH] drm/sched: Add native dependency support to drm_sched

For context, the native dependency support is used in these as yet unsubmitted files: https://gitlab.freedesktop.org/sarah-walker-imgtec/powervr/-/blob/dev/v3/drivers/gpu/drm/imagination/pvr_job.c https://gitlab.freedesktop.org/sarah-walker-imgtec/powervr/-/blob/dev/v3/drivers/gpu/drm/imagination/p

Re: [PATCH 0/7] Secure display with new CRTC properties

On 2023/5/25 下午 04:50, Jani Nikula wrote: On Wed, 24 May 2023, Simon Ser wrote: On Tuesday, May 16th, 2023 at 07:39, Alan Liu wrote: To address this problem, since modern display control hardware is able to calculate the CRC checksum of the display content, we are thinking of a feature to

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Thomas Zimmermann writes: Hello Thomas, > Hi > [...] >>> I'd also question the argument that there's even fbdev userspace out >>> there. It was never popular in it's heyday and definitely hasn't >>> improved since then. Even the 3 people who still ask for fbdev support >> >> There's X.org, D

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

Hi Carl, > > > besides this, ask a dumb question. > > > How we retrieve the pat_index from a shared resource though dma_buf fd? > > > maybe we need to know whether it could be CPU cached if we want map it. > > > Of course, looks there are no real usage to access it though CPU. > > > Just use it di

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Javier, On Fri, Jun 9, 2023 at 11:59 AM Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > >>> I'd also question the argument that there's even fbdev userspace out > >>> there. It was never popular in it's heyday and definitely hasn't > >>> improved since then. Even the 3 people wh

Re: [PATCH][next] drm/connector: Fix spelling mistake "provded" -> "provided"

Reviewed-by: Simon Ser

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Geert Uytterhoeven writes: >> * fbdev drivers + DRM fbdev emulation + fbdev user-space > > "fbdev drivers + fbdev user-space", I assume? > Right, I meant to also include "only fbdev drivers + fbdev user-space" but forgot :) >> * only DRM drivers without fbdev emulation nor fbdev user-space (yo

[PATCH v4 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Sui Jingfeng --- include/linux/vgaarb.h | 30 +---

[PATCH v4 1/4] PCI/VGA: Use unsigned type for the io_state variable

The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type. Signed-off-by: Sui Jingfeng --- d

[PATCH v4 2/4] PCI/VGA: Deal only with VGA class devices

Deal only with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class != 0x0300) out. There no need to process the non-display PCI device. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 22 ++

[PATCH v4 3/4] PCI/VGA: Tidy up the code and comment format

This patch replaces the leading space with a tab and removes the double blank line, no functional change. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 108 - include/linux/vgaarb.h | 4 +- 2 files changed, 65 insertions(+), 47 deletions(-) d

[PATCH v5] drm/dp_mst: Clear MSG_RDY flag before sending new message

[Why] The sequence for collecting down_reply from source perspective should be: Request_n->repeat (get partial reply of Request_n->clear message ready flag to ack DPRX that the message is received) till all partial replies for Request_n are received->new Request_n+1. Now there is chance that drm_

Re: [PATCH v4 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

On Fri, 09 Jun 2023, Sui Jingfeng wrote: > Per Documentation/process/license-rules.rst, the SPDX MIT identifier is > equivalent to including the entire MIT license text from > LICENSES/preferred/MIT. > > Replace the MIT license text with the equivalent SPDX identifier. > > Signed-off-by: Sui Jingf

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Am 09.06.23 um 11:14 schrieb Geert Uytterhoeven: [...] What do you think low-end embedded devices with an out-of-tree[*] fbdev driver are using? And those do not count either. IIRC Android used to be built on top of fbdev devices. I'm not sure if they have moved to DRM by now. But embedde

Re: [PATCH v4 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

Hi, On 2023/6/9 18:58, Jani Nikula wrote: On Fri, 09 Jun 2023, Sui Jingfeng wrote: Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX ide

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Hi Thomas, On Fri, Jun 9, 2023 at 1:04 PM Thomas Zimmermann wrote: > Am 09.06.23 um 11:14 schrieb Geert Uytterhoeven: > [...] > > > >>> What do you think low-end embedded devices with an out-of-tree[*] > >>> fbdev driver are using? > >> > >> And those do not count either. IIRC Android used to be

[PATCH v5 2/4] PCI/VGA: Deal only with VGA class devices

Deal only with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function with pci_get_class(). Filter the non-PCI display device(pdev->class != 0x0300) out. There no need to process the non-display PCI device. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 22 ++

[PATCH v5 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

Per Documentation/process/license-rules.rst, the SPDX MIT identifier is equivalent to including the entire MIT license text from LICENSES/preferred/MIT. Replace the MIT license text with the equivalent SPDX identifier. Signed-off-by: Sui Jingfeng --- include/linux/vgaarb.h | 23 ++--

[PATCH v5 3/4] PCI/VGA: Tidy up the code and comment format

This patch replaces the leading space with a tab and removes the double blank line, no functional change. Signed-off-by: Sui Jingfeng --- drivers/pci/vgaarb.c | 108 - include/linux/vgaarb.h | 4 +- 2 files changed, 65 insertions(+), 47 deletions(-) d

[PATCH v5 1/4] PCI/VGA: Use unsigned type for the io_state variable

The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace the third argument of vga_str_to_iostate() function with the unsigned int * type. Signed-off-by: Sui Jingfeng --- d

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

Thomas Zimmermann writes: [...] >> >> So with FB_CORE, you can have default y if you have a real fbdev driver, >> and default n if you have only DRM drivers. >> All this discussion about FB_CORE is unrelated to your series though and that is covered by enabling CONFIG_FB_DEVICE. I think that

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

Hi Simon Am 02.03.23 um 15:35 schrieb Simon Ser: drm_gem_map_dma_buf() requires drm_gem_object_funcs.get_sg_table to be implemented, or else WARNs. Allow drivers to leave this hook unimplemented to implement purely local DMA-BUFs (ie, DMA-BUFs which cannot be imported anywhere else but the devi

Re: [PATCH v5 1/4] PCI/VGA: Use unsigned type for the io_state variable

Hi Sui, On Fri, Jun 09, 2023 at 07:24:14PM +0800, Sui Jingfeng wrote: > The io_state variable in the vga_arb_write() function is declared with > unsigned int type, while the vga_str_to_iostate() function takes int * > type. To keep them consistent, replace the third argument of > vga_str_to_iostat

Re: [RFC PATCH] drm/sched: Wait for the currently popped dependency in kill_jobs_cb()

Am 08.06.23 um 08:55 schrieb Boris Brezillon: If I understand correctly, drm_sched_entity_kill_jobs_cb() is supposed to wait on all the external dependencies (those added to drm_sched_job::dependencies) before signaling the job finished fence. This is done this way to prevent jobs depending on th

Re: [PATCH drm-next v4 00/14] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

On Wed, 2023-06-07 at 00:31 +0200, Danilo Krummrich wrote: > > Christian König (1): > drm: execution context for GEM buffers v4 > > Danilo Krummrich (13): > maple_tree: split up MA_STATE() macro > drm: manager to keep track of GPUs VA mappings I have tested the drm GPUVA manager as part of

Re: [PATCH v5 3/4] PCI/VGA: Tidy up the code and comment format

Hi Sui, On Fri, Jun 09, 2023 at 07:24:16PM +0800, Sui Jingfeng wrote: > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. You mainly fixed comment style, though and it's not written here. No need to resend for me as you also wrote it in t

Re: [PATCH v5 4/4] PCI/VGA: Replace full MIT license text with SPDX identifier

On Fri, Jun 09, 2023 at 07:24:17PM +0800, Sui Jingfeng wrote: > Per Documentation/process/license-rules.rst, the SPDX MIT identifier is > equivalent to including the entire MIT license text from > LICENSES/preferred/MIT. > > Replace the MIT license text with the equivalent SPDX identifier. > > Si

[PATCH] accel/habanalabs: add more debugfs stub helpers

From: Arnd Bergmann Two functions got added with normal prototypes for debugfs, but not alternative when building without it: drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_deb

Re: [RESEND 07/15] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:584: warning: Function > parameter or member 'init' not described in 'init_reserved' > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c:611: w

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Track buffer objects belonging to clients

On 09/06/2023 05:16, Iddamsetty, Aravind wrote: On 08-06-2023 20:21, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it o

Re: [RESEND 06/15] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc'

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function > ‘nvkm_acr_lsfw_load_sig_image_desc_v2’: > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable > ‘loc’ set

Re: [RESEND 08/15] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:49: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/gpu

Re: [PATCH] dma-fence: Bypass signaling annotation from dma_fence_is_signaled

On 09/06/2023 07:32, Christian König wrote: Am 08.06.23 um 16:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin For dma_fence_is_signaled signaling critical path annotations are an annoying cause of false positives when using dma_fence_is_signaled and indirectly higher level helpers such as dm

Re: [RESEND 10/15] drm/nouveau/nvkm/engine/gr/tu102: Staticify local function gf100_fifo_nonstall_block()

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/tu102.c:210:1: warning: no previous > prototype for ‘tu102_gr_load’ [-Wmissing-prototypes] > > Cc: Ben Skeggs > Cc: Karol Herbst > Cc: Lyude Paul >

Re: [RESEND 09/15] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:1044: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > > Cc: Ben Sk

Re: [RESEND 12/15] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses

On Fri, Jun 9, 2023 at 10:18 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/nouveau/dispnv04/crtc.c:453: warning: This comment starts > with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/gpu/drm/nou

[PATCH 1/8] dma-fence: Bypass signaling annotation from dma_fence_is_signaled

From: Tvrtko Ursulin For dma_fence_is_signaled signaling critical path annotations are an annoying cause of false positives when using dma_fence_is_signaled and indirectly higher level helpers such as dma_resv_test_signaled etc. Drop the critical path annotation since the "is signaled" API does

[PATCH v3 0/8] fdinfo memory stats

From: Tvrtko Ursulin I added tracking of most classes of objects which contribute to client's memory footprint and accouting along the similar lines as in Rob's msm code. Then printing it out to fdinfo using the drm helper Rob added. Accounting by keeping per client lists may not be the most eff

[PATCH 3/8] drm/i915: Record which clients own a VM

From: Tvrtko Ursulin To enable accounting of indirect client memory usage (such as page tables) in the following patch, lets start recording the creator of each PPGTT. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 --- drivers/gpu/drm/i915/gem

[PATCH 2/8] drm/i915: Track buffer objects belonging to clients

From: Tvrtko Ursulin In order to show per client memory usage lets start tracking which objects belong to which clients. We start with objects explicitly created by object creation UAPI and track it on a new per client lists, protected by a new per client lock. In order for delayed destruction (

[PATCH 5/8] drm/i915: Account ring buffer and context state storage

From: Tvrtko Ursulin Account ring buffers and logical context space against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 6 ++ drivers/gpu/drm/i915/i915_drm_client.c | 10 ++ drivers/gpu/drm/i915/i915_dr

[PATCH 4/8] drm/i915: Track page table backing store usage

From: Tvrtko Ursulin Account page table backing store against the owning client memory usage stats. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gtt.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/int

[PATCH 7/8] drm/i915: Track imported dma-buf objects in memory stats

From: Tvrtko Ursulin We want to be able to show memory usage of imported dma-buf opjects in the fdinfo stats. To achieve this we wrap drm_gem_prime_fd_to_handle(_obj) in i915_gem_prime_fd_to_handle and append some client management at the end. Signed-off-by: Tvrtko Ursulin Cc: Aravind Iddamset

[PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

From: Tvrtko Ursulin I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which will return a reference to a newly created GEM objects (if created), in order to enable tracking of imported i915 GEM objects in the following patch. Minor code reshuffule and only trivial additions on

[PATCH 8/8] drm/i915: Implement fdinfo memory stats printing

From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

Re: [Intel-gfx] [PATCH v3 3/4] PCI/VGA: only deal with VGA class devices

Hi, On 2023/6/9 03:12, Bjorn Helgaas wrote: Start with verb and capitalize to match ("Deal only with ...") On Thu, Jun 08, 2023 at 07:43:21PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng vgaarb only deal with the VGA devcie(pdev->class == 0x0300), so replace the pci_get_subsys() function wi

Re: [PATCH v5 1/4] PCI/VGA: Use unsigned type for the io_state variable

Hi, On 2023/6/9 19:48, Andi Shyti wrote: Hi Sui, On Fri, Jun 09, 2023 at 07:24:14PM +0800, Sui Jingfeng wrote: The io_state variable in the vga_arb_write() function is declared with unsigned int type, while the vga_str_to_iostate() function takes int * type. To keep them consistent, replace th

Re: [PATCH v5 3/4] PCI/VGA: Tidy up the code and comment format

Hi, On 2023/6/9 20:00, Andi Shyti wrote: Hi Sui, On Fri, Jun 09, 2023 at 07:24:16PM +0800, Sui Jingfeng wrote: This patch replaces the leading space with a tab and removes the double blank line, no functional change. You mainly fixed comment style, though and it's not written here. No need t

Re: [PATCH 6/8] drm: Add drm_gem_prime_fd_to_handle_obj

On 09-06-2023 17:41, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I need a new flavour of the drm_gem_prime_fd_to_handle helper, one which > will return a reference to a newly created GEM objects (if created), in > order to enable tracking of imported i915 GEM objects in the following > pa

Re: [PATCH 2/3] drm: Remove references to removed transitional helpers

On Fri, Jun 2, 2023 at 1:17 PM Geert Uytterhoeven wrote: > On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart > wrote: > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > The transitional helpers were removed a long time ago, but some > > > references stuck. Remove them. >

Re: [PATCH] dma-fence: Bypass signaling annotation from dma_fence_is_signaled

Am 09.06.23 um 14:09 schrieb Tvrtko Ursulin: On 09/06/2023 07:32, Christian König wrote: Am 08.06.23 um 16:30 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin For dma_fence_is_signaled signaling critical path annotations are an annoying cause of false positives when using dma_fence_is_signaled a

Re: [PATCH v2 1/2] drm/prime: reject DMA-BUF attach when get_sg_table is missing

Hi, On Friday, June 9th, 2023 at 13:31, Thomas Zimmermann wrote: > Is there a v3 of this patchset? It was Acked with the one errno code > changed. Since this was a minor change, I did it locally and pushed the patch to drm-misc-next already. Simon

Re: [PATCH v10 9/9] drm: Remove superfluous print statements in DRM core

On Wed, 07 Jun 2023 00:00:10 +0530, Siddh Raman Pant wrote: > There are a couple of superfluous print statements using the drm_* > macros, which do stuff like printing newlines, print OOM messages > (OOM while allocating memory is already supposed to be noisy), and > printing strings like "Initiali

Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

On 09/06/2023 15:06, Arnd Bergmann wrote: > From: Arnd Bergmann > > Two functions got added with normal prototypes for debugfs, but not > alternative when building without it: > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': > drivers/accel/habanalabs/common/device.c:217

  1   2   >