[PATCH v2 10/10] arm64: dts: qcom: sc7180: Link trogdor touchscreens to the panels

2023-06-07 Thread Douglas Anderson
Let's provide the proper link from the touchscreen to the panel on trogdor devices where the touchscreen support it. This allows the OS to power sequence the touchscreen more properly. For the most part, this is just expected to marginally improve power consumption while the screen is off. However

Re: [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-07 Thread Dmitry Baryshkov
On 08/06/2023 00:05, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features.  Properly utilizing all planes requires the attention of the compositor, who shoul

Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Detect registered instances of fb_info by reading the reference > counter from struct fb_info.read. Avoids looking at the dev field > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann > Cc: Steve Glendinning > --- > driv

Re: [PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the 3dfx hardware device from the Linux device hierarchy as > parent device of the i2c adapter. Aligns the driver with the rest > of the codebase and prepares fbdev for making struct fb_info.dev > optional. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by:

Re: [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-06-07 Thread Rob Herring
On Thu, Jun 01, 2023 at 03:12:27PM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Reviewed-by: Conor Dooley > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v6 > - Moved compatible t

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- [...] > + > +#include #include here, the robot complained about: drivers/video/fbdev/core/fb_devfs.

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, Jun 07, 2023 at 09:59:47PM +0200, Noralf Trønnes wrote: > > > On 6/7/23 13:55, Leonard Göhrs wrote: > > Some MIPI DBI panels support a three wire mode (clock, chip select, > > bidirectional data) that can be used to ask the panel if it is already set > > up by e.g. the bootloader and can

Re: [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:00 +0200, Leonard Göhrs wrote: > The Shineworld LH133K is a 1.3" 240x240px RGB LCD with a MIPI DBI > compatible SPI interface. > The initialization procedure is quite basic with the exception of > requiring inverted colors. > A basic mipi-dbi-cmd[1] script to get the dis

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:01 +0200, Leonard Göhrs wrote: > Some MIPI DBI panels support a three wire mode (clock, chip select, > bidirectional data) that can be used to ask the panel if it is already set > up by e.g. the bootloader and can thus skip the initialization. > This enables a flicker-fr

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert and Thomas, > Hi Thomas, > > On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: >> Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: >> > On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann >> > wrote: >> >> --- a/drivers/video/fbdev/Kconfig >> >> +++ b

Re: [PATCH v2 1/2] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-06-07 Thread Dmitry Baryshkov
On Sun, 04 Jun 2023 06:13:07 +0300, Dmitry Baryshkov wrote: > Currently the driver passes the PINGPONG index to > dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean > flag to tell whether INTF should be bound or unbound. Simplify this by > passing PINGPONG_NONE in case of unb

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 14:43:51 +0200, Konrad Dybcio wrote: > v5 -> v6: > - Drop unnecessary items: level in bindings > - Use INTF_SC7180_MASK for 6375 to avoid enabling DPU_INTF_DATA_COMPRESS on > DPU6 > - Pick up tags > > v5: > https://lore.kernel.org/r/20230411-topic-straitlagoon_mdss-v5-0-998

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 23:11, Kuogee Hsieh wrote: From: Abhinav Kumar Some platforms have DSC blocks which have not been declared in the catalog. Complete DSC 1.1 support for all platforms by adding the missing blocks to MSM8998. Changes in v9: -- add MSM8998 and SC8180x to commit title Changes in v10

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On 07/06/2023 17:42, Dan Carpenter wrote: On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( * frequency divided by the no. of rows (lines) in the LCDpanel. */ vsync_hz = dpu_kms_get_clk

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 11:33:03 +0300, Dan Carpenter wrote: > The "vsync_hz" variable is unsigned int so it can't be less > than zero. The dpu_kms_get_clk_rate() function used to return a u64 > but I previously changed it to return an unsigned long and zero on > error so it matches clk_get_rate().

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 13:11:12 -0700, Kuogee Hsieh wrote: > Some platforms have DSC blocks which have not been declared in the catalog. > Complete DSC 1.1 support for all platforms by adding the missing blocks to > MSM8998. > > Changes in v9: > -- add MSM8998 and SC8180x to commit title > > [...]

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 15:43, Konrad Dybcio wrote: [skipped the changelog] --- Konrad Dybcio (12): dt-bindings: display/msm: dsi-controller-main: Add SM6350 dt-bindings: display/msm: dsi-controller-main: Add SM6375 dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

Re: [v1] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-07 Thread Teres Alexis, Alan Previn
On Fri, 2023-06-02 at 11:52 -0700, Alan Previn wrote: > In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because > GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification > where all command formats are defined in units of dwords so that '1' > is a dword. Accordingly, GUC_CTB_MSG_MAX_LEN is 2

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread Andi Shyti
Hi Dong, On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed work > and intel_gt_reset. > Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync > version for reset path, it is safe as the w

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
On 2023/6/7 22:03, Doug Anderson wrote: Hi, On Tue, Jun 6, 2023 at 6:25 PM Su Hui wrote: Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c |

[PATCH v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b

[PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-07 Thread Sui Jingfeng
drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this two kconfig option, otherwise the driver failed to compile on platform without REGMAP_MMIO selected: ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined! make[1]: *** [scripts/M

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 20:19, Maxime Ripard wrote: On Wed, Jun 07, 2023 at 06:30:01PM +0800, Sui Jingfeng wrote: On 2023/6/7 17:36, Paul Cercueil wrote: Hi Sui, Le mercredi 07 juin 2023 à 13:30 +0800, Sui Jingfeng a écrit : The single map_noncoherent member of struct drm_gem_dma_object may not suff

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-07 Thread kernel test robot
rg/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230607144931.v2.8.Ib1a98309c455cd7e26b931c69993d4fba33bbe15%40changeid patch subject: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower config: arc-randconfig-r021-20230607 (https://download.0

Re: [PATCH] accel/ivpu: Use struct_size()

2023-06-07 Thread Stanislaw Gruszka
On Thu, Jun 01, 2023 at 05:58:48PM +0200, Marco Pagani wrote: > > On 2023-05-29 15:28, Christophe JAILLET wrote: > > Use struct_size() instead of hand-writing it. It is less verbose, more > > robust and more informative. > > > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Marco Pagani A

Re: [PATCH 5/5] accel/ivpu: Mark 64 kB contiguous areas as contiguous in PTEs

2023-06-07 Thread Stanislaw Gruszka
On Thu, May 18, 2023 at 08:17:02AM -0600, Jeffrey Hugo wrote: > On 5/18/2023 7:16 AM, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > Whenever KMD maps region larger than 64kB that is both aligned and > > contiguous, set contiguous bit (52) in MMU PTE descriptor for each page > > in th

Re: [PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

2023-06-07 Thread Stanislaw Gruszka
On Fri, Jun 02, 2023 at 11:30:31AM -0600, Jeffrey Hugo wrote: > On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: > > If we get signal when waiting for the mmu->lock we do not invalidate > > current MMU configuration what might result on undefined behavior. > > "that might result in" Fixed this and a

Re: [PATCH] accel/ivpu: Fix sporadic VPU boot failure

2023-06-07 Thread Stanislaw Gruszka
On Wed, Jun 07, 2023 at 11:45:02AM +0200, Stanislaw Gruszka wrote: > From: Andrzej Kacprowski > > Wait for AON bit in HOST_SS_CPR_RST_CLR to return 0 before > starting VPUIP power up sequence, otherwise the VPU device > may sporadically fail to boot. > > An error in power up sequence is propagat

[LINUX KERNEL PATCH 0/1] add S3 support for virtgpu

2023-06-07 Thread Jiqian Chen
Hi all, I am working to implement virtgpu S3 function on Xen. Currently on Xen, if we start a guest who enables virtgpu, and then run "echo mem > /sys/power/state" to suspend guest. And run "sudo xl trigger s3resume" to resume guest. We can find that the guest kernel comes back, but the display

[LINUX KERNEL PATCH 1/1] virtgpu: init vq during resume and notify qemu guest status

2023-06-07 Thread Jiqian Chen
This patch solves two problem: First, when we suspended guest VM, it called into Qemu to call virtio_reset->__virtio_queue_reset, this cleared all virtuqueue information of virtgpu on Qemu end. As a result, after guest resumed, guest sended ctrl/cursor requests to Qemu through virtqueue, but Qemu

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-07 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > Hi Wolfram, > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi all, > > > > sorry for not being able to chime in earlier. > > > > > In Biju's particular use case

Re: [PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

2023-06-07 Thread Stanislaw Gruszka
On Tue, Jun 06, 2023 at 08:50:52AM -0600, Jeffrey Hugo wrote: > On 6/6/2023 7:44 AM, Stanislaw Gruszka wrote: > > Hi > > > > On Fri, Jun 02, 2023 at 11:30:31AM -0600, Jeffrey Hugo wrote: > > > On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: > > > > If we get signal when waiting for the mmu->lock we

[RFC PATCH] drm/sched: Wait for the currently popped dependency in kill_jobs_cb()

2023-06-07 Thread Boris Brezillon
If I understand correctly, drm_sched_entity_kill_jobs_cb() is supposed to wait on all the external dependencies (those added to drm_sched_job::dependencies) before signaling the job finished fence. This is done this way to prevent jobs depending on these canceled jobs from considering the resources

<    1   2   3