[PATCH 0/5] drm/ssd130x: A few enhancements and cleanups

2023-06-05 Thread Javier Martinez Canillas
Hello, While working on adding support for the SSD132X family of 4-bit grayscale Solomon OLED panel controllers, I noticed a few things in the driver that can be improved and make extending to support other chip families easier. I've split the preparatory patches in this series and will post the

[PATCH 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-05 Thread Javier Martinez Canillas
A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 anymore. Instead is set to a width and height that's controller dependent. Update DT schema to reflect what the driver does and make its users aware. Signed-off-by: Javier Martinez Canillas --- .../devicetree/bindings/d

[PATCH 3/5] drm/ssd130x: Set the page height value in the device info data

2023-06-05 Thread Javier Martinez Canillas
The driver only supports OLED controllers that have a page height of 8 but there are devices that have different page heights. So it is better to not hardcode this value and instead have it as a per controller data value. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd13

[PATCH 1/5] drm/ssd130x: Make default width and height to be controller dependent

2023-06-05 Thread Javier Martinez Canillas
Currently the driver hardcodes the default values to 96x16 pixels but this default resolution depends on the controller. The datasheets for the chips describes the following display controller resolutions: - SH1106: 132 x 64 Dot Matrix OLED/PLED - SSD1306: 128 x 64 Dot Matrix OLED/PLED - SSD13

[PATCH 4/5] drm/ssd130x: Don't allocate buffers on each plane update

2023-06-05 Thread Javier Martinez Canillas
The resolutions for these panels are fixed and defined in the Device Tree, so there's no point to allocate the buffers on each plane update and that can just be done once. Let's do the allocation and free on the encoder enable and disable helpers since that's where others initialization and teardo

[PATCH 5/5] drm/ssd130x: Remove hardcoded bits-per-pixel in ssd130x_buf_alloc()

2023-06-05 Thread Javier Martinez Canillas
The driver only supports OLED controllers that have a native DRM_FORMAT_C1 pixel format and that is why it has harcoded a division of the width by 8. But the driver might be extended to support devices that have a different pixel format. So it's better to use the struct drm_format_info helpers to

Re: [PATCH v2 1/2] drm/bridge: imx: fix mixed module-builtin object

2023-06-05 Thread Ying Liu
On Sun, Jun 4, 2023 at 3:57 PM Masahiro Yamada wrote: > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice > versa), imx-ldb-helper.o is linked to a module and also to vmlinux > even though the expected CFLAGS are different between builtins and > modules. > > This is the same situa

Re: [PATCH v2 2/2] drm/bridge: imx: turn imx8{qm, qxp}-ldb into single-object modules

2023-06-05 Thread Ying Liu
On Sun, Jun 4, 2023 at 3:57 PM Masahiro Yamada wrote: > With the previous fix, these modules are built from a single C file. > > Rename the source files so they match the module names. > > Signed-off-by: Masahiro Yamada > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/imx/Makefile

Re: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-05 Thread Philipp Zabel
Hi Keith, On Fri, Jun 02, 2023 at 03:40:43PM +0800, Keith Zhao wrote: > Add HDMI dirver for StarFive SoC JH7110. > > Signed-off-by: Keith Zhao > --- > drivers/gpu/drm/verisilicon/Kconfig | 11 + > drivers/gpu/drm/verisilicon/Makefile| 1 + > drivers/gpu/drm/verisilicon/starfi

Re: [PATCH v2] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-05 Thread Christian König
Am 03.06.23 um 09:43 schrieb Min Li: Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free. Signed-off-by: Min Li Reviewed-by: Christian König --- Changes in v2: - Remove unused robj,

Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Tvrtko Ursulin
On 31/05/2023 18:10, fei.y...@intel.com wrote: From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 1/2] 2. add set_pat extension for gem_create [PATCH 2/2] v2: drop one patch that was merged separately commit 341ad0e8e254 ("dr

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Tvrtko Ursulin
On 31/05/2023 18:10, fei.y...@intel.com wrote: From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at o

Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Tvrtko Ursulin
On 05/06/2023 09:53, Tvrtko Ursulin wrote: On 31/05/2023 18:10, fei.y...@intel.com wrote: From: Fei Yang This series introduce a new extension for GEM_CREATE, 1. end support for set caching ioctl [PATCH 1/2] 2. add set_pat extension for gem_create [PATCH 2/2] v2: drop one patch that was me

Re: [PATCH 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-05 Thread Maxime Ripard
Hi, On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote: > A default resolution in the ssd130x driver isn't set to an arbitrary 96x16 > anymore. Instead is set to a width and height that's controller dependent. > > Update DT schema to reflect what the driver does and make its

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-05 Thread Wolfram Sang
> Wolfram: time to chime in ;-) I'll have a look this week. signature.asc Description: PGP signature

Re: [PATCH] video: fbdev: omapfb: lcd_mipid: Fix an error handling path in mipid_spi_probe()

2023-06-05 Thread Helge Deller
On 6/4/23 17:42, Christophe JAILLET wrote: If 'mipid_detect()' fails, we must free 'md' to avoid a memory leak. Fixes: 66d2f99d0bb5 ("omapfb: add support for MIPI-DCS compatible LCDs") Signed-off-by: Christophe JAILLET applied. Thanks! Helge --- drivers/video/fbdev/omap/lcd_mipid.c | 6 +

Re: [PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-05 Thread Maxime Ripard
Hi, On Fri, Jun 02, 2023 at 03:40:43PM +0800, Keith Zhao wrote: > Add HDMI dirver for StarFive SoC JH7110. > > Signed-off-by: Keith Zhao I have a few high level comments: > +static int starfive_hdmi_setup(struct starfive_hdmi *hdmi, > +struct drm_display_mode *mode)

Re: [PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

2023-06-05 Thread Johan Hovold
[ +CC: Thorsten and regzbot so they can help with tracking this regression ] #regzbot introduced: v6.3..v6.4-rc1 On Tue, May 23, 2023 at 05:16:46PM +0200, Johan Hovold wrote: > This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c988e3. > > PSR support clearly is not ready for mainline and spe

Re: [PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

2023-06-05 Thread Dmitry Baryshkov
On Mon, 5 Jun 2023 at 13:02, Johan Hovold wrote: > > [ +CC: Thorsten and regzbot so they can help with tracking this > regression ] > > #regzbot introduced: v6.3..v6.4-rc1 > > On Tue, May 23, 2023 at 05:16:46PM +0200, Johan Hovold wrote: > > This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c9

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-06-05 Thread Arseniy Krasnov
Hello all guys! Sorry, ping, FYI there is v4: https://lore.kernel.org/linux-mtd/20230523101637.3009746-1-avkras...@sberdevices.ru/ Thanks, Arseniy On 25.05.2023 10:02, Arseniy Krasnov wrote: > > > On 24.05.2023 10:13, Arseniy Krasnov wrote: >> >> >> On 24.05.2023 09:33, liao jaime wrote: >>> H

Re: [PATCH 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values

2023-06-05 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, Thanks for your feedback. > Hi, > > On Mon, Jun 05, 2023 at 09:47:50AM +0200, Javier Martinez Canillas wrote: [...] >>solomon,width: >> $ref: /schemas/types.yaml#/definitions/uint32 >> -default: 96 >> description: >> - Width in pixel

Re: [PATCH] Revert "drm/msm/dp: set self refresh aware based on PSR support"

2023-06-05 Thread Johan Hovold
On Mon, Jun 05, 2023 at 01:05:36PM +0300, Dmitry Baryshkov wrote: > On Mon, 5 Jun 2023 at 13:02, Johan Hovold wrote: > > Virtual terminals are still broken with 6.4-rc5 on the Lenovo ThinkPad > > X13s two weeks after I reported this, and there has been no indication > > of any progress in the oth

Re: [PATCH v2] drm/nouveau: don't detect DSM for non-NVIDIA device

2023-06-05 Thread Karol Herbst
On Tue, May 23, 2023 at 11:12 PM Ratchanan Srirattanamet wrote: > > The call site of nouveau_dsm_pci_probe() uses single set of output > variables for all invocations. So, we must not write anything to them > unless it's an NVIDIA device. Otherwise, if we are called with another > device after the

Re: Build regressions/improvements in v6.4-rc5

2023-06-05 Thread Geert Uytterhoeven
On Mon, 5 Jun 2023, Geert Uytterhoeven wrote: JFYI, when comparing v6.4-rc5[1] to v6.4-rc4[3], the summaries are: - build errors: +2/-4 arm64-gcc5/arm64-allmodconfig (seen before) [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9561de3a55bed6bdd44a12820ba81ec416e705a7/ (151 out o

[PATCH] drm/amdkfd: mark som eclear_address_watch() callback static

2023-06-05 Thread Arnd Bergmann
From: Arnd Bergmann Some of the newly introduced clear_address_watch callback handlers have no prototype because they are only used in one file, which causes a W=1 warning: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c:164:10: error: no previous prototype for 'kgd_gfx_aldebaran_clear_add

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-06-05 Thread Thorsten Leemhuis
On 17.05.23 17:15, Linux regression tracking (Thorsten Leemhuis) wrote: > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting > for once, to make this easily accessible to everyone. > > Dmitry, was any progress made to address this regression? Doesn't look > like it, but I strong

[PATCH v3 1/2] drm/bridge: imx: fix mixed module-builtin object

2023-06-05 Thread Masahiro Yamada
With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice versa), imx-ldb-helper.o is linked to a module and also to vmlinux even though the expected CFLAGS are different between builtins and modules. This is the same situation as fixed by commit 637a642f5ca5 ("zstd: Fixing mixed module-b

[PATCH v3 2/2] drm/bridge: imx: turn imx8{qm, qxp}-ldb into single-object modules

2023-06-05 Thread Masahiro Yamada
With the previous fix, these modules are built from a single C file. Rename the source files so they match the module names. Signed-off-by: Masahiro Yamada Reviewed-by: Laurent Pinchart Reviewed-by: Liu Ying --- (no changes since v1) drivers/gpu/drm/bridge/imx/Makefile

Re: [PATCH v2 0/6] Add display support on the stm32f746-disco board

2023-06-05 Thread Raphael Gallais-Pou
Hi Dario, Thanks for this serie. I'll look at it shortly. In the meantime, would it be possible to send it again as I think it is not complete. patchwork and lore.kernel.org both prompt incomplete parts of your serie. https://patchwork.freedesktop.org/series/118814/?_sm_au_=iVVrkQQkv5r1r0rQcLp

[PATCH] drm/i915: Use the fdinfo helper

2023-06-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the common fdinfo helper for printing the basics. Remove now unused client id allocation code. Signed-off-by: Tvrtko Ursulin Cc: Rob Clark --- drivers/gpu/drm/i915/i915_driver.c | 6 +-- drivers/gpu/drm/i915/i915_drm_client.c | 65 -- driv

[PATCH] drm/i915/selftests: Add some missing error propagation

2023-06-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add some missing error propagation in live_parallel_switch. To avoid needlessly burdening the various backport processes, note I am not marking it as a fix against any patches and not copying stable since it is debug/selftests only code. Signed-off-by: Tvrtko Ursulin Repor

Re: [PATCH] drm/i915/selftests: Add some missing error propagation

2023-06-05 Thread Dan Carpenter
On Mon, Jun 05, 2023 at 02:11:35PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add some missing error propagation in live_parallel_switch. > > To avoid needlessly burdening the various backport processes, note I am > not marking it as a fix against any patches and not copying stable

Re: [PATCH v3 1/3] drm/msm/adreno: Add Adreno A690 support

2023-06-05 Thread Rob Clark
On Tue, May 30, 2023 at 8:09 PM Bjorn Andersson wrote: > > From: Bjorn Andersson > > Introduce support for the Adreno A690, found in Qualcomm SC8280XP. > > Tested-by: Steev Klimaszewski > Reviewed-by: Konrad Dybcio > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Ch

Re: [PATCH] drm/i915/selftests: Add some missing error propagation

2023-06-05 Thread Andi Shyti
Hi Tvrtko, > Add some missing error propagation in live_parallel_switch. > > To avoid needlessly burdening the various backport processes, note I am > not marking it as a fix against any patches and not copying stable since > it is debug/selftests only code. which I did :/ But I guess you are r

Re: [PATCH v3 1/2] drm/bridge: imx: fix mixed module-builtin object

2023-06-05 Thread rfoss
From: Robert Foss On Mon, 5 Jun 2023 21:00:20 +0900, Masahiro Yamada wrote: > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice > versa), imx-ldb-helper.o is linked to a module and also to vmlinux > even though the expected CFLAGS are different between builtins and > modules. >

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Alex Deucher
On Sat, Jun 3, 2023 at 10:52 AM Felix Richter wrote: > > Hi Guys, > > sorry for the silence from my side. I had a lot of things to take care > of after returning from vacation. Also I had to wait on the zfs modules > to be updated to support kernel 6.3 for further testing. > > The bad news is that

[PULL] drm-intel-next

2023-06-05 Thread Jani Nikula
Hi Dave & Daniel - Due to miscommunication (mea culpa) there was no earlier drm-intel-next pull request for v6.5, so this is the first one and therefore quite big. Sorry about that. (But hey, if there's going to be another pull request, it'll be tiny! ;) This round, Meteorlake display enabling

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Paulo Pavacic
Hello Conor, pet, 19. svi 2023. u 18:41 Conor Dooley napisao je: > > Hey Paulo, > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > > > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > > DCS initiali

[PATCH] drm/i915: Implement fdinfo memory stats printing

2023-06-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the newly added drm_print_memory_stats helper to show memory utilisation of our objects in drm/driver specific fdinfo output. To collect the stats we walk the per memory regions object lists and accumulate object size into the respective drm_memory_stats categories. Obj

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Conor Dooley
On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote: > Hello Conor, > > pet, 19. svi 2023. u 18:41 Conor Dooley napisao je: > > > > Hey Paulo, > > > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavacic wrote: > > > > > > Added fannal to vendor-prefixes and dt bindings for Fannal C3

[PATCH 04/30] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup

2023-06-05 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/aty/atyfb_base.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --g

[PATCH 00/30] fbdev: Make userspace interfaces optional

2023-06-05 Thread Thomas Zimmermann
Add the new config option FB_DEVICE. If enabled, fbdev provides traditional userspace interfaces in devfs, sysfs and procfs, such as /dev/fb0 or /proc/fb. Modern Linux distrobutions have adopted DRM drivers for graphics output and use fbdev only for the kernel's framebuffer console. Userspace has

[PATCH 09/30] fbdev/ep93xx-fb: Alloc DMA memory from hardware device

2023-06-05 Thread Thomas Zimmermann
Pass the hardware device to the DMA helpers dma_alloc_wc(), dma_mmap_wc() and dma_free_coherent(). The fbdev device that is currently being used is a software device and does not provide DMA memory. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/ep93xx-fb.c | 8 1 file changed

[PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

2023-06-05 Thread Thomas Zimmermann
Struct gpio_backlight_platform_data refers to a platform device within the Linux device hierarchy. The test in gpio_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight

[PATCH 07/30] fbdev/aty128fb: Use hardware device as backlight parent

2023-06-05 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/aty/aty128fb.c | 2 +- 1 file changed, 1 inserti

[PATCH 03/30] backlight/lv5207lp: Compare against struct fb_info.device

2023-06-05 Thread Thomas Zimmermann
Struct lv5207lp_platform_data refers to a platform device within the Linux device hierarchy. The test in lv5207lp_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight dr

[PATCH 21/30] fbdev/sm501fb: Output message with fb_err()

2023-06-05 Thread Thomas Zimmermann
Fix case were dev_err() is being called with struct fb_info.dev. Use fb_err() instead. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/sm501fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c index e0d29b

[PATCH 14/30] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup

2023-06-05 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas --- drivers/video/fbdev/nvidia/nvidia.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH 12/30] fbdev/mb862xxfb: Output messages with fb_dbg() and fb_err()

2023-06-05 Thread Thomas Zimmermann
Fix cases were output helpers are called with struct fb_info.dev. Use fb_dbg() and fb_err() instead. Prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

[PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent

2023-06-05 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Benjamin Herrenschmidt --- drivers/video/fbdev/aty/radeon_backlight.c |

[PATCH 16/30] fbdev/pxa168fb: Do not assign to struct fb_info.dev

2023-06-05 Thread Thomas Zimmermann
Do not assign the hardware device to struct fb_info.dev. The field references the fbdev software device, which is unrelated. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/pxa168fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/pxa168fb.c b/dr

[PATCH 06/30] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup

2023-06-05 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/aty/aty128fb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dri

[PATCH 17/30] fbdev/radeonfb: Reorder backlight and framebuffer cleanup

2023-06-05 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the cleanup calls for both data structures. The init calls are already in the correct order. Signed-off-by: Thomas Zimmermann Cc: Benjamin Herrenschmidt --- drivers/video/fbdev/aty/radeon_base.c | 3 +-- 1

[PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

2023-06-05 Thread Thomas Zimmermann
Use the 3dfx hardware device from the Linux device hierarchy as parent device of the i2c adapter. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/tdfxfb.c | 4 ++-- 1 file changed,

[PATCH 10/30] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err()

2023-06-05 Thread Thomas Zimmermann
Fix cases were output helpers are called with struct fb_info.dev. Use fb_info() and fb_err() instead. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/ep93xx-fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/ep93xx-fb.c b/drivers/vi

[PATCH 15/30] fbdev/nvidiafb: Use hardware device as backlight parent

2023-06-05 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas --- drivers/video/fbdev/nvidia/nv_backlight.c | 2 +

[PATCH 05/30] fbdev/atyfb: Use hardware device as backlight parent

2023-06-05 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/aty/atyfb_base.c | 2 +- 1 file changed, 1 inser

[PATCH 13/30] fbdev/metronomefb: Use hardware device for dev_err()

2023-06-05 Thread Thomas Zimmermann
Replace the use of the fbdev software device, stored in struct fb_info.dev, with the hardware device from struct fb_info.device in load_waveform(). The device is only used for printing errors with dev_err(). This change aligns load_waveform() with the rest of the driver and prepares fbdev for maki

[PATCH 29/30] fbdev/core: Rework fb init code

2023-06-05 Thread Thomas Zimmermann
Init the class "graphics" before the rest of fbdev. Later steps, such as the sysfs code, depend on the class. Also arrange the module's exit code in reverse order. Unexport the global variable fb_class, which is only shared internally within the fbdev core module. Signed-off-by: Thomas Zimmermann

[PATCH 08/30] fbdev/broadsheetfb: Call device_remove_file() with hardware device

2023-06-05 Thread Thomas Zimmermann
Call device_remove_file() with the same device that has been used for device_create_file(), which is the hardware device stored in struct fb_info.device. Prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/broadsheetfb.c | 2 +- 1 file

[PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-05 Thread Thomas Zimmermann
Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev device optional. If the new option has not been selected, fbdev does not create a files in devfs or sysfs. Most modern Linux systems run a DRM-based graphics stack that uses the kernel's framebuffer console, but has otherwise deprecate

[PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device

2023-06-05 Thread Thomas Zimmermann
Struct bd6107_platform_data refers to a platform device within the Linux device hierarchy. The test in bd6107_backlight_check_fb() compares it against the fbdev device in struct fb_info.dev, which is different. Fix the test by comparing to struct fb_info.device. Fixes a bug in the backlight driver

[PATCH 19/30] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup

2023-06-05 Thread Thomas Zimmermann
The driver's backlight code requires the framebuffer to be registered. Therefore reorder the init and cleanup calls for both data structures. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas --- drivers/video/fbdev/riva/fbdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 26/30] fbdev/core: Add fb_device_{create,destroy}()

2023-06-05 Thread Thomas Zimmermann
Move the logic to create and destroy fbdev devices into the new helpers fb_device_create() and fb_device_destroy(). There was a call to fb_cleanup_device() in do_unregister_framebuffer() that was too late. The device had already been removed at this point. Move the call into fb_device_destroy().

[PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-05 Thread Thomas Zimmermann
Detect registered instances of fb_info by reading the reference counter from struct fb_info.read. Avoids looking at the dev field and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Steve Glendinning --- drivers/video/fbdev/smscufx.c | 4 ++-- 1 file

[PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files

2023-06-05 Thread Thomas Zimmermann
Move framebuffer and backlight helpers into separate files. Leave fbsysfs.c to sysfs-related code. No functional changes. The framebuffer helpers are not in fbmem.c because they are under GPL-2.0-or-later copyright, while fbmem.c is GPL-2.0. Signed-off-by: Thomas Zimmermann --- drivers/video/fb

[PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

2023-06-05 Thread Thomas Zimmermann
Do not assing the Linux device to struct fb_info.dev. The call to register_framebuffer() initializes the field to the fbdev device. Drivers should not override its value. Fixes a bug where the driver incorrectly decreases the hardware device's reference counter and leaks the fbdev device. Signed-

[PATCH 20/30] fbdev/rivafb: Use hardware device as backlight parent

2023-06-05 Thread Thomas Zimmermann
Use the hardware device in struct fb_info.device as parent of the backlight device. Aligns the driver with the rest of the codebase and prepares fbdev for making struct fb_info.dev optional. Signed-off-by: Thomas Zimmermann Cc: Antonino Daplas --- drivers/video/fbdev/riva/fbdev.c | 2 +- 1 file

[PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-05 Thread Thomas Zimmermann
Move fbdev's file-I/O code into a separate file and contain it in init and cleanup helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/Makefile | 1 + drivers/video/fbdev/core/fb_devfs.c| 484 + drivers/video/fbdev/core

[PATCH 24/30] fbdev/core: Pass Linux device to pm_vt_switch_*() functions

2023-06-05 Thread Thomas Zimmermann
Pass the Linux device to pm_vt_switch_*() instead of the virtual fbdev device. Prepares fbdev for making struct fb_info.dev optional. The type of device that is passed to the PM functions does not matter much. It is only a token within the internal list of known devices. The PM functions do not re

[PATCH 27/30] fbdev/core: Move procfs code to separate file

2023-06-05 Thread Thomas Zimmermann
Move fbdev's procfs code into a separate file and contain it in init and cleanup helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/Makefile | 1 + drivers/video/fbdev/core/fb_internal.h | 12 - drivers/video/fbdev/core/fb_procfs.c | 62

Re: [PATCH] drm/i915/selftests: Add some missing error propagation

2023-06-05 Thread Tvrtko Ursulin
On 05/06/2023 14:43, Dan Carpenter wrote: On Mon, Jun 05, 2023 at 02:11:35PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add some missing error propagation in live_parallel_switch. To avoid needlessly burdening the various backport processes, note I am not marking it as a fix against

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Paulo Pavacic
Hello Conor, pon, 5. lip 2023. u 16:43 Conor Dooley napisao je: > > On Mon, Jun 05, 2023 at 04:33:15PM +0200, Paulo Pavacic wrote: > > Hello Conor, > > > > pet, 19. svi 2023. u 18:41 Conor Dooley napisao je: > > > > > > Hey Paulo, > > > > > > On Fri, May 19, 2023 at 04:24:55PM +0200, Paulo Pavac

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-05 Thread Greg KH
On Mon, Jun 05, 2023 at 04:48:12PM +0200, Thomas Zimmermann wrote: > Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev > device optional. If the new option has not been selected, fbdev > does not create a files in devfs or sysfs. > > Most modern Linux systems run a DRM-based graphics

Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Andi Shyti
On Mon, Jun 05, 2023 at 10:16:22AM +0100, Tvrtko Ursulin wrote: > > On 05/06/2023 09:53, Tvrtko Ursulin wrote: > > > > On 31/05/2023 18:10, fei.y...@intel.com wrote: > > > From: Fei Yang > > > > > > This series introduce a new extension for GEM_CREATE, > > > 1. end support for set caching ioctl

Re: [PATCH 1/2] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Conor Dooley
On Mon, Jun 05, 2023 at 04:56:13PM +0200, Paulo Pavacic wrote: > Hello Conor, > > pon, 5. lip 2023. u 16:43 Conor Dooley napisao je: > Sorry this is my first patch, I still don't understand, why should I > add `maxItems: 1` to the 'reg:' ? > Isn't part of the code: > > required: > > - compati

Re: [Intel-gfx] [PATCH v15 0/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Yang, Fei
> On 05/06/2023 09:53, Tvrtko Ursulin wrote: >> On 31/05/2023 18:10, fei.y...@intel.com wrote: >>> From: Fei Yang >>> >>> This series introduce a new extension for GEM_CREATE, >>> 1. end support for set caching ioctl [PATCH 1/2] >>> 2. add set_pat extension for gem_create [PATCH 2/2] >>> >>> v2: d

Re: [PATCH v2] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-05 Thread Alex Deucher
Applied. Thanks! On Mon, Jun 5, 2023 at 4:13 AM Christian König wrote: > > Am 03.06.23 um 09:43 schrieb Min Li: > > Userspace can race to free the gobj(robj converted from), robj should not > > be accessed again after drm_gem_object_put, otherwith it will result in > > use-after-free. > > > > Si

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-05 Thread Hamza Mahfooz
On 6/3/23 10:52, Felix Richter wrote: Hi Guys, sorry for the silence from my side. I had a lot of things to take care of after returning from vacation. Also I had to wait on the zfs modules to be updated to support kernel 6.3 for further testing. The bad news is that I am still experiencin

RE: [PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Deucher, Alexander
[AMD Official Use Only - General] > -Original Message- > From: Paul Menzel > Sent: Monday, June 5, 2023 11:23 AM > To: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; David > Airlie ; Daniel Vetter > Cc: Paul Menzel ; amd-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.

[PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Paul Menzel
Since there is overlap in supported devices, both modules load, but only one will bind to a particular device depending on the model and user's configuration. amdgpu binds to all display class devices with VID 0x1002 and then determines whether or not to bind to a device based on whether the indiv

[PATCH v2 0/3] drm/panel: add fannal c3004 panel

2023-06-05 Thread Paulo Pavacic
Fannal C3004 is a 2 lane MIPI DSI 480x800 panel which requires initialization with DSI DCS commands. After few initialization commands delay is required. Paulo Pavacic (3): dt-bindings: add fannal vendor prefix dt-bindings: display: panel: add fannal,c3004 drm/panel-fannal-c3003: Add fannal

[PATCH v2 1/3] dt-bindings: add fannal vendor prefix

2023-06-05 Thread Paulo Pavacic
Fannal is a one-stop-solution provider for touch displays in industrial application, committed to delivering a variety of professional high-quality products and technical services globally. Website: www.fannal.com Signed-off-by: Paulo Pavacic --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH v2 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-05 Thread Paulo Pavacic
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands. Signed-off-by: Paulo Pavacic --- v4 changelog: - add spaces between properties v3 changelog: - r

[PATCH v2 3/3] drm/panel-fannal-c3003: Add fannal c3004 DSI panel

2023-06-05 Thread Paulo Pavacic
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences. Signed-off-by: Paulo Pavacic --- v3 changelog: - using generic mipi_dsi_dcs_write_seq - removed success prints - removed some comments - simplified code/removed support for different panels - changed

Re: [PATCH v5 00/12] SM63(50|75) DPU support

2023-06-05 Thread Will Deacon
On Thu, Jun 01, 2023 at 03:16:52AM +0300, Dmitry Baryshkov wrote: > On 23/05/2023 10:46, Konrad Dybcio wrote: > > [skipped the changelog] > > > --- > > Konrad Dybcio (12): > >dt-bindings: display/msm: dsi-controller-main: Add SM6350 > >dt-bindings: display/msm: dsi-controller-main

Re: [PATCH v5 00/12] SM63(50|75) DPU support

2023-06-05 Thread Dmitry Baryshkov
On Mon, 5 Jun 2023 at 18:43, Will Deacon wrote: > > On Thu, Jun 01, 2023 at 03:16:52AM +0300, Dmitry Baryshkov wrote: > > On 23/05/2023 10:46, Konrad Dybcio wrote: > > > > [skipped the changelog] > > > > > --- > > > Konrad Dybcio (12): > > >dt-bindings: display/msm: dsi-controller-main: Ad

Re: [RESUBMIT][PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-05 Thread Janusz Krzysztofik
(fixed misspelled Cc: email address of intel-gfx list) On Friday, 2 June 2023 16:53:30 CEST Juergen Gross wrote: > On 02.06.23 16:48, Juergen Gross wrote: > > On 02.06.23 16:43, Borislav Petkov wrote: > >> On Thu, Jun 01, 2023 at 10:47:39AM +0200, Juergen Gross wrote: > >>> As described in the com

[linux-next:master] BUILD REGRESSION 9ca10bfb8aa8fbf19ee22e702c8cf9b66ea73a54

2023-06-05 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9ca10bfb8aa8fbf19ee22e702c8cf9b66ea73a54 Add linux-next specific files for 20230605 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202305070840.x0g3ofjl-...@intel.com https

Re: [PATCH] drm/amdgpu: fix xclk freq on CHIP_STONEY

2023-06-05 Thread Alex Deucher
Applied. Thanks! On Fri, Jun 2, 2023 at 11:13 PM Chia-I Wu wrote: > > On Fri, Jun 2, 2023 at 11:50 AM Alex Deucher wrote: > > > > Nevermind, missing your Signed-off-by. Please add and I'll apply. > Sorry that I keep forgetting... This patch is > > Signed-off-by: Chia-I Wu > > I can send v2

Re: [PATCH v1 1/1] backlight: hx8357: Convert to agnostic GPIO API

2023-06-05 Thread Andy Shevchenko
On Mon, Mar 20, 2023 at 01:54:26PM +0200, Andy Shevchenko wrote: > On Fri, Mar 17, 2023 at 09:53:40PM +0100, Linus Walleij wrote: > > On Fri, Mar 17, 2023 at 7:51 PM Andy Shevchenko > > wrote: > > > > > The of_gpio.h is going to be removed. In preparation of that convert > > > the driver to the a

RE: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 ttm_bo_release+0x27e/0x2d0 [ttm]

2023-06-05 Thread Deucher, Alexander
[Public] + Christian > -Original Message- > From: Borislav Petkov > Sent: Saturday, June 3, 2023 1:48 PM > To: amd-...@lists.freedesktop.org > Cc: Deucher, Alexander ; dri- > de...@lists.freedesktop.org; lkml > Subject: WARNING: CPU: 5 PID: 1464 at drivers/gpu/drm/ttm/ttm_bo.c:326 > ttm

Re: [Intel-gfx] [PATCH v15 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-05 Thread Yang, Fei
> On 31/05/2023 18:10, fei.y...@intel.com wrote: >> From: Fei Yang >> >> To comply with the design that buffer objects shall have immutable >> cache setting through out their life cycle, {set, get}_caching ioctl's >> are no longer supported from MTL onward. With that change caching >> policy can o

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-05 Thread Alex Deucher
Adding the relevant AMD folks for RAS. We currently expose RAS via sysfs, but also have an event interface in KFD which may be somewhat similar to this. If we were to converge on a common RAS interface, would we want to look at any commonality in bad page storage/reporting for device memory? Ale

Re: [PATCH v1] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-05 Thread Matthew Brost
On Fri, Jun 02, 2023 at 11:52:13AM -0700, Alan Previn wrote: > In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because > GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification > where all command formats are defined in units of dwords so that '1' > is a dword. Accordingly, GUC_CTB_MSG_MAX_L

Re: [PATCH] drm/amdkfd: mark som eclear_address_watch() callback static

2023-06-05 Thread Alex Deucher
On Mon, Jun 5, 2023 at 6:58 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Some of the newly introduced clear_address_watch callback handlers have > no prototype because they are only used in one file, which causes a W=1 > warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_aldebaran.c:164

Re: [PATCH v5 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-06-05 Thread Konrad Dybcio
On 4.06.2023 20:04, Krzysztof Kozlowski wrote: > On 23/05/2023 09:46, Konrad Dybcio wrote: >> Document the SM6375 MDSS. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 >> + >> 1 file changed, 216 insertions(+) >> >> di

Re: [PATCH v5 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-06-05 Thread Dmitry Baryshkov
On Mon, 5 Jun 2023 at 20:01, Konrad Dybcio wrote: > > > > On 4.06.2023 20:04, Krzysztof Kozlowski wrote: > > On 23/05/2023 09:46, Konrad Dybcio wrote: > >> Document the SM6375 MDSS. > >> > >> Signed-off-by: Konrad Dybcio > >> --- > >> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 > >

Re: [Intel-xe] [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-05 Thread Iddamsetty, Aravind
On 04-06-2023 22:37, Tomer Tayar wrote: > On 26/05/2023 19:20, Aravind Iddamsetty wrote: >> Our hardware supports RAS(Reliability, Availability, Serviceability) by >> exposing a set of error counters which can be used by observability >> tools to take corrective actions or repairs. Traditionally

Re: [Intel-xe] [RFC 1/5] drm/netlink: Add netlink infrastructure

2023-06-05 Thread Iddamsetty, Aravind
On 04-06-2023 22:37, Tomer Tayar wrote: > On 26/05/2023 19:20, Aravind Iddamsetty wrote: >> Define the netlink commands and attributes that can be commonly used >> across by drm drivers. >> >> Signed-off-by: Aravind Iddamsetty >> --- >> include/uapi/drm/drm_netlink.h | 68

  1   2   >