[PATCH 5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel

2023-06-02 Thread Dario Binacchi
Add support for Rocktech RK043FN48H 4.3" (480x272) LCD-TFT panel. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c

[PATCH 5.4/5.10 0/1] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2023-06-02 Thread Fedor Pchelkin
general protection fault in drm_mode_object_put() is hit on 5.4/5.10 if drm_property_create_blob() fails for some reason and state->mode_blob is assigned an error pointer which is not treated correctly in some places as mentioned in patch description. The following patch fixes the issue and can be

[PATCH 0/6] Add display support on the stm32f746-disco board

2023-06-02 Thread Dario Binacchi
The series adds support for the display on the stm32f746-disco board, along with a generic patch that adds the "bpp" parameter to the stm-drm module. The intention is to allow users to size, within certain limits, the memory footprint required by the framebuffer. Dario Binacchi (6): ARM: dts: s

[PATCH 5.4/5.10 1/1] drm/atomic: Don't pollute crtc_state->mode_blob with error pointers

2023-06-02 Thread Fedor Pchelkin
From: Ville Syrjälä commit 439cf34c8e0a8a33d8c15a31be1b7423426bc765 upstream. Make sure we don't assign an error pointer to crtc_state->mode_blob as that will break all kinds of places that assume either NULL or a valid pointer (eg. drm_property_blob_put()). Cc: sta...@vger.kernel.org Reported-

Re: [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-02 Thread Uwe Kleine-König
Hello, On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > this patch series adapts the platform drivers below drivers/gpu/drm > to use the .remove_new() callback. Compared to the traditional .remove() > callback .remove_new() returns no value. This is a good thing because > the dr

[PATCH 6/6] drm/stm: add an option to change FB bpp

2023-06-02 Thread Dario Binacchi
Boards that use the STM32F{4,7} series have limited amounts of RAM. The added parameter allows users to size, within certain limits, the memory footprint required by the framebuffer. Signed-off-by: Dario Binacchi --- drivers/gpu/drm/stm/drv.c | 8 +++- 1 file changed, 7 insertions(+), 1 de

[PATCH 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-02 Thread Dario Binacchi
Add compatible to panel-simple for Rocktech Displays Limited RK043FN48H 4.3" 480x272 LCD-TFT panel. Signed-off-by: Dario Binacchi --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/p

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-02 Thread Biju Das
Hi All, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > On Wed, May 31, 2023 at 12:53:18PM +, Biju Das wrote: > > > > Subject: Re:

[PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-06-02 Thread Keith Zhao
Add crtc driver which implements crtc related operation functions. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 1 + drivers/gpu/drm/verisilicon/vs_crtc.c | 388 ++ drivers/gpu/drm/verisilicon/vs_crtc.h | 74 + drivers/gpu/drm/verisilicon/v

[PATCH 4/9] drm/verisilicon: Add gem driver for JH7110 SoC

2023-06-02 Thread Keith Zhao
This patch implements gem related APIs for JH7100 SoC. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_drv.c | 6 + drivers/gpu/drm/verisilicon/vs_gem.c | 372 +++ drivers/gpu/drm/verisilicon/vs_gem.h | 72 +++

[PATCH 7/9] drm/verisilicon: Add drm plane funcs

2023-06-02 Thread Keith Zhao
Implement plane functions for the DRM driver. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 3 +- drivers/gpu/drm/verisilicon/vs_plane.c | 440 + drivers/gpu/drm/verisilicon/vs_plane.h | 74 + 3 files changed, 516 insertions(+), 1 deletion(

[PATCH 0/9] Add DRM driver for StarFive SoC JH7110

2023-06-02 Thread Keith Zhao
Hi, This series is a DRM driver for StarFive SoC JH7110, which includes a display controller driver for Verisilicon DC8200 and an HMDI driver. We use GEM framework for buffer management and allocate memory by using DMA APIs. The JH7110 display subsystem includes a display controller Verisilicon

[PATCH 3/9] drm/verisilicon: Add basic drm driver

2023-06-02 Thread Keith Zhao
Add a basic platform driver of the DRM driver for JH7110 SoC. Signed-off-by: Keith Zhao --- MAINTAINERS | 2 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/verisilicon/Kconfig | 13 ++ drivers/gpu/drm/ver

[PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-02 Thread Keith Zhao
Add bindings for JH7110 display subsystem which has a display controller verisilicon dc8200 and an HDMI interface. Signed-off-by: Keith Zhao --- .../display/verisilicon/starfive-hdmi.yaml| 93 +++ .../display/verisilicon/verisilicon-dc.yaml | 110 ++ .../displa

[PATCH 5/9] drm/verisilicon: Add mode config funcs

2023-06-02 Thread Keith Zhao
Add mode setting functions for JH7110 SoC. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile | 1 + drivers/gpu/drm/verisilicon/vs_drv.c | 3 + drivers/gpu/drm/verisilicon/vs_fb.c | 181 +++ drivers/gpu/drm/verisilicon/vs_fb.h | 15 +++ 4 files cha

[PATCH 9/9] drm/verisilicon: Add starfive hdmi driver

2023-06-02 Thread Keith Zhao
Add HDMI dirver for StarFive SoC JH7110. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Kconfig | 11 + drivers/gpu/drm/verisilicon/Makefile| 1 + drivers/gpu/drm/verisilicon/starfive_hdmi.c | 928 drivers/gpu/drm/verisilicon/starfive_hdmi.h | 2

[PATCH 8/9] drm/verisilicon: Add verisilicon dc controller driver

2023-06-02 Thread Keith Zhao
Add DC8200 display controller driver for StarFive JH7110 SoC. Signed-off-by: Keith Zhao --- drivers/gpu/drm/verisilicon/Makefile |4 +- drivers/gpu/drm/verisilicon/vs_dc.c| 1040 drivers/gpu/drm/verisilicon/vs_dc.h| 62 + drivers/gpu/drm/verisilicon/vs_dc_hw.c | 2008

[PATCH 2/9] riscv: dts: starfive: jh7110: add dc&hdmi controller node

2023-06-02 Thread Keith Zhao
Add the dc controller and hdmi node for the Starfive JH7110 SoC. Signed-off-by: Keith Zhao --- .../jh7110-starfive-visionfive-2.dtsi | 87 +++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 46 ++ 2 files changed, 133 insertions(+) diff --git a/arch/riscv/boot/d

Re: [PATCH 2/2] drm: lcdif: force modeset when FB format changes

2023-06-02 Thread Ying Liu
On Thu, Jun 1, 2023 at 2:45 AM Lucas Stach wrote: > > Force a modeset if the new FB has a different format than the > currently active one. While it might be possible to change between > compatible formats without a full modeset as the format control is > also supposed to be double buffered, the c

Re: [PATCH v5 08/12] drm/msm/dpu: Add SM6375 support

2023-06-02 Thread Konrad Dybcio
On 1.06.2023 16:56, Marijn Suijten wrote: > On 2023-05-23 09:46:19, Konrad Dybcio wrote: >> Add basic SM6375 support to the DPU1 driver to enable display output. > > Nit: The SM6350 commit doesn't use the word "basic" here: what does it > mean? Is this addition not complete (because it seems s

Re: [PATCH v3 1/3] drm/msm/adreno: Add Adreno A690 support

2023-06-02 Thread Konrad Dybcio
On 1.06.2023 20:30, Akhil P Oommen wrote: > On Wed, May 31, 2023 at 10:30:09PM +0200, Konrad Dybcio wrote: >> >> >> >> On 31.05.2023 05:09, Bjorn Andersson wrote: >>> From: Bjorn Andersson >>> >>> Introduce support for the Adreno A690, found in Qualcomm SC8280XP. >>> >>> Tested-by: Steev Klimas

[PATCH 0/3] drm: Atomic modesetting doc and comment improvements

2023-06-02 Thread Geert Uytterhoeven
Hi all, This patch series contains various improvements to the documentation and comments related to atomic modesetting. Hopefully, it will ease the job of DRM novice who want to tackle the daunting task of converting a legacy DRM driver to atomic modesetting. Thanks for your comments!

[PATCH 3/3] drm: Fix references to drm_plane_helper_check_state()

2023-06-02 Thread Geert Uytterhoeven
only after the commit that removed the function... This is against next-20230602, which does not have the drivers/gpu/drm/{ => renesas}/rcar-du move yet. Biju: you're adding a new copy in drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- dri

[PATCH 2/3] drm: Remove references to removed transitional helpers

2023-06-02 Thread Geert Uytterhoeven
The transitional helpers were removed a long time ago, but some references stuck. Remove them. Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") Signed-off-by: Geert Uytterhoeven --- It doesn't look like the drm_encoder_helper_funcs were ever used by the transitional plane helpers? --

[PATCH 1/3] drm/todo: Add atomic modesetting references

2023-06-02 Thread Geert Uytterhoeven
The section about converting existing KMS drivers to atomic modesetting mentions the existence of a conversion guide, but does not reference it. While the guide is old and rusty, it still contains useful information, so add a link to it. Also link to the LWN.net articles that give an overview abou

[PATCH -next] drm/meson: Remove unneeded semicolon

2023-06-02 Thread Yang Li
./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392 Signed-off-by: Yang Li --- drivers/gpu/drm/meson/meson_dw_mipi_dsi

Re: [PATCH -next] drm/meson: Remove unneeded semicolon

2023-06-02 Thread neil . armstrong
On 02/06/2023 11:14, Yang Li wrote: ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5392 Signed-off-by: Yang Li ---

Re: [PATCH] dim: Disallow remote branch deletions with 'dim push'

2023-06-02 Thread Jani Nikula
On Thu, 01 Jun 2023, Ashutosh Dixit wrote: > An inadvertent 'dim push -d' can delete remote branches. Disallow such > remote branch deletions. Please see https://drm.pages.freedesktop.org/maintainer-tools/CONTRIBUTING.html > > Signed-off-by: Ashutosh Dixit > --- > dim | 6 ++ > 1 file chan

RE: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state()

2023-06-02 Thread Biju Das
> exists, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the drivers/gp

[PATCH v9 0/4] drm/i915: use ref_tracker library for tracking wakerefs

2023-06-02 Thread Andrzej Hajda
Hi Jakub, This is reviewed series of ref_tracker patches, ready to merge via network tree, rebased on net-next/main. i915 patches will be merged later via intel-gfx tree. Signed-off-by: Andrzej Hajda --- Changes in v9: - removed i915 patches, just to merge network part - added r-b-s - Link to v8

[PATCH v9 1/4] lib/ref_tracker: add unlocked leak print helper

2023-06-02 Thread Andrzej Hajda
To have reliable detection of leaks, caller must be able to check under the same lock both: tracked counter and the leaks. dir.lock is natural candidate for such lock and unlocked print helper can be called with this lock taken. As a bonus we can reuse this helper in ref_tracker_dir_exit. Signed-o

[PATCH v9 2/4] lib/ref_tracker: improve printing stats

2023-06-02 Thread Andrzej Hajda
In case the library is tracking busy subsystem, simply printing stack for every active reference will spam log with long, hard to read, redundant stack traces. To improve readabilty following changes have been made: - reports are printed per stack_handle - log is more compact, - added display name

[PATCH v9 3/4] lib/ref_tracker: add printing to memory buffer

2023-06-02 Thread Andrzej Hajda
Similar to stack_(depot|trace)_snprint the patch adds helper to printing stats to memory buffer. It will be helpful in case of debugfs. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Reviewed-by: Eric Dumazet --- include/linux/ref_tracker.h | 8 +++ lib/ref_tracker.c | 56

[PATCH v9 4/4] lib/ref_tracker: remove warnings in case of allocation failure

2023-06-02 Thread Andrzej Hajda
Library can handle allocation failures. To avoid allocation warnings __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been replaced with GFP_NOWAIT in case of stack allocation on tracker free call. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Reviewed-by: Eric Dumazet ---

Re: How to fetch the implicit sync fence for a GPU buffer?

2023-06-02 Thread Michel Dänzer
On 6/1/23 23:15, Hoosier, Matt wrote: > Hi, > >   > > In the past there has been writing about Wayland’s model using implicit > synchronization of GPU renderbuffers and KMS commits [1] [2]. > >   > > It would sometimes be nice to do that waiting explicitly in a compositor > before enqueueing

Re: [PATCH 1/3] drm/todo: Add atomic modesetting references

2023-06-02 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, Thanks for your patch. > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still contains useful information, > so add

Re: How to fetch the implicit sync fence for a GPU buffer?

2023-06-02 Thread Simon Ser
On Friday, June 2nd, 2023 at 12:29, Michel Dänzer wrote: > > I’m wondering whether there’s an API -- maybe something analogous to > > drmPrimeHandleToFD() – that allows userspace to fetch a waitable fence fd > > for a dmabuf? > > A dma-buf fd itself can serve this purpose; it polls as readable

Re: [PATCH 1/3] drm/todo: Add atomic modesetting references

2023-06-02 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > The section about converting existing KMS drivers to atomic modesetting > mentions the existence of a conversion guide, but does not reference it. > While the guide is old and rusty, it still

Re: [PATCH 2/3] drm: Remove references to removed transitional helpers

2023-06-02 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > The transitional helpers were removed a long time ago, but some > references stuck. Remove them. > > Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") > Signed-off-by: Geert Uytte

Re: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state()

2023-06-02 Thread Laurent Pinchart
sts, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the >

Re: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-06-02 Thread Laurent Pinchart
Hi Biju, On Thu, Jun 01, 2023 at 12:12:59PM +, Biju Das wrote: > > Subject: Re: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display > > Unit support > > > > On Mon, May 29, 2023 at 02:22:06PM +, Biju Das wrote: > > > > Subject: Re: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L

[GIT PULL FOR v6.5] drm: rcar-du: Miscellaneous changes

2023-06-02 Thread Laurent Pinchart
Hello, The following changes since commit 85d712f033d23bb56a373e29465470c036532d46: Merge tag 'drm-intel-gt-next-2023-05-24' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2023-05-29 06:21:51 +1000) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/

Re: [PATCH 2/3] drm: Remove references to removed transitional helpers

2023-06-02 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart wrote: > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > The transitional helpers were removed a long time ago, but some > > references stuck. Remove them. > > > > Fixes: 21ebe615c16994f3 ("drm: Remove transition

Re: [PATCH 1/3] drm/todo: Add atomic modesetting references

2023-06-02 Thread Geert Uytterhoeven
Hi Javier, On Fri, Jun 2, 2023 at 12:39 PM Javier Martinez Canillas wrote: > Geert Uytterhoeven writes: > > The section about converting existing KMS drivers to atomic modesetting > > mentions the existence of a conversion guide, but does not reference it. > > While the guide is old and rusty, i

[PATCH] drm/todo: Fix corrupted duplicate in defio section

2023-06-02 Thread Geert Uytterhoeven
Part of the paragraph was accidentally duplicated. Fixes: be5cadc7e7b4cee8 ("drm/todo: Better defio support in the generic fbdev emulation") Signed-off-by: Geert Uytterhoeven --- Documentation/gpu/todo.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/gpu/t

Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support

2023-06-02 Thread Laurent Pinchart
Hi Biju, On Thu, Jun 01, 2023 at 12:08:44PM +, Biju Das wrote: > > Subject: Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support > > > > Hi Biju, > > > > Thank you for the patch. > > > > This is a partial review, because the driver is big, and because some > > changes in v10 will (hopefully

Re: [PATCH 2/3] drm: Remove references to removed transitional helpers

2023-06-02 Thread Laurent Pinchart
Hi Geert, On Fri, Jun 02, 2023 at 01:17:58PM +0200, Geert Uytterhoeven wrote: > On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart wrote: > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > The transitional helpers were removed a long time ago, but some > > > references stuc

Re: [PATCH v3] amdgpu: validate offset_in_bo of drm_amdgpu_gem_va

2023-06-02 Thread Christian König
Am 02.06.23 um 00:44 schrieb Chia-I Wu: This is motivated by OOB access in amdgpu_vm_update_range when offset_in_bo+map_size overflows. v2: keep the validations in amdgpu_vm_bo_map v3: add the validations to amdgpu_vm_bo_map/amdgpu_vm_bo_replace_map rather than to amdgpu_gem_va_ioctl Fixes

Re: [PATCH 2/3] drm: Remove references to removed transitional helpers

2023-06-02 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Jun 2, 2023 at 1:36 PM Laurent Pinchart wrote: > On Fri, Jun 02, 2023 at 01:17:58PM +0200, Geert Uytterhoeven wrote: > > On Fri, Jun 2, 2023 at 1:05 PM Laurent Pinchart wrote: > > > On Fri, Jun 02, 2023 at 11:11:35AM +0200, Geert Uytterhoeven wrote: > > > > The transitional he

Re: [Intel-gfx] [PATCH v2 00/13] drm/display & drm/i915: more struct drm_edid conversions

2023-06-02 Thread Jani Nikula
On Wed, 31 May 2023, Jani Nikula wrote: > On Tue, 30 May 2023, Jani Nikula wrote: >> Rebase of https://patchwork.freedesktop.org/series/116813/ >> >> Move struct drm_edid conversions forward. >> >> There are still some drm_edid_raw() stragglers, but this nudges things >> forward nicely. >> >> Jan

Re: mailmap: Add missing email address

2023-06-02 Thread Maxime Ripard
Hi, On Thu, Jun 01, 2023 at 12:11:59AM +0800, Sui Jingfeng wrote: > Okey, that sound fine. Is it a Reviewed-by? Maxime signature.asc Description: PGP signature

Re: [PATCH] drm/todo: Fix corrupted duplicate in defio section

2023-06-02 Thread Thomas Zimmermann
Hi Am 02.06.23 um 13:30 schrieb Geert Uytterhoeven: Part of the paragraph was accidentally duplicated. This TODO item is mostly obsolete. It should be removed. Best regards Thomas Fixes: be5cadc7e7b4cee8 ("drm/todo: Better defio support in the generic fbdev emulation") Signed-off-by: Geer

Re: [PATCH] mailmap: Add missing email address

2023-06-02 Thread Thomas Zimmermann
Am 31.05.23 um 15:37 schrieb Maxime Ripard: I've been using that email address for contributions for a while but it seems I never added it to mailmap. Signed-off-by: Maxime Ripard Acked-by: Thomas Zimmermann --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.

Re: [git pull] drm fixes for 6.4-rc5

2023-06-02 Thread pr-tracker-bot
The pull request you sent on Fri, 2 Jun 2023 14:12:59 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e99a74673a19631d4a23c7e1fe2f21c55471a5d1 Thank you! -- Deet-doot-dot, I am a bot. https://ko

[PATCH] drm/meson: venc: include linux/bitfield.h

2023-06-02 Thread Arnd Bergmann
From: Arnd Bergmann Without this header, the use of FIELD_PREP() can cause a build failure: drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table': drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-d

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-06-02 Thread Jani Nikula
On Thu, 01 Jun 2023, Alan Previn wrote: > After recent discussions with Mesa folks, it was requested > that we optimize i915's GET_PARAM for the PXP_STATUS without > changing the UAPI spec. > > This patch adds this additional optimizations: Nitpick, please avoid "This patch". It's redundant, and

Re: [PATCH] drm/amd/display: clean up some inconsistent indenting

2023-06-02 Thread Alex Deucher
Acked-by: Alex Deucher On Fri, Jun 2, 2023 at 2:18 AM Jiapeng Chong wrote: > > No functional modification involved. > > drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:2377 > link_set_dpms_on() warn: inconsistent indenting. > > Reported-by: Abaci Robot > Closes: https://bugzilla.open

Re: [PATCH 1/3] drm/todo: Add atomic modesetting references

2023-06-02 Thread Bagas Sanjaya
On Fri, Jun 02, 2023 at 11:11:34AM +0200, Geert Uytterhoeven wrote: > -There is a conversion guide for atomic and all you need is a GPU for a > +There is a conversion guide for atomic[1] and all you need is a GPU for a > non-converted driver (again virtual HW drivers for KVM are still all > -suita

Re: [PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-06-02 Thread Alex Deucher
Reviewed-by: Alex Deucher On Fri, Jun 2, 2023 at 2:17 AM Jiapeng Chong wrote: > > No functional modification involved. > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:614 amdgpu_gfx_enable_kcq() warn: > inconsistent indenting. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/s

Re: [PATCH] drm/meson: venc: include linux/bitfield.h

2023-06-02 Thread Neil Armstrong
On 02/06/2023 14:45, Arnd Bergmann wrote: From: Arnd Bergmann Without this header, the use of FIELD_PREP() can cause a build failure: drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table': drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of functi

Re: [PATCH -next] drm/meson: Remove unneeded semicolon

2023-06-02 Thread Neil Armstrong
Hi, On Fri, 02 Jun 2023 17:14:16 +0800, Yang Li wrote: > ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:117:2-3: Unneeded semicolon > ./drivers/gpu/drm/meson/meson_dw_mipi_dsi.c:231:2-3: Unneeded semicolon > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

Re: [PATCH] drm/meson: venc: include linux/bitfield.h

2023-06-02 Thread Neil Armstrong
Hi, On Fri, 02 Jun 2023 14:45:24 +0200, Arnd Bergmann wrote: > Without this header, the use of FIELD_PREP() can cause a build failure: > > drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table': > drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of >

Re: mailmap: Add missing email address

2023-06-02 Thread Sui Jingfeng
Hi, On 2023/6/2 19:54, Maxime Ripard wrote: Hi, On Thu, Jun 01, 2023 at 12:11:59AM +0800, Sui Jingfeng wrote: Okey, that sound fine. Is it a Reviewed-by? Yes, I can't see problems from this. Reviewed-by: Sui Jingfeng Maxime -- Jingfeng

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-06-02 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: Friday, June 2, 2023 12:15 PM > To: Biju Das > Cc: David Airlie ; Daniel Vetter ; > Philipp Zabel ; Geert Uytterhoeven > ; Kieran Bingham > ; dri- > de...@lists.freedesktop.org; linux-renesas-...@vger.kernel.org; Fabrizio

[PATCH v6 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-02 Thread Biju Das
Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main device and another for rtc device. Enhance i2c_new_ancillary_device() to instantiate an I2C client device apart from the already supported I2C dummy client device. Added helper function __i2c_new_dummy_device to share the c

Re: [PATCH] drm/amd/display: clean up some inconsistent indenting

2023-06-02 Thread Hamza Mahfooz
On 6/2/23 02:17, Jiapeng Chong wrote: No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:2377 link_set_dpms_on() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5376 Signed-off-by: Jiapen

Re: [PATCH] drm/amd/display: fix compilation error due to shifting negative value

2023-06-02 Thread Hamza Mahfooz
On 6/2/23 06:12, GONG, Ruiqi wrote: Currently compiling linux-next with allmodconfig triggers the following error: ./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h: In function ‘dc_fixpt_truncate’: ./drivers/gpu/drm/amd/amdgpu/../display/include/fixed31_32.h:528:22: error: left shi

Re: [PATCH v2 3/3] drm/panel-simple: allow LVDS format override

2023-06-02 Thread Johannes Zink
Hi, gentle ping here - Do you have any feedback for me on this patch? Thanks and best regards Johannes On 5/23/23 10:19, Johannes Zink wrote: Some panels support multiple LVDS data mapping formats, which can be used e.g. run displays on jeida-18 format when only 3 LVDS lanes are available. Ad

Re: [RESUBMIT][PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-02 Thread Borislav Petkov
On Thu, Jun 01, 2023 at 10:47:39AM +0200, Juergen Gross wrote: > As described in the commit message, this only works on bare metal due to the > PAT bit not being needed for WC mappings. > > Making this patch Xen specific would try to cure the symptoms without fixing > the underlying problem: _PAGE_

Re: [RESUBMIT][PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-02 Thread Juergen Gross
On 02.06.23 16:43, Borislav Petkov wrote: On Thu, Jun 01, 2023 at 10:47:39AM +0200, Juergen Gross wrote: As described in the commit message, this only works on bare metal due to the PAT bit not being needed for WC mappings. Making this patch Xen specific would try to cure the symptoms without f

Re: [RESUBMIT][PATCH] x86/mm: Fix PAT bit missing from page protection modify mask

2023-06-02 Thread Juergen Gross
On 02.06.23 16:48, Juergen Gross wrote: On 02.06.23 16:43, Borislav Petkov wrote: On Thu, Jun 01, 2023 at 10:47:39AM +0200, Juergen Gross wrote: As described in the commit message, this only works on bare metal due to the PAT bit not being needed for WC mappings. Making this patch Xen specific

Re: [PATCH 36/36] drm/amd/display: allow newer DC hardware to use degamma ROM for PQ/HLG

2023-06-02 Thread Harry Wentland
On 5/23/23 18:15, Melissa Wen wrote: > From: Joshua Ashton > > Need to funnel the color caps through to these functions so it can check > that the hardware is capable. > > Signed-off-by: Joshua Ashton > Signed-off-by: Melissa Wen > --- > .../amd/display/amdgpu_dm/amdgpu_dm_color.c | 35 +

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Fix size_t format specifier in gsccs_send_message()

2023-06-02 Thread Jani Nikula
On Tue, 30 May 2023, Andi Shyti wrote: > Hi Nathan, > > On Tue, May 30, 2023 at 11:37:56AM -0700, Nathan Chancellor wrote: >> When building ARCH=i386 allmodconfig, the following warning occurs: >> >> In file included from include/linux/device.h:15, >>from include/linux/node.

Re: [PATCH 00/36] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-06-02 Thread Harry Wentland
On 5/23/23 18:14, Melissa Wen wrote: > This series is a refined version of our RFC [1] for AMD driver-specific > color management properties. It is a collection of contributions from > Joshua, Harry and I to enhance AMD KMS color pipeline for Steam > Deck/SteamOS by exposing the large set of col

Re: [PATCH v2 1/3] dt-bindings: display: move LVDS data-mapping definition to separate file

2023-06-02 Thread Laurent Pinchart
Hello Johannes, Thank you for the patch. On Tue, May 23, 2023 at 10:19:41AM +0200, Johannes Zink wrote: > As the LVDS data-mapping property is required in multiple bindings: move > it to separate file and include instead of duplicating it. > > Signed-off-by: Johannes Zink > > --- > > Changes:

Re: [Intel-gfx] [PATCH] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-06-02 Thread Teres Alexis, Alan Previn
Thanks Jani - will rev this up and fix these. On Fri, 2023-06-02 at 16:03 +0300, Jani Nikula wrote: > On Thu, 01 Jun 2023, Alan Previn wrote: > > After recent discussions with Mesa folks, it was requested > > that we optimize i915's GET_PARAM for the PXP_STATUS without > > changing the UAPI spec.

Re: [PATCH v2 2/3] dt-bindings: display: simple: support non-default data-mapping

2023-06-02 Thread Laurent Pinchart
Hi Johannes, Thank you for the patch. On Tue, May 23, 2023 at 10:19:42AM +0200, Johannes Zink wrote: > Some Displays support more than just a single default lvds data mapping, s/lvds/LVDS/ > which can be used to run displays on only 3 LVDS lanes in the jeida-18 > data-mapping mode. > > Add an

Re: [PATCH v2 3/3] drm/panel-simple: allow LVDS format override

2023-06-02 Thread Laurent Pinchart
Hi Johannes, Thank you for the patch. On Tue, May 23, 2023 at 10:19:43AM +0200, Johannes Zink wrote: > Some panels support multiple LVDS data mapping formats, which can be > used e.g. run displays on jeida-18 format when only 3 LVDS lanes are > available. > > Add parsing of an optional data-mapp

Re: (subset) [PATCH] mailmap: Add missing email address

2023-06-02 Thread Maxime Ripard
On Wed, 31 May 2023 15:37:24 +0200, Maxime Ripard wrote: > I've been using that email address for contributions for a while but it > seems I never added it to mailmap. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime

[PATCH v2] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-06-02 Thread Alan Previn
After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. Add these additional optimizations: - If any PXP initializatoin flow failed, then ensure that we catch it so that we can change the returned PXP_S

Re: Kernel bug related to drivers/gpu/drm/ttm/ttm_bo.c

2023-06-02 Thread Christopher Klooz
See also (maybe this user experiences the same bug?): https://bugzilla.redhat.com/show_bug.cgi?id=2193325 To provide direct links: My original post in "Kernel bug related to drivers/gpu/drm/ttm/ttm_bo.c" relates to: https://gitlab.com/py0xc31/public-tmp-storage/-/blob/main/retry6.3.4/firefoxC

RE: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support

2023-06-02 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support > > Hi Biju, > > On Thu, Jun 01, 2023 at 12:08:44PM +, Biju Das wrote: > > > Subject: Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support > > > > > > Hi Biju, > > > > > > Thank you for the

[PATCH] drm/vkms: Add support to 1D gamma LUT

2023-06-02 Thread Arthur Grillo
Support a 1D gamma LUT for each color channel on the VKMS driver. Add a check for the LUT length by creating vkms_atomic_check(). Tested with: igt@kms_color@gamma igt@kms_color@legacy-gamma igt@kms_color@invalid-gamma-lut-sizes Signed-off-by: Arthur Grillo --- drivers/gpu/drm/vkms/vkms_composer

Re: [PATCH] accel/ivpu: ivpu_ipc needs GENERIC_ALLOCATOR

2023-06-02 Thread Jeffrey Hugo
On 5/25/2023 10:45 PM, Randy Dunlap wrote: Drivers that use the gen_pool*() family of functions should select GENERIC_ALLOCATOR to prevent build errors like these: ld: drivers/accel/ivpu/ivpu_ipc.o: in function `gen_pool_free': include/linux/genalloc.h:172: undefined reference to `gen_pool_free_

Re: [PATCH 1/2] accel/ivpu: Do not trigger extra VPU reset if the VPU is idle

2023-06-02 Thread Jeffrey Hugo
On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: From: Andrzej Kacprowski Turning off the PLL and entering D0i3 will reset the VPU so an explicit IP reset is redundant. But if the VPU is active, it may interfere with PLL disabling and to avoid that, we have to issue an additional IP reset to sile

Re: [PATCH v2] drm/i915_drm.h: fix a typo

2023-06-02 Thread Jani Nikula
On Mon, 29 May 2023, Sui Jingfeng wrote: > 'rbiter' -> 'arbiter' > > Signed-off-by: Sui Jingfeng Pushed to drm-intel-next, thanks for the patch. BR, Jani. > --- > include/drm/i915_drm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/i915_drm.h b/include/

Re: [PATCH v2] drm/i915_drm.h: fix a typo

2023-06-02 Thread Sui Jingfeng
Hi, On 2023/6/3 01:24, Jani Nikula wrote: On Mon, 29 May 2023, Sui Jingfeng wrote: 'rbiter' -> 'arbiter' Signed-off-by: Sui Jingfeng Pushed to drm-intel-next, thanks for the patch. Thanks for your kindness and guidance. BR, Jani. --- include/drm/i915_drm.h | 2 +- 1 file changed,

Re: [PATCH 2/2] accel/ivpu: Do not use mutex_lock_interruptible

2023-06-02 Thread Jeffrey Hugo
On 5/25/2023 4:38 AM, Stanislaw Gruszka wrote: If we get signal when waiting for the mmu->lock we do not invalidate current MMU configuration what might result on undefined behavior. "that might result in" Additionally there is little or no benefit on break waiting for ipc->lock. In current c

[linux-next:master] BUILD REGRESSION bc708bbd8260ee4eb3428b0109f5f3be661fae46

2023-06-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: bc708bbd8260ee4eb3428b0109f5f3be661fae46 Add linux-next specific files for 20230602 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306011435.2bxshfue-...@intel.com https

[pull] amdgpu, amdkfd, radeon, ttm, UAPI drm-next-6.5

2023-06-02 Thread Alex Deucher
Hi Dave, Daniel, New stuff for 6.5. The following changes since commit e82c98f2ca439356d5595ba8c9cd782f993f6f8c: Merge tag 'amd-drm-next-6.4-2023-04-14' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2023-04-17 10:54:59 +1000) are available in the Git repository at: https:/

Re: [PATCH] drm/amdgpu: fix xclk freq on CHIP_STONEY

2023-06-02 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jun 1, 2023 at 5:48 PM Chia-I Wu wrote: > > According to Alex, most APUs from that time seem to have the same issue > (vbios says 48Mhz, actual is 100Mhz). I only have a CHIP_STONEY so I > limit the fixup to CHIP_STONEY > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 1

Re: [PATCH 1/9] dt-bindings: display: Add yamls for JH7110 display subsystem

2023-06-02 Thread Conor Dooley
Hey Keith, On Fri, Jun 02, 2023 at 03:40:35PM +0800, Keith Zhao wrote: > Add bindings for JH7110 display subsystem which > has a display controller verisilicon dc8200 > and an HDMI interface. > > Signed-off-by: Keith Zhao > --- > .../display/verisilicon/starfive-hdmi.yaml| 93 +

Re: [PATCH v3] amdgpu: validate offset_in_bo of drm_amdgpu_gem_va

2023-06-02 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Jun 2, 2023 at 7:43 AM Christian König wrote: > > Am 02.06.23 um 00:44 schrieb Chia-I Wu: > > This is motivated by OOB access in amdgpu_vm_update_range when > > offset_in_bo+map_size overflows. > > > > v2: keep the validations in amdgpu_vm_bo_map > > v3: add the v

Re: [PATCH][next] drm/amdgpu/discovery: Replace fake flex-arrays with flexible-array members

2023-06-02 Thread Alex Deucher
Applied. Thanks! On Tue, May 30, 2023 at 7:08 PM Kees Cook wrote: > > On Sun, May 28, 2023 at 02:26:37PM -0600, Gustavo A. R. Silva wrote: > > Zero-length and one-element arrays are deprecated, and we are moving > > towards adopting C99 flexible-array members, instead. > > > > Use the DECLARE_FL

Re: [PATCH v9 2/4] lib/ref_tracker: improve printing stats

2023-06-02 Thread Simon Horman
On Fri, Jun 02, 2023 at 12:21:34PM +0200, Andrzej Hajda wrote: > In case the library is tracking busy subsystem, simply > printing stack for every active reference will spam log > with long, hard to read, redundant stack traces. To improve > readabilty following changes have been made: Hi Andrzej,

Re: [PATCH] drm/amdgpu: fix xclk freq on CHIP_STONEY

2023-06-02 Thread Alex Deucher
Nevermind, missing your Signed-off-by. Please add and I'll apply. Alex On Fri, Jun 2, 2023 at 2:19 PM Alex Deucher wrote: > > Applied. Thanks! > > Alex > > On Thu, Jun 1, 2023 at 5:48 PM Chia-I Wu wrote: > > > > According to Alex, most APUs from that time seem to have the same issue > > (vbio

[PATCH v1] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-02 Thread Alan Previn
In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification where all command formats are defined in units of dwords so that '1' is a dword. Accordingly, GUC_CTB_MSG_MAX_LEN is 256-1 (i.e. 255 dwords). However, h2g_write was incorrectly ass

[PATCH 1/2] drm: bridge: tc358767: increase PLL lock time delay

2023-06-02 Thread Lucas Stach
From: David Jander The PLL often fails to lock with this delay. The new value was determined by trial and error increasing the delay bit by bit until the error did not occurr anymore even after several tries. Then double that value was taken as the minimum delay to be safe. Signed-off-by: David

[PATCH 2/2] drm: bridge: tc358767: give VSDELAY some positive value

2023-06-02 Thread Lucas Stach
From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not properly formatted in the output stream when DSI->DP mode is used. The calculation spreadsheets from Toshiba seem to always make this value

RE: [PATCH v2] drm: rcar-du: Use dev_err_probe() to record cause of KMS init errors

2023-06-02 Thread Biju Das
Hi Laurent, Thanks for the patch. > Subject: [PATCH v2] drm: rcar-du: Use dev_err_probe() to record cause of > KMS init errors > > The (large) rcar_du_modeset_init() function can fail for many reasons, > two of two involving probe deferral. Use dev_err_probe() in those code > paths to record the

  1   2   >