Re: [PATCH v4 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Hi Am 29.05.23 um 21:36 schrieb Sam Ravnborg: Hi Thomas, On Wed, May 24, 2023 at 11:21:50AM +0200, Thomas Zimmermann wrote: Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 wa

Re: [PATCH 00/36] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-05-30 Thread Pekka Paalanen
On Tue, 30 May 2023 01:55:21 +0300 Dmitry Baryshkov wrote: > On 24/05/2023 01:14, Melissa Wen wrote: > > This series is a refined version of our RFC [1] for AMD driver-specific > > color management properties. It is a collection of contributions from > > Joshua, Harry and I to enhance AMD KMS col

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Neil Armstrong
Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this condition can be dropped. I want to leave room for possibly running the panel without DSC (at a lower

[PATCH v5 00/17] drm/meson: add support for MIPI DSI Display

2023-05-30 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI glue on the same Amlogic SoCs. This adds support for the glue managing the transceiver, mimicing the init flow provided

[PATCH v5 02/17] clk: meson: g12a: add CTS_ENCL & CTS_ENCL_SEL clocks

2023-05-30 Thread Neil Armstrong
Add new CTS_ENCL & CTS_ENCL_SEL clocks for the G12A compatible SoCs, they are used to feed the VPU LCD Pixel encoder used for DSI display purposes. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.c | 40 drivers/clk/meson/g12a.h | 4 +++- 2 file

[PATCH v5 05/17] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-05-30 Thread Neil Armstrong
In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2 - vclk_div1 - vclk2_div2_en - vclk2_div4_en - vclk2_div6_en - vclk2_div12_en - vclk2_div2 - vclk2_div4 -

[PATCH v5 03/17] dt-bindings: clk: g12a-clkc: add VCLK2_SEL and CTS_ENCL clock ids

2023-05-30 Thread Neil Armstrong
Add new CLK ids for the VCLK2_SEL, CTS_ENCL and CTS_ENCL_SEL clocks on G12A compatible SoCs. Signed-off-by: Neil Armstrong --- include/dt-bindings/clock/g12a-clkc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/clock/g12a-clkc.h b/include/dt-bindings/clock/g12a-clkc

[PATCH v5 07/17] dt-bindings: display: meson-vpu: add third DPI output port

2023-05-30 Thread Neil Armstrong
Add third port corresponding to the ENCL DPI encoder used to connect to DSI or LVDS transceivers. Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Reviewed-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml | 5

[PATCH v5 04/17] clk: meson: g12: use VCLK2_SEL, CTS_ENCL & CTS_ENCL_SEL public CLK IDs

2023-05-30 Thread Neil Armstrong
Now those CLK IDs were added to the public bindings header, switch to use those defines and drop the PRIV defines. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.c | 18 +- drivers/clk/meson/g12a.h | 3 --- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git

[PATCH v5 15/17] DONOTMERGE: arm64: meson: khadas-vim3l: add DSI panel

2023-05-30 Thread Neil Armstrong
This add nodes to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- .../boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 76 ++ .../boot/dts/amlogic/meson-sm1-khadas-

[PATCH v5 12/17] drm/meson: add support for MIPI-DSI transceiver

2023-05-30 Thread Neil Armstrong
The Amlogic G12A/G12B/SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data inputs similar to the DW-HDMI Glue on other Amlogic SoCs. This adds support for the Glue managing the transceiver, mimicing the init flow provided by Amlo

[PATCH v5 16/17] dt-bindings: arm: amlogic: Document the MNT Reform 2 CM4 adapter with a BPI-CM4 Module

2023-05-30 Thread Neil Armstrong
The MNT Reform 2 CM4 adapter can be populated with any Raspberry Pi CM4 compatible module such as a BPI-CM4 Module, document that. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bin

[PATCH v5 08/17] drm/meson: fix unbind path if HDMI fails to bind

2023-05-30 Thread Neil Armstrong
If the case the HDMI controller fails to bind, we try to unbind all components before calling drm_dev_put() which makes drm_bridge_detach() crash because unbinding the HDMI controller frees the bridge memory. The solution is the unbind all components at the end like in the remove path. Signed-off

[PATCH v5 17/17] arm64: dts: amlogic: meson-g12b-bananapi-cm4: add support for MNT Reform2 with CM4 adaper

2023-05-30 Thread Neil Armstrong
This adds a basic devicetree for the MNT Reform2 DIY laptop when using a CM4 adapter and a BPI-CM4 module. Co-developed-by: Lukas F. Hartmann Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/Makefile | 1 + .../meson-g12b-bananapi-cm4-mnt-reform2.dts| 388 ++

[PATCH v5 01/17] clk: meson: g12a: prefix private CLK IDs defines with PRIV

2023-05-30 Thread Neil Armstrong
Exposing should not be done in a single commit anymore due to dt-bindings enforced rules. Prepend PRIV to the private CLK IDs so we can add new clock to the bindings header and in a separate commit remove such private define and switch to the public CLK IDs identifier. This refers to a discussion

[PATCH v5 10/17] drm/meson: venc: add ENCL encoder setup for MIPI-DSI output

2023-05-30 Thread Neil Armstrong
This adds supports for the ENCL encoder connected to a MIPI-DSI transceiver on the Amlogic AXG, G12A, G12B & SM1 SoCs. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 25 drivers/gpu/drm/meson/meson_venc.c | 211 +

[PATCH v5 11/17] drm/meson: add DSI encoder

2023-05-30 Thread Neil Armstrong
This adds an encoder bridge designed to drive a MIPI-DSI display by using the ENCL encoder through the internal MIPI DSI transceiver connected to the output of the ENCL pixel encoder. Signed-off-by: Neil Armstrong Reviewed-by: Jagan Teki Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/

[PATCH v5 06/17] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-30 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a) with a custom glue managing the IP resets, clock and data inputs similar to the DW-HDMI Glue on the same Amlogic SoC families. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong --- .../display/amlo

[PATCH v5 13/17] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate

2023-05-30 Thread Neil Armstrong
This updates the panel timings to achieve a clean 60Hz refresh rate. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/pan

[PATCH v5 09/17] drm/meson: only use components with dw-hdmi

2023-05-30 Thread Neil Armstrong
Only DW-HDMI currently needs components since it reuses the drm-meson driver context to access HHI registers (sic). Once this is solved, we can get rid on components. Until now, limit the components matching to the dw-hdmi compatibles we know to require this hack, for other bridges simply use pro

[PATCH v5 14/17] arm64: meson: g12-common: add the MIPI DSI nodes

2023-05-30 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH] drm/panel-edp: Convert to platform remove callback returning void

2023-05-30 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to

Re: [PATCH 2/3] dw-hdmi: truly enforce 420-only formats when drm mode demands it

2023-05-30 Thread Neil Armstrong
On 28/05/2023 16:00, Adrián Larumbe wrote: The current output bus format selection logic is enforcing YUV420 even when the drm mode allows for other bus formats as well. Fix it by adding check for 420-only drm modes. Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c

Re: [PATCH 1/3] drm/meson: dw-hdmi: change YUV420 selection logic at clock setup

2023-05-30 Thread Neil Armstrong
On 28/05/2023 15:59, Adrián Larumbe wrote: Right now clocking value selection code is prioritising RGB, YUV444 modes over YUV420 for HDMI2 sinks. However, because of the bus format selection procedure in dw-hdmi, for HDMI2 sinks YUV420 is the format that will always be picked during the drm bridg

Re: [PATCH V8 7/7] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-30 Thread Krzysztof Kozlowski
On 26/05/2023 21:30, Conor Dooley wrote: > On Fri, May 26, 2023 at 02:24:21PM -0500, Adam Ford wrote: >> On Fri, May 26, 2023 at 1:19 PM Conor Dooley wrote: >>> On Thu, May 25, 2023 at 10:05:59PM -0500, Adam Ford wrote: > description: - DSIM high speed burst mode frequency. >>

Re: [PATCH 3/3] dw-hdmi: remove dead code and fix indentation

2023-05-30 Thread Neil Armstrong
On 28/05/2023 16:00, Adrián Larumbe wrote: Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hd

[v11] media: mediatek: vcodec: support stateless AV1 decoder

2023-05-30 Thread Xiaoyong Lu
Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xiaoyong Lu Tested-by: Nicolas Dufresne Reviewed-by: Nicolas Dufresne Tested-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Regno --- Changes from v10: - fix conflict with new patch

Re: [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-05-30 Thread Neil Armstrong
On 26/05/2023 16:04, Adam Ford wrote: On Fri, May 26, 2023 at 2:24 AM Neil Armstrong wrote: On 26/05/2023 09:22, Neil Armstrong wrote: Hi, On Thu, 25 May 2023 22:05:52 -0500, Adam Ford wrote: This series fixes the blanking pack size and the PMS calculation. It then adds support to allows t

Re: [PATCH V2] dt-bindings: bridge: samsung-dsim: Make some flags optional

2023-05-30 Thread Neil Armstrong
Hi, On Sun, 28 May 2023 08:27:27 -0500, Adam Ford wrote: > In the event a device is connected to the samsung-dsim > controller that doesn't support the burst-clock, the > driver is able to get the requested pixel clock from the > attached device or bridge. In these instances, the > samsung,burst-

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-30 Thread Jerome Brunet
On Tue 16 May 2023 at 11:00, Neil Armstrong wrote: > On 16/05/2023 10:44, Arnd Bergmann wrote: >> On Mon, May 15, 2023, at 18:22, neil.armstr...@linaro.org wrote: >>> On 15/05/2023 18:15, Krzysztof Kozlowski wrote: On 15/05/2023 18:13, Krzysztof Kozlowski wrote: Also one more arg

Re: [PATCH v5 01/17] clk: meson: g12a: prefix private CLK IDs defines with PRIV

2023-05-30 Thread Jerome Brunet
On Tue 30 May 2023 at 09:38, Neil Armstrong wrote: > Exposing should not be done in a single commit anymore due to > dt-bindings enforced rules. > > Prepend PRIV to the private CLK IDs so we can add new clock to > the bindings header and in a separate commit remove such private > define and swi

Re: [PATCH v5 05/17] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-05-30 Thread Jerome Brunet
On Tue 30 May 2023 at 09:38, Neil Armstrong wrote: > In order to setup the DSI clock, let's make the unused VCLK2 clock path > configuration via CCF. > > The nocache option is removed from following clocks: > - vclk2_sel > - vclk2_input > - vclk2_div > - vclk2 > - vclk_div1 > - vclk2_div2_en >

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 01:39:10, Dmitry Baryshkov wrote: > On 30/05/2023 01:37, Marijn Suijten wrote: > > On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > > >>> +ret = mipi_dsi_dcs_set_display_on(dsi); > >>> +if (ret < 0) { > >>> +dev_err(dev, "Failed to turn display on: %d\n

[PATCH] gpu: Replace the ternary conditional operator with max()

2023-05-30 Thread Lu Hongfei
It would be better to replace the traditional ternary conditional operator with max() Signed-off-by: Lu Hongfei --- drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) mode change 100644 => 100755 drivers/gpu/drm/amd/display/dc/dml/dcn

Re: [PATCH 0/9] Support Wifi RFI interference mitigation feature

2023-05-30 Thread Felix Fietkau
On 30.05.23 04:42, Evan Quan wrote: Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI i

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Marijn Suijten
On 2023-05-30 09:24:24, Neil Armstrong wrote: > Hi Marijn, Dmitry, Caleb, Jessica, > > On 29/05/2023 23:11, Marijn Suijten wrote: > > On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > > >>> + if (ctx->dsi->dsc) { > >> > >> dsi->dsc is always set, thus this condition can be dropped. > > > > I w

[RFC PATCH] Documentation/gpu: Add a VM_BIND async draft document.

2023-05-30 Thread Thomas Hellström
Add a motivation for and description of asynchronous VM_BIND operation Signed-off-by: Thomas Hellström --- Documentation/gpu/drm-vm-bind-async.rst | 138 1 file changed, 138 insertions(+) create mode 100644 Documentation/gpu/drm-vm-bind-async.rst diff --git a/Documenta

Re: [PATCH v4 0/4] STM32 warning cleanup

2023-05-30 Thread Alexandre TORGUE
Hi Raphael On 5/29/23 11:13, Raphael Gallais-Pou wrote: This serie aims to reduce the number of device-tree warnings of following boards : - STM32F469-DISCO - STM32MP15* Those warnings were appearing either during build or when checking dt-bindings and concern mostly LTDC and DSI IPs. Th

[PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test

2023-05-30 Thread Guillaume Ranquet
The pll prediv calculus searchs for the smallest prediv that gets the ns_hdmipll_ck in the range of 5 GHz to 12 GHz. A typo in the upper bound test was testing for 5Ghz to 1Ghz Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Signed-off-by: Guillaume Ranquet --- drive

Re: [PATCH] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-05-30 Thread Marijn Suijten
On 2023-05-30 01:13:12, Dmitry Baryshkov wrote: > On Tue, 30 May 2023 at 00:46, Marijn Suijten > wrote: > > > > On 2023-05-26 12:09:45, Dmitry Baryshkov wrote: > > > Currently the driver passes the PINGPONG index to > > > dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean > >

Re: [PATCH] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-30 Thread Christian König
Am 29.05.23 um 11:28 schrieb Ma Jun: Remove redundant assignment code for ttm->caching The explanation is missing why this is redundant, e.g. something like "this is overwritten just a few lines later".. Apart from that looks good to me, Christian., Signed-off-by: Ma Jun --- drivers/gp

Re: [PATCH v5 5/6] drm/etnaviv: expand driver support for the PCI devices

2023-05-30 Thread kernel test robot
Hi Sui, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.4-rc4 next-20230530] [If your patch is applied to the

[PATCH v2 00/13] drm/display & drm/i915: more struct drm_edid conversions

2023-05-30 Thread Jani Nikula
Rebase of https://patchwork.freedesktop.org/series/116813/ Move struct drm_edid conversions forward. There are still some drm_edid_raw() stragglers, but this nudges things forward nicely. Jani Nikula (13): drm/edid: parse display info has_audio similar to is_hdmi drm/display/dp_mst: drop has

[PATCH v2 01/13] drm/edid: parse display info has_audio similar to is_hdmi

2023-05-30 Thread Jani Nikula
Since we already iterate everything that's needed for determining audio, reduce the need to call drm_detect_monitor_audio() by storing has_audio to connector info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 6 ++ include/drm/drm_connector.h | 8

[PATCH v2 02/13] drm/display/dp_mst: drop has_audio from struct drm_dp_mst_port

2023-05-30 Thread Jani Nikula
Caching the has_audio in struct drm_dp_mst_port seems odd, and oddly placed. Defer audio handling to drivers, and use the info from the connector display info. i915 was the only one using it anyway. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_to

[PATCH v2 03/13] drm/i915/dp: stop caching has_audio in struct intel_dp

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +- drivers/gpu/drm/i915/display/intel_display_types.h | 1 - drivers/gpu/drm/i915/display/intel_dp.c | 5 ++--- 3 files

[PATCH v2 04/13] drm/i915/dp: stop caching has_hdmi_sink in struct intel_dp

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Add intel_dp_has_hdmi_sink() helper to access it. v2: Rebased Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++--- .../drm/i915/display/intel_display_types.h| 1 - drivers/gpu/drm/

[PATCH v2 05/13] drm/i915/hdmi: stop caching has_audio in struct intel_hdmi

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 +++- drivers/gpu/drm/i915/display/intel_display_types.h | 1 - drivers/gpu/drm/i915/display/intel_hdmi.c| 6 ++

[PATCH v2 06/13] drm/i915/hdmi: stop caching has_hdmi_sink in struct intel_hdmi

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display_types.h | 1 - drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/driver

[PATCH v2 07/13] drm/i915/sdvo: stop caching has_hdmi_monitor in struct intel_sdvo

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_sdvo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/d

[PATCH v2 08/13] drm/i915/sdvo: stop caching has_hdmi_audio in struct intel_sdvo

2023-05-30 Thread Jani Nikula
Use the information stored in display info. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_sdvo.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm

[PATCH v2 09/13] drm/edid: add drm_edid_read_switcheroo()

2023-05-30 Thread Jani Nikula
Add a switcheroo variant to the struct drm_edid based EDID read functions. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + include/drm/drm_edid.h | 2 ++ 2 files changed, 31 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v2 10/13] drm/i915/lvds: switch to drm_edid_read_switcheroo()

2023-05-30 Thread Jani Nikula
Use drm_edid_read_switcheroo() to switch from struct edid to struct drm_edid. Reviewed-by: Lukas Wunner Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_lvds.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_

[PATCH v2 13/13] drm/i915/display: switch the rest of the connectors to struct drm_edid

2023-05-30 Thread Jani Nikula
Convert the remaining uses of struct edid based drm_get_edid(), drm_connector_update_edid_property() and drm_add_edid_modes() calls to the struct drm_edid based drm_edid_read_ddc(), drm_edid_connector_update() and drm_edid_connector_add_modes(). Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nik

[PATCH v2 11/13] drm/edid: make drm_edid_duplicate() safe to call with NULL parameter

2023-05-30 Thread Jani Nikula
It's a bit tedious to check for NULL before calling drm_edid_duplicate(). Make it handle NULL parameter graciously. Reviewed-by: Ankit Nautiyal Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/g

[PATCH v2 12/13] drm/display/dp_mst: convert to struct drm_edid

2023-05-30 Thread Jani Nikula
Convert the topology manager to use struct drm_edid, add drm_dp_mst_edid_read() that returns drm_edid, and rewrite the old drm_dp_mst_get_edid() to use it. Note that the old drm_get_edid() ended up calling drm_connector_update_edid_property(). This responsibility is now deferred to drivers, which

Re: [PATCH] phy: mediatek: hdmi: mt8195: fix prediv bad upper limit test

2023-05-30 Thread AngeloGioacchino Del Regno
Il 30/05/23 10:43, Guillaume Ranquet ha scritto: The pll prediv calculus searchs for the smallest prediv that gets the ns_hdmipll_ck in the range of 5 GHz to 12 GHz. A typo in the upper bound test was testing for 5Ghz to 1Ghz Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt

[PATCH] drm: rcar-du: Use dev_err_probe()

2023-05-30 Thread Laurent Pinchart
Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify the code. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu

[PATCH] drm: rcar-du: Replace DRM_INFO() with drm_info()

2023-05-30 Thread Laurent Pinchart
drm_info() adds proper context to the kernel log message, as it receives the drm_device pointer. It is thus preferred over DRM_INFO(). Replace the latter with the former. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Konrad Dybcio
On 30.05.2023 10:41, Marijn Suijten wrote: > On 2023-05-30 09:24:24, Neil Armstrong wrote: >> Hi Marijn, Dmitry, Caleb, Jessica, >> >> On 29/05/2023 23:11, Marijn Suijten wrote: >>> On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: >>> > + if (ctx->dsi->dsc) { dsi->dsc is always set

Re: [PATCH] drm: rcar-du: Use dev_err_probe()

2023-05-30 Thread Geert Uytterhoeven
Hi Laurent, On Tue, May 30, 2023 at 11:34 AM Laurent Pinchart wrote: > Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify > the code. > > Signed-off-by: Laurent Pinchart Thanks for your patch! I sent a similar patch before: https://lore.kernel.org/linux-renesas-soc/62addd

Re: [Intel-xe] [RFC PATCH] Documentation/gpu: Add a VM_BIND async draft document.

2023-05-30 Thread Nirmoy Das
Hi Thomas, On 5/30/2023 10:42 AM, Thomas Hellström wrote: Add a motivation for and description of asynchronous VM_BIND operation Signed-off-by: Thomas Hellström --- Documentation/gpu/drm-vm-bind-async.rst | 138 1 file changed, 138 insertions(+) create mode 10064

Re: [PATCH] drm: rcar-du: Use dev_err_probe()

2023-05-30 Thread Laurent Pinchart
Hi Geert, On Tue, May 30, 2023 at 11:38:44AM +0200, Geert Uytterhoeven wrote: > On Tue, May 30, 2023 at 11:34 AM Laurent Pinchart wrote: > > Replace manual handling of EPROBE_DEFER with dev_err_probe() to simplify > > the code. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! >

Re: [v10] media: mediatek: vcodec: support stateless AV1 decoder

2023-05-30 Thread 卢小勇
Hi Hans, I have updated v11 patch to fix this. Thanks! best regards xiaoyong Lu On Fri, 2023-05-26 at 14:04 +0200, Hans Verkuil wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. On 14/04/2023 10:30, Xiaoyong Lu wrote: > Add

Re: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 11:27, Marijn Suijten wrote: > > On 2023-05-30 01:39:10, Dmitry Baryshkov wrote: > > On 30/05/2023 01:37, Marijn Suijten wrote: > > > On 2023-05-30 01:18:40, Dmitry Baryshkov wrote: > > > > > >>> +ret = mipi_dsi_dcs_set_display_on(dsi); > > >>> +if (ret < 0)

[bug report] drm: Track drm_mm allocators and show leaks on shutdown

2023-05-30 Thread Dan Carpenter
Hello Chris Wilson, The patch 5705670d0463: "drm: Track drm_mm allocators and show leaks on shutdown" from Oct 31, 2016, leads to the following Smatch static checker warning: drivers/gpu/drm/drm_mm.c:1001 drm_mm_takedown() warn: sleeping in atomic context drivers/gpu/drm/drm_mm.c

RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: > > Hi Marijn, Dmitry, Caleb, Jessica, > > On 29/05/2023 23:11, Marijn Suijten wrote: > > On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > > >>> + if (ctx->dsi->dsc) { > >> > >> dsi->dsc is always set, thus this condition can be dropped. >

Re: [PATCH v2 1/3] dt-bindings: display: hdmi-connector: add hdmi-pwr supply

2023-05-30 Thread Krzysztof Kozlowski
On 19/05/2023 20:40, Dmitry Baryshkov wrote: > Follow the dp-connector example and add hdmi-pwr supply to drive the 5V > pin of the HDMI connector (together with some simple glue logic possibly > attached to the connector). > > Reviewed-by: Laurent Pinchart > Acked-by: Krzysztof Kozlowski > Sign

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread AngeloGioacchino Del Regno
Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this con

Re: [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-05-30 Thread Krzysztof Kozlowski
On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: > The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks > we'd normally assign to the GMU as if they were a part of the GMU, even > though they are not". It's a (good) software representation of the GMU_CX > and GMU_GX register

Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-30 Thread Krzysztof Kozlowski
On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote: > "#address-cells" and "#size-cells" are two properties that are not > mandatory. For instance, the DSI could refer to a bridge outside the scope > of the node rather than include a 'panel@0' subnode. By doing so, address > and size fie

Re: RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: +   if (

Re: [PATCH v5 5/6] drm/etnaviv: expand driver support for the PCI devices

2023-05-30 Thread Sui Jingfeng
ild test ERROR on drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.4-rc4 next-20230530] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in h

Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-30 Thread Alexandre TORGUE
On 5/30/23 14:27, Krzysztof Kozlowski wrote: On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote: "#address-cells" and "#size-cells" are two properties that are not mandatory. For instance, the DSI could refer to a bridge outside the scope of the node rather than include a 'panel@0' su

Re: [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-05-30 Thread Konrad Dybcio
On 30.05.2023 14:26, Krzysztof Kozlowski wrote: > On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: >> The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks >> we'd normally assign to the GMU as if they were a part of the GMU, even >> though they are not". It's a (good) sof

Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-30 Thread Raphael Gallais-Pou
On 5/30/23 15:30, Alexandre TORGUE wrote: > On 5/30/23 14:27, Krzysztof Kozlowski wrote: >> On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote: >>> "#address-cells" and "#size-cells" are two properties that are not >>> mandatory. For instance, the DSI could refer to a bridge outside th

Re: [PATCH 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-05-30 Thread kernel test robot
Hi Evan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on kvalo-ath/ath-next wireless-next/main wireless/main linus/master v6.4-rc4] [cannot apply to next-20230530] [If your patch is applied to the wrong git tree

Re: [PATCH 00/51] video: fbdev: Convert to platform remove callback returning void

2023-05-30 Thread Uwe Kleine-König
[Dropped a few recipents that resulted in bounces before] Hello, On Sun, Mar 19, 2023 at 07:04:54PM +0100, Helge Deller wrote: > On 3/19/23 00:53, Uwe Kleine-König wrote: > > this series adapts the platform drivers below drivers/video/fbdev to use the > > .remove_new() callback. Compared to the t

RE: [RFC PATCH] Documentation/gpu: Add a VM_BIND async draft document.

2023-05-30 Thread Zeng, Oak
Hi Thomas, Thanks for the document. See one question inline. Thanks, Oak > -Original Message- > From: dri-devel On Behalf Of > Thomas Hellström > Sent: May 30, 2023 4:43 AM > To: intel...@lists.freedesktop.org > Cc: Brost, Matthew ; Thomas Hellström > ; linux-ker...@vger.kernel.org; dri

Re: [PATCH 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-05-30 Thread kernel test robot
Hi Evan, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on kvalo-ath/ath-next wireless-next/main wireless/main linus/master v6.4-rc4] [cannot apply to next-20230530] [If your patch is applied to the wrong git tree

[PATCH] MAINTAINERS: Add myself as reviewer for mgag200 and ast drivers

2023-05-30 Thread Jocelyn Falempe
I've contributed to these two drivers, fixing bugs and performance issues. Signed-off-by: Jocelyn Falempe --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 250518fc70ff..92a991643b36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6398,6 +6398,7

Re: [RFC PATCH] Documentation/gpu: Add a VM_BIND async draft document.

2023-05-30 Thread Thomas Hellström
Hi, Oak, On 5/30/23 16:06, Zeng, Oak wrote: Hi Thomas, Thanks for the document. See one question inline. Thanks, Oak -Original Message- From: dri-devel On Behalf Of Thomas Hellström Sent: May 30, 2023 4:43 AM To: intel...@lists.freedesktop.org Cc: Brost, Matthew ; Thomas Hellström ;

Re: [PATCH] drm/msm/dp: add module parameter for PSR

2023-05-30 Thread Johan Hovold
On Wed, May 24, 2023 at 10:13:33AM -0700, Doug Anderson wrote: > On Wed, May 24, 2023 at 1:06 AM Dmitry Baryshkov > wrote: > > Originally this issue was reported by Doug, and at [1] he reported that > > an issue is fixed for him. So, for me it looks like we have hardware > > where VT works and ha

[PATCH v5 00/13]

2023-05-30 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[PATCH v5 01/13] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-30 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas Zimme

[PATCH v5 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v5 06/13] drm/radeon: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-30 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

[PATCH v5 09/13] drm/tegra: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely

[PATCH v5 05/13] drm/gma500: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v5 03/13] drm/armada: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v5 13/13] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the fbdev callbacks. i915 was the only caller of the DRM helpers, so remove them from the helper module. i915's fbdev emulation is still incomplete as it do

[PATCH v5 07/13] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions enti

[PATCH v5 11/13] drm/msm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[PATCH v5 10/13] drm/fb-helper: Export helpers for marking damage areas

2023-05-30 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[PATCH v5 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Use an fbdev generator macro for deferred I/O to create the callbacks. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v4: * generate deferred-I/O helpers

[PATCH v5 08/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entire

[PATCH v5 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-30 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[PATCH v5 04/13] drm/exynos: Use regular fbdev I/O helpers

2023-05-30 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirel

[PATCH v5 02/13] fbdev: Add initializer macros for struct fb_ops

2023-05-30 Thread Thomas Zimmermann
For framebuffers in I/O and system memory, add macros that set struct fb_ops to the respective callback functions. For deferred I/O, add macros that generate callback functions with damage handling. Add initializer macros that set struct fb_ops to the generated callbacks. These macros can remove

  1   2   3   >