[PATCH] drm/amd/display: Simplify the calculation of variables

2023-05-12 Thread Jiapeng Chong
./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:586:37-39: WARNING !A || A && B is equivalent to !A || B. ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:595:37-39: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cg

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Thomas Zimmermann
Hi Am 11.05.23 um 19:02 schrieb Helge Deller: On 5/11/23 16:27, Thomas Zimmermann wrote: But the work I do within fbdev is mostly for improving DRM. Sure. For the other issues in this file, I don't think that matroxfb should even be around any longer. Fbdev has been deprecated for a long ti

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-12 Thread Pekka Paalanen
On Thu, 11 May 2023 19:29:27 + Simon Ser wrote: > On Thursday, May 11th, 2023 at 18:56, Joshua Ashton wrote: > > > When we are talking about being 'prescriptive' in the API, are we > > outright saying we don't want to support arbitrary 3D LUTs, or are we > > just offering certain algorithms

Re: [PATCH] fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

2023-05-12 Thread Geert Uytterhoeven
Hi Helge, On Sat, Apr 22, 2023 at 11:27 PM Helge Deller wrote: > Add typical resolution for Full-HD monitors. > > Signed-off-by: Helge Deller > --- a/drivers/video/fbdev/core/modedb.c > +++ b/drivers/video/fbdev/core/modedb.c > @@ -257,6 +257,10 @@ static const struct fb_videomode modedb[] = {

[PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does no

[PATCH 03/11] drm/gma500: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_GMA500_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[PATCH 10/11] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. Add CONFIG_DRM_FBDEV_GENERIC_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depe

[PATCH 02/11] drm/exynos: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_EXYNOS_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[PATCH 08/11] drm/tegra: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_TEGRA_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on

[PATCH 07/11] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_OMAP_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend o

[PATCH 04/11] drm/radeon: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_RADEON_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[PATCH 01/11] drm/armada: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_ARMADA_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[PATCH 09/11] drm/fb-helper: Export helpers for marking damage areas

2023-05-12 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by thems

[PATCH 06/11] drm/msm: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_MSM_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on the

[PATCH 05/11] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. Add CONFIG_DRM_FBDEV_DMA_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend

[PATCH 11/11] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-12 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. i915 was the only caller of the DRM helpers, so remove them from the helper module. Add CONFIG_DRM_I915_FBDEV_EMULATION to select the necessary Kconfig options automatically. Make fbdev emulation depend on the ne

Re: [PATCH v6 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-12 Thread Artur Rojek
On 2023-05-11 14:35, Geert Uytterhoeven wrote: Hi Arnd, CC Artur, who's working on HP Jornada 680. Thanks for CC'ing me - I faced this exact issue while working on my (still not upstreamed) hd6446x PCMCIA controller driver. The PCMCIA subsystem uses `inb/outb`, which expect the `sh_io_port_base

[PATCH 05/17] drm/radeon: Use pcie_lnkctl{, 2}_clear_and_set() for changing LNKCTL{, 2}

2023-05-12 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL/LNKCTL2. ASPM policy changes can trigger write to LNKCTL outside of driver's control. And in the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use pcie_lnkctl_clear_and_set() and pcie_

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-12 Thread Carl Vanderlip
On 5/3/2023 3:41 AM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by: D

[RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-12 Thread Arseniy Krasnov
This adds support for OTP area access on MX30LFxG18AC chip series. Changelog: v1 -> v2: * Add slab.h include due to kernel test robot error. v2 -> v3: * Use 'uint64_t' as input argument for 'do_div()' instead of 'unsigned long' due to kernel test robot error. Signed-off-by: Arseniy Kr

Re: [RESEND PATCH v3] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-05-12 Thread Arseniy Krasnov
Cc: Mason Yang and Boris Brezillon On 11.05.2023 18:21, Arseniy Krasnov wrote: > This adds support for OTP area access on MX30LFxG18AC chip series. > > Changelog: > v1 -> v2: > * Add slab.h include due to kernel test robot error. > v2 -> v3: > * Use 'uint64_t' as input argument for 'do

Re: [PATCH 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Greg Ungerer
On 11/5/23 23:34, Bagas Sanjaya wrote: Replace GPL boilerplate notice on remaining files with appropriate SPDX tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. Cc: David A. Hinds Cc: Donald Becker Cc: Peter De Schrijver Cc: Greg Ungerer Cc: Simon Horman Signed-off-by: B

[PATCH v4 5/9] drivers: use new capable_any functionality

2023-05-12 Thread Christian Göttsche
Use the new added capable_any function in appropriate cases, where a task is required to have any of two capabilities. Reorder CAP_SYS_ADMIN last. Signed-off-by: Christian Göttsche --- v4: Additional usage in kfd_ioctl() v3: rename to capable_any() --- drivers/gpu/drm/amd/amdkfd/kfd_chard

[PATCH 04/17] drm/amdgpu: Use pcie_lnkctl{, 2}_clear_and_set() for changing LNKCTL{, 2}

2023-05-12 Thread Ilpo Järvinen
Don't assume that only the driver would be accessing LNKCTL/LNKCTL2. ASPM policy changes can trigger write to LNKCTL outside of driver's control. And in the case of upstream (parent), the driver does not even own the device it's changing the registers for. Use pcie_lnkctl_clear_and_set() and pcie_

Re: [PATCH] accel/qaic: silence some uninitialized variable warnings

2023-05-12 Thread Pranjal Ramajor Asha Kanojiya
On 5/3/2023 4:11 PM, Dan Carpenter wrote: Smatch complains that these are not initialized if get_cntl_version() fails but we still print them in the debug message. Not the end of the world, but true enough. Let's just initialize them to a dummy value to make the checker happy. Signed-off-by

[PATCH v2] drm/amdkfd: Fix potential deallocation of previously deallocated memory.

2023-05-12 Thread Daniil Dulov
Pointer mqd_mem_obj can be deallocated in kfd_gtt_sa_allocate(). The function then returns non-zero value, which causes the second deallocation. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: d1f8f0d17d40 ("drm/amdkfd: Move non-sdma mqd allocation out of init_mqd") Signe

Re: [PATCH] drm/i915/pmu: Turn off the timer to sample frequencies when GT is parked

2023-05-12 Thread Tvrtko Ursulin
On 12/05/2023 02:53, Ashutosh Dixit wrote: pmu_needs_timer() keeps the timer running even when GT is parked, ostensibly to sample requested/actual frequencies. However frequency_sample() has the following: /* Report 0/0 (actual/requested) frequency while parked. */ if (!intel_g

Re: [PATCH] fbdev: modedb: Add a 1920x1080 at 60 Hz video mode

2023-05-12 Thread Helge Deller
On 5/12/23 09:44, Geert Uytterhoeven wrote: Hi Helge, On Sat, Apr 22, 2023 at 11:27 PM Helge Deller wrote: Add typical resolution for Full-HD monitors. Signed-off-by: Helge Deller --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -257,6 +257,10 @@ static c

Re: [PATCH 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
On 5/11/23 22:08, Guenter Roeck wrote: >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > This was supposed to be a C++ style comment for C source files. > Has the rule changed ? > Oops, I don't see checkpatch. Will fix. >> +/* SPDX-License-Identifier: GPL-2.0-only */ > > The text below sugge

Re: [PATCH 00/10] Treewide GPL SPDX conversion (love letter to Didi)

2023-05-12 Thread Bagas Sanjaya
On 5/12/23 07:41, Jakub Kicinski wrote: > On Thu, 11 May 2023 20:33:56 +0700 Bagas Sanjaya wrote: >> I trigger this patch series because of Didi's GPL full name fixes >> attempt [1], for which all of them had been NAKed. In many cases, the >> appropriate correction is to use SPDX license identifier

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-12 Thread Tomi Valkeinen
On 09/05/2023 12:30, Aradhya Bhatia wrote: From: Nikhil Devshatwar With new connector model, mhdp bridge will not create the connector and SoC driver will rely on format negotiation to setup the encoder format. Support minimal format negotiations hooks in the drm_bridge_funcs. Complete format

Re: [PATCH v6 0/8] drm/tidss: Use new connector model for tidss

2023-05-12 Thread Tomi Valkeinen
On 09/05/2023 12:30, Aradhya Bhatia wrote: Hi all, I have picked up this long standing series from Nikhil Devshatwar[1]. This series moves the tidss to using new connectoe model, where the SoC driver (tidss) creates the connector and all the bridges are attached with the flag DRM_BRIDGE_ATTACH_

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Andi Shyti
Hi Ashutosh, On Thu, May 11, 2023 at 10:43:30AM -0700, Dixit, Ashutosh wrote: > On Wed, 10 May 2023 11:36:06 -0700, Ashutosh Dixit wrote: > > > > Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) > > causes the following warning: > > > > UBSAN: invalid-load in drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Silence UBSAN uninitialized bool variable warning

2023-05-12 Thread Andrzej Hajda
On 10.05.2023 20:36, Ashutosh Dixit wrote: Loading i915 on UBSAN enabled kernels (CONFIG_UBSAN/CONFIG_UBSAN_BOOL) causes the following warning: UBSAN: invalid-load in drivers/gpu/drm/i915/gt/uc/intel_uc.c:558:2 load of value 255 is not a valid value for type '_Bool' Call Trace: dump

Re: [PATCH 06/11] drm/msm: Use regular fbdev I/O helpers

2023-05-12 Thread Dmitry Baryshkov
On Fri, 12 May 2023 at 11:41, Thomas Zimmermann wrote: > > Use the regular fbdev helpers for framebuffer I/O instead of DRM's > helpers. Msm does not use damage handling, so DRM's fbdev helpers > are mere wrappers around the fbdev code. > > Add CONFIG_DRM_MSM_FBDEV_EMULATION to select the necessar

[PATCH v2 02/10] mISDN: Replace GPL notice boilerplate with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Replace unversioned GPL notice boilerplate on dsp_* with SPDX identifier for GPL 1.0+. These files missed previous SPDX conversion batches due to not specifying GPL version. Cc: Stephen Hemminger Cc: Andreas Eversberg Cc: Karsten Keil Reviewed-by: Simon Horman Signed-off-by: Bagas Sanjaya ---

[PATCH v2 01/10] agp/amd64: Remove GPL distribution notice

2023-05-12 Thread Bagas Sanjaya
There is already SPDX tag which does the job, so remove the redundant notice. Cc: Christophe JAILLET Reviewed-by: Simon Horman Signed-off-by: Bagas Sanjaya --- drivers/char/agp/amd64-agp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-

[PATCH v2 03/10] net: bonding: Add SPDX identifier to remaining files

2023-05-12 Thread Bagas Sanjaya
Previous batches of SPDX conversion missed bond_main.c and bonding_priv.h because these files doesn't mention intended GPL version. Add SPDX identifier to these files, assuming GPL 1.0+. Cc: Thomas Davis Cc: Christophe JAILLET Cc: Stephen Hemminger Reviewed-by: Simon Horman Signed-off-by: Baga

[PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes)

2023-05-12 Thread Bagas Sanjaya
I trigger this patch series as a response to Didi's GPL full name fix patches [1], for which all of them had been NAKed. In many cases, the appropriate correction is to use SPDX license identifier instead. Often, when replacing license notice boilerplates with their equivalent SPDX identifier, the

[PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Replace GPL boilerplate notice on remaining files with appropriate SPDX tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. Cc: David A. Hinds Cc: Donald Becker Cc: Peter De Schrijver Cc: Topi Kanerva Cc: Alain Malek Cc: Bruce Abbott Cc: Alan Cox Acked-by: Greg Ungerer Revi

[PATCH v2 09/10] udf: Replace license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Except Kconfig and Makefile, all source files for UDF filesystem doesn't bear SPDX license identifier. Add appropriate license identifier while replacing boilerplates. Cc: Thomas Gleixner Cc: Pali Rohár Reviewed-by: Simon Horman Signed-off-by: Bagas Sanjaya --- tglx, in your patch attempt [1]

[PATCH v2 05/10] net: ethernet: i825xx: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Replace unversioned GPL boilerplate notice on remaining i825xx files with appropriate SPDX identifier. For files that contains "extension to Linux kernel", use GPL 2.0, otherwise GPL 1.0+. Cc: Donald Becker Cc: Michael Hipp Cc: Richard Hirst Cc: Sam Creasey Reviewed-by: Simon Horman Signed-of

[PATCH v2 06/10] pcmcia: Add SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Add SPDX identifier on remaining files untouched during previous rounds of SPDX conversion while replacing boilerplate notice if any. Cc: Maxime Bizon Cc: David A. Hinds Cc: John G. Dorsey Reviewed-by: Simon Horman Signed-off-by: Bagas Sanjaya --- drivers/pcmcia/bcm63xx_pcmcia.c | 5 +

[PATCH v2 07/10] drivers: staging: wlan-ng: Remove GPL/MPL boilerplate

2023-05-12 Thread Bagas Sanjaya
Remove the license boilerplate as there is already SPDX license identifier added in b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") which fulfills the same intention as the boilerplate. Cc: Dan Carpenter Cc: Kate Stewart Cc: Philippe Ombredanne C

[PATCH v2 10/10] include: synclink: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Replace unversioned GPL license notice with appropriate SPDX identifier, which is GPL 1.0+. Reviewed-by: Simon Horman Signed-off-by: Bagas Sanjaya --- include/linux/synclink.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/synclink.h b/include/linux/synclink

[PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
Many watchdog drivers's source files has already SPDX license identifier, while some remaining doesn't. Convert notices on remaining files to SPDX identifier. While at it, also move SPDX identifier for drivers/watchdog/rtd119x_wdt.c to the top of file (as in other files). Cc: Ray Lehtiniemi Cc:

Re: [PATCH v6 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Finn Thain
On Thu, 11 May 2023, Thomas Zimmermann wrote: > But I'd really like to see most of these drivers being moved into > staging and deleted soon afterwards. Users will complain about those > drivers that are really still required. Those might be worth to spend > effort on. > That strategy is not

Re: [Intel-gfx] [PATCH] drm/i1915/guc: Fix probe injection CI failures after recent change

2023-05-12 Thread Andi Shyti
Hi John, On Wed, May 10, 2023 at 01:55:56PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > A recent change bumped a 'notice' message up to 'error' level for > debug builds to help trap incorrect configurations in CI systems. > Unfortunaetly, tha error condition in question is

[PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-12 Thread Thomas Zimmermann
Cast I/O offsets to pointers to use them with I/O functions. The I/O functions expect pointers of type 'volatile void __iomem *', but the offsets are plain integers. Build warnings are ../drivers/video/fbdev/hitfb.c: In function 'hitfb_accel_wait': ../arch/x86/include/asm/hd64461.h:18:33: warn

[PATCH v7 0/7] fbdev: Move framebuffer I/O helpers to

2023-05-12 Thread Thomas Zimmermann
Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture, but they are all equivalent to regular I/O functions of similar names. So use regular functions instead and move all helpers into The fi

[PATCH v7 3/7] ipu-v3: Include

2023-05-12 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu

[PATCH v7 5/7] fbdev: Include instead of

2023-05-12 Thread Thomas Zimmermann
Replace include statements for with . Fixes the coding style: if a header is available in asm/ and linux/, it is preferable to include the header from linux/. This only affects a few source files, most of which already include . Suggested-by: Sam Ravnborg Signed-off-by: Thomas Zimmermann Review

[PATCH v7 4/7] fbdev: Include in various drivers

2023-05-12 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h

[PATCH v7 6/7] fbdev: Move framebuffer I/O helpers into

2023-05-12 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such as __raw_readb() or memset_io(). A few architectures used plain system- memory reads and writes. Sparc used

[PATCH v7 7/7] fbdev: Rename fb_mem*() helpers

2023-05-12 Thread Thomas Zimmermann
Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() becomes fb_memcpy_toio(). No functional changes. v6: * update new file fb_io_fop

[PATCH v7 2/7] fbdev/matrox: Remove trailing whitespaces

2023-05-12 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2

Re: [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Sam Ravnborg
Hi Thomas, On Fri, May 12, 2023 at 10:41:41AM +0200, Thomas Zimmermann wrote: > DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() > and fb_sys_() helpers. The DRM functions don't provide any additional > functionality for most DRM drivers. So remove them and call the fbdev > I

[PATCH v3 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-12 Thread Maíra Canal
Create a new fixed-point helper to allow us to return the rounded value of our fixed point value. [v2]: * Create the function drm_fixp2int_round() (Melissa Wen). [v3]: * Use drm_fixp2int() instead of shifting manually (Arthur Grillo). Signed-off-by: Maíra Canal --- include/drm/drm_fixed

[PATCH v3 2/2] drm/vkms: Fix RGB565 pixel conversion

2023-05-12 Thread Maíra Canal
Currently, the pixel conversion isn't rounding the fixed-point values before assigning it to the RGB coefficients, which is causing the IGT pixel-format tests to fail. So, use the drm_fixp2int_round() fixed-point helper to round the values when assigning it to the RGB coefficients. Tested with igt

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > masks for fixed-width types and also the corresponding BIT_U32(), > BIT_U16() and BIT_U8(). Why? > All of those depend on a new "U" suffix added to the integer

Re: [PATCH v2 05/10] net: ethernet: i825xx: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2023 at 05:06:16PM +0700, Bagas Sanjaya wrote: > Replace unversioned GPL boilerplate notice on remaining i825xx files > with appropriate SPDX identifier. For files that contains "extension to > Linux kernel", use GPL 2.0, otherwise GPL 1.0+. > > Cc: Donald Becker > Cc: Michael Hip

RE: [PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-12 Thread David Laight
From: Thomas Zimmermann > Sent: 12 May 2023 11:25 > > Cast I/O offsets to pointers to use them with I/O functions. The I/O > functions expect pointers of type 'volatile void __iomem *', but the > offsets are plain integers. Build warnings are > > ../drivers/video/fbdev/hitfb.c: In function 'hit

Re: [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes)

2023-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2023 at 05:06:11PM +0700, Bagas Sanjaya wrote: > I trigger this patch series as a response to Didi's GPL full name fix > patches [1], for which all of them had been NAKed. In many cases, the > appropriate correction is to use SPDX license identifier instead. > > Often, when replaci

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create >> masks for fixed-width types and also the corresponding BIT_U32(), >> BIT_U16() and BIT_U8(). > > Why? The main r

Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Geert Uytterhoeven
Hi Bagas, On Fri, May 12, 2023 at 12:08 PM Bagas Sanjaya wrote: > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. > > Cc: David A. Hinds > Cc: Donald Becker > Cc: Peter De Schrijver > Cc: Topi Kanerva

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Andy Shevchenko
On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: > On Fri, 12 May 2023, Andy Shevchenko > wrote: > > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: > >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to create > >> masks for fixed-width types and also the

[PATCH] drm/i915/gvt: fix typo in comment

2023-05-12 Thread Deming Wang
Spelling mistake (triple letters) in comment. Signed-off-by: Deming Wang --- drivers/gpu/drm/i915/gvt/gvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gvt.h b/drivers/gpu/drm/i915/gvt/gvt.h index 2d65800d8e93..c933e9a1c5ad 100644 --- a/drivers/gp

Re: [PATCH v7 1/7] fbdev/hitfb: Cast I/O offset to address

2023-05-12 Thread Thomas Zimmermann
Hi Am 12.05.23 um 13:16 schrieb David Laight: From: Thomas Zimmermann Sent: 12 May 2023 11:25 Cast I/O offsets to pointers to use them with I/O functions. The I/O functions expect pointers of type 'volatile void __iomem *', but the offsets are plain integers. Build warnings are ../drivers/

Re: [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2023-05-12 Thread Jani Nikula
On Fri, 12 May 2023, Andy Shevchenko wrote: > On Fri, May 12, 2023 at 02:25:18PM +0300, Jani Nikula wrote: >> On Fri, 12 May 2023, Andy Shevchenko >> wrote: >> > On Mon, May 08, 2023 at 10:14:02PM -0700, Lucas De Marchi wrote: >> >> Add GENMASK_U32(), GENMASK_U16() and GENMASK_U8() macros to cr

Re: [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Thomas Zimmermann
Hi Sam Am 12.05.23 um 12:29 schrieb Sam Ravnborg: Hi Thomas, On Fri, May 12, 2023 at 10:41:41AM +0200, Thomas Zimmermann wrote: DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DR

[PATCH] drm/ssd130x: Fix include guard name

2023-05-12 Thread Javier Martinez Canillas
This is a leftover from an early iteration of the driver when it was still named ssd1307 instead of ssd130x. Change it for consistency with the rest. Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c > index 504be461f992a9..822bf8905bf3ce 100644 > --- a/drivers/watchdog/sb_wdog.c > +++ b/drivers/watchdog/sb_wdog.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-1.0

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Guenter Roeck
On Fri, May 12, 2023 at 05:06:19PM +0700, Bagas Sanjaya wrote: > Many watchdog drivers's source files has already SPDX license > identifier, while some remaining doesn't. > > Convert notices on remaining files to SPDX identifier. While at it, > also move SPDX identifier for drivers/watchdog/rtd119

Re: [PATCH v2 08/10] drivers: watchdog: Replace GPL license notice with SPDX identifier

2023-05-12 Thread Bagas Sanjaya
On 5/12/23 17:06, Bagas Sanjaya wrote: > diff --git a/drivers/watchdog/octeon-wdt-nmi.S > b/drivers/watchdog/octeon-wdt-nmi.S > index 97f6eb7b5a8e04..57bb0845de477d 100644 > --- a/drivers/watchdog/octeon-wdt-nmi.S > +++ b/drivers/watchdog/octeon-wdt-nmi.S > @@ -1,8 +1,5 @@ > +/* SPDX-License-Ident

Re: [PATCH v2 04/10] net: ethernet: 8390: Replace GPL boilerplate with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > > Replace GPL boilerplate notice on remaining files with appropriate SPDX > tag. For files mentioning COPYING, use GPL 2.0; otherwise GPL 1.0+. > diff --git a/drivers/net/ethernet/8390/ne2k-pci.c > b/drivers/net/ethernet/8390/ne2k-pci.c > in

Re: [PATCH v3 1/2] drm: Add fixed-point helper to get rounded integer values

2023-05-12 Thread Arthur Grillo Queiroz Cabral
On 12/05/23 07:40, Maíra Canal wrote: > Create a new fixed-point helper to allow us to return the rounded value > of our fixed point value. > > [v2]: > * Create the function drm_fixp2int_round() (Melissa Wen). > [v3]: > * Use drm_fixp2int() instead of shifting manually (Arthur Grillo).

[PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-12 Thread Neil Armstrong
Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and CTS_ENCL_SEL clocks on G12A compatible SoCs. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.h | 1 - include/dt-bindings/clock/g12a-clkc.h | 3 +++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/

[PATCH v4 02/13] clk: meson: g12a: add CTS_ENCL & CTS_ENCL_SEL clocks

2023-05-12 Thread Neil Armstrong
Add new CTS_ENCL & CTS_ENCL_SEL clocks for the G12A compatible SoCs, they are used to feed the VPU LCD Pixel encoder used for DSI display purposes. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.c | 40 drivers/clk/meson/g12a.h | 2 +- 2 files

[PATCH v4 00/13] drm/meson: add support for MIPI DSI Display

2023-05-12 Thread Neil Armstrong
| 3 + 23 files changed, 1428 insertions(+), 35 deletions(-) --- base-commit: ac9a78681b921877518763ba0e89202254349d1b change-id: 20230512-amlogic-v6-4-upstream-dsi-ccf-vim3-b8e5217e1f4a Best regards, -- Neil Armstrong

[PATCH v4 05/13] dt-bindings: display: meson-vpu: add third DPI output port

2023-05-12 Thread Neil Armstrong
Add third port corresponding to the ENCL DPI encoder used to connect to DSI or LVDS transceivers. Signed-off-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Reviewed-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/amlogic,meson-vpu.yaml | 5

[PATCH v4 08/13] drm/meson: add DSI encoder

2023-05-12 Thread Neil Armstrong
This adds an encoder bridge designed to drive a MIPI-DSI display by using the ENCL encoder through the internal MIPI DSI transceiver connected to the output of the ENCL pixel encoder. Signed-off-by: Neil Armstrong Reviewed-by: Jagan Teki Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/

[PATCH v4 03/13] clk: meson: g12a: make VCLK2 and ENCL clock path configurable by CCF

2023-05-12 Thread Neil Armstrong
In order to setup the DSI clock, let's make the unused VCLK2 clock path configuration via CCF. The nocache option is removed from following clocks: - vclk2_sel - vclk2_input - vclk2_div - vclk2 - vclk_div1 - vclk2_div2_en - vclk2_div4_en - vclk2_div6_en - vclk2_div12_en - vclk2_div2 - vclk2_div4 -

[PATCH v4 06/13] drm/meson: fix unbind path if HDMI fails to bind

2023-05-12 Thread Neil Armstrong
If the case the HDMI controller fails to bind, we try to unbind all components before calling drm_dev_put() which makes drm_bridge_detach() crash because unbinding the HDMI controller frees the bridge memory. The solution is the unbind all components at the end like in the remove path. Signed-off

[PATCH v4 10/13] phy: amlogic: phy-meson-g12a-mipi-dphy-analog: fix CNTL2_DIF_TX_CTL0 value

2023-05-12 Thread Neil Armstrong
Use the same CNTL2_DIF_TX_CTL0 value used by the vendor, it was reported fixing timings issues. Fixes: 2a56dc650e54 ("phy: amlogic: Add G12A Analog MIPI D-PHY driver") Signed-off-by: Neil Armstrong --- drivers/phy/amlogic/phy-meson-g12a-mipi-dphy-analog.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v4 07/13] drm/meson: venc: add ENCL encoder setup for MIPI-DSI output

2023-05-12 Thread Neil Armstrong
This adds supports for the ENCL encoder connected to a MIPI-DSI transceiver on the Amlogic AXG, G12A, G12B & SM1 SoCs. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 25 drivers/gpu/drm/meson/meson_venc.c | 211 +

[PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-12 Thread Neil Armstrong
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic SoCs. Signed-off-by: Neil Armstrong Signed-off-by: Neil Armstrong --- .../display/amlogic,me

[PATCH v4 09/13] drm/meson: add support for MIPI-DSI transceiver

2023-05-12 Thread Neil Armstrong
The Amlogic G12A/G12B/SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on other Amlogic SoCs. This adds support for the Glue managing the transceiver, mimicing the init flow provided by Am

[PATCH v4 11/13] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate

2023-05-12 Thread Neil Armstrong
This updates the panel timings to achieve a clean 60Hz refresh rate. Link: https://lore.kernel.org/r/20221025-ts050-timings-v1-1-5c824bbb2...@linaro.org Signed-off-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-khadas-ts050.c | 16 1 file changed, 8 insertions(+), 8 deletio

[PATCH v4 12/13] arm64: meson: g12-common: add the MIPI DSI nodes

2023-05-12 Thread Neil Armstrong
Add the MIPI DSI Analog & Digital PHY nodes and the DSI control nodes with proper port endpoint to the VPU. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 70 +++ 1 file changed, 70 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH v4 13/13] DONOTMERGE: arm64: meson: khadas-vim3l: add DSI panel

2023-05-12 Thread Neil Armstrong
This add nodes to support the Khadas TS050 panel on the Khadas VIM3 & VIM3L boards. Signed-off-by: Neil Armstrong --- .../boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 76 ++ .../boot/dts/amlogic/meson-sm1-khadas-

Re: [PATCH 09/10] udf: Replace license notice with SPDX identifier

2023-05-12 Thread Jan Kara
On Thu 11-05-23 20:34:05, Bagas Sanjaya wrote: > Except Kconfig and Makefile, all source files for UDF filesystem doesn't > bear SPDX license identifier. Add appropriate license identifier while > replacing boilerplates. > > Cc: Thomas Gleixner > Signed-off-by: Bagas Sanjaya > --- > fs/udf/ball

Re: [PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-05-12 Thread Linus Walleij
Sorry for late regression detection but this patch regresses the Integrator AB IMPD-1 graphics, I bisected down to this patch. On Mon, Jan 2, 2023 at 12:30 PM Thomas Zimmermann wrote: > Fix the color-format selection of the single-probe helper. Go > through all user-specified values and test eac

Re: [PATCH v2 09/10] udf: Replace license notice with SPDX identifier

2023-05-12 Thread Richard Fontana
On Fri, May 12, 2023 at 6:07 AM Bagas Sanjaya wrote: > diff --git a/fs/udf/ecma_167.h b/fs/udf/ecma_167.h > index de17a97e866742..b2b5bca45758df 100644 > --- a/fs/udf/ecma_167.h > +++ b/fs/udf/ecma_167.h > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: BSD-2-Clause OR GPL-1.0+ */ > /* > * ecma

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH 00/11] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-12 Thread Sam Ravnborg
Hi Thomas, > > > > Nice cleanup. > > > > From one of the patches: > > > > > +config DRM_ARMADA_FBDEV_EMULATION > > > + bool > > > + depends on DRM_ARMADA > > > + select FB_CFB_COPYAREA > > > + select FB_CFB_FILLRECT > > > + select FB_CFB_IMAGEBLIT > > > > This seems like a

Re: [PATCH] drm/ssd130x: Fix include guard name

2023-05-12 Thread Sam Ravnborg
On Fri, May 12, 2023 at 02:02:31PM +0200, Javier Martinez Canillas wrote: > This is a leftover from an early iteration of the driver when it was still > named ssd1307 instead of ssd130x. Change it for consistency with the rest. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Sam Ravnborg

RE: [PATCH 04/11] drm/radeon: Use regular fbdev I/O helpers

2023-05-12 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Zimmermann > Sent: Friday, May 12, 2023 4:42 AM > To: dan...@ffwll.ch; airl...@gmail.com; maarten.lankho...@linux.intel.com; > mrip...@kernel.org; javi...@redhat.com > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; >

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 Bagas Sanjaya (bagasdo...@gmail.com) changed: What|Removed |Added CC||bagasdo...@gmail.co

[Bug 217432] AMDGPU crash on shutdown

2023-05-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217432 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- The patch was cc'ed to stable as well, so it should land there soon. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assigne

Re: [PATCH] drm/amd/display: Simplify the calculation of variables

2023-05-12 Thread Hamza Mahfooz
On 5/12/23 03:04, Jiapeng Chong wrote: ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:586:37-39: WARNING !A || A && B is equivalent to !A || B. ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:595:37-39: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Link: h

  1   2   >