Re: [PATCH 48/53] drm/tiny: Convert to platform remove callback returning void

2023-05-08 Thread Thomas Zimmermann
Hi, the subject line is a bit ugly. You may want to change the it to say either 'drm/tiny/arcgpu' or just 'drm/arcgpu'. Same for the other tiny/-related patches. Best regards Thomas Am 07.05.23 um 18:26 schrieb Uwe Kleine-König: The .remove() callback for a platform driver returns an int wh

Re: [PATCH 22/53] drm/imx/ipuv3: Convert to platform remove callback returning void

2023-05-08 Thread Philipp Zabel
On So, 2023-05-07 at 18:25 +0200, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typical

Re: [PATCH v2 RESEND] drm/vram-helper: fix function names in vram helper doc

2023-05-08 Thread Thomas Zimmermann
Hi Am 08.05.23 um 02:09 schrieb Luc Ma: From: Luc Ma Refer to drmm_vram_helper_init() instead of the non-existent drmm_vram_helper_alloc_mm(). Fixes: a5f23a72355d ("drm/vram-helper: Managed vram helpers") Signed-off-by: Luc Ma Reviewed-by: Thomas Zimmermann Thanks for the patch. I'll add

Re: [PATCH 48/53] drm/tiny: Convert to platform remove callback returning void

2023-05-08 Thread Uwe Kleine-König
On Mon, May 08, 2023 at 09:03:30AM +0200, Thomas Zimmermann wrote: > Hi, > > the subject line is a bit ugly. You may want to change the it to say either > 'drm/tiny/arcgpu' or just 'drm/arcgpu'. Same for the other tiny/-related > patches. Oh, indeed non-optimal. There is this patch touching arcpg

Re: [PATCH v12 0/2] drm: add kms driver for loongson display controller

2023-05-08 Thread Sui Jingfeng
Hi, If there are bugs, We will take the responsibility to fix. Is there any chance to merge this patch? comments and review are also welcome, help please! On 2023/5/4 16:04, Sui Jingfeng wrote: Loongson display controller IP has been integrated in both Loongson north bridge chipset(ls7a100

Re: [PATCH v12 0/2] drm: add kms driver for loongson display controller

2023-05-08 Thread Sui Jingfeng
This patch is tested against IGT, 1) fbdev test passed IGT-Version: 1.27.1-gce91d123 (loongarch64) (Linux: 6.3.0+ loongarch64) Starting subtest: info Subtest info: SUCCESS (0.000s) Starting subtest: pan Subtest pan: SUCCESS (0.042s) Starting subtest: read Subtest read: SUCCESS (0.012s) Startin

Re: [PATCH 2/4] drm/mgag200: Simplify offset and scale computation.

2023-05-08 Thread Thomas Zimmermann
Hi Am 05.05.23 um 14:43 schrieb Jocelyn Falempe: Now that the driver handles only 16, 24 and 32-bit framebuffer, it can be simplified. I think it should say that the driver never really handled 8-bit colors. Or at least I'm not aware of. No functional changes. offset: 16bit: (bppshift =

Re: [PATCH] phy: mediatek: fix returning garbage

2023-05-08 Thread Vinod Koul
On 05-05-23, 17:37, Matthias Brugger wrote: > > > On 05/05/2023 11:28, Vinod Koul wrote: > > On 14-04-23, 08:22, Tom Rix wrote: > > > clang reports > > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable > > >'ret' is uninitialized when used here [-Werror,-Wuninitialized] > >

Re: [PATCH v12 0/2] drm: add kms driver for loongson display controller

2023-05-08 Thread Sui Jingfeng
kms_flip test simple of IGT run finished,  a few tail lines of the full log is pasted here. as following: Dynamic subtest AB-HDMI-A1-HDMI-A2: FAIL (0.771s) Subtest 2x-modeset-vs-vblank-race-interruptible: FAIL (0.771s) Starting subtest: bo-too-big-interruptible Starting dynamic subtest: A-HDMI

[PATCH v5 1/4] vkms: Pass the correct bitmask for possible crtcs

2023-05-08 Thread Marius Vlad
In preparation of having multiple pipelines we need to able to choose the correct encoder/connectors/crtc combination so pass also the index as a bitmask as possible CRTCs for the encoder. Signed-off-by: Marius Vlad --- drivers/gpu/drm/vkms/vkms_output.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v5 0/4] drm/vkms: Add support for multiple pipes

2023-05-08 Thread Marius Vlad
With multiple pipe available we can perform management of outputs at a more granular level, such that we're able to turn off or on several outputs at a time, or combinations that arise from doing that. The Weston project use VKMS when running its test suite in CI, and we have now uses cases which

[PATCH v5 3/4] vkms: Add support for multiple pipes

2023-05-08 Thread Marius Vlad
This adds support for creating multiple virtual pipes, in case one would need to display multiple independent things on different outputs. We use a module parameter to specify how many to create, defaulting to just one with the possibility of specifying a maximum of 4 possible pipes. This is of

[PATCH v5 4/4] Documentation/gpu/vkms.rst: Added a note about plane migration

2023-05-08 Thread Marius Vlad
And remove the run-time configuration comment regarding needing first more than 1 pipe. Signed-off-by: Marius Vlad --- Documentation/gpu/vkms.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst index 0f599c897614..5

[PATCH v5 2/4] drm/vkms: Add overlay_planes config

2023-05-08 Thread Marius Vlad
And init it by default to NUM_OVERLAY_PLANES. This change would allow us to configure the amount of overlay planes we can have in combination with multiple pipes, in case we'll exceed the number of planes we can have. Signed-off-by: Marius Vlad --- drivers/gpu/drm/vkms/vkms_drv.c| 2 ++ driv

Re: [PATCH v4 2/3] vkms: Add support for multiple pipes

2023-05-08 Thread Marius Vlad
On 5/4/23 15:20, Maíra Canal wrote: Hi Marius, I'm not sure if you'll keep working in this series after the proposal of the Chromium folks. Anyway, just a small comment. Hi Maíra, No worries, thanks for a lot for taking another look. I've added another patch to adjust the number of overalys,

Re: [PATCH 4/4] drm/mgag200: Use DMA to copy the framebuffer to the VRAM

2023-05-08 Thread Thomas Zimmermann
Hi Jocelyn Am 05.05.23 um 14:43 schrieb Jocelyn Falempe: Even if the transfer is not faster, it brings significant improvement in latencies and CPU usage. I think I shot down this patch already. I don't want to maintain the extra code for DMA support. CPU usage drops from 100% of one cor

Re: [PATCH 38/53] drm/rockchip: Convert to platform remove callback returning void

2023-05-08 Thread Heiko Stübner
Am Sonntag, 7. Mai 2023, 18:26:01 CEST schrieb Uwe Kleine-König: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this

Re: [PATCH] phy: mediatek: fix returning garbage

2023-05-08 Thread Matthias Brugger
On 08/05/2023 09:48, Vinod Koul wrote: On 05-05-23, 17:37, Matthias Brugger wrote: On 05/05/2023 11:28, Vinod Koul wrote: On 14-04-23, 08:22, Tom Rix wrote: clang reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Fri, 5 May 2023 21:51:41 +0200 Daniel Vetter wrote: > On Fri, May 05, 2023 at 05:57:37PM +0200, Sebastian Wick wrote: > > On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > > > > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > > > Hi all, > > > > > > > > The goal of

Re: [PATCH 28/53] drm/mediatek: Convert to platform remove callback returning void

2023-05-08 Thread Matthias Brugger
On 07/05/2023 18:25, Uwe Kleine-König wrote: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in re

Re: [PATCH 29/53] drm/mediatek: Convert to platform remove callback returning void

2023-05-08 Thread Matthias Brugger
On 07/05/2023 18:25, Uwe Kleine-König wrote: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in re

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 21:07, Dmitry Baryshkov wrote: > To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be > enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. > > Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support") > Signed-off-by: Dmitry Baryshko

Re: [PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 21:07, Dmitry Baryshkov wrote: > Add the qcom,controlled-remotely property for the blsp2_bam > controller node. This board requires this, otherwise the board stalls > during the boot for some reason (most probably because TZ mishandles the > protection error and keeps on looping som

[PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel

2023-05-08 Thread Liu Ying
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel compatible string. The panel has a LVDS display interface. The panel's product specification can be found at: http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf Acked-by: Krzysztof Kozlowski Signed-off

[PATCH v2 0/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-08 Thread Liu Ying
Hi, This patch series aims to add BOE EV121WXM-N10-1850 panel support in the DRM simple panel driver. Patch 1/2 adds dt-bindings support for the panel. Patch 2/2 adds the panel support in the DRM simple panel driver. v1->v2: * Add Krzysztof's A-b tag on patch 1/2. * Use struct display_timing in

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 21:07, Dmitry Baryshkov wrote: > Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region > differs from the one defined in the msm8974, so it overriden locally. > > The modem is specified use mba.mbn instead of mbn.b00 (for the sake of > similarity with other platforms).

[PATCH v2 2/2] drm/panel: panel-simple: Add BOE EV121WXM-N10-1850 panel support

2023-05-08 Thread Liu Ying
Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel support. The panel has a LVDS display interface. The panel's product specification can be found at: http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpecification_20180801.pdf Signed-off-by: Liu Ying --- v1->v2: * Use struct di

Re: [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 21:07, Dmitry Baryshkov wrote: > Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard. > > Signed-off-by: Dmitry Baryshkov > --- > .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boo

Re: [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 18:00, Marijn Suijten wrote: > On 2023-05-05 14:23:50, Jessica Zhang wrote: >> Add DATA_COMPRESS feature flag to DPU INTF block. >> >> In DPU 7.x and later, DSC/DCE enablement registers have been moved from >> PINGPONG to INTF. >> >> As core_rev (and related macros) was removed from

Re: [PATCH v3 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 10:14, Krzysztof Kozlowski wrote: > On 05/05/2023 23:40, Konrad Dybcio wrote: >> SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with >> the main exception being that the last one requires an additional >> throttle clock. >> >> It is not well understood yet, but fai

Re: [PATCH v3 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 10:19, Krzysztof Kozlowski wrote: > On 05/05/2023 23:40, Konrad Dybcio wrote: >> Document the SM6350 MDSS. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 >> + >> 1 file changed, 214 insertions(+) >> >> di

Re: [PATCH v3 08/12] drm/msm/dpu: Add SM6375 support

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 22:02, Dmitry Baryshkov wrote: > On 06/05/2023 00:40, Konrad Dybcio wrote: >> Add basic SM6375 support to the DPU1 driver to enable display output. >> >> Signed-off-by: Konrad Dybcio >> --- >>   .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 >> + >>  

Re: [PATCH v4 0/4] drm: sun4i: set proper TCON0 DCLK rate in DSI mode

2023-05-08 Thread Frank Oltmanns
Hi Roman, On 2023-05-05 at 07:21:06 +0200, Roman Beranek wrote: > According to Allwinner's BSP code, in DSI mode, TCON0 clock needs to be > running at what's effectively the per-lane datarate of the DSI link. > Given that the TCON DCLK divider is fixed to 4 (SUN6I_DSI_TCON_DIV), > DCLK can't be s

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Fri, 5 May 2023 16:04:35 -0500 Steven Kucharzyk wrote: > Hi, > > I'm new to this list and probably can't contribute but interested, I > passed your original posting to a friend and have enclosed his thoughts > ... old hash or food for thought ??? I ask your forgiveness if you find > this inap

[PATCH] drm/i915: Fix memory leaks in function live_nop_switch

2023-05-08 Thread Cong Liu
Be sure to properly free the allocated memory before exiting the live_nop_switch function. Signed-off-by: Cong Liu --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.

Re: [PATCH] phy: mediatek: fix returning garbage

2023-05-08 Thread Vinod Koul
On 08-05-23, 10:24, Matthias Brugger wrote: > > > On 08/05/2023 09:48, Vinod Koul wrote: > > On 05-05-23, 17:37, Matthias Brugger wrote: > > > > > > > > > On 05/05/2023 11:28, Vinod Koul wrote: > > > > On 14-04-23, 08:22, Tom Rix wrote: > > > > > clang reports > > > > > drivers/phy/mediatek/phy

Re: [PATCH v2] phy: mediatek: rework the floating point comparisons to fixed point

2023-05-08 Thread Matthias Brugger
On 02/05/2023 16:50, Tom Rix wrote: gcc on aarch64 reports drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function ‘mtk_hdmi_pll_set_rate’: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:240:52: error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types 240 | e

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Simon Ser
On Friday, May 5th, 2023 at 21:53, Daniel Vetter wrote: > On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > > On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > > > > > Ok no comments from me on the actual color operations and semantics of all > > > that, because I have simply

Re: [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-08 Thread Konrad Dybcio
On 6.05.2023 16:46, Akhil P Oommen wrote: > On Fri, May 05, 2023 at 12:35:18PM +0200, Konrad Dybcio wrote: >> >> >> On 5.05.2023 10:46, Akhil P Oommen wrote: >>> On Thu, May 04, 2023 at 08:34:07AM +0200, Konrad Dybcio wrote: On 3.05.2023 22:32, Akhil P Oommen wrote: > On Tue,

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Daniel Vetter
On Mon, 8 May 2023 at 10:24, Pekka Paalanen wrote: > > On Fri, 5 May 2023 21:51:41 +0200 > Daniel Vetter wrote: > > > On Fri, May 05, 2023 at 05:57:37PM +0200, Sebastian Wick wrote: > > > On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > > > > > > > On Thu, May 04, 2023 at 03:22:59PM +

Re: [RFC PATCH v1 2/3] ARM: dts: qcom: msm8974: add support for the HDMI output

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 22:28, Dmitry Baryshkov wrote: > Add HDMI and HDMI PHY device nodes for the Qualcomm MSM8974 SoC. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 90 - > 1 file changed, 89 insertions(+), 1 deletion(-) > > diff --git

Re: [RFC PATCH v1 3/3] ARM: dts: qcom: apq8074-dragonboard: enable HDMI output

2023-05-08 Thread Konrad Dybcio
On 7.05.2023 22:28, Dmitry Baryshkov wrote: > Enable HDMI output on the APQ8074 dragonboard device. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 30 +++ > 1 file changed, 30 insertions(+) > > d

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Daniel Vetter
On Mon, 8 May 2023 at 10:58, Simon Ser wrote: > > On Friday, May 5th, 2023 at 21:53, Daniel Vetter wrote: > > > On Fri, May 05, 2023 at 04:06:26PM +, Simon Ser wrote: > > > On Friday, May 5th, 2023 at 17:28, Daniel Vetter wrote: > > > > > > > Ok no comments from me on the actual color operat

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel

2023-05-08 Thread Rob Herring
On Mon, 08 May 2023 16:38:25 +0800, Liu Ying wrote: > Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel > compatible string. The panel has a LVDS display interface. > > The panel's product specification can be found at: > http://www.onetech.com.tw/files/EV121WXM-N10-1850ProductSpeci

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Pekka Paalanen
On Mon, 8 May 2023 09:14:18 +1000 Dave Airlie wrote: > On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: > > > > On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > > > > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > > > > > Hi all, > > > > > > > > The goal of this RFC is to

RE: [PATCH v2] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-05-08 Thread Lin, Wayne
[Public] Hi Lyude and Jani, Could you help to review please? Thanks for your time! Regards, Wayne Lin > -Original Message- > From: Wayne Lin > Sent: Thursday, April 27, 2023 3:29 PM > To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org > Cc: ly...@redhat.com; ville.syrj..

[PATCH 6.1 184/611] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-05-08 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 4082b9f5ead4966797dddcfef0905d59e5a83873 ] Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ drivers/gpu/drm/amd/amdgpu/../

[PATCH 6.1 215/611] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-05-08 Thread Greg Kroah-Hartman
From: Thomas Hellström [ Upstream commit 379989e7cbdc7aa7496a00ee286ec146c7599cf0 ] When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thi

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-08 Thread Jonas Ådahl
On Mon, May 08, 2023 at 09:14:18AM +1000, Dave Airlie wrote: > On Sat, 6 May 2023 at 08:21, Sebastian Wick wrote: > > > > On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > > > > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > > > > > Hi all, > > > > > > > > The goal of this RFC is t

[PATCH 6.1 415/611] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-08 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40: e

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add BOE EV121WXM-N10-1850 panel

2023-05-08 Thread Krzysztof Kozlowski
On 08/05/2023 11:27, Rob Herring wrote: > > On Mon, 08 May 2023 16:38:25 +0800, Liu Ying wrote: >> Add BOE EV121WXM-N10-1850 12.1" WXGA (1280x800) TFT LCD panel >> compatible string. The panel has a LVDS display interface. >> >> The panel's product specification can be found at: >> http://www.one

[PATCH 6.1 609/611] drm/amd/display (gcc13): fix enum mismatch

2023-05-08 Thread Greg Kroah-Hartman
From: Jiri Slaby (SUSE) commit 545094d993f4639482018becda5f2a47d126f0ab upstream. rn_vbios_smu_set_dcn_low_power_state() produces a valid warning with gcc-13: drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:237:6: error: conflicting types for 'rn_vbios_smu_set_dcn_low_powe

Re: [PATCH v3 08/12] drm/msm/dpu: Add SM6375 support

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 11:43, Konrad Dybcio wrote: On 7.05.2023 22:02, Dmitry Baryshkov wrote: On 06/05/2023 00:40, Konrad Dybcio wrote: Add basic SM6375 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio ---   .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 11:30, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu suppor

[PATCH 6.2 190/663] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-05-08 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 4082b9f5ead4966797dddcfef0905d59e5a83873 ] Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ drivers/gpu/drm/amd/amdgpu/../

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-08 Thread Konrad Dybcio
On 8.05.2023 12:24, Dmitry Baryshkov wrote: > On 08/05/2023 11:30, Konrad Dybcio wrote: >> >> >> On 7.05.2023 21:07, Dmitry Baryshkov wrote: >>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be >>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. >

[PATCH 6.2 222/663] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-05-08 Thread Greg Kroah-Hartman
From: Thomas Hellström [ Upstream commit 379989e7cbdc7aa7496a00ee286ec146c7599cf0 ] When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thi

[PATCH] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK

2023-05-08 Thread Konrad Dybcio
#define WB_SM8250_MASK (BIT(DPU_WB_LINE_MODE) | \ BIT(DPU_WB_UBWC) | \ --- base-commit: c47189dee0decd9ecc1e65ae376ad6d4b0b7f1f2 change-id: 20230508-topic-hctl_en-3abb999a6c99 Best regards, -- Konrad Dybcio

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 13:28, Konrad Dybcio wrote: On 8.05.2023 12:24, Dmitry Baryshkov wrote: On 08/05/2023 11:30, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be enabled. Pass it to the GPU to get it to work

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 11:33, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region differs from the one defined in the msm8974, so it overriden locally. The modem is specified use mba.mbn instead of mbn.b00 (for the sake of

Re: [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 11:34, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard. Signed-off-by: Dmitry Baryshkov --- .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++ 1 file changed, 51 insertions

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU

2023-05-08 Thread Konrad Dybcio
On 8.05.2023 12:32, Dmitry Baryshkov wrote: > On 08/05/2023 13:28, Konrad Dybcio wrote: >> >> >> On 8.05.2023 12:24, Dmitry Baryshkov wrote: >>> On 08/05/2023 11:30, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: > To get GPU working with the OCMEM, the oxili

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-08 Thread Konrad Dybcio
On 8.05.2023 12:33, Dmitry Baryshkov wrote: > On 08/05/2023 11:33, Konrad Dybcio wrote: >> >> >> On 7.05.2023 21:07, Dmitry Baryshkov wrote: >>> Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region >>> differs from the one defined in the msm8974, so it overriden locally. >>> >>> The

Re: [PATCH 2/4] ARM: dts: qcom: apq8074-dragonboard: Set DMA as remotely controlled

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 11:32, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: Add the qcom,controlled-remotely property for the blsp2_bam controller node. This board requires this, otherwise the board stalls during the boot for some reason (most probably because TZ mishandles the prote

[PATCH 6.2 458/663] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-08 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40: e

Re: [PATCH 3/4] ARM: dts: qcom: apq8074-dragonboard: enable adsp and MSS

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 13:38, Konrad Dybcio wrote: On 8.05.2023 12:33, Dmitry Baryshkov wrote: On 08/05/2023 11:33, Konrad Dybcio wrote: On 7.05.2023 21:07, Dmitry Baryshkov wrote: Enable ADSP and Modem DSPs on APQ8074 dragonboard. The MSS region differs from the one defined in the msm8974, so it o

Re: [PATCH] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK

2023-05-08 Thread Marijn Suijten
BIT(DPU_INTF_DATA_COMPRESS) > +#define INTF_SC7280_MASK INTF_SC7180_MASK | BIT(DPU_INTF_DATA_COMPRESS) > > #define WB_SM8250_MASK (BIT(DPU_WB_LINE_MODE) | \ > BIT(DPU_WB_UBWC) | \ > > --- > base-commit: c47189dee0decd9ecc1e65ae376ad6d4b0b7f1f2 > change-id: 20230508-topic-hctl_en-3abb999a6c99 > > Best regards, > -- > Konrad Dybcio >

[PATCH 6.3 222/694] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-05-08 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 4082b9f5ead4966797dddcfef0905d59e5a83873 ] Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ drivers/gpu/drm/amd/amdgpu/../

[PATCH 6.3 259/694] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-05-08 Thread Greg Kroah-Hartman
From: Thomas Hellström [ Upstream commit 379989e7cbdc7aa7496a00ee286ec146c7599cf0 ] When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thi

[PATCH 6.3 507/694] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-08 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40: e

Re: [PATCH] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK

2023-05-08 Thread Dmitry Baryshkov
#define WB_SM8250_MASK (BIT(DPU_WB_LINE_MODE) | \ BIT(DPU_WB_UBWC) | \ --- base-commit: c47189dee0decd9ecc1e65ae376ad6d4b0b7f1f2 change-id: 20230508-topic-hctl_en-3abb999a6c99 Best regards, -- Konrad Dybcio -- With best wishes Dmitry

Re: [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-08 Thread Dmitry Baryshkov
On 08/05/2023 14:02, Leonard Lausen wrote: Abhinav Kumar writes: On 5/7/2023 7:15 PM, Bjorn Andersson wrote: When booting with the cable connected on my X13s, 100 is long enough for my display to time out and require me to disconnect and reconnect the cable again. Do we have any idea of why t

[PATCH 5.15 114/371] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings

2023-05-08 Thread Greg Kroah-Hartman
From: Lee Jones [ Upstream commit 4082b9f5ead4966797dddcfef0905d59e5a83873 ] Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:157:21: note: in expansion of macro ‘mmCRTC1_DCFE_MEM_LIGHT_SLEEP_CNTL’ drivers/gpu/drm/amd/amdgpu/../

[PATCH 5.15 127/371] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-05-08 Thread Greg Kroah-Hartman
From: Thomas Hellström [ Upstream commit 379989e7cbdc7aa7496a00ee286ec146c7599cf0 ] When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thi

[PATCH 5.15 252/371] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-08 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40: e

Re: [PATCH v5 3/4] vkms: Add support for multiple pipes

2023-05-08 Thread Maíra Canal
Hi Marius, On 5/8/23 04:53, Marius Vlad wrote: This adds support for creating multiple virtual pipes, in case one would need to display multiple independent things on different outputs. We use a module parameter to specify how many to create, defaulting to just one with the possibility of spec

[PATCH v5 2/6] ipu-v3: Include

2023-05-08 Thread Thomas Zimmermann
The code uses readl() and writel(). Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/gpu/ipu-v3/ipu-prv.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu

[PATCH v5 3/6] fbdev: Include in various drivers

2023-05-08 Thread Thomas Zimmermann
The code uses writel() and similar I/O-memory helpers. Include the header file to get the declarations. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng --- drivers/video/fbdev/arcfb.c | 1 + drivers/video/fbdev/aty/atyfb.h

[PATCH v5 6/6] fbdev: Rename fb_mem*() helpers

2023-05-08 Thread Thomas Zimmermann
Update the names of the fb_mem*() helpers to be consistent with their regular counterparts. Hence, fb_memset() now becomes fb_memset_io(), fb_memcpy_fromfb() now becomes fb_memcpy_fromio() and fb_memcpy_tofb() becomes fb_memcpy_toio(). No functional changes. Signed-off-by: Thomas Zimmermann Revie

[PATCH v5 4/6] fbdev: Include instead of

2023-05-08 Thread Thomas Zimmermann
Replace include statements for with . Fixes the coding style: if a header is available in asm/ and linux/, it is preferable to include the header from linux/. This only affects a few source files, most of which already include . Suggested-by: Sam Ravnborg Signed-off-by: Thomas Zimmermann Review

[PATCH v5 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-08 Thread Thomas Zimmermann
Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such as __raw_readb() or memset_io(). A few architectures used plain system- memory reads and writes. Sparc used

[PATCH v5 1/6] fbdev/matrox: Remove trailing whitespaces

2023-05-08 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Arnd Bergmann Reviewed-by: Sam Ravnborg Reviewed-by: Sui Jingfeng Tested-by: Sui Jingfeng --- drivers/video/fbdev/matrox/matroxfb_accel.c | 6 +++--- drivers/video/fbdev/matrox/matroxfb_base.h | 4 ++-- 2

[PATCH v5 0/6] fbdev: Move framebuffer I/O helpers to

2023-05-08 Thread Thomas Zimmermann
Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture, but they are all equivalent to regular I/O functions of similar names. So use regular functions instead and move all helpers into The fi

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-08 Thread Dmitry Osipenko
On 5/3/23 09:51, Gerd Hoffmann wrote: > On Mon, May 01, 2023 at 06:38:45PM +0300, Dmitry Osipenko wrote: >> On 4/16/23 14:52, Dmitry Osipenko wrote: >>> We have multiple Vulkan context types that are awaiting for the addition >>> of the sync object DRM UAPI support to the VirtIO-GPU kernel driver:

Re: [PATCH v4 0/6] drm/vkms: introduce plane rotation property

2023-05-08 Thread Maíra Canal
On 5/7/23 17:54, Melissa Wen wrote: On 04/18, Maíra Canal wrote: This patchset implements all possible rotation value in vkms. All operations were implemented by software by changing the way the pixels are read. The way the blending is performed can be depicted as: - rotate-0:     (x) >    

Re: [PATCH 39/53] drm/shmobile: Convert to platform remove callback returning void

2023-05-08 Thread Geert Uytterhoeven
On Sun, May 7, 2023 at 6:31 PM Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically

Re: [PATCH 37/53] drm/rcar-du: Convert to platform remove callback returning void

2023-05-08 Thread Geert Uytterhoeven
On Sun, May 7, 2023 at 6:31 PM Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-08 Thread Rob Clark
On Wed, May 3, 2023 at 10:07 AM Gurchetan Singh wrote: > > > > On Mon, May 1, 2023 at 8:38 AM Dmitry Osipenko > wrote: >> >> On 4/16/23 14:52, Dmitry Osipenko wrote: >> > We have multiple Vulkan context types that are awaiting for the addition >> > of the sync object DRM UAPI support to the Virt

Re: [PATCH v2 0/7] drm: sun4i: set proper TCON0 DCLK rate in DSI mode

2023-05-08 Thread Frank Oltmanns
Hello again, On 2023-05-08 at 08:54:28 +0200, Frank Oltmanns wrote: > Hello Roman, > > On 2023-05-03 at 16:22:32 +0200, "Roman Beranek" wrote: >> Hello everyone, >> >> I apologize for my absence from the discussion during past week, I got >> hit with tonsillitis. > > I hope you feel better! > >>

[PATCH] MAINTAINERS: Add Maira to VKMS maintainers

2023-05-08 Thread Maíra Canal
I've been contributing to VKMS with improvements, reviews, testing and debugging. Therefore, add myself as a co-maintainer of the VKMS driver. Signed-off-by: Maíra Canal --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 276298cfc7ee..63e9b1e8c113

Re: [PATCH] drm/panel: Modify innolux hj110iz panel inital code

2023-05-08 Thread Doug Anderson
Hi, On Sat, May 6, 2023 at 2:32 AM Cong Yang wrote: > > Optimize flickering problem and power off sequence GOP timing at sleep in > mode. > When display sleep in raise the potential of all GOP signals to VGHO and then > lower to GND. > > Signed-off-by: Cong Yang > --- > .../gpu/drm/panel/panel

Re: [PATCH] MAINTAINERS: Add Maira to VKMS maintainers

2023-05-08 Thread Javier Martinez Canillas
Maíra Canal writes: > I've been contributing to VKMS with improvements, reviews, testing and > debugging. Therefore, add myself as a co-maintainer of the VKMS driver. > > Signed-off-by: Maíra Canal > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Pl

Re: [PATCH] drm/amdgpu: Remove the unused variable golden_settings_gc_9_4_3

2023-05-08 Thread Alex Deucher
Applied. Thanks! On Sat, May 6, 2023 at 4:11 AM Jiapeng Chong wrote: > > Variable golden_settings_gc_9_4_3 is not effectively used, so delete it. > > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:48:38: warning: > ‘golden_settings_gc_9_4_3’ defined but not used. > > Reported-by: Abaci Robot > Link:

Re: [PATCH 47/53] drm/tilcdc: Convert to platform remove callback returning void

2023-05-08 Thread jyri . sarha
May 7, 2023 at 7:26 PM, "Uwe Kleine-König" mailto:u.kleine-koe...@pengutronix.de?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do

Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes

2023-05-08 Thread andy . shevchenko
Fri, May 05, 2023 at 01:16:55PM +0200, Linus Walleij kirjoitti: > The Nokia 770 is using GPIOs from the global numberspace on the > CBUS node to pass down to the LCD controller. This regresses when we > let the OMAP GPIO driver use dynamic GPIO base. > > The Nokia 770 now has dynamic allocation of

Re: [PATCH v3 3/3] ARM: omap1: Fix up the Nokia 770 board device IRQs

2023-05-08 Thread andy . shevchenko
Fri, May 05, 2023 at 01:16:57PM +0200, Linus Walleij kirjoitti: > The platform devices on the Nokia 770 is using some > board-specific IRQs that get statically assigned to platform > devices in the boardfile. > > This does not work with dynamic IRQ chip bases. > > Utilize the NULL device to defin

Re: [V3] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-08 Thread Sui Jingfeng
Nice patch! I have tested this patch on ls3a5000+ls7a2000+AMDGPU RX550, but it seems that dc_fpu_begin() and dc_fpu_end() will not be called on AMDGPU RX550. But it at least proved that this patch does not introduce bugs to what already works. I can proved that after apply this patch,  glm

Re: [PATCH] Documentation: vkms: clarify devres managed refernce cleanup

2023-05-08 Thread Sean Paul
On Thu, Apr 27, 2023 at 12:02:18PM +0200, Daniel Vetter wrote: > On Tue, Apr 25, 2023 at 08:02:40AM +, Brandon Pollack wrote: > > added documentation to drm_dev_unregister clarifying that devres managed > > devices allocated with devm_drm_dev_alloc do not require calls to > > drm_dev_put. > >

Re: [PATCH] drm/i915: Fix memory leaks in function live_nop_switch

2023-05-08 Thread Rodrigo Vivi
On Mon, May 08, 2023 at 04:50:15PM +0800, Cong Liu wrote: > Be sure to properly free the allocated memory before exiting > the live_nop_switch function. > > Signed-off-by: Cong Liu > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

Re: [V3] drm/amdgpu/display: Enable DC_FP for LoongArch

2023-05-08 Thread Sui Jingfeng
I have tested glmark2 on ls3a5000 with this patch applied, I have also bought a better gpu (vega 56), which is on the way. currently only have a rx550 at hand. I pasted the performance score here, how about this score? Does this looks normal? glmark2 =

  1   2   >