Re: [PATCH 0/5] fbdev: Move framebuffer I/O helpers to

2023-04-27 Thread Thomas Zimmermann
Hi Sam Am 26.04.23 um 21:21 schrieb Sam Ravnborg: Hi Thomas. On Wed, Apr 26, 2023 at 03:04:15PM +0200, Thomas Zimmermann wrote: Fbdev provides helpers for framebuffer I/O, such as fb_readl(), fb_writel() or fb_memcpy_to_fb(). The implementation of each helper depends on the architecture. It's

[PATCH v2] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-04-27 Thread Wayne Lin
[Why] The sequence for collecting down_reply from source perspective should be: Request_n->repeat (get partial reply of Request_n->clear message ready flag to ack DPRX that the message is received) till all partial replies for Request_n are received->new Request_n+1. Now there is chance that drm_

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: drop SSPP's SRC subblock

2023-04-27 Thread Jeykumar Sankaran
On 4/21/2023 5:08 PM, Dmitry Baryshkov wrote: The src_blk declares a lame copy of main SSPP register space. It's offset is always 0. It's length has been fixed to 0x150, while SSPP's length is now correct. Drop the src_blk and access SSPP registers without additional subblock lookup. Signed-o

[PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2023-04-27 Thread Arseniy Krasnov
This adds support for OTP area access on MX30LFxG18AC chip series. Signed-off-by: Arseniy Krasnov --- drivers/mtd/nand/raw/nand_macronix.c | 212 +++ 1 file changed, 212 insertions(+) diff --git a/drivers/mtd/nand/raw/nand_macronix.c b/drivers/mtd/nand/raw/nand_macronix

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-04-27 Thread Petr Tesařík
Hi, On Wed, 19 Apr 2023 12:03:52 +0200 Petr Tesarik wrote: > From: Petr Tesarik > > The goal of my work is to provide more flexibility in the sizing of > SWIOTLB. > > The software IO TLB was designed with these assumptions: > > 1. It would not be used much, especially on 64-bit systems. > 2.

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-04-27 Thread Petr Tesařík
On Wed, 26 Apr 2023 14:53:52 +0200 Greg Kroah-Hartman wrote: > On Wed, Apr 26, 2023 at 02:44:39PM +0200, Petr Tesařík wrote: > > Hi Greg, > > > > On Wed, 26 Apr 2023 14:26:36 +0200 > > Greg Kroah-Hartman wrote: > > > > > On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > > > >

Re: [PATCH v2 0/7] Allow dynamic allocation of software IO TLB bounce buffers

2023-04-27 Thread Petr Tesařík
Hi Greg, On Wed, 26 Apr 2023 14:26:36 +0200 Greg Kroah-Hartman wrote: > On Wed, Apr 26, 2023 at 02:15:20PM +0200, Petr Tesařík wrote: > > Hi, > > > > On Wed, 19 Apr 2023 12:03:52 +0200 > > Petr Tesarik wrote: > > > > > From: Petr Tesarik > > > > > > The goal of my work is to provide more

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu: access QSEED registers directly

2023-04-27 Thread Jeykumar Sankaran
On 4/21/2023 5:08 PM, Dmitry Baryshkov wrote: Stop using _sspp_subblk_offset() to get offset of the scaler_blk. Inline this function and use ctx->cap->sblk->scaler_blk.base directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 27 +++--

Re: [PATCH V3 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

2023-04-27 Thread whitehat002 whitehat002
Hello, What is the current status of this patch, has it been applied? Alex Deucher 于2023年4月19日周三 21:49写道: > Applied. Thanks! > > Alex > > On Wed, Apr 19, 2023 at 8:24 AM Christian König > wrote: > > > > Am 19.04.23 um 14:20 schrieb hackyzh002: > > > The type of size is unsigned, if size is 0x

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: access CSC/CSC10 registers directly

2023-04-27 Thread Jeykumar Sankaran
On 4/21/2023 5:08 PM, Dmitry Baryshkov wrote: Stop using _sspp_subblk_offset() to get offset of the csc_blk. Inline this function and use ctx->cap->sblk->csc_blk.base directly. As this was the last user, drop _sspp_subblk_offset() too. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/m

RE: [PATCH 07/14] drm/mgag200: Replace simple-KMS with regular atomic helpers

2023-04-27 Thread kernel
On Wed, Apr 26, 2023 at 3:15 AM Thomas Zimmermann wrote: > Oh, now I got it. This G200eW is broken. The other one is good. And the > kernel is also broken on the G200EH? Correct, which doesn't make much sense. I have two Dells, both of which have 102b:0532, but only one has no video. On your s

Re: [Intel-xe] [PATCH 02/14] drm/xe: Introduce the dev_coredump infrastructure.

2023-04-27 Thread Thomas Hellström
On 4/26/23 22:57, Rodrigo Vivi wrote: The goal is to use devcoredump infrastructure to report error states captured at the crash time. The error state will contain useful information for GPU hang debug, such as INSTDONE registers and the current buffers getting executed, as well as any other i

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-27 Thread Pin-yen Lin
On Thu, Apr 20, 2023 at 5:10 PM Pin-yen Lin wrote: > > On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2023-04-13 17:22:46) > > > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > > > > > Actually the `mode-switch` property here is mainly because > > > > `fwnode_

[PATCH v2 2/2] drm/mediatek: Add DSI support for mt8188 vdosys0

2023-04-27 Thread Jason-JH . Lin
Add DSI as main display output for mt8188 vdosys0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 + drivers/gpu/drm/mediatek/mtk_d

[PATCH v2 0/2] Add dynamic connector selection mechanism

2023-04-27 Thread Jason-JH . Lin
To support DSI and eDP as main display connector without modifying mtk-drm driver, we add the dynamic connector selection mechanism. Change in v2: 1. rebase on linux-next: next-20230426 2. Fix alphabetical order and max_num condition check problem. Change in v1: 1. based on mediatek-drm maintaine

[PATCH v2 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-04-27 Thread Jason-JH . Lin
1. Move output drm connector from each ddp_path array to connector array. 2. Add dynamic select available connector flow in crtc create and enable. Signed-off-by: Nancy Lin Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/guc/slpc: Provide sysfs for efficient freq

2023-04-27 Thread Andi Shyti
Hi Vinay, On Tue, Apr 25, 2023 at 05:39:41PM -0700, Vinay Belgaumkar wrote: > SLPC enables use of efficient freq at init by default. It is > possible for GuC to request frequencies that are higher than > the 'software' max if user has set it lower than the efficient > level. > > Scenarios/tests t

Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/selftest: Update the SLPC selftest

2023-04-27 Thread Andi Shyti
Hi Vinay, On Tue, Apr 25, 2023 at 05:39:42PM -0700, Vinay Belgaumkar wrote: > Use the new efficient frequency toggling interface. Also > create a helper function to restore the frequencies after > the test is done. > > v2: Restore max freq first and then min. > > Signed-off-by: Vinay Belgaumkar

Re: [PATCH v3 3/7] arm64: dts: allwinner: a64: assign PLL_MIPI to CLK_TCON0

2023-04-27 Thread Maxime Ripard
On Thu, Apr 27, 2023 at 11:16:07AM +0200, Roman Beranek wrote: > Assign pll-mipi parent to tcon0's source clock via 'assigned-clocks'. > > Signed-off-by: Roman Beranek Again, you should be doing it in the driver, not the device tree. Maxime signature.asc Description: PGP signature

Re: [PATCH v3 4/7] arm64: dts: allwinner: a64: reset pll-video0 rate

2023-04-27 Thread Maxime Ripard
Hi, I'm not sure I understand what you're doing here On Thu, Apr 27, 2023 at 11:16:08AM +0200, Roman Beranek wrote: > With pll-mipi as its source clock, the exact rate to which TCON0's data > clock can be set to is constrained by the current rate of pll-video0. What in the TCON exactly is constr

Re: [PATCH v2] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-27 Thread Daniel Vetter
On Thu, Apr 20, 2023 at 02:47:24AM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/4/17 15:29, Thomas Zimmermann wrote: > > Hi > > > > Am 14.04.23 um 12:58 schrieb Sui Jingfeng: > > > Hi, > > > > > > On 2023/4/14 03:16, Thomas Zimmermann wrote: > > > > Hi, > > > > > > > > thanks for the patch. Thi

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-27 Thread Daniel Vetter
On Fri, Apr 21, 2023 at 07:47:26AM -0700, Rob Clark wrote: > On Fri, Apr 21, 2023 at 2:33 AM Emil Velikov wrote: > > > > Greeting all, > > > > Sorry for the delay - Easter Holidays, food coma and all that :-) > > > > On Tue, 18 Apr 2023 at 15:31, Rob Clark wrote: > > > > > > On Tue, Apr 18, 2023

Re: [PATCH] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-27 Thread Daniel Vetter
On Thu, Apr 20, 2023 at 11:15:24AM +0200, Geert Uytterhoeven wrote: > Hi Daniel, > > On Wed, Apr 19, 2023 at 6:38 PM Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 08:42:46PM +0200, Geert Uytterhoeven wrote: > > > Fbtest contains some very simple validation of the fbdev userspace API > > > cont

Re: [PATCH v2 1/3] drm: Create support for Write-Only property blob

2023-04-27 Thread Daniel Vetter
On Fri, Apr 21, 2023 at 12:27:47PM -0400, Mark Yacoub wrote: > From: Mark Yacoub > > [Why] > User space might need to inject data into the kernel without allowing it > to be read again by any user space. > An example of where this is particularly useful is secret keys fetched > by user space and

Re: [PATCH] Documentation: vkms: clarify devres managed refernce cleanup

2023-04-27 Thread Daniel Vetter
On Tue, Apr 25, 2023 at 08:02:40AM +, Brandon Pollack wrote: > added documentation to drm_dev_unregister clarifying that devres managed > devices allocated with devm_drm_dev_alloc do not require calls to > drm_dev_put. > > Signed-off-by: Brandon Pollack > > --- > > This is my first patch to

Re: [PATCH 0/5] fbdev: Move framebuffer I/O helpers to

2023-04-27 Thread Arnd Bergmann
On Thu, Apr 27, 2023, at 08:22, Thomas Zimmermann wrote: > Am 26.04.23 um 21:21 schrieb Sam Ravnborg: >> On Wed, Apr 26, 2023 at 03:04:15PM +0200, Thomas Zimmermann wrote: >>> Fbdev provides helpers for framebuffer I/O, such as fb_readl(), >>> fb_writel() or fb_memcpy_to_fb(). The implementation of

[PULL] drm-intel-next-fixes

2023-04-27 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one Cc stable SKL+ pipe source size fix for #8357: CML-U: external 5120x2160 monitor can't play video. Best Regards, Joonas *** drm-intel-next-fixes-2023-04-27: One cc stable for pipe source size check on SKL+ The following changes since commit 2c69679626d5daa680d71c77a

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-04-27 Thread Hogander, Jouni
On Thu, 2023-03-09 at 14:34 +0200, Ville Syrjälä wrote: > On Thu, Mar 09, 2023 at 12:09:55PM +0100, Maarten Lankhorst wrote: > > > > On 2023-03-09 12:04, Hogander, Jouni wrote: > > > On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: > > > > On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten L

Re: [PATCH V3 0/3] drm/panel: Add Anbernic RG353V-V2 Panel

2023-04-27 Thread Neil Armstrong
Hi, On Wed, 26 Apr 2023 09:32:10 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add the NewVision NV3051D panel as found on the second revision of the > RG353V. The underlying LCD panel itself is unknown (ST7703 is the > controller IC). > > Changes from V2: > - Rebased patch series (to ad

Re: [PATCH V3 0/3] drm/panel: Add Anbernic RG353V-V2 Panel

2023-04-27 Thread Neil Armstrong
On 27/04/2023 13:47, Neil Armstrong wrote: Hi, On Wed, 26 Apr 2023 09:32:10 -0500, Chris Morgan wrote: From: Chris Morgan Add the NewVision NV3051D panel as found on the second revision of the RG353V. The underlying LCD panel itself is unknown (ST7703 is the controller IC). Changes from V2:

Re: [PATCH] dt-bindings: display: simplify compatibles syntax

2023-04-27 Thread Neil Armstrong
On 14/04/2023 12:42, Krzysztof Kozlowski wrote: Lists (items) with one item should be just const or enum because it is shorter and simpler. Signed-off-by: Krzysztof Kozlowski --- Rebased on next-20230406. I hope it applies cleanly... --- .../display/bridge/analogix,anx7625.yaml | 3 +-

Re: [PATCH v2 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-04-27 Thread Matthias Brugger
On 27/04/2023 10:40, Jason-JH.Lin wrote: 1. Move output drm connector from each ddp_path array to connector array. 2. Add dynamic select available connector flow in crtc create and enable. Signed-off-by: Nancy Lin Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/m

Re: [PATCH v2 2/2] drm/mediatek: Add DSI support for mt8188 vdosys0

2023-04-27 Thread Matthias Brugger
On 27/04/2023 10:40, Jason-JH.Lin wrote: Add DSI as main display output for mt8188 vdosys0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + d

[PATCH v2] dt-bindings: display/msm: dsi-controller-main: Document qcom, master-dsi and qcom, sync-dual-dsi

2023-04-27 Thread Jianhua Lu
This fixes warning: sm8250-xiaomi-elish-csot.dtb: dsi@ae94000: Unevaluated properties are not allowed ('qcom,master-dsi', 'qcom,sync-dual-dsi' were unexpected) Reviewed-by: Dmitry Baryshkov Acked-by: Rob Herring Signed-off-by: Jianhua Lu --- Changes in v2: - pick up tags - fix typo (need

[PATCH] drm/scheduler: mark jobs without fence as canceled

2023-04-27 Thread Christian König
When no hw fence is provided for a job that means that the job didn't executed. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/sched_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_

Re: [PATCH v3 2/2] drm/amdgpu: Fix integer overflow in amdgpu_cs_pass1

2023-04-27 Thread Alex Deucher
As per my prior reply, it has been applied. Thanks, Alex On Thu, Apr 27, 2023 at 8:39 AM whitehat002 whitehat002 wrote: > > hello > What is the current status of this patch, has it been applied? > > > hackyzh002 于2023年4月19日周三 20:23写道: > > > > The type of size is unsigned int, if size is 0x4000

[RFC 0/4] Expose RPS thresholds in sysfs

2023-04-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin >From patch 4: User feedback indicates significant performance gains are possible in specific games with non default RPS up/down thresholds. Expose these tunables via sysfs which will allow users to achieve best performance when running games and best power

[RFC 1/4] drm/i915: Move setting of rps thresholds to init

2023-04-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since 36d516be867c ("drm/i915/gt: Switch to manual evaluation of RPS") thresholds are invariant so lets move their setting to init time. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_rps.c | 27 --- 1 file changed, 16 insertions(+)

[RFC 2/4] drm/i915: Record default rps threshold values

2023-04-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Record the default values as preparation for exposing the sysfs controls. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/gt/intel_rps.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i91

[RFC 3/4] drm/i915: Add helpers for managing rps thresholds

2023-04-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In preparation for exposing via sysfs add helpers for managing rps thresholds. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_rps.c | 36 + drivers/gpu/drm/i915/gt/intel_rps.h | 4 2 files changed, 40 insertions(+) diff -

[RFC 4/4] drm/i915: Expose RPS thresholds in sysfs

2023-04-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin User feedback indicates significant performance gains are possible in specific games with non default RPS up/down thresholds. Expose these tunables via sysfs which will allow users to achieve best performance when running games and best power efficiency elsewhere. Note this

Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-27 Thread Neil Armstrong
Hi, On Sun, 23 Apr 2023 10:53:00 -0400, Tom Rix wrote: > smatch has several simailar warnings to > drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol > 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? > > These variables are only used in their defining file so should b

Re: [PATCH] drm/meson: set variables meson_hdmi_* storage-class-specifier to static

2023-04-27 Thread neil . armstrong
On 23/04/2023 23:36, Martin Blumenstingl wrote: On Sun, Apr 23, 2023 at 4:53 PM Tom Rix wrote: smatch has several simailar warnings to s/simailar/similar/ drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? These

Re: [PATCH v5 9/9] drm: selftest: convert drm_mm selftest to KUnit

2023-04-27 Thread Maxime Ripard
Hi, On Fri, Jul 08, 2022 at 05:30:52PM -0300, Maíra Canal wrote: > From: Arthur Grillo > > Considering the current adoption of the KUnit framework, convert the > DRM mm selftest to the KUnit API. > > Signed-off-by: Arthur Grillo > Tested-by: David Gow > Acked-by: Daniel Latypov > Reviewed-by

Re: [PATCH 4/6] fbdev: Validate info->screen_{base, buffer} in fb_ops implementations

2023-04-27 Thread Thomas Zimmermann
Hi Am 26.04.23 um 16:56 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: Push the test for info->screen_base from fb_read() and fb_write() into the implementations of struct fb_ops.{fb_read,fb_write}. In cases where the driver operates on info->

Re: [PATCH v4 02/22] drm/msm/dpu: Remove TE2 block and feature from DPU >= 5.0.0 hardware

2023-04-27 Thread Dmitry Baryshkov
On 27/04/2023 01:37, Marijn Suijten wrote: No hardware beyond kona (sm8250, DPU 6.0.0) defines the TE2 PINGPONG sub-block offset downstream, and according to insiders no DPU >= 5.0.0 hardware has support for it either. Especially since neither downstream nor upstream utilize these registers in a

[PATCH v1 0/9] drm/bridge: tc358768: various fixes on PLL calculation and DSI timings

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini This series includes multiple fixes on the tc358768 parallel RGB to DSI driver. With the following changes I am able to have a stable display output using a TI SN65DSI83 (DSI-LVDS bridge) and a 1280 x 800 LVDS display panel and the register values are coherent with Toshib

[PATCH v1 4/9] drm/bridge: tc358768: fix TCLK_ZEROCNT computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correct computation of TCLK_ZEROCNT register. This register must be set to a value that ensure that (TCLK-PREPARECNT + TCLK-ZERO) > 300ns with the actual value of (TCLK-PREPARECNT + TCLK-ZERO) being (1 to 2) + (TCLK_ZEROCNT + 1)) x HSByteClkCycle + (PHY output delay) w

[PATCH v1 3/9] drm/bridge: tc358768: fix PLL target frequency

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correctly compute the PLL target frequency, the current formula works correctly only when the input bus width is 24bit, actually to properly compute the PLL target frequency what is relevant is the bits-per-pixel on the DSI link. No regression expected since the DSI forma

[PATCH v1 1/9] drm/bridge: tc358768: always enable HS video mode

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Always enable HS video mode setting the TXMD bit, without this change no video output is present with DSI sinks that are setting MIPI_DSI_MODE_LPM flag (tested with LT8912B DSI-HDMI bridge). Previously the driver was enabling HS mode only when the DSI sink was not explici

[PATCH v1 2/9] drm/bridge: tc358768: fix PLL parameters computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini According to Toshiba documentation the PLL input clock after the divider should be not less than 4MHz, fix the PLL parameters computation accordingly. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc3

[PATCH v1 6/9] drm/bridge: tc358768: fix THS_ZEROCNT computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correct computation of THS_ZEROCNT register. This register must be set to a value that ensure that THS_PREPARE + THS_ZERO > 145ns + 10*UI with the actual value of (THS_PREPARE + THS_ZERO) being ((1 to 2) + 1 + (TCLK_ZEROCNT + 1) + (3 to 4)) x ByteClk cycle + + HSByteC

[PATCH v1 7/9] drm/bridge: tc358768: fix TXTAGOCNT computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correct computation of TXTAGOCNT register. This register must be set to a value that ensure that the TTA-GO period = (4 x TLPX) with the actual value of TTA-GO being 4 x (TXTAGOCNT + 1) x (HSByteClk cycle) Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-

[PATCH v1 9/9] drm/bridge: tc358768: remove unused variable

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Remove the unused phy_delay_nsk variable, before it was wrongly used to compute some register value, the fixed computation is no longer using it and therefore can be removed. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 4 +--- 1 file changed

[PATCH v1 5/9] drm/bridge: tc358768: fix TCLK_TRAILCNT computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correct computation of TCLK_TRAILCNT register. The driver does not implement non-continuous clock mode, so the actual value doesn't make a practical difference yet. However this change also ensures that the value does not write to reserved registers bits in case of under/

[PATCH v1 8/9] drm/bridge: tc358768: fix THS_TRAILCNT computation

2023-04-27 Thread Francesco Dolcini
From: Francesco Dolcini Correct computation of THS_TRAILCNT register. This register must be set to a value that ensure that THS_TRAIL > 60 ns + 4 x UI and THS_TRAIL > 8 x UI and THS_TRAIL < TEOT with TEOT = 105 ns + (12 x UI) with the actual value of THS_TRAIL being (1 + THS_TRAILCNT) x Byt

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-27 Thread Rob Clark
On Thu, Apr 27, 2023 at 2:39 AM Daniel Vetter wrote: > > On Fri, Apr 21, 2023 at 07:47:26AM -0700, Rob Clark wrote: > > On Fri, Apr 21, 2023 at 2:33 AM Emil Velikov > > wrote: > > > > > > Greeting all, > > > > > > Sorry for the delay - Easter Holidays, food coma and all that :-) > > > > > > On T

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-27 Thread Tvrtko Ursulin
On 26/04/2023 16:41, Yang, Fei wrote: > On 26/04/2023 07:24, fei.y...@intel.com wrote: >> From: Fei Yang >> >> The first three patches in this series are taken from >> https://patchwork.freedesktop.org/series/116868/ >> These patches are included here because the last patch >> has depen

Re: [PATCH] drm/scheduler: mark jobs without fence as canceled

2023-04-27 Thread Luben Tuikov
Hi Christian, Patch is, Reviewed-by: Luben Tuikov Regards, Luben On 2023-04-27 08:27, Christian König wrote: > When no hw fence is provided for a job that means that the job didn't > executed. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/scheduler/sched_main.c | 2 +- > 1 file

Re: drm/bridge: it6505: Move a variable assignment behind a null pointer check in receive_timing_debugfs_show()

2023-04-27 Thread Robert Foss
On Tue, Apr 25, 2023 at 4:16 PM Markus Elfring wrote: > > > This patch seems to be a part of a series without being marked as such, > > The mentioned patch affects only a single function implementation. > > > > this causes issues when importing this patch with maintainer tools > > like b4 which au

Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195

2023-04-27 Thread AngeloGioacchino Del Regno
Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto: Il 12/09/22 03:29, Jason-JH.Lin ha scritto: Since the gamma_set_common() function for previous SoC, such as  mt8173 and mt8183, is designed for 9bit-to-10bit conversion. mt8195 is using 10bit-to-12bit conversion, which is not compatible w

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-27 Thread Marijn Suijten
On 2023-04-21 00:31:16, Konrad Dybcio wrote: > Add SM6350 support to the DPU1 driver to enable display output. > > Signed-off-by: Konrad Dybcio > Signed-off-by: Konrad Dybcio After addressing the comments from Dmitry (CURSOR0->DMA1 and CURSOR1->DMA2), this is: Reviewed-by: Marijn Suijten See

Re: [PATCH v2 1/3] drm: Create support for Write-Only property blob

2023-04-27 Thread Sean Paul
On Thu, Apr 27, 2023 at 5:59 AM Daniel Vetter wrote: > > On Fri, Apr 21, 2023 at 12:27:47PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > User space might need to inject data into the kernel without allowing it > > to be read again by any user space. > > An example of where th

Re: [git pull] drm next fixes for 6.4-rc1

2023-04-27 Thread pr-tracker-bot
The pull request you sent on Thu, 27 Apr 2023 11:43:17 +1000: > git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/32f7ad0fbe7521de2a5e8f79c33d46110247fd7c Thank you! -- Deet-doot-dot, I am a bot. htt

Re: [PATCH v2 09/13] drm/msm/dpu: Add SM6375 support

2023-04-27 Thread Marijn Suijten
On 2023-04-21 00:31:18, Konrad Dybcio wrote: > Add basic SM6375 support to the DPU1 driver to enable display output. > > Signed-off-by: Konrad Dybcio > --- > .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_4_sm6350.h | 5 - > .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 >

Re: [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-04-27 Thread Marijn Suijten
On 2023-04-27 17:37:42, Marijn Suijten wrote: > On 2023-04-21 00:31:16, Konrad Dybcio wrote: > > Add SM6350 support to the DPU1 driver to enable display output. > > > > Signed-off-by: Konrad Dybcio > > Signed-off-by: Konrad Dybcio > > After addressing the comments from Dmitry (CURSOR0->DMA1 and

Re: [PATCH] dt-bindings: display: simplify compatibles syntax

2023-04-27 Thread Krzysztof Kozlowski
On 27/04/2023 13:50, Neil Armstrong wrote: > On 14/04/2023 12:42, Krzysztof Kozlowski wrote: >> Lists (items) with one item should be just const or enum because it is >> shorter and simpler. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Rebased on next-20230406. I hope it applies cleanl

Re: [PATCH v10 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-04-27 Thread Dmitry Baryshkov
On 26/04/2023 19:29, Doug Anderson wrote: Hi, On Wed, Apr 19, 2023 at 8:43 AM Mark Yacoub wrote: Hi all, This is v10 of the HDCP patches. The patches are authored by Sean Paul. I rebased and addressed the review comments in v6-v10. Main change in v10 is handling the kernel test bot warnings.

Re: [PATCH v2 2/4] drm/msm/dpu: remove DPU_DSPP_IGC handling in dspp flush

2023-04-27 Thread Dmitry Baryshkov
On 26/04/2023 22:22, Abhinav Kumar wrote: Inverse gamma correction blocks (IGC) are not used today so lets remove the usage of DPU_DSPP_IGC in the dspp flush to make it easier to remove IGC from the catalog. We can add this back when IGC is properly supported in DPU with one of the standard DRM

Re: [PATCH v2 4/4] drm/msm/dpu: drop DSPP_MSM8998_MASK from hw catalog

2023-04-27 Thread Dmitry Baryshkov
On 26/04/2023 22:22, Abhinav Kumar wrote: Since GC and IGC masks have now been dropped DSPP_MSM8998_MASK is same as DSPP_SC7180_MASK. Since DSPP_SC7180_MASK is used more than DSPP_MSM8998_MASK, lets drop the latter. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_

Re: [PATCH v2 3/4] drm/msm/dpu: remove GC related code from dpu catalog

2023-04-27 Thread Dmitry Baryshkov
On 26/04/2023 22:22, Abhinav Kumar wrote: Since Gamma Correction (GC) block is currently unused, drop related code from the dpu hardware catalog otherwise this becomes a burden to carry across chipsets in the catalog. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Link: https://lor

Re: [PATCH v4 05/22] drm/msm/dpu: Fix PP_BLK_DIPHER -> DITHER typo

2023-04-27 Thread Neil Armstrong
On 27/04/2023 00:37, Marijn Suijten wrote: SM8550 exclusively has a DITHER sub-block inside the PINGPONG block and no other registers, hence the DITHER name of the macro and a corresponding PINGPONG block length of zero. However, the PP_BLK_ macro name was typo'd to DIPHER rather than DITHER. F

Re: [PATCH v2] drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2

2023-04-27 Thread Jeff Layton
On Wed, 2023-04-19 at 16:54 -0400, Lyude Paul wrote: > Reviewed-by: Lyude Paul > > Thanks! > > On Wed, 2023-04-19 at 07:24 -0400, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > >

Re: [Intel-gfx] [PATCH v2 0/5] drm/i915: Allow user to set cache at BO creation

2023-04-27 Thread Yang, Fei
> On 26/04/2023 16:41, Yang, Fei wrote: >>> On 26/04/2023 07:24, fei.y...@intel.com wrote: From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has

[PATCH v6] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-27 Thread Won Chung
Create a symlink pointing to USB Type-C connector for DRM connectors when they are created. The link will be created only if the firmware is able to describe the connection beween the two connectors. Currently, even if a display uses a USB Type-C port, there is no way for the userspace to find whi

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix error capture for virtual engines

2023-04-27 Thread Teres Alexis, Alan Previn
On Fri, 2023-04-14 at 17:27 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > GuC based register dumps in error capture logs were basically broken > for virtual engines. This can be seen in igt@gem_exec_balancer@hang: > [IGT] gem_exec_balancer: starting subtest hang > [drm] GP

Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-04-27 Thread Rob Herring
On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote: > The ASP 2.0 Ethernet controller uses a brcm unimac. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

2023-04-27 Thread Florian Fainelli
On 4/27/23 10:03, Rob Herring wrote: On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote: The ASP 2.0 Ethernet controller uses a brcm unimac. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ 1 file ch

Re: [PATCH v2 net-next 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-27 Thread Rob Herring
On Wed, Apr 26, 2023 at 11:54:28AM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > .../devicetree/bindings/net/brcm,asp-v2.0.yaml | 145 >

Re: [PATCH 0/5] fbdev: Move framebuffer I/O helpers to

2023-04-27 Thread Sam Ravnborg
Hi Thomas, On Thu, Apr 27, 2023 at 09:22:47AM +0200, Thomas Zimmermann wrote: > Hi Sam > > Am 26.04.23 um 21:21 schrieb Sam Ravnborg: > > Hi Thomas. > > > > On Wed, Apr 26, 2023 at 03:04:15PM +0200, Thomas Zimmermann wrote: > > > Fbdev provides helpers for framebuffer I/O, such as fb_readl(), >

Re: [PATCH v4 07/22] drm/msm/dpu: Set PINGPONG block length to zero for DPU >= 7.0.0

2023-04-27 Thread Dmitry Baryshkov
On 27/04/2023 01:37, Marijn Suijten wrote: Despite downstream DTS stating otherwise, the PINGPONG block has no registers starting with DPU revision 7.0.0. TEAR registers are gone since DPU 5.0.0 after being moved to the INTF block, and DSC registers are gone since 7.0.0, leaving only the dither

Re: [PATCH v4 18/22] drm/msm/dpu: Describe TEAR interrupt registers for DSI interfaces

2023-04-27 Thread Dmitry Baryshkov
On 27/04/2023 01:37, Marijn Suijten wrote: All SoCs since DPU 5.0.0 have the tear interrupt registers moved out of the PINGPONG block and into the INTF block. Wire up the IRQ register masks in the interrupt table for enabling, reading and clearing them. Signed-off-by: Marijn Suijten --- driv

[PATCH v2 0/9] drm: fdinfo memory stats

2023-04-27 Thread Rob Clark
From: Rob Clark Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with VRAM might want some placement stats as well. But this seems like a reasonable start.

[PATCH v2 1/9] drm/docs: Fix usage stats typos

2023-04-27 Thread Rob Clark
From: Rob Clark Fix a couple missing ':'s. Signed-off-by: Rob Clark Reviewed-by: Rodrigo Vivi --- Documentation/gpu/drm-usage-stats.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/drm-usage-stats.rst b/Documentation/gpu/drm-usage-stats.rst index

[PATCH v2 2/9] drm: Add common fdinfo helper

2023-04-27 Thread Rob Clark
From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. This also ensures consistent behavior across drivers for standardised fields. v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo Reviewed-by: Daniel Vetter

[PATCH v2 6/9] drm/msm: Add memory stats to fdinfo

2023-04-27 Thread Rob Clark
From: Rob Clark Use the new helper to export stats about memory usage. v2: Drop unintended hunk v3: Rebase Signed-off-by: Rob Clark Reviewed-by: Emil Velikov --- drivers/gpu/drm/msm/msm_drv.c | 2 ++ drivers/gpu/drm/msm/msm_gem.c | 15 +++ 2 files changed, 17 insertions(+) diff

[PATCH v2 4/9] drm/amdgpu: Switch to fdinfo helper

2023-04-27 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +- 3 files changed, 9 insertions(+), 12 deletions(-)

[PATCH v2 3/9] drm/msm: Switch to fdinfo helper

2023-04-27 Thread Rob Clark
From: Rob Clark Now that we have a common helper, use it. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 11 +-- drivers/gpu/drm/msm/msm_gpu.c | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_dr

[PATCH v2 5/9] drm: Add fdinfo memory stats

2023-04-27 Thread Rob Clark
From: Rob Clark Add support to dump GEM stats to fdinfo. v2: Fix typos, change size units to match docs, use div_u64 v3: Do it in core v4: more kerneldoc Signed-off-by: Rob Clark Reviewed-by: Emil Velikov Reviewed-by: Daniel Vetter --- Documentation/gpu/drm-usage-stats.rst | 54 +++-

[PATCH v2 8/9] drm/fdinfo: Add comm/cmdline override fields

2023-04-27 Thread Rob Clark
From: Rob Clark These are useful in particular for VM scenarios where the process which has opened to drm device file is just a proxy for the real user in a VM guest. Signed-off-by: Rob Clark --- Documentation/gpu/drm-usage-stats.rst | 18 ++ drivers/gpu/drm/drm_file.c

[PATCH v2 7/9] drm/doc: Relax fdinfo string constraints

2023-04-27 Thread Rob Clark
From: Rob Clark The restriction about no whitespace, etc, really only applies to the usage of strings in keys. Values can contain anything (other than newline). Signed-off-by: Rob Clark Acked-by: Tvrtko Ursulin --- Documentation/gpu/drm-usage-stats.rst | 27 ++- 1 fil

[PATCH v2 9/9] drm/msm: Wire up comm/cmdline override for fdinfo

2023-04-27 Thread Rob Clark
From: Rob Clark Also store the override strings in drm_file so that fdinfo can display them. We still need to keep our original copy as we could need these override strings after the device file has been closed and drm_file freed. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno

[PATCH] drm: Switch i2c drivers back to use .probe()

2023-04-27 Thread Uwe Kleine-König
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_dr

Re: [Intel-gfx] [PATCH v8 6/8] drm/i915/uapi/pxp: Add a GET_PARAM for PXP

2023-04-27 Thread Teres Alexis, Alan Previn
(fixed email addresses again - why is my Evolution client deteorating??) On Thu, 2023-04-27 at 17:18 +, Teres Alexis, Alan Previn wrote: > On Wed, 2023-04-26 at 15:35 -0700, Justen, Jordan L wrote: > > On 2023-04-26 11:17:16, Teres Alexis, Alan Previn wrote: > alan:snip > > Can you tell that p

Re: [Intel-gfx] [PATCH v8 6/8] drm/i915/uapi/pxp: Add a GET_PARAM for PXP

2023-04-27 Thread Lionel Landwerlin
On 27/04/2023 21:19, Teres Alexis, Alan Previn wrote: (fixed email addresses again - why is my Evolution client deteorating??) On Thu, 2023-04-27 at 17:18 +, Teres Alexis, Alan Previn wrote: On Wed, 2023-04-26 at 15:35 -0700, Justen, Jordan L wrote: On 2023-04-26 11:17:16, Teres Alexis, Al

Re: [PATCH v2 net-next 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-27 Thread Justin Chen
On Thu, Apr 27, 2023 at 10:16 AM Rob Herring wrote: > > On Wed, Apr 26, 2023 at 11:54:28AM -0700, Justin Chen wrote: > > From: Florian Fainelli > > > > Add a binding document for the Broadcom ASP 2.0 Ethernet > > controller. > > > > Signed-off-by: Florian Fainelli > > Signed-off-by: Justin Chen

Re: [PATCH v3] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-27 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 26, 2023 at 6:55 PM Chia-I Wu wrote: > > mgr->ctx_handles should be protected by mgr->lock. > > v2: improve commit message > v3: add a Fixes tag > > Signed-off-by: Chia-I Wu > Reviewed-by: Christian König > Fixes: 52c6a62c64fac ("drm/amdgpu: add interface for

Re: [PATCH v3 29/65] clk: socfpga: gate: Add a determine_rate hook

2023-04-27 Thread Dinh Nguyen
Hi Maxime, On 4/25/23 09:48, Maxime Ripard wrote: Hi Dinh, On Mon, Apr 24, 2023 at 01:32:28PM -0500, Dinh Nguyen wrote: On 4/4/23 05:11, Maxime Ripard wrote: The SoCFGPA gate clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd

Re: [GIT PULL] fbdev fixes and updates for v6.4-rc1

2023-04-27 Thread pr-tracker-bot
The pull request you sent on Wed, 26 Apr 2023 20:40:07 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.4-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/725a345b2ee3c24f9ac2078eb73667e22a1b7214 Thank you! -- Deet

Re: drm/bridge: it6505: Move a variable assignment behind a null pointer check in receive_timing_debugfs_show()

2023-04-27 Thread Markus Elfring
> Fix the email Sign-off email != Sender email issue, resubmit and I'll > be able to apply this. You can pick the email from my tag “Signed-off-by” up also directly as an ordinary patch author email, can't you? Regards, Markus

  1   2   >