[PATCH v2] drm/bridge: adv7511: fix use after free bug in adv7511_remove due to race condition

2023-04-13 Thread Zheng Wang
In adv7511_probe, adv7511->hpd_work is bound with adv7511_hpd_work. adv7511_irq_process might be called to start the work. If we call adv7511_remove with an unfinished work. There may be a race condition. Here is the possible sequence: CPU0 CPU1 |adv7511_hpd

Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

2023-04-13 Thread Javier Martinez Canillas
p...@panix.com (Pierre Asselin) writes: > After careful reading of the comments in f35cd3fa7729, would this > be an appropriate fix ? Does it still address all the issues raised > by Thomas ? > > (not tested) > > diff --git a/drivers/firmware/sysfb_simplefb.c > b/drivers/firmware/sysfb_simplefb.

[PULL] drm-intel-fixes

2023-04-13 Thread Jani Nikula
Hi Dave & Daniel - One DSI fix, stable material. drm-intel-fixes-2023-04-13: drm/i915 fixes for v6.3-rc7: - Fix dual link DSI for TGL+ BR, Jani. The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d: Linux 6.3-rc6 (2023-04-09 11:15:57 -0700) are available in the Git

Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Andrzej Hajda wrote: > On 13.04.2023 05:13, Cong Liu wrote: A commit message is still needed. >> Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist >> creation") >> No blank line here. BR, Jani. >> Signed-off-by: Cong Liu >> --- > > Reviewed-by:

Re: [PATCH 2/2] drm/mediatek: dp: Add the audio control to mtk_dp_data struct

2023-04-13 Thread 陳柏辰

Re: [PATCH 2/5] dt-bindings: display: panel: nt36523: Add Lenovo J606F panel

2023-04-13 Thread Linus Walleij
On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio wrote: > Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 > video mode display. Document it and allow rotation while at it (Lenovo > mounted it upside down!). > > Signed-off-by: Konrad Dybcio Looks good to me! Reviewed-by: Linus Wal

Re: [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code

2023-04-13 Thread 陳柏辰

Re: [PATCH 3/5] drm/panel: nt36523: Add DCS backlight support

2023-04-13 Thread Linus Walleij
On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio wrote: > This chip supports controlling the backlight via DCS commands, on at > least some panels. Add support for doing so. > > Note this may only concern the NT36523*W* variant. Nobody knows, really, > there's no docs. > > Signed-off-by: Konrad Dybc

Re: [PATCH 4/5] drm/panel: nt36523: Get orientation from OF

2023-04-13 Thread Linus Walleij
On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio wrote: > Some bright vendors mount their display panels upside down. Add the > required pieces to allow for accounting for that. > > Signed-off-by: Konrad Dybcio Reviewed-by: Linus Walleij Yours, Linus Walleij

Re: [PATCH 5/5] drm/panel: nt36523: Add Lenovo J606F panel

2023-04-13 Thread Linus Walleij
I added Novatek contact email to responders. Hi Novatek, can we have a public datasheet for NT36523? We are developing a Linux driver for NT36523-based displays and we need documentation. Thanks. On Wed, Apr 12, 2023 at 9:46 PM Konrad Dybcio wrote: > Some Lenovo J606F tablets come with a 2K (20

Re: [PATCH 1/2] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

2023-04-13 Thread Krzysztof Kozlowski
On 13/04/2023 06:06, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC. > > Signed-off-by: Xinlei Lee > Signed-off-by: Jitao Shi > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188

2023-04-13 Thread Krzysztof Kozlowski
On 13/04/2023 08:09, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add dt-binding documentation of dsi for MediaTek MT8188 SoC. > > Signed-off-by: Xinlei Lee > Signed-off-by: Jitao Shi > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 01/11] dmaengine: Add API function dmaengine_prep_slave_dma_array()

2023-04-13 Thread Paul Cercueil
Hi Vinod, Le mercredi 12 avril 2023 à 22:53 +0530, Vinod Koul a écrit : > On 03-04-23, 17:47, Paul Cercueil wrote: > > This function can be used to initiate a scatter-gather DMA transfer > > where the DMA addresses and lengths are located inside arrays. > > > > The major difference with dmaengine

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stats.rst, 64b client-id, rename drm_show_fdinfo Reviewed-by: Daniel Vetter Signed-off-by: Rob Clark --- Docum

Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Andi Shyti
Hi Cong, > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist > creation") > > Signed-off-by: Cong Liu As Jani suggested we need a commit message here. Would something like this work for you? " We forget to free 'pages' after checking for overflow. Be sure to properly

[PATCH 2/2] gpu: host1x: Return error when context device not attached to IOMMU

2023-04-13 Thread Mikko Perttunen
From: Mikko Perttunen If a context device was not attached to IOMMU, we kept the old success err value causing context devices to be unregistered but success to be returned. This would mean that things would go on but with context isolation disabled. To decide on an explicit behavior, let's retu

[PATCH 1/2] drm/tegra: Add error check for NVDEC firmware memory allocation

2023-04-13 Thread Mikko Perttunen
From: Mikko Perttunen The return value for tegra_drm_alloc was missing an error check. Add one. Reported-by: Dan Carpenter Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/nvdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/teg

Re: [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Rui Salvaterra
Hi again, everyone. So, while preparing to file the bug report with the requested information, I got a trace completely unrelated to DRM (on a swapon call, it seems). [4.868340] rcu: INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 4- } 3 jiffies s: 265 root: 0x10/. [4.86834

[BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Rui Salvaterra
Hi, everyone, I apologise in advance if I've sent this to {too many, the wrong} people. For some time now, I've been getting sporadic (in about one out of five boots) DRM-related RCU complaints on an Ivy Bridge-based (Core i7-3720QM) Mac Mini. Call trace (on Linux 6.3-rc6) follows: [5.794026]

Re: [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Rui Salvaterra
Hi, Jani, On Wed, 12 Apr 2023 at 10:28, Jani Nikula wrote: > > Please file a bug at fdo gitlab [1]. Add drm.debug=0xe and maybe > log_buf_len=4M or similar kernel parameters, and attach dmesg all the > way from boot to reproducing the problem. Sure, will do, thanks! > How long is "for some time

[PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Cong Liu
This patch fixes memory leaks on error escapes in function fake_get_pages Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH 1/2] fbdev/offb: Update expected device name

2023-04-13 Thread Cyril Brulebois
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required. This means that offb no longer finds the expected device

[PATCH 2/2] drm/ofdrm: Update expected device name

2023-04-13 Thread Cyril Brulebois
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required. This means that offb no longer finds the expected device

Updating hardcoded "of-display" devices

2023-04-13 Thread Cyril Brulebois
Hi, We've spotted a regression with the Debian Installer on ppc64el, and I've confirmed that the first patch fixes fbdev/offb as expected (or at least works around the regression, see last part of the commit message): - [PATCH 1/2] fbdev/offb: Update expected device name Since I've spotted that

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement wait_hpd_asserted

2023-04-13 Thread Nikita Travkin
Doug Anderson писал(а) 13.04.2023 01:22: > Hi, > > On Sat, Apr 8, 2023 at 1:20 AM Nikita Travkin wrote: >> >> This bridge doesn't actually implement HPD due to it being way too slow >> but instead expects the panel driver to wait enough to assume HPD is >> asserted. However some panels (such as t

[PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Cong Liu
Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist creation") Signed-off-by: Cong Liu --- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/dr

[RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device

2023-04-13 Thread James Cowgill
This is the logical place to put the backlight device, and it also fixes a kernel crash if the MIPI host is removed. Previously the backlight device would be unregistered twice when this happened - once as a child of the MIPI host through `mipi_dsi_host_unregister`, and once when the panel device i

Re: [pull] amdgpu drm-fixes-6.3

2023-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2023 at 05:56:37PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > Fixes for 6.3. > > The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d: > > Linux 6.3-rc6 (2023-04-09 11:15:57 -0700) > > are available in the Git repository at: > > https://gitlab.

Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Andi Shyti
On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: > This patch fixes memory leaks on error escapes in function fake_get_pages > > Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist > creation") > Signed-off-by: Cong Liu OK, while I was proposing the adjustments

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: > Am 13.04.23 um 00:42 schrieb Rob Clark: > > From: Rob Clark > > > > Handle a bit of the boiler-plate in a single case, and make it easier to > > add some core tracked stats. > > > > v2: Update drm-usage-stats.rst, 64b client-id,

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Wed, 12 Apr 2023 at 16:18, Christian König wrote: > > Am 12.04.23 um 11:08 schrieb Daniel Vetter: > > On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > >> On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: > >>> Am 11.04.23 um 11:51 schrieb Daniel Vetter: > On Tue, Apr 04

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2023 at 04:05:42PM +0200, Stanislaw Gruszka wrote: > On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: > > This reverts commit 566fc96198b4bb07ca6806386956669881225271. > > > > This exposes a userspace API that is still under debate. Revert the > > change before the uA

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-13 Thread Daniel Vetter
On Wed, Apr 12, 2023 at 07:15:43PM +0200, Greg KH wrote: > On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: > > This reverts commit 566fc96198b4bb07ca6806386956669881225271. > > > > This exposes a userspace API that is still under debate. Revert the > > change before the uAPI gets ex

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-13 Thread Matthias Brugger
On 12/04/2023 23:03, Rob Herring wrote: On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchino Del Regno --- Documentation/devicetree/bin

Re: [PATCH v5 2/9] video/aperture: use generic code to figure out the vga default device

2023-04-13 Thread Daniel Vetter
On Tue, Apr 11, 2023 at 05:25:47PM +0200, Helge Deller wrote: > On 4/11/23 16:36, Daniel Vetter wrote: > > On Fri, Apr 07, 2023 at 10:54:00PM +0200, Helge Deller wrote: > > > On 4/6/23 15:21, Thomas Zimmermann wrote: > > > > From: Daniel Vetter > > > > > > > > Since vgaarb has been promoted to be

Re: [PATCH v5 2/5] drm/i915: Create the locked version of the request create

2023-04-13 Thread Andi Shyti
Hi Andrzej, > > Make version of the request creation that doesn't hold any > > lock. > > > > Signed-off-by: Andi Shyti > > Cc: sta...@vger.kernel.org > > Reviewed-by: Nirmoy Das > > --- > > drivers/gpu/drm/i915/i915_request.c | 38 + > > drivers/gpu/drm/i915/i915_

Re: [PATCH v5 3/5] drm/i915: Create the locked version of the request add

2023-04-13 Thread Andi Shyti
Hi Andrzej, On Wed, Apr 12, 2023 at 03:06:42PM +0200, Andrzej Hajda wrote: > On 12.04.2023 13:33, Andi Shyti wrote: > > i915_request_add() assumes that the timeline is locked whtn the > *when > > function is called. Before exiting it releases the lock. But in > > the next commit we have one case w

Re: [PATCH 02/27] dt-bindings: phy: mediatek, dsi-phy: Add compatible for MT6795 Helio X10

2023-04-13 Thread Matthias Brugger
On 12/04/2023 15:17, AngeloGioacchino Del Regno wrote: Il 12/04/23 15:12, Alexandre Mergnat ha scritto: On 12/04/2023 15:03, AngeloGioacchino Del Regno wrote: Il 12/04/23 14:59, Alexandre Mergnat ha scritto: On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: Add a compatible string for

Re: [PATCH 1/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8188

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee Add dt-binding documentation of dsi for MediaTek MT8188 SoC. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi Reviewed-by: Matthias Brugger --- .../devicetree/bindings/display/mediatek/mediatek,dsi.yaml |

Re: [PATCH 2/3] drm/mediatek: Add mt8188 dsi compatible to mtk_dsi.c

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee Add the compatible because there are different definitions for cmdq register bit control in mt8188. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk

Re: [RFC PATCH 9/9] drm/rustgem: create dummy IOCTL with number 0x00

2023-04-13 Thread Daniel Vetter
On Fri, Mar 17, 2023 at 09:12:13AM -0300, Maíra Canal wrote: > In order to declare IOCTLs with the current Rust abstractions, we use > the kernel::declare_drm_ioctls! macro. This macro considers that the > IOCTLs are in the right order and there are no gaps. This isn't the case > for vgem, which st

Re: [PATCH 3/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code

2023-04-13 Thread Matthias Brugger
On 13/04/2023 08:09, xinlei@mediatek.com wrote: From: Xinlei Lee For mt8188, add dsi cmdq reg control to send long packets to panel initialization. Signed-off-by: Xinlei Lee Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 12 1 file changed, 12 inser

[PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Andi Shyti
From: Paulo Zanoni In multitile systems IRQ need to be reset and enabled per GT. Although in MTL the GUnit misc interrupts register set are available only in GT-0, we need to loop through all the GT's in order to initialize the media engine which lies on a different GT. Signed-off-by: Paulo Zan

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-04-13 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:26PM +0900, Asahi Lina wrote: > DRM drivers need to be able to declare which driver-specific ioctls they > support. This abstraction adds the required types and a helper macro to > generate the ioctl definition inside the DRM driver. > > Note that this macro is not us

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-13 Thread AngeloGioacchino Del Regno
Il 13/04/23 10:52, Matthias Brugger ha scritto: On 12/04/2023 23:03, Rob Herring wrote: On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: Add a compatible string for MediaTek Helio X10 MT6795's display PWM block: this is the same as MT8173. Signed-off-by: AngeloGioacchin

Re: [PATCH 3/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2

2023-04-13 Thread Christian König
Am 12.04.23 um 17:11 schrieb Daniel Vetter: On Wed, Apr 12, 2023 at 04:52:04PM +0200, Christian König wrote: The mutex was completely pointless in the first place since any parallel adding of files to this list would result in random behavior since the list is filled and consumed multiple times.

[Bug 201497] [amdgpu]: '*ERROR* No EDID read' is back in 4.19

2023-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201497 --- Comment #27 from Emre (ereno...@gmail.com) --- This makes my docked laptop almost unusable :( Once it suspends the displays, there's no coming back. I'd need to undock, and hope it recovers. After undocking, re-docking the USB-C hub does not h

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Christian König
Am 13.04.23 um 10:48 schrieb Daniel Vetter: On Wed, 12 Apr 2023 at 16:18, Christian König wrote: Am 12.04.23 um 11:08 schrieb Daniel Vetter: On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: On Tue, Apr 11, 2023 at 02:11:18PM +0200, Christian König wrote: Am 11.04.23 um 11:51 schrieb Danie

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-13 Thread Pin-yen Lin
Hi Stephen, On Wed, Apr 12, 2023 at 10:38 AM Stephen Boyd wrote: > > Quoting Pin-yen Lin (2023-03-31 02:11:39) > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > index b4255

RE: [PATCH v7 00/17] Add RCar DU lib support

2023-04-13 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: Wednesday, April 12, 2023 4:43 PM > To: Biju Das > Cc: David Airlie ; Daniel Vetter ; Mauro > Carvalho Chehab ; Rob Herring ; > Krzysztof Kozlowski ; dri-devel@lists.freedesktop.org; > linux-ker.

[Bug 201497] [amdgpu]: '*ERROR* No EDID read' is back in 4.19

2023-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201497 --- Comment #28 from Rev (r...@pop.ms) --- I share that concern. Can the OP create a new report with a recent kernel and updated logs, maybe with a link to this report? That would be wonderful! By the way, my last comment, that the issue stops wh

[PATCH v2 0/5] Lenovo Tab P11 panel

2023-04-13 Thread Konrad Dybcio
v1 -> v2: - Remove dsi_info (unused for single DSI) [5/5] - Add backlight.scale [3/5] - pick up tags v1: https://lore.kernel.org/r/20230412-topic-lenovopanel-v1-0-00b25df46...@linaro.org Continuation of: https://lore.kernel.org/lkml/20230217-topic-lenovo-panel-v2-0-2e2c64729...@linaro.org/ I ro

[PATCH v2 1/5] dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports'

2023-04-13 Thread Konrad Dybcio
Using 'port' instead of 'ports' for single-DSI usecases allows for saving a couple of DTS LoC, including a level of indentation. Allow that. Signed-off-by: Konrad Dybcio --- .../bindings/display/panel/novatek,nt36523.yaml | 15 +-- 1 file changed, 13 insertions(+), 2 deleti

[PATCH v2 4/5] drm/panel: nt36523: Get orientation from OF

2023-04-13 Thread Konrad Dybcio
Some bright vendors mount their display panels upside down. Add the required pieces to allow for accounting for that. Reviewed-by: Linus Walleij Reviewed-by: Jianhua Lu Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 15 +++ 1 file changed, 15 inser

[PATCH v2 2/5] dt-bindings: display: panel: nt36523: Add Lenovo J606F panel

2023-04-13 Thread Konrad Dybcio
Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 video mode display. Document it and allow rotation while at it (Lenovo mounted it upside down!). Reviewed-by: Linus Walleij Signed-off-by: Konrad Dybcio --- .../bindings/display/panel/novatek,nt36523.yaml | 16 ++

[PATCH v2 5/5] drm/panel: nt36523: Add Lenovo J606F panel

2023-04-13 Thread Konrad Dybcio
Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 video mode display. Add support for these panels. Reviewed-by: Linus Walleij Reviewed-by: Jianhua Lu Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/panel/panel-novatek-nt36523.c | 486 ++ 1 file changed

[PATCH v2 3/5] drm/panel: nt36523: Add DCS backlight support

2023-04-13 Thread Konrad Dybcio
This chip supports controlling the backlight via DCS commands, on at least some panels. Add support for doing so. Note this may only concern the NT36523*W* variant. Nobody knows, really, there's no docs. Reviewed-by: Linus Walleij Reviewed-by: Jianhua Lu Signed-off-by: Konrad Dybcio --- drive

Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Cong Liu
Hi Andi, thank you for your reminder, next time I will pay attention to my format, and when someone has already reviewed, add the Reviewed-by field Regards. On 2023/4/13 16:44, Andi Shyti wrote: On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: This patch fixes memory leaks on error

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-13 Thread Jacek Lawrynowicz
Hi, On 13.04.2023 10:49, Daniel Vetter wrote: > On Wed, Apr 12, 2023 at 04:05:42PM +0200, Stanislaw Gruszka wrote: >> On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: >>> This reverts commit 566fc96198b4bb07ca6806386956669881225271. >>> >>> This exposes a userspace API that is still

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 10:46 schrieb Daniel Vetter: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [PATCH v4 3/6] drm/amdgpu: Switch to fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +-

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 10:20, Andi Shyti wrote: From: Paulo Zanoni In multitile systems IRQ need to be reset and enabled per GT. Although in MTL the GUnit misc interrupts register set are available only in GT-0, we need to loop through all the GT's in order to initialize the media engine which lies o

[RFC PATCH v2 0/2] Imagination Technologies PowerVR DRM driver

2023-04-13 Thread Sarah Walker
This patch adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver (pvrsrvkm). This

[RFC PATCH v2 2/2] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-04-13 Thread Sarah Walker
Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr.yaml diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentatio

[PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu :30:00.0: [drm] Failed to create MST payload for port 6d3a3885: -5 ...followed by an Oops due to a NULL pointer dereference. The real bug

Re: [Intel-gfx] [PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 14:10, Rodrigo Vivi wrote: On Wed, Apr 12, 2023 at 12:56:26PM +0200, Andi Shyti wrote: Hi Rodrigo, Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these req

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-13 Thread kernel test robot
3/20230412-235231 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230412145206.2483-3-christian.koenig%40amd.com patch subject: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3 config: arc-randconfig-r043-20230413 (https://downl

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 12:33, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request i

[PULL] drm-intel-next-fixes

2023-04-13 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one Cc:stable fix for indirect sampler state this week on drm-intel-next-fixes. Regards, Joonas *** drm-intel-next-fixes-2023-04-13: Short summary of fixes pull (less than what git shortlog provides): Just one Cc:stable fix for sampler indirect state in bindless heap.

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Jeff Layton wrote: > I've been experiencing some intermittent crashes down in the display > driver code. The symptoms are ususally a line like this in dmesg: > > amdgpu :30:00.0: [drm] Failed to create MST payload for port > 6d3a3885: -5 > > ...followed by an

Re: [RFC PATCH v2 0/2] Imagination Technologies PowerVR DRM driver

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Sarah Walker wrote: > The code in this patch, along with some of its history, can also be found > here: > https://gitlab.freedesktop.org/frankbinns/powervr/-/tree/powervr-next FYI patch 1/2 is likely so big that it gets dropped by the list. BR, Jani. -- Jani Nikula, Intel

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 12:56, Tvrtko Ursulin wrote: On 12/04/2023 12:33, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
On Thu, 2023-04-13 at 15:31 +0300, Jani Nikula wrote: > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to create MS

[PATCH 0/2] Fix mtk-hdmi-mt8195 unitialized variable usage and clock rate calculation

2023-04-13 Thread Guillaume Ranquet
x uninitialized variable usage in pll_calc phy: mediatek: hdmi: mt8195: fix wrong pll calculus drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) --- base-commit: 45810d486bb44bd60213d5f09a713df81b987972 change-id: 20230413-fixes-for-

[PATCH 1/2] phy: mediatek: hdmi: mt8195: fix uninitialized variable usage in pll_calc

2023-04-13 Thread Guillaume Ranquet
The ret variable in mtk_hdmi_pll_calc() was used unitialized as reported by the kernel test robot. Fix the issue by removing the variable altogether and testing out the return value of mtk_hdmi_pll_set_hw() Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Reported-by: k

[PATCH 2/2] phy: mediatek: hdmi: mt8195: fix wrong pll calculus

2023-04-13 Thread Guillaume Ranquet
The clock rate calculus in mtk_hdmi_pll_calc() was wrong when it has been replaced by 'div_u64'. Fix the issue by multiplying the values in the denominator instead of dividing them. Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Signed-off-by: Guillaume Ranquet ---

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin wrote: On 11/04/2023 23:5

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Alex Deucher
+ Wayne On Thu, Apr 13, 2023 at 8:31 AM Jani Nikula wrote: > > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to c

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 09:46, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 23:42, Rob Clark wrote: From: Rob Clark There is more do to here to remove my client->id fully (would now be dead code) so maybe easiest if you drop this patch and I do it after you land this and it propagates to our branches? I'd like to avoid pain with conflicts if possibl

Re: [PULL] drm-intel-fixes

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 10:13:57AM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > One DSI fix, stable material. > > drm-intel-fixes-2023-04-13: > drm/i915 fixes for v6.3-rc7: > - Fix dual link DSI for TGL+ > > BR, > Jani. > > The following changes since commit 09a9639e56c01c7a00d6c0ca63f

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 11:46, Christian König wrote: > > Am 13.04.23 um 10:48 schrieb Daniel Vetter: > > On Wed, 12 Apr 2023 at 16:18, Christian König > > wrote: > >> Am 12.04.23 um 11:08 schrieb Daniel Vetter: > >>> On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > On Tue, Apr 11, 2023

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > > > On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > > > > > > > > On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob C

Re: [PATCH] drm/stm: ltdc: fix late dereference check

2023-04-13 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Reviewed-by: Yannick Fertre On 4/12/23 11:25, Raphael GALLAIS-POU wrote: Attention: Sender not authenticated -- In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the po

Re: [PATCH 3/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 11:34:45AM +0200, Christian König wrote: > Am 12.04.23 um 17:11 schrieb Daniel Vetter: > > On Wed, Apr 12, 2023 at 04:52:04PM +0200, Christian König wrote: > > > The mutex was completely pointless in the first place since any > > > parallel adding of files to this list would

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Andi Shyti
Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: > > On 13/04/2023 10:20, Andi Shyti wrote: > > From: Paulo Zanoni > > > > In multitile systems IRQ need to be reset and enabled per GT. > > > > Although in MTL the GUnit misc interrupts registe

[PATCH v2] video/hdmi: minor fixes for *_infoframe_init functions

2023-04-13 Thread Nikita Zhandarovich
Multiple hdmi_*_infoframe_init() functions that initialize different types of hdmi infoframes only return default 0 value (contrary to their descriptions). Yet these functions are still checked against possible errors in case of failure. This patch removes redundant checks for errors in calls to f

Re: [RFC PATCH v2 2/2] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-04-13 Thread Krzysztof Kozlowski
On 13/04/2023 12:34, Sarah Walker wrote: > Signed-off-by: Sarah Walker NAK, multiple problems. Missing commit msg. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Th

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-04-13 Thread Dmitry Baryshkov
Hi Suraj, On 07/04/2023 06:11, Kandpal, Suraj wrote: Hi Dmitry -Original Message- From: Dmitry Baryshkov Sent: Friday, April 7, 2023 8:28 AM To: Kandpal, Suraj ; Jani Nikula ; dri-devel@lists.freedesktop.org; intel- g...@lists.freedesktop.org Cc: Nautiyal, Ankit K ; Shankar, Uma ; Ma

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 14:56, Andi Shyti wrote: Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: On 13/04/2023 10:20, Andi Shyti wrote: From: Paulo Zanoni In multitile systems IRQ need to be reset and enabled per GT. Although in MTL the GUnit mi

[PATCH] drm/rockchip: vop2: fix suspend/resume

2023-04-13 Thread Sascha Hauer
During a suspend/resume cycle the VO power domain will be disabled and the VOP2 registers will reset to their default values. After that the cached register values will be out of sync and the read/modify/write operations we do on the window registers will result in bogus values written. Fix this by

Re: [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Paul E. McKenney
On Thu, Apr 13, 2023 at 08:30:02AM +0100, Rui Salvaterra wrote: > Hi again, everyone. > > So, while preparing to file the bug report with the requested > information, I got a trace completely unrelated to DRM (on a swapon > call, it seems). > > [4.868340] rcu: INFO: rcu_sched detected expedit

[PATCH v2] radeon: avoid double free in ci_dpm_init()

2023-04-13 Thread Nikita Zhandarovich
Several calls to ci_dpm_fini() will attempt to free resources that either have been freed before or haven't been allocated yet. This may lead to undefined or dangerous behaviour. For instance, if r600_parse_extended_power_table() fails, it might call r600_free_extended_power_table() as will ci_dpm

Re: [PATCH] drm/rockchip: vop2: fix suspend/resume

2023-04-13 Thread Chris Morgan
On Thu, Apr 13, 2023 at 04:43:47PM +0200, Sascha Hauer wrote: > During a suspend/resume cycle the VO power domain will be disabled and > the VOP2 registers will reset to their default values. After that the > cached register values will be out of sync and the read/modify/write > operations we do on

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Sui Jingfeng
Hi, On 2023/4/13 01:44, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote: Hi, On 2023/4/11 22:53, Daniel Vetter wrote: On Sun, Apr 09, 2023 at 09:21:10PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng We should setting the screen buffer size according to the

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-13 Thread kernel test robot
ownload.01.org/0day-ci/archive/20230413/202304132344.9oz5dfji-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 9638da200e00bd069e6dd63604e14cbafede9324) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/m

Re: [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 6:07 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 23:42, Rob Clark wrote: > > From: Rob Clark > > There is more do to here to remove my client->id fully (would now be > dead code) so maybe easiest if you drop this patch and I do it after you > land this and it propagates t

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 5:58 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > >> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > >>> > >>> On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: >

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Matt Roper
On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: > Hi Tvrtko, > > (I forgot to CC Daniele) > > On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: > > > > On 13/04/2023 10:20, Andi Shyti wrote: > > > From: Paulo Zanoni > > > > > > In multitile systems IRQ need to be rese

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 17:35, Sui Jingfeng <15330273...@189.cn> wrote: > > Hi, > > On 2023/4/13 01:44, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote: > >> Hi, > >> > >> On 2023/4/11 22:53, Daniel Vetter wrote: > >>> On Sun, Apr 09, 2023 at 09:21:10PM +0800, S

  1   2   >