Re: [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 03:25:15PM +0300, Ville Syrjälä wrote: > On Wed, Apr 05, 2023 at 10:16:50AM +0200, Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > > computing the timestampe of the next vblank is somewhat ill-defined. > > And indeed, the code splats

[PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Daniel Vetter
If the crtc is being switched on or off then the semantics of computing the timestampe of the next vblank is somewhat ill-defined. And indeed, the code splats with a warning in the timestamp computation code. Specifically it hits the check to make sure that atomic drivers have full set up the timin

Re: [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Ville Syrjälä
On Wed, Apr 05, 2023 at 03:31:05PM +0200, Daniel Vetter wrote: > If the crtc is being switched on or off then the semantics of > computing the timestampe of the next vblank is somewhat ill-defined. > And indeed, the code splats with a warning in the timestamp > computation code. Specifically it hit

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: > Some hardware may require more complex resource utilization accounting > than the simple job count supported by drm_sched internally. Add a > can_run_job callback to allow drivers to implement more logic before > deciding whether to run

Re: [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Lee Jones
On Tue, 04 Apr 2023, Jani Nikula wrote: > On Mon, 03 Apr 2023, Lee Jones wrote: > > On Mon, 03 Apr 2023, Jani Nikula wrote: > > > >> On Fri, 31 Mar 2023, Lee Jones wrote: > >> > Fixes the following W=1 kernel build warning(s): > >> > > >> > drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: F

Re: [Intel-gfx] [PATCH] drm/atomic-helper: Don't set deadline for modesets

2023-04-05 Thread Rob Clark
On Wed, Apr 5, 2023 at 6:31 AM Daniel Vetter wrote: > > If the crtc is being switched on or off then the semantics of > computing the timestampe of the next vblank is somewhat ill-defined. > And indeed, the code splats with a warning in the timestamp > computation code. Specifically it hits the ch

[PATCH 1/1] drm/bridge: ti-sn65dsi86: Allow GPIO operations to sleep

2023-04-05 Thread Alexander Stein
There is no need to require non-sleeping GPIO access. Silence the WARN_ON() if GPIO is using e.g. I2C expanders. Signed-off-by: Alexander Stein --- This is the TI SN65DSI86 equivalent to 805245071240 ("drm/bridge: ti-sn65dsi83: Allow GPIO operations to sleep") drivers/gpu/drm/bridge/ti-sn65dsi

Re: [PATCH 1/5] drm/i915/ttm: Add I915_BO_PREALLOC

2023-04-05 Thread Andi Shyti
> Add a mechanism to preserve existing data when creating a TTM > object with the I915_BO_ALLOC_USER flag. This will be used in the subsequent > patch where the I915_BO_ALLOC_USER flag will be applied to the framebuffer > object. For a pre-allocated framebuffer without the I915_BO_PREALLOC flag, >

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:36PM +0900, Asahi Lina wrote: > drm_sched_fini() currently leaves any pending jobs dangling, which > causes segfaults and other badness when job completion fences are > signaled after the scheduler is torn down. > > Explicitly detach all jobs from their completion cal

Re: [PATCH 2/2] vkms: Add support for multiple connectors

2023-04-05 Thread Maíra Canal
Hi Marius, > This patch adds support for creating multiple virtual connectors, in > case one would need it. Use module parameters to specify how many, > defaulting to just one, allocating from the start, a maximum of 4 > possible outputs. I got a bit confused by this description. The commit messa

Re: [Intel-gfx] [PATCH] i915/guc/slpc: Provide sysfs for efficient freq

2023-04-05 Thread Rodrigo Vivi
On Fri, Mar 31, 2023 at 08:11:29PM -0700, Dixit, Ashutosh wrote: > On Fri, 31 Mar 2023 19:00:49 -0700, Vinay Belgaumkar wrote: > > > > Hi Vinay, > > > @@ -478,20 +507,15 @@ int intel_guc_slpc_set_min_freq(struct intel_guc_slpc > > *slpc, u32 val) > > val > slpc->max_freq_softlimit) > >

Re: [RFC PATCH 08/10] dma-buf/dma-fence: Introduce long-running completion fences

2023-04-05 Thread Christian König
Am 05.04.23 um 14:45 schrieb Daniel Vetter: On Wed, Apr 05, 2023 at 02:39:35PM +0200, Christian König wrote: Am 05.04.23 um 14:35 schrieb Thomas Hellström: Hi, On 4/4/23 21:25, Daniel Vetter wrote: On Tue, Apr 04, 2023 at 07:02:23PM +, Matthew Brost wrote: On Tue, Apr 04, 2023 at 08:14:0

RFC: DSI/DRM multiplexer bridge

2023-04-05 Thread Alexander Stein
Hi, my platform has a DIP switch controlled multiplexer for MIPI DSI output signals. One output has a TI SN65DSI84 (LVDS) and the other output has a TI SN65DSI86 (eDP) attached to it. The Multiplexer status can be read back from a GPIO. The GPIO is also IRQ capable, so it would be possible to s

Re: [PATCH 2/5] drm/i915/display: Set I915_BO_ALLOC_USER for fb

2023-04-05 Thread Andrzej Hajda
On 04.04.2023 16:30, Nirmoy Das wrote: Framebuffer is exposed to userspace so make sure we set proper flags for it. Set I915_BO_PREALLOC for prealloced fb so that ttm won't clear existing data. Cc: Matthew Auld Cc: Andi Shyti Cc: Andrzej Hajda Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre D

Re: [PATCH v2 0/2] Update the handling of the primary plane

2023-04-05 Thread Melissa Wen
On 03/24, Maíra Canal wrote: > This patchset focus on the proper handling of the primary plane after the > modifications introduced in commit bc0d7fdefec6 ("drm: vkms: Supports to the > case where primary plane doesn't match the CRTC"). Before this commit, the > composition was executed on top of t

Re: [PATCH 4/5] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper

2023-04-05 Thread Andrzej Hajda
On 04.04.2023 16:30, Nirmoy Das wrote: Add a helper function to retrieve struct intel_fbdev from struct drm_fb_helper. Cc: Matthew Auld Cc: Andi Shyti Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Nirmoy Das Reviewed-by: Jani Nikula Reviewed-by: Andi Shyti Reviewed-by

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Christian König
Am 05.04.23 um 15:40 schrieb Daniel Vetter: On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: Some hardware may require more complex resource utilization accounting than the simple job count supported by drm_sched internally. Add a can_run_job callback to allow drivers to implement mor

Re: [PATCH 4/5] drm/i915/display: Add helper func to get intel_fbdev from drm_fb_helper

2023-04-05 Thread Andrzej Hajda
On 05.04.2023 16:13, Andrzej Hajda wrote: On 04.04.2023 16:30, Nirmoy Das wrote: Add a helper function to retrieve struct intel_fbdev from struct drm_fb_helper. Cc: Matthew Auld Cc: Andi Shyti Cc: Ville Syrjälä Cc: Jani Nikula Cc: Imre Deak Signed-off-by: Nirmoy Das Reviewed-by: Jani

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: Hold a wakeref for the active VM

2023-04-05 Thread Andrzej Hajda
On 31.03.2023 16:16, Andrzej Hajda wrote: From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. v2: added explanation to __queue_and_release_pm Signed-off-by:

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:14:11PM +0200, Christian König wrote: > Am 05.04.23 um 15:40 schrieb Daniel Vetter: > > On Tue, Mar 07, 2023 at 11:25:35PM +0900, Asahi Lina wrote: > > > Some hardware may require more complex resource utilization accounting > > > than the simple job count supported by dr

[PATCH v2 2/2] drm: bridge: cdns-mhdp8546: Add support for no-hpd

2023-04-05 Thread Jayesh Choudhary
From: Rahul T R In J721S2 EVMs DP0 hpd is not connected to correct hpd pin on SOC, to handle such cases, Add support for "no-hpd" property in the device tree node to disable hpd Also change the log level for dpcd read failuers to debug, since framework retries 32 times for each read Signed-off-

[PATCH v2 1/2] dt-bindings: drm/bridge: Add no-hpd property

2023-04-05 Thread Jayesh Choudhary
From: Rahul T R The mhdp bridge can work without its HPD pin hooked up to the connector, but the current bridge driver throws an error when hpd line is not connected to the connector. For such cases, we need an indication for no-hpd, using which we can bypass the hpd detection and instead use the

[PATCH v2 0/2] "no-hpd" support in CDNS DP bridge driver

2023-04-05 Thread Jayesh Choudhary
In J721s2 EVM, DP0 HPD is not connected to correct HPD pin on SOC which results in HPD detect as always connnected, so when display is not connected driver continuously retries to read EDID and DPCD registers. To handle such cases add support for no hpd configuration in cdns-mhdp driver. DT chang

Re: [PATCH -next] drm: bridge: samsung-dsim: fix platform_no_drv_owner.cocci warning

2023-04-05 Thread Jagan Teki
On Thu, Mar 30, 2023 at 6:57 AM Yang Li wrote: > > ./drivers/gpu/drm/bridge/samsung-dsim.c:1957:6-11: No need to set .owner > here. The core will do it. > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4640 > Signed-off-by: Yang Li > --- Reviewed-by: Jagan Te

Re: [PATCH v5 0/8] QAIC accel driver

2023-04-05 Thread Jeffrey Hugo
On 4/5/2023 7:27 AM, Daniel Vetter wrote: On Wed, Apr 05, 2023 at 03:35:19PM +0300, Oded Gabbay wrote: On Wed, Apr 5, 2023 at 2:26 PM Jacek Lawrynowicz wrote: Hi, On 03.04.2023 19:22, Jeffrey Hugo wrote: On 3/27/2023 9:54 AM, Jeffrey Hugo wrote: This series introduces a driver under the ac

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Laurent Pinchart
Hi Hans, On Wed, Apr 05, 2023 at 10:50:37AM +0200, Hans Verkuil wrote: > On 05/04/2023 10:31, Luca Ceresoli wrote: > > On Wed, 5 Apr 2023 05:30:48 +0300 Laurent Pinchart wrote: > >> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: > >>> On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil

Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Thomas Zimmermann
Hi Am 05.04.23 um 15:18 schrieb Daniel Vetter: On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: Thomas Zimmermann writes: [...] Your comment says that it calls a PCI function to clean up to vgacon. That comment explains what is happening, not why. And how the PCI a

Re: RFC: DSI/DRM multiplexer bridge

2023-04-05 Thread Jagan Teki
On Wed, Apr 5, 2023 at 7:39 PM Alexander Stein wrote: > > Hi, > > my platform has a DIP switch controlled multiplexer for MIPI DSI output > signals. One output has a TI SN65DSI84 (LVDS) and the other output has a TI > SN65DSI86 (eDP) attached to it. The Multiplexer status can be read back from a >

Re: [PATCH RFC 18/18] drm/asahi: Add the Asahi driver for Apple AGX GPUs

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:43PM +0900, Asahi Lina wrote: > +/// Look up a GEM object handle for a `File` and return an `ObjectRef` for > it. > +pub(crate) fn lookup_handle(file: &DrmFile, handle: u32) -> > Result { > +Ok(ObjectRef::new(shmem::Object::lookup_handle(file, handle)?)) > +} So

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Maxime Ripard
On Wed, Apr 05, 2023 at 02:57:26PM +0200, Paul Cercueil wrote: > Le lundi 27 mars 2023 à 21:24 +0200, Maxime Ripard a écrit : > > On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > > > > > My suggestion: add a per-clock bitmap to keep track of which > > > > > parents > > > > > are a

[PATCH 0/2] Add dynamic connector selection mechanism

2023-04-05 Thread Jason-JH . Lin
To support DSI and eDP as main display connector without modifying mtk-drm driver, we add the dynamic connector selection mechanism. Jason-JH.Lin (2): drm/mediatek: Add ability to support dynamic connector selection drm/mediatek: Add DSI support for mt8188 vdosys0 drivers/gpu/drm/mediatek/mt

[PATCH 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-04-05 Thread Jason-JH . Lin
1. Move output drm connector from each ddp_path array to connector array. 2. Add dynamic select available connector flow in crtc create and enable. Signed-off-by: Nancy Lin Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu

[PATCH 2/2] drm/mediatek: Add DSI support for mt8188 vdosys0

2023-04-05 Thread Jason-JH . Lin
Add DSI as main display output for mt8188 vdosys0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 + drivers/gpu/drm/mediatek/mtk_d

Re: [PATCH RFC 13/18] drm/gem: Add a flag to control whether objects can be exported

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:38PM +0900, Asahi Lina wrote: > Drivers may want to support driver-private objects, which cannot be > shared. This allows them to share a single lock and enables other > optimizations. > > Add an `exportable` field to drm_gem_object, which blocks PRIME export > if set

Re: [PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-04-05 Thread Thierry Reding
On Thu, Mar 30, 2023 at 10:36:00AM +0200, Thomas Zimmermann wrote: > Convert tegra's fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in tegra is now just > another DRM clie

Re: [PATCH 7/7] dt-bindings: display: add panel-timing property to sitronix,st7789v

2023-04-05 Thread Maxime Ripard
On Tue, Apr 04, 2023 at 06:26:25PM +0200, Michael Riesch wrote: > A different question is the partial mode, for which (IIUC) you suggest > the overscan feature. As I have never heard of this before, it would be > very nice if you could point me to some examples. Where would the > >>>

Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG

2023-04-05 Thread Maxime Ripard
On Wed, Apr 05, 2023 at 02:34:11PM +0200, Roman Beranek wrote: > Hello Maxime, > > On Wed Mar 29, 2023 at 9:58 PM CEST, Maxime Ripard wrote: > > > In order to preserve semantic correctness however, I propose to preface > > > the change with a patch that renames sun4i_dotclock and tcon-pixel-clock

Re: [PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-04-05 Thread Thierry Reding
From: Thierry Reding On Thu, 30 Mar 2023 10:36:00 +0200, Thomas Zimmermann wrote: > Convert tegra's fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in tegra is now just >

[PATCH 00/18] arch: Consolidate

2023-04-05 Thread Thomas Zimmermann
Various architectures provide with helpers for fbdev framebuffer devices. Share the contained code where possible. There is already , which implements generic (as in 'empty') functions of the fbdev helpers. The header was added in commit aafe4dbed0bf ("asm-generic: add generic versions of common h

[PATCH 02/18] arch/arc: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Vineet Gupta --- arch/arc/include/asm/fb.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/arc/include/asm/fb.h b/arch/a

[PATCH 01/18] fbdev: Prepare generic architecture helpers

2023-04-05 Thread Thomas Zimmermann
Generic implementations of fb_pgprotect() and fb_is_primary_device() have been in the source code for a long time. Prepare the header file to make use of them. Improve the code by using an inline function for fb_pgprotect() and by removing include statements. Symbols are protected by preprocessor

[PATCH 03/18] arch/arm: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Russell King --- arch/arm/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm/include/asm/fb.h b/arch/ar

[PATCH 09/18] video: Remove trailing whitespaces

2023-04-05 Thread Thomas Zimmermann
Fix trailing whitespaces. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/console/sticon.c | 4 +- drivers/video/console/sticore.c | 102 ++--- drivers/video/fbdev/sticore.h | 14 +-- drivers/video/fbdev/stifb.c | 156 --

[PATCH 13/18] arch/parisc: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from on systems without CONFIG_STI_CORE. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley" Cc: Helge Deller --- arch/parisc/include/asm/fb.h | 15 --- 1 file changed, 8 insertio

[PATCH 11/18] arch/parisc: Remove trailing whitespaces

2023-04-05 Thread Thomas Zimmermann
Fix trailing whitespaces. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley" Cc: Helge Deller --- arch/parisc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile index a2d8600521f9..0d049a6f6a6

[PATCH 10/18] video: Move HP PARISC STI core code to shared location

2023-04-05 Thread Thomas Zimmermann
STI core files have been located in console and fbdev code. Move the source code and header to the directories for video helpers. Also update the config and build rules such that the code depends on the config symbol CONFIG_STI_CORE, which STI console and STI framebuffer select automatically. Clea

[PATCH 05/18] arch/ia64: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann --- arch/ia64/include/asm/fb.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/ia64/include/asm/fb.h b/arch/ia64/include/asm/

[PATCH 08/18] arch/mips: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Bogendoerfer --- arch/mips/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/mips/include/asm/fb.h

[PATCH 17/18] arch/sparc: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_pgprotect() with the generic one from on 32-bit builds. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "David S. Miller" --- arch/sparc/include/asm/fb.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/sparc/include/

[PATCH 07/18] arch/m68k: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Also use the generic helper for fb_pgprotect() on systems without MMU. Signed-off-by: Thomas Zimmermann Cc: Geert Uytterhoeven --- arch/m68k/include/asm/fb.h | 10 +++--- 1 file changed, 3 i

[PATCH 06/18] arch/loongarch: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Huacai Chen Cc: WANG Xuerui --- arch/loongarch/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/loongarc

[PATCH 15/18] arch/sh: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz --- arch/sh/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-)

[PATCH 18/18] arch/x86: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Include and set the required preprocessor tokens correctly. x86 now implements its own set of fb helpers, but still follows the overall pattern. Signed-off-by: Thomas Zimmermann Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/includ

[PATCH 04/18] arch/arm64: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Catalin Marinas Cc: Will Deacon --- arch/arm64/include/asm/fb.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm64/in

[PATCH 12/18] arch/parisc: Implement fb_is_primary_device() under arch/parisc

2023-04-05 Thread Thomas Zimmermann
Move PARISC's implementation of fb_is_primary_device() into the architecture directory. This the place of the declaration and where other architectures implement this function. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "James E.J. Bottomley" Cc: Helge Deller --- arch/parisc/M

[PATCH 14/18] arch/powerpc: Implement with generic helpers

2023-04-05 Thread Thomas Zimmermann
Replace the architecture's fb_is_primary_device() with the generic one from . No functional changes. Signed-off-by: Thomas Zimmermann Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy --- arch/powerpc/include/asm/fb.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-)

[PATCH 16/18] arch/sparc: Implement fb_is_primary_device() in source file

2023-04-05 Thread Thomas Zimmermann
Other architectures implment fb_is_primary_device() in a source file. Do the same on sparc. No functional changes, but allows to remove several include statement from . Signed-off-by: Thomas Zimmermann Cc: "David S. Miller" --- arch/sparc/Makefile | 1 + arch/sparc/include/asm/fb.h | 2

Re: [PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-04-05 Thread Thomas Zimmermann
Am 05.04.23 um 16:55 schrieb Thierry Reding: On Thu, Mar 30, 2023 at 10:36:00AM +0200, Thomas Zimmermann wrote: Convert tegra's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, f

Re: [PATCH v3 63/65] ASoC: tlv320aic32x4: pll: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:53PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since we'

Re: [PATCH v3 64/65] ASoC: tlv320aic32x4: div: Switch to determine_rate

2023-04-05 Thread Mark Brown
On Tue, Apr 04, 2023 at 12:11:54PM +0200, Maxime Ripard wrote: > The driver does implement round_rate() though, which means that we can > change the rate of the clock, but we will never get to change the > parent. > However, It's hard to tell whether it's been done on purpose or not. > Since we'

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-05 Thread Maxime Ripard
Hi Mark, On Tue, Apr 04, 2023 at 04:26:18PM +0100, Mark Brown wrote: > On Tue, Apr 04, 2023 at 12:11:33PM +0200, Maxime Ripard wrote: > > The tlv320aic32x4 clkin clock implements a mux with a set_parent hook, > > but doesn't provide a determine_rate implementation. > > > This is a bit odd, since

Re: [PATCH v3 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Maxime Ripard
Hi Paul, On Wed, Apr 05, 2023 at 03:04:05PM +0200, Paul Cercueil wrote: > Le mardi 04 avril 2023 à 12:11 +0200, Maxime Ripard a écrit : > > The Ingenic CGU clocks implements a mux with a set_parent hook, but > > doesn't provide a determine_rate implementation. > > > > This is a bit odd, since set

Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

2023-04-05 Thread Maxime Ripard
Hi David, On Wed, Apr 05, 2023 at 10:03:24AM -0500, David Lechner wrote: > On 4/4/23 5:11 AM, Maxime Ripard wrote: > > The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent > > hook, but doesn't provide a determine_rate implementation. > > > > This is a bit odd, since set_parent() is

Re: [PATCH 0/4] log2: make is_power_of_2() more generic

2023-04-05 Thread Steven Price
On 31/03/2023 09:31, Jani Nikula wrote: > On Thu, 30 Mar 2023, Andrew Morton wrote: >> On Thu, 30 Mar 2023 21:53:03 + David Laight >> wrote: >> But wouldn't all these issues be addressed by simply doing #define is_power_of_2(n) (n != 0 && ((n & (n - 1)) == 0)) ?

Re: [PATCH v3 22/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip "clk48" clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most l

Re: [PATCH v3 21/65] clk: davinci: da8xx-cfgchip: Add a determine_rate hook

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The Davinci DA8xxx cfgchip mux clock implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likel

Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

2023-04-05 Thread David Lechner
On 4/4/23 5:11 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit odd, since set_parent() is there to, as its name implies, change the parent of a clock. However, the most likely cand

Re: [PATCH] drm/panel-edp: Add AUO NE135FBM-N41 v8.1 panel entry

2023-04-05 Thread Doug Anderson
Hi, On Wed, Apr 5, 2023 at 3:05 AM AngeloGioacchino Del Regno wrote: > > Add a panel entry with delay_200_500_e50 for the AUO NE135FBM-N41 > version 8.1, found on a number of ACER laptops, including the > Swift 3 (SF313-52, SF313-53), Chromebook Spin 513 (CP513-2H) and > others. > > Signed-off-by

Re: [PATCH v2 56/65] clk: ingenic: cgu: Switch to determine_rate

2023-04-05 Thread Paul Cercueil
Le mercredi 05 avril 2023 à 16:50 +0200, Maxime Ripard a écrit : > On Wed, Apr 05, 2023 at 02:57:26PM +0200, Paul Cercueil wrote: > > Le lundi 27 mars 2023 à 21:24 +0200, Maxime Ripard a écrit : > > > On Fri, Mar 24, 2023 at 08:58:48PM +, Aidan MacDonald wrote: > > > > > > My suggestion: add a

Re: [PATCH v3 43/65] ASoC: tlv320aic32x4: Add a determine_rate hook

2023-04-05 Thread Mark Brown
On Wed, Apr 05, 2023 at 05:17:21PM +0200, Maxime Ripard wrote: > On Tue, Apr 04, 2023 at 04:26:18PM +0100, Mark Brown wrote: > > To be honest it's surprising that we'd have to manually specify this, I > > would expect to be able to reparent. I suspect it'd be better to go the > > other way here a

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi86: Allow GPIO operations to sleep

2023-04-05 Thread Doug Anderson
Hi, On Wed, Apr 5, 2023 at 6:51 AM Alexander Stein wrote: > > There is no need to require non-sleeping GPIO access. Silence the > WARN_ON() if GPIO is using e.g. I2C expanders. > > Signed-off-by: Alexander Stein > --- > This is the TI SN65DSI86 equivalent to 805245071240 ("drm/bridge: > ti-sn65d

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-04-05 Thread Danilo Krummrich
On 4/4/23 06:31, Luben Tuikov wrote: On 2023-03-28 04:54, Lucas Stach wrote: Hi Danilo, Am Dienstag, dem 28.03.2023 um 02:57 +0200 schrieb Danilo Krummrich: Hi all, Commit df622729ddbf ("drm/scheduler: track GPU active time per entity") tries to track the accumulated time that a job was activ

Re: [PATCH RFC 12/18] rust: drm: sched: Add GPU scheduler abstraction

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:37PM +0900, Asahi Lina wrote: > The GPU scheduler manages scheduling GPU jobs and dependencies between > them. This Rust abstraction allows Rust DRM drivers to use this > functionality. > > Signed-off-by: Asahi Lina Overall (with my limited rust knowledge) I really

Re: [PATCH 01/18] fbdev: Prepare generic architecture helpers

2023-04-05 Thread Arnd Bergmann
On Wed, Apr 5, 2023, at 17:05, Thomas Zimmermann wrote: > Generic implementations of fb_pgprotect() and fb_is_primary_device() > have been in the source code for a long time. Prepare the header file > to make use of them. > > Improve the code by using an inline function for fb_pgprotect() and > by

Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > Hi > > Am 05.04.23 um 15:18 schrieb Daniel Vetter: > > On Wed, Apr 05, 2023 at 01:16:27PM +0200, Javier Martinez Canillas wrote: > > > Thomas Zimmermann writes: > > > > > > [...] > > > > > > > > > > > Your comment says that i

Re: [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-04-05 Thread Jordan Crouse
On Fri, Mar 10, 2023 at 01:05:36AM +0200, Dmitry Baryshkov wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On 10/03/2023 00:20, Jordan Crouse wrote: > >

Re: [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Jani Nikula
On Wed, 05 Apr 2023, Lee Jones wrote: > On Tue, 04 Apr 2023, Jani Nikula wrote: > >> On Mon, 03 Apr 2023, Lee Jones wrote: >> > On Mon, 03 Apr 2023, Jani Nikula wrote: >> > >> >> On Fri, 31 Mar 2023, Lee Jones wrote: >> >> > Fixes the following W=1 kernel build warning(s): >> >> > >> >> > drive

Re: [PATCH 01/18] fbdev: Prepare generic architecture helpers

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 05:53:03PM +0200, Arnd Bergmann wrote: > On Wed, Apr 5, 2023, at 17:05, Thomas Zimmermann wrote: > > Generic implementations of fb_pgprotect() and fb_is_primary_device() > > have been in the source code for a long time. Prepare the header file > > to make use of them. > > >

Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

2023-04-05 Thread David Lechner
On 4/5/23 10:22 AM, Maxime Ripard wrote: Hi David, On Wed, Apr 05, 2023 at 10:03:24AM -0500, David Lechner wrote: On 4/4/23 5:11 AM, Maxime Ripard wrote: The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent hook, but doesn't provide a determine_rate implementation. This is a bit

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-04-05 Thread Luben Tuikov
On 2023-04-05 10:05, Danilo Krummrich wrote: > On 4/4/23 06:31, Luben Tuikov wrote: >> On 2023-03-28 04:54, Lucas Stach wrote: >>> Hi Danilo, >>> >>> Am Dienstag, dem 28.03.2023 um 02:57 +0200 schrieb Danilo Krummrich: Hi all, Commit df622729ddbf ("drm/scheduler: track GPU active tim

Re: [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: [...] >> >> but only the 'var->xres > fb->width || var->yres > fb->height' from the >> conditions checked could be false after your __fill_var() call above. >> >> You should drop the 'var->bits_per_pixel > bpp', 'var->xres_virtual > >> fb->width' and 'var->yres_virtual >

[PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-05 Thread Asahi Lina
A signaled scheduler fence can outlive its scheduler, since fences are independently reference counted. Therefore, we can't reference the scheduler in the get_timeline_name() implementation. Fixes oopses on `cat /sys/kernel/debug/dma_buf/bufinfo` when shared dma-bufs reference fences from GPU sche

[PATCH] drm/scheduler: Fix UAF race in drm_sched_entity_push_job()

2023-04-05 Thread Asahi Lina
After a job is pushed into the queue, it is owned by the scheduler core and may be freed at any time, so we can't write nor read the submit timestamp after that point. Fixes oopses observed with the drm/asahi driver, found with kASAN. Signed-off-by: Asahi Lina --- drivers/gpu/drm/scheduler/sche

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-05 Thread Sui Jingfeng
Hi, On 2023/4/4 22:10, Emil Velikov wrote: Greetings Sui Jingfeng, I haven't been around drm-land for a while and this is the first driver I skim through in a few years. So take the following suggestions with a healthy pinch of salt. Hope that helps o/ Emil, we love your reviews, On Mon, 3 A

Re: [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-05 Thread Lee Jones
On Wed, 05 Apr 2023, Jani Nikula wrote: > On Wed, 05 Apr 2023, Lee Jones wrote: > > On Tue, 04 Apr 2023, Jani Nikula wrote: > > > >> On Mon, 03 Apr 2023, Lee Jones wrote: > >> > On Mon, 03 Apr 2023, Jani Nikula wrote: > >> > > >> >> On Fri, 31 Mar 2023, Lee Jones wrote: > >> >> > Fixes the foll

Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: [...] >> > > >/* >> > > > * WARNING: Apparently we must kick fbdev drivers before vgacon, >> > > > * otherwise the vga fbdev driver falls over. >> > > > */ >> > > >

Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller

2023-04-05 Thread Sui Jingfeng
On 2023/4/6 00:40, Sui Jingfeng wrote: Hi, On 2023/4/4 22:10, Emil Velikov wrote: Greetings Sui Jingfeng, I haven't been around drm-land for a while and this is the first driver I skim through in a few years. So take the following suggestions with a healthy pinch of salt. Hope that helps o/

Re: [PATCH RFC 02/18] rust: drm: Add Device and Driver abstractions

2023-04-05 Thread Daniel Vetter
On Tue, Mar 07, 2023 at 11:25:27PM +0900, Asahi Lina wrote: > Add the initial abstractions for DRM drivers and devices. These go > together in one commit since they are fairly tightly coupled types. > > A few things have been stubbed out, to be implemented as further bits of > the DRM subsystem ar

[PATCH] drm/nouveau: Add a jump label in nouveau_gem_ioctl_pushbuf()

2023-04-05 Thread Markus Elfring
Date: Wed, 5 Apr 2023 18:38:54 +0200 The label “out_prevalid” was used to jump to another pointer check despite of the detail in the implementation of the function “nouveau_gem_ioctl_pushbuf” that it was determined already in one case that the corresponding variable contained an error pointer beca

Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Daniel Vetter
On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas wrote: > > Daniel Vetter writes: > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > [...] > > >> > > >/* > >> > > > * WARNING: Apparently we must kick fbdev drivers before > >> > > > vgacon, > >> > >

Re: [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Daniel Vetter
On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: > Daniel Vetter writes: > > [...] > > >> > >> but only the 'var->xres > fb->width || var->yres > fb->height' from the > >> conditions checked could be false after your __fill_var() call above. > >> > >> You should drop t

Re: [RFC PATCH 02/10] drm/sched: Move schedule policy to scheduler / entity

2023-04-05 Thread Luben Tuikov
Hi, Inlined: On 2023-04-03 20:22, Matthew Brost wrote: > Rather than a global modparam for scheduling policy, move the scheduling > policy to scheduler / entity so user can control each scheduler / entity > policy. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_devi

Re: [PATCH] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-04-05 Thread Luben Tuikov
On 2023-03-31 01:59, Christian König wrote: > Am 31.03.23 um 02:06 schrieb Danilo Krummrich: >> It already happend a few times that patches slipped through which >> implemented access to an entity through a job that was already removed >> from the entities queue. Since jobs and entities might have

Re: [PATCH 3/3] drm/fb-helper: fix input validation gaps in check_var

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, Apr 05, 2023 at 06:27:17PM +0200, Javier Martinez Canillas wrote: >> Daniel Vetter writes: [...] >> > >> > The __fill_var is after this. I'm honestly not sure what the exact >> >> Ah, your patch adds it after that indeed. Please ignore my comment then. > > So r

Re: [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Javier Martinez Canillas
Daniel Vetter writes: > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > wrote: >> >> Daniel Vetter writes: [...] >> >> Yeah, agreed that if vga_remove_vgacon() isn't enough and another helper >> is needed then starts to get a little silly. Maybe one option is to add a >> 3rd param to

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-04-05 Thread Danilo Krummrich
On 4/5/23 18:09, Luben Tuikov wrote: On 2023-04-05 10:05, Danilo Krummrich wrote: On 4/4/23 06:31, Luben Tuikov wrote: On 2023-03-28 04:54, Lucas Stach wrote: Hi Danilo, Am Dienstag, dem 28.03.2023 um 02:57 +0200 schrieb Danilo Krummrich: Hi all, Commit df622729ddbf ("drm/scheduler: track G

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-04-05 Thread Lucas Stach
Hi Luben, Am Dienstag, dem 04.04.2023 um 00:31 -0400 schrieb Luben Tuikov: > On 2023-03-28 04:54, Lucas Stach wrote: > > Hi Danilo, > > > > Am Dienstag, dem 28.03.2023 um 02:57 +0200 schrieb Danilo Krummrich: > > > Hi all, > > > > > > Commit df622729ddbf ("drm/scheduler: track GPU active time pe

Re: [Intel-gfx] [PATCH 1/8] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-04-05 Thread Patrik Jakobsson
On Wed, Apr 5, 2023 at 7:15 PM Daniel Vetter wrote: > > On Wed, 5 Apr 2023 at 18:54, Javier Martinez Canillas > wrote: > > > > Daniel Vetter writes: > > > > > On Wed, Apr 05, 2023 at 04:32:19PM +0200, Thomas Zimmermann wrote: > > > > [...] > > > > >> > > >/* > > >> > > > * WARNIN

RE: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-05 Thread Zeng, Oak
Hi, Using dma-fence for completion/dependency tracking for long-run workload(more precisely on-demand paging/page fault enabled workload) can cause deadlock. This seems the significant issue here. Other issues such as the drm scheduler completion order implication etc are minors which can be so

Re: [PATCH] drm/scheduler: Fix UAF in drm_sched_fence_get_timeline_name

2023-04-05 Thread Luben Tuikov
On 2023-04-05 12:34, Asahi Lina wrote: > A signaled scheduler fence can outlive its scheduler, since fences are > independently reference counted. Therefore, we can't reference the > scheduler in the get_timeline_name() implementation. > > Fixes oopses on `cat /sys/kernel/debug/dma_buf/bufinfo` wh

<    1   2   3   >