RE: [PATCH v8 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-04-03 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand...@chromium.org; dri-devel@lists.freedesktop.

RE: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-04-03 Thread Shankar, Uma
> > -Original Message- > > From: Dmitry Baryshkov > > Sent: Tuesday, March 28, 2023 6:58 PM > > To: Kandpal, Suraj > > Cc: Jani Nikula ; > > dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > Nautiyal, Ankit K ; Shankar, Uma > > ; Maarten Lankhorst > > > > Subject: Re

[PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Julien Stephan
From: Phi-bang Nguyen This is a new driver that supports the MIPI CSI CD-PHY for mediatek mt8365 soc Signed-off-by: Louis Kuo Signed-off-by: Phi-bang Nguyen [Julien Stephan: use regmap] [Julien Stephan: use GENMASK] Co-developed-by: Julien Stephan Signed-off-by: Julien Stephan --- .../bindi

[syzbot] [dri?] general protection fault in drm_crtc_next_vblank_start

2023-04-03 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a6d9e3034536 Add linux-next specific files for 20230330 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=1001d1cdc8 kernel config: https://syzkaller.appspot.com/x/.config?x=aceb117f7924508e dashbo

Re: [PATCH] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-03 Thread Thomas Zimmermann
Hi Am 01.04.23 um 17:38 schrieb Rob Clark: From: Rob Clark This should fix a crash that was reported on ast (and possibly other drivers which do not initialize vblank). fbcon: Taking over console Unable to handle kernel NULL pointer dereference at virtual address 0074

Re: [PATCH 4/6] drm/omapdrm: Remove fbdev from struct omap_drm_private

2023-04-03 Thread Thomas Zimmermann
Hi Am 30.03.23 um 14:08 schrieb Tomi Valkeinen: On 30/03/2023 11:32, Thomas Zimmermann wrote: The DRM device stores a pointer to the fbdev helper. Remove struct omap_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann ---   drivers/gpu/drm

Re: [PATCH 5/6] drm/omapdrm: Initialize fbdev DRM client

2023-04-03 Thread Thomas Zimmermann
Hi Am 30.03.23 um 14:13 schrieb Tomi Valkeinen: On 30/03/2023 11:32, Thomas Zimmermann wrote: Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. I

Re: [PATCH 6/6] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Thomas Zimmermann
Hi Am 30.03.23 um 15:13 schrieb Tomi Valkeinen: On 30/03/2023 11:32, Thomas Zimmermann wrote: Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls bot

Re: [PULL] drm-misc-next

2023-04-03 Thread Daniel Vetter
On Fri, Mar 31, 2023 at 05:42:25PM +0200, Maarten Lankhorst wrote: > Hi Dave, Daniel, > > Small update. Slow week. Felt like sending a pull request regardless. > > drm-misc-next-2023-03-31: > drm-misc-next for v6.4-rc1: > > Cross-subsystem Changes: > - DT bindings update for adding Mali MT81xx d

Re: [pull] amdgpu, amdkfd, radeon drm-next-6.4

2023-04-03 Thread Daniel Vetter
On Fri, Mar 31, 2023 at 06:19:55PM -0400, Alex Deucher wrote: > Hi Dave, Daniel, > > More new stuff for 6.4. > > The following changes since commit d36d68fd1925d33066d52468b7c7c6aca6521248: > > Merge tag 'drm-habanalabs-next-2023-03-20' of > https://git.kernel.org/pub/scm/linux/kernel/git/oga

Re: linux-next: build failure after merge of the drm-misc tree

2023-04-03 Thread Qiang Yu
I think you can just revert the following three lima commits when merge: * 4a66f3da99dc ("drm/lima: add show_fdinfo for drm usage stats") * 87767de835ed ("drm/lima: allocate unique id per drm_file") * bccafec957a5 ("drm/lima: add usage counting method to ctx_mgr") Regards, Qiang On Mon, Apr 3, 20

Re: [PATCH 6/6] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Tomi Valkeinen
Hi Thomas, On 03/04/2023 11:24, Thomas Zimmermann wrote: That's my only real comment. Kernel test bot had one comment too. But other than that: Reviewed-by: Tomi Valkeinen I tested this series on TI DRA76 EVM, and worked fine for me. That you so much. I'm going to send out an update with

Re: [PATCH] drm/mediatek: dp: change the aux retries times when receiving AUX_DEFER

2023-04-03 Thread 李昕磊

[PATCH v4 00/12] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-04-03 Thread Dmitry Baryshkov
Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note: the RC parameters were cross-checked against config files found in DSC model 2021062, 2016

[PATCH v4 02/12] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-04-03 Thread Dmitry Baryshkov
The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with the code to propagage them to the drm_dsc_config. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 35 +++ dri

[PATCH v4 01/12] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-04-03 Thread Dmitry Baryshkov
After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the model, by patching the rc values in the code. Note: I left one case uncorrected, 8bpp/10b

[PATCH v4 04/12] drm/i915/dsc: stop using interim structure for calculated params

2023-04-03 Thread Dmitry Baryshkov
Stop using an interim structure rc_parameters for storing calculated params and then setting drm_dsc_config using that structure. Instead put calculated params into the struct drm_dsc_config directly. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/inte

[PATCH v4 03/12] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-04-03 Thread Dmitry Baryshkov
Move DSC RC tables to DRM DSC helper. No additional code changes and/or cleanups are a part of this commit, it will be cleaned up in the followup commits. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++ drivers

[PATCH v4 09/12] drm/display/dsc: add helper to set semi-const parameters

2023-04-03 Thread Dmitry Baryshkov
Add a helper setting config values which are typically constant across operating modes (table E-4 of the standard) and mux_word_size (which is a const according to 3.5.2). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 22 ++ include/drm/displa

[PATCH v4 05/12] drm/display/dsc: use flat array for rc_parameters lookup

2023-04-03 Thread Dmitry Baryshkov
Next commits are going to add support for additional RC parameter lookup tables. These tables are going to use different bpp/bpc combinations, thus it makes little sense to keep the 2d array for RC parameters. Switch to using the flat array. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshko

[PATCH v4 06/12] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-04-03 Thread Dmitry Baryshkov
The array of rc_parameters contains a mixture of parameters from DSC 1.1 and DSC 1.2 standards. Split these tow configuration arrays in preparation to adding more configuration data. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 127 ++ drive

[PATCH v4 10/12] drm/display/dsc: Add flatness and initial scale value calculations

2023-04-03 Thread Dmitry Baryshkov
From: Jessica Zhang Add helpers to calculate det_thresh_flatness and initial_scale_value as these calculations are defined within the DSC spec. Changes in v2: - Renamed det_thresh_flatness to flatness_det_thresh - Set initial_scale_value directly in helper Signed-off-by: Jessica Zhang Signed-o

[PATCH v4 07/12] drm/display/dsc: include the rest of pre-SCR parameters

2023-04-03 Thread Dmitry Baryshkov
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, include them here for completeness. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 72 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dsc_

[PATCH v4 08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-04-03 Thread Dmitry Baryshkov
Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 438 +++ include/drm/display/drm_dsc_helper.h | 2 + 2 files changed, 440 insertions(+) diff --git a/drivers/gpu/drm/display/d

[PATCH v4 11/12] drm/i915/dsc: use additional DSC helpers

2023-04-03 Thread Dmitry Baryshkov
Switch to drm_dsc_set_const_params() to set some semi-constant parameters. The rc_model_size, which is set beforehand, is preserved by the helper. Also make use of drm_dsc_set_initial_scale_value(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/intel_vdsc.c | 15 ++

[PATCH v4 12/12] drm/i915/dsc: make use of several params from drm_dsc_config

2023-04-03 Thread Dmitry Baryshkov
The code was ignoring (up to some point for rc_model_size) the rc_model_size, rc_tgt_offset_high, rc_tgt_offset_low and rc_edge_factor parameters from struct drm_dsc_config. Actually use them instead of resorting to predefined constants. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/d

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-04-03 Thread Krzysztof Kozlowski
On 03/04/2023 05:30, Chun-Kuang Hu wrote: > Hi, Chen-yu: > > Chen-Yu Tsai 於 2023年3月30日 週四 下午7:05寫道: >> >> On Mon, Mar 27, 2023 at 11:17 PM Chun-Kuang Hu >> wrote: >>> >>> Hi, Angelo: >>> >>> AngeloGioacchino Del Regno 於 >>> 2023年3月24日 週五 下午4:38寫道: Il 24/03/23 00:25, Chun-Kuang Hu ha

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Krzysztof Kozlowski
On 03/04/2023 09:19, Julien Stephan wrote: > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] > Co-developed-by

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Chun-Kuang Hu
Hi, Julien: Julien Stephan 於 2023年4月3日 週一 下午3:20寫道: > > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] > Co-d

Re: [PATCH v1 0/7] Move dma-buf mmap() reservation locking down to exporters

2023-04-03 Thread Dmitry Osipenko
On 4/2/23 19:48, Dmitry Osipenko wrote: > This patchset makes dma-buf exporters responisble for taking care of > the reservation lock. I also included patch that moves drm-shmem to use > reservation lock, to let CI test the whole set. I'm going to take all > the patches via the drm-misc tree, pleas

[PATCH v2 0/5] drm/omapdrm: Convert fbdev to DRM client

2023-04-03 Thread Thomas Zimmermann
Convert omapdrm's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in omapdrm is now just another DRM client that runs after the DRM device has been registered. Once all driver

[PATCH v2 2/5] drm/omapdrm: Remove fb from struct omap_fbdev

2023-04-03 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct omap_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 11 ++- 1 file changed, 6 insertions(+

[PATCH v2 3/5] drm/omapdrm: Remove bo from struct omap_fbdev

2023-04-03 Thread Thomas Zimmermann
Fbdev's framebuffer stores a pointer to the GEM object. Remove struct omap_fbdev.bo, which contains the same value. No functional changes. v2: * fix commit message (Tomi) Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 32

[PATCH v2 1/5] drm/omapdrm: Include

2023-04-03 Thread Thomas Zimmermann
Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c ind

[PATCH v2 4/5] drm/omapdrm: Remove fbdev from struct omap_drm_private

2023-04-03 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct omap_drm_private.fbdev, which contains the same value. No functional changes. v2: * don't clear dev->fb_helper unnecessarily (Tomi) * include omap_fbdev.h in omap_fbdev.c (kernel test robot) Signed-off-by: Thomas Z

[PATCH v2 5/5] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

Re: [PATCH 0/5] drm/exynos: Convert fbdev to DRM client

2023-04-03 Thread Thomas Zimmermann
Am 31.03.23 um 12:36 schrieb Marek Szyprowski: On 30.03.2023 09:36, Thomas Zimmermann wrote: Convert exynos' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in exynos is n

Re: [1/7] drm/tegra: Include

2023-04-03 Thread Thomas Zimmermann
Am 30.03.23 um 14:51 schrieb Sui Jingfeng: Reviewed-by: Sui Jingfeng > Thanks a lot. On 2023/3/30 16:36, Thomas Zimmermann wrote: Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann ---   drivers/gpu/drm/t

Re: [PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

2023-04-03 Thread Thomas Zimmermann
Hi Am 30.03.23 um 11:51 schrieb Dmitry Baryshkov: On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: Move aperture management out of the fbdev code. It is unrelated and needs to run even if fbdev support has been disabled. Call the helper at the top of msm_drm_init() to take over hardware

RE: [PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running

2023-04-03 Thread Vinod Polimera
> On Fri, 31 Mar 2023 at 16:59, Vinod Polimera > wrote: > > > > In certain CPU stress conditions, there can be a delay in scheduling commit > > work and it was observed that PSR commit from a different work queue > was > > scheduled. Avoid these commits as display is already in PSR mode. > > > > S

Re: [PATCH] accel/ivpu: Remove D3hot delay for Meteorlake

2023-04-03 Thread Stanislaw Gruszka
On Fri, Mar 31, 2023 at 02:26:04PM -0500, Bjorn Helgaas wrote: > On Fri, Mar 31, 2023 at 01:40:27PM +0200, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > VPU on MTL has hardware optimizations and does not require 10ms > > D0 - D3hot transition delay imposed by PCI specification. > >

[PATCH v2] accel/ivpu: Remove D3hot delay for Meteorlake

2023-04-03 Thread Stanislaw Gruszka
From: Karol Wachowski VPU on MTL has hardware optimizations and does not require 10ms D0 - D3hot transition delay imposed by PCI specification (PCIe r6.0, sec 5.9.) . The delay removal is traditionally done by adding PCI ID to quirk_remove_d3hot_delay() in drivers/pci/quirks.c . But since we do

Re: [PATCH v1] drm/bridge: lt8912b: Fix DSI Video Mode

2023-04-03 Thread rfoss
From: Robert Foss On Thu, 30 Mar 2023 11:31:31 +0200, Francesco Dolcini wrote: > From: Francesco Dolcini > > LT8912 DSI port supports only Non-Burst mode video operation with Sync > Events and continuous clock on clock lane, correct dsi mode flags > according to that removing MIPI_DSI_MODE_VIDE

[PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Fabio Estevam
From: Jagan Teki Samsung MIPI DSIM bridge can be found on Exynos and NXP's i.MX8M Mini/Nano/Plus SoCs. Convert exynos_dsim.txt to yaml. Used the example node from latest Exynos SoC instead of the one used in legacy exynos_dsim.txt. Signed-off-by: Jagan Teki Signed-off-by: Fabio Estevam ---

[PATCH v2 1/8] drm/msm: Include

2023-04-03 Thread Thomas Zimmermann
Include to get the declaration of devm_ioremap() on sparc64. No functional changes. Signed-off-by: Thomas Zimmermann Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303301856.zsmpwzjj-...@intel.com/ --- drivers/gpu/drm/msm/msm_io_utils.c | 1 + 1 file changed, 1 i

[PATCH v2 3/8] drm/msm: Remove fb from struct msm_fbdev

2023-04-03 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct msm_fbdev.fb, which contains thre same value. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_fbdev.c | 32 +--- 1 file chang

[PATCH v2 0/8] drm/msm: Convert fbdev to DRM client

2023-04-03 Thread Thomas Zimmermann
Convert msm' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in msm is now just another DRM client that runs after the DRM device has been registered. Once all drivers' fbdev

[PATCH v2 5/8] drm/msm: Remove fbdev from struct msm_drm_private

2023-04-03 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct msm_drm_private.fbdev, which contains the same value. No functional changes. v2: * test for fb_helper->fb in debugfs code Signed-off-by: Thomas Zimmermann Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_debugf

[PATCH v2 2/8] drm/msm: Clear aperture ownership outside of fbdev code

2023-04-03 Thread Thomas Zimmermann
Move aperture management out of the fbdev code. It is unrelated and needs to run even if fbdev support has been disabled. Call the helper at the top of msm_drm_init() to take over hardware from other drivers. v2: * bind all subdevices before acquiring device (Dmitri) Signed-off-by: Thomas

[PATCH v2 7/8] drm/msm: Initialize fbdev DRM client

2023-04-03 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_fbdev.

[PATCH v2 8/8] drm/msm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[PATCH v2 4/8] drm/msm: Remove struct msm_fbdev

2023-04-03 Thread Thomas Zimmermann
Remove struct msm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. v2: * kfree fbdev helper instance on init errors (Dmitri) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 20 1 fil

[PATCH v2 6/8] drm/msm: Move module parameter 'fbdev' to fbdev code

2023-04-03 Thread Thomas Zimmermann
Define the module's parameter 'fbdev' in fbdev code. No other code uses it. No functional changes, but simplifies the later conversion to struct drm_client. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 10 ++ drivers/gpu/drm/msm/msm_fbdev.c | 7 +++ 2 files

Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Krzysztof Kozlowski
On 03/04/2023 14:44, Fabio Estevam wrote: > From: Jagan Teki > > Samsung MIPI DSIM bridge can be found on Exynos and NXP's > i.MX8M Mini/Nano/Plus SoCs. > > Convert exynos_dsim.txt to yaml. > > Used the example node from latest Exynos SoC instead of > the one used in legacy exynos_dsim.txt. >

Re: [PATCH] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Krzysztof Kozlowski
On 31/03/2023 21:57, Fabio Estevam wrote: > From: Jagan Teki > > Samsung MIPI DSIM bridge can be found on Exynos and NXP's > i.MX8M Mini and Nano SoC's. > > Convert exynos_dsim.txt to yaml. > > Used the example node from latest Exynos SoC instead of > the one used in legacy exynos_dsim.txt. >

Re: [PATCH 1/7] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-03 Thread Jani Nikula
On Fri, 31 Mar 2023, fei.y...@intel.com wrote: > From: Fei Yang > > On MTL, GT can no longer allocate on LLC - only the CPU can. > This, along with addition of support for ADM/L4 cache calls a > MOCS/PAT table update. > Also add PTE encode functions for MTL as it has different PAT > index definiti

Re: [PATCH 4/4] drm/i915: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Thomas Zimmermann
Hi Am 28.03.23 um 17:31 schrieb Jani Nikula: On Tue, 28 Mar 2023, Thomas Zimmermann wrote: Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to i915_fbdev_setup() after i915 has registered its DRM device. J

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Emil Velikov
On Sun, 2 Apr 2023 at 18:45, Dmitry Osipenko wrote: > > On 3/30/23 20:24, Emil Velikov wrote: > > Hi Dmitry, > > > > Have you considered creating a few DRM helpers for this functionality? > > > > AFAICT this is the third driver which supports syncobj timelines and > > looking at one of the impleme

Re: [PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-04-03 Thread Thomas Zimmermann
Hi Geert Am 31.03.23 um 16:48 schrieb Geert Uytterhoeven: Hi all, Currently, there are two drivers for the LCD controller on Renesas SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: 1. sh_mobile_lcdcfb, using the fbdev framework, 2. shmob_drm, using the DRM framework. Howev

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Emil Velikov
On Mon, 3 Apr 2023 at 14:00, Emil Velikov wrote: > > > I think we should zero num_(in|out)_syncobjs when the respective parse > > > fails. Otherwise we get one "cleanup" within the parse function itself > > > and a second during the cleanup_submit. Haven't looked at it too closely > > > but I sus

Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Fabio Estevam
Hi Krzysztof, On 03/04/2023 09:49, Krzysztof Kozlowski wrote: Signed-off-by: Jagan Teki Signed-off-by: Fabio Estevam --- Changes since v1: - Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan) - Added Marek Szyprowski entry to the samsung,mipi-dsim.yaml maintainers section (Jagan)

Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Krzysztof Kozlowski
On 03/04/2023 15:25, Fabio Estevam wrote: > Hi Krzysztof, > > On 03/04/2023 09:49, Krzysztof Kozlowski wrote: > >>> Signed-off-by: Jagan Teki >>> Signed-off-by: Fabio Estevam >>> --- >>> Changes since v1: >>> - Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan) >>> - Added Marek Szy

Re: [1/7] drm/tegra: Include

2023-04-03 Thread Sui Jingfeng
Hi, On 2023/4/3 18:42, Thomas Zimmermann wrote: Am 30.03.23 um 14:51 schrieb Sui Jingfeng: Reviewed-by: Sui Jingfeng > Thanks a lot. I send my mail with Thunderbird mail client, don't know this does this look like this. Sorry about that. It should be:

Re: [PATCH 0/5] drm: shmobile: Fixes and enhancements

2023-04-03 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Apr 3, 2023 at 3:14 PM Thomas Zimmermann wrote: > Am 31.03.23 um 16:48 schrieb Geert Uytterhoeven: > > Currently, there are two drivers for the LCD controller on Renesas > > SuperH-based and ARM-based SH-Mobile and R-Mobile SoCs: > >1. sh_mobile_lcdcfb, using the fbdev fram

Re: [PATCH v1 7/7] drm/shmem-helper: Switch to reservation lock

2023-04-03 Thread Emil Velikov
Hi Dmitry, On Sun, 2 Apr 2023 at 17:49, Dmitry Osipenko wrote: > -void drm_gem_shmem_put_pages(struct drm_gem_shmem_object *shmem) > +static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem) > { > - mutex_lock(&shmem->pages_lock); > - drm_gem_shmem_put_pages_locked(sh

Re: [PATCH v2 5/5] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Emil Velikov
On Mon, 3 Apr 2023 at 11:41, Thomas Zimmermann wrote: > > Move code from ad-hoc fbdev callbacks into DRM client functions > and remove the old callbacks. The functions instruct the client > to poll for changed output or restore the display. The DRM core > calls both, the old callbacks and the new

Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Jagan Teki
On Mon, Apr 3, 2023 at 7:13 PM Krzysztof Kozlowski wrote: > > On 03/04/2023 15:25, Fabio Estevam wrote: > > Hi Krzysztof, > > > > On 03/04/2023 09:49, Krzysztof Kozlowski wrote: > > > >>> Signed-off-by: Jagan Teki > >>> Signed-off-by: Fabio Estevam > >>> --- > >>> Changes since v1: > >>> - Added

Re: [PATCH v2 5/5] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Thomas Zimmermann
Hi Am 03.04.23 um 16:27 schrieb Emil Velikov: On Mon, 3 Apr 2023 at 11:41, Thomas Zimmermann wrote: Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core c

Re: [PATCH 5/7] drm/i915: use pat_index instead of cache_level

2023-04-03 Thread Ville Syrjälä
On Fri, Mar 31, 2023 at 11:38:28PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > Currently the KMD is using enum i915_cache_level to set caching policy for > buffer objects. This is flaky because the PAT index which really controls > the caching behavior in PTE has far more levels than wh

RE: [PATCH v1 1/3] drm/msm/dpu: set dirty_fb flag while in self refresh mode

2023-04-03 Thread Vinod Polimera
> On Fri, 31 Mar 2023 at 16:59, Vinod Polimera > wrote: > > > > While in virtual terminal mode with PSR enabled, there will be > > no atomic commits triggered without dirty_fb being set. This > > will create a notion of no screen update. Allow atomic commit > > when dirty_fb ioctl is issued, so th

Re: [PATCH v4 2/2] drm/virtio: Support sync objects

2023-04-03 Thread Dmitry Osipenko
On 4/3/23 16:22, Emil Velikov wrote: > On Mon, 3 Apr 2023 at 14:00, Emil Velikov wrote: > I think we should zero num_(in|out)_syncobjs when the respective parse fails. Otherwise we get one "cleanup" within the parse function itself and a second during the cleanup_submit. Haven't lo

Re: [PATCH v3] ASoC: dt-bindings: maxim,max98371: Convert to DT schema

2023-04-03 Thread Mark Brown
On Sat, 01 Apr 2023 15:19:29 -0300, André Morishita wrote: > Convert the Maxim Integrated MAX98371 audio codec bindings to DT schema. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: dt-bindings: maxim,max98371: Convert to DT sch

Re: [PATCH v2 5/5] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-04-03 Thread Emil Velikov
On Mon, 3 Apr 2023 at 15:50, Thomas Zimmermann wrote: > > Hi > > Am 03.04.23 um 16:27 schrieb Emil Velikov: > > On Mon, 3 Apr 2023 at 11:41, Thomas Zimmermann wrote: > >> > >> Move code from ad-hoc fbdev callbacks into DRM client functions > >> and remove the old callbacks. The functions instruct

Re: [PATCH v1 5/7] Revert "drm: Assert held reservation lock for dma-buf mmapping"

2023-04-03 Thread Christian König
Am 02.04.23 um 18:48 schrieb Dmitry Osipenko: Don't assert held dma-buf reservation lock on memory mapping of exported buffer. We're going to change dma-buf mmap() locking policy such that exporters will have to handle the lock. The previous locking policy caused deadlock problem for DRM drivers

Re: [PATCH 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-04-03 Thread Chun-Kuang Hu
Hi, Julien: Julien Stephan 於 2023年4月3日 週一 下午3:20寫道: > > From: Phi-bang Nguyen > > This is a new driver that supports the MIPI CSI CD-PHY for mediatek > mt8365 soc > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-bang Nguyen > [Julien Stephan: use regmap] > [Julien Stephan: use GENMASK] > Co-d

Re: [PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running

2023-04-03 Thread Dmitry Baryshkov
On 31/03/2023 16:58, Vinod Polimera wrote: In certain CPU stress conditions, there can be a delay in scheduling commit work and it was observed that PSR commit from a different work queue was scheduled. Avoid these commits as display is already in PSR mode. Signed-off-by: Vinod Polimera --- d

Re: [PATCH v2 1/5] drm/tests: Test drm_rect_intersect()

2023-04-03 Thread Maíra Canal
Hi Arthur, On 3/27/23 10:38, Arthur Grillo wrote: Insert test for the drm_rect_intersect() function, it also create a helper for comparing drm_rects more easily. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 139 ++ 1 file changed, 139 inse

Re: [PATCH 01/19] drm/i915/i915_scatterlist: Fix kerneldoc formatting issue - missing '@'

2023-04-03 Thread Jani Nikula
On Fri, 31 Mar 2023, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/i915/i915_scatterlist.c:62: warning: Function parameter or > member 'size' not described in 'i915_refct_sgt_init' > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvr

Re: [PATCH v2 2/5] drm/tests: Test drm_rect_calc_hscale()

2023-04-03 Thread Maíra Canal
Hi Arthur, On 3/27/23 10:38, Arthur Grillo wrote: Insert test for the drm_rect_hscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 57 +++ 1 file changed, 57

Re: [v2,1/8] drm/msm: Include

2023-04-03 Thread Sui Jingfeng
Reviewed-by:  Sui Jingfeng On 2023/4/3 20:45, Thomas Zimmermann wrote: Include to get the declaration of devm_ioremap() on sparc64. No functional changes. Signed-off-by: Thomas Zimmermann Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303301856.zsmpwzjj-...

Re: [PATCH v2 3/5] drm/tests: Test drm_rect_calc_vscale()

2023-04-03 Thread Maíra Canal
Hi Arthur, On 3/27/23 10:38, Arthur Grillo wrote: Insert test for the drm_rect_vscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 56 +++ 1 file changed, 56

[PATCH v3 00/11] iio: new DMABUF based API, v3

2023-04-03 Thread Paul Cercueil
Hi Jonathan, Here's the v3 of my patchset that introduces a new interface based on DMABUF objects to complement the fileio API, and adds write() support to the existing fileio API. It changed quite a lot since V2; the IIO subsystem is now just a DMABUF importer, and all the complexity related to

[PATCH v3 01/11] dmaengine: Add API function dmaengine_prep_slave_dma_array()

2023-04-03 Thread Paul Cercueil
This function can be used to initiate a scatter-gather DMA transfer where the DMA addresses and lengths are located inside arrays. The major difference with dmaengine_prep_slave_sg() is that it supports specifying the lengths of each DMA transfer; as trying to override the length of the transfer w

[PATCH v3 02/11] dmaengine: dma-axi-dmac: Implement device_prep_slave_dma_array

2023-04-03 Thread Paul Cercueil
Add implementation of the .device_prep_slave_dma_array() callback. Signed-off-by: Paul Cercueil --- v3: New patch --- drivers/dma/dma-axi-dmac.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c in

[PATCH v3 03/11] iio: buffer-dma: Get rid of outgoing queue

2023-04-03 Thread Paul Cercueil
The buffer-dma code was using two queues, incoming and outgoing, to manage the state of the blocks in use. While this totally works, it adds some complexity to the code, especially since the code only manages 2 blocks. It is much easier to just check each block's state manually, and keep a counter

[PATCH v3 04/11] iio: buffer-dma: Enable buffer write support

2023-04-03 Thread Paul Cercueil
Adding write support to the buffer-dma code is easy - the write() function basically needs to do the exact same thing as the read() function: dequeue a block, read or write the data, enqueue the block when entirely processed. Therefore, the iio_buffer_dma_read() and the new iio_buffer_dma_write()

[PATCH v3 05/11] iio: buffer-dmaengine: Support specifying buffer direction

2023-04-03 Thread Paul Cercueil
Update the devm_iio_dmaengine_buffer_setup() function to support specifying the buffer direction. Update the iio_dmaengine_buffer_submit() function to handle input buffers as well as output buffers. Signed-off-by: Paul Cercueil Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/adi-axi-adc.c

[PATCH v3 06/11] iio: buffer-dmaengine: Enable write support

2023-04-03 Thread Paul Cercueil
Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() functions provided by the buffer-dma core, to enable write support in the buffer-dmaengine code. Signed-off-by: Paul Cercueil Reviewed-by: Alexandru Ardelean --- drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 ++ 1 file

[PATCH v3 07/11] iio: core: Add new DMABUF interface infrastructure

2023-04-03 Thread Paul Cercueil
Add the necessary infrastructure to the IIO core to support a new optional DMABUF based interface. With this new interface, DMABUF objects (externally created) can be attached to a IIO buffer, and subsequently used for data transfer. A userspace application can then use this interface to share DM

[PATCH v3 08/11] iio: buffer-dma: split iio_dma_buffer_fileio_free() function

2023-04-03 Thread Paul Cercueil
From: Alexandru Ardelean This change splits the logic into a separate function, which will be re-used later. Signed-off-by: Alexandru Ardelean Cc: Alexandru Ardelean Signed-off-by: Paul Cercueil --- drivers/iio/buffer/industrialio-buffer-dma.c | 43 +++- 1 file changed, 24 in

[PATCH v3 09/11] iio: buffer-dma: Enable support for DMABUFs

2023-04-03 Thread Paul Cercueil
Implement iio_dma_buffer_attach_dmabuf(), iio_dma_buffer_detach_dmabuf() and iio_dma_buffer_transfer_dmabuf(), which can then be used by the IIO DMA buffer implementations. Signed-off-by: Paul Cercueil --- v3: Update code to provide the functions that will be used as callbacks for the new IOCTLs

[PATCH v3 10/11] iio: buffer-dmaengine: Support new DMABUF based userspace API

2023-04-03 Thread Paul Cercueil
Use the functions provided by the buffer-dma core to implement the DMABUF userspace API in the buffer-dmaengine IIO buffer implementation. Since we want to be able to transfer an arbitrary number of bytes and not necesarily the full DMABUF, the associated scatterlist is converted to an array of DM

[PATCH v3 11/11] Documentation: iio: Document high-speed DMABUF based API

2023-04-03 Thread Paul Cercueil
Document the new DMABUF based API. Signed-off-by: Paul Cercueil Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- v2: - Explicitly state that the new interface is optional and is not implemented by all drivers. - The IOCTLs can now only be called on the buffer FD returned by

Re: [PATCH 3/3] drm: sun4i: calculate proper DCLK rate for DSI

2023-04-03 Thread Frank Oltmanns
On 2023-04-03 at 15:52:36 +0200, "Roman Beranek" wrote: > On Sun Apr 2, 2023 at 12:49 PM CEST, Frank Oltmanns wrote: >> >> When apply this to drm-next my panel stays dark. I haven't figured out >> yet why, though. The other two patches in this series work fine, i.e. >> they have no effect as the

Re: [syzbot] [dri?] general protection fault in drm_crtc_next_vblank_start

2023-04-03 Thread Rob Clark
On Mon, Apr 3, 2023 at 12:57 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:a6d9e3034536 Add linux-next specific files for 20230330 > git tree: linux-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=1001d1cdc8 > kernel config: ht

Re: [PATCH 7/7] drm/i915: Allow user to set cache at BO creation

2023-04-03 Thread Ville Syrjälä
On Fri, Mar 31, 2023 at 11:38:30PM -0700, fei.y...@intel.com wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out its life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching >

[PATCH v2] drm/vblank: Fix for drivers that do not drm_vblank_init()

2023-04-03 Thread Rob Clark
From: Rob Clark This should fix a crash that was reported on ast (and possibly other drivers which do not initialize vblank). fbcon: Taking over console Unable to handle kernel NULL pointer dereference at virtual address 0074 Mem abort info: ESR = 0x9604

Re: [PATCH v3 11/11] Documentation: iio: Document high-speed DMABUF based API

2023-04-03 Thread Jonathan Corbet
Paul Cercueil writes: One nit: > Document the new DMABUF based API. > > Signed-off-by: Paul Cercueil > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > > --- > v2: - Explicitly state that the new interface is optional and is > not implemented by all drivers. > - The IOCTLs can n

[PATCH] drm/vblank: Simplify drm_dev_has_vblank()

2023-04-03 Thread Rob Clark
From: Rob Clark What does vblank have to do with num_crtcs? Well, this was technically correct, but you'd have to go look at where num_crtcs is initialized to understand why. Lets just replace it with the simpler and more obvious check. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_vblank

Re: [PATCH] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml

2023-04-03 Thread Marek Vasut
On 3/31/23 21:57, Fabio Estevam wrote: [...] +properties: + compatible: +enum: + - samsung,exynos3250-mipi-dsi + - samsung,exynos4210-mipi-dsi + - samsung,exynos5410-mipi-dsi + - samsung,exynos5422-mipi-dsi + - samsung,exynos5433-mipi-dsi + - fsl,imx8mm-mipi-d

  1   2   3   >