Re: [PATCH v3 0/7] drm/msm: add support for SM8550

2023-03-30 Thread Neil Armstrong
On 29/03/2023 22:13, Dmitry Baryshkov wrote: On 29/03/2023 22:52, Rob Herring wrote: On Tue, Mar 28, 2023 at 5:38 PM Dmitry Baryshkov wrote: On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is ba

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Lucas De Marchi
On Thu, Mar 30, 2023 at 08:57:36AM +0200, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buff

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Sui Jingfeng
Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just

[PATCH 1/7] accel/habanalabs: print raw binning masks in debug level

2023-03-30 Thread Oded Gabbay
From: Ofir Bitton There are rare cases of failures when cards are initialized due to wrong values in efuse mappings that are parsed by firmware. To help debug those cases, print (in debug level) the raw binning masks as fetched from the firmware during device initialization. Signed-off-by: Ofir

[PATCH 2/7] accel/habanalabs: remove completion from abnormal interrupt work name

2023-03-30 Thread Oded Gabbay
From: Tomer Tayar Decoder abnormal interrupts are for errors and not for completion, so rename the relevant work and work function to not include 'completion'. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/decoder.c| 22

[PATCH 3/7] accel/habanalabs: fix events mask of decoder abnormal interrupts

2023-03-30 Thread Oded Gabbay
From: Tomer Tayar The decoder IRQ status register may have several set bits upon an abnormal interrupt. Therefore, when setting the events mask, need to check all bits and not using if-else. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/haba

[PATCH 6/7] accel/habanalabs: don't wait for STS_OK after sending COMMS WFE

2023-03-30 Thread Oded Gabbay
From: Koby Elbaz Sending COMMS_GOTO_WFE instructs the FW's CPU to halt (WFE state). Once sent, FW's CPU isn't expected to continue communicating with LKD. Therefore, the stage of waiting for COMMS_STS_OK should be skipped or else waiting for COMMS_STS_OK will simply timeout, which will trigger un

[PATCH 7/7] accel/habanalabs: fixes for unexpected error interrupt

2023-03-30 Thread Oded Gabbay
From: Ofir Bitton Removing redundant asic prop variable as we don't need to expose this to common code. In addition, fix some typos. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/habanalabs.h | 2 -- drivers/accel/habanalab

[PATCH 5/7] accel/habanalabs: sync f/w events interrupt in hard reset

2023-03-30 Thread Oded Gabbay
From: Tal Cohen Receiving events from FW, while the device is in hard reset, causes a warning message in Driver log. The message may point to a problem in the Driver or FW. But It also can appear as a result of events that have been sent from FW just before the hard reset. In order to avoid recei

[PATCH 4/7] accel/habanalabs: fix wrong reset and event flags

2023-03-30 Thread Oded Gabbay
From: Ofir Bitton During event handling, driver sets relevant reset and user event notifier flags. Fix few wrong flags settings. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 13 + 1 file changed, 9 i

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Thomas Zimmermann
Hi Am 30.03.23 um 09:17 schrieb Sui Jingfeng: Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment

[PATCH 0/4] drm/armada: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert armada's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other driver's fbdev emulation, fbdev in armada is now just another DRM client that runs after the DRM device has been registered. Once all drivers'

[PATCH 3/4] drm/armada: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_fbdev.c | 43 ++

[PATCH 4/4] drm/armada: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[PATCH 1/4] drm/armada: Include

2023-03-30 Thread Thomas Zimmermann
Include to get declarations of of_node_put() and of_device_is_available(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/armada_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv

[PATCH 2/4] drm/armada: Hide fbdev support behind config option

2023-03-30 Thread Thomas Zimmermann
Only build armada's fbdev emulation if CONFIG_DRM_FBDEV_EMULATION has been enabled. No functional changes, but allows to build armada without fbdev. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/armada/Makefile | 3 ++- drivers/gpu/drm/armada/armada_drm.h | 14 -- 2 files

Re: [PATCH v2] dt-bindings: display: seiko,43wvf1g: Change the maintainer's contact

2023-03-30 Thread Krzysztof Kozlowski
On 29/03/2023 22:11, Fabio Estevam wrote: > From: Fabio Estevam > > Marco's NXP email is no longer valid. > > Marco told me offline that he has no interest to be listed as the > maintainer contact for this binding, so add my contact. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2] dt-bindings: display: seiko,43wvf1g: Change the maintainer's contact

2023-03-30 Thread Neil Armstrong
Hi, On Wed, 29 Mar 2023 17:11:50 -0300, Fabio Estevam wrote: > Marco's NXP email is no longer valid. > > Marco told me offline that he has no interest to be listed as the > maintainer contact for this binding, so add my contact. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/dr

[PATCH 0/5] drm/exynos: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert exynos' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in exynos is now just another DRM client that runs after the DRM device has been registered. Once all drivers'

[PATCH 2/5] drm/exynos: Remove struct exynos_drm_fbdev

2023-03-30 Thread Thomas Zimmermann
Remove struct exynos_drm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff

[PATCH 3/5] drm/exynos: Remove fb_helper from struct exynos_drm_private

2023-03-30 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct exynos_drm_private.fb_helper, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 15 +-

[PATCH 1/5] drm/exynos: Remove exynos_gem from struct exynos_drm_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's framebuffer stores a pointer to the GEM object. Remove struct exynos_drm_fbdev.exynos_gem, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 13 - 1 file changed, 4 insertions(+), 9 deletions

[PATCH 5/5] drm/exynos: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[PATCH 4/5] drm/exynos: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 35 ++

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

2023-03-30 Thread Krzysztof Kozlowski
On 29/03/2023 16:41, Fabio Estevam wrote: > From: Fabio Estevam > > The Samsung DSIM IP block allows the inversion of the clock and > data lanes. > > Add an optional property called 'lane-polarities' that describes the > polarities of the MIPI DSI clock and data lanes. > > This is property is u

[PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

2023-03-30 Thread Thomas Zimmermann
Move aperture management out of the fbdev code. It is unrelated and needs to run even if fbdev support has been disabled. Call the helper at the top of msm_drm_init() to take over hardware from other drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_drv.c | 6 ++ driver

[PATCH 0/6] drm/msm: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert msm' fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in msm is now just another DRM client that runs after the DRM device has been registered. Once all drivers' fbdev

[PATCH 3/6] drm/msm: Remove struct msm_fbdev

2023-03-30 Thread Thomas Zimmermann
Remove struct msm_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 19 +++ 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/gp

[PATCH 2/6] drm/msm: Remove fb from struct msm_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct msm_fbdev.fb, which contains thre same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 32 +--- 1 file changed, 13 insertions(+), 19 deleti

[PATCH 4/6] drm/msm: Remove fbdev from struct msm_drm_private

2023-03-30 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct msm_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_debugfs.c | 5 ++--- drivers/gpu/drm/msm/msm_drv.c | 4 ++-- drivers/gpu/drm/msm/msm_dr

[PATCH 5/6] drm/msm: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/msm/msm_fbdev.c | 38

[PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

Re: [PATCH 1/2] dt-bindings: display: bridge: ldb: Add i.MX6SX support

2023-03-30 Thread Krzysztof Kozlowski
On 29/03/2023 15:04, Fabio Estevam wrote: > From: Fabio Estevam > > i.MX6SX has a single LVDS port and share a similar LDB_CTRL register > layout with i.MX8MP and i.MX93. > > Signed-off-by: Fabio Estevam > --- > .../devicetree/bindings/display/bridge/fsl,ldb.yaml | 11 +++ > 1 file c

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Sui Jingfeng
On 2023/3/30 15:26, Thomas Zimmermann wrote: Hi Am 30.03.23 um 09:17 schrieb Sui Jingfeng: Hi, On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

2023-03-30 Thread Jagan Teki
On Thu, Mar 30, 2023 at 1:08 PM Krzysztof Kozlowski wrote: > > On 29/03/2023 16:41, Fabio Estevam wrote: > > From: Fabio Estevam > > > > The Samsung DSIM IP block allows the inversion of the clock and > > data lanes. > > > > Add an optional property called 'lane-polarities' that describes the > >

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Sui Jingfeng
On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just tri

[PATCH 1/6] drm/omapdrm: Include

2023-03-30 Thread Thomas Zimmermann
Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 699ed814e021..fb403b44769c

[PATCH 0/6] drm/omapdrm: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert omapdrm's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in omapdrm is now just another DRM client that runs after the DRM device has been registered. Once all driver

[PATCH 4/6] drm/omapdrm: Remove fbdev from struct omap_drm_private

2023-03-30 Thread Thomas Zimmermann
The DRM device stores a pointer to the fbdev helper. Remove struct omap_drm_private.fbdev, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_debugfs.c | 6 +++--- drivers/gpu/drm/omapdrm/omap_drv.c | 1 + drivers/gpu/drm/o

[PATCH 6/6] drm/omapdrm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[PATCH 2/6] drm/omapdrm: Remove fb from struct omap_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct omap_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH 3/6] drm/omapdrm: Remove bo from struct omap_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's framebuffer stores a pointer to the GEM object. Remove struct omap_fbdev.exynos_gem, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 32 +--- 1 file changed, 19 insertions(+), 13 del

[PATCH 5/6] drm/omapdrm: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 33 +++

[PATCH 1/7] drm/tegra: Include

2023-03-30 Thread Thomas Zimmermann
Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 2 ++ drivers/gpu/drm/tegra/rgb.c| 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c inde

[PATCH 0/7] drm/tegra: Convert fbdev to DRM client

2023-03-30 Thread Thomas Zimmermann
Convert tegra's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other drivers' fbdev emulation, fbdev in tegra is now just another DRM client that runs after the DRM device has been registered. Once all drivers' f

[PATCH 2/7] drm/tegra: Include

2023-03-30 Thread Thomas Zimmermann
Include to get the contained declarations. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index d31c87f48da0..dc2dcb5ca1c8 100644 --- a

[PATCH 3/7] drm/tegra: Removed fb from struct tegra_fbdev

2023-03-30 Thread Thomas Zimmermann
Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove struct tegra_fbdev.fb, which contains the same value. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/drm.h | 1 - drivers/gpu/drm/tegra/fb.c | 23 --- 2 files changed, 12

[PATCH 7/7] drm/tegra: Implement fbdev emulation as in-kernel client

2023-03-30 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform t

[PATCH 4/7] drm/tegra: Remove struct tegra_fbdev

2023-03-30 Thread Thomas Zimmermann
Remove struct tegra_fbdev, which is an empty wrapper around struct drm_fb_helper. Use the latter directly. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/drm.h | 10 --- drivers/gpu/drm/tegra/fb.c | 59 ++--- 2 files changed

[PATCH 5/7] drm/tegra: Hide fbdev support behind config option

2023-03-30 Thread Thomas Zimmermann
Only build tegra's fbdev emulation if CONFIG_DRM_FBDEV_EMULATION has been enabled. As part of this change, move the code into its own source file. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/Makefile | 2 + drivers/gpu/drm/tegra/drm.h| 20 +++ drivers

[PATCH 6/7] drm/tegra: Initialize fbdev DRM client

2023-03-30 Thread Thomas Zimmermann
Initialize the fbdev client in the fbdev code with empty helper functions. Also clean up the client. The helpers will later implement various functionality of the DRM client. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tegra/fbdev.c | 33 ++

Re: [PATCH] drm/scdc-helper: Pimp SCDC debugs

2023-03-30 Thread Maxime Ripard
Hi, On Wed, Mar 29, 2023 at 08:14:02PM +0300, Ville Syrjala wrote: > diff --git a/drivers/gpu/drm/display/drm_scdc_helper.c > b/drivers/gpu/drm/display/drm_scdc_helper.c > index c3ad4ab2b456..2b124152384c 100644 > --- a/drivers/gpu/drm/display/drm_scdc_helper.c > +++ b/drivers/gpu/drm/display/drm

Re: [PATCH v7 12/12] drm: sun4: dsi: Convert to bridge driver

2023-03-30 Thread Maxime Ripard
On Thu, Mar 30, 2023 at 12:15:49PM +0530, Jagan Teki wrote: > On Wed, Mar 29, 2023 at 9:36 PM Maxime Ripard wrote: > > > > On Wed, Mar 29, 2023 at 09:08:17PM +0530, Jagan Teki wrote: > > > On Wed, Mar 29, 2023 at 8:29 PM Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > The patch prefix sh

[PATCH 2/3] drm/drm_gem.c: remove surplus else after return clause

2023-03-30 Thread Sui Jingfeng
From: Sui Jingfeng else is not generally useful after return Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_gem.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index a6208e2c089b..364e3733af98 100644 --- a

[PATCH 3/3] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Sui Jingfeng
From: Sui Jingfeng The assignment already done in drm_client_buffer_vmap(), this patch save a copy. No functional change. Signed-off-by: Sui Jingfeng --- drivers/gpu/drm/drm_fbdev_generic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fbdev_gen

[PATCH 1/3] dma-buf/dma-buf.c: add a blank line between the two adjoining functions

2023-03-30 Thread Sui Jingfeng
From: Sui Jingfeng Trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index aa4ea8530cb3..485b022a31fa 100644 --- a/dri

Re: [PATCH] drm/fbdev-generic: optimize out a redundant assignment clause

2023-03-30 Thread Sui Jingfeng
On 2023/3/30 14:57, Thomas Zimmermann wrote: Hi Am 30.03.23 um 06:17 schrieb Lucas De Marchi: On Wed, Mar 29, 2023 at 11:04:17AM +0200, Thomas Zimmermann wrote: (cc'ing Lucas) Hi Am 25.03.23 um 08:46 schrieb Sui Jingfeng:  The assignment already done in drm_client_buffer_vmap(),  just tri

[PATCH v1] drm/bridge: lt8912b: Fix DSI Video Mode

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini LT8912 DSI port supports only Non-Burst mode video operation with Sync Events and continuous clock on clock lane, correct dsi mode flags according to that removing MIPI_DSI_MODE_VIDEO_BURST flag. Cc: Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge"

[PATCH] accel/habanalabs/uapi: new Gaudi2 server type

2023-03-30 Thread Oded Gabbay
Add definition of a new Gaudi2 server type. This represents the connectivity between the cards in that server type. Signed-off-by: Oded Gabbay --- include/uapi/drm/habanalabs_accel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/habanalabs_accel.h b/incl

Re: [PATCH v1] drm/bridge: lt8912b: Fix DSI Video Mode

2023-03-30 Thread Robert Foss
On Thu, Mar 30, 2023 at 11:31 AM Francesco Dolcini wrote: > > From: Francesco Dolcini > > LT8912 DSI port supports only Non-Burst mode video operation with Sync > Events and continuous clock on clock lane, correct dsi mode flags > according to that removing MIPI_DSI_MODE_VIDEO_BURST flag. > > Cc:

Re: [PATCH] drm/ttm: set TTM allocated pages as reserved

2023-03-30 Thread David Stevens
On Thu, Mar 30, 2023 at 2:22 AM Sean Christopherson wrote: > > +David > > On Wed, Mar 29, 2023, Paolo Bonzini wrote: > > On 3/29/23 18:43, Christian K�nig wrote: > > > > > > > > > > > > 3) other uses of kmap() must switch to MMU-notifier protection. > > > > > > I would rather suggest to return t

Re: [PATCH 0/6] drm/msm: Convert fbdev to DRM client

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Convert msm' fbdev code to struct drm_client. Replaces the current > ad-hoc integration. The conversion includes a number of cleanups. As > with most other drivers' fbdev emulation, fbdev in msm is now just > another DRM client that runs a

Re: [PATCH 1/6] drm/msm: Clear aperture ownership outside of fbdev code

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Move aperture management out of the fbdev code. It is unrelated > and needs to run even if fbdev support has been disabled. Call > the helper at the top of msm_drm_init() to take over hardware > from other drivers. > > Signed-off-by: Thoma

Re: [PATCH 2/6] drm/msm: Remove fb from struct msm_fbdev

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Fbdev's struct fb_helper stores a pointer to the framebuffer. Remove > struct msm_fbdev.fb, which contains thre same value. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_fbdev.c | 32 ++

Re: [PATCH 3/6] drm/msm: Remove struct msm_fbdev

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Remove struct msm_fbdev, which is an empty wrapper around struct > drm_fb_helper. Use the latter directly. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_fbdev.c | 19 +++ > 1

[PATCH v1 3/6] dt-bindings: display: bridge: toshiba, tc358768: add parallel input mode

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add new toshiba,input-rgb-mode property to describe the actual signal connection on the parallel RGB input interface. Signed-off-by: Francesco Dolcini --- .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --gi

[PATCH v1 6/6] drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add atomic_get_input_bus_fmts() implementation, tc358768 has a parallel RGB input interface with the actual bus format depending on the amount of parallel input data lines. Without this change when the tc358768 is used with less than 24bit the color mapping is completely

[PATCH v1 4/6] drm/bridge: tc358768: Add TC9594

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add TC9594 ids, from the software point of view this is fully compatible with tc358768, the only difference is the automotive qualification. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/driv

[PATCH v1 5/6] drm/bridge: tc358768: Add parallel data format cfg

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add configuration for parallel data format register, tc358768 supports different mapping on the parallel input RGB interface, enable the configuration for it. Valid values, and the related meaning, are: 0 = R[7:0], G[7:0], B[7:0] 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[

[PATCH v1 0/6] drm/bridge: tc358768: Improve parallel RGB input configuration

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add support for different parallel RGB input format and mapping, this enables using the TC358768 when the parallel input width is less than 24-bit or the input mapping is not the default one. In addition to that this series add support for the TC9594, that is the automoti

[PATCH v1 2/6] dt-bindings: display: bridge: toshiba, tc358768: Add TC9594

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Add TC9594, from the software point of view this is identical to TC358768 with the main difference being automotive qualified. Signed-off-by: Francesco Dolcini --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v1 1/6] dt-bindings: display: bridge: toshiba, tc358768: Fix typo

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Correct Toshiba spelling. Signed-off-by: Francesco Dolcini --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/

Re: [PATCH v7 10/12] drm/bridge: Implement enable_next_first to alter bridge init order

2023-03-30 Thread Dave Stevenson
Hi Jagan On Thu, 30 Mar 2023 at 07:56, Jagan Teki wrote: > > On Wed, Mar 29, 2023 at 10:16 PM Maxime Ripard wrote: > > > > On Wed, Mar 29, 2023 at 05:28:28PM +0100, Dave Stevenson wrote: > > > On Wed, 29 Mar 2023 at 14:19, Jagan Teki > > > wrote: > > > > > > > > DSI sink devices typically send

Re: [PATCH 4/6] drm/msm: Remove fbdev from struct msm_drm_private

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > The DRM device stores a pointer to the fbdev helper. Remove struct > msm_drm_private.fbdev, which contains the same value. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/msm/msm_debugfs.c | 5 ++---

Re: [PATCH 5/6] drm/msm: Initialize fbdev DRM client

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 10:41, Thomas Zimmermann wrote: > > Initialize the fbdev client in the fbdev code with empty helper > functions. Also clean up the client. The helpers will later > implement various functionality of the DRM client. No functional > changes. > > Signed-off-by: Thomas Zimmerman

[PATCH v1 0/2] drm/bridge: ti-sn65dsi83: Add DSI video mode configuration

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini SN65DSI8[34] device supports burst video mode and non-burst video mode with sync events or with sync pulses packet transmission as described in the DSI specification. Enable configuration of the DSI video mode instead of hard-coding MIPI_DSI_MODE_VIDEO_BURST. Francesco D

[PATCH v1 1/2] dt-bindings: display: bridge: sn65dsi83: Add DSI video mode

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini SN65DSI8[34] device supports burst video mode and non-burst video mode with sync events or with sync pulses packet transmission as described in the DSI specification. Add property to select the expected mode, this allows for example to select a mode that is compatible wit

[PATCH v1 2/2] drm/bridge: ti-sn65dsi83: Add DSI video mode configuration

2023-03-30 Thread Francesco Dolcini
From: Francesco Dolcini Enable configuration of the DSI video mode instead of hard-coding MIPI_DSI_MODE_VIDEO_BURST. The bridge support any of burst-mode, non-burst with sync event or non-burst with sync pulse With this change is possible to use the bridge with host DSI that do not support burst

Re: [PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.3-rc4] [cannot apply to next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [RFC][PATCH v2 1/3] drm: Introduce plane SIZE_HINTS property

2023-03-30 Thread Pekka Paalanen
On Tue, 21 Mar 2023 16:36:41 +0200 Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the DRM_CAP_CU

Re: [PATCH 6/6] drm/msm: Implement fbdev emulation as in-kernel client

2023-03-30 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.3-rc4] [cannot apply to next-20230330] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[PATCH v2 1/2] dt-bindings: display: bridge: ldb: Add i.MX6SX support

2023-03-30 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. Signed-off-by: Fabio Estevam --- Changes since v1: - Do not duplicate the entire if. (Krzysztof) .../devicetree/bindings/display/bridge/fsl,ldb.yaml | 5 - 1 f

[PATCH v2 2/2] drm/bridge: fsl-ldb: Add i.MX6SX support

2023-03-30 Thread Fabio Estevam
From: Fabio Estevam i.MX6SX has a single LVDS port and share a similar LDB_CTRL register layout with i.MX8MP and i.MX93. There is no LVDS CTRL register on the i.MX6SX, so only write to this register on the appropriate SoCs. Add support for the i.MX6SX LDB. Tested on a imx6sx-sdb board with a H

[PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-30 Thread Jani Nikula
is_power_of_2() only works for types <= sizeof(unsigned long) and it's also not a constant expression. There are a number of places in kernel where is_power_of_2() is called on u64, which fails on 32-bit builds. Try to remedy that. While at it, make it a constant expression when possible. I admit

[PATCH 2/4] log2: have is_power_of_2() support bigger types than unsigned long

2023-03-30 Thread Jani Nikula
is_power_of_2() does not work properly for e.g. u64 in 32-bit builds. Choose an unsigned long long version if the argument is bigger than unsigned long. Cc: Andrew Morton Cc: Christian König Cc: David Gow Link: https://lore.kernel.org/r/20230329065532.2122295-2-david...@google.com Signed-off-by

[PATCH 1/4] log2: add helper __IS_POWER_OF_2()

2023-03-30 Thread Jani Nikula
Add a helper to avoid duplication in the subsequent changes. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/log2.h b/include/linux/log2.h index 9f30d08

[PATCH 3/4] log2: allow use of is_power_of_2() in constant expressions

2023-03-30 Thread Jani Nikula
Even though the static inline functions are __attribute__((const)) you can't use them in constant expressions. Make is_power_of_2() a constant expression if possible. Cc: Andrew Morton Cc: Christian König Cc: David Gow Signed-off-by: Jani Nikula --- include/linux/log2.h | 8 +--- 1 file c

[PATCH 4/4] drm/i915/reg: use is_power_of_2() from log2.h

2023-03-30 Thread Jani Nikula
Now that log2.h is_power_of_2() supports constant expressions, use it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg_defs.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg_defs.h b/drivers/gpu/drm/i915/i915_reg_defs.h index

Re: [PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

2023-03-30 Thread Jani Nikula
On Wed, 29 Mar 2023, David Gow wrote: > The drm buddy allocator tests were broken on 32-bit systems, as > rounddown_pow_of_two() takes a long, and the buddy allocator handles > 64-bit sizes even on 32-bit systems. > > This can be reproduced with the drm_buddy_allocator KUnit tests on i386: >

Re: [PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

2023-03-30 Thread Christian König
Am 30.03.23 um 12:53 schrieb Jani Nikula: On Wed, 29 Mar 2023, David Gow wrote: The drm buddy allocator tests were broken on 32-bit systems, as rounddown_pow_of_two() takes a long, and the buddy allocator handles 64-bit sizes even on 32-bit systems. This can be reproduced with the drm_buddy_al

Re: [PATCH 0/4] log2: make is_power_of_2() more generic

2023-03-30 Thread Christian König
Am 30.03.23 um 12:42 schrieb Jani Nikula: is_power_of_2() only works for types <= sizeof(unsigned long) and it's also not a constant expression. There are a number of places in kernel where is_power_of_2() is called on u64, which fails on 32-bit builds. Try to remedy that. While at it, make it a

Re: [PATCH v30 0/7] Add MediaTek SoC DRM (vdosys1) support for mt8195

2023-03-30 Thread Chen-Yu Tsai
On Mon, Mar 27, 2023 at 11:17 PM Chun-Kuang Hu wrote: > > Hi, Angelo: > > AngeloGioacchino Del Regno 於 > 2023年3月24日 週五 下午4:38寫道: > > > > Il 24/03/23 00:25, Chun-Kuang Hu ha scritto: > > > Hi, Angelo: > > > > > > AngeloGioacchino Del Regno 於 > > > 2023年3月23日 週四 下午4:58寫道: > > >> > > >> Il 21/03/23

Re: [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 00:24, Dmitry Baryshkov wrote: > Konrad brought up the topic of scaling the MX domain according to the > OPP changes. Here is my RFC for this functionality. I post it as an RFC > for two reasons: > > 1) I'm not sure that we should scale MX if we are not scaling main > voltage foll

Re: [PATCH 1/2] dt-bindings: display: exynos: dsim: Add 'lane-polarities'

2023-03-30 Thread Fabio Estevam
Hi Jagan, On Thu, Mar 30, 2023 at 4:55 AM Jagan Teki wrote: > I have a previous iteration of this conversion. Can I resend it on top > of drm-misc-next? > https://lore.kernel.org/all/20210704090230.26489-9-ja...@amarulasolutions.com/ I tried applying your patch against linux-next, but I get the

Re: [PATCH 1/2] drm: buddy_allocator: Fix buddy allocator init on 32-bit systems

2023-03-30 Thread Jani Nikula
On Thu, 30 Mar 2023, Christian König wrote: > Am 30.03.23 um 12:53 schrieb Jani Nikula: >> On Wed, 29 Mar 2023, David Gow wrote: >>> The drm buddy allocator tests were broken on 32-bit systems, as >>> rounddown_pow_of_two() takes a long, and the buddy allocator handles >>> 64-bit sizes even on 32

Re: [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Dmitry Baryshkov
On 30/03/2023 14:06, Konrad Dybcio wrote: On 30.03.2023 00:24, Dmitry Baryshkov wrote: Konrad brought up the topic of scaling the MX domain according to the OPP changes. Here is my RFC for this functionality. I post it as an RFC for two reasons: 1) I'm not sure that we should scale MX if we a

Re: [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Konrad Dybcio
On 30.03.2023 13:15, Dmitry Baryshkov wrote: > On 30/03/2023 14:06, Konrad Dybcio wrote: >> >> >> On 30.03.2023 00:24, Dmitry Baryshkov wrote: >>> Konrad brought up the topic of scaling the MX domain according to the >>> OPP changes. Here is my RFC for this functionality. I post it as an RFC >>>

Re: [RFC PATCH 0/3] drm/msm/a5xx: scale MX following the frequency changes

2023-03-30 Thread Dmitry Baryshkov
On Thu, 30 Mar 2023 at 14:16, Konrad Dybcio wrote: > > > > On 30.03.2023 13:15, Dmitry Baryshkov wrote: > > On 30/03/2023 14:06, Konrad Dybcio wrote: > >> > >> > >> On 30.03.2023 00:24, Dmitry Baryshkov wrote: > >>> Konrad brought up the topic of scaling the MX domain according to the > >>> OPP ch

[PULL] drm-intel-fixes

2023-03-30 Thread Jani Nikula
Hi Dave & Daniel - drm-intel-fixes-2023-03-30: drm/i915 fixes for v6.3-rc5: - Fix PMU support by reusing functions with sysfs - Fix a number of issues related to color, PSR and arm/noarm - Fix state check related to ICL PHY ownership check in TC-cold state - Flush lmem contents after constructio

Re: [v2,19/50] drm/msm/dpu: split SM8450 catalog entry to the separate file

2023-03-30 Thread Konrad Dybcio
On 12.02.2023 00:12, Dmitry Baryshkov wrote: > Signed-off-by: Dmitry Baryshkov > --- > .../msm/disp/dpu1/catalog/dpu_8_1_sm8450.h| 203 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 204 +- > 2 files changed, 205 insertions(+), 202 deletions(-) > crea

  1   2   3   4   >