Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-28 Thread Neil Armstrong
On 28/03/2023 02:03, Inki Dae wrote: Hi, 2023년 3월 27일 (월) 오후 11:08, Neil Armstrong mailto:neil.armstr...@linaro.org>>님이 작성: On 23/03/2023 16:34, Fabio Estevam wrote: > Hi Inki, > > On Mon, Mar 13, 2023 at 9:51 PM Inki Dae mailto:daei...@gmail.com>> wrote: > >>> Coul

Re: [PATCH RESEND] drm/tests: Suballocator test

2023-03-28 Thread Thomas Hellström
Hi Michal, Thanks for the review, see comments inline, On 3/26/23 11:42, Michał Winiarski wrote: On Thu, Mar 02, 2023 at 09:34:22AM +0100, Thomas Hellström wrote: Add a suballocator test to get some test coverage for the new drm suballocator, and perform some basic timing (elapsed time). Sign

Re: [PATCH v8 2/2] drm: add kms driver for loongson display controller

2023-03-28 Thread Sui Jingfeng
Hi, Welcome review, comments and discussion, If there are issues in this driver, I will take the responsibility to resolve and revise  my driver. We are maintain three version of this drvier  at downstream world, target to linux-4.19.190, linux 5.4 kernel and linux 5.10 kernel respectively

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-03-28 Thread Lucas Stach
Hi Danilo, Am Dienstag, dem 28.03.2023 um 02:57 +0200 schrieb Danilo Krummrich: > Hi all, > > Commit df622729ddbf ("drm/scheduler: track GPU active time per entity") > tries to track the accumulated time that a job was active on the GPU > writing it to the entity through which the job was deplo

Re: [Intel-gfx] [PATCH] drm/i915/guc: Disable PL1 power limit when loading GuC firmware

2023-03-28 Thread Tvrtko Ursulin
On 27/03/2023 18:47, Rodrigo Vivi wrote: +Daniel On Mon, Mar 27, 2023 at 09:58:52AM -0700, Dixit, Ashutosh wrote: On Sun, 26 Mar 2023 04:52:59 -0700, Rodrigo Vivi wrote: Hi Rodrigo, On Fri, Mar 24, 2023 at 04:31:22PM -0700, Dixit, Ashutosh wrote: On Fri, 24 Mar 2023 11:15:02 -0700, Be

Re: [PATCH 27/34] drm/amdkfd: add debug set and clear address watch points operation

2023-03-28 Thread kernel test robot
Hi Jonathan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-exynos/exynos-drm-next drm-tip/drm-tip next-20230328] [cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes

Re: [PATCH v8 2/2] drm: add kms driver for loongson display controller

2023-03-28 Thread kernel test robot
Hi Sui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc4 next-20230328] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v8 2/2] drm: add kms driver for loongson display controller

2023-03-28 Thread Sui Jingfeng
I will fix them all. On 2023/3/28 17:27, kernel test robot wrote: Hi Sui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc4 next-20230328] [If your patch is applied to the wrong git tree,

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Fix MTL stolen memory GGTT mapping

2023-03-28 Thread Andi Shyti
Hi Daniele, On Mon, Mar 27, 2023 at 06:24:30PM -0700, Daniele Ceraolo Spurio wrote: > The PTEs expect the offset from the base of the fake LMEM region (i.e. > the base of stolen) and not from the base of the DSM. Quoting the specs: > "Driver will set the Device Memory bit = 1 in the PTE when point

Re: [PATCH 00/12] drm/amd: Remove unused variables

2023-03-28 Thread Jani Nikula
On Mon, 27 Mar 2023, Caio Novais wrote: > This patchset cleans the code removing unused variables and one unused > function. > > Caio Novais (12): > Remove unused variable 'r' > Remove unused variable 'value0' > Remove unused variable 'pixel_width' > Remove unused variable 'hubp' > Remov

Re: [Regression] drm/scheduler: track GPU active time per entity

2023-03-28 Thread Christian König
The same strategy was suggested before for amdgpu and reverted as well because of running into the same problems. No idea how that slipped, Andrew reviewed it and IIRC he was also the one who reverted the initial approach for amdgpu. Instead of letting the scheduler sum that stuff up proactiv

[PATCH 0/4] drm/i915: Convert fbdev to DRM client

2023-03-28 Thread Thomas Zimmermann
Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. As with most other driver's fbdev emulation, fbdev in i915 is now just another DRM client that runs after the DRM device has been registered. This allows to remove

[PATCH 1/4] drm/i915: Move fbdev functions

2023-03-28 Thread Thomas Zimmermann
Move functions within intel_fbdev.c to simplify later updates. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 154 ++--- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_fb

[PATCH 3/4] drm/i915: Implement fbdev client callbacks

2023-03-28 Thread Thomas Zimmermann
Move code from ad-hoc fbdev callbacks into DRM client functions and remove the old callbacks. The functions instruct the client to poll for changed output or restore the display. The DRM core calls both, the old callbacks and the new client helpers, from the same places. The new functions perform

[PATCH 4/4] drm/i915: Implement fbdev emulation as in-kernel client

2023-03-28 Thread Thomas Zimmermann
Replace all code that initializes or releases fbdev emulation throughout the driver. Instead initialize the fbdev client by a single call to i915_fbdev_setup() after i915 has registered its DRM device. Just like in most drivers, i915 fbdev emulation now acts like a regular DRM client. The fbdev cl

[PATCH 2/4] drm/i915: Initialize fbdev DRM client with callback functions

2023-03-28 Thread Thomas Zimmermann
Initialize i915's fbdev client by giving an instance of struct drm_client_funcsi to drm_client_init(). Also clean up with drm_client_release(). Doing this in i915 prevents fbdev helpers from initializing and releasing the client internally (see drm_fb_helper_init()). No functional change yet; the

Re: [PATCH] drm/i915/mtl: Fix MTL stolen memory GGTT mapping

2023-03-28 Thread Das, Nirmoy
On 3/28/2023 3:24 AM, Daniele Ceraolo Spurio wrote: The PTEs expect the offset from the base of the fake LMEM region (i.e. the base of stolen) and not from the base of the DSM. Quoting the specs: "Driver will set the Device Memory bit = 1 in the PTE when pointing to a page in DSM and program th

Re: [PATCH 02/10] Revert "drm/msm: Fix failure paths in msm_drm_init()"

2023-03-28 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: This reverts commit 8636500300a01740d92b345c680b036b94555b1b. A recent commit tried to address a drm device leak in the early msm_drm_uninit() error paths but ended up making things worse. Specifically, it moved the drm device reference put in msm_drm_un

Re: [PATCH 01/10] Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"

2023-03-28 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: This reverts commit 643b7d0869cc7f1f7a5ac7ca6bd25d88f54e31d0. A recent patch that tried to fix up the msm_drm_init() paths with respect to the workqueue but only ended up making things worse: First, the newly added calls to msm_drm_uninit() on early erro

Re: [PATCH 07/10] drm/msm: fix missing wq allocation error handling

2023-03-28 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: Add the missing sanity check to handle workqueue allocation failures. Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") Cc: sta...@vger.kernel.org # 3.12 Cc: Rob Clark Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c |

Re: [PATCH 08/10] drm/msm: fix workqueue leak on bind errors

2023-03-28 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: Make sure to destroy the workqueue also in case of early errors during bind (e.g. a subcomponent failing to bind). Since commit c3b790ea07a1 ("drm: Manage drm_mode_config_init with drmm_") the mode config will be freed when the drm device is released also

Re: [PATCH] drm/msm/dsi: simplify pixel clk rate handling

2023-03-28 Thread Dmitry Baryshkov
On 26/01/2023 02:07, Abhinav Kumar wrote: On 1/18/2023 5:00 AM, Dmitry Baryshkov wrote: Move a call to dsi_calc_pclk() out of calc_clk_rate directly towards msm_dsi_host_get_phy_clk_req(). It is called for both 6g and v2 hosts. Also, while we are at it, replace another dsi_get_pclk_rate() inv

Re: [PATCH 1/1] drm/i915: fix race condition UAF in i915_perf_add_config_ioctl

2023-03-28 Thread Tvrtko Ursulin
On 28/03/2023 10:36, Min Li wrote: Userspace can guess the id value and try to race oa_config object creation with config remove, resulting in a use-after-free if we dereference the object after unlocking the metrics_lock. For that reason, unlocking the metrics_lock must be done after we are d

RE: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-28 Thread Kandpal, Suraj
> -Original Message- > From: dri-devel On Behalf Of Jani > Nikula > Sent: Wednesday, March 8, 2023 5:00 PM > To: Kandpal, Suraj ; dri- > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Dmitry Baryshkov ; Nautiyal, Ankit K > ; Shankar, Uma ; > Kandpal, Suraj > Subject

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-03-28 Thread Dmitry Baryshkov
On Tue, 28 Mar 2023 at 16:20, Kandpal, Suraj wrote: > > -Original Message- > > From: dri-devel On Behalf Of Jani > > Nikula > > Sent: Wednesday, March 8, 2023 5:00 PM > > To: Kandpal, Suraj ; dri- > > de...@lists.freedesktop.org; intel-...@lists.freedesktop.org > > Cc: Dmitry Baryshkov ;

Re: [PATCH v7 31/32] drm/msm/dpu: log the multirect_index in _dpu_crtc_blend_setup_pipe

2023-03-28 Thread Dmitry Baryshkov
On 16/03/2023 18:16, Dmitry Baryshkov wrote: From: Abhinav Kumar Lets print the multirect_index as well in _dpu_crtc_blend_setup_pipe() as it will give the complete information of the sw_pipe as well. Signed-off-by: Abhinav Kumar For the sake of completeness: Reviewed-by: Dmitry Baryshkov

Re: [PATCH v7 32/32] drm/msm/dpu: remove unused dpu_plane_validate_multirect_v2 function

2023-03-28 Thread Dmitry Baryshkov
On 16/03/2023 18:16, Dmitry Baryshkov wrote: From: Abhinav Kumar After cleaning up the older multirect support the function dpu_plane_validate_multirect_v2() is unused. Lets remove it. Signed-off-by: Abhinav Kumar [DB: also drop struct dpu_multirect_plane_states and R0/R1/R_MAX] Signed-off-by

Re: [PATCH v10 07/15] dma-buf/sw_sync: Add fence deadline support

2023-03-28 Thread Tvrtko Ursulin
On 08/03/2023 15:52, Rob Clark wrote: From: Rob Clark This consists of simply storing the most recent deadline, and adding an ioctl to retrieve the deadline. This can be used in conjunction with the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various sw_sync fences, merge them

Re: [PATCH v10 09/15] drm/syncobj: Add deadline support for syncobj waits

2023-03-28 Thread Tvrtko Ursulin
On 08/03/2023 15:53, Rob Clark wrote: From: Rob Clark Add a new flag to let userspace provide a deadline as a hint for syncobj and timeline waits. This gives a hint to the driver signaling the backing fences about how soon userspace needs it to compete work, so it can addjust GPU frequency a

[PATCH v5 0/8] drm/i915: use ref_tracker library for tracking wakerefs

2023-03-28 Thread Andrzej Hajda
Gently ping for network developers, could you look at ref_tracker patches, as the ref_tracker library was developed for network. This is revived patchset improving ref_tracker library and converting i915 internal tracker to ref_tracker. The old thread ended without consensus about small kernel all

[PATCH v5 2/8] lib/ref_tracker: improve printing stats

2023-03-28 Thread Andrzej Hajda
In case the library is tracking busy subsystem, simply printing stack for every active reference will spam log with long, hard to read, redundant stack traces. To improve readabilty following changes have been made: - reports are printed per stack_handle - log is more compact, - added display name

[PATCH v5 4/8] lib/ref_tracker: remove warnings in case of allocation failure

2023-03-28 Thread Andrzej Hajda
Library can handle allocation failures. To avoid allocation warnings __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been replaced with GFP_NOWAIT in case of stack allocation on tracker free call. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- lib/ref_tracker.c | 5 +++

[PATCH v5 1/8] lib/ref_tracker: add unlocked leak print helper

2023-03-28 Thread Andrzej Hajda
To have reliable detection of leaks, caller must be able to check under the same lock both: tracked counter and the leaks. dir.lock is natural candidate for such lock and unlocked print helper can be called with this lock taken. As a bonus we can reuse this helper in ref_tracker_dir_exit. Signed-o

[PATCH v5 3/8] lib/ref_tracker: add printing to memory buffer

2023-03-28 Thread Andrzej Hajda
Similar to stack_(depot|trace)_snprint the patch adds helper to printing stats to memory buffer. It will be helpful in case of debugfs. Signed-off-by: Andrzej Hajda --- include/linux/ref_tracker.h | 8 +++ lib/ref_tracker.c | 56 ++--- 2 fil

[PATCH v5 6/8] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library

2023-03-28 Thread Andrzej Hajda
Beside reusing existing code, the main advantage of ref_tracker is tracking per instance of wakeref. It allows also to catch double put. On the other side we lose information about the first acquire and the last release, but the advantages outweigh it. Signed-off-by: Andrzej Hajda --- drivers/gp

[PATCH v5 5/8] drm/i915: Correct type of wakeref variable

2023-03-28 Thread Andrzej Hajda
Wakeref has dedicated type. Assumption it will be int compatible forever is incorrect. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_

[PATCH v5 7/8] drm/i915: track gt pm wakerefs

2023-03-28 Thread Andrzej Hajda
Track every intel_gt_pm_get() until its corresponding release in intel_gt_pm_put() by returning a cookie to the caller for acquire that must be passed by on released. When there is an imbalance, we can see who either tried to free a stale wakeref, or who forgot to free theirs. Signed-off-by: Andrz

[PATCH v5 8/8] drm/i915/gt: Hold a wakeref for the active VM

2023-03-28 Thread Andrzej Hajda
From: Chris Wilson There may be a disconnect between the GT used by the engine and the GT used for the VM, requiring us to hold a wakeref on both while the GPU is active with this request. Signed-off-by: Chris Wilson Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_context.h

Re: [PATCH v2 07/11] video/aperture: Disable and unregister sysfb devices via aperture helpers

2023-03-28 Thread Samuel Čavoj
On 2023-03-20 13:12, Javier Martinez Canillas wrote: Samuel Čavoj writes: [...] This call to sysfb_disable() has been causing trouble with regard to VFIO. VFIO has been calling aperture_remove_conflicting_pci_devices to get rid of any console drivers (d173780620792c) using the device in ques

RE: [PATCH 12/34] drm/amdgpu: add configurable grace period for unmap queues

2023-03-28 Thread Russell, Kent
[AMD Official Use Only - General] 3 tiny grammar/spelling things inline (not critical) Kent > -Original Message- > From: amd-gfx On Behalf Of > Jonathan Kim > Sent: Monday, March 27, 2023 2:43 PM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Kuehling, Felix

Re: [PATCH 2/4] drm/i915: Initialize fbdev DRM client with callback functions

2023-03-28 Thread Jani Nikula
On Tue, 28 Mar 2023, Thomas Zimmermann wrote: > Initialize i915's fbdev client by giving an instance of struct > drm_client_funcsi to drm_client_init(). Also clean up with > drm_client_release(). > > Doing this in i915 prevents fbdev helpers from initializing and > releasing the client internally

Re: [PATCH v8 2/2] drm: add kms driver for loongson display controller

2023-03-28 Thread Sui Jingfeng
HI, On 2023/3/28 17:27, kernel test robot wrote: Hi Sui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc4 next-20230328] [If your patch is applied to the wrong git tree, kindly drop us

Re: [PATCH] drm/mediatek: Add ovl_adaptor get format function

2023-03-28 Thread AngeloGioacchino Del Regno
Il 28/03/23 04:51, Nancy.Lin ha scritto: Add ovl_adaptor get_format and get_num_formats component function. The two functions are need for getting the supported format in mtk_plane_init(). Signed-off-by: Nancy.Lin Change-Id: Ia8e9f6cabcc71b262155a022b103ae81d1616b8f The code looks good to me,

Re: [PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-28 Thread Dmitry Baryshkov
On 25/03/2023 00:00, Rob Clark wrote: From: Rob Clark If userspace asked for a timeout greater than zero, but less than a jiffy, they clearly weren't planning on spinning. So it is better to round up to one. This fixes an issue with supertuxkart that was (for some reason) spinning on a gl syn

Re: [PATCH v4 12/14] drm/msm/a6xx: Use adreno_is_aXYZ macros in speedbin matching

2023-03-28 Thread Dmitry Baryshkov
On 14/03/2023 17:28, Konrad Dybcio wrote: Before transitioning to using per-SoC and not per-Adreno speedbin fuse values (need another patchset to land elsewhere), a good improvement/stopgap solution is to use adreno_is_aXYZ macros in place of explicit revision matching. Do so to allow differentia

Re: [PATCH v4 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-03-28 Thread Dmitry Baryshkov
On 14/03/2023 17:28, Konrad Dybcio wrote: A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just tha

Re: [PATCH 4/4] drm/i915: Implement fbdev emulation as in-kernel client

2023-03-28 Thread Jani Nikula
On Tue, 28 Mar 2023, Thomas Zimmermann wrote: > Replace all code that initializes or releases fbdev emulation > throughout the driver. Instead initialize the fbdev client by a > single call to i915_fbdev_setup() after i915 has registered its > DRM device. Just like in most drivers, i915 fbdev emul

Re: [PATCH v4 14/14] drm/msm/a6xx: Add A610 speedbin support

2023-03-28 Thread Dmitry Baryshkov
On 14/03/2023 17:28, Konrad Dybcio wrote: A610 is implemented on at least three SoCs: SM6115 (bengal), SM6125 (trinket) and SM6225 (khaje). Trinket does not support speed binning (only a single SKU exists) and we don't yet support khaje upstream. Hence, add a fuse mapping table for bengal to allo

Re: [PATCH v4 06/14] drm/msm/a6xx: Remove both GBIF and RBBM GBIF halt on hw init

2023-03-28 Thread Dmitry Baryshkov
On 14/03/2023 17:28, Konrad Dybcio wrote: Currently we're only deasserting REG_A6XX_RBBM_GBIF_HALT, but we also need REG_A6XX_GBIF_HALT to be set to 0. For GMU-equipped GPUs this is done in a6xx_bus_clear_pending_transactions(), but for the GMU-less ones we have to do it *somewhere*. Unhalting bo

RE: [PATCH 12/34] drm/amdgpu: add configurable grace period for unmap queues

2023-03-28 Thread Kim, Jonathan
[Public] Thanks for catch Kent. I'll fix up the typos with a follow-on. Jon > -Original Message- > From: Russell, Kent > Sent: Tuesday, March 28, 2023 11:19 AM > To: Kim, Jonathan ; amd-...@lists.freedesktop.org; > dri-devel@lists.freedesktop.org > Cc: Kuehling, Felix ; Kim, Jonathan >

Re: [PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 8:28 AM Dmitry Baryshkov wrote: > > On 25/03/2023 00:00, Rob Clark wrote: > > From: Rob Clark > > > > If userspace asked for a timeout greater than zero, but less than a > > jiffy, they clearly weren't planning on spinning. So it is better > > to round up to one. > > > >

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-28 Thread Teres Alexis, Alan Previn
On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote: > These two: > e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded") > b76c14c8fb2a ("drm/i915/huc: better define HuC status getparam possible > return values.") > They do not help here? It is not possible to use or exten

Re: [PATCH v8 2/2] drm: add kms driver for loongson display controller

2023-03-28 Thread Nathan Chancellor
] > > [also build test WARNING on linus/master v6.3-rc4 next-20230328] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_

[PATCH v2 2/2] drm/bridge: Document bridge init order with pre_enable_prev_first

2023-03-28 Thread Jagan Teki
In order to satisfy the MIPI DSI initialization sequence the bridge init order has been altered with the help of pre_enable_prev_first in pre_enable and post_disable bridge operations. Document the affected bridge init order with an example on the bridge operations helpers. Signed-off-by: Jagan T

[PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-03-28 Thread Jagan Teki
For a given bridge pipeline if any bridge sets pre_enable_prev_first flag then the pre_enable for the previous bridge will be called before pre_enable of this bridge and opposite is done for post_disable. These are the potential bridge flags to alter bridge init order in order to satisfy the MIPI

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-28 Thread Daniel Vetter
On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: > Hi Dave and Daniel, > > Here is the series for dma-fence deadline hint, without driver > specific patches, with the intent that it can be merged into drm-next > as well as -driver next trees to enable landing driver specific > support th

Re: [GIT PULL] exynos-drm-next

2023-03-28 Thread Daniel Vetter
On Tue, Mar 28, 2023 at 01:05:24PM +0900, Inki Dae wrote: > Hi Dave and Daniel, > >Just one patch series that moves the existing Exynos DSI driver >to drm/bridge directory to support both SoCs family - Exynos >and I.MX - because same Exynos MIPI DSI ip can be used by the two >diffe

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/pxp: Add ARB session creation and cleanup

2023-03-28 Thread Rodrigo Vivi
On Tue, Mar 28, 2023 at 05:01:36PM +, Teres Alexis, Alan Previn wrote: > On Mon, 2023-03-27 at 17:15 +0100, Tvrtko Ursulin wrote: > > These two: > > e6177ec586d1 ("drm/i915/huc: stall media submission until HuC is loaded") > > b76c14c8fb2a ("drm/i915/huc: better define HuC status getparam possi

Re: [PATCH 4/4] dt-bindings: display: sitronix, st7701: document port and rotation

2023-03-28 Thread Jagan Teki
On Mon, Mar 27, 2023 at 2:12 AM Krzysztof Kozlowski wrote: > > Panels are supposed to have one port (defined in panel-common.yaml > binding) and can have also rotation: > > rk3326-odroid-go3.dtb: panel@0: 'port', 'rotation' do not match any of the > regexes: 'pinctrl-[0-9]+' > > Signed-off-by:

Re: [PATCH 2/4] dt-bindings: display: feiyang,fy07024di26a30d: document port

2023-03-28 Thread Jagan Teki
On Mon, Mar 27, 2023 at 2:12 AM Krzysztof Kozlowski wrote: > > Panels are supposed to have one port (defined in panel-common.yaml > binding): > > rk3399-rockpro64.dtb: panel@0: 'port' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-b

Re: [PATCH 1/4] dt-bindings: display: xinpeng, xpp055c272: document port

2023-03-28 Thread Jagan Teki
On Mon, Mar 27, 2023 at 2:12 AM Krzysztof Kozlowski wrote: > > Panels are supposed to have one port (defined in panel-common.yaml > binding): > > px30-evb.dtb: panel@0: 'port' does not match any of the regexes: > 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Jagan

Re: [PATCH 3/4] dt-bindings: display: elida,kd35t133: document port and rotation

2023-03-28 Thread Jagan Teki
On Mon, Mar 27, 2023 at 2:12 AM Krzysztof Kozlowski wrote: > > Panels are supposed to have one port (defined in panel-common.yaml > binding) and can have also rotation: > > rk3326-odroid-go2.dtb: panel@0: 'port', 'rotation' do not match any of the > regexes: 'pinctrl-[0-9]+' > > Signed-off-by:

Re: Linux 6.3-rc3

2023-03-28 Thread Nathan Chancellor
On Fri, Mar 24, 2023 at 05:23:12PM +0200, Kalle Valo wrote: > Nathan Chancellor writes: > > >> This is nitpicking but it would be nice if the tarball contents wouldn't > >> conflict with each other. Now both llvm-16.0.0-aarch64.tar.gz and > >> llvm-16.0.0-x86_64.tar extract to the same directory

Re: [PATCH] drm/sun4i: uncouple DSI dotclock divider from TCON0_DCLK_REG

2023-03-28 Thread Frank Oltmanns
Hi, On 2023-03-27 at 22:20:45 +0200, Maxime Ripard wrote: > Hi, > > On Sat, Mar 25, 2023 at 12:40:04PM +0100, Frank Oltmanns wrote: [...] >> Actually, I had the following third patch prepared that adjusted the >> dotclock rate so that the >> required PLL rate is set. But again, this seems very

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement fbdev emulation as in-kernel client

2023-03-28 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 6e5f96153989e454041848f66a5227be9bd0bbc3] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-i915-Move-fbdev-functions/20230328-191627 base: 6e5f96153989e454041848f66a5227be9bd0bbc3

Re: [Intel-gfx] [PATCH 1/1] drm/i915: fix race condition UAF in i915_perf_add_config_ioctl

2023-03-28 Thread Andi Shyti
Hi Min, On Tue, Mar 28, 2023 at 05:36:27PM +0800, Min Li wrote: > Userspace can guess the id value and try to race oa_config object creation > with config remove, resulting in a use-after-free if we dereference the > object after unlocking the metrics_lock. For that reason, unlocking the > metric

Re: [Intel-gfx] [PATCH 1/1] drm/i915: fix race condition UAF in i915_perf_add_config_ioctl

2023-03-28 Thread Andi Shyti
On Tue, Mar 28, 2023 at 05:36:27PM +0800, Min Li wrote: > Userspace can guess the id value and try to race oa_config object creation > with config remove, resulting in a use-after-free if we dereference the > object after unlocking the metrics_lock. For that reason, unlocking the > metrics_lock mu

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 10:19 AM Daniel Vetter wrote: > > On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: > > Hi Dave and Daniel, > > > > Here is the series for dma-fence deadline hint, without driver > > specific patches, with the intent that it can be merged into drm-next > > as well

[PATCH 1/2] drm/amd/display: Remove unused variable 'scl_enable'

2023-03-28 Thread Caio Novais
Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c: In function ‘dml_rq_dlg_get_dlg_params’: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_rq_dlg_calc_314.c:991:14: warning: variable ‘scl_enable’ set but not u

[PATCH 0/2] drm/amd/display: Remove a unused variable and add a function prototype

2023-03-28 Thread Caio Novais
This patchset removes one unused variable and adds a function prototype. Caio Novais (2): drm/amd/display: Remove unused variable 'scl_enable' drm/amd/display: Add previous prototype to 'optc3_wait_drr_doublebuffer_pending_clear' drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h

[PATCH 2/2] drm/amd/display: Add previous prototype to 'optc3_wait_drr_doublebuffer_pending_clear'

2023-03-28 Thread Caio Novais
Compiling AMD GPU drivers displays a warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes] Get rid of it by adding a function prototype 'optc3_wait_drr_doublebuffer_pendi

Re: [PATCH 6.2 regression fix] drm/nouveau/kms: Fix backlight registration

2023-03-28 Thread Lyude Paul
Reviewed-by: Lyude Paul (Also note to Mark: this is my way of letting you know someone fixed the regression with backlight controls upstream, looking into the weird bright screen after resume issue) On Sun, 2023-03-26 at 22:54 +0200, Hans de Goede wrote: > The nouveau code used to call drm_fb_he

[pull] drm: dma-fence-deadline for v6.4

2023-03-28 Thread Rob Clark
Hi Dave and Daniel, Here is the series for dma-fence deadline hint, without driver specific patches, or UAPI, with the intent that it can be merged into drm-next as well as -driver next trees to enable landing driver specific support through their corresponding -next trees. The following changes

Re: [PATCH][next] drm/msm/dp: Fix spelling mistake "Capabiity" -> "Capability"

2023-03-28 Thread Dmitry Baryshkov
On Tue, 14 Mar 2023 08:20:50 +, Colin Ian King wrote: > There is a spelling mistake in a drm_dbg_dp message. Fix it. > > Applied, thanks! [1/1] drm/msm/dp: Fix spelling mistake "Capabiity" -> "Capability" https://gitlab.freedesktop.org/lumag/msm/-/commit/6ee9666a4f4c Best regards,

Re: [PATCH v2 1/2] drm/msm/dp: Clean up handling of DP AUX interrupts

2023-03-28 Thread Dmitry Baryshkov
On Thu, 26 Jan 2023 17:09:12 -0800, Douglas Anderson wrote: > The DP AUX interrupt handling was a bit of a mess. > * There were two functions (one for "native" transfers and one for > "i2c" transfers) that were quite similar. It was hard to say how > many of the differences between the two fu

Re: [PATCH v2 0/3] drm/msm/mdss: rework UBWC setup

2023-03-28 Thread Dmitry Baryshkov
On Wed, 18 Jan 2023 03:04:25 +0200, Dmitry Baryshkov wrote: > The commit 92bab9142456 ("drm/msm: less magic numbers in > msm_mdss_enable") reworked the static UBWC setup to replace magic > numbers with calulating written values from the SoC/device parameters. > This simplified adding new platform

Re: [v12] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2023-03-28 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 02:14:47 -0800, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This chang

Re: [PATCH v7 00/32] drm/msm/dpu: wide planes support

2023-03-28 Thread Dmitry Baryshkov
On Thu, 16 Mar 2023 19:16:21 +0300, Dmitry Baryshkov wrote: > This patchset brings in multirect usage to support using two SSPP > rectangles for a single plane. Full virtual planes support is omitted > from this pull request, it will come later (I'm at the final stages of > polishing and testing,

Re: [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-03-28 Thread Dmitry Baryshkov
On Fri, 17 Mar 2023 16:06:31 +0100, Neil Armstrong wrote: > Switch the QMP PHY to the newly documented USB3/DP Combo PHY > bindings at [1] and add the DP controller nodes. > > The DP output is shared with the USB3 SuperSpeed lanes and is > usually connected to an USB-C port which Altmode is cont

Re: [PATCH 00/10] drm/msm: fix bind error handling

2023-03-28 Thread Dmitry Baryshkov
On Mon, 06 Mar 2023 11:07:12 +0100, Johan Hovold wrote: > I had reasons to look closer at the MSM DRM driver error handling and > realised that it had suffered from a fair amount of bit rot over the > years. > > Unfortunately, I started fixing this in my 6.2 branch and failed to > notice two par

Re: [PATCH v6 0/9] Fix DSI host idx detection on HW revision clash

2023-03-28 Thread Dmitry Baryshkov
On Sat, 18 Mar 2023 14:42:46 +0100, Konrad Dybcio wrote: > v5 -> v6: > - Squash both fixes that concerned the deprecated QCM2290 compatible to > avoid warnings > > v5: > https://lore.kernel.org/r/20230307-topic-dsi_qcm-v5-0-9d4235b77...@linaro.org > > v4 -> v5: > - Drop superfluous items: le

Re: [PATCH 1/2] drm/lima: Use drm_sched_job_add_syncobj_dependency()

2023-03-28 Thread Dmitry Baryshkov
On Fri, 24 Feb 2023 18:41:32 -0300, Maíra Canal wrote: > As lima_gem_add_deps() performs the same steps as > drm_sched_job_add_syncobj_dependency(), replace the open-coded > implementation in Lima in order to simply use the DRM function. > > Applied, thanks! [2/2] drm/msm: Use drm_sched_job_a

Re: [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-28 Thread Dmitry Baryshkov
On Fri, 24 Mar 2023 10:28:45 +0100, Neil Armstrong wrote: > A few fixes to pass the DT bindings check successfully > for sm8450 qrd & hdk DTs. > > The following are still needed to pass all the checks: > - > https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasi...@linaro.org > -

Re: [PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-28 Thread Dmitry Baryshkov
On Mon, 06 Mar 2023 10:06:33 +0100, Geert Uytterhoeven wrote: > With gcc-5 and CONFIG_UBSAN_SHIFT=y: > > drivers/gpu/drm/msm/msm_mdss.c: In function 'msm_mdss_enable': > drivers/gpu/drm/msm/msm_mdss.c:296:2: error: case label does not reduce > to an integer constant > case DPU_HW_

Re: [PATCH v3 0/7] drm/msm: add support for SM8550

2023-03-28 Thread Dmitry Baryshkov
On Mon, 09 Jan 2023 11:15:17 +0100, Neil Armstrong wrote: > This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. > > This patchset is based on the SM8450 display support serie at [1]. > > In order to work, the following patchsets are required: > - PM8550 LDO fix at [2] > - DI

Re: [PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-28 Thread Dmitry Baryshkov
On Fri, 24 Mar 2023 15:00:13 -0700, Rob Clark wrote: > If userspace asked for a timeout greater than zero, but less than a > jiffy, they clearly weren't planning on spinning. So it is better > to round up to one. > > This fixes an issue with supertuxkart that was (for some reason) > spinning on

Re: [RFC PATCH v3 0/4] Move TE setup to prepare_for_kickoff()

2023-03-28 Thread Dmitry Baryshkov
On Mon, 13 Feb 2023 11:48:15 -0800, Jessica Zhang wrote: > Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() > functions in both MDP4 and DPU drivers. > > Changes in V2: > - Added changes to remove empty prepare_commit() functions > > Changes in V3: > - Reordered "drm/msm

Re: [PATCH v4 0/4] Move TE setup to prepare_for_kickoff()

2023-03-28 Thread Dmitry Baryshkov
On Tue, 21 Feb 2023 10:42:52 -0800, Jessica Zhang wrote: > Move TE setup to prepare_for_kickoff() and remove empty prepare_commit() > functions in both MDP4 and DPU drivers. > > Changes in V2: > - Added changes to remove empty prepare_commit() functions > > Changes in V3: > - Reordered "drm/msm

Re: [PATCH] drm/msm: Rename drm_msm_gem_submit_reloc::or in C++ code

2023-03-28 Thread Dmitry Baryshkov
On Sun, 26 Mar 2023 09:38:13 -0700, Rob Clark wrote: > Clashes with C++ `or` keyword > > Applied, thanks! [1/1] drm/msm: Rename drm_msm_gem_submit_reloc::or in C++ code https://gitlab.freedesktop.org/lumag/msm/-/commit/be7772e53681 Best regards, -- Dmitry Baryshkov

Re: [pull] drm: dma-fence-deadline-core for v6.4

2023-03-28 Thread Rob Clark
On Tue, Mar 28, 2023 at 10:19 AM Daniel Vetter wrote: > > On Sat, Mar 25, 2023 at 11:24:56AM -0700, Rob Clark wrote: > > Hi Dave and Daniel, > > > > Here is the series for dma-fence deadline hint, without driver > > specific patches, with the intent that it can be merged into drm-next > > as well

linux-next: manual merge of the drm-msm tree with the drm-misc tree

2023-03-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: drivers/gpu/drm/msm/adreno/adreno_gpu.c between commit: 7fa5047a436b ("drm: Use of_property_present() for testing DT property presence") from the drm-misc tree and commit: 9f251f934012 ("drm/msm/adreno: Use OPP for

Re: [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-28 Thread Randy Dunlap
On 3/24/23 02:54, Arnd Bergmann wrote: > From: Arnd Bergmann > > Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM > is not enabled: > > WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS > Depends on [n]: PM [=n] > Selected by [m]: > - DRM_MSM [=

RE: [PATCH 3/3] drm/xe: Update GuC/HuC firmware autoselect logic

2023-03-28 Thread Srivatsa, Anusha
> -Original Message- > From: De Marchi, Lucas > Sent: Thursday, March 23, 2023 10:18 PM > To: intel...@lists.freedesktop.org > Cc: Srivatsa, Anusha ; Harrison, John C > ; Ceraolo Spurio, Daniele > ; dri-devel@lists.freedesktop.org; Daniel > Vetter ; Dave Airlie ; De Marchi, > Lucas > S

[PATCH] drm/i915/hwmon: Use 0 to designate disabled PL1 power limit

2023-03-28 Thread Ashutosh Dixit
On ATSM the PL1 limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when the PL1 limit is disabled. For example at power up, the disabled ATSM PL1 limit

[PATCH v3 01/10] drm/i915/dsc: change DSC param tables to follow the DSC model

2023-03-28 Thread Dmitry Baryshkov
After cross-checking DSC models (20150914, 20161212, 20210623) change values in rc_parameters tables to follow config files present inside the DSC model. Handle two places, where i915 tables diverged from the model, by patching the rc values in the code. Note: I left one case uncorrected, 8bpp/10b

[PATCH v3 00/10] drm/i915: move DSC RC tables to drm_dsc_helper.c

2023-03-28 Thread Dmitry Baryshkov
Other platforms (msm) will benefit from sharing the DSC config setup functions. This series moves parts of static DSC config data from the i915 driver to the common helpers to be used by other drivers. Note: the RC parameters were cross-checked against config files found in DSC model 2021062, 2016

[PATCH v3 02/10] drm/i915/dsc: move rc_buf_thresh values to common helper

2023-03-28 Thread Dmitry Baryshkov
The rc_buf_thresh values are common to all DSC implementations. Move them to the common helper together with the code to propagage them to the drm_dsc_config. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 35 +++ dri

[PATCH v3 04/10] drm/i915/dsc: stop using interim structure for calculated params

2023-03-28 Thread Dmitry Baryshkov
Stop using an interim structure rc_parameters for storing calculated params and then setting drm_dsc_config using that structure. Instead put calculated params into the struct drm_dsc_config directly. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/i915/display/inte

[PATCH v3 07/10] drm/display/dsc: include the rest of pre-SCR parameters

2023-03-28 Thread Dmitry Baryshkov
DSC model contains pre-SCR RC parameters for other bpp/bpc combinations, include them here for completeness. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 72 1 file changed, 72 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dsc_

[PATCH v3 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper

2023-03-28 Thread Dmitry Baryshkov
Move DSC RC tables to DRM DSC helper. No additional code changes and/or cleanups are a part of this commit, it will be cleaned up in the followup commits. Reviewed-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dsc_helper.c | 372 ++ drivers

  1   2   >