Regression in deaeeda2051f ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")

2023-03-22 Thread Uwe Kleine-König
Hello, hmm, the subject is wrong, this is about commit deaeeda2051f ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state") and not 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle"). I fixed it accordingly. On Wed, Mar 22, 2023 at 05:13:24AM +

Re: [v2,6/8] drm/fbdev-generic: Clean up after failed probing

2023-03-22 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/3/20 23:07, Thomas Zimmermann wrote: Clean up fbdev and client state if the probe function fails. It used to leak allocated resources. Also reorder the individual steps to simplify cleanup. v2: * move screen_size update into separate patches Signed-off-

Re: [v2, 5/8] drm/fbdev-generic: Set screen size to size of GEM buffer

2023-03-22 Thread Sui Jingfeng
Tested-by: Sui Jingfeng On 2023/3/20 23:07, Thomas Zimmermann wrote: The size of the screen memory should be equivalent to the size of the screen's GEM buffer. Don't recalculate the value. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fbdev_

Re: [v2,4/8] drm/fb-helper: Support smem_len in deferred I/O

2023-03-22 Thread Sui Jingfeng
Yet, better to clarify which one should be used, not two. Tested-by: Sui Jingfeng On 2023/3/20 23:07, Thomas Zimmermann wrote: The size of the framebuffer can either be stored in screen_info or smem_len. Take both into account in the deferred I/O code. Signed-off-by: Thomas Zimmermann Revie

Re: [PATCH] dt-bindings: display: msm: sm8350-mdss: Fix DSI compatible

2023-03-22 Thread Krzysztof Kozlowski
On 21/03/2023 22:35, Konrad Dybcio wrote: > The DSI compatible changed between patchset revisions, but that wasn't > reflected in the bindings. Fix it. > > Fixes: 430e11f42bff ("dt-bindings: display: msm: Add qcom, sm8350-mdss > binding") > Signed-off-by: Konrad Dybcio > --- Acked-by: Krzyszto

Re: [PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-22 Thread Johan Hovold
On Tue, Mar 21, 2023 at 04:54:51PM +0200, Dmitry Baryshkov wrote: > On 06/03/2023 12:07, Johan Hovold wrote: > > Make sure to free the DRM device also in case of early errors during > > bind(). > > > > Fixes: 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time") > > Cc: sta...@vger.ke

Re: [PATCH v4 8/8] MAINTAINERS: Add entry for QAIC driver

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 20.03.2023 16:11, Jeffrey Hugo wrote: > Add MAINTAINERS entry for the Qualcomm Cloud AI 100 driver. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Carl Vanderlip > Reviewed-by: Pranjal Ramajor Asha Kanojiya > Reviewed-by: Stanislaw Gruszka > --- > MAINTAINE

Re: [PATCH v4 3/8] accel/qaic: Add MHI controller

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 20.03.2023 16:11, Jeffrey Hugo wrote: > An AIC100 device contains a MHI interface with a number of different > channels for controlling different aspects of the device. The MHI > controller works with the MHI bus to enable and drive that interface. > > AIC100 us

Re: [PATCH v4 4/8] accel/qaic: Add control path

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 20.03.2023 16:11, Jeffrey Hugo wrote: > Add the control path component that talks to the management processor (QSM) > to load workloads onto the AIC100 device. This implements the KMD portion > of the NNC protocol over the QAIC_CONTROL MHI channel and the > DRM_I

Re: [PATCH v4 5/8] accel/qaic: Add datapath

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 20.03.2023 16:11, Jeffrey Hugo wrote: > Add the datapath component that manages BOs and submits them to running > workloads on the qaic device via the dma_bridge hardware. This allows > QAIC clients to interact with their workloads (run inferences) via the > foll

Re: [PATCH 00/10] drm/msm: fix bind error handling

2023-03-22 Thread Johan Hovold
On Tue, Mar 21, 2023 at 05:21:56PM +0200, Dmitry Baryshkov wrote: > On 21/03/2023 15:02, Johan Hovold wrote: > > On Mon, Mar 06, 2023 at 11:07:12AM +0100, Johan Hovold wrote: > >> I had reasons to look closer at the MSM DRM driver error handling and > >> realised that it had suffered from a fair am

Re: [PATCH v4 7/8] accel/qaic: Add qaic driver to the build system

2023-03-22 Thread Jacek Lawrynowicz
Hi, On 20.03.2023 16:11, Jeffrey Hugo wrote: > Now that we have all the components of a minimum QAIC which can boot and > run an AIC100 device, add the infrastructure that allows the QAIC driver > to be built. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Carl Vanderlip > Reviewed-by: Pranjal

Re: [PATCH v4 2/8] accel/qaic: Add uapi and core driver file

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 20.03.2023 16:11, Jeffrey Hugo wrote: > Add the QAIC driver uapi file and core driver file that binds to the PCIe > device. The core driver file also creates the accel device and manages > all the interconnections between the different parts of the driver. > > T

Re: [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl

2023-03-22 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz Hi, On 20.03.2023 20:06, Jeffrey Hugo wrote: > On 3/20/2023 9:11 AM, Jeffrey Hugo wrote: >> From: Pranjal Ramajor Asha Kanojiya >> >> Some of the MHI channels for an AIC100 device need to be routed to >> userspace so that userspace can communicate directly with QS

[PATCH] drm/bochs: replace ioremap with devm_ioremap to avoid immo leak

2023-03-22 Thread Gencen Gan
From: Gan Gecen Smatch reports: drivers/gpu/drm/tiny/bochs.c:290 bochs_hw_init() warn: 'bochs->mmio' from ioremap() not released on lines: 246,250,254. In the function bochs_load() that calls bochs_hw_init() only, if bochs_hw_init(dev) returns -ENODEV(-19), it will jumps

RE: Regression in deaeeda2051f ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state")

2023-03-22 Thread Aisheng Dong
Hi Uwe, > From: Uwe Kleine-König > Sent: 2023年3月22日 15:04 > > Hello, > > hmm, the subject is wrong, this is about commit deaeeda2051f > ("backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive > state") and not 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > per backlight

Re: [syzbot] [dri?] BUG: sleeping function called from invalid context in _vm_unmap_aliases

2023-03-22 Thread Tetsuo Handa
Commit c53e98934f93 ("mm: vmalloc: use rwsem, mutex for vmap_area_lock and vmap_block->lock") is broken. We can't take mutex (a sleeping lock) inside RCU read section (an atomic context). @@ -2183,7 +2184,7 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush)

Re: [PATCH v2 1/2] backlight: pwm_bl: Configure pwm only once per backlight toggle

2023-03-22 Thread Aisheng Dong
On Fri, Jan 20, 2023 at 01:00:18PM +0100, Uwe Kleine-König wrote: > Most but not all PWMs drive the PWM pin to its inactive state when > disabled. However if there is no enable_gpio and no regulator the PWM > must drive the inactive state to actually disable the backlight. > > So keep the PWM on in

Re: [PATCH 1/2] dt-bindings: drm/bridge: Add no-hpd property

2023-03-22 Thread Jayesh Choudhary
Hello Krzysztof, On 17/03/23 18:08, Krzysztof Kozlowski wrote: On 16/03/2023 15:08, Jayesh Choudhary wrote: From: Rahul T R Add no-hpd property to the bindings, to disable hpd when not connected or unusable Signed-off-by: Rahul T R Signed-off-by: Jayesh Choudhary --- .../devicetree/bindi

Re: [PATCH 1/2] dt-bindings: drm/bridge: Add no-hpd property

2023-03-22 Thread Jayesh Choudhary
On 21/03/23 18:08, Krzysztof Kozlowski wrote: On 21/03/2023 13:02, Jayesh Choudhary wrote: +type: boolean +description: + Set if the HPD line on the bridge isn't hooked up to anything or is + otherwise unusable. It's the property of the panel, not bridge. Unless you want

[PATCH] drm/bridge: display-connector: Use dev_err_probe()

2023-03-22 Thread ye.xingchen
From: Ye Xingchen Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen --- drivers/gpu/drm/bridge/display-connector.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/dr

[PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

2023-03-22 Thread ye.xingchen
From: Ye Xingchen Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen --- drivers/gpu/drm/bridge/simple-bridge.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/

[PATCH] drm/tegra: dpaux: Use dev_err_probe()

2023-03-22 Thread ye.xingchen
From: Ye Xingchen Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen --- drivers/gpu/drm/tegra/dpaux.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index 3c

[PATCH] drm: xlnx: zynqmp: Use dev_err_probe()

2023-03-22 Thread ye.xingchen
From: Ye Xingchen Replace the open-code with dev_err_probe() to simplify the code. Signed-off-by: Ye Xingchen --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index

[PATCH v6 0/2] Add pixel formats used in Synatpics SoC

2023-03-22 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" Those pixel formats are used in Synaptics's VideoSmart series SoCs, likes VS640, VS680. I just disclose the pixel formats used in the video codecs and display pipeline this time. Actually any device connected to the MTR module could support those tiling and compressed p

[PATCH v6 1/2] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2023-03-22 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" Those modifiers only record the parameters would effort pixel layout or memory layout. Whether physical memory page mapping is used is not a part of format. Signed-off-by: Hsia-Jun(Randy) Li --- include/uapi/drm/drm_fourcc.h | 75 +++

[PATCH v6 2/2] Documentation/gpu: Add Synaptics tiling formats documentation

2023-03-22 Thread Hsia-Jun Li
From: Randy Li Signed-off-by: Randy Li Signed-off-by: Hsia-Jun(Randy) Li --- Documentation/gpu/synaptics.rst | 81 + 1 file changed, 81 insertions(+) create mode 100644 Documentation/gpu/synaptics.rst diff --git a/Documentation/gpu/synaptics.rst b/Documentatio

Re: [PATCH] drm/bridge: display-connector: Use dev_err_probe()

2023-03-22 Thread Laurent Pinchart
Hi Ye, Thank you for the patch. On Wed, Mar 22, 2023 at 04:21:33PM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/disp

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Sanitycheck MMIO access early in driver load

2023-03-22 Thread Andrzej Hajda
On 21.03.2023 23:43, Andi Shyti wrote: Hi Matt, We occasionally see the PCI device in a non-accessible state at the point the driver is loaded. When this happens, all BAR accesses will read back as 0x. Rather than reading registers and misinterpreting their (invalid) values, let's spe

Re: [Intel-gfx] [PATCH] drm/i915: Use i915 instead of dev_priv insied the file_priv structure

2023-03-22 Thread Andrzej Hajda
On 22.03.2023 01:16, Andi Shyti wrote: In the process of renaming all instances of 'dev_priv' to 'i915', start using 'i915' within the 'drm_i915_file_private' structure. Signed-off-by: Andi Shyti Apparently the last struct member with this name, R.I.P. Reviewed-by: Andrzej Hajda Regards An

Re: [PATCH] drm: xlnx: zynqmp: Use dev_err_probe()

2023-03-22 Thread Laurent Pinchart
Hi Ye, Thank you for the patch. On Wed, Mar 22, 2023 at 04:25:25PM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen > --- > drivers/gpu/drm/xlnx/zynqmp_dp.c | 6 ++ > 1 file change

[PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state")

2023-03-22 Thread Uwe Kleine-König
Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") calling pwm_backlight_power_off() doesn't disable the PWM any more. However this is necessary to suspend, because PWM drivers usually refuse to suspend if they are still enabled. Also adapt shutdown to di

[PATCH] drm/qxl: prevent memory leak

2023-03-22 Thread Zongmin Zhou
The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl resume, it will cause memory leak. Signed-off-by: Zongmin Zhou --- drivers/gpu/dr

[PATCH v5 0/8] Support ROHM BU27034 ALS sensor

2023-03-22 Thread Matti Vaittinen
Support ROHM BU27034 ALS sensor This series adds support for ROHM BU27034 Ambient Light Sensor. The BU27034 has configurable gain and measurement (integration) time settings. Both of these have inversely proportional relation to the sensor's intensity channel scale. Many users only set the scale

[bug report] drm/vmwgfx: Do not drop the reference to the handle too soon

2023-03-22 Thread Dan Carpenter
Hello Zack Rusin, The patch 9ef8d83e8e25: "drm/vmwgfx: Do not drop the reference to the handle too soon" from Feb 11, 2023, leads to the following Smatch static checker warning: drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:698 vmw_dumb_create() error: uninitialized symbol 'vbo'. drivers/gp

Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

2023-03-22 Thread Laurent Pinchart
Hi Ye, Thank you for the patch. On Wed, Mar 22, 2023 at 04:22:51PM +0800, ye.xingc...@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/simp

[PATCH v5 2/8] drm/tests: helpers: Use generic helpers

2023-03-22 Thread Matti Vaittinen
Replace DRM specific managed device creation test-helpers with generic ones. Signed-off-by: Matti Vaittinen --- v4 => v5: - do not rename + move helpers from DRM but add temporary dublicates to simplify merging. This patch depends on interface added at patch 1/8. --- drivers/gpu/drm/Kconfig

[PATCH] drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

2023-03-22 Thread Dan Carpenter
The devm_drm_dev_alloc() function returns error pointers. It never returns NULL. Fix the check. Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/imx/lcdc/imx-lcdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH] drm/panel: magnachip: Prevent error pointer dereference in probe

2023-03-22 Thread Dan Carpenter
Don't dereference "db->dsi_dev" when it is an error pointer. Fixes: 249a4f5e663c ("drm/panel: Add Magnachip D53E6EA8966 Panel Driver") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/panel/panel-magnachip-d53e6ea8966.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Check for unreliable MMIO during forcewake

2023-03-22 Thread Andrzej Hajda
On 21.03.2023 18:09, Andi Shyti wrote: From: Matt Roper Although we now sanitycheck MMIO access during driver load to make sure the MMIO BAR isn't returning all 0x, there have been a few cases where (temporarily?) unreliable MMIO access has happened after GPU resets or power events. We

Re: [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture

2023-03-22 Thread Luca Ceresoli
Hello, On Thu, 9 Mar 2023 15:42:59 +0100 Luca Ceresoli wrote: > TL;DR: Resending this series with Rob's review tag added. Now all DT > patches have at least a reviewed-by tag from Rob or Krzysztof, all the > driver patches have one from Dmitry. This is a gentle ping about this series. All patc

RE: [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state")

2023-03-22 Thread Aisheng Dong
> From: Uwe Kleine-König > Sent: 2023年3月22日 16:51 > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > per backlight toggle") calling pwm_backlight_power_off() doesn't disable the > PWM any more. However this is necessary to suspend, because PWM drivers > usually refuse to

Re: [PATCH] drm/imx/lcdc: fix a NULL vs IS_ERR() bug in probe

2023-03-22 Thread Uwe Kleine-König
On Wed, Mar 22, 2023 at 12:06:55PM +0300, Dan Carpenter wrote: > The devm_drm_dev_alloc() function returns error pointers. It never > returns NULL. Fix the check. > > Fixes: c87e859cdeb5 ("drm/imx/lcdc: Implement DRM driver for imx25") > Signed-off-by: Dan Carpenter Reviewed-by: Uwe Kleine-Kön

[PATCH 0/7] acell/ivpu: Fixes for 6.3

2023-03-22 Thread Stanislaw Gruszka
Various fixes intended for linux 6.3 relase. Patch 6 is dependency for patch 7. Stanislaw Gruszka (7): accel/ivpu: Do not access HW registers after unbind accel/ivpu: Cancel recovery work accel/ivpu: Do not use SSID 1 accel/ivpu: Fix power down sequence accel/ivpu: Disable buttress on d

[PATCH 1/7] accel/ivpu: Do not access HW registers after unbind

2023-03-22 Thread Stanislaw Gruszka
We should not access hardware after we unbind from the bus. Use drm_dev_enter() / drm_dev_exit() to mark code sections where hardware is accessed (and not already protected by other locks) and drm_dev_unplug() to mark device is gone. Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_

[PATCH 2/7] accel/ivpu: Cancel recovery work

2023-03-22 Thread Stanislaw Gruszka
Prevent running recovery_work after device is removed. Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 2 ++ drivers/accel/ivpu/ivpu_pm.c | 15 +-- drivers/accel/ivpu/ivpu_pm.h | 1 + 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/acc

[PATCH 3/7] accel/ivpu: Do not use SSID 1

2023-03-22 Thread Stanislaw Gruszka
The SSID=1 is used by the firmware as default value in case SSID mapping is not initialized. This allows detecting use of miss-configured memory contexts. The future FW versions may not allow using SSID=1. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Stani

[PATCH 4/7] accel/ivpu: Fix power down sequence

2023-03-22 Thread Stanislaw Gruszka
Remove FPGA WA on power_down to skip checking for noc quiescent state. Put VPU in reset before powering it down and skip manipulating registers that are reset by the VPU reset. This fixes power down errors there VPU is powered down just after VPU is booted. Co-developed-by: Jacek Lawrynowicz Si

[PATCH 5/7] accel/ivpu: Disable buttress on device removal

2023-03-22 Thread Stanislaw Gruszka
Use pci_set_power_state() to disable buttress when device is removed. This is workaround of hardware bug that hangs the system. Additionally not disabling buttress prevents CPU enter deeper Pkg-C states when the driver is unloaded or fail to probe. Signed-off-by: Stanislaw Gruszka --- drivers/a

[PATCH 6/7] accel/ivpu: Remove support for 1 tile SKUs

2023-03-22 Thread Stanislaw Gruszka
The support for single tile SKUs was dropped from MTL. Note that we can still boot the VPU with 1-tile work point config - this is independent from number of tiles present in the VPU. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Stanislaw Gruszka --- dri

[PATCH 7/7] accel/ivpu: Fix VPU clock calculation

2023-03-22 Thread Stanislaw Gruszka
VPU cpu clock frequency depends on the workpoint configuration that was granted by the punit. Previously driver was passing incorrect frequency to the VPU firmware. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivp

[PATCH v2 0/3] usb: gadget: functionfs: DMABUF import interface

2023-03-22 Thread Paul Cercueil
Hi, This small patchset adds three new IOCTLs that can be used to attach, detach, or transfer from/to a DMABUF object. Changes since v1: - patch [2/3] is new. I had to reuse a piece of code that was already duplicated in the driver, so I factorized the code. - Make ffs_dma_resv_lock() static -

[PATCH v2 1/3] usb: gadget: Support already-mapped DMA SGs

2023-03-22 Thread Paul Cercueil
Add a new 'sg_was_mapped' field to the struct usb_request. This field can be used to indicate that the scatterlist associated to the USB transfer has already been mapped into the DMA space, and it does not have to be done internally. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/udc/core.c

[PATCH v2 2/3] usb: gadget: functionfs: Factorize wait-for-endpoint code

2023-03-22 Thread Paul Cercueil
This exact same code was duplicated in two different places. Signed-off-by: Paul Cercueil --- drivers/usb/gadget/function/f_fs.c | 48 +- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/

[PATCH v2 3/3] usb: gadget: functionfs: Add DMABUF import interface

2023-03-22 Thread Paul Cercueil
This patch introduces three new ioctls. They all should be called on a data endpoint (ie. not ep0). They are: - FUNCTIONFS_DMABUF_ATTACH, which takes the file descriptor of a DMABUF object to attach to the endpoint. - FUNCTIONFS_DMABUF_DETACH, which takes the file descriptor of the DMABUF to

Re: [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture

2023-03-22 Thread Hans Verkuil
On 22/03/2023 10:14, Luca Ceresoli wrote: > Hello, > > On Thu, 9 Mar 2023 15:42:59 +0100 > Luca Ceresoli wrote: > >> TL;DR: Resending this series with Rob's review tag added. Now all DT >> patches have at least a reviewed-by tag from Rob or Krzysztof, all the >> driver patches have one from Dmi

Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 06:16:27AM +, Vaittinen, Matti wrote: > On 3/21/23 20:59, Stephen Boyd wrote: > > Quoting Matti Vaittinen (2023-03-20 22:45:52) > >> On 3/20/23 21:23, Stephen Boyd wrote: > >>> Quoting Matti Vaittinen (2023-03-18 23:36:20) > >> Besides, I was not sure if you were plann

Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote: > Revision history: > v4 => v5: Mostly fixes to review comments from Andy and Jonathan. > - more accurate change-log in individual patches > - copy code from DRM test helper instead of moving it to simplify > merging 1) Why do yo

Re: [PATCH v2 00/65] clk: Make determine_rate mandatory for muxes

2023-03-22 Thread Maxime Ripard
Hi Stephen, On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2022-11-04 06:17:17) > > Hi, > > > > This is a follow-up to a previous series that was printing a warning > > when a mux has a set_parent implementation but is missing > > determine_rate(). > > > >

Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor

2023-03-22 Thread Javier Martinez Canillas
Andy Shevchenko writes: Hello Andy, > On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote: > >> Revision history: >> v4 => v5: Mostly fixes to review comments from Andy and Jonathan. >> - more accurate change-log in individual patches > >> - copy code from DRM test helper instead of

Re: [PATCH] drm: xlnx: zynqmp: Use dev_err_probe()

2023-03-22 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.3-rc3 next-20230322] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/tegra: allow compile test on !ARM v2

2023-03-22 Thread Christian König
This compile tests on x86 just perfectly fine. v2: fix missing include complained by kernel test robot Signed-off-by: Christian König CC: Thierry Reding CC: Jonathan Hunter CC: linux-te...@vger.kernel.org --- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/drm/tegra/gem.c | 1 + drivers/g

[PATCH v14 00/10] Register Type-C mode-switch in DP bridge endpoints

2023-03-22 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. This series is not directly related to the built-in mux in anx7625, which automatically switches between the two orientations

[PATCH v14 01/10] device property: Add remote endpoint to devcon matcher

2023-03-22 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices. Th

[PATCH v14 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-03-22 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-22 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tree. Signed-off-by: Pin-yen Lin --- Chan

[PATCH v14 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-03-22 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Als

[PATCH v14 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-22 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port endpo

[PATCH v14 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-03-22 Thread Pin-yen Lin
These two drivers embed a i2c_client in their private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko --- (no changes since v13) Changes in v13: - Update a typo in the com

[PATCH v14 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-03-22 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Signed

[PATCH v14 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-22 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant ports are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Crosspoint switch can also be used for switching the output signal for different o

[PATCH v14 09/10] drm/bridge: it6505: Fix Kconfig indentation

2023-03-22 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file

[PATCH v14 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-22 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by: P

Re: [PATCH] drm/panel: Fix panel mode type setting logic

2023-03-22 Thread Neil Armstrong
Hi, On 17/03/2023 01:23, Doug Anderson wrote: Hi, On Tue, Mar 14, 2023 at 4:55 PM Jianhua Lu wrote: On Tue, Mar 14, 2023 at 10:12:02AM -0700, Doug Anderson wrote: Hi, On Tue, Mar 14, 2023 at 4:45 AM Jianhua Lu wrote: Some panels set mode type to DRM_MODE_TYPE_PREFERRED by the number of

[PATCH] RFC: drm: Create a alloc helper flags blob

2023-03-22 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" In Android, we could also call gralloc to allocate a graphics buffer for the decoder, display or encoder. In the GNU Linux, we don't have such framework, the only thing we could have is the GBM. Unfortunately, some platforms don't have a GPU may not ship the gbm library

Re: [PATCH] drm: bridge: simple-bridge: Use dev_err_probe()

2023-03-22 Thread Neil Armstrong
Hi, On Wed, 22 Mar 2023 16:22:51 +0800, ye.xingc...@zte.com.cn wrote: > Replace the open-code with dev_err_probe() to simplify the code. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm: bridge: simple-bridge: Use dev_err_probe() htt

Re: [PATCH] drm/bridge: display-connector: Use dev_err_probe()

2023-03-22 Thread Neil Armstrong
Hi, On Wed, 22 Mar 2023 16:21:33 +0800, ye.xingc...@zte.com.cn wrote: > Replace the open-code with dev_err_probe() to simplify the code. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/bridge: display-connector: Use dev_err_probe()

Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor

2023-03-22 Thread Matti Vaittinen
On 3/22/23 12:34, Javier Martinez Canillas wrote: Andy Shevchenko writes: Hello Andy, On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote: Revision history: v4 => v5: Mostly fixes to review comments from Andy and Jonathan. - more accurate change-log in individual patches - co

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "reg" propertie

Re: [PATCH v5 0/8] Support ROHM BU27034 ALS sensor

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 12:59:33PM +0200, Matti Vaittinen wrote: > On 3/22/23 12:34, Javier Martinez Canillas wrote: > > > On Wed, Mar 22, 2023 at 11:05:23AM +0200, Matti Vaittinen wrote: ... > > > > - copy code from DRM test helper instead of moving it to simplify > > > >merging > > > > > >

Re: [PATCH v14 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-22 Thread Andy Shevchenko
On Wed, Mar 22, 2023 at 06:46:36PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant ports are available in Device Tree. Configure the crosspoint > switch based on the entered alternate mode for a specific Type-C > connector. > > Crosspoin

Re: [PATCH 4/7] drm/debugfs: rework debugfs directory creation v2

2023-03-22 Thread Stanislaw Gruszka
On Thu, Mar 16, 2023 at 09:20:32AM +0100, Christian König wrote: > Instead of the per minor directories only create a single debugfs > directory for the whole device directly when the device is initialized. > > For DRM devices each minor gets a symlink to the per device directory > for now until w

Re: DRM debugfs cleanup take 3

2023-03-22 Thread Stanislaw Gruszka
On Thu, Mar 16, 2023 at 09:20:28AM +0100, Christian König wrote: > Hi guys, > > I've messed up the last send out. Cleanup up some issues reported by people > with the accel drivers (duplicated files) and rebased the result. > > Apart from that the same approach we already discussed previously.

Re: [PATCH v14 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-03-22 Thread AngeloGioacchino Del Regno
Il 22/03/23 11:46, Pin-yen Lin ha scritto: These two drivers embed a i2c_client in their private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko Reviewed-by: AngeloGioac

Re: [PATCH v14 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-22 Thread AngeloGioacchino Del Regno
Il 22/03/23 11:46, Pin-yen Lin ha scritto: The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence

Re: [PATCH v14 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-03-22 Thread AngeloGioacchino Del Regno
Il 22/03/23 11:46, Pin-yen Lin ha scritto: From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-con

Re: Linux 6.3-rc3

2023-03-22 Thread Kalle Valo
Nathan Chancellor writes: > On Mon, Mar 20, 2023 at 11:26:17AM -0700, Linus Torvalds wrote: >> On Mon, Mar 20, 2023 at 11:05 AM Nathan Chancellor wrote: >> > >> > On the clang front, I am still seeing the following warning turned error >> > for arm64 allmodconfig at least: >> > >> > drivers/gp

[PATCH 0/5] Create tests for the drm_rect functions

2023-03-22 Thread Arthur Grillo
This patchset seeks to add unit tests for the rest of the functions on the drm_rect.c. The test coverage report generated by the gcov[1] tool states that this set reaches 100% of coverage on the drm_rect.c file. This would be very good for future development on the file. Thanks for reviewing! Be

[PATCH 1/5] drm/tests: Test drm_rect_intersect()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_intersect() function, it also create a helper for comparing drm_rects more easily. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_t

[PATCH 2/5] drm/tests: Test drm_rect_calc_hscale()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_hscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 58 +++ 1 file changed, 58 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_r

[PATCH 3/5] drm/tests: Test drm_rect_calc_vscale()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_vscale() function, besides the test for the usual case it also test for the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 56 +++ 1 file changed, 56 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_r

[PATCH 4/5] drm/tests: Test drm_rect_rotate()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_rotate() function, create test cases for all the rotation modes. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c b/drivers/g

[PATCH v1] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

2023-03-22 Thread Francesco Dolcini
From: Matheus Castello Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent with what all the other DRM bridge drivers are doing and this is required since the bridge might not be there when the driver is probed and this should not be a fatal failure. Cc: Fixes: 30e2ae943c26

[PATCH 5/5] drm/test: Test drm_rect_rotate_inv()

2023-03-22 Thread Arthur Grillo
Insert test for the drm_rect_rotate_inv() function, by expanding the existing test framework for the drm_rect_rotate(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_rect_test.c

Re: [PATCH v4 7/8] accel/qaic: Add qaic driver to the build system

2023-03-22 Thread Jeffrey Hugo
On 3/22/2023 2:03 AM, Jacek Lawrynowicz wrote: Hi, On 20.03.2023 16:11, Jeffrey Hugo wrote: Now that we have all the components of a minimum QAIC which can boot and run an AIC100 device, add the infrastructure that allows the QAIC driver to be built. Signed-off-by: Jeffrey Hugo Reviewed-by: C

Re: [PATCH v4 6/8] accel/qaic: Add mhi_qaic_cntl

2023-03-22 Thread Jeffrey Hugo
On 3/22/2023 2:11 AM, Jacek Lawrynowicz wrote: Reviewed-by: Jacek Lawrynowicz Hi, On 20.03.2023 20:06, Jeffrey Hugo wrote: On 3/20/2023 9:11 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Some of the MHI channels for an AIC100 device need to be routed to userspace so that user

Re: [PATCH v1] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

2023-03-22 Thread Laurent Pinchart
Hi Francesco, Thank you for the patch. On Wed, Mar 22, 2023 at 03:03:09PM +0100, Francesco Dolcini wrote: > From: Matheus Castello > > Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent > with what all the other DRM bridge drivers are doing and this is > required since the

Re: [PATCH 1/7] accel/ivpu: Do not access HW registers after unbind

2023-03-22 Thread Jeffrey Hugo
On 3/22/2023 3:18 AM, Stanislaw Gruszka wrote: We should not access hardware after we unbind from the bus. Use drm_dev_enter() / drm_dev_exit() to mark code sections where hardware is accessed (and not already protected by other locks) and drm_dev_unplug() to mark device is gone. Signed-off-by:

Re: [PATCH 2/7] accel/ivpu: Cancel recovery work

2023-03-22 Thread Jeffrey Hugo
On 3/22/2023 3:18 AM, Stanislaw Gruszka wrote: Prevent running recovery_work after device is removed. Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 2 ++ drivers/accel/ivpu/ivpu_pm.c | 15 +-- drivers/accel/ivpu/ivpu_pm.h | 1 + 3 files changed, 16 in

Re: [PATCH 3/7] accel/ivpu: Do not use SSID 1

2023-03-22 Thread Jeffrey Hugo
On 3/22/2023 3:18 AM, Stanislaw Gruszka wrote: The SSID=1 is used by the firmware as default value in case SSID mapping is not initialized. This allows detecting use of miss-configured memory contexts. The future FW versions may not allow using SSID=1. Co-developed-by: Andrzej Kacprowski Signed

  1   2   3   >