Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Christian König
Am 09.03.23 um 07:30 schrieb Asahi Lina: On 09/03/2023 05.14, Christian König wrote: I think you mean wake_up_interruptible(). That would be drm_sched_job_done(), on the fence callback when a job completes, which as I keep saying is the same logic used for hw_rq_count/hw_submission_limit trackin

Re: [PATCH v2 3/7] drm/ttm: Use the BIT macro for the TTM_TT_FLAGs

2023-03-09 Thread Christian König
Am 09.03.23 um 08:06 schrieb Thomas Hellström: Hi, Christian, Thanks for reviewing these. Ack to merge reviewed patches through drm-misc-next? Sure. Christian. Thanks, Thomas On 3/8/23 09:49, Christian König wrote: Am 07.03.23 um 15:46 schrieb Thomas Hellström: New code is recommende

Re: [PATCH] fbdev: tgafb: Fix potential divide by zero

2023-03-09 Thread Helge Deller
On 3/9/23 08:53, Jani Nikula wrote: On Wed, 08 Mar 2023, Helge Deller wrote: On 3/7/23 14:08, harperchen wrote: fb_set_var would by called when user invokes ioctl with cmd FBIOPUT_VSCREENINFO. User-provided data would finally reach tgafb_check_var. In case var->pixclock is assigned to zero, di

Re: [PATCH 00/22] drm/dma-helper: Add dedicated fbdev emulation

2023-03-09 Thread Linus Walleij
On Tue, Mar 7, 2023 at 9:55 AM Thomas Zimmermann wrote: > Am 06.03.23 um 23:19 schrieb Linus Walleij: > > 2) Why isn't this DRM driver changed? > > drivers/gpu/drm/mcde/mcde_drv.c > > AFAICT it also uses GEM buffers in system memory. > > This driver requires damage handling > https://elixir.bootl

[PATCH] drm/mcde: Do not use dirty GEM FB handling

2023-03-09 Thread Linus Walleij
This driver has no way to handle damage, the reason the drm_gem_fb_create_with_dirty() was used was because I had the ambition that the driver would only send out updates to DSI command displays whenever something changed, so as to minimize traffic. It turns out this ambition with command mode isn

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-09 Thread Intel
On 3/8/23 10:10, Christian König wrote: Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it starts using GEM as well. Is this because vmwgfx piggybacks

Re: [PATCH 9/9] drm: move ttm_execbuf_util into vmwgfx

2023-03-09 Thread Intel
Hi, On 3/9/23 06:14, Zack Rusin wrote: On Wed, 2023-03-08 at 10:10 +0100, Christian König wrote: Am 08.03.23 um 06:14 schrieb Zack Rusin: On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote: VMWGFX is the only remaining user of this and should probably moved over to drm_exec when it star

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-09 Thread Christian König
Am 08.03.23 um 20:37 schrieb Asahi Lina: On 09/03/2023 03.12, Christian König wrote: Am 08.03.23 um 18:32 schrieb Asahi Lina: [SNIP] Yes but... none of this cleans up jobs that are already submitted by the scheduler and in its pending list, with registered completion callbacks, which were alrea

Re: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Dmitry Baryshkov
On 09/03/2023 07:48, Guchun Chen wrote: In order to catch issues in other drivers to ensure proper call sequence of polling function. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2411 Fixes: a4e771729a51("drm/probe_helper: sort out poll_running vs poll_enabled") Previously it was sugge

Re: [RFC v2 0/6] drm/amd/display: Pass proper parent for DM backlight device v2

2023-03-09 Thread Hans de Goede
Hi all, On 3/8/23 23:10, Hans de Goede wrote: > Hi, > > On 3/8/23 22:58, Hans de Goede wrote: >> Hi All, >> >> Here is version 2 of my patch series to pass the proper parent device >> to backlight_device_register(). >> >> New in version 2 is delaying the registering of the backlight_dev till >> a

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-03-09 Thread Ricardo Cañuelo
Hi Marek, On lun 09-01-2023 23:00:33, Marek Szyprowski wrote: > devm_regulator_get_enable_optional() function returns 0 on success, so > use it for the check if function succeded instead of the -ENODEV value. > > Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") > Sign

Re: [RFC] drm: property: use vzalloc() instead of kvzalloc() for large blobs

2023-03-09 Thread Dmitry Baryshkov
On 08/03/2023 22:02, Abhinav Kumar wrote: For DRM property blobs created by user mode using drm_property_create_blob(), if the blob value needs to be updated the only way is to destroy the previous blob and create a new one instead. For some of the property blobs, if the size of the blob is more

Re: [PATCH v4 27/30] drm/msm/dpu: add support for wide planes

2023-03-09 Thread Dmitry Baryshkov
On 09/03/2023 01:14, Abhinav Kumar wrote: On 3/3/2023 4:57 AM, Dmitry Baryshkov wrote: Typically SSPP can support rectangle with width up to 2560. However it's possible to use multirect feature and split source to use the SSPP to output two consecutive rectangles. This commit brings in this ca

[PATCH v5] dt-bindings: display: mediatek: clean unnecessary item

2023-03-09 Thread Alexandre Mergnat
The item which have the mediatek,mt8192-disp-ccorr as const compatible already exist above. Merge all compatibles which have the same fallback under the same item. Acked-by: Krzysztof Kozlowski Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rob Herring Signed-off-by: Alexandre Mergnat -

Re: [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE in GGTT. If this PTE points to invalid addres

Re: [PATCH drm-next v2 00/16] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-03-09 Thread Boris Brezillon
Hi Danilo, On Fri, 17 Feb 2023 14:44:06 +0100 Danilo Krummrich wrote: > Changes in V2: > == > Nouveau: > - Reworked the Nouveau VM_BIND UAPI to avoid memory allocations in fence > signalling critical sections. Updates to the VA space are split up in > three > separ

Re: [PATCH RFC 10/18] drm/scheduler: Add can_run_job callback

2023-03-09 Thread Asahi Lina
On 09/03/2023 17.05, Christian König wrote: > Am 09.03.23 um 07:30 schrieb Asahi Lina: >> On 09/03/2023 05.14, Christian König wrote: I think you mean wake_up_interruptible(). That would be drm_sched_job_done(), on the fence callback when a job completes, which as I keep saying is th

[PATCH v4 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-03-09 Thread Neil Armstrong
Switch the QMP PHY to the newly documented USB3/DP Combo PHY bindings at [1] and add the DP controller nodes. The DP output is shared with the USB3 SuperSpeed lanes and is usually connected to an USB-C port which Altmode is controlled by the PMIC Glink infrastructure in discution at [1] & [2]. DT

[PATCH v4 2/5] arm64: dts: qcom: sm8350: switch to combo usb3/dp phy

2023-03-09 Thread Neil Armstrong
The first QMP PHY is an USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Reviewed-by: Dmitry Baryshkov Tested-by: Dmitry Baryshkov #SM8350-HDK Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 42 ++

[PATCH v4 3/5] arm64: dts: qcom: sm8350: add dp controller

2023-03-09 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Tested-by: Dmitry Baryshkov #SM8350-HDK Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/

[PATCH v4 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible

2023-03-09 Thread Neil Armstrong
The SM8450 & SM350 shares the same DT TX IP version, use the SM8350 compatible as fallback for SM8450. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/dp-controller.yaml| 25 +- 1 file changed, 15 insertions(+), 10 deletion

[PATCH v4 4/5] arm64: dts: qcom: sm8450: switch to usb3/dp combo phy

2023-03-09 Thread Neil Armstrong
The QMP PHY is a USB3/DP combo phy, switch to the newly documented bindings and register the clocks to the GCC and DISPCC controllers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 42 +--- 1 file changed,

[PATCH v4 5/5] arm64: dts: qcom: sm8450: add dp controller

2023-03-09 Thread Neil Armstrong
Add the Display Port controller subnode to the MDSS node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi

Re: [PATCH 1/2] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 03:46, Ashutosh Dixit wrote: Expose intel_rps_read_actual_frequency_fw to read the actual freq without taking forcewake for use by PMU. The code is refactored to use a common set of functions across sysfs and PMU. Using common functions with sysfs in PMU solves the issues of missi

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread Laurent Pinchart
Hi David, On Thu, Mar 09, 2023 at 07:59:34AM +, David Binderman wrote: > Hello there Laurent, > > >We could, but I don't think it will make any difference in practice as > >the maximum pixel clock frequency supported by the SoC is 80MHz (per > >LVDS channel). That would result in a 560MHz fre

RE: [PATCH 04/13] backlight: da9052_bl: Convert to platform remove callback returning void

2023-03-09 Thread DLG Adam Ward
On 08/03/2023 07:40, Uwe Kleine-König wrote: >The .remove() callback for a platform driver returns an int which makes many >driver authors wrongly assume it's possible to do error handling by returning >an error code. However the value returned is (mostly) ignored >and this >typically results i

Re: [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Andrzej Hajda
On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread David Binderman
Hello there Laurent, >Would you be able to send a patch to fix this ? Sadly, no. My success rate with kernel patches is low enough to make it not worth trying. Regards David Binderman From: Laurent Pinchart Sent: 09 March 2023 09:26 To: David Binderman Cc: andrzej.ha...@intel.com ; neil.a

Re: [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-09 Thread Asahi Lina
On 09/03/2023 17.42, Christian König wrote: > Am 08.03.23 um 20:37 schrieb Asahi Lina: >> On 09/03/2023 03.12, Christian König wrote: >>> Am 08.03.23 um 18:32 schrieb Asahi Lina: [SNIP] Yes but... none of this cleans up jobs that are already submitted by the scheduler and in its pend

Re: [PATCH drm-next v2 00/16] [RFC] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-03-09 Thread Boris Brezillon
On Thu, 9 Mar 2023 10:12:43 +0100 Boris Brezillon wrote: > Hi Danilo, > > On Fri, 17 Feb 2023 14:44:06 +0100 > Danilo Krummrich wrote: > > > Changes in V2: > > == > > Nouveau: > > - Reworked the Nouveau VM_BIND UAPI to avoid memory allocations in fence > > signalling cr

Re: [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Andrzej Hajda
On 09.03.2023 10:43, Tvrtko Ursulin wrote: On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try t

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Pekka Paalanen
On Thu, 9 Mar 2023 01:56:11 +0100 Sebastian Wick wrote: > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > Harry Wentland wrote: > > > > > From: Joshua Ashton > > > > > > To match the other enums, and add more information about these values.

Re: drivers/gpu/drm/bridge/fsl-ldb.c:101: possible loss of information.

2023-03-09 Thread Laurent Pinchart
Hi David, On Thu, Mar 09, 2023 at 09:42:54AM +, David Binderman wrote: > Hello there Laurent, > > > Would you be able to send a patch to fix this ? > > Sadly, no. My success rate with kernel patches is low enough to make > it not worth trying. I'm sorry to hear that. If you were willing to

Re: [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 09:59, Andrzej Hajda wrote: On 09.03.2023 10:43, Tvrtko Ursulin wrote: On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_captu

Re: [PATCH v13 03/10] drm/display: Add Type-C switch helpers

2023-03-09 Thread Pin-yen Lin
Hi Andy, On Wed, Mar 8, 2023 at 11:29 PM Andy Shevchenko wrote: > > On Wed, Mar 08, 2023 at 06:20:14PM +0800, Pin-yen Lin wrote: > > On Mon, Mar 6, 2023 at 7:49 PM Andy Shevchenko > > > On Fri, Mar 03, 2023 at 10:33:43PM +0800, Pin-yen Lin wrote: > > ... > > > > > + switch_desc->typec_ports =

Re: [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-09 Thread Pekka Paalanen
On Wed, 8 Mar 2023 07:52:51 -0800 Rob Clark wrote: > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspired by a trick i915 do

Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-09 Thread Pin-yen Lin
Hi Andy, On Wed, Mar 8, 2023 at 11:31 PM Andy Shevchenko wrote: > > On Wed, Mar 08, 2023 at 09:51:19PM +0800, Pin-yen Lin wrote: > > On Mon, Mar 6, 2023 at 8:03 PM Andy Shevchenko > > wrote: > > > On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: > > ... > > > > > + it6505

Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Implement fbdev emulation that is optimized for drivers that use > DMA helpers. The buffers may no tbe moveable, may not require damage "may not be" Is may the correct verb here though? I guess you meant "shall not". > handling and have to be located in system memor

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Hogander, Jouni
On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: > On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > > Hey, > > > > On 2023-03-06 16:23, Souza, Jose wrote: > > > On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: > > > > As a fallback if we decide not to merge th

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Maarten Lankhorst
On 2023-03-09 12:04, Hogander, Jouni wrote: On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: Hey, On 2023-03-06 16:23, Souza, Jose wrote: On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: As a fallback if w

Re: [PATCH 01/22] drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers

2023-03-09 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [...] >> +drm_fb_helper_prepare(dev, fb_helper, preferred_bpp, >> &drm_fbdev_dma_helper_funcs); >> + >> +ret = drm_client_init(dev, &fb_helper->client, "fbdev", >> &drm_fbdev_dma_client_funcs); >> +if (ret) { >> +drm_err(dev, "Failed to

Re: [PATCH 02/22] arm/hdlcd: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 03/22] arm/malidp: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 04/22] drm/aspeed: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 05/22] drm/atmel-hlcdc: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 06/22] drm/fsl-dcu: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 07/22] drm/imx/dcss: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 08/22] drm/imx: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 09/22] drm/kmb: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 08/22] drm/imx: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 11/22] drm/meson: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 10/22] drm/logicvc: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 12/22] drm/mxsfb/lcdif: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 13/22] drm/mxsfb: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 14/22] drm/sti: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 15/22] drm/stm: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-09 Thread AL13N
Dave Stevenson schreef op 2023-03-07 18:10: Hi Maarten On Tue, 7 Mar 2023 at 16:25, AL13N wrote: AL13N schreef op 2023-03-06 17:34: > Hi, > > I have a RPI4B connected on 2nd HDMI port (furthest away from power) > to a 4K TV, which works until 5.16, from 5.17 there is no X (or > plymouth), the

Re: [PATCH 16/22] drm/sun4i: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 17/22] drm/tidss: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 19/22] drm/arcpgu: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 20/22] drm/tve200: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 21/22] drm/vc4: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH 22/22] drm/xlnx: Use GEM DMA fbdev emulation

2023-03-09 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-09 Thread Christian König
Am 09.03.23 um 10:43 schrieb Asahi Lina: On 09/03/2023 17.42, Christian König wrote: Am 08.03.23 um 20:37 schrieb Asahi Lina: On 09/03/2023 03.12, Christian König wrote: Am 08.03.23 um 18:32 schrieb Asahi Lina: [SNIP] Yes but... none of this cleans up jobs that are already submitted by the sc

Re: [PATCH RFC 06/18] rust: drm: gem: shmem: Add DRM shmem helper abstraction

2023-03-09 Thread Maíra Canal
On 3/9/23 02:25, Asahi Lina wrote: On 08/03/2023 22.38, Maíra Canal wrote: On 3/7/23 11:25, Asahi Lina wrote: The DRM shmem helper includes common code useful for drivers which allocate GEM objects as anonymous shmem. Add a Rust abstraction for this. Drivers can choose the raw GEM implementatio

Re: [PATCH RFC 01/18] rust: drm: ioctl: Add DRM ioctl abstraction

2023-03-09 Thread Maíra Canal
On 3/9/23 03:15, Dave Airlie wrote: On Thu, 9 Mar 2023 at 15:32, Asahi Lina wrote: On 08/03/2023 00.32, Maíra Canal wrote: On 3/7/23 11:25, Asahi Lina wrote: DRM drivers need to be able to declare which driver-specific ioctls they support. This abstraction adds the required types and a helpe

Re: [PATCH 22/99] fbdev/fsl-diu-fb: Duplicate video-mode option string

2023-03-09 Thread Thomas Zimmermann
Hi Am 08.03.23 um 17:26 schrieb Timur Tabi: On Tue, Mar 7, 2023 at 2:28 AM Thomas Zimmermann wrote: So after module_init is finished, mode_option_buf[] no longer exists? Does the __init attribute on a function affect the static variables in that function? That is an excellent question. ht

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2023 at 12:09:55PM +0100, Maarten Lankhorst wrote: > > On 2023-03-09 12:04, Hogander, Jouni wrote: > > On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: > >> On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > >>> Hey, > >>> > >>> On 2023-03-06 16:23, Souza,

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-09 Thread Dave Stevenson
On Thu, 9 Mar 2023 at 11:26, AL13N wrote: > > Dave Stevenson schreef op 2023-03-07 18:10: > > Hi Maarten > > > > On Tue, 7 Mar 2023 at 16:25, AL13N wrote: > >> > >> AL13N schreef op 2023-03-06 17:34: > >> > Hi, > >> > > >> > I have a RPI4B connected on 2nd HDMI port (furthest away from power) > >

[PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Jani Nikula
Make the struct ttm_device_funcs pointers const so the data can be placed in rodata. Cc: Christian Koenig Cc: Huang Rui Signed-off-by: Jani Nikula --- drivers/gpu/drm/ttm/ttm_device.c | 2 +- include/drm/ttm/ttm_device.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --g

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Christian König
Am 09.03.23 um 13:37 schrieb Jani Nikula: Make the struct ttm_device_funcs pointers const so the data can be placed in rodata. Cc: Christian Koenig Cc: Huang Rui Signed-off-by: Jani Nikula Good idea, Reviewed-by: Christian König Should I push it to drm-misc-next or do you need it on some

Re: [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Jani Nikula
On Thu, 09 Mar 2023, Christian König wrote: > Am 09.03.23 um 13:37 schrieb Jani Nikula: >> Make the struct ttm_device_funcs pointers const so the data can be placed in >> rodata. >> >> Cc: Christian Koenig >> Cc: Huang Rui >> Signed-off-by: Jani Nikula > > Good idea, Reviewed-by: Christian Kön

Re: [regression] RPI4B drm vc4: no crtc or sizes since 5.17 (works in 5.16; and still broken in at least 6.1)

2023-03-09 Thread Dave Stevenson
On Wed, 8 Mar 2023 at 22:46, AL13N wrote: > > AL13N schreef op 2023-03-08 22:16: > > Maxime Ripard schreef op 2023-03-08 13:35: > >> Hi, > >> > >> On Tue, Mar 07, 2023 at 05:10:16PM +, Dave Stevenson wrote: > >>> On Tue, 7 Mar 2023 at 16:25, AL13N wrote: > >>> > AL13N schreef op 2023-03-06 17

RE: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Chen, Guchun
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, March 9, 2023 4:49 PM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, > Alexander ; Zhang, Hawking > ; spassw...@web.de; m...@fireburn.co.uk > Subject: Re: [PATCH 2/2] drm/pr

[PATCH v3 0/3] drm/ttm: Small fixes / cleanups in prep for shrinking

2023-03-09 Thread Thomas Hellström
I collected the, from my POW, uncontroversial patches from V1 of the TTM shrinker series, some corrected after the initial patch submission, one patch added from the Xe RFC ("drm/ttm: Don't print error message if eviction was interrupted"). It would be nice to have these reviewed and merged while r

[PATCH v3 3/3] drm/ttm: Make the call to ttm_tt_populate() interruptible when faulting

2023-03-09 Thread Thomas Hellström
When swapping in, or under memory pressure ttm_tt_populate() may sleep for a substantiable amount of time. Allow interrupts during the sleep. This will also allow us to inject -EINTR errors during swapin in upcoming patches. Also avoid returning VM_FAULT_OOM, since that will confuse the core mm, m

[PATCH v3 1/3] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-03-09 Thread Thomas Hellström
When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thing. v2: - Simplify that common function (Christian König) v3: - Rename that common fun

[PATCH v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-03-09 Thread Thomas Hellström
When swapping out, we will split multi-order pages both in order to move them to the swap-cache and to be able to return memory to the swap cache as soon as possible on a page-by-page basis. Reduce the page max order to the system PMD size, as we can then be nicer to the system and avoid splitting

Re: [PATCH RFC 11/18] drm/scheduler: Clean up jobs when the scheduler is torn down

2023-03-09 Thread Asahi Lina
On 09/03/2023 20.47, Christian König wrote: > Am 09.03.23 um 10:43 schrieb Asahi Lina: >> On 09/03/2023 17.42, Christian König wrote: >>> Am 08.03.23 um 20:37 schrieb Asahi Lina: On 09/03/2023 03.12, Christian König wrote: > Am 08.03.23 um 18:32 schrieb Asahi Lina: >> [SNIP] >> Yes

Re: [PATCH RFC 06/18] rust: drm: gem: shmem: Add DRM shmem helper abstraction

2023-03-09 Thread Asahi Lina
On 09/03/2023 20.47, Maíra Canal wrote: > On 3/9/23 02:25, Asahi Lina wrote: >> On 08/03/2023 22.38, Maíra Canal wrote: >>> On 3/7/23 11:25, Asahi Lina wrote: The DRM shmem helper includes common code useful for drivers which allocate GEM objects as anonymous shmem. Add a Rust abstraction

Re: [PATCH 1/2] drm/amdgpu: move poll enabled/disable into non DC path

2023-03-09 Thread Alex Deucher
On Thu, Mar 9, 2023 at 12:48 AM Guchun Chen wrote: > > Some amd asics having reliable hotplug support don't call > drm_kms_helper_poll_init in driver init sequence. However, > due to the unified suspend/resume path for all asics, because > the output_poll_work->func is not set for these asics, a w

[PATCH 00/21] Add display support for the MT8365-EVK board.

2023-03-09 Thread Alexandre Mergnat
The purpose of this series is to add the display support for the mt8365-evk. This is the list of HWs / IPs support added: - Connectors (HW): - HDMI - MIPI DSI (Mobile Industry Processor Interface Display Serial Interface) - HDMI bridge (it66121) - DSI pannel (startek,kd070fhfid015) - SoC displ

[PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Color Correction for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devic

[PATCH 01/21] dt-bindings: display: mediatek: aal: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Adaptive Ambient Light for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/d

[PATCH 05/21] dt-bindings: display: mediatek: dsi: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Serial Interface for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- .../bindings/display/mediatek/mediatek,dsi.yaml | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a

[PATCH 06/21] dt-bindings: display: mediatek: dpi: add power-domains property

2023-03-09 Thread Alexandre Mergnat
From: Fabien Parent DPI is part of the display / multimedia block in MediaTek SoCs, and always have a power-domain (at least in the upstream device-trees). Add the power-domains property to the binding documentation. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- Documentat

[PATCH 03/21] dt-bindings: display: mediatek: color: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Color for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,color.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365

2023-03-09 Thread Alexandre Mergnat
From: Fabien Parent DPI for MT8365 is compatible with MT8192 but requires an additional clock. Modify the documentation to requires this clock only on MT8365 SoCs. Signed-off-by: Fabien Parent Signed-off-by: Alexandre Mergnat --- .../bindings/display/mediatek/mediatek,dpi.yaml| 48 +++

[PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Overlay for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8192 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 08/21] dt-bindings: display: mediatek: gamma: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display GAMMA for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindi

[PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display PWM for MT8365 is compatible with MT8183. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/pwm/mediatek,p

[PATCH 04/21] dt-bindings: display: mediatek: dither: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Dither for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bin

[PATCH 12/21] dt-bindings: pwm: add power-domains property

2023-03-09 Thread Alexandre Mergnat
According to the Mediatek datasheet, the display PWM block has a power domain. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yam

[PATCH 11/21] dt-bindings: display: pannel: add startek kd070fhfid015 binding documentation

2023-03-09 Thread Alexandre Mergnat
The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution of 1024 x 600 pixels. Signed-off-by: Alexandre Mergnat --- .../display/panel/startek,kd070fhfid015.yaml | 55 ++ 1 file changed, 55 insertions(+) diff --git a/Documentation/devicetree/bindings/dis

[PATCH 10/21] dt-bindings: display: mediatek: rdma: add binding for MT8365 SoC

2023-03-09 Thread Alexandre Mergnat
Display Data Path Read DMA for MT8365 is compatible with another SoC. Then, add MT8365 binding along with MT8183 SoC. Signed-off-by: Alexandre Mergnat --- Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devi

[PATCH 17/21] arm64: dts: mediatek: add display support for mt8365-evk

2023-03-09 Thread Alexandre Mergnat
MIPI DSI: - Add "vsys_lcm_reg" regulator support and setup the "mt6357_vsim1_reg", to power the pannel plugged to the DSI connector. - Setup the Display Parallel Interface. - Add the startek kd070fhfid015 pannel support. HDMI: - Add HDMI connector support. - Add the "ite,it66121" HDMI bridge sup

[PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness

2023-03-09 Thread Alexandre Mergnat
Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing b

[PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property

2023-03-09 Thread Alexandre Mergnat
According to the mtk-mutex.c driver and the SoC DTS, the clock isn't required to work properly for some of MTK SoC. Improve the clock requirement by adding a condition which is function to the compatible. Signed-off-by: Alexandre Mergnat --- .../bindings/soc/mediatek/mediatek,mutex.yaml|

  1   2   3   4   >