[PATCH v8 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm

2023-03-06 Thread Jason-JH . Lin
Because compatible of mt8195 is changing from "mediatek,mt8195-mmsys" to "mediatek,mt8195-vdosys0". We have to revert the multiple compatible finding function and add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del R

[PATCH v8 2/2] soc: mediatek: remove DDP_DOMPONENT_DITHER from enum

2023-03-06 Thread Jason-JH . Lin
After mmsys and drm change DITHER enum to DDP_COMPONENT_DITHER0, mmsys header can remove the useless DDP_COMPONENT_DITHER enum. Signed-off-by: Jason-JH.Lin Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Rex-BC Chen Acked-by: Matthias Brugger --- include/linux/soc/mediatek/mtk-mmsys.h |

[PATCH v8 0/2] Change mmsys compatible for mt8195 mediatek-drm

2023-03-06 Thread Jason-JH . Lin
For previous MediaTek SoCs, such as MT8173, there are 2 display HW pipelines binding to 1 mmsys with the same power domain, the same clock driver and the same mediatek-drm driver. For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to 2 different power domains, different clock drive

Re: [PATCH] drm/amdgpu: Use uncached ioremap() for LoongArch

2023-03-06 Thread WANG Xuerui
On 2023/3/6 10:49, Huacai Chen wrote: Hi, Christian, On Mon, Mar 6, 2023 at 12:40 AM Christian König wrote: Am 05.03.23 um 06:21 schrieb Huacai Chen: LoongArch maintains cache coherency in hardware, but its WUC attribute (Weak-ordered UnCached, which is similar to WC) is out of the scope of

[PATCH] drm/amd/display: add prefix to amdgpu_dm_plane.h functions

2023-03-06 Thread David Tadokoro
From: David Tadokoro The amdgpu_dm_plane.h functions didn't have names that indicated where they were declared. To better filter results in debug tools like ftrace, prefix these functions with 'amdgpu_dm_plane_'. Note that we may want to make this same change in other files like amdgpu_dm_crtc.

Re: [PATCH] drm: fix typo in margin connector properties docs

2023-03-06 Thread Pekka Paalanen
On Sun, 05 Mar 2023 10:35:10 + Simon Ser wrote: > This was pointed out by Ville and Pekka in their replies, but > forgot to apply the change properly before pushing. Sorry for > the noise! > > Signed-off-by: Simon Ser > Fixes: 409f07d353b3 ("drm: document connector margin properties") > Cc:

Re: IMX8MM: assign panel to mipi_dsi in a device tree

2023-03-06 Thread Frieder Schrempf
On 05.03.23 20:45, Patrick Boettcher wrote: > [Sie erhalten nicht häufig E-Mails von patrick.boettc...@posteo.de. Weitere > Informationen, warum dies wichtig ist, finden Sie unter > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, 6 Mar 2023 00:05:03 +0530 > Jagan Teki wrote: > >> O

Re: [PATCH v2] drm/meson: fix 1px pink line on GXM when scaling video overlay

2023-03-06 Thread Neil Armstrong
Hi, On Fri, 03 Mar 2023 12:33:12 +, Christian Hewitt wrote: > Playing media with a resolution smaller than the crtc size requires the > video overlay to be scaled for output and GXM boards display a 1px pink > line on the bottom of the scaled overlay. Comparing with the downstream > vendor dri

Re: [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks

2023-03-06 Thread Neil Armstrong
Hi, On Mon, 13 Feb 2023 10:32:09 +0100, Carlo Caione wrote: > Relax a bit the supported modes list by including also 480x1920 and > 400x1280. This was actually tested on real hardware and it works > correctly. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-mis

Re: Build regressions/improvements in v6.3-rc1

2023-03-06 Thread Geert Uytterhoeven
On Mon, 6 Mar 2023, Geert Uytterhoeven wrote: Below is the list of build error/warning regressions/improvements in v6.3-rc1[1] compared to v6.2[2]. Summarized: - build errors: +9/-14 - build warnings: +4/-1447 Happy fixing! ;-) Thanks to the linux-next team for providing the build service.

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-06 Thread Jagan Teki
Hi Inki Dae, On Mon, Mar 6, 2023 at 10:54 AM 대인기/Tizen Platform Lab(SR)/삼성전자 wrote: > > Hi Jagan, > > > -Original Message- > > From: Jagan Teki > > Sent: Friday, March 3, 2023 11:51 PM > > To: Andrzej Hajda ; Inki Dae > > ; > > Marek Szyprowski ; Neil Armstrong > > ; Marek Vasut ; Maxim

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-06 Thread Krzysztof Kozlowski
On 04/03/2023 16:55, Konrad Dybcio wrote: > The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" > alone. This however didn't quite work out and the property became s/property/compatible/ > undocumented instead of deprecated. Fix that. Reviewed-by: Krzysztof Kozlowski Best r

[Bug 217141] [amdgpu] ring gfx_0.0.0 timeout steam deck AMD APU

2023-03-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217141 The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) changed: What|Removed |Added C

Re: [PATCH v3 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-03-06 Thread Krzysztof Kozlowski
On 04/03/2023 16:55, Konrad Dybcio wrote: > Since the DSI autodetection is bound to work correctly on 6115 now, > switch to using the correct per-SoC + generic fallback compatible > combo. > > Signed-off-by: Konrad Dybcio > --- > .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml

PSA: drm-misc-next-fixes is closed

2023-03-06 Thread Thomas Zimmermann
Hi, I'm just letting you know that drm-misc-next-fixes is closed as v6.3-rc1 has been tagged on Sunday. DRM's drm-next tree will be open for features and bugfixes until -rc6 comes out. The transition from/to drm-misc-fixes-next sometimes results in patches getting applied to the wrong tree a

[PATCH] drm/msm/dpu: Fix bit-shifting UB in DPU_HW_VER() macro

2023-03-06 Thread Geert Uytterhoeven
With gcc-5 and CONFIG_UBSAN_SHIFT=y: drivers/gpu/drm/msm/msm_mdss.c: In function 'msm_mdss_enable': drivers/gpu/drm/msm/msm_mdss.c:296:2: error: case label does not reduce to an integer constant case DPU_HW_VER_800: ^ drivers/gpu/drm/msm/msm_mdss.c:299:2: error: case label

Re: [PATCH] dt-bindings: Fix SPI and I2C bus node names in examples

2023-03-06 Thread Bartosz Golaszewski
On Tue, Feb 28, 2023 at 10:54 PM Rob Herring wrote: > > SPI and I2C bus node names are expected to be "spi" or "i2c", > respectively, with nothing else, a unit-address, or a '-N' index. A > pattern of 'spi0' or 'i2c0' or similar has crept in. Fix all these > cases. Mostly scripted with the followi

Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm

2023-03-06 Thread 林睿祥

[PATCH] VT: Protect KD_FONT_OP_GET_TALL from unbound access

2023-03-06 Thread Samuel Thibault
In ioctl(KD_FONT_OP_GET_TALL), userland tells through op->height which vpitch should be used to copy over the font. In con_font_get, we were not checking that it is within the maximum height value, and thus userland could make the vc->vc_sw->con_font_get(vc, &font, vpitch); call possibly overflow t

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-06 Thread Konrad Dybcio
On 4.03.2023 18:53, Bryan O'Donoghue wrote: > On 04/03/2023 17:45, Bryan O'Donoghue wrote: >> On 04/03/2023 17:35, Konrad Dybcio wrote: you'll see no error. However if you just do this diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi

Re: [PATCH v3 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-03-06 Thread Konrad Dybcio
On 6.03.2023 09:57, Krzysztof Kozlowski wrote: > On 04/03/2023 16:55, Konrad Dybcio wrote: >> Since the DSI autodetection is bound to work correctly on 6115 now, >> switch to using the correct per-SoC + generic fallback compatible >> combo. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../devi

[PATCH 06/10] drm/msm: fix vram leak on bind errors

2023-03-06 Thread Johan Hovold
Make sure to release the VRAM buffer also in a case a subcomponent fails to bind. Fixes: d863f0c7b536 ("drm/msm: Call msm_init_vram before binding the gpu") Cc: sta...@vger.kernel.org # 5.11 Cc: Craig Tatlor Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 26 +++

[PATCH 08/10] drm/msm: fix workqueue leak on bind errors

2023-03-06 Thread Johan Hovold
Make sure to destroy the workqueue also in case of early errors during bind (e.g. a subcomponent failing to bind). Since commit c3b790ea07a1 ("drm: Manage drm_mode_config_init with drmm_") the mode config will be freed when the drm device is released also when using the legacy interface, but add a

[PATCH 02/10] Revert "drm/msm: Fix failure paths in msm_drm_init()"

2023-03-06 Thread Johan Hovold
This reverts commit 8636500300a01740d92b345c680b036b94555b1b. A recent commit tried to address a drm device leak in the early msm_drm_uninit() error paths but ended up making things worse. Specifically, it moved the drm device reference put in msm_drm_uninit() to msm_drm_init() which means that t

[PATCH 09/10] drm/msm: use drmm_mode_config_init()

2023-03-06 Thread Johan Hovold
Switch to using drmm_mode_config_init() so that the mode config is released when the last reference to the DRM device is dropped rather than unconditionally at unbind() (which may be too soon). Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 11 +-- 1 file changed, 5 inse

[PATCH 03/10] drm/msm: fix NULL-deref on snapshot tear down

2023-03-06 Thread Johan Hovold
In case of early initialisation errors and on platforms that do not use the DPU controller, the deinitilisation code can be called with the kms pointer set to NULL. Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot") Cc: sta...@vger.kernel.org # 5.14 Cc: Abhinav Kumar Signed-of

[PATCH 04/10] drm/msm: fix NULL-deref on irq uninstall

2023-03-06 Thread Johan Hovold
In case of early initialisation errors and on platforms that do not use the DPU controller, the deinitilisation code can be called with the kms pointer set to NULL. Fixes: f026e431cf86 ("drm/msm: Convert to Linux IRQ interfaces") Cc: sta...@vger.kernel.org # 5.14 Cc: Thomas Zimmermann Signed

[PATCH 00/10] drm/msm: fix bind error handling

2023-03-06 Thread Johan Hovold
I had reasons to look closer at the MSM DRM driver error handling and realised that it had suffered from a fair amount of bit rot over the years. Unfortunately, I started fixing this in my 6.2 branch and failed to notice two partial and, as it turned out, broken attempts to address this that are n

[PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-06 Thread Johan Hovold
Make sure to free the DRM device also in case of early errors during bind(). Fixes: 2027e5b3413d ("drm/msm: Initialize MDSS irq domain at probe time") Cc: sta...@vger.kernel.org # 5.17 Cc: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 10 -- 1 fil

[PATCH 07/10] drm/msm: fix missing wq allocation error handling

2023-03-06 Thread Johan Hovold
Add the missing sanity check to handle workqueue allocation failures. Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon") Cc: sta...@vger.kernel.org # 3.12 Cc: Rob Clark Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 4 1 file changed, 4 insertions(+) di

[PATCH 01/10] Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"

2023-03-06 Thread Johan Hovold
This reverts commit 643b7d0869cc7f1f7a5ac7ca6bd25d88f54e31d0. A recent patch that tried to fix up the msm_drm_init() paths with respect to the workqueue but only ended up making things worse: First, the newly added calls to msm_drm_uninit() on early errors would trigger NULL-pointer dereferences,

[PATCH 10/10] drm/msm: move include directive

2023-03-06 Thread Johan Hovold
Move the include of of_address.h to the top of the file where it belongs. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index ade17947d1e5..42ae7575

[PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Nirmoy Das
Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset for lmem objects. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/display/intel_dpt.c | 4 +++- drivers/gpu/drm/i915/display/intel_fbdev.c | 3 ++- driver

[PATCH 2/3] drm/i915: Add a helper func for gem obj mmap

2023-03-06 Thread Nirmoy Das
Move gem obj mmap code to i915_gem_object_mmap() so that this can be used by others. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 20 ++--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 25 ++ drivers/gpu/drm/i915/gem/i915_gem_mman.h

[PATCH RFC 3/3] drm/i915/display: Implement fb_mmap callback function

2023-03-06 Thread Nirmoy Das
If stolen memory allocation fails for fbdev, the driver will fallback to system memory. Calculation of smem_start is wrong for such framebuffer objs if the platform comes with no gmadr or no aperture. Solve this by adding fb_mmap callback which also gives driver more control. Signed-off-by: Nirmoy

[PATCH] drm/sun4i: fix missing component unbind on bind errors

2023-03-06 Thread Johan Hovold
Make sure to unbind all subcomponents when binding the aggregate device fails. Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support") Cc: sta...@vger.kernel.org # 4.7 Cc: Maxime Ripard Signed-off-by: Johan Hovold --- Note that this one has only been compile tested. Johan

[PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-06 Thread Johan Hovold
Make sure to unbind all subcomponents when binding the aggregate device fails. Fixes: a41e82e6c457 ("drm/meson: Add support for components") Cc: sta...@vger.kernel.org # 4.12 Cc: Neil Armstrong Signed-off-by: Johan Hovold --- Note that this one has only been compile tested. Johan drive

[PATCH v3 1/9] drm/vc4: Switch to container_of_const

2023-03-06 Thread Maxime Ripard
container_of_const() allows to preserve the pointer constness and is thus more flexible than inline functions. Let's switch all our instances of container_of() to container_of_const(). Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_mock.h| 3 ++ drivers/gpu/drm/vc4/test

[PATCH v3 0/9] drm/vc4: hdmi: Broadcast RGB, BT601, BT2020

2023-03-06 Thread Maxime Ripard
Hi, Here's a collection of patches that have been in the downstream tree for a while to add a bunch of new features to the HDMI controller. Let me know what you think, Maxime Signed-off-by: Maxime Ripard --- Changes in v3: - Convert only helper functions to container_of_const but drop the dir

[PATCH v3 2/9] drm/vc4: hdmi: Update all the planes if the TV margins are changed

2023-03-06 Thread Maxime Ripard
On VC4, the TV margins on the HDMI connector are implemented by scaling the planes. However, if only the TV margins or the connector are changed by a new state, the planes ending up on that connector won't be. Thus, they won't be updated properly and we'll effectively ignore that change until the

[PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson Copy Intel's "Broadcast RGB" property semantics to add manual override of the HDMI pixel range for monitors that don't abide by the content of the AVI Infoframe. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 97 +++

[PATCH v3 4/9] drm/vc4: hdmi: Rename full range helper

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson The VC4 HDMI driver has a helper function to figure out whether full range or limited range RGB is being used called vc4_hdmi_is_full_range_rgb(). We'll need it to support other colorspaces, so let's rename it to vc4_hdmi_is_full_range(). Signed-off-by: Dave Stevenson Revi

[PATCH v3 5/9] drm/vc4: hdmi: Swap CSC matrix channels for YUV444

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson YUV444 and YUV422 actually require the same matrix, but programmed differently. We've dealt with it in the past by having two matrices, with the one for YUV444 reordered to accomodate the hardware. This gets in the way of subsequent reworks so let's define a function that w

[PATCH v3 6/9] drm/vc4: hdmi: Rework the CSC matrices organization

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson The CSC matrices were stored as separate matrix for each colorspace, and if we wanted a limited or full RGB output. This created some gaps in our support and we would not always pick the relevant matrix. Let's rework our data structure to store one per colorspace, and then

[PATCH v3 7/9] drm/vc4: hdmi: Add a function to retrieve the CSC matrix

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson The CSC matrix to use depends on the output format, its range and the colorspace. Since we're going to add more colorspaces, let's move the CSC matrix retrieval to a function. Signed-off-by: Dave Stevenson Reviewed-by: Thomas Zimmermann Signed-off-by: Maxime Ripard ---

[PATCH v3 8/9] drm/vc4: hdmi: Add BT.601 Support

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson Even though we report that we support the BT601 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT601 ones. Signed-off-by: Dave Stevenson Reviewed-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 38 ++

[PATCH v3 9/9] drm/vc4: hdmi: Add BT.2020 Support

2023-03-06 Thread Maxime Ripard
From: Dave Stevenson Even though we report that we support the BT.2020 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT.2020 ones. Signed-off-by: Dave Stevenson Reviewed-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3

Re: Linux 6.2.1 hits a display driver bug (list_del corruption, ffff88811b4af298->next is NULL)

2023-03-06 Thread Jani Nikula
On Sun, 05 Mar 2023, Ammar Faizi wrote: > On Fri, Mar 03, 2023 at 03:06:18PM +0700, Bagas Sanjaya wrote: >> Can you please try v6.1? > > It's reproducible in v6.1.9. I finally can reliably reproduce it, it > only happens when I start a VM with qemu. > > Specifically adding this device to the qemu

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-06 Thread Marek Szyprowski
Hi Jagan, On 04.03.2023 19:59, Jagan Teki wrote: > On Sat, Mar 4, 2023 at 3:56 AM Marek Szyprowski > wrote: >> On 03.03.2023 15:51, Jagan Teki wrote: >>> This series supports common bridge support for Samsung MIPI DSIM >>> which is used in Exynos and i.MX8MM SoC's. >>> >>> The final bridge suppor

Re: [PATCH 1/2] drm/i915/pmu: Use only freq bits for falling back to requested freq

2023-03-06 Thread Tvrtko Ursulin
On 04/03/2023 01:27, Ashutosh Dixit wrote: On newer generations, the GEN12_RPSTAT1 register contains more than freq information, e.g. see GEN12_VOLTAGE_MASK. Therefore use only the freq bits to decide whether to fall back to requested freq. Could you find an appropriate Fixes: tag please? If

Re: [PATCH] drm/i915: avoid flush_scheduled_work() usage

2023-03-06 Thread Jani Nikula
On Fri, 03 Mar 2023, Tetsuo Handa wrote: > On 2023/03/03 19:11, Tetsuo Handa wrote: >> @@ -79,6 +81,7 @@ static int __init i915_init(void) >> { >> int err, i; >> >> +i915_wq = alloc_workqueue("i915", 0, 0); > > Oops. I forgot to add > > if (!i915_wq) > return -ENOME

Re: [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC

2023-03-06 Thread Tvrtko Ursulin
On 04/03/2023 01:27, Ashutosh Dixit wrote: SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from Would it be more accurate to say 'SLPC does not use rps->cur_freq' rather than it not using struct intel_rps? Fixes: / stable ? CI chances of catching this? GEN6_RPNSWREQ for SLPC

Re: [PATCH] drm/i915: avoid flush_scheduled_work() usage

2023-03-06 Thread Tetsuo Handa
On 2023/03/06 20:05, Jani Nikula wrote: > On Fri, 03 Mar 2023, Tetsuo Handa wrote: >> On 2023/03/03 19:11, Tetsuo Handa wrote: >>> @@ -79,6 +81,7 @@ static int __init i915_init(void) >>> { >>> int err, i; >>> >>> + i915_wq = alloc_workqueue("i915", 0, 0); >> >> Oops. I forgot to add >> >>

Re: [PATCH v5 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-03-06 Thread Philipp Zabel
Hi Uwe, just a few nitpicks, see below. On Fri, Feb 10, 2023 at 07:00:14PM +0100, Uwe Kleine-König wrote: > From: Marian Cichy > > Add support for the LCD Controller found on i.MX21 and i.MX25. > > It targets to be a drop in replacement for the imx-fb driver. > > Signed-off-by: Marian Cichy

Re: (subset) [PATCH 2/2] ARM: dts: exynos: add ports to TC358764 bridge on Arndale

2023-03-06 Thread Krzysztof Kozlowski
On Sat, 25 Feb 2023 17:02:52 +0100, Krzysztof Kozlowski wrote: > The Toshiba TC358764 bridge binding expect up two ports as it is a > bridge, thus add ports property to encapsulate them. > > Applied, thanks! [2/2] ARM: dts: exynos: add ports to TC358764 bridge on Arndale https://git.kern

Re: [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher

2023-03-06 Thread Andy Shevchenko
On Fri, Mar 03, 2023 at 10:33:41PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate thos

Re: [PATCH v13 03/10] drm/display: Add Type-C switch helpers

2023-03-06 Thread Andy Shevchenko
On Fri, Mar 03, 2023 at 10:33:43PM +0800, Pin-yen Lin wrote: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "reg" propertie

Re: Linux 6.2.1 hits a display driver bug (list_del corruption, ffff88811b4af298->next is NULL)

2023-03-06 Thread Ammar Faizi
On Mon, Mar 06, 2023 at 12:54:59PM +0200, Jani Nikula wrote: > Please file a bug at fdo gitlab: > > https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-i915-bugs OK, I posted it here https://gitlab.freedesktop.org/drm/intel/-/issues/8274 Thanks, -- Ammar Faizi P.S: I had to create a ne

Re: [PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-06 Thread Andy Shevchenko
On Fri, Mar 03, 2023 at 10:33:45PM +0800, Pin-yen Lin wrote: > The output port endpoints can be connected to USB-C connectors. > Running drm_of_find_panel_or_bridge() with such endpoints leads to > a continuous return value of -EPROBE_DEFER, even though there is > no panel present. > > To avoid th

[PATCH v6 1/2] dt-bindings: display: imx: Describe drm binding for fsl, imx-lcdc

2023-03-06 Thread Uwe Kleine-König
Modify the existing (fb-like) binding to support the drm-like binding in parallel. Reviewed-by: Rob Herring Signed-off-by: Uwe Kleine-König --- .../bindings/display/imx/fsl,imx-lcdc.yaml| 46 ++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/Documentation/dev

[PATCH v6 2/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-03-06 Thread Uwe Kleine-König
From: Marian Cichy Add support for the LCD Controller found on i.MX21 and i.MX25. It targets to be a drop in replacement for the imx-fb driver. [ukl: Rebase to a newer kernel version, various smaller fixes and improvements] Signed-off-by: Marian Cichy Reviewed-by: Philipp Zabel Signed-off-by

[PATCH v6 0/2] drm/imx/lcdc: Implement DRM driver for imx25

2023-03-06 Thread Uwe Kleine-König
Hello, in response to Philipp's reply to v5 here comes a v6. The code changes are: | diff --git a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c b/drivers/gpu/drm/imx/lcdc/imx-lcdc.c | index c2197fc50306..24bc7b310367 100644 | --- a/drivers/gpu/drm/imx/lcdc/imx-lcdc.c | +++ b/drivers/gpu/drm/imx/lcdc/imx-l

Re: [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher

2023-03-06 Thread Sakari Ailus
Hi Pin-yen, Thanks for the update. On Fri, Mar 03, 2023 at 10:33:41PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allow

Re: [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-06 Thread Andy Shevchenko
On Fri, Mar 03, 2023 at 10:33:47PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant ports are available in Device Tree. Configure the crosspoint > switch based on the entered alternate mode for a specific Type-C > connector. > > Crosspoin

Re: [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-06 Thread Andy Shevchenko
On Fri, Mar 03, 2023 at 10:33:50PM +0800, Pin-yen Lin wrote: > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the "lane_swap" > state based on the entered alternate mode for a specific Type-C > connector, which ends up u

[PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Nirmoy Das
Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset for lmem objects. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/display/intel_dpt.c | 4 +++- drivers/gpu/drm/i915/display/intel_fbdev.c | 3 ++- driver

[PATCH 2/3] drm/i915: Add a helper func for gem obj mmap

2023-03-06 Thread Nirmoy Das
Move gem obj mmap code to i915_gem_object_mmap() so that this can be used by others. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 20 ++--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 25 ++ drivers/gpu/drm/i915/gem/i915_gem_mman.h

[PATCH RFC v2 3/3] drm/i915/display: Implement fb_mmap callback function

2023-03-06 Thread Nirmoy Das
If stolen memory allocation fails for fbdev, the driver will fallback to system memory. Calculation of smem_start is wrong for such framebuffer objs if the platform comes with no gmadr or no aperture. Solve this by adding fb_mmap callback which also gives driver more control. v2: Remove unused var

Re: [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Matthew Auld
On 06/03/2023 12:07, Nirmoy Das wrote: Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset for lmem objects. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/display/intel_dpt.c | 4 +++- drivers/gpu/drm/i915/di

Re: [PATCH 09/10] drm/msm: use drmm_mode_config_init()

2023-03-06 Thread Dmitry Baryshkov
On 06/03/2023 12:07, Johan Hovold wrote: Switch to using drmm_mode_config_init() so that the mode config is released when the last reference to the DRM device is dropped rather than unconditionally at unbind() (which may be too soon). This also means that drm_bridge_detach() might be called at

[PATCH 2/3] habanalabs/gaudi2: move soft-reset wait to soft-reset execute

2023-03-06 Thread Oded Gabbay
From: Dafna Hirschfeld We plan to do soft-reset either by mmio or by using cpucp packet depending on the FW version. We don't want to check FW version in two different places for that (execute soft-reset and wait to soft-reset) so move the waiting to gaudi2_execute_soft_reset. This also makes sen

[PATCH 1/3] habanalabs/gaudi2: add uapi to stall/resume engine

2023-03-06 Thread Oded Gabbay
From: Koby Elbaz The user might want to stall/resume engines to perform power testing for various scenarios. Because our current HL_CS_FLAGS_ENGINE_CORE_COMMAND command only handles the engines' cores, we need to add another opcode for handling entire engine and not just its core. The user suppl

[PATCH 3/3] habanalabs: postpone mem_mgr IDR destruction to hpriv_release()

2023-03-06 Thread Oded Gabbay
From: Tomer Tayar The memory manager IDR is currently destroyed when user releases the file descriptor. However, at this point the user context might be still held, and memory buffers might be still in use. Later on, calls to release those buffers will fail due to not finding their handles in the

[PATCH v2] drm/ttm: Change the meaning of the fields in the ttm_place structure from pfn to bytes

2023-03-06 Thread Somalapuram Amaranath
The ttm_plac structure allows page-based allocation, to support byte-based allocation using default or custom ttm_resource_manager_func function like ttm_range_man_alloc, amdgpu_gtt_mgr_new, i915_ttm_buddy_man_alloc,nouveau_vram_manager_new etc. Change the ttm_place structure member fpfn, lpfn, mem

Re: [PATCH 09/10] drm/msm: use drmm_mode_config_init()

2023-03-06 Thread Johan Hovold
On Mon, Mar 06, 2023 at 02:38:37PM +0200, Dmitry Baryshkov wrote: > On 06/03/2023 12:07, Johan Hovold wrote: > > Switch to using drmm_mode_config_init() so that the mode config is > > released when the last reference to the DRM device is dropped rather > > than unconditionally at unbind() (which ma

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Das, Nirmoy
Hi Matt, On 3/6/2023 1:25 PM, Matthew Auld wrote: On 06/03/2023 12:07, Nirmoy Das wrote: Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset for lmem objects. Signed-off-by: Nirmoy Das ---   drivers/gpu/drm/i915/display/inte

Re: [PATCH v6 0/4] drm/rockchip: dw_hdmi: Add 4k@30 support

2023-03-06 Thread Sascha Hauer
Hi, No negative feedback anymore, so I think this series should be merged now. Heiko, can you take these patches? I just noticed that I didn't Cc you on this series, I just added you for this mail. Please let me know if I should resend. Sascha On Thu, Feb 16, 2023 at 11:24:43AM +0100, Sascha Ha

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-06 Thread Danilo Krummrich
On 2/28/23 17:24, Liam R. Howlett wrote: * Danilo Krummrich [230227 21:17]: On Tue, Feb 21, 2023 at 01:20:50PM -0500, Liam R. Howlett wrote: * Danilo Krummrich [230217 08:45]: Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementati

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Matthew Auld
On 06/03/2023 13:31, Das, Nirmoy wrote: Hi Matt, On 3/6/2023 1:25 PM, Matthew Auld wrote: On 06/03/2023 12:07, Nirmoy Das wrote: Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset for lmem objects. Signed-off-by: Nirmoy Das

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Das, Nirmoy
On 3/6/2023 2:49 PM, Matthew Auld wrote: On 06/03/2023 13:31, Das, Nirmoy wrote: Hi Matt, On 3/6/2023 1:25 PM, Matthew Auld wrote: On 06/03/2023 12:07, Nirmoy Das wrote: Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER flag for it. This also make sure that ttm allocates offset

[PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-06 Thread Maarten Lankhorst
As a fallback if we decide not to merge the frontbuffer tracking, allow i915 to keep its own implementation, and do the right thing in Xe. The frontbuffer tracking for Xe is still done per-fb, while i915 can keep doing the weird intel_frontbuffer + i915_active thing without blocking Xe. Signed-of

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Set I915_BO_ALLOC_USER for framebuffer

2023-03-06 Thread Ville Syrjälä
On Mon, Mar 06, 2023 at 11:28:48AM +0100, Nirmoy Das wrote: > Framebuffer is exposed to userspace so set I915_BO_ALLOC_USER > flag for it. This also make sure that ttm allocates offset > for lmem objects. I have no idea what that means. > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i91

Re: [PATCH 2/3] drm/i915: Add a helper func for gem obj mmap

2023-03-06 Thread Ville Syrjälä
On Mon, Mar 06, 2023 at 11:28:49AM +0100, Nirmoy Das wrote: > Move gem obj mmap code to i915_gem_object_mmap() so that > this can be used by others. > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 20 ++--- > drivers/gpu/drm/i915/gem/i915_gem_mman.c

Re: [PATCH RFC 3/3] drm/i915/display: Implement fb_mmap callback function

2023-03-06 Thread Ville Syrjälä
On Mon, Mar 06, 2023 at 11:28:50AM +0100, Nirmoy Das wrote: > If stolen memory allocation fails for fbdev, the driver will > fallback to system memory. Calculation of smem_start is wrong > for such framebuffer objs if the platform comes with no gmadr or > no aperture. Solve this by adding fb_mmap c

[PATCH v2] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Dmitry Osipenko
VirtIO-GPU got a new config option for disabling KMS. There were two problems left unnoticed during review when the new option was added: 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was inverted, hence KMS was disabled when it should be enabled and vice versa. 2. The disabled K

Re: [PATCH v2] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Gerd Hoffmann
On Mon, Mar 06, 2023 at 05:32:34PM +0300, Dmitry Osipenko wrote: > VirtIO-GPU got a new config option for disabling KMS. There were two > problems left unnoticed during review when the new option was added: > > 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was > inverted, hence KM

Re: [PATCH 2/7] drm/gma500: Move fbdev code into separate source file

2023-03-06 Thread Patrik Jakobsson
On Thu, Feb 23, 2023 at 1:17 PM Thomas Zimmermann wrote: > > Move the fbdev emulation from framebuffer.c into fbdev.c. Only build > the source code if the Kconfig symbol has been selected. Remaining in > framebuffer.c is gma500's code for DRM frambuffers. No functional > hanges. > > Signed-off-by:

Re: [PATCH 5/7] drm/gma500: Inline psbfb_create() into psbfb_probe()

2023-03-06 Thread Patrik Jakobsson
On Thu, Feb 23, 2023 at 1:17 PM Thomas Zimmermann wrote: > > Inline psbfb_create() into its only caller psbfb_probe(). Streamline > the color-depth selection. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/gma500/fbdev.c | 65 ++ > 1 file changed, 26

Re: [PATCH 7/7] drm/gma500: Pass fb_info to psb_fbdev_vm_fault()

2023-03-06 Thread Patrik Jakobsson
On Thu, Feb 23, 2023 at 1:17 PM Thomas Zimmermann wrote: > > Instead of the DRM framebuffer, pass the FB info strcuture to the > fbdev page-fault handler psb_fbdev_vm_fault(). The framebuffer is a > high-level data structure and does not belong into fault handling. > The fb_info has all necessary

Re: [PATCH v2] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Emil Velikov
On 2023/03/06, Dmitry Osipenko wrote: > VirtIO-GPU got a new config option for disabling KMS. There were two > problems left unnoticed during review when the new option was added: > > 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was > inverted, hence KMS was disabled when it shou

RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-06 Thread Sripada, Radhakrishna
> -Original Message- > From: Andi Shyti > Sent: Friday, March 3, 2023 7:24 PM > To: Sripada, Radhakrishna > Cc: Andi Shyti ; intel-...@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org; Tvrtko Ursulin ; > Andi Shyti ; Patelczyk, Maciej > ; Wajdeczko, Michal > > Subject: Re:

Re: [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-06 Thread Souza, Jose
On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: > As a fallback if we decide not to merge the frontbuffer tracking, allow > i915 to keep its own implementation, and do the right thing in Xe. > > The frontbuffer tracking for Xe is still done per-fb, while i915 can > keep doing the weird

Re: [PATCH v28 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

2023-03-06 Thread Chun-Kuang Hu
Hi, Nancy: I've lost the v29 mail, so I reply in this mail for v29. I got some message by make dt_binding_check. /home/chunkuang/git/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.example.dtb: hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7, 16384, 4096, 42

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-03-06 Thread Danilo Krummrich
On 3/2/23 03:38, Liam R. Howlett wrote: * Danilo Krummrich [230227 08:17]: ... Would this variant be significantly more efficient? Well, what you are doing is walking the tree to see if there's anything there... then re-walking the tree to store it. So, yes, it's much more efficient.. Howe

Re: [PATCH v2] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-06 Thread Dmitry Osipenko
On 3/6/23 18:02, Emil Velikov wrote: > On 2023/03/06, Dmitry Osipenko wrote: >> VirtIO-GPU got a new config option for disabling KMS. There were two >> problems left unnoticed during review when the new option was added: >> >> 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was >> in

[PATCH 00/99] fbdev: Fix memory leak in option parsing

2023-03-06 Thread Thomas Zimmermann
Introduce struct option_iter and helpers to parse command-line options with comma-separated key-value pairs. Then convert fbdev drivers to the new interface. Fixes a memory leak in the parsing of the video= option. Before commit 73ce73c30ba9 ("fbdev: Transfer video= option strings to caller; clari

[PATCH 05/99] fbdev/acornfb: Parse option string with struct option_iter

2023-03-06 Thread Thomas Zimmermann
Use struct option_iter to walk over the individual options in the driver's option string. Replaces the hand-written strsep() loop with a clean interface. The helpers for struct option_iter handle empty option strings and empty options transparently. The struct's _init and _release functions duplica

[PATCH 02/99] fbdev/68328fb: Remove trailing whitespaces

2023-03-06 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/68328fb.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/68328fb.c b/drivers/video/fbdev/68328fb.c index 7db03ed77c76..7fe56ecbe4e6 100644 --- a

[PATCH 04/99] fbdev/acornfb: Only init fb_info once

2023-03-06 Thread Thomas Zimmermann
Init the fb_info instance once before parsing options. The current code initializes the instance once again after parsing options, which clears any resolution settings that have been given in the options string. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/acornfb.c | 5 + 1 file

[PATCH 06/99] fbdev/amifb: Duplicate video-mode option string

2023-03-06 Thread Thomas Zimmermann
Assume that the driver does not own the option string or its substrings and hence duplicate the option string for the video mode. The driver only parses the option string once as part of module initialization, so use a static buffer to store the duplicated mode option. Linux automatically free the

  1   2   3   >