Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-27 Thread Thomas Zimmermann
Hi Am 27.02.23 um 08:55 schrieb Asahi Lina: On 27/02/2023 16.45, Thomas Zimmermann wrote: Hi Am 25.02.23 um 22:51 schrieb Dmitry Osipenko: On 2/5/23 15:51, Asahi Lina wrote: -EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt); +EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt); Note it was a GPL symb

Re: [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-27 Thread Thomas Hellström
Hi, On 2/23/23 19:50, Alex Deucher wrote: On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström wrote: Hi, Daniel, On 2/16/23 21:18, Daniel Vetter wrote: On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: A slightly unusual cover letter for a single patch. The page table walker

Re: [PATCH 0/1] drm: Add a gpu page-table walker

2023-02-27 Thread Thomas Hellström
Hi, Oded. On 2/26/23 19:56, Oded Gabbay wrote: On Thu, Feb 23, 2023 at 8:50 PM Alex Deucher wrote: On Thu, Feb 23, 2023 at 10:03 AM Thomas Hellström wrote: Hi, Daniel, On 2/16/23 21:18, Daniel Vetter wrote: On Thu, Feb 16, 2023 at 05:27:28PM +0100, Thomas Hellström wrote: A slightly unusu

Re: [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Thomas Hellström
Daniel, Dave Ack to merge this to drm through drm-misc-next? /Thomas On 2/24/23 10:51, Thomas Hellström wrote: This series (or at least the suballocator helper) is a prerequisite for the new Xe driver. There was an unresolved issue when the series was last up for review, and that was the per

Re: [PATCH] MAINTAINERS: Add myself as co-maintainer for DRM Panels drivers

2023-02-27 Thread Neil Armstrong
Hi Sam ! On 17/02/2023 11:45, Sam Ravnborg wrote: On Fri, Feb 17, 2023 at 10:58:15AM +0100, Neil Armstrong wrote: Add myself as co-maintainer for DRM Panel Drivers in order to help reviewing and getting new panels drivers merged. Signed-off-by: Neil Armstrong Thanks for stepping up! Acked-

Re: [PATCH v11 05/10] drm/shmem-helper: Add memory shrinker

2023-02-27 Thread kernel test robot
Hi Dmitry, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree

Re: [PATCH v11 05/10] drm/shmem-helper: Add memory shrinker

2023-02-27 Thread kernel test robot
Hi Dmitry, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [cannot apply to drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree

Re: [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Thomas Hellström
Hi, Maarten, On 2/27/23 09:55, Maarten Lankhorst wrote: Hey, I can push this to drm-misc-next, I don't think a drm maintainer ack is needed, as long as we have the acks from the amd folk for merging through drm-misc-next. OK, sound good, we have that ack so please go ahead! /Thomas ~Ma

Re: [PATCH] drm: omapdrm: Do not use helper unininitialized in omap_fbdev_init()

2023-02-27 Thread Thomas Zimmermann
Hi Am 24.02.23 um 18:25 schrieb Nathan Chancellor: Clang warns (or errors with CONFIG_WERROR): ../drivers/gpu/drm/omapdrm/omap_fbdev.c:235:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!fbdev)

[PATCH] drm/shmem-helper: Revert accidental non-GPL export

2023-02-27 Thread Asahi Lina
_pages_sgt); /** * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from --- base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f change-id: 20230227-shmem-export-fix-85fde1351104 Thank you, ~~ Lina

Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export

2023-02-27 Thread Thomas Zimmermann
ages_sgt(struct drm_gem_shmem_object *shmem) return sgt; } -EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt); +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt); /** * drm_gem_shmem_prime_import_sg_table - Produce a shmem GEM object from --- base-commit: f3a2439f20d918930cc4ae8f76fe1c1afd26958f chan

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-27 Thread Asahi Lina
On 27/02/2023 17.04, Thomas Zimmermann wrote: > Hi > > Am 27.02.23 um 08:55 schrieb Asahi Lina: >> On 27/02/2023 16.45, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 25.02.23 um 22:51 schrieb Dmitry Osipenko: On 2/5/23 15:51, Asahi Lina wrote: > -EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt

Re: [PATCH AUTOSEL 6.2 18/60] drm/msm/dp: Remove INIT_SETUP delay

2023-02-27 Thread Johan Hovold
On Sun, Feb 26, 2023 at 09:00:03PM -0500, Sasha Levin wrote: > From: Bjorn Andersson > > [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] > > During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP > event is generated, but with a delay of 100 units. This delay existe

Re: [PATCH AUTOSEL 6.1 18/58] drm/msm/dp: Remove INIT_SETUP delay

2023-02-27 Thread Johan Hovold
On Sun, Feb 26, 2023 at 09:04:16PM -0500, Sasha Levin wrote: > From: Bjorn Andersson > > [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] > > During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP > event is generated, but with a delay of 100 units. This delay existe

Re: [PATCH] drm/shmem-helper: Revert accidental non-GPL export

2023-02-27 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 27.02.23 um 10:04 schrieb Asahi Lina: >> The referenced commit added a wrapper for drm_gem_shmem_get_pages_sgt(), >> but in the process it accidentally changed the export type from GPL to >> non-GPL. Switch it back to GPL. >> >> Reported-by: Dmitry Osipenko

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-27 Thread Thomas Zimmermann
Hi Am 27.02.23 um 10:07 schrieb Asahi Lina: On 27/02/2023 17.04, Thomas Zimmermann wrote: Hi Am 27.02.23 um 08:55 schrieb Asahi Lina: On 27/02/2023 16.45, Thomas Zimmermann wrote: Hi Am 25.02.23 um 22:51 schrieb Dmitry Osipenko: On 2/5/23 15:51, Asahi Lina wrote: -EXPORT_SYMBOL_GPL(drm_ge

[PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread Yuanzhi Wang
When the laptop is plugged into AC or DC power supply, the brightness obtained ACPI may be smaller than current brightness.As a result the screen becomes dark,this is not what people want. Signed-off-by: Yuanzhi Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 9 - 1 file changed, 8 i

Re: [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Maarten Lankhorst
Hey, I can push this to drm-misc-next, I don't think a drm maintainer ack is needed, as long as we have the acks from the amd folk for merging through drm-misc-next. ~Maarten On 2023-02-27 09:11, Thomas Hellström wrote: Daniel, Dave Ack to merge this to drm through drm-misc-next? /Thomas

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-27 Thread Pekka Paalanen
On Fri, 24 Feb 2023 11:44:53 -0800 Rob Clark wrote: > On Fri, Feb 24, 2023 at 2:24 AM Pekka Paalanen wrote: > > > > On Fri, 24 Feb 2023 09:41:46 + > > Tvrtko Ursulin wrote: > > > > > On 24/02/2023 09:26, Pekka Paalanen wrote: > > > > On Thu, 23 Feb 2023 10:51:48 -0800 > > > > Rob Clark

Re: [PATCH v7 1/7] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-02-27 Thread Jani Nikula
On Sun, 26 Feb 2023, Siddh Raman Pant wrote: > Comments say macros DRM_DEBUG_* are deprecated in favor of > drm_dbg_*(NULL, ...), but they have broken support for it, > as the macro will result in `(NULL) ? (NULL)->dev : NULL`. > > Thus, fix them by separating logic to get dev ptr in a new > funct

Re: [Intel-gfx] [PATCH v5 1/7] arch: rename all internal names __xchg to __arch_xchg

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:44PM +0100, Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann > Acked-by: Geert Uytterhoeven [m68k] > Acked-by: Palmer Dabbelt [riscv] Reviewed-by: Andi Shyti Thanks,

Re: [Intel-gfx] [PATCH v5 2/7] linux/include: add non-atomic version of xchg

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:45PM +0100, Andrzej Hajda wrote: > The pattern of setting variable with new value and returning old > one is very common in kernel. Usually atomicity of the operation > is not required, so xchg seems to be suboptimal and confusing in > such cases. > > Sig

Re: [Intel-gfx] [PATCH v5 3/7] arch/*/uprobes: simplify arch_uretprobe_hijack_return_addr

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:46PM +0100, Andrzej Hajda wrote: > In all architectures, except x86, arch_uretprobe_hijack_return_addr > is just __xchg. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 4/7] llist: simplify __llist_del_all

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:47PM +0100, Andrzej Hajda wrote: > llist_del_all uses xchg, let's use __xchg here. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [RESEND PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-02-27 Thread Jani Nikula
On Tue, 14 Feb 2023, Arun R Murthy wrote: > Enable SDP error detection configuration, this will set CRC16 in > 128b/132b link layer. > For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is > added to enable/disable SDP CRC applicable for DP2.0 only, but the > default value of this b

Re: [Intel-gfx] [PATCH v5 6/7] qed: use __xchg if possible

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:49PM +0100, Andrzej Hajda wrote: > Recently introduced helper simplifies the code. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 7/7] drm/i915/gt: use __xchg instead of internal helper

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:50PM +0100, Andrzej Hajda wrote: > Prefer core helper if available. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

Re: [Intel-gfx] [PATCH v5 5/7] io_uring: use __xchg if possible

2023-02-27 Thread Andi Shyti
Hi Andrzej, On Wed, Jan 18, 2023 at 04:44:48PM +0100, Andrzej Hajda wrote: > Recently introduced helper simplifies the code. > > Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Thanks, Andi

[PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Dan Carpenter
The drmm_encoder_alloc() function returns error pointers. It never returns NULL. Fix the check accordingly. Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage encoder") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 4 ++-- 1 file changed, 2 in

[PATCH] fbdev: chipsfb: Fix error codes in chipsfb_pci_init()

2023-02-27 Thread Dan Carpenter
The error codes are not set on these error paths. Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") Signed-off-by: Dan Carpenter --- drivers/video/fbdev/chipsfb.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/chipsfb.c

[PATCH] drm/mediatek: dsi: fix error codes in mtk_dsi_host_transfer()

2023-02-27 Thread Dan Carpenter
There is a type bug because the return statement: return ret < 0 ? ret : recv_cnt; will not return negatives on 64bit systems. The problem is that the function returns ssize_t types, while "ret" is int and "recv_cnt" is a u32. The negative values are type promoted to u32 and returned as

Re: [PATCH] fbdev: chipsfb: Fix error codes in chipsfb_pci_init()

2023-02-27 Thread Thomas Zimmermann
Hi Am 27.02.23 um 11:07 schrieb Dan Carpenter: The error codes are not set on these error paths. Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann with the comments below addressed. --- drivers/video/fbdev/c

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PULL] drm-intel-next-fixes

2023-02-27 Thread Jani Nikula
Hi Dave & Daniel - Some more fixes for v6.3-rc1. drm-intel-next-fixes-2023-02-27: drm/i915 fixes for v6.3-rc1: - Don't use stolen memory or BAR mappings for ring buffers with LLC - Add inverted backlight quirk for HP 14-r206nv - Fix GSI offset for MCR lookups - GVT fixes (memleak, debugfs attri

Re: amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-02-27 Thread Christian König
Am 24.02.23 um 17:21 schrieb Mikhail Gavrilov: On Fri, Feb 24, 2023 at 8:31 PM Christian König wrote: Sorry I totally missed that you attached the full dmesg to your original mail. Yeah, the driver did fail gracefully. But then X doesn't come up and then gdm just dies. Are you sure that these

[PATCH v2] fbdev: chipsfb: Fix error codes in chipsfb_pci_init()

2023-02-27 Thread Dan Carpenter
The error codes are not set on these error paths. Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann --- v2: I accidentally returned -EINVAL instead -ENODEV. Add Thomas's Reviewed-by tag. drivers/video/fbdev/chip

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-27 Thread Jani Nikula
On Mon, 27 Feb 2023, Dmitry Osipenko wrote: > On 2/17/23 16:41, Dmitry Osipenko wrote: >> On 2/17/23 16:28, Thomas Zimmermann wrote: >>> Hi, >>> >>> I looked through the series. Most of the patches should have an r-b or >>> a-b at this point. I can't say much about patch 2 and had questions >>> ab

Re: [PATCH 1/5] drm/msm/adreno: Use OPP for every GPU generation

2023-02-27 Thread Konrad Dybcio
On 24.02.2023 17:56, Chris Healy wrote: > I may be missing something, but looking at the code path for a2xx, > it's not clear to me how this would work with SoCs with a2xx that > don't support 200MHz for GPU frequency. For example, the NXP i.MX51 > requires the A205 GPU to run at 166MHz while t

Re: [PATCH v3 1/2] drm/edid: parse DRM VESA dsc bpp target

2023-02-27 Thread Jani Nikula
On Sun, 26 Feb 2023, Yaroslav Bolyukin wrote: > As per DisplayID v2.0 Errata E9 spec "DSC pass-through timing support" > VESA vendor-specific data block may contain target DSC bits per pixel > fields > > Signed-off-by: Yaroslav Bolyukin > --- > drivers/gpu/drm/drm_edid.c | 38 ++

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-27 Thread Dmitry Osipenko
On 2/27/23 13:37, Jani Nikula wrote: > On Mon, 27 Feb 2023, Dmitry Osipenko wrote: >> On 2/17/23 16:41, Dmitry Osipenko wrote: >>> On 2/17/23 16:28, Thomas Zimmermann wrote: Hi, I looked through the series. Most of the patches should have an r-b or a-b at this point. I can't sa

Re: [PATCH v11 05/10] drm/shmem-helper: Add memory shrinker

2023-02-27 Thread Dmitry Osipenko
On 2/27/23 11:25, kernel test robot wrote: > All errors (new ones prefixed by >>): > >drivers/gpu/drm/drm_gem_shmem_helper.c:832:18: warning: no previous > prototype for function 'drm_gem_shmem_get_pages_sgt_locked' > [-Wmissing-prototypes] >struct sg_table *drm_gem_shmem_get_pages_sgt_l

Re: [PATCH v2] fbdev: chipsfb: Fix error codes in chipsfb_pci_init()

2023-02-27 Thread Thomas Zimmermann
Hi Am 27.02.23 um 11:33 schrieb Dan Carpenter: The error codes are not set on these error paths. Fixes: 145eed48de27 ("fbdev: Remove conflicting devices on PCI bus") Signed-off-by: Dan Carpenter Reviewed-by: Thomas Zimmermann --- v2: I accidentally returned -EINVAL instead -ENODEV. Add T

[PATCH 1/6] habanalabs: add helper function to get vm hash node

2023-02-27 Thread Oded Gabbay
From: Tomer Tayar Add a helper function to search the vm hash for a node with a given virtual address. As opposed to the current code, this function explicitly returns NULL when no node is found, instead of basing on the loop cursor object's value. Signed-off-by: Tomer Tayar Reviewed-by: Oded G

[PATCH 2/6] habanalabs: add device id to all threads names

2023-02-27 Thread Oded Gabbay
From: Sagiv Ozeri Compute driver threads names will start with hlX-*, when X is the device id. This will help distinguish them from the NIC thread names. Signed-off-by: Sagiv Ozeri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/device.c | 20 +

[PATCH 3/6] habanalabs/gaudi2: break is_idle function into per-engine sub-routines

2023-02-27 Thread Oded Gabbay
From: Koby Elbaz is_idle() was too long, so break it up for readability. In addition, we can now use the new sub-routines from other places. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 212 --

[PATCH 5/6] habanalabs: use notifications and graceful reset for decoder

2023-02-27 Thread Oded Gabbay
From: Tomer Tayar Add notifications to user in case of decoder abnormal interrupts, and use the graceful reset mechanism if reset is required. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/common/decoder.c | 22 ---

[PATCH 6/6] habanalabs/gaudi2: verify return code after scrubbing ARCs DCCMs

2023-02-27 Thread Oded Gabbay
From: Koby Elbaz In case the KDMA fails scrubbing the DCCMs (following a soft-reset upon device release), the driver will only print failure until reset flow ends, rather than escalating it into a hard-reset. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- d

[PATCH 4/6] habanalabs: assert return value of hw_fini

2023-02-27 Thread Oded Gabbay
From: Dafna Hirschfeld Since hw_fini return error code for failure indication, we should check its return value. Currently it might only fail upon soft-reset from hl_device_reset. Later patch will add hw_fini failure in case of polling timeout in hard-reset. Signed-off-by: Dafna Hirschfeld Revi

Re: [RESEND PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper

2023-02-27 Thread Jagan Teki
On Fri, Feb 3, 2023 at 4:34 PM Maxime Ripard wrote: > > On Fri, Feb 03, 2023 at 04:28:30PM +0530, Jagan Teki wrote: > > On Fri, Feb 3, 2023 at 4:19 PM Maxime Ripard wrote: > > > > > > On Fri, Feb 03, 2023 at 04:13:49PM +0530, Jagan Teki wrote: > > > > On Fri, Feb 3, 2023 at 1:56 PM Maxime Ripard

Re: [PATCH] drm/i915: Set wedged if enable guc communication failed

2023-02-27 Thread Jani Nikula
On Fri, 24 Feb 2023, Zhanjun Dong wrote: > Add err code check for enable_communication on resume path, set wedged if > failed. I can see that this is *what* the code does, but the commit message should answer the question *why*. > > Signed-off-by: Zhanjun Dong > --- > drivers/gpu/drm/i915/gt/

Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Kieran Bingham
Quoting Dan Carpenter (2023-02-27 10:06:59) > The drmm_encoder_alloc() function returns error pointers. It never > returns NULL. Fix the check accordingly. Yes, indeed. Thanks. Reviewed-by: Kieran Bingham > > Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage > encoder")

[PATCH v13 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-27 Thread Jagan Teki
This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. Patch 0001 - 0004: find child DSI bridge and panel Patch 0005 - 0006: optional PHY, PMS_P offset Patch 0007 : in

[PATCH v13 01/18] drm: of: Lookup if child node has DSI panel or bridge

2023-02-27 Thread Jagan Teki
Devices can also be child nodes when we also control that device through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). Unlike the drm_of_find_panel_or_bridge helper it requires a special case to lookup a child node of the given parent that isn't either port or ports. Lookup for a chil

[PATCH v13 02/18] drm: bridge: panel: Support nodrm case for drmm_panel_bridge_add

2023-02-27 Thread Jagan Teki
drmm_panel_bridge_add DRM-managed action helper is useful for the bridge which automatically removes the bridge when drm pointer is cleaned. Supporting the same on non-component bridges like host DSI bridge requires a drm pointer which is indeed available only when a panel-bridge is found. For th

[PATCH v13 03/18] drm: exynos: dsi: Drop explicit call to bridge detach

2023-02-27 Thread Jagan Teki
Exynos DSI already converted into a bridge driver, so bridge detach will suppose happened during bridge chain removal done by the bridge core. Drop the explicit call chain to detach the bridge. Signed-off-by: Jagan Teki --- Changes for v13, v12, v11: - none Changes for v10: - new patch drivers

[PATCH v13 04/18] drm: exynos: dsi: Switch to DSI panel or bridge find helper

2023-02-27 Thread Jagan Teki
drm_of_dsi_find_panel_or_bridge is capable of looking up the downstream DSI bridge and panel and trying to add a panel bridge if the panel is found. Replace explicit finding calls with drm_of_dsi_find_panel_or_bridge followed with drmm_panel_bridge_add. Signed-off-by: Jagan Teki --- Changes for

[PATCH v13 05/18] drm: exynos: dsi: Mark PHY as optional

2023-02-27 Thread Jagan Teki
The same Samsung MIPI DSIM master can also be used in NXP's i.MX8M Mini/Nano/Plus SoC. In i.MX8M Mini/Nano/Plus SoC the DSI Phy requires a MIPI DPHY bit to reset in order to activate the PHY and that can be done via upstream i.MX8M blk-ctrl driver. So, mark the phy get as optional. Reviewed-by:

[PATCH v13 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset

2023-02-27 Thread Jagan Teki
Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but t

[PATCH v13 07/18] drm: exynos: dsi: Introduce hw_type platform data

2023-02-27 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano/Plus. Add hw_type enum via platform_data so that accessing the different controller data between various platforms becomes easy and meaningful. Reviewed-by: Marek Vasut Reviewed-by: Fried

[PATCH v13 08/18] drm: exynos: dsi: Handle proper host initialization

2023-02-27 Thread Jagan Teki
From: Marek Szyprowski Host transfer() in the DSI master will invoke only when the DSI commands are sent from DSI devices like DSI Panel or DSI bridges and this host the transfer wouldn't invoke for I2C-based-DSI bridge drivers. Handling DSI host initialization in transfer calls misses the contr

[PATCH v13 09/18] drm: exynos: dsi: Add atomic check

2023-02-27 Thread Jagan Teki
Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work proper

[PATCH v13 10/18] drm: exynos: dsi: Add input_bus_flags

2023-02-27 Thread Jagan Teki
LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano

[PATCH v13 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts

2023-02-27 Thread Jagan Teki
Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the

[PATCH v13 12/18] drm: exynos: dsi: Consolidate component and bridge

2023-02-27 Thread Jagan Teki
DSI host registration, attach and detach operations are quite different for the component and bridge-based DRM drivers.  Supporting generic bridge driver to use both component and bridge based DRM drivers can be tricky and would require additional host related operation hooks. Add host operation

[PATCH v13 13/18] drm: exynos: dsi: Add host helper for te_irq_handler

2023-02-27 Thread Jagan Teki
IRQ handler for te-gpio seems to be common across DSIM host. However, Exynos is handling this via CRTC drivers but there is no clear evidence on how the same has been handled in i.MX8MM. Keeping the handler as-it-is can be a viable option but adding DSIM bridge core in upcoming patches is not poss

[PATCH v13 14/18] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge

2023-02-27 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano. In order to access this DSI controller between various platform SoCs, the ideal way to incorporate this in the drm stack is via the drm bridge driver. We already have a consolidated code

[PATCH v13 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support

2023-02-27 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8M Mini/Nano SoC. Add dt-bingings for it. Reviewed-by: Marek Vasut Acked-by: Rob Herring Signed-off-by: Jagan Teki --- Changes for v13: - none Changes for v12: - collect RB from Marek Changes for v11, v10, v9: - none Changes for v8: - add comme

[PATCH v13 16/18] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support

2023-02-27 Thread Jagan Teki
Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. Add compatible and associated driver_data for it. Reviewed-by: Marek Vasut Reviewed-by: Frieder Schrempf Acked-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- Chan

[PATCH v13 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support

2023-02-27 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8M Plus SoC. Add dt-bingings for it. Reviewed-by: Marek Vasut Acked-by: Rob Herring Signed-off-by: Jagan Teki --- Changes for v13: - none Changes for v12: - collect RB from Marek Changes for v11: - collect ACK from Rob Changes for v10, v9: - no

[PATCH v13 18/18] drm: bridge: samsung-dsim: Add i.MX8M Plus support

2023-02-27 Thread Jagan Teki
From: Marek Vasut Add extras to support i.MX8M Plus. The main change is the removal of HS/VS/DE signal inversion in the LCDIFv3-DSIM glue logic, otherwise the implementation of this IP in i.MX8M Plus is very much compatible with the i.MX8M Mini/Nano one. Reviewed-by: Marek Vasut Reviewed-by: Fr

Re: [PATCH 1/3] drm/i915: Separate wakeref tracking

2023-02-27 Thread Jani Nikula
On Fri, 24 Feb 2023, Andrzej Hajda wrote: > From: Chris Wilson > > Extract the callstack tracking of intel_runtime_pm.c into its own > utility so that that we can reuse it for other online debugging of > scoped wakerefs. > > Signed-off-by: Chris Wilson > Signed-off-by: Andrzej Hajda > --- > dr

Re: [PATCH] media: Fix building pdfdocs

2023-02-27 Thread Akira Yokosawa
Hi Mauro, On Sun, 26 Feb 2023 11:47:44 +0100, Mauro Carvalho Chehab wrote: > Em Sun, 26 Feb 2023 08:39:32 +0900 > Akira Yokosawa escreveu: > >> [+CC: Jon, linux-doc] >> >> On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote: >>> Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") adde

Re: [PATCH v13 02/18] drm: bridge: panel: Support nodrm case for drmm_panel_bridge_add

2023-02-27 Thread Maxime Ripard
On Mon, Feb 27, 2023 at 05:09:09PM +0530, Jagan Teki wrote: > drmm_panel_bridge_add DRM-managed action helper is useful for the bridge > which automatically removes the bridge when drm pointer is cleaned. > > Supporting the same on non-component bridges like host DSI bridge requires > a drm pointe

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

[PATCH] drm: document TV margin properties

2023-02-27 Thread Simon Ser
Add docs for "{left,right,top,bottom} margin" properties. Signed-off-by: Simon Ser Cc: Maxime Ripard Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Noralf Trønnes Cc: Mateusz Kwiatkowski --- drivers/gpu/drm/drm_connector.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) dif

[PATCH] drm: remove outdated doc TODO for subconnector property

2023-02-27 Thread Simon Ser
This is already documented under "standard connector properties". Signed-off-by: Simon Ser Cc: Maxime Ripard Cc: Daniel Vetter Cc: Pekka Paalanen Cc: Noralf Trønnes Cc: Mateusz Kwiatkowski --- drivers/gpu/drm/drm_connector.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm: document TV margin properties

2023-02-27 Thread Maxime Ripard
On Mon, Feb 27, 2023 at 12:21:16PM +, Simon Ser wrote: > Add docs for "{left,right,top,bottom} margin" properties. > > Signed-off-by: Simon Ser > Cc: Maxime Ripard > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Noralf Trønnes > Cc: Mateusz Kwiatkowski Acked-by: Maxime Ripard Maxime

Re: [PATCH] drm: remove outdated doc TODO for subconnector property

2023-02-27 Thread Maxime Ripard
On Mon, Feb 27, 2023 at 12:25:26PM +, Simon Ser wrote: > This is already documented under "standard connector properties". > > Signed-off-by: Simon Ser > Cc: Maxime Ripard > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Noralf Trønnes > Cc: Mateusz Kwiatkowski Acked-by: Maxime Ripard M

Re: [PATCH v13 02/18] drm: bridge: panel: Support nodrm case for drmm_panel_bridge_add

2023-02-27 Thread Jagan Teki
On Mon, Feb 27, 2023 at 5:41 PM Maxime Ripard wrote: > > On Mon, Feb 27, 2023 at 05:09:09PM +0530, Jagan Teki wrote: > > drmm_panel_bridge_add DRM-managed action helper is useful for the bridge > > which automatically removes the bridge when drm pointer is cleaned. > > > > Supporting the same on n

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Dmitry Baryshkov
On Mon, 27 Feb 2023 at 02:15, Abhinav Kumar wrote: > > > > On 2/26/2023 5:13 AM, Dmitry Baryshkov wrote: > > On 26/02/2023 02:16, Abhinav Kumar wrote: > >> Hi Dmitry > >> > >> On 2/24/2023 3:57 PM, Dmitry Baryshkov wrote: > >>> On Sat, 25 Feb 2023 at 01:51, Kuogee Hsieh > >>> wrote: > >

[PATCH] drm/vram-helper: fix typos in vram helper doc

2023-02-27 Thread Luc Ma
Fixes: a5f23a72355d ("drm/vram-helper: Managed vram helpers") Signed-off-by: Luc Ma --- drivers/gpu/drm/drm_gem_vram_helper.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index d40b3edb52d0

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Dmitry Baryshkov
On Mon, 27 Feb 2023 at 01:49, Abhinav Kumar wrote: > > > > On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: > > On 26/02/2023 02:47, Abhinav Kumar wrote: > >> Hi Dmitry > >> > >> On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: > >>> On 25/02/2023 02:36, Abhinav Kumar wrote: > > > On 2/24

Re: [RFC PATCH 00/20] Initial Xe driver submission

2023-02-27 Thread Oded Gabbay
On Fri, Feb 17, 2023 at 10:51 PM Daniel Vetter wrote: > > Hi all, > > [I thought I've sent this out earlier this week, but alas got stuck, kinda > bad timing now since I'm out next week but oh well] > > So xe is a quite substantial thing, and I think we need a clear plan how to > land > this or i

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-27 Thread Jani Nikula
On Sun, 26 Feb 2023, Abhinav Kumar wrote: > On 2/26/2023 5:09 AM, Dmitry Baryshkov wrote: >> On 26/02/2023 02:47, Abhinav Kumar wrote: >>> Hi Dmitry >>> >>> On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: On 25/02/2023 02:36, Abhinav Kumar wrote: > > > On 2/24/2023 3:53 PM, Dmitry B

Re: [Intel-xe] [PATCH v4 0/3] drm/helpers: Make the suballocation manager drm generic

2023-02-27 Thread Christian König
Am 27.02.23 um 10:00 schrieb Thomas Hellström: Hi, Maarten, On 2/27/23 09:55, Maarten Lankhorst wrote: Hey, I can push this to drm-misc-next, I don't think a drm maintainer ack is needed, as long as we have the acks from the amd folk for merging through drm-misc-next. OK, sound good, we h

Re: [PATCH] drm/vram-helper: fix typos in vram helper doc

2023-02-27 Thread Thomas Zimmermann
Hi thanks for the fix. A few things could be improved. The subject line should say 'fix function names' instead of 'fix typos'. The patch also deserves at least a minimal description if the change. Something like 'Refer to drmm_vram_helper_init() instead of the non-existent drmm_vram_helper_a

Re: [PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-27 Thread Danilo Krummrich
On 2/23/23 20:09, Liam R. Howlett wrote: * Danilo Krummrich [230222 13:13]: On 2/21/23 19:20, Liam R. Howlett wrote: * Danilo Krummrich [230217 08:45]: Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivate

Re: [PATCH v3 04/11] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC

2023-02-27 Thread AngeloGioacchino Del Regno
Il 24/02/23 11:08, Chen-Yu Tsai ha scritto: On Thu, Feb 23, 2023 at 9:34 PM AngeloGioacchino Del Regno wrote: The MediaTek MT8195 SoC has a Mali G57 MC5 (Valhall-JM) and has the same number of power domains and requirements as MT8192 in terms of bindings. Signed-off-by: AngeloGioacchino Del R

Re: [PATCH v13 02/18] drm: bridge: panel: Support nodrm case for drmm_panel_bridge_add

2023-02-27 Thread Jagan Teki
On Mon, Feb 27, 2023 at 5:41 PM Maxime Ripard wrote: > > On Mon, Feb 27, 2023 at 05:09:09PM +0530, Jagan Teki wrote: > > drmm_panel_bridge_add DRM-managed action helper is useful for the bridge > > which automatically removes the bridge when drm pointer is cleaned. > > > > Supporting the same on n

Re: [PATCH] media: Fix building pdfdocs

2023-02-27 Thread Tomi Valkeinen
On 27/02/2023 14:06, Akira Yokosawa wrote: Hi Mauro, On Sun, 26 Feb 2023 11:47:44 +0100, Mauro Carvalho Chehab wrote: Em Sun, 26 Feb 2023 08:39:32 +0900 Akira Yokosawa escreveu: [+CC: Jon, linux-doc] On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote: Commit 8d0e3fc61abd ("media: Add

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread kernel test robot
Hi Yuanzhi, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.2 next-20230227] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '-

Re: [PATCH] drm: omapdrm: Do not use helper unininitialized in omap_fbdev_init()

2023-02-27 Thread Tomi Valkeinen
On 27/02/2023 11:01, Thomas Zimmermann wrote: Hi Am 24.02.23 um 18:25 schrieb Nathan Chancellor: Clang warns (or errors with CONFIG_WERROR):    ../drivers/gpu/drm/omapdrm/omap_fbdev.c:235:6: error: variable 'helper' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-u

Re: [Intel-gfx] [PATCH v5 0/7] Introduce __xchg, non-atomic xchg

2023-02-27 Thread Peter Zijlstra
On Thu, Feb 23, 2023 at 10:24:19PM +0100, Andrzej Hajda wrote: > On 22.02.2023 18:04, Peter Zijlstra wrote: > > On Wed, Jan 18, 2023 at 04:35:22PM +0100, Andrzej Hajda wrote: > > > > > Andrzej Hajda (7): > > >arch: rename all internal names __xchg to __arch_xchg > > >linux/include: add non

Re: [PATCH] drm: document TV margin properties

2023-02-27 Thread Dave Stevenson
On Mon, 27 Feb 2023 at 12:21, Simon Ser wrote: > > Add docs for "{left,right,top,bottom} margin" properties. > > Signed-off-by: Simon Ser > Cc: Maxime Ripard > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Noralf Trønnes > Cc: Mateusz Kwiatkowski This certainly matches my understanding of th

Re: [PATCH] amdgpu: add a filter condition when set brightness

2023-02-27 Thread Mario Limonciello
On 2/27/23 01:39, Yuanzhi Wang wrote: When the laptop is plugged into AC or DC power supply, the brightness obtained ACPI may be smaller than current brightness.As a result the screen becomes dark,this is not what people want. Do you have a matching bug report with more information included?

[PATCH] drm/edid: Fix csync detailed mode parsing

2023-02-27 Thread Ville Syrjala
From: Ville Syrjälä Remove the bogus csync check and replace it with something that: - triggers for all forms of csync, not just the basic analog variant - actually populates the mode csync flags so that drivers can decide what to do with the mode Originally the code tried to outright reject c

Re: [PATCH] drm: rcar-du: Fix a NULL vs IS_ERR() bug

2023-02-27 Thread Laurent Pinchart
Hi Dan, Thank you for the patch. On Mon, Feb 27, 2023 at 01:06:59PM +0300, Dan Carpenter wrote: > The drmm_encoder_alloc() function returns error pointers. It never > returns NULL. Fix the check accordingly. > > Fixes: 7a1adbd23990 ("drm: rcar-du: Use drmm_encoder_alloc() to manage > encoder"

Re: [PATCH 0/4] drm/displayid: use primary use case to figure out non-desktop

2023-02-27 Thread Jani Nikula
On Mon, 27 Feb 2023, Dmitry Osipenko wrote: > On 2/21/23 19:29, Dmitry Osipenko wrote: >> On 2/20/23 18:44, Dmitry Osipenko wrote: >>> On 2/16/23 23:44, Jani Nikula wrote: Mostly this is prep work and plumbing for easier use of displayid structure version and primary use case for parsing

Re: [PATCH v13 12/18] drm: exynos: dsi: Consolidate component and bridge

2023-02-27 Thread Marek Vasut
On 2/27/23 12:39, Jagan Teki wrote: [...] @@ -1733,11 +1728,67 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) return 0; } +static int _exynos_dsi_host_attach(struct exynos_dsi *dsim, I didn't notice it before, but please get rid of those leading underscores in functio

Re: [PATCH v13 13/18] drm: exynos: dsi: Add host helper for te_irq_handler

2023-02-27 Thread Marek Vasut
On 2/27/23 12:39, Jagan Teki wrote: IRQ handler for te-gpio seems to be common across DSIM host. However, Exynos is handling this via CRTC drivers but there is no clear evidence on how the same has been handled in i.MX8MM. Keeping the handler as-it-is can be a viable option but adding DSIM bridg

  1   2   3   >