Re: [PATCH v4 3/6] drm: lcdif: Determine bus format and flags in ->atomic_check()

2023-02-17 Thread Alexander Stein
Hi Liu, thanks for the update. Am Freitag, 17. Februar 2023, 07:54:04 CET schrieb Liu Ying: > Instead of determining LCDIF output bus format and bus flags in > ->atomic_enable(), do that in ->atomic_check(). This is a > preparation for the upcoming patch to check consistent bus format > and bus

Re: [PATCH v4 4/6] drm: lcdif: Check consistent bus format and flags across first bridges

2023-02-17 Thread Alexander Stein
Hi Liu, thanks for this update. Am Freitag, 17. Februar 2023, 07:54:05 CET schrieb Liu Ying: > The single LCDIF embedded in i.MX93 SoC may drive multiple displays > simultaneously. Check bus format and flags across first bridges in > ->atomic_check() to ensure they are consistent. This is a pre

Re: [PATCH v4 5/6] drm: lcdif: Add multiple encoders and first bridges support

2023-02-17 Thread Alexander Stein
Hi Liu, thanks for the update. Am Freitag, 17. Februar 2023, 07:54:06 CET schrieb Liu Ying: > The single LCDIF embedded in i.MX93 SoC may drive multiple displays > simultaneously. Look at LCDIF output port's remote port parents to > find all enabled first bridges. Add an encoder for each found

Re: [PATCH v4 2/2] gpu/drm/panel: Add Sony TD4353 JDI panel driver

2023-02-17 Thread Daniel Vetter
On Thu, Feb 16, 2023 at 09:37:51PM +0100, Sam Ravnborg wrote: > On Thu, Feb 16, 2023 at 01:49:23PM +0100, Daniel Vetter wrote: > > On Thu, 16 Feb 2023 at 13:47, Neil Armstrong > > wrote: > > > > > > On 16/02/2023 13:32, Daniel Vetter wrote: > > > > On Thu, 16 Feb 2023 at 12:59, Konrad Dybcio >

Re: [PATCH 01/11] fbdev: Fix contact info in fb_cmdline.c

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Fix Daniel's email address. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Daniel Vetter > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-02-17 Thread Alexander Stein
Hi Liu, Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying: > Hi, > > This patch set aims to add i.MX93 LCDIF display controller support > in the existing LCDIF DRM driver. The LCDIF embedded in i.MX93 SoC > is essentially the same to those embedded in i.MX8mp SoC. Through > internal b

Re: [PATCH] drm/fb-helper: Remove drm_fb_helper_unprepare() from drm_fb_helper_fini()

2023-02-17 Thread Thomas Zimmermann
Hi Am 16.02.23 um 21:11 schrieb Daniel Vetter: On Thu, Feb 16, 2023 at 03:06:20PM +0100, Thomas Zimmermann wrote: Move drm_fb_helper_unprepare() from drm_fb_helper_fini() into the calling fbdev implementation. Avoids a possible stale mutex with generic fbdev code. As indicated by its name, drm

Re: [PATCH 17/17] drm/cirrus: Use VGA macro constants to unblank

2023-02-17 Thread Thomas Zimmermann
Hi Am 16.02.23 um 18:20 schrieb Ville Syrjälä: On Thu, Feb 16, 2023 at 02:21:43PM +0100, Thomas Zimmermann wrote: Hi Am 16.02.23 um 13:52 schrieb Ville Syrjälä: On Thu, Feb 16, 2023 at 01:03:02PM +0100, Thomas Zimmermann wrote: Hi, thanks for taking a look at the patches. Am 16.02.23 um 12

Re: [PULL] nouveau-next

2023-02-17 Thread 何金朋
Dear Ben Skeggs: When I using GT710 card bsed on kernel version is 4.19.90 ubuntu. the following error message appeared, I really want to get your help, thank you very much. [ 32.191620] nouveau :01:00.0: fifo: CHSW_ERROR 0002 [ 32.197195] nouveau :01:00.0: fifo: FB_

Re: [PATCH 02/11] fbdev: Transfer video= option strings to caller; clarify ownership

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > In fb_get_options(), always duplicate the returned option string and > transfer ownership of the memory to the function's caller. > > Until now, only the global option string got duplicated and transferred > to the caller; the per-driver options were owned by fb_get_op

Re: [PATCH v3 0/2] Don't use stolen memory or BAR mappings for ring buffers

2023-02-17 Thread Hogander, Jouni
On Wed, 2023-02-15 at 17:10 -0800, john.c.harri...@intel.com wrote: > From: John Harrison > > Instruction from hardware arch is that stolen memory and BAR mappings > are unsafe for use as ring buffers. There can be issues with cache > aliasing due to the CPU access going to memory via the BAR. So

Re: [PATCH 03/11] fbdev: Support NULL for name in option-string lookup

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Ignore the per-driver video options if no driver name has been > specified to fb_get_option(). Return the global options in this > case. > > Signed-off-by: Thomas Zimmermann > --- I think you need to update the kernel-doc as well to mention that @name could be NULL ?

Re: [PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Get the kernel's global video= parameter with fb_get_option(). Done > to unexport the internal fbdev state fb_mode_config. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH 05/11] fbdev: Read video= option with fb_get_option() in modedb

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Get the kernel's global video= parameter with fb_get_option(). Done > to unexport the internal fbdev state fb_mode_config. No functional > changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH] habanalabs: make some functions static

2023-02-17 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 02:26:26PM +0800, Jiapeng Chong wrote: > These functions are not used outside the file device.c, so the > modification is defined as static. > > drivers/accel/habanalabs/common/device.c:2641:6: warning: no previous > prototype for ‘hl_capture_fw_err’. > drivers/accel/haban

Re: [PATCH 06/11] fbdev: Unexport fb_mode_option

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > There are no external users of fb_mode_option. Unexport the variable > and declare it static. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

[PATCH -next] drm/bridge: analogix_dp: Use devm_platform_ioremap_resource()

2023-02-17 Thread Yang Li
Convert platform_get_resource(), devm_ioremap_resource() to a single call to Use devm_platform_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Yang Li --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [PATCH 07/11] fbdev: Move option-string lookup into helper

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move the lookup of the option string into an internal helper. No > functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-17 Thread Rasmus Villemoes
On 14/02/2023 12.09, Fabio Estevam wrote: > Hi Rasmus, > > On Tue, Feb 14, 2023 at 7:55 AM Rasmus Villemoes > wrote: > >> Well, the data sheet for the dsi86 says up to 750MHz DSI HS clock, and >> if the value specified in samsung,burst-clock-frequency is twice the DSI >> HS clk, I suppose I shou

Re: [PATCH v4 0/6] drm: lcdif: Add i.MX93 LCDIF support

2023-02-17 Thread Liu Ying
On Fri, 2023-02-17 at 09:18 +0100, Alexander Stein wrote: > Hi Liu, Hi Alexander, > > Am Freitag, 17. Februar 2023, 07:54:01 CET schrieb Liu Ying: > > Hi, > > > > This patch set aims to add i.MX93 LCDIF display controller support > > in the existing LCDIF DRM driver. The LCDIF embedded in i.MX

Re: [PATCH] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-02-17 Thread Krzysztof Kozlowski
On 16/02/2023 14:14, Konrad Dybcio wrote: > Since the DSI autodetection is bound to work correctly on 6115 now, > switch to using the correct per-SoC + generic fallback compatible > combo. > > Signed-off-by: Konrad Dybcio > --- > Depends on (and should have been a part of): > > https://lore.kern

Re: [PATCH 08/11] fbdev: Handle video= parameter in video/cmdline.c

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Handle the command-line parameter video= in video/cmdline.c. Implement > the fbdev helper fb_get_options() on top. Will allows to handle the > kernel parameter in DRM without fbdev dependencies. > > Note that __video_get_options() has the meaning of its return value >

Re: [PATCH 09/11] driver/ps3: Include for mode parsing

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Include in ps3av.c to get video_get_options() and > avoid the dependency on . The replaced function > fb_get_options() is just a tiny wrapper around video_get_opions(). No > functional changes. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez

Re: [PATCH 10/11] drm: Include for mode parsing

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Include in drm_connector.c to get video_get_options() > and avoid the dependency on . The replaced function > fb_get_options() is just a tiny wrapper around video_get_opions(). No > functional changes. > > Include to get fwnode_handle_put(), which had been > provided

Re: [PATCH 11/11] drm: Fix comment on mode parsing

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Do not claim that there's a default mode in the video= option parser. > if no option string has been given, the parser does nothing. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH] habanalabs: make some functions static

2023-02-17 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 09:48:14AM +0100, Stanislaw Gruszka wrote: > On Fri, Feb 17, 2023 at 02:26:26PM +0800, Jiapeng Chong wrote: > > These functions are not used outside the file device.c, so the > > modification is defined as static. > > > > drivers/accel/habanalabs/common/device.c:2641:6: war

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Christian König
Am 16.02.23 um 20:54 schrieb Daniel Vetter: On Thu, Feb 16, 2023 at 07:08:49PM +0200, Jani Nikula wrote: On Thu, 16 Feb 2023, Christian König wrote: Am 16.02.23 um 17:46 schrieb Jani Nikula: On Thu, 16 Feb 2023, Christian König wrote: Am 16.02.23 um 12:33 schrieb Daniel Vetter: On Thu, Feb

Re: [PATCH 2/2] drm: document DRM_IOCTL_GEM_CLOSE

2023-02-17 Thread Pekka Paalanen
On Thu, 16 Feb 2023 20:48:05 +0100 Daniel Vetter wrote: > On Thu, Feb 16, 2023 at 01:09:45PM +, Simon Ser wrote: > > This is a bit tricky, because of the ref'counting considerations. > > See also [1] for more discussion about this topic. Since this is > > kernel docs, I've decided to elaborat

Re: [PATCH 2/2] drm: document DRM_IOCTL_GEM_CLOSE

2023-02-17 Thread Simon Ser
On Thursday, February 16th, 2023 at 20:48, Daniel Vetter wrote: > I'd duplicate the relevant parts into each ioctl doc too, just to increase > the chances people notice these caveats. Hm, I'd rather not duplicate, this makes it very easy for each version to go out-of-sync with the rest. I will

Re: [PATCH 02/11] fbdev: Transfer video= option strings to caller; clarify ownership

2023-02-17 Thread Thomas Zimmermann
Hi Am 17.02.23 um 09:37 schrieb Javier Martinez Canillas: Thomas Zimmermann writes: In fb_get_options(), always duplicate the returned option string and transfer ownership of the memory to the function's caller. Until now, only the global option string got duplicated and transferred to the c

Re: [PATCH] dma-buf: make kobj_type structure constant

2023-02-17 Thread Christian König
_buf_ktype = { +static const struct kobj_type dma_buf_ktype = { .sysfs_ops = &dma_buf_stats_sysfs_ops, .release = dma_buf_sysfs_release, .default_groups = dma_buf_stats_default_groups, --- base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f change-id: 20230217-kob

Re: [PATCH] drm/i915: Make kobj_type structures constant

2023-02-17 Thread Jani Nikula
On Thu, 16 Feb 2023, Jani Nikula wrote: > On Thu, 16 Feb 2023, Thomas Weißschuh wrote: >> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") >> the driver core allows the usage of const struct kobj_type. >> >> Take advantage of this to constify the structure definitions to preven

[PATCH] MAINTAINERS: Add myself as co-maintainer for DRM Panels drivers

2023-02-17 Thread Neil Armstrong
Add myself as co-maintainer for DRM Panel Drivers in order to help reviewing and getting new panels drivers merged. Signed-off-by: Neil Armstrong --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index be167c695c64..18fd7548a49b 100644 --- a/MAINTAINER

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 10:22:25AM +0100, Christian König wrote: > Am 16.02.23 um 20:54 schrieb Daniel Vetter: > > On Thu, Feb 16, 2023 at 07:08:49PM +0200, Jani Nikula wrote: > > > On Thu, 16 Feb 2023, Christian König wrote: > > > > Am 16.02.23 um 17:46 schrieb Jani Nikula: > > > > > On Thu, 16 F

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

2023-02-17 Thread Alexander Stein
Am Freitag, 17. Februar 2023, 09:55:22 CET schrieb Rasmus Villemoes: > On 14/02/2023 12.09, Fabio Estevam wrote: > > Hi Rasmus, > > > > On Tue, Feb 14, 2023 at 7:55 AM Rasmus Villemoes > > > > wrote: > >> Well, the data sheet for the dsi86 says up to 750MHz DSI HS clock, and > >> if the value sp

Re: [PATCH] gpu-drm-tiny-cirrus: Add NULL check of pointer pipe->plane.state->fb in cirrus_pipe_update()

2023-02-17 Thread Thomas Zimmermann
Hi Am 15.02.23 um 18:15 schrieb Alexander Sapozhnikov: From: Alexandr Sapozhnikov After having been compared to NULL value at cirrus.c:455, pointer 'pipe->plane.state->fb' is passed as 1st parameter in call to function 'cirrus_fb_blit_rect' at cirrus.c:461, where it is dereferenced at cirrus

Re: [PATCH v2] drm/meson/meson_venc: Relax the supported mode checks

2023-02-17 Thread Neil Armstrong
On 13/02/2023 10:32, Carlo Caione wrote: Relax a bit the supported modes list by including also 480x1920 and 400x1280. This was actually tested on real hardware and it works correctly. Signed-off-by: Carlo Caione --- In particular relax the resolution checks to allow more resolutions like 480x1

Re: [PATCH v5] drm/i915: Consolidate TLB invalidation flow

2023-02-17 Thread Tvrtko Ursulin
On 16/02/2023 15:41, Matt Roper wrote: On Thu, Feb 16, 2023 at 09:21:23AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time i

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Stanislaw Gruszka
On Thu, Feb 16, 2023 at 07:06:46PM +0200, Jani Nikula wrote: > > > > But should not this the driver responsibility, call drm_debugfs_add_file() > > whenever you are ready to handle operations on added file ? > > In theory, yes, but in practice it's pretty hard for a non-trivial > driver to maintai

Re: [PATCH] MAINTAINERS: Add myself as co-maintainer for DRM Panels drivers

2023-02-17 Thread Sam Ravnborg
On Fri, Feb 17, 2023 at 10:58:15AM +0100, Neil Armstrong wrote: > Add myself as co-maintainer for DRM Panel Drivers in order to help > reviewing and getting new panels drivers merged. > > Signed-off-by: Neil Armstrong Thanks for stepping up! Acked-by: Sam Ravnborg > --- > MAINTAINERS | 1 + >

[PATCH 5/4] drm/edid: parse Tiled Display Topology Data Block for DisplayID 2.0

2023-02-17 Thread Jani Nikula
Currently we only parse the Tiled Display Topology Data Block for DisplayID structure version 1.2, but not 2.0. The contents seem to be the same for both, so expand the parsing to structure version 2.0. Note that DisplayID spec version is not the same as DisplayID structure version; DisplayID 1.3

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Jani Nikula
On Fri, 17 Feb 2023, Stanislaw Gruszka wrote: > On Thu, Feb 16, 2023 at 07:06:46PM +0200, Jani Nikula wrote: >> > >> > But should not this the driver responsibility, call drm_debugfs_add_file() >> > whenever you are ready to handle operations on added file ? >> >> In theory, yes, but in practice

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Christian König
Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely hard not to enable signalling on the fences that hold the memory up for freeing, which makes it hard to understand and to fix potential i

[PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Konrad Dybcio
SM6115 previously erroneously added just "qcom,dsi-ctrl-6g-qcm2290", without the generic fallback. Fix the deprecated binding to reflect that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC") Signed-off-by: Konrad Dybcio --- Depends on (

[PATCH v2 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-02-17 Thread Konrad Dybcio
Since the DSI autodetection is bound to work correctly on 6115 now, switch to using the correct per-SoC + generic fallback compatible combo. Signed-off-by: Konrad Dybcio --- Depends on (and should have been a part of): https://lore.kernel.org/linux-arm-msm/20230213121012.1768296-1-konrad.dyb...@

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Thomas Hellström
On 2/17/23 12:00, Christian König wrote: Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely hard not to enable signalling on the fences that hold the memory up for freeing, which makes

Re: [PATCH 02/11] fbdev: Transfer video= option strings to caller; clarify ownership

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Hi > > Am 17.02.23 um 09:37 schrieb Javier Martinez Canillas: >> Thomas Zimmermann writes: >> >>> In fb_get_options(), always duplicate the returned option string and >>> transfer ownership of the memory to the function's caller. >>> >>> Until now, only the global op

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Christian König
Am 17.02.23 um 12:21 schrieb Thomas Hellström: On 2/17/23 12:00, Christian König wrote: Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely hard not to enable signalling on the fences th

[PATCH 0/2] Add support for Lenovo NT36523W BOE panel

2023-02-17 Thread Konrad Dybcio
: c068f40300a0eaa34f7105d137a5560b86951aa9 change-id: 20230217-topic-lenovo-panel-48c63b84e3f8 Best regards, -- Konrad Dybcio

[PATCH 2/2] gpu/drm/panel: Add Lenovo NT36523W BOE panel

2023-02-17 Thread Konrad Dybcio
Introduce support for the BOE panel with a NT36523W touch/driver IC found on some Lenovo Tab P11 devices. It's a 2000x1200, 24bit RGB MIPI DSI panel with integrated DCS-controlled backlight (that expects big-endian communication). Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/panel/Kconfig

[PATCH 1/2] dt-bindings: display/panel: Add Lenovo NT36523W BOE panel

2023-02-17 Thread Konrad Dybcio
Add bindings for the 2000x1200px IPS panel found on Lenovo Tab P11/ XiaoXin Pad devices. Signed-off-by: Konrad Dybcio --- .../display/panel/lenovo,nt36523w-boe-j606.yaml| 60 ++ 1 file changed, 60 insertions(+) diff --git a/Documentation/devicetree/bindings/display/pane

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:13, Konrad Dybcio wrote: > SM6115 previously erroneously added just "qcom,dsi-ctrl-6g-qcm2290", > without the generic fallback. Fix the deprecated binding to reflect > that. > > Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible > strings for every curren

Re: [PATCH v2 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:13, Konrad Dybcio wrote: > Since the DSI autodetection is bound to work correctly on 6115 now, > switch to using the correct per-SoC + generic fallback compatible > combo. > > Signed-off-by: Konrad Dybcio > --- > Depends on (and should have been a part of): > > https://lore.kern

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Konrad Dybcio
rl > > Wasn't then intention to deprecate both - qcm2290 and mdss - when used > alone? "qcom,dsi-ctrl-6g-qcm2290", "qcom,mdss-dsi-ctrl" was never used. The only upstream usage of the 2290 compat is in sm6115.dtsi: compatible = "qcom,dsi-ctrl-6g-qcm2290"; https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm6115.dtsi?h=next-20230217#n1221 Konrad > > > Best regards, > Krzysztof >

RE: [PATCH 08/27] habanalabs: add info when FD released while device still in use

2023-02-17 Thread Tomer Tayar
On Thu, Feb 16, 2023 at 17:05 Stanislaw Gruszka wrote: > On Thu, Feb 16, 2023 at 04:21:48PM +0200, Oded Gabbay wrote: > > On Thu, Feb 16, 2023 at 2:25 PM Stanislaw Gruszka > > wrote: > > > > > > On Sun, Feb 12, 2023 at 10:44:35PM +0200, Oded Gabbay wrote: > > > > From: Tomer Tayar > > > > > > >

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
drop the items as it is just an enum. >> >>>- enum: >>>- qcom,dsi-ctrl-6g-qcm2290 >>> - - const: qcom,mdss-dsi-ctrl >> >> Wasn't then intention to deprecate both - qcm2290 and mdss - when used >> alone?

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Stanislaw Gruszka
On Fri, Feb 17, 2023 at 12:49:41PM +0200, Jani Nikula wrote: > On Fri, 17 Feb 2023, Stanislaw Gruszka > wrote: > > On Thu, Feb 16, 2023 at 07:06:46PM +0200, Jani Nikula wrote: > >> > > >> > But should not this the driver responsibility, call > >> > drm_debugfs_add_file() > >> > whenever you are

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Konrad Dybcio
enum: >>>>- qcom,dsi-ctrl-6g-qcm2290 >>>> - - const: qcom,mdss-dsi-ctrl >>> >>> Wasn't then intention to deprecate both - qcm2290 and mdss - when used >>> alone? >> "qcom,dsi-ctrl-6g-qcm2290", "qco

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Christian König
Am 17.02.23 um 12:36 schrieb Stanislaw Gruszka: On Fri, Feb 17, 2023 at 12:49:41PM +0200, Jani Nikula wrote: On Fri, 17 Feb 2023, Stanislaw Gruszka wrote: On Thu, Feb 16, 2023 at 07:06:46PM +0200, Jani Nikula wrote: But should not this the driver responsibility, call drm_debugfs_add_file() w

Re: [PATCH v10 01/11] drm/msm/gem: Prevent blocking within shrinker loop

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Consider this scenario: 1. APP1 continuously creates lots of small GEMs 2. APP2 triggers `drop_caches` 3. Shrinker starts to evict APP1 GEMs, while APP1 produces new purgeable GEMs 4. msm_gem_shrinker_scan() returns non-zero number of freed p

Re: [PATCH] Don't test for NULL firmware before releasing

2023-02-17 Thread Mikko Perttunen
On 2/16/23 15:19, Stanislaw Gruszka wrote: Hi On Thu, Feb 16, 2023 at 02:37:15AM +0100, Jesper Juhl wrote: From 4fe34831e2e7677b1c9616356f0a2e0a36ec092f Mon Sep 17 00:00:00 2001 From: Jesper Juhl Date: Thu, 16 Feb 2023 02:33:05 +0100 Subject: [PATCH] Don't test for NULL firmware before releas

Re: [PATCH 1/2] drm/client: fix circular reference counting issue

2023-02-17 Thread Christian König
Am 16.02.23 um 15:34 schrieb Daniel Vetter: On Thu, Jan 26, 2023 at 03:30:31PM +0100, Thomas Zimmermann wrote: Hi Am 26.01.23 um 11:28 schrieb Christian König: We reference dump buffers both by their handle as well as their object. The problem is now that when anybody iterates over the DRM fra

[PATCH 1/7] drm/amdgpu: use amdgpu_res_cursor in more places v2

2023-02-17 Thread Christian König
Instead of resource->start use the cursor to get this. v2 (chk): remove changes to amdgpu_bo_gpu_offset_no_check(), that won't work with the AGP aperture otherwise. Signed-off-by: Somalapuram Amaranath Reviewed-by: Christian König Signed-off-by: Christian König --- drivers/gpu/drm/a

[PATCH 2/7] drm/ttm: Change the parameters of ttm_range_man_init() from pages to bytes

2023-02-17 Thread Christian König
From: Somalapuram Amaranath Change the parameters of ttm_range_man_init_nocheck() size from page size to byte size. Cleanup the PAGE_SHIFT operation on the depended caller functions. Signed-off-by: Somalapuram Amaranath Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

[PATCH 4/7] drm/ttm: Change the meaning of resource->start from pfn to bytes v2

2023-02-17 Thread Christian König
From: Somalapuram Amaranath Change resource->start from pfn to bytes to allow allocating objects smaller than a page and adjust all DRM drivers still using this. v2 (chk): inline drm_gem_vram_pg_offset(), move amdgpu cursor changes to separate patch, make resource->start 64bit on all p

[PATCH 6/7] drm/amdgpu: Cleanup the GDS, GWS and OA allocations

2023-02-17 Thread Christian König
From: Somalapuram Amaranath Change the size of GDS, GWS and OA from pages to bytes. The initialized gds_size, gws_size and oa_size in bytes, remove PAGE_SHIFT in amdgpu_ttm_init_on_chip(). Signed-off-by: Somalapuram Amaranath --- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c| 12 ++-- dr

[PATCH 3/7] drm/ttm: Change the meaning of the fields in the drm_mm_nodes structure from pfn to bytes v3

2023-02-17 Thread Christian König
From: Somalapuram Amaranath Change the ttm_range_man_alloc() allocation from pages to size in bytes. Fix the dependent drm_mm_nodes start and size from pages to bytes. v2 (chk): Change the drm_mm_node usage in amdgpu as well. re-order the patch to be independent of the resource->start

[PATCH 5/7] drm/gem: Remove BUG_ON in drm_gem_private_object_init

2023-02-17 Thread Christian König
From: Somalapuram Amaranath ttm_resource can allocate size in bytes to support less than page size. Signed-off-by: Somalapuram Amaranath Reviewed-by: Christian König Signed-off-by: Christian König Link: https://patchwork.freedesktop.org/patch/msgid/20230208090106.9659-1-amaranath.somalapu...

[PATCH 7/7] drm/ttm: cleanup ttm_range_mgr_node

2023-02-17 Thread Christian König
We don't need multiple drm_mm nodes any more. Clean that up and remove the extra complexity. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c| 18 +- drivers/gpu/drm/amd/amdgpu/amdgpu_res_cursor.h | 2 +- drivers/gpu/drm/i915/intel_region_ttm.c

Re: [PATCH v10 03/11] drm/gem: Add evict() callback to drm_gem_object_funcs

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Add new common evict() callback to drm_gem_object_funcs and corresponding drm_gem_object_evict() helper. This is a first step on a way to providing common GEM-shrinker API for DRM drivers. Suggested-by: Thomas Zimmermann Signed-off-by: Dmitry Os

[PULL] drm-intel-next-fixes

2023-02-17 Thread Jani Nikula
Hi Dave & Daniel - Fixes for drm-next and the upcoming merge window. drm-intel-next-fixes-2023-02-17: drm/i915 fixes for the v6.3 merge window: - Fix eDP+DSI dual panel systems - Fix system suspend when fbdev isn't initialized - Fix memory leaks in scatterlist - Fix some MCR register annotation

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Thomas Hellström
On 2/17/23 12:28, Christian König wrote: Am 17.02.23 um 12:21 schrieb Thomas Hellström: On 2/17/23 12:00, Christian König wrote: Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely ha

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Krzysztof Kozlowski
On 17/02/2023 12:36, Konrad Dybcio wrote: >>> >>> compatible = "qcom,dsi-ctrl-6g-qcm2290"; >>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/sm6115.dtsi?h=next-20230217#n1221 >> >> I meant, that o

Re: [PATCH v10 04/11] drm/shmem: Put booleans in the end of struct drm_gem_shmem_object

2023-02-17 Thread Thomas Zimmermann
Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Group all 1-bit boolean members of struct drm_gem_shmem_object in the end of the structure, allowing compiler to pack data better and making code to look more consistent. Suggested-by: Thomas Zimmermann Signed-off-by: Dmitry Osipenko Reviewed-b

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Christian König
Am 17.02.23 um 13:24 schrieb Thomas Hellström: On 2/17/23 12:28, Christian König wrote: Am 17.02.23 um 12:21 schrieb Thomas Hellström: On 2/17/23 12:00, Christian König wrote: Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to leverage the amdgpu suballocation manager. It

Re: [PATCH v10 05/11] drm/shmem: Switch to use drm_* debug helpers

2023-02-17 Thread Thomas Zimmermann
Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Ease debugging of a multi-GPU system by using drm_WARN_*() and drm_dbg_kms() helpers that print out DRM device name corresponding to shmem GEM. Suggested-by: Thomas Zimmermann Signed-off-by: Dmitry Osipenko Reviewed-by: Thomas Zimmermann ---

Re: [PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-17 Thread Jani Nikula
On Fri, 17 Feb 2023, Christian König wrote: > If i915 have such structural problems then I strongly suggest to solve > them inside i915 and not make common code out of that. All other things aside, that's just a completely unnecessary and unhelpful remark. BR, Jani. -- Jani Nikula, Intel Op

Re: [PATCH v10 06/11] drm/shmem-helper: Don't use vmap_use_count for dma-bufs

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: DMA-buf core has its own refcounting of vmaps, use it instead of drm-shmem counting. This change prepares drm-shmem for addition of memory shrinker support where drm-shmem will use a single dma-buf reservation lock for all operations performed ove

[PATCH] drm/i915/guc: avoid FIELD_PREP warning

2023-02-17 Thread Arnd Bergmann
From: Arnd Bergmann With gcc-7 and earlier, there are lots of warnings like In file included from :0:0: In function '__guc_context_policy_add_priority.isra.66', inlined from '__guc_context_set_prio.isra.67' at drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:3292:3, inlined from 'guc_c

Re: [PATCH v10 07/11] drm/shmem-helper: Switch to reservation lock

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock betwe

Re: [Intel-gfx] [RFC v2 0/5] Waitboost drm syncobj waits

2023-02-17 Thread Tvrtko Ursulin
On 16/02/2023 18:19, Rodrigo Vivi wrote: On Tue, Feb 14, 2023 at 11:14:00AM -0800, Rob Clark wrote: On Fri, Feb 10, 2023 at 5:07 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin In i915 we have this concept of "wait boosting" where we give a priority boost for instance to fences which are ac

Re: [PATCH v2 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible

2023-02-17 Thread Konrad Dybcio
On 17.02.2023 13:24, Krzysztof Kozlowski wrote: > On 17/02/2023 12:36, Konrad Dybcio wrote: >>>> >>>> compatible = "qcom,dsi-ctrl-6g-qcm2290"; >>>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Thomas Hellström
On 2/17/23 13:28, Christian König wrote: Am 17.02.23 um 13:24 schrieb Thomas Hellström: On 2/17/23 12:28, Christian König wrote: Am 17.02.23 um 12:21 schrieb Thomas Hellström: On 2/17/23 12:00, Christian König wrote: Am 16.02.23 um 15:48 schrieb Thomas Hellström: Initially we tried to le

Re: [PATCH 1/3] drm/suballoc: Introduce a generic suballocation manager

2023-02-17 Thread Christian König
Am 17.02.23 um 14:10 schrieb Thomas Hellström: [SNIP] Any chance you could do a quick performance comparison? If not, anything against merging this without the amd / radeon changes until we can land a simpler allocator? Only if you can stick the allocator inside Xe and not drm, cause this

Re: [PATCH v10 08/11] drm/shmem-helper: Add memory shrinker

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Introduce common drm-shmem shrinker for DRM drivers. To start using drm-shmem shrinker drivers should do the following: 1. Implement evict() callback of GEM object where driver should check whether object is purgeable or evictable using drm-

Re: [PATCH 1/6] drm/atomic-helper: Add atomic_enable plane-helper callback

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Add atomic_enable to struct drm_plane_helper_funcs. It enables a > plane independently from updating the plane's content. As such, it is > the inverse of the atomic_disable plane helper. Useful for hardware > where plane enable state is independent from plane content.

Re: [PATCH 2/6] drm/ast: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Enable the primary plane for ast hardware via atomic_enable. Atomic > helpers invoke this callback only when the plane becomes active. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH 4/6] drm/mgag200: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Enable the primary plane for mgag200 hardware via atomic_enable. > Atomic helpers invoke this callback only when the plane becomes > active. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH 5/6] drm/tidss: Remove return values from dispc_plane_{setup, enable}()

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Calls to dispc_plane_setup() and dispc_plane_enable() cannot fail. > Remove the return value. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-17 Thread Thomas Zimmermann
Hi, I looked through the series. Most of the patches should have an r-b or a-b at this point. I can't say much about patch 2 and had questions about others. Maybe you can already land patches 2, and 4 to 6? They look independent from the shrinker changes. You could also attempt to land the l

Re: [PATCH 6/6] drm/tidss: Implement struct drm_plane_helper_funcs.atomic_enable

2023-02-17 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Enable the primary plane for tidss hardware via atomic_enable. > Atomic helpers invoke this callback only when the plane becomes > active. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas Best regards, Javier

Re: [PATCH v10 07/11] drm/shmem-helper: Switch to reservation lock

2023-02-17 Thread Thomas Zimmermann
Hi Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Replace all drm-shmem locks with a GEM reservation lock. This makes locks consistent with dma-buf locking convention where importers are responsible for holding reservation lock for all operations performed over dma-bufs, preventing deadlock betwe

Re: [PATCH v10 07/11] drm/shmem-helper: Switch to reservation lock

2023-02-17 Thread Dmitry Osipenko
On 2/17/23 15:52, Thomas Zimmermann wrote: > Hi > > Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: >> Replace all drm-shmem locks with a GEM reservation lock. This makes locks >> consistent with dma-buf locking convention where importers are >> responsible >> for holding reservation lock for all op

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-02-17 Thread Dmitry Osipenko
On 2/17/23 16:28, Thomas Zimmermann wrote: > Hi, > > I looked through the series. Most of the patches should have an r-b or > a-b at this point. I can't say much about patch 2 and had questions > about others. > > Maybe you can already land patches 2, and 4 to 6? They look independent > from the

Re: [PATCH v10 09/11] drm/gem: Add drm_gem_pin_unlocked()

2023-02-17 Thread Thomas Zimmermann
I forgot this change. Am 08.01.23 um 22:04 schrieb Dmitry Osipenko: Add unlocked variants of drm_gem_un/pin() functions. These new helpers will take care of GEM dma-reservation locking for DRM drivers. VirtIO-GPU driver will use these helpers to pin shmem framebuffers, preventing them from evic

[PATCH drm-next v2 05/16] drm: manager to keep track of GPUs VA mappings

2023-02-17 Thread Danilo Krummrich
Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, allow userspace applications to request multiple and arbitrary GPU VA mappings of buffe

[PATCH drm-next v2 04/16] maple_tree: add flag MT_FLAGS_LOCK_NONE

2023-02-17 Thread Danilo Krummrich
Generic components making use of the maple tree (such as the DRM GPUVA Manager) delegate the responsibility of ensuring mutual exclusion to their users. While such components could inherit the concept of an external lock, some users might just serialize the access to the component and hence to the

[PATCH drm-next v2 06/16] drm: debugfs: provide infrastructure to dump a DRM GPU VA space

2023-02-17 Thread Danilo Krummrich
This commit adds a function to dump a DRM GPU VA space and a macro for drivers to register the struct drm_info_list 'gpuvas' entry. Most likely, most drivers might maintain one DRM GPU VA space per struct drm_file, but there might also be drivers not having a fixed relation between DRM GPU VA spac

[PATCH drm-next v2 07/16] drm/nouveau: new VM_BIND uapi interfaces

2023-02-17 Thread Danilo Krummrich
This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs can provide a kernel reserved VA area. 2) Bind and unbind GPU VA space ma

[PATCH drm-next v2 01/16] drm: execution context for GEM buffers

2023-02-17 Thread Danilo Krummrich
From: Christian König This adds the infrastructure for an execution context for GEM buffers which is similar to the existinc TTMs execbuf util and intended to replace it in the long term. The basic functionality is that we abstracts the necessary loop to lock many different GEM buffers with auto

  1   2   >