Try to address the drm_debugfs issues

2023-02-09 Thread Christian König
Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between initializing and registering of DRM devices since the underlying debugfs directory wasn't created yet. The resulting necessity of the driver->debugfs_init() callback fun

[PATCH 2/3] drm/debugfs: split registration into dev and minor

2023-02-09 Thread Christian König
The different subsystems should probably only register their debugfs files once. This temporary removes the common files from the render node directory. Signed-off-by: Christian König --- drivers/gpu/drm/drm_atomic.c| 4 ++-- drivers/gpu/drm/drm_client.c| 4 ++-- drivers/gpu/d

[PATCH 1/3] drm/debugfs: separate debugfs creation into init and register

2023-02-09 Thread Christian König
This way we can create debugfs files directly, even between init and register. Signed-off-by: Christian König --- drivers/gpu/drm/drm_debugfs.c | 12 drivers/gpu/drm/drm_drv.c | 15 +++ drivers/gpu/drm/drm_internal.h | 1 + 3 files changed, 16 insertions(+), 12 de

[PATCH 3/3] drm/debugfs: remove dev->debugfs_list and debugfs_mutex

2023-02-09 Thread Christian König
The mutex was completely pointless in the first place since any parallel adding of files to this list would result in random behavior since the list is filled and consumed multiple times. Completely drop that approach and just create the files directly. This also re-adds the debugfs files to the

Re: [PATCH v11 1/9] device property: Add remote endpoint to devcon matcher

2023-02-09 Thread Sakari Ailus
Hi Pin-yen, On Thu, Feb 09, 2023 at 12:28:33PM +0800, Pin-yen Lin wrote: > Hi Sakari, > > Thanks for the review. > > On Mon, Feb 6, 2023 at 5:11 AM Sakari Ailus > wrote: > > > > Hi Pin-yen, > > > > On Sat, Feb 04, 2023 at 09:30:32PM +0800, Pin-yen Lin wrote: > > > From: Prashant Malani > > > >

Re: [PATCH] media: Fix building pdfdocs

2023-02-09 Thread Akira Yokosawa
On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote: > Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added > documatation for a few new RGB formats. For some reason these break the > pdfdocs build, even if the same style seems to work elsewhere in the > file. > > Remove the traili

Re: [PATCH v3 1/7] media: Add 2-10-10-10 RGB formats

2023-02-09 Thread Akira Yokosawa
On Wed, 8 Feb 2023 09:56:24 +0200, Tomi Valkeinen wrote: > On 08/02/2023 03:53, Akira Yokosawa wrote: [...] >> Tomi, can you remove those extra "-"s I mentioned above? >> >> Hopefully, this can be fixed before the v6.3 merge window. > > This is all black magics to me... Why does the same format wo

Re: [Freedreno] [PATCH 09/14] drm/msm/a6xx: Fix some A619 tunables

2023-02-09 Thread Jordan Crouse
On Thu, Jan 26, 2023 at 04:16:13PM +0100, Konrad Dybcio wrote: > Adreno 619 expects some tunables to be set differently. Make up for it. > > Fixes: b7616b5c69e6 ("drm/msm/adreno: Add A619 support") > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- > 1 file

Re: [PATCH 2/9] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192

2023-02-09 Thread Chen-Yu Tsai
On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: > > MediaTek MT8192 (and similar) needs five power domains for the > Mali GPU and no sram-supply: change the binding to allow so. > mt8192 compatible was already added, so this should have: Fixes: 5d82e74a97c2 ("dt-bindings: Add co

Re: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-09 Thread Neil Armstrong
Hi, On Tue, 07 Feb 2023 11:04:36 +0100, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes) [1/1] dt-bindings: display: panel: visionox,vtdr6130: add missing

[PULL] drm-misc-fixes

2023-02-09 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2023-02-09: A fix for a circular refcounting in drm/client, one for a memory leak in amdgpu and a virtio fence fix when interrupted The following changes since commit a3ee9e0b57f8ecca02d1c16fad4941e09bfe2941: drm/panel:

Re: [PATCH 5/9] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-09 Thread Chen-Yu Tsai
On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: > > Get GPU support on MT8186 by adding its compatible. I'd skip MT8186 for now. We have to work out some binning details for the OPP, in particular how to deal with both Panfrost (or Mali) and SVS adding the OPP table. We were just

Re: (subset) [PATCH] drm/vc4: Fix YUV plane handling when planes are in different buffers

2023-02-09 Thread Maxime Ripard
On Fri, 27 Jan 2023 16:57:08 +0100, Maxime Ripard wrote: > YUV images can either be presented as one allocation with offsets > for the different planes, or multiple allocations with 0 offsets. > > The driver only ever calls drm_fb_[dma|cma]_get_gem_obj with plane > index 0, therefore any applicati

Re: (subset) [PATCH] drm/vc4: hdmi: Always enable GCP with AVMUTE cleared

2023-02-09 Thread Maxime Ripard
On Fri, 27 Jan 2023 17:12:19 +0100, Maxime Ripard wrote: > Issue is some displays go blank at the point of firmware to kms > handover. Plugging/unplugging hdmi cable, power cycling display, or > switching standby off/on > typically resolve this case. > > Finally managed to find a display that suf

Re: (subset) [PATCH] drm/vc4: crtc: Increase setup cost in core clock calculation to handle extreme reduced blanking

2023-02-09 Thread Maxime Ripard
On Fri, 27 Jan 2023 15:55:58 +0100, Maxime Ripard wrote: > The formula that determines the core clock requirement based on pixel > clock and blanking has been determined experimentally to minimise the > clock while supporting all modes we've seen. > > A new reduced blanking mode (4kp60 at 533MHz r

Re: [PATCH] nvidiafb: detect the hardware support before removing console.

2023-02-09 Thread Thomas Zimmermann
Hi Am 06.02.23 um 09:54 schrieb Zeno Davatz: Dear Dave On Mon, Feb 6, 2023 at 9:40 AM David Airlie wrote: On Mon, Feb 6, 2023 at 6:38 PM Zeno Davatz wrote: Dear Dave On Mon, Feb 6, 2023 at 9:10 AM Dave Airlie wrote: On Mon, 6 Feb 2023 at 18:01, Zeno Davatz wrote: Dear Dave On Mon,

Re: [PATCH 0/9] Panfrost: Improve and add MediaTek SoCs support

2023-02-09 Thread Chen-Yu Tsai
On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: > > This series adds support for new MediaTek SoCs (MT8186/MT8192/MT8195) > and improves MT8183 support: since the mtk-regulator-coupler driver > was picked, it is now useless for Panfrost to look for, and manage, > two regulators (G

Re: [PATCH] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
On 07/02/2023 12:36, Jocelyn Falempe wrote: On 07/02/2023 12:17, Thomas Zimmermann wrote: Hi I was wondering if this start address is not an offset in the GPU memory, and in this case the primary plane offset should always be 0 ? I think it's the case, so I will send a v2 shortly. Best

[PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower 24bits are used, and due to alignment it was almost always 0. But on some unlucky hardware, it's not the case, and some unitilized memory is

Re: [PATCH 1/9] dt-bindings: gpu: mali-bifrost: Don't allow sram-supply by default

2023-02-09 Thread AngeloGioacchino Del Regno
Il 09/02/23 03:50, Chen-Yu Tsai ha scritto: On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: The sram-supply is MediaTek-specific, it is and will ever be used only for the mediatek,mt8183-mali compatible due to the addition of the mediatek-regulator-coupler driver: change the b

Re: remove arch/sh

2023-02-09 Thread John Paul Adrian Glaubitz
On Wed, 2023-02-08 at 21:09 -0600, Rob Landley wrote: > > Geert has suggested to wait with adding a tree source to the entry until I > > get my > > own kernel.org account. I have enough GPG signatures from multiple kernel > > developers > > on my GPG key, so I think it shouldn't be too difficult

[PULL] drm-misc-next-fixes

2023-02-09 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the weekly PR for drm-misc-next-fixes. Best regards Thomas drm-misc-next-fixes-2023-02-09: Short summary of fixes pull: Contains a number of fixes to vc4 and ivpu. The patches to the probe helpers were cherry-picked from the regular development branch. The following c

Re: [PATCH 2/9] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192

2023-02-09 Thread AngeloGioacchino Del Regno
Il 09/02/23 09:33, Chen-Yu Tsai ha scritto: On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: MediaTek MT8192 (and similar) needs five power domains for the Mali GPU and no sram-supply: change the binding to allow so. mt8192 compatible was already added, so this should have:

Re: [PATCH 5/9] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-09 Thread AngeloGioacchino Del Regno
Il 09/02/23 09:49, Chen-Yu Tsai ha scritto: On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: Get GPU support on MT8186 by adding its compatible. I'd skip MT8186 for now. We have to work out some binning details for the OPP, in particular how to deal with both Panfrost (or Mal

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

2023-02-09 Thread Mikhail Gavrilov
Harry, please don't ignore me. This issue still happens in 6.1 and 6.2 Leo you are the author of the problematic commit please don't stand aside. Really nobody is interested in clean logs without warnings and errors? I am 100% sure that reverting commit b261509952bc19d1012cf732f853659be6ebc61e will

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
On 09/02/2023 10:22, Jammy Huang wrote: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. ok, thanks for the review, I will se

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jammy Huang
Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@

Re: [PATCH] drm/client: Convert to VISIBLE_IF_KUNIT

2023-02-09 Thread Maxime Ripard
On Thu, Feb 02, 2023 at 02:05:14PM +0100, Thomas Zimmermann wrote: > Hi > > Am 02.02.23 um 13:35 schrieb Maxime Ripard: > > Hi, > > > > On Thu, Feb 02, 2023 at 01:22:01PM +0100, Thomas Zimmermann wrote: > > > Am 02.02.23 um 12:03 schrieb Maxime Ripard: > > > > Commit 8fc0380f6ba7 ("drm/client: Ad

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Thomas Zimmermann
Hi Am 09.02.23 um 10:22 schrieb Jammy Huang: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_init() as below. I was about to write the same.

Re: [PATCH v2] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
On 09/02/2023 10:35, Thomas Zimmermann wrote: Hi Am 09.02.23 um 10:22 schrieb Jammy Huang: Hello, The offset given to ast_set_start_address_crt1() should be offset in vram. It should 0 now as your patch. I think it is better to correct it in ast_primary_plane_init() and ast_cursor_plane_in

[PATCH v3] drm/ast: Fix start address computation

2023-02-09 Thread Jocelyn Falempe
During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower 24bits are used, and due to alignment it was almost always 0. But on some unlucky hardware, it's not the case, and some unitilized memory is

Re: [PATCH 5/9] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-09 Thread Chen-Yu Tsai
On Thu, Feb 9, 2023 at 5:20 PM AngeloGioacchino Del Regno wrote: > > Il 09/02/23 09:49, Chen-Yu Tsai ha scritto: > > On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno > > wrote: > >> > >> Get GPU support on MT8186 by adding its compatible. > > > > I'd skip MT8186 for now. We have to work

Re: [PATCH v3] drm/ast: Fix start address computation

2023-02-09 Thread Thomas Zimmermann
Am 09.02.23 um 10:44 schrieb Jocelyn Falempe: During the driver conversion to shmem, the start address for the scanout buffer was set to the base PCI address. In most cases it works because only the lower 24bits are used, and due to alignment it was almost always 0. But on some unlucky hardware

Re: [PATCH 5/9] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186

2023-02-09 Thread AngeloGioacchino Del Regno
Il 09/02/23 10:45, Chen-Yu Tsai ha scritto: On Thu, Feb 9, 2023 at 5:20 PM AngeloGioacchino Del Regno wrote: Il 09/02/23 09:49, Chen-Yu Tsai ha scritto: On Wed, Feb 8, 2023 at 6:37 PM AngeloGioacchino Del Regno wrote: Get GPU support on MT8186 by adding its compatible. I'd skip MT8186 fo

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-09 Thread Pekka Paalanen
On Wed, 8 Feb 2023 16:49:31 +0200 Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 11:18:42AM +0200, Pekka Paalanen wrote: > > On Fri, 3 Feb 2023 16:02:51 +0200 > > Ville Syrjälä wrote: > > > > > On Fri, Feb 03, 2023 at 02:52:50PM +0100, Sebastian Wick wrote: > > > > On Fri, Feb 3, 2023 at 2:

Re: [PATCH] drm/amdgpu/display: remove duplicate include header in link_dpms.c

2023-02-09 Thread Jani Nikula
On Thu, 09 Feb 2023, wrote: > From: Ye Xingchen > > link_hwss.h is included more than once. You've got U+00A0 non-breaking space in the subject line. BR, Jani. > > Signed-off-by: Ye Xingchen > --- > drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 - > 1 file changed, 1 deletion(-) > > di

Re: [PATCH] media: Fix building pdfdocs

2023-02-09 Thread Tomi Valkeinen
Hi Daniel, Dave, Could you pick this fix to drm-next? The offending commit is there, it was merged via Laurent's "[GIT PULL FOR v6.3] R-Car DU fixes and improvements". I can also push this to drm-misc-fixes, but the offending commit is not there yet. Tomi On 08/02/2023 13:17, Mauro Carva

Re: [PATCH] drm/vmwgfx: Do not drop the reference to the handle too soon

2023-02-09 Thread Martin Krastev (VMware)
From: Martin Krastev Looks good to me. Reviewed-by: Martin Krastev Regards, Martin On 8.02.23 г. 23:53 ч., Zack Rusin wrote: From: Zack Rusin It is possible for userspace to predict the next buffer handle and to destroy the buffer while it's still used by the kernel. Delay dropping the

[PATCH v2] drm/amd/display: remove duplicate include header

2023-02-09 Thread ye.xingchen
From: Ye Xingchen link_hwss.h is included more than once in link_dpms.c . Signed-off-by: Ye Xingchen --- v1 -> v2 Fix the U+00A0 non-breaking space in the subject line. drivers/gpu/drm/amd/display/dc/link/link_dpms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displa

Re: [PATCH 2/3] drm/debugfs: split registration into dev and minor

2023-02-09 Thread Maíra Canal
On 2/9/23 05:18, Christian König wrote: The different subsystems should probably only register their debugfs files once. This temporary removes the common files from the render node directory. Signed-off-by: Christian König --- drivers/gpu/drm/drm_atomic.c| 4 ++-- drivers/gpu/drm/

[PATCH AUTOSEL 6.1 22/38] drm/nouveau/devinit/tu102-: wait for GFW_BOOT_PROGRESS == COMPLETED

2023-02-09 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit d22915d22ded21fd5b24b60d174775789f173997 ] Starting from Turing, the driver is no longer responsible for initiating DEVINIT when required as the GPU started loading a FW image from ROM and executing DEVINIT itself after power-on. However - we apparently still

[PATCH AUTOSEL 6.1 29/38] drm/amd/display: Add missing brackets in calculation

2023-02-09 Thread Sasha Levin
From: Daniel Miess [ Upstream commit ea062fd28f922cb118bfb33229f405b81aff7781 ] [Why] Brackets missing in the calculation for MIN_DST_Y_NEXT_START [How] Add missing brackets for this calculation Reviewed-by: Nicholas Kazlauskas Acked-by: Alex Hung Signed-off-by: Daniel Miess Tested-by: Dani

[PATCH AUTOSEL 6.1 30/38] drm/amd/display: Adjust downscaling limits for dcn314

2023-02-09 Thread Sasha Levin
From: Daniel Miess [ Upstream commit dd2db2dc4bd298f33dea50c80c3c11bee4e3b0a4 ] [Why] Lower max_downscale_ratio and ARGB888 downscale factor to prevent cases where underflow may occur on dcn314 [How] Set max_downscale_ratio to 400 and ARGB downscale factor to 250 for dcn314 Reviewed-by: Nichol

[PATCH AUTOSEL 6.1 31/38] drm/amd/display: Unassign does_plane_fit_in_mall function from dcn3.2

2023-02-09 Thread Sasha Levin
From: George Shen [ Upstream commit 275d8a1db261a1272a818d40ebc61b3b865b60e5 ] [Why] The hwss function does_plane_fit_in_mall not applicable to dcn3.2 asics. Using it with dcn3.2 can result in undefined behaviour. [How] Assign the function pointer to NULL. Reviewed-by: Alvin Lee Acked-by: Ale

[PATCH AUTOSEL 6.1 32/38] drm/amd/display: Reset DMUB mailbox SW state after HW reset

2023-02-09 Thread Sasha Levin
From: Nicholas Kazlauskas [ Upstream commit 154711aa5759ef9b45903124fa813c4c29ee681c ] [Why] Otherwise we can be out of sync with what's in the hardware, leading to us rerunning every command that's presently in the ringbuffer. [How] Reset software state for the mailboxes in hw_reset callback.

[PATCH AUTOSEL 6.1 33/38] drm/amdgpu: enable HDP SD for gfx 11.0.3

2023-02-09 Thread Sasha Levin
From: Evan Quan [ Upstream commit bb25849c0fa550b26cecc9c476c519a927c66898 ] Enable HDP clock gating control for gfx 11.0.3. Signed-off-by: Evan Quan Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/soc21.c | 3 ++- 1 file changed

[PATCH AUTOSEL 6.1 34/38] drm/amdgpu: Enable vclk dclk node for gc11.0.3

2023-02-09 Thread Sasha Levin
From: Yiqing Yao [ Upstream commit ac7170082c0e140663f0853d3de733a5341ce7b0 ] These sysfs nodes are tested supported, so enable them. Signed-off-by: Yiqing Yao Reviewed-by: Hawking Zhang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 -

[PATCH AUTOSEL 6.1 35/38] drm/amd/display: Properly handle additional cases where DCN is not supported

2023-02-09 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ] There could be boards with DCN listed in IP discovery, but no display hardware actually wired up. In this case the vbios display table will not be populated. Detect this case and skip loading DM when we detect it.

[PATCH AUTOSEL 5.15 12/17] drm/nouveau/devinit/tu102-: wait for GFW_BOOT_PROGRESS == COMPLETED

2023-02-09 Thread Sasha Levin
From: Ben Skeggs [ Upstream commit d22915d22ded21fd5b24b60d174775789f173997 ] Starting from Turing, the driver is no longer responsible for initiating DEVINIT when required as the GPU started loading a FW image from ROM and executing DEVINIT itself after power-on. However - we apparently still

[PATCH AUTOSEL 5.15 16/17] drm/amd/display: Properly handle additional cases where DCN is not supported

2023-02-09 Thread Sasha Levin
From: Alex Deucher [ Upstream commit 6fc547a5a2ef5ce05b16924106663ab92f8f87a7 ] There could be boards with DCN listed in IP discovery, but no display hardware actually wired up. In this case the vbios display table will not be populated. Detect this case and skip loading DM when we detect it.

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Maíra Canal
On 2/9/23 05:18, Christian König wrote: Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between initializing and registering of DRM devices since the underlying debugfs directory wasn't created yet. The resulting necessity

RE: [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-09 Thread Kalyan Thota
Kindly ignore my previous email. Sent too early !! We have tested the changes on top of tip: https://chromium.googlesource.com/chromiumos/third_party/kernel/+log/refs/heads/chromeos-5.15 + 5 CTM patches ( that you have quoted ) We didn’t see the issue that you have reported on herobrine. Night l

Re: [PATCH 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Melissa Wen
On 02/08, Maíra Canal wrote: > As v3d_job_add_deps() performs the same steps as > drm_sched_job_add_syncobj_dependency(), replace the open-coded > implementation in v3d in order to simply, using the DRM function. > > Signed-off-by: Maíra Canal > --- > drivers/gpu/drm/v3d/v3d_gem.c | 9 +

Re: [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-09 Thread Dmitry Baryshkov
On Thu, 9 Feb 2023 at 04:19, Abhinav Kumar wrote: > > > > On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: > > Typically SSPP can support rectangle with width up to 2560. However it's > > Not always 2560. Depends on the chipset. _typically_ > > > possible to use multirect feature and split source t

Re: [PATCH v3 22/27] drm/msm/dpu: rework dpu_plane_sspp_atomic_update()

2023-02-09 Thread Dmitry Baryshkov
On 07/02/2023 02:22, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the sspp-dependent? separate function dpu_plane_sspp_update_pipe(). This is one of preparational steps to add r_pipe support. Signed-o

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-09 Thread Pekka Paalanen
On Wed, 8 Feb 2023 23:16:56 +0200 Ville Syrjälä wrote: > On Wed, Feb 08, 2023 at 03:03:49PM +0200, Ville Syrjälä wrote: > > On Wed, Feb 08, 2023 at 02:13:12PM +0200, Pekka Paalanen wrote: > > > On Wed, 8 Feb 2023 06:09:10 +0200 > > > Ville Syrjala wrote: > > > > > > > From: Ville Syrjälä

[ANNOUNCE] libdrm 2.4.115

2023-02-09 Thread Simon Ser
Alex Deucher (2): amdgpu: add marketing names from amd-5.4 (22.40) amdgpu: add some additional marketing names Lang Yu (1): tests/amdgpu: use AMDGPU_TIMEOUT_INFINITE to query fence Matt Roper (1): intel: Eliminate need to keep adding PCI IDs Philipp Zabel (2): drm_f

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-09 Thread Pekka Paalanen
On Wed, 8 Feb 2023 23:10:16 +0200 Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the DRM_CAP_CU

Re: [PATCH 2/3] drm/debugfs: split registration into dev and minor

2023-02-09 Thread Christian König
Am 09.02.23 um 12:12 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: The different subsystems should probably only register their debugfs files once. This temporary removes the common files from the render node directory. Signed-off-by: Christian König ---   drivers/gpu/drm/drm_a

Re: [PATCH 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Christian König
Am 09.02.23 um 12:27 schrieb Melissa Wen: On 02/08, Maíra Canal wrote: As v3d_job_add_deps() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in v3d in order to simply, using the DRM function. Signed-off-by: Maíra Canal --- drivers/gpu/

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Christian König
Am 09.02.23 um 12:23 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between initializing and registering of DRM devices since the underlying debugfs directory w

Re: [PATCH 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Melissa Wen
On 02/09, Christian König wrote: > Am 09.02.23 um 12:27 schrieb Melissa Wen: > > On 02/08, Maíra Canal wrote: > > > As v3d_job_add_deps() performs the same steps as > > > drm_sched_job_add_syncobj_dependency(), replace the open-coded > > > implementation in v3d in order to simply, using the DRM fun

[PATCH v2] drm/vmwgfx: Do not drop the reference to the handle too soon

2023-02-09 Thread Zack Rusin
From: Zack Rusin v2: Update the commit message to include note describing why the second usag of vmw_gem_object_create_with_handle in vmwgfx_surface.c wasn't changed It is possible for userspace to predict the next buffer handle and to destroy the buffer while it's still used by the kernel. Dela

[PATCH] drm/amd/display: fix link_validation build failure

2023-02-09 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_DRM_AMD_DC_DCN is disabled, the is_frl member is not defined: drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c: In function 'dp_active_dongle_validate_timing': drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c:126:66: error: 'const s

Re: [PATCH 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Christian König
Am 09.02.23 um 13:36 schrieb Melissa Wen: On 02/09, Christian König wrote: Am 09.02.23 um 12:27 schrieb Melissa Wen: On 02/08, Maíra Canal wrote: As v3d_job_add_deps() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in v3d in order to si

[PATCH v2 0/5] drm/sched: Create wrapper to add a syncobj dependency to job

2023-02-09 Thread Maíra Canal
Some drivers perform the same operation to add a syncobj's fence to the sched as a dependency: first, call drm_syncobj_find_fence() to find the fence and then, call drm_sched_job_add_dependency(). Therefore, create a wrapper to encapsulate those steps in one single function. The first patch create

[PATCH v2 1/5] drm/sched: Create wrapper to add a syncobj dependency to job

2023-02-09 Thread Maíra Canal
In order to add a syncobj's fence as a dependency to a job, it is necessary to call drm_syncobj_find_fence() to find the fence and then add the dependency with drm_sched_job_add_dependency(). So, wrap these steps in one single function, drm_sched_job_add_syncobj_dependency(). Reviewed-by: Christia

[PATCH v2 2/5] drm/lima: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Maíra Canal
As lima_gem_add_deps() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in Lima in order to simply use the DRM function. Signed-off-by: Maíra Canal --- drivers/gpu/drm/lima/lima_gem.c | 12 ++-- 1 file changed, 2 insertions(+), 10 d

[PATCH v2 3/5] drm/msm: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Maíra Canal
As msm_parse_deps() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in msm in order to simply use the DRM function. Signed-off-by: Maíra Canal --- drivers/gpu/drm/msm/msm_gem_submit.c | 9 ++--- 1 file changed, 2 insertions(+), 7 delet

[PATCH v2 4/5] drm/panfrost: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Maíra Canal
As panfrost_copy_in_sync() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in Panfrost in order to simply use the DRM function. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Maíra Canal --- drivers/gpu/drm/panfrost/panfrost_drv.c | 11 ++-

[PATCH v2 5/5] drm/v3d: Use drm_sched_job_add_syncobj_dependency()

2023-02-09 Thread Maíra Canal
As v3d_job_add_deps() performs the same steps as drm_sched_job_add_syncobj_dependency(), replace the open-coded implementation in v3d in order to simply use the DRM function. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_gem.c | 22 -- 1 file changed, 4 insertions(+)

[PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

2023-02-09 Thread Colin Ian King
The function name is being reported as dc_link_contruct when it is actually dc_link_construct_phy. Fix this by using %s and the __func__ for the function name. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Maíra Canal
On 2/9/23 09:13, Christian König wrote: Am 09.02.23 um 12:23 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between initializing and registering of DRM devices

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-09 Thread Ville Syrjälä
On Thu, Feb 09, 2023 at 01:58:55PM +0200, Pekka Paalanen wrote: > On Wed, 8 Feb 2023 23:10:16 +0200 > Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > Add a new immutable plane property by which a plane can advertise > > a handful of recommended plane sizes. This would be mostly exposed

Re: DRM accel and debugfs/sysfs

2023-02-09 Thread Maíra Canal
On 2/8/23 15:13, Oded Gabbay wrote: On Wed, Feb 8, 2023 at 8:07 PM Daniel Vetter wrote: On Tue, Feb 07, 2023 at 01:17:47PM -0300, Maíra Canal wrote: On 2/7/23 12:43, Jeffrey Hugo wrote: On 2/7/2023 4:31 AM, Maíra Canal wrote: Hi Stanislaw, On 2/1/23 12:20, Stanislaw Gruszka wrote: Hi I w

Re: [PATCH v2] drm/vmwgfx: Do not drop the reference to the handle too soon

2023-02-09 Thread Martin Krastev (VMware)
From: Martin Krastev LGTM Reviewed-by: Martin Krastev Regards, Martin On 9.02.23 г. 14:37 ч., Zack Rusin wrote: From: Zack Rusin v2: Update the commit message to include note describing why the second usag of vmw_gem_object_create_with_handle in vmwgfx_surface.c wasn't changed It is pos

Re: [PATCH] drm/vmwgfx: Stop accessing buffer objects which failed init

2023-02-09 Thread Martin Krastev (VMware)
From: Martin Krastev Much nicer now. Reviewed-by: Martin Krastev Regards, Martin On 8.02.23 г. 20:00 ч., Zack Rusin wrote: From: Zack Rusin ttm_bo_init_reserved on failure puts the buffer object back which causes it to be deleted, but kfree was still being called on the same buffer in vmw

[PATCH v3 0/6] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-09 Thread Dmitry Baryshkov
Add A660 device to the Qualcomm SM8350 platform and enable it for the sm8350-hdk board. Unfortunately while adding the GPU & related devices I noticed that DT nodes on SM8350 are greatly out of the adress sorting order, so patches 2-4 reorder DT nodes to follow the agreement. Changes since v1: - D

[PATCH v3 1/6] dt-bindings: display/msm/gmu: add Adreno 660 support

2023-02-09 Thread Dmitry Baryshkov
Add Adreno A660 to the A635 clause to define all version-specific properties. There is no need to add it to the top-level clause, since top-level compatible uses pattern to define compatible strings. Acked-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/dis

[PATCH v3 2/6] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-09 Thread Dmitry Baryshkov
Somehow sm8350 got its device nodes not fully sorted. Start reordering DT nodes by their address. Move apps SMMU, GIC, timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper position at the end of /soc/. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 12

[PATCH v3 3/6] arm64: dts: qcom: sm8350: move more nodes to correct place

2023-02-09 Thread Dmitry Baryshkov
Continue ordering DT nodes by their address. Move RNG, UFS, system NoC and SLPI nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 314 +-- 1 file changed, 157 insertions(+), 157 deletions(-) diff --git a/arch/arm64/b

[PATCH v3 4/6] arm64: dts: qcom: sm8350: finish reordering nodes

2023-02-09 Thread Dmitry Baryshkov
Finish reordering DT nodes by their address. Move PDC, tsens, AOSS, SRAM, SPMI and TLMM nodes to the proper position. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 764 +-- 1 file changed, 382 insertions(+), 382 deletions(-) diff --git a/arch

[PATCH v3 5/6] arm64: dts: qcom: sm8350: add GPU, GMU, GPU CC and SMMU nodes

2023-02-09 Thread Dmitry Baryshkov
Add device nodes required to enable GPU on the SM8350 platform. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 178 +++ 1 file changed, 178 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi

[PATCH v3 6/6] arm64: dts: qcom: sm8350-hdk: enable GPU

2023-02-09 Thread Dmitry Baryshkov
Enable the GPU on the SM8350-HDK device. The ZAP shader is required for the GPU to function properly. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm835

Re: [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-09 Thread Dmitry Baryshkov
On 09/02/2023 05:28, Bjorn Andersson wrote: On Mon, Feb 06, 2023 at 04:57:03PM +0200, Dmitry Baryshkov wrote: Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper position at the end of /soc/. I think "ac

[PATCH] drm/amd/display: set should_disable_otg storage-class-specifier to static

2023-02-09 Thread Tom Rix
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c:90:6: warning: symbol 'should_disable_otg' was not declared. Should it be static? should_disable_otg() is only used in dcn315_clk_mgr.c, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/am

[PATCH 00/11] drm,fbdev: Move video= option to drivers/video

2023-02-09 Thread Thomas Zimmermann
The kernel's video= option sets the initial video mode. It is shared by fbdev and DRM, but located within the fbdev code. Move it to drivers/video/ and adapt callers. Allows DRM (and others) to use the option without depending on fbdev. While at it, fix the interface of the lookup functions. This

[PATCH 02/11] fbdev: Transfer video= option strings to caller; clarify ownership

2023-02-09 Thread Thomas Zimmermann
In fb_get_options(), always duplicate the returned option string and transfer ownership of the memory to the function's caller. Until now, only the global option string got duplicated and transferred to the caller; the per-driver options were owned by fb_get_options(). In the end, it was impossibl

[PATCH 03/11] fbdev: Support NULL for name in option-string lookup

2023-02-09 Thread Thomas Zimmermann
Ignore the per-driver video options if no driver name has been specified to fb_get_option(). Return the global options in this case. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/video/

[PATCH 04/11] drivers/ps3: Read video= option with fb_get_option()

2023-02-09 Thread Thomas Zimmermann
Get the kernel's global video= parameter with fb_get_option(). Done to unexport the internal fbdev state fb_mode_config. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/ps3/ps3av.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/ps3/ps3

[PATCH 06/11] fbdev: Unexport fb_mode_option

2023-02-09 Thread Thomas Zimmermann
There are no external users of fb_mode_option. Unexport the variable and declare it static. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 4 +--- include/linux/fb.h| 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/vide

[PATCH 05/11] fbdev: Read video= option with fb_get_option() in modedb

2023-02-09 Thread Thomas Zimmermann
Get the kernel's global video= parameter with fb_get_option(). Done to unexport the internal fbdev state fb_mode_config. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/modedb.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 07/11] fbdev: Move option-string lookup into helper

2023-02-09 Thread Thomas Zimmermann
Move the lookup of the option string into an internal helper. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fb_cmdline.c | 60 --- 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/drivers/video/fbdev/core/fb_cmdline.c

[PATCH 01/11] fbdev: Fix contact info in fb_cmdline.c

2023-02-09 Thread Thomas Zimmermann
Fix Daniel's email address. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Daniel Vetter --- drivers/video/fbdev/core/fb_cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_cmdline.c b/drivers/video/fbdev/core/fb_cmdline.c inde

[PATCH 08/11] fbdev: Handle video= parameter in video/cmdline.c

2023-02-09 Thread Thomas Zimmermann
Handle the command-line parameter video= in video/cmdline.c. Implement the fbdev helper fb_get_options() on top. Will allows to handle the kernel parameter in DRM without fbdev dependencies. Note that __video_get_options() has the meaning of its return value inverted compared to fb_get_options().

[PATCH 11/11] drm: Fix comment on mode parsing

2023-02-09 Thread Thomas Zimmermann
Do not claim that there's a default mode in the video= option parser. if no option string has been given, the parser does nothing. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_modes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_modes.c b/

[PATCH 09/11] driver/ps3: Include for mode parsing

2023-02-09 Thread Thomas Zimmermann
Include in ps3av.c to get video_get_options() and avoid the dependency on . The replaced function fb_get_options() is just a tiny wrapper around video_get_opions(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/ps3/ps3av.c | 18 ++ 1 file changed, 6 inserti

[PATCH 10/11] drm: Include for mode parsing

2023-02-09 Thread Thomas Zimmermann
Include in drm_connector.c to get video_get_options() and avoid the dependency on . The replaced function fb_get_options() is just a tiny wrapper around video_get_opions(). No functional changes. Include to get fwnode_handle_put(), which had been provided via . Signed-off-by: Thomas Zimmermann

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-09 Thread Rob Herring
On Wed, Feb 8, 2023 at 10:00 PM Pin-yen Lin wrote: > > Hi Rob, > > Thanks for the review. > > On Wed, Feb 8, 2023 at 4:52 AM Rob Herring wrote: > > > > On Sat, Feb 04, 2023 at 09:30:38PM +0800, Pin-yen Lin wrote: > > > ITE IT6505 can be used in systems to switch the DP traffic between > > > two d

Re: Try to address the drm_debugfs issues

2023-02-09 Thread Christian König
Am 09.02.23 um 14:06 schrieb Maíra Canal: On 2/9/23 09:13, Christian König wrote: Am 09.02.23 um 12:23 schrieb Maíra Canal: On 2/9/23 05:18, Christian König wrote: Hello everyone, the drm_debugfs has a couple of well known design problems. Especially it wasn't possible to add files between i

  1   2   >