Re: [PATCH v10 10/11] drm/virtio: Support memory shrinking

On Mon, Jan 09, 2023 at 12:04:44AM +0300, Dmitry Osipenko wrote: > Support generic drm-shmem memory shrinker and add new madvise IOCTL to > the VirtIO-GPU driver. BO cache manager of Mesa driver will mark BOs as > "don't need" using the new IOCTL to let shrinker purge the marked BOs on > OOM, the s

Re: [PATCH v10 06/11] drm/shmem-helper: Don't use vmap_use_count for dma-bufs

On Thu, Jan 26, 2023 at 03:24:30PM +0300, Dmitry Osipenko wrote: > On 1/26/23 15:17, Gerd Hoffmann wrote: > > On Mon, Jan 09, 2023 at 12:04:40AM +0300, Dmitry Osipenko wrote: > >> its own refcounting of vmaps, use it instead of drm-shmem > >> counting. This change prepares drm-shmem for addition o

Re: [PATCH v10 00/11] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

On Thu, Jan 26, 2023 at 01:55:09AM +0300, Dmitry Osipenko wrote: > Hello Thomas and Gerd, > > On 1/9/23 00:04, Dmitry Osipenko wrote: > > This series: > > > > 1. Makes minor fixes for drm_gem_lru and Panfrost > > 2. Brings refactoring for older code > > 3. Adds common drm-shmem memory shrin

Re: [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

On 26/01/2023 19:36, Jon Cormier wrote: > On Thu, Jan 26, 2023 at 10:40 AM Krzysztof Kozlowski < > krzysztof.kozlow...@linaro.org> wrote: > >> On 25/01/2023 22:09, Jonathan Cormier wrote: >>> Add a i2c example with HDMI connector >> >> Why? It's the same - but more on this below. >> > The existing

[PATCH v8 01/25] llist: Move llist_{head,node} definition to types.h

llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

[PATCH v8 16/25] dept: Apply sdt_might_sleep_{start, end}() to dma fence wait

Makes Dept able to track dma fence waits. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 406b4e2..1db4bc0 100644 --- a/drivers/dma-buf/dma-fence.c +++ b/drivers

[PATCH v8 06/25] dept: Add proc knobs to show stats and dependency graph

It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 -- kernel/dependency/dept_internal.h | 26

[PATCH v8 14/25] dept: Add a mechanism to refill the internal memory pools on running out

Dept engine works in a constrained environment. For example, Dept cannot make use of dynamic allocation e.g. kmalloc(). So Dept has been using static pools to keep memory chunks Dept uses. However, Dept would barely work once any of the pools gets run out. So implemented a mechanism for the refill

[PATCH v8 10/25] dept: Apply sdt_might_sleep_{start, end}() to waitqueue wait

Makes Dept able to track dependencies by waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index a0307b5..ff349e6 100644 --- a/include/linux/wait.h +++ b/include/linux/wait.h

[PATCH v8 05/25] dept: Tie to Lockdep and IRQ tracing

Yes. How to place Dept in here looks so ugly. But it's inevitable as long as relying on Lockdep. The way should be enhanced gradually. 1. Basically relies on Lockdep to track typical locks and IRQ things. 2. Dept fails to recognize IRQ situation so it generates false alarms when raw_l

[PATCH v8 20/25] dept: Apply timeout consideration to waitqueue wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to waitqueue wait, assuming an input 'ret' in ___wait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v8 15/25] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, fal

[PATCH v8 02/25] dept: Implement Dept(Dependency Tracker)

CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v8 13/25] dept: Distinguish each work from another

Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH] drm/virtio: exbuf->fence_fd unmodified on interrupted wait

An interrupted dma_fence_wait() becomes an -ERESTARTSYS returned to userspace ioctl(DRM_IOCTL_VIRTGPU_EXECBUFFER) calls, prompting to retry the ioctl(), but the passed exbuf->fence_fd has been reset to -1, making the retry attempt fail at sync_file_get_fence(). The uapi for DRM_IOCTL_VIRTGPU_EXECB

[PATCH v8 24/25] dept: Make Dept able to work with an external wgen

There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH v8 08/25] dept: Apply sdt_might_sleep_{start, end}() to PG_{locked, writeback} wait

Makes Dept able to track dependencies by PG_{locked,writeback} waits. Signed-off-by: Byungchul Park --- mm/filemap.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/mm/filemap.c b/mm/filemap.c index c4d4ace..adc49cb 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -42,6 +42,7 @@

[PATCH v8 00/25] DEPT(Dependency Tracker)

I'm happy to see that DEPT reports a real problem in practice. See: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a4856...@i-love.sakura.ne.jp/#t https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.p...@lge.com/ Nevertheless, I apologize for the lack of doc

[PATCH v8 18/25] dept: Apply timeout consideration to wait_for_completion()/complete()

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 4 ++-- kernel/sched/completion.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v8 23/25] dept: Record the latest one out of consecutive waits of the same class

The current code records all the waits for later use to track relation between waits and events in each context. However, since the same class is handled the same way, it'd be okay to record only one on behalf of the others if they all have the same class. Even though it's the ideal to search the

[PATCH v8 03/25] dept: Add single event dependency tracker APIs

Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate (the simplest way): 1. Initaialize a map for the interesting wait. /*

[PATCH v8 17/25] dept: Track timeout waits separately with a new Kconfig

Waits with valid timeouts don't actually cause deadlocks. However, Dept has been reporting the cases as well because it's worth informing the circular dependency for some cases where, for example, timeout is used to avoid a deadlock but not meant to be expired. However, yes, there are also a lot o

[PATCH 00/35] Documentation: correct lots of spelling errors (series 1)

Correct many spelling errors in Documentation/ as reported by codespell. Maintainers of specific kernel subsystems are only Cc-ed on their respective patches, not the entire series. [if all goes well] These patches are based on linux-next-20230125. [PATCH 01/35] Documentation: arm64: correct s

[PATCH v8 22/25] dept: Apply timeout consideration to dma fence wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

[PATCH v8 09/25] dept: Apply sdt_might_sleep_{start,end}() to swait

Makes Dept able to track dependencies by swaits. Signed-off-by: Byungchul Park --- include/linux/swait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index 6a8c22b..0284821 100644 --- a/include/linux/swait.h +++ b/include/linux/swait.h @@ -

[PATCH v8 12/25] dept: Distinguish each syscall context from another

It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH v8 04/25] dept: Add lock dependency tracker APIs

Wrapped the base APIs for easier annotation on typical lock. Signed-off-by: Byungchul Park --- include/linux/dept_ldt.h | 77 1 file changed, 77 insertions(+) create mode 100644 include/linux/dept_ldt.h diff --git a/include/linux/dept_ldt.h b/in

[PATCH v8 11/25] dept: Apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

Makes Dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 7725b75..fe89282 100644 --- a/include/linux/wait_bit.h +++

[PATCH v8 25/25] dept: Track the potential waits of PG_{locked, writeback}

Currently, Dept only tracks the real waits of PG_{locked,writeback} that actually happened having gone through __schedule() to avoid false positives. However, it ends in limited capacity for deadlock detection, because anyway there might be still way more potential dependencies by the waits that ha

[PATCH v8 19/25] dept: Apply timeout consideration to swait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v8 07/25] dept: Apply sdt_might_sleep_{start, end}() to wait_for_completion()/complete()

Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/include/linux/completion.h b/include/linux/completion.h inde

[PATCH v8 21/25] dept: Apply timeout consideration to hashed-waitqueue wait

Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to hashed-waitqueue wait, assuming an input 'ret' in ___wait_var_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v2 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

On 26/01/2023 23:40, Jonathan Cormier wrote: > Add a i2c example with HDMI connector > > Signed-off-by: Jonathan Cormier > --- > .../bindings/display/bridge/ti,tfp410.yaml | 30 > ++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindin

Re: [PATCH V12 0/4] drm/panel: Add Magnachip D53E6EA8966 Panel Controller

Hi Chris, patches look good to me, Maxime is happy, so: On Mon, Jan 23, 2023 at 4:46 PM Chris Morgan wrote: > Chris Morgan (4): > drm: of: Add drm_of_get_dsi_bus helper function > dt-bindings: display: panel: Add Samsung AMS495QA01 > drm/panel: Add Magnachip D53E6EA8966 Panel Driver Thes

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

Hi Gwan-gyeong, thanks for the review and the thorough explanation. On Fri, Jan 27, 2023 at 08:50:26AM +0200, Gwan-gyeong Mun wrote: > > > On 1/11/23 5:36 PM, Andi Shyti wrote: > > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > > > On Wed, 11 Jan 2023, Andi Shyti wrote: > > > >

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

Le ven. 27 janv. 2023 à 07:01, Ben Skeggs a écrit : > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo > > > wrote: > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wr

Re: [PATCH v7 3/6] mei: clean pending read with vtag on bus

On Wed, Jan 25, 2023 at 12:26:34AM -0800, Alan Previn wrote: > From: Alexander Usyskin > > Client on bus have only one vtag map slot and should disregard the vtag > value when cleaning pending read flag. > Fixes read flow control message unexpectedly generated when > clent on bus send messages wi

Re: [PATCH v7 1/6] mei: mei-me: resume device in prepare

On Wed, Jan 25, 2023 at 12:26:32AM -0800, Alan Previn wrote: > From: Alexander Usyskin > > Asynchronous runtime resume is not possible while the system > is suspending. > The power management subsystem resumes the device only in the > suspend phase, not in the prepare phase. > Force resume device

Re: [PATCH v7 3/6] mei: clean pending read with vtag on bus

On Wed, Jan 25, 2023 at 12:28:29PM -0500, Rodrigo Vivi wrote: > > Greg, ack on getting these 3 mei patches merged through intel-gfx? I only see 2 mei patches in this series, what am I missing? thanks, greg k-h

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

On 27.01.23 08:39, Greg KH wrote: > On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: >> On 1/20/2023 11:46, Guenter Roeck wrote: >>> On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why]

Re: [PATCH 1/2] accep/ivpu: PM: remove broken ivpu_dbg() statements

On Thu, Jan 26, 2023 at 05:37:54PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PM is disabled, the driver fails to build: > > drivers/accel/ivpu/ivpu_pm.c: In function 'ivpu_rpm_get': > drivers/accel/ivpu/ivpu_pm.c:240:84: error: 'struct dev_pm_info' has no > member named

[PATCH] accel: work around DRM_ACCEL dependencies

From: Arnd Bergmann At the moment, accel drivers can be built-in even with CONFIG_DRM=m, but this causes a link failure: x86_64-linux-ld: drivers/accel/ivpu/ivpu_drv.o: in function `ivpu_dev_init': ivpu_drv.c:(.text+0x1535): undefined reference to `drmm_kmalloc' x86_64-linux-ld: ivpu_drv.c:(.tex

Re: [PATCH v3 5/6] drm/rockchip: vop2: add support for the rgb output block

On 1/24/23 06:47, Michael Riesch wrote: > The Rockchip VOP2 features an internal RGB output block, which can be > attached any video port of the VOP2. Add support for this output block. s/attached any/attached to any/ of course. Can this be fixed when the patch is applied? Michael > Signed-off-b

Re: [RFC v3 00/12] DRM scheduling cgroup controller

On Thu, Jan 26, 2023 at 05:57:24PM +, Tvrtko Ursulin wrote: > So even if the RFC shows just a simple i915 implementation, the controller > itself shouldn't prevent a smarter approach (via exposed ABI). scan/query + over budget notification is IMO limited in guarantees. > [...] > Yes agreed,

[v12] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few nit

[PATCH 0/3] Reserve dspps based on user request

This series will enable color features on sc7280 target which has primary panel as eDP The series removes dspp allocation based on encoder type and allows the dspp reservation based on user request via ctm. The series will release/reserve the dpu resources when ever there is a topology change

[PATCH 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

Some features like ctm can be enabled dynamically. Release and reserve the dpu resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 1 + drivers/gpu/drm/msm/disp/dpu1/d

[PATCH 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request

Add dspp blocks into the topology for reservation, if there is a ctm request for that composition. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encod

[PATCH 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release

Clear dspp reservations from the global state during rm release Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 73b3442..718ea0a 100

Re: [PATCH] accel: work around DRM_ACCEL dependencies

Hi On Fri, Jan 27, 2023 at 10:36:20AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > At the moment, accel drivers can be built-in even with CONFIG_DRM=m, > but this causes a link failure: > > x86_64-linux-ld: drivers/accel/ivpu/ivpu_drv.o: in function `ivpu_dev_init': > ivpu_drv.c:(.text

Re: [PATCH 2/2] gpu: ipu-v3: pre: add dynamic buffer layout reconfiguration

On Thu, Jan 26, 2023 at 07:47:44PM +0100, Lucas Stach wrote: > imx-drm doesn't mandate a modeset when the framebuffer modifier changes, > but currently the tile prefetch and resolve (TPR) configuration of the > PRE is only set up on the initial modeset. > > As the TPR configuration is double buffe

Re: [PATCH 1/2] gpu: ipu-v3: pre: move state into struct

On Thu, Jan 26, 2023 at 07:47:43PM +0100, Lucas Stach wrote: > Move the variables tracking the current dynamic state into a struct > to separate it a bit better from the static device properties. > > Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH] accel: work around DRM_ACCEL dependencies

On Fri, Jan 27, 2023, at 11:17, Stanislaw Gruszka wrote: > On Fri, Jan 27, 2023 at 10:36:20AM +0100, Arnd Bergmann wrote: >> I think it will be necessary to establish a link hierarchy between drm.ko >> and drm_accel.ko to avoid circular dependencies like this, but until then >> the only way that b

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

ABLK_PD_LCDIF_1>; status = "disabled"; port { lcdif_out_dsi: endpoint { remote-endpoint = <&dsi_in_lcdif>; }; }; }; The lcdif1 node is based on h

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

On Fri, Jan 27, 2023 at 4:03 PM Rasmus Villemoes wrote: > > Hi Jagan and others > > I'm trying to test this series on our imx8mp-based boards, which has the > mipi-dsi connected to a ti,sn65dsi86 bridge (in turn connected to a > full-size DP-connector). But I don't know how to add the proper nodes

Re: [PATCH 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release

On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Clear dspp reservations from the global state during > rm release > > Signed-off-by: Kalyan Thota Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo > > > wrote: > > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airl

[PATCH v2] drm/vc4: hvs: Defer dlist slots deallocation

_HANDLED; + } } /* Clear every per-channel interrupt flag. */ @@ -794,6 +974,8 @@ struct vc4_hvs *__vc4_hvs_alloc(struct vc4_dev *vc4, struct platform_device *pde hvs->pdev = pdev; spin_lock_init(&hvs->mm_lock); + INIT_LIST_HEAD(&hvs->stale_dlist_entries); + INIT_WORK(&hvs->free_dlist_work, vc4_hvs_dlist_free_work); /* Set up the HVS display list memory manager. We never * overwrite the setup from the bootloader (just 128b out of --- base-commit: e2f86c02fdc96ca29ced53221a3cbf50aa6f8b49 change-id: 20230127-rpi-cursor-corruption-c98fc609ab18 Best regards, -- Maxime Ripard

Re: [PATCH 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request

On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Add dspp blocks into the topology for reservation, if there is a ctm > request for that composition. ... rather than just allocating them for DSI encoders. With this fixed (and one nit below): Reviewed-by: Dmitry Baryshkov > > Signed-off-b

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

On Fri, Jan 27, 2023 at 10:03:17AM +0100, Nicolas Chauvet wrote: > I've tried to run glmark2-wayland under weston with DRI_PRIME=1, it > seems to work at the beginning, but then I have the following error: > > [ 1510.861730] nouveau 5700.gpu: gr: DATA_ERROR 0003 > [INVALID_OPERATION] ch 3

Re: [PATCH v2 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

Hi Joakim, Hi Etienne, Let me bring back this pull request for OPTEE Linux driver. Last feedback was from Christian König and Sumit Garg. >From Christian: > Just two comments: > > 1. Dmitry is working on a change which renames some functions and > makes > it mandatory to call them with the dma_r

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

On 27/01/2023 11.39, Jagan Teki wrote: > On Fri, Jan 27, 2023 at 4:03 PM Rasmus Villemoes > wrote: >> >> Hi Jagan and others >> >> I'm trying to test this series on our imx8mp-based boards, which has the >> mipi-dsi connected to a ti,sn65dsi86 bridge (in turn connected to a >> full-size DP-connect

[PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. Signed-off-by: Jean Delvare Cc: David Airlie Cc

[PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed. Signed-off-by: Jean Delvare Cc: Paul Kocialkowsk

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

On Fri, Jan 27, 2023 at 4:26 PM Rasmus Villemoes wrote: > > On 27/01/2023 11.39, Jagan Teki wrote: > > On Fri, Jan 27, 2023 at 4:03 PM Rasmus Villemoes > > wrote: > >> > >> Hi Jagan and others > >> > >> I'm trying to test this series on our imx8mp-based boards, which has the > >> mipi-dsi connect

[PULL] drm-intel-next

Hi Dave & Daniel - drm-intel-next-2023-01-27: drm/i915 feature pull #2 v6.3: Features and functionality: - Enable HF-EEODB by switching HDMI, DP and LVDS to use struct drm_edid (Jani) - Start using unversioned DMC firmware paths for new platforms (Gustavo) Refactoring and cleanups: - ELD refac

Re: [PATCH v2 1/1] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

Hi guys, Am 27.01.23 um 11:54 schrieb Olivier Masse: Hi Joakim, Hi Etienne, Let me bring back this pull request for OPTEE Linux driver. Last feedback was from Christian König and Sumit Garg. From Christian: Just two comments: 1. Dmitry is working on a change which renames some functions and

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. @nouveau-maintainers, did anyone take a look at this? The report is already 8 days old and I don't see a single reply. Sure, we'll likely get a -rc8, but still it would be good to no

Re: [PATCH 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Some features like ctm can be enabled dynamically. Release and reserve > the dpu resources whenever a topology change occurs such that > required hw blocks are allocated appropriately. > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/m

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

Where was the original email sent to anyway, because I don't have it at all. Anyhow, I suspect we want to fetch logs to see what's happening, but due to the nature of this bug it might get difficult. I'm checking out the laptops I have here if I can reproduce this issue, but I think all mine with

Re: [RFC v3 00/12] DRM scheduling cgroup controller

On 27/01/2023 10:04, Michal Koutný wrote: On Thu, Jan 26, 2023 at 05:57:24PM +, Tvrtko Ursulin wrote: So even if the RFC shows just a simple i915 implementation, the controller itself shouldn't prevent a smarter approach (via exposed ABI). scan/query + over budget notification is IMO l

Re: [PATCH] drm/nouveau/mmu: fix Use after Free bug in nvkm_vmm_node_split

On Tue, 03 Jan 2023 15:07:55 +0100, Takashi Iwai wrote: > > On Fri, 30 Dec 2022 08:27:58 +0100, > Zheng Wang wrote: > > > > Here is a function call chain. > > nvkm_vmm_pfn_map->nvkm_vmm_pfn_split_merge->nvkm_vmm_node_split > > If nvkm_vma_tail return NULL in nvkm_vmm_node_split, it will > > final

Re: [PATCH v12 00/18] drm: Add Samsung MIPI DSIM bridge

On 1/27/23 12:04, Jagan Teki wrote: On Fri, Jan 27, 2023 at 4:26 PM Rasmus Villemoes wrote: On 27/01/2023 11.39, Jagan Teki wrote: On Fri, Jan 27, 2023 at 4:03 PM Rasmus Villemoes wrote: Hi Jagan and others I'm trying to test this series on our imx8mp-based boards, which has the mipi-dsi

Re: [PATCH v2 01/16] of: device: make of_device_uevent_modalias() take a const device *

On Wed, Jan 11, 2023 at 08:54:04AM -0600, Rob Herring wrote: > On Wed, Jan 11, 2023 at 5:30 AM Greg Kroah-Hartman > wrote: > > > > of_device_uevent_modalias() does not modify the device pointer passed to > > it, so mark it constant. In order to properly do this, a number of > > busses need to hav

Re: [RFC v3 00/12] DRM scheduling cgroup controller

On Fri, Jan 27, 2023 at 11:40:58AM +, Tvrtko Ursulin wrote: > The main point is, should someone prove me wrong and come up a smarter way > at some point in the future, then "drm.weight" as an ABI remains compatible > and the improvement can happen completely under the hood. In the mean time >

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: > +static int drmcs_can_attach(struct cgroup_taskset *tset) > +{ > + int ret; > + > + /* > + * As processes are getting moved between groups we need to ensure > + * both that the old group does not see a sudden down

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: > > > + some more people based on e1a7ab4fca0c > > On 19/01/2023 17:32, Rob Clark wrote: > > From: Rob Clark > > > > Adding the vm to the vm_xa table makes it visible to userspace, which > > could try to race with us to close the vm. So we need

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode

Re: [PATCH 5/7] drm/vmwgfx: Cleanup the vmw bo usage in the cursor paths

Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Base mapped count is useless because the ttm unmap functions handle null maps just fine so completely remove all the code related to it. Rename dummy to is_iomem because that's what it is even if we're not activelly using it. Makes t

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

Am 27.01.23 um 14:12 schrieb Danilo Krummrich: On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UA

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On 27/01/2023 13:01, Michal Koutný wrote: On Thu, Jan 12, 2023 at 04:56:07PM +, Tvrtko Ursulin wrote: +static int drmcs_can_attach(struct cgroup_taskset *tset) +{ + int ret; + + /* +* As processes are getting moved between groups we need to ensure +* both that

Re: [PATCH 6/7] drm/vmwgfx: Abstract placement selection

Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Problem with explicit placement selection in vmwgfx is that by the time the buffer object needs to be validated the information about which placement was supposed to be used is lost. To workaround this the driver had a bunch of state

Re: [PATCH 1/7] drm/vmwgfx: Use the common gem mmap instead of the custom code

Hi Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin Before vmwgfx supported gem it needed to implement the entire mmap logic explicitly. With GEM support that's not needed and the generic code can be used by simply setting the vm_ops to vmwgfx specific ones on the gem object itself.

Re: [Intel-gfx] [PATCH] drm/i915: Avoid potential vm use-after-free

On 27/01/2023 13:10, Matthew Auld wrote: On Mon, 23 Jan 2023 at 16:57, Tvrtko Ursulin wrote: + some more people based on e1a7ab4fca0c On 19/01/2023 17:32, Rob Clark wrote: From: Rob Clark Adding the vm to the vm_xa table makes it visible to userspace, which could try to race with us to

Re: [PATCH 3/7] drm/vmwgfx: Rename vmw_buffer_object to vmw_bo

Am 26.01.23 um 18:38 schrieb Zack Rusin: From: Zack Rusin The rest of the drivers which are using ttm have mostly standardized on driver_prefix_bo as the name for subclasses of the TTM buffer object. Make vmwgfx match the rest of the drivers and follow the same naming semantics. This is espe

Re: [PATCH] drm: override detected status for connectors which are forced on

Hi Michael, all, On Fri, Jan 20, 2023 at 10:03:48AM +0100, Michael Rodin wrote: > Hi Maxime, > > thank you for your feedback! > On Thu, Dec 22, 2022 at 06:40:54PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote: > > > The detected status

Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control

On Fri, Jan 27, 2023 at 01:31:54PM +, Tvrtko Ursulin wrote: > I think you missed the finish_suspend_scanning() part: > > if (root_drmcs.suspended_period_us) > cancel_delayed_work_sync(&root_drmcs.scan_work); > > So if scanning was in progress migration will wait until it

Re: [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

Hi Am 25.01.23 um 21:52 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver

Re: [PATCH v3 02/10] drm/client: Add hotplug_failed flag

Hi Am 25.01.23 um 21:57 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:07PM +0100, Thomas Zimmermann wrote: Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled wi

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

On 26/01/2023 17:16, Konrad Dybcio wrote: A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just tha

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

Hi Am 25.01.23 um 22:03 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such as

Re: [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

Hey Greg, On 1/27/23 02:39, Greg KH wrote: On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: On 1/20/2023 11:46, Guenter Roeck wrote: On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. [Why] Changes cause

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

On 1/27/23 14:23, Christian König wrote: Am 27.01.23 um 14:12 schrieb Danilo Krummrich: On 1/27/23 08:55, Christian König wrote: Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This comm

Re: [PATCH] drm/mediatek: mtk_drm_crtc: Add checks for devm_kcalloc

Hi, Ruanjinjie: Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2022年12月5日 週一 下午7:53寫道： > > Il 05/12/22 10:51, ruanjinjie ha scritto: > > As the devm

[PATCH] drm/vc4: crtc: Increase setup cost in core clock calculation to handle extreme reduced blanking

From: Dom Cobley The formula that determines the core clock requirement based on pixel clock and blanking has been determined experimentally to minimise the clock while supporting all modes we've seen. A new reduced blanking mode (4kp60 at 533MHz rather than the standard 594MHz) has been seen th

RE: [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr

> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 24, 2023 10:15 PM > To: Vinod Polimera > Cc: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; Sankeerth > Billaka

RE: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

[Public] > -Original Message- > From: Linux kernel regression tracking (Thorsten Leemhuis) > > Sent: Friday, January 27, 2023 03:15 > To: Greg KH ; Limonciello, Mario > > Cc: dri-devel@lists.freedesktop.org; sta...@vger.kernel.org; > stanislav.lisovs...@intel.com; Zuo, Jerry ; amd- > g

Re: [PATCH v2] drm/mediatek: Clean dangling pointer on bind error path

Hi, Nicolas: Nícolas F. R. A. Prado 於 2022年11月22日 週二 下午10:39寫道： > > mtk_drm_bind() can fail, in which case drm_dev_put() is called, > destroying the drm_device object. However a pointer to it was still > being held in the private object, and that pointer would be passed along > to DRM in mtk_drm_

  1   2   >