Re: [PATCH 01/86] drm/komeda: Direct include headers from drm_print

2023-01-23 Thread Thomas Zimmermann
Hi Sam Am 21.01.23 um 21:07 schrieb Sam Ravnborg via B4 Submission Endpoint: From: Sam Ravnborg Direct include the headers that otherwise comes indirect from The grammar in this sentence is slightly off at 'direct include' and 'headers that [...] comes'. I'd write 'Directly include header

Re: [PATCH 84/86] drm/drm_atomic_helper: Minimize include footprint

2023-01-23 Thread Thomas Zimmermann
Hi, in the subject line, I'd use 'dependencies' instead of 'footprint'. Your choice. Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint: From: Sam Ravnborg Reduce drm_atomic_helper.h to include or forward the minimal set of files/symbols - to minimize the impact of the fil

Re: [PATCH] drm/vc4: hdmi: make CEC adapter name unique

2023-01-23 Thread Hans Verkuil
On 20/01/2023 20:13, Maxime Ripard wrote: > Hi Hans, > > On Thu, Jan 19, 2023 at 10:02:19AM +0100, Hans Verkuil wrote: >> The bcm2711 has two HDMI outputs, each with their own CEC adapter. >> The CEC adapter name has to be unique, but it is currently >> hardcoded to "vc4" for both outputs. Change

[PATCH] drm/msm/dpu: fix sm8450 CTL configuration

2023-01-23 Thread Dmitry Baryshkov
Correct the CTL size on sm8450 platform. This fixes the incorrect merge of sm8350 support, which unfortunately also touched the SM8450 setup. Fixes: 0e91bcbb0016 ("drm/msm/dpu: Add SM8350 to hw catalog") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 10

Re: [PATCH 2/2] drm: lcdif: Add i.MX93 LCDIF support

2023-01-23 Thread Lothar Waßmann
Hi, On Mon, 23 Jan 2023 15:23:58 +0800 Liu Ying wrote: > The LCDIF embedded in i.MX93 SoC is essentially the same to those > in i.MX8mp SoC. However, i.MX93 LCDIF may connect with MIPI DSI > controller through LCDIF cross line pattern(controlled by mediamix > blk-ctrl) or connect with LVDS displa

[RFC] Proposal for X.Org EVoC

2023-01-23 Thread Siddh Raman Pant
Hello, I want to participate in X.Org EVoC as I am looking to learn and contribute more to the Linux kernel. I have made a draft proposal at https://gitlab.freedesktop.org/-/snippets/7366. Please take a look at it and let me know your thoughts. I am also looking for a mentor. I had tried earlie

Re: [PATCH v2 04/13] iio: imu: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Jonathan Cameron
On Fri, 20 Jan 2023 00:23:33 +0530 Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the > tra

Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-23 Thread Tomi Valkeinen
On 20/01/2023 19:05, Laurent Pinchart wrote: On Fri, Jan 20, 2023 at 06:18:07PM +0200, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. Another small comment: in the commit message, s/lvsd/lvds/ Yep. On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: Reset LVDS usin

Re: [PATCH v2 2/7] drm: rcar-du: lvds: Add runtime PM

2023-01-23 Thread Tomi Valkeinen
On 20/01/2023 18:16, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:04AM +0200, Tomi Valkeinen wrote: Add simple runtime PM suspend and resume functionality. I think you need to depend on PM in Kconfig. That's not a compile-time dependency but a runti

Re: [PATCH 0/7] Fix MST on amdgpu

2023-01-23 Thread Didier 'OdyX' Raboud
For the whole series, as rebased on v6.1.7. Tested on this Thinkpad X13 AMD Gen2: Tested-By: Didier Raboud Le vendredi, 20 janvier 2023, 00.51:53 h CET Harry Wentland a écrit : > MST has been broken on amdgpu after a refactor in drm_dp_mst > code that was aligning drm_dp_mst more closely with t

Re: [PATCH v3 0/2] drm/bridge: fsl-ldb: Add i.MX93 LDB support

2023-01-23 Thread Neil Armstrong
Hi, On Mon, 23 Jan 2023 10:14:47 +0800, Liu Ying wrote: > This patch set aims to add i.MX93 LVDS Display Bridge(LDB) support in > the existing i.MX8mp LDB DRM bridge driver. Same to i.MX8mp LDB, i.MX93 > LDB is controlled by mediamix blk-ctrl through two registers. i.MX93 > LDB supports only one

[PATCH 10/15] serial: ambarella: add support for Ambarella uart_port

2023-01-23 Thread Li Chen
This driver add support for Ambarella's uart, which can be used for console and etc. Signed-off-by: Li Chen Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 --- MAINTAINERS |1 + drivers/tty/serial/Kconfig | 16 + drivers/tty/serial/Makefile |

Re: [PATCH 1/2] dt-bindings: lcdif: Add i.MX93 LCDIF support

2023-01-23 Thread Krzysztof Kozlowski
On 23/01/2023 08:23, Liu Ying wrote: > There is one LCDIF embedded in i.MX93 SoC to connect with > MIPI DSI controller through LCDIF cross line pattern(controlled > by mediamix blk-ctrl) or connect with LVDS display bridge(LDB) > directly or connect with a parallel display through parallel > displa

Re: [PATCH 85/86] drm: move drm_timeout_abs_to_jiffies to drm_util

2023-01-23 Thread Thomas Zimmermann
Hi Sam, please see my comment below. Am 21.01.23 um 21:09 schrieb Sam Ravnborg via B4 Submission Endpoint: From: Sam Ravnborg drm_timeout_abs_to_jiffies() was implmented in drm_syncobj where it really did not belong. Create a drm_util file and move the implementation. Likewise move the protot

Re: [PATCH 00/86] drm: Header file maintenance

2023-01-23 Thread Thomas Zimmermann
Hi Sam, nice patchset. For patches 1 to 84, you can add Reviewed-by: Thomas Zimmermann Please consider my (few) comments. For patches 85 and 86, others may want to comment on those. Ping me if no reviewers shown up in the next days. Best regards Thomas Am 21.01.23 um 21:07 schrieb Sam Rav

Re: [PATCH v11 3/3] drm: exynos: dsi: Restore proper bridge chain order

2023-01-23 Thread Frieder Schrempf
On 20.01.23 20:42, Dave Stevenson wrote: > Hi Jagan > > On Fri, 20 Jan 2023 at 19:10, Jagan Teki wrote: >> >> Hi Dave, >> >> On Sat, Jan 21, 2023 at 12:26 AM Dave Stevenson >> wrote: >>> >>> Hi Jagan >>> >>> Responding due to Marek's comment on the "Add Samsung MIPI DSIM >>> bridge" series, alth

Re: [PATCH v4 7/8] drm/simpledrm: Support the XB24/AB24 format

2023-01-23 Thread Thomas Zimmermann
Hi Am 20.01.23 um 18:31 schrieb Thierry Reding: From: Thierry Reding Add XB24 and AB24 to the list of supported formats. The format helpers support conversion to these formats and they are documented in the simple-framebuffer device tree bindings. Signed-off-by: Thierry Reding Reviewed-by:

RE: [PATCH] drm/ssd130x: Silence a `dubious: x & !y` warning

2023-01-23 Thread David Laight
From: Javier Martinez Canillas > Sent: 21 January 2023 19:10 > > The sparse tool complains with the following warning: > > $ make M=drivers/gpu/drm/solomon/ C=2 > CC [M] drivers/gpu/drm/solomon/ssd130x.o > CHECK drivers/gpu/drm/solomon/ssd130x.c > drivers/gpu/drm/solomon/ssd130x.c:363:21:

Re: [PATCH] drm/ssd130x: Silence a `dubious: x & !y` warning

2023-01-23 Thread Javier Martinez Canillas
Hello David, Thanks for your feedback. On 1/23/23 10:26, David Laight wrote: > From: Javier Martinez Canillas >> Sent: 21 January 2023 19:10 >> >> The sparse tool complains with the following warning: >> >> $ make M=drivers/gpu/drm/solomon/ C=2 >> CC [M] drivers/gpu/drm/solomon/ssd130x.o >>

Re: [PATCH 52/86] drm/imx: Direct include headers from drm_atomic_helper

2023-01-23 Thread Philipp Zabel
On Sat, Jan 21, 2023 at 09:08:30PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > Direct include the headers that otherwise comes indirect from > drm_atomic_helper, because drm_atomic_helper will be reduced to > include only the minimal set of headers. > > Signed

Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port

2023-01-23 Thread Greg Kroah-Hartman
On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 Please always use scripts/checkpatch.pl so you don't get grumpy main

Re: [PATCH v8 4/8] drm/edid: remove redundant _drm_connector_update_edid_property()

2023-01-23 Thread Jani Nikula
On Thu, 19 Jan 2023, Jani Nikula wrote: > Realize that drm_edid_connector_update() and > _drm_connector_update_edid_property() are now the same thing. Drop the > latter. > > Cc: Ville Syrjälä > Reviewed-by: Ville Syrjälä > Signed-off-by: Jani Nikula Thanks for the reviews, pushed 1-4 to drm-mi

Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port

2023-01-23 Thread Greg Kroah-Hartman
On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > --- > MAINTAINERS |1 + > drivers/tty/

Re: [PATCH V11 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-23 Thread Maxime Ripard
On Thu, Jan 19, 2023 at 09:09:03AM -0600, Chris Morgan wrote: > On Thu, Jan 19, 2023 at 09:15:42AM +0100, Maxime Ripard wrote: > > Hi, > > > > On Wed, Jan 18, 2023 at 05:31:32PM -0600, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Add helper function to find DSI host for devices where

Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI

2023-01-23 Thread Boris Brezillon
On Sun, 22 Jan 2023 17:48:37 + Matthew Brost wrote: > On Fri, Jan 20, 2023 at 11:22:45AM +0100, Boris Brezillon wrote: > > On Thu, 19 Jan 2023 16:38:06 + > > Matthew Brost wrote: > > > > > On Thu, Jan 19, 2023 at 04:36:43PM +0100, Danilo Krummrich wrote: > > > > On 1/19/23 05:58, Ma

Re: [PATCH 1/8] iommu: Add a gfp parameter to iommu_map()

2023-01-23 Thread Joerg Roedel
On Fri, Jan 20, 2023 at 01:53:40PM -0400, Jason Gunthorpe wrote: > > Well, having GFP parameters is not a strict kernel convention. There are > > places doing it differently and have sleeping and atomic variants of > > APIs. I have to say I like the latter more. But given that this leads to > > an

[PATCH 05/10] drm/fb-helper: Remove preferred_bpp parameter from fbdev internals

2023-01-23 Thread Thomas Zimmermann
Store the console's preferred BPP value in struct drm_fb_helper and remove the respective function parameters from the internal fbdev code. The BPP value is only required as a fallback and will now always be available in the fb-helper instance. No functional changes. Signed-off-by: Thomas Zimmer

[PATCH 08/10] drm/fbdev-generic: Minimize client unregistering

2023-01-23 Thread Thomas Zimmermann
For uninitialized framebuffers, only release the DRM client and free the fbdev memory. Do not attempt to clean up the framebuffer. DRM fbdev clients have a two-step initialization: first create the DRM client; then create the framebuffer device on the first successful hotplug event. In cases where

[PATCH 07/10] drm/fbdev-generic: Minimize hotplug error handling

2023-01-23 Thread Thomas Zimmermann
Call drm_fb_helper_init() in the generic-fbdev hotplug helper to revert the effects of drm_fb_helper_init(). No full cleanup is required. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-23 Thread Thomas Zimmermann
Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such as the preferred BPP. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 13 + 1 file change

[PATCH 10/10] drm/fbdev-generic: Rename struct fb_info 'fbi' to 'info'

2023-01-23 Thread Thomas Zimmermann
The generic fbdev emulation names variables of type struct fb_info both 'fbi' and 'info'. The latter seems to be more common in fbdev code, so name fbi accordingly. Also replace the duplicate variable in drm_fbdev_fb_destroy(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_gene

[PATCH 06/10] drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function

2023-01-23 Thread Thomas Zimmermann
Initialize the fb-helper's preferred_bpp field early from within drm_fb_helper_prepare(); instead of the later client hot-plugging callback. This simplifies the generic fbdev setup function. No real changes, but all drivers' fbdev code has to be adapted. Signed-off-by: Thomas Zimmermann --- dri

[PATCH 02/10] drm/client: Add hotplug_failed flag

2023-01-23 Thread Thomas Zimmermann
Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled with a combination of cleared pointers in struct drm_fb_helper, which prevents us from initializing these pointers early after allo

[PATCH 09/10] drm/fbdev-generic: Inline clean-up helpers into drm_fbdev_fb_destroy()

2023-01-23 Thread Thomas Zimmermann
The fbdev framebuffer cleanup in drm_fbdev_fb_destroy() calls drm_fbdev_release() and drm_fbdev_cleanup(). Inline both into the caller. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fbdev_generic.c | 17 ++--- 1 file changed, 2 insertions(+), 15 dele

[PATCH 00/10] drm/fb-helper: Various cleanups

2023-01-23 Thread Thomas Zimmermann
Add various cleanups and changes to DRM's fbdev helpers and the generic fbdev emulation. There's no clear theme here, just lots of small things that need to be updated. In the end, the code will better reflect which parts are in the DRM client, which is fbdev emulation, and which are shared fbde

[PATCH 03/10] drm/fb-helper: Introduce drm_fb_helper_unprepare()

2023-01-23 Thread Thomas Zimmermann
Move the fb-helper clean-up code into drm_fb_helper_unprepare(). No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 14 +- include/drm/drm_fb_helper.h | 4 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/

Re: [PATCH v11 3/3] drm: exynos: dsi: Restore proper bridge chain order

2023-01-23 Thread Jagan Teki
Hi Dave, On Sat, Jan 21, 2023 at 1:12 AM Dave Stevenson wrote: > > Hi Jagan > > On Fri, 20 Jan 2023 at 19:10, Jagan Teki wrote: > > > > Hi Dave, > > > > On Sat, Jan 21, 2023 at 12:26 AM Dave Stevenson > > wrote: > > > > > > Hi Jagan > > > > > > Responding due to Marek's comment on the "Add Sams

Re: [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES()

2023-01-23 Thread Jani Nikula
On Fri, 20 Jan 2023, Lucas De Marchi wrote: > It's a constant pattern in the driver to need to use 2 ranges of MMIOs > based on port, phy, pll, etc. When that happens, instead of using > _PICK_EVEN(), _PICK() needs to be used. Using _PICK() is discouraged > due to some reasons like: > > 1) It inc

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Add _PICK_EVEN_2RANGES()

2023-01-23 Thread Jani Nikula
On Sat, 21 Jan 2023, Lucas De Marchi wrote: > On Fri, Jan 20, 2023 at 10:14:19PM -0800, Anusha Srivatsa wrote: >> >> >>> -Original Message- >>> From: Intel-gfx On Behalf Of Lucas >>> De Marchi >>> Sent: Friday, January 20, 2023 11:35 AM >>> To: intel-...@lists.freedesktop.org >>> Cc: De M

[PATCH] agp/amd64: Fix full name of the GPL

2023-01-23 Thread Diederik de Haas
Signed-off-by: Diederik de Haas --- drivers/char/agp/amd64-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c index ce8651436609..3020fd92fd00 100644 --- a/drivers/char/agp/amd64-agp.c +++ b/drivers/char/agp/amd64-

Re: [PATCH RFC 4/4] drm/panfrost: Expose some memory related stats through fdinfo

2023-01-23 Thread Tvrtko Ursulin
Hi, Chris was kind enough to bring my attention to this thread. Indeed this information was asked for by various people for many years so it sounds very useful to actually do attempt it. On 04/01/2023 13:03, Boris Brezillon wrote: drm-memory-all: memory hold by this context. Not that all t

Re: [PATCH v8 5/8] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid

2023-01-23 Thread Jani Nikula
On Fri, 20 Jan 2023, Ville Syrjälä wrote: > On Thu, Jan 19, 2023 at 06:18:58PM +0200, Jani Nikula wrote: >> diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c >> b/drivers/gpu/drm/i915/display/intel_lvds.c >> index aecec992cd0d..6a98787edf48 100644 >> --- a/drivers/gpu/drm/i915/display/intel_

[PATCH 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-23 Thread Thomas Zimmermann
Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver bug. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c| 5 + drivers/gpu/drm/drm_fbdev_generic.c |

Re: [PATCH] drm/bridge: panel: Set orientation on panel_bridge connector

2023-01-23 Thread John Keeping
Hi Laurent, On Sun, Jan 22, 2023 at 05:01:27PM +0200, Laurent Pinchart wrote: > On Sat, Jan 21, 2023 at 05:58:11PM +, John Keeping wrote: > > On Sat, Jan 21, 2023 at 09:57:18AM +0100, Sam Ravnborg wrote: > > > On Fri, Jan 20, 2023 at 01:44:38PM -0800, Doug Anderson wrote: > > > > On Fri, Jan 2

Re: [PATCH v2 0/8] Add _PICK_EVEN_2RANGES

2023-01-23 Thread Jani Nikula
On Fri, 20 Jan 2023, Lucas De Marchi wrote: > Add a new macro, _PICK_EVEN_2RANGES, that supports using 2 address > ranges. This can be considered a v2 of > https://patchwork.freedesktop.org/series/109606/ > > I think I converted all the _PICK() uses that could be easily done > without making it mu

[PATCH v11 01/18] drm: of: Lookup if child node has DSI panel or bridge

2023-01-23 Thread Jagan Teki
Devices can also be child nodes when we also control that device through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). Unlike the drm_of_find_panel_or_bridge helper it requires a special case to lookup a child node of the given parent that isn't either port or ports. Lookup for a chil

[PATCH v11 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-23 Thread Jagan Teki
This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge Patch 0005 - 0006: optional PHY, PMS_P offset Patch 0007 :

[PATCH v11 03/18] drm: exynos: dsi: Drop explicit call to bridge detach

2023-01-23 Thread Jagan Teki
Exynos DSI already converted into a bridge driver, so bridge detach will suppose happened during bridge chain removal done by the bridge core. Drop the explicit call chain to detach the bridge. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - new patch drivers/gpu/drm/e

[PATCH v11 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge

2023-01-23 Thread Jagan Teki
devm_drm_of_dsi_get_bridge is capable of looking up the downstream DSI bridge and panel and trying to add a panel bridge if the panel is found. Replace explicit finding calls with devm_drm_of_dsi_get_bridge. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - new patch dri

[PATCH v11 07/18] drm: exynos: dsi: Introduce hw_type platform data

2023-01-23 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano/Plus. Add hw_type enum via platform_data so that accessing the different controller data between various platforms becomes easy and meaningful. Reviewed-by: Frieder Schrempf Suggested-by:

[PATCH v11 05/18] drm: exynos: dsi: Mark PHY as optional

2023-01-23 Thread Jagan Teki
The same Samsung MIPI DSIM master can also be used in NXP's i.MX8M Mini/Nano/Plus SoC. In i.MX8M Mini/Nano/Plus SoC the DSI Phy requires a MIPI DPHY bit to reset in order to activate the PHY and that can be done via upstream i.MX8M blk-ctrl driver. So, mark the phy get as optional. Reviewed-by:

[PATCH v11 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset

2023-01-23 Thread Jagan Teki
Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but t

[PATCH v11 08/18] drm: exynos: dsi: Handle proper host initialization

2023-01-23 Thread Jagan Teki
From: Marek Szyprowski Host transfer() in the DSI master will invoke only when the DSI commands are sent from DSI devices like DSI Panel or DSI bridges and this host the transfer wouldn't invoke for I2C-based-DSI bridge drivers. Handling DSI host initialization in transfer calls misses the contr

[PATCH v11 09/18] drm: exynos: dsi: Add atomic check

2023-01-23 Thread Jagan Teki
Look like an explicit fixing up of mode_flags is required for DSIM IP present in i.MX8M Mini/Nano SoCs. At least the LCDIF + DSIM needs active low sync polarities in order to correlate the correct sync flags of the surrounding components in the chain to make sure the whole pipeline can work proper

[PATCH v11 14/18] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge

2023-01-23 Thread Jagan Teki
Samsung MIPI DSIM controller is common DSI IP that can be used in various SoCs like Exynos, i.MX8M Mini/Nano. In order to access this DSI controller between various platform SoCs, the ideal way to incorporate this in the drm stack is via the drm bridge driver. We already have a consolidated code

[PATCH v11 13/18] drm: exynos: dsi: Add Exynos based host irq hooks

2023-01-23 Thread Jagan Teki
Enable and disable of te_gpio's are Exynos platform specific irq handling, so add the exynos based irq operations and hook them for exynos plat_data. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - split from previous series patch "drm: bridge: Generalize Exynos-DSI drive

Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-23 Thread Jagan Teki
On Sat, Jan 21, 2023 at 12:29 AM Dave Stevenson wrote: > > Hi Marek & Jagan > > On Fri, 20 Jan 2023 at 15:06, Marek Vasut wrote: > > > > On 1/20/23 15:41, Jagan Teki wrote: > > > Hi Fabio, > > > > Hello all, > > > > > On Fri, Jan 20, 2023 at 5:36 PM Fabio Estevam wrote: > > >> > > >> Hi Jagan, >

[PATCH v11 16/18] drm: bridge: samsung-dsim: Add i.MX8M Mini/Nano support

2023-01-23 Thread Jagan Teki
Samsung MIPI DSIM master can also be found in i.MX8M Mini/Nano SoC. Add compatible and associated driver_data for it. Reviewed-by: Frieder Schrempf Acked-by: Robert Foss Reviewed-by: Laurent Pinchart Signed-off-by: Marek Szyprowski Signed-off-by: Jagan Teki --- Changes for v11: - collect RB

[PATCH v11 15/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Mini/Nano support

2023-01-23 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8M Mini/Nano SoC. Add dt-bingings for it. Acked-by: Rob Herring Signed-off-by: Jagan Teki --- Changes for v11, v10, v9: - none Changes for v8: - add comment to include i.MX8M Nano. Changes for v7, v6, v5, v4: - none Changes for v3: - collect Rob

[PATCH v11 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support

2023-01-23 Thread Jagan Teki
Samsung MIPI DSIM bridge can also be found in i.MX8M Plus SoC. Add dt-bingings for it. Signed-off-by: Jagan Teki --- Changes for v11: - collect ACK from Rob Changes for v10, v9: - none Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v11 18/18] drm: bridge: samsung-dsim: Add i.MX8M Plus support

2023-01-23 Thread Jagan Teki
From: Marek Vasut Add extras to support i.MX8M Plus. The main change is the removal of HS/VS/DE signal inversion in the LCDIFv3-DSIM glue logic, otherwise the implementation of this IP in i.MX8M Plus is very much compatible with the i.MX8M Mini/Nano one. Reviewed-by: Frieder Schrempf Acked-by:

[PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper

2023-01-23 Thread Jagan Teki
Add devm OF helper to return the next DSI bridge in the chain. Unlike general bridge return helper devm_drm_of_get_bridge, this helper uses the dsi specific panel_or_bridge helper to find the next DSI device in the pipeline. Helper lookup a given child DSI node or a DT node's port and endpoint nu

[PATCH v11 11/18] drm: exynos: dsi: Add atomic_get_input_bus_fmts

2023-01-23 Thread Jagan Teki
Finding the right input bus format throughout the pipeline is hard so add atomic_get_input_bus_fmts callback and initialize with the proper input format from list of supported output formats. This format can be used in pipeline for negotiating bus format between the DSI-end of this bridge and the

Re: [RFC 1/2] drm/connector: add connector list iteration with filtering

2023-01-23 Thread Jani Nikula
On Thu, 15 Dec 2022, Daniel Vetter wrote: > On Wed, Oct 05, 2022 at 01:51:43PM +0300, Jani Nikula wrote: >> Add new function drm_connector_list_iter_filter_begin() to initialize >> connector list iterator with a filter function. Subsequent iteration on >> the list will only return connectors on wh

[PATCH v11 12/18] drm: exynos: dsi: Consolidate component and bridge

2023-01-23 Thread Jagan Teki
DSI host registration, attach and detach operations are quite different for the component and bridge-based DRM drivers.  Supporting generic bridge driver to use both component and bridge based DRM drivers can be tricky and would require additional host related operation hooks. Add host operation

[PATCH v11 10/18] drm: exynos: dsi: Add input_bus_flags

2023-01-23 Thread Jagan Teki
LCDIF-DSIM glue logic inverts the HS/VS/DE signals and expecting the i.MX8M Mini/Nano DSI host to add additional Data Enable signal active low (DE_LOW). This makes the valid data transfer on each horizontal line. So, add additional bus flags DE_LOW setting via input_bus_flags for i.MX8M Mini/Nano

DMA-heap driver hints

2023-01-23 Thread Christian König
Hi guys, this is just an RFC! The last time we discussed the DMA-buf coherency problem [1] we concluded that DMA-heap first needs a better way to communicate to userspace which heap to use for a certain device. As far as I know userspace currently just hard codes that information which is certain

Re: [PATCH v2 1/3] drm/msm/gpu: Add devfreq tuning debugfs

2023-01-23 Thread Krzysztof Kozlowski
On 11/01/2023 00:14, Rob Clark wrote: > From: Rob Clark > > Make the handful of tuning knobs available visible via debugfs. > > v2: select DEVFREQ_GOV_SIMPLE_ONDEMAND because for some reason > struct devfreq_simple_ondemand_data depends on this > > Signed-off-by: Rob Clark > --- For some

Re: [PATCH v11 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support

2023-01-23 Thread Frieder Schrempf
On 23.01.23 13:23, Jagan Teki wrote: > Samsung MIPI DSIM bridge can also be found in i.MX8M Plus SoC. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki > --- > Changes for v11: > - collect ACK from Rob Tag is missing > Changes for v10, v9: > - none > > Documentation/devicetree/bindin

RE: [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

2023-01-23 Thread Jani Nikula
On Sun, 22 Jan 2023, "Usyskin, Alexander" wrote: >> > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >> b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >> > index d50354bfb993..bef6d7f8ac55 100644 >> > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c >> > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_t

Re: [PATCH v11 17/18] dt-bindings: display: exynos: dsim: Add NXP i.MX8M Plus support

2023-01-23 Thread Jagan Teki
On Mon, Jan 23, 2023 at 6:08 PM Frieder Schrempf wrote: > > On 23.01.23 13:23, Jagan Teki wrote: > > Samsung MIPI DSIM bridge can also be found in i.MX8M Plus SoC. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v11: > > - collect ACK from Rob > > Tag is

[PATCH 2/2] media: uvcvideo: expose dma-heap hint to userspace

2023-01-23 Thread Christian König
Expose an indicator to let userspace know from which dma_heap to allocate for buffers of this device. Signed-off-by: Christian König --- drivers/media/usb/uvc/uvc_driver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc

[PATCH 1/2] dma-heap: add device link and unlink functions

2023-01-23 Thread Christian König
This allows device drivers to specify a DMA-heap where they want their buffers to be allocated from. This information is then exposed as sysfs link between the device and the DMA-heap. Useful for userspace when in need to decide from which provider to allocate a buffer. Signed-off-by: Christian K

Re: pr-tracker-bot for drm subsystem?

2023-01-23 Thread Jani Nikula
On Fri, 20 Jan 2023, Konstantin Ryabitsev wrote: > On Fri, Jan 20, 2023 at 09:09:18AM +0200, Jani Nikula wrote: >> >> Konstantin? > > Sorry, I didn't mean to scholz you around. This reply alone was worth the wait. ;D > The pr-tracker-bot is very much a > bespoke solution for Linus, so adapting

Re: [LSF/MM/BPF proposal]: Physr discussion

2023-01-23 Thread Jason Gunthorpe
On Mon, Jan 23, 2023 at 04:36:25AM +, Matthew Wilcox wrote: > > I've been working on an implementation and hope to have something > > draft to show on the lists in a few weeks. It is pretty clear there > > are several interesting decisions to make that I think will benefit > > from a live disc

Re: DMA-heap driver hints

2023-01-23 Thread Laurent Pinchart
Hi Christian, CC'ing James as I think this is related to his work on the unix device memory allocator ([1]). [1] https://lore.kernel.org/dri-devel/8b555674-1c5b-c791-4547-2ea7c16ae...@nvidia.com/ On Mon, Jan 23, 2023 at 01:37:54PM +0100, Christian König wrote: > Hi guys, > > this is just an RF

Re: [PATCH 2/2] media: uvcvideo: expose dma-heap hint to userspace

2023-01-23 Thread Laurent Pinchart
Hi Christian, Thank you for the patch. On Mon, Jan 23, 2023 at 01:37:56PM +0100, Christian König wrote: > Expose an indicator to let userspace know from which dma_heap > to allocate for buffers of this device. > > Signed-off-by: Christian König > --- > drivers/media/usb/uvc/uvc_driver.c | 11 +

Re: [PATCH v2 04/10] iommu/dma: Use the gfp parameter in __iommu_dma_alloc_noncontiguous()

2023-01-23 Thread Jason Gunthorpe
On Fri, Jan 20, 2023 at 07:28:19PM +, Robin Murphy wrote: > Overall I'm starting to wonder if it might not be better to stick a "use > GFP_KERNEL_ACCOUNT if you allocate" flag in the domain for any level of the > API internals to pick up as appropriate, rather than propagate per-call gfp > fla

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-23 Thread Naresh Kamboju
Hi Nathan, On Thu, 12 Jan 2023 at 08:35, Nathan Chancellor wrote: > > Hi all, > > Clang can emit a few different warnings when it encounters a flag that it > recognizes but does not support internally. These warnings are elevated to > errors within {as,cc}-option via -Werror to catch unsupported

[ANNOUNCE] pixfmtdb

2023-01-23 Thread Simon Ser
Hi all, In the last few days I've been working on a small new project, pixfmtdb [1]. It's a Web database of pixel format guides, it can be useful to understand how pixels are laid out in memory for a given format and which formats from various APIs are compatible with each other. pixfmtdb relies

Re: [PATCH v3 4/7] drm: rcar-du: lvds: Fix stop sequence

2023-01-23 Thread Geert Uytterhoeven
Hi Tomi, On Mon, Jan 23, 2023 at 11:48 AM Tomi Valkeinen wrote: > From: Koji Matsuoka > > According to hardware manual, LVDCR0 register must be cleared bit by bit > when disabling LVDS. > > Signed-off-by: Koji Matsuoka > Signed-off-by: LUU HOAI > [tomi.valkeinen: simplified the code a bit] > S

Re: [PATCH v9 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-23 Thread Daniel Thompson
On Fri, Jan 20, 2023 at 11:50:17PM +0800, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v9 2/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-23 Thread Daniel Thompson
On Fri, Jan 20, 2023 at 11:50:18PM +0800, Jianhua Lu wrote: > Add support for Kinetic KTZ8866 backlight, which is used in > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > downstream implementation [1]. > [1] > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/driv

Re: [Intel-gfx] [PATCH v5 2/6] drm/i915/pxp: add device link between i915 and mei_pxp

2023-01-23 Thread Rodrigo Vivi
On Sun, Jan 22, 2023 at 06:57:24AM +, Usyskin, Alexander wrote: > > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > b/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > > index d50354bfb993..bef6d7f8ac55 100644 > > > --- a/drivers/gpu/drm/i915/pxp/intel_pxp_tee.c > > > +++ b/drivers/gpu/d

Re: [PATCH v2] drm/shmem: Cleanup drm_gem_shmem_create_with_handle()

2023-01-23 Thread Steven Price
On 19/01/2023 22:44, Rob Clark wrote: > From: Rob Clark > > Once we create the handle, the handle owns the reference. Currently > nothing was doing anything with the shmem ptr after the handle was > created, but let's change drm_gem_shmem_create_with_handle() to not > return the pointer, so-as t

Re: [PATCH v2 2/7] drm: rcar-du: lvds: Add runtime PM

2023-01-23 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Jan 20, 2023 at 5:16 PM Laurent Pinchart wrote: > On Fri, Jan 20, 2023 at 10:50:04AM +0200, Tomi Valkeinen wrote: > > Add simple runtime PM suspend and resume functionality. > > I think you need to depend on PM in Kconfig. That's not a compile-time > dependency but a runtime-d

Re: [RFC] TTM shrinking revisited

2023-01-23 Thread Thomas Hellström
On 1/4/23 11:31, Christian König wrote: Am 30.12.22 um 12:11 schrieb Thomas Hellström: Hi, Christian, others. I'm starting to take a look at the TTM shrinker again. We'll probably be needing it at least for supporting integrated hardware with the xe driver. So assuming that the last attemp

Re: [PULL] drm-misc-next

2023-01-23 Thread John Paul Adrian Glaubitz
Hi Thomas! Driver Changes: * Remove obsolete drivers for userspace modesetting i810, mga, r128, savage, sis, tdfx, via Is the Rage 128 GPU still supported via the generic modesetting driver? I'm asking because, we're still supporting PowerMacs in Debian Ports of which some of those are s

Re: [PATCH v2 0/8] Docs: Add missing SPDX license identifiers of

2023-01-23 Thread Jonathan Corbet
SeongJae Park writes: > Some subsystem documents are missing SPDX license identifiers on index > files. This patchset adds those. Documentation/ is far behind on the SPDX front, and I'm all in favor of fixing that. I do worry, though, about sticking license declarations onto files that did not

Re: [PATCH/RFC 0/3] Atari DRM driver

2023-01-23 Thread John Paul Adrian Glaubitz
Hi Geert! On 11/25/22 21:31, Geert Uytterhoeven wrote: This RFC patch series adds a DRM driver for the good old Atari ST/TT/Falcon hardware. It was developed and tested (only) on the ARAnyM emulator. I just remembered this WIP driver. Has there been any progress? Adrian -- .''`. John Paul

Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-23 Thread Serge Semin
On Fri, Jan 20, 2023 at 12:23:31AM +0530, Amit Kumar Mahapatra wrote: > Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod > members of struct spi_device to be an array. But changing the type of these > members to array would break the spi driver functionality. To make the

Re: [PATCH/RFC 0/3] Atari DRM driver

2023-01-23 Thread Geert Uytterhoeven
Hi Adrian, On Mon, Jan 23, 2023 at 4:09 PM John Paul Adrian Glaubitz wrote: > On 11/25/22 21:31, Geert Uytterhoeven wrote: > > This RFC patch series adds a DRM driver for the good old Atari > > ST/TT/Falcon hardware. It was developed and tested (only) on the ARAnyM > > emulator. > > I just remem

[RESEND PATCH v11 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-23 Thread Jagan Teki
This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge Patch 0005 - 0006: optional PHY, PMS_P offset Patch 0007 :

[RESEND PATCH v11 01/18] drm: of: Lookup if child node has DSI panel or bridge

2023-01-23 Thread Jagan Teki
Devices can also be child nodes when we also control that device through the upstream device (ie, MIPI-DCS for a MIPI-DSI device). Unlike the drm_of_find_panel_or_bridge helper it requires a special case to lookup a child node of the given parent that isn't either port or ports. Lookup for a chil

[RESEND PATCH v11 02/18] drm: bridge: panel: Add devm_drm_of_dsi_get_bridge helper

2023-01-23 Thread Jagan Teki
Add devm OF helper to return the next DSI bridge in the chain. Unlike general bridge return helper devm_drm_of_get_bridge, this helper uses the dsi specific panel_or_bridge helper to find the next DSI device in the pipeline. Helper lookup a given child DSI node or a DT node's port and endpoint nu

[RESEND PATCH v11 03/18] drm: exynos: dsi: Drop explicit call to bridge detach

2023-01-23 Thread Jagan Teki
Exynos DSI already converted into a bridge driver, so bridge detach will suppose happened during bridge chain removal done by the bridge core. Drop the explicit call chain to detach the bridge. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - new patch drivers/gpu/drm/e

[RESEND PATCH v11 04/18] drm: exynos: dsi: Switch to devm_drm_of_dsi_get_bridge

2023-01-23 Thread Jagan Teki
devm_drm_of_dsi_get_bridge is capable of looking up the downstream DSI bridge and panel and trying to add a panel bridge if the panel is found. Replace explicit finding calls with devm_drm_of_dsi_get_bridge. Signed-off-by: Jagan Teki --- Changes for v11: - none Changes for v10: - new patch dri

[RESEND PATCH v11 05/18] drm: exynos: dsi: Mark PHY as optional

2023-01-23 Thread Jagan Teki
The same Samsung MIPI DSIM master can also be used in NXP's i.MX8M Mini/Nano/Plus SoC. In i.MX8M Mini/Nano/Plus SoC the DSI Phy requires a MIPI DPHY bit to reset in order to activate the PHY and that can be done via upstream i.MX8M blk-ctrl driver. So, mark the phy get as optional. Reviewed-by:

Re: [PULL] drm-misc-next

2023-01-23 Thread Thomas Zimmermann
Hi Am 23.01.23 um 16:00 schrieb John Paul Adrian Glaubitz: Hi Thomas! Driver Changes:  * Remove obsolete drivers for userspace modesetting i810, mga, r128,    savage, sis, tdfx, via Is the Rage 128 GPU still supported via the generic modesetting driver? I'm asking because, we're still supp

[RESEND PATCH v11 06/18] drm: exynos: dsi: Add platform PLL_P (PMS_P) offset

2023-01-23 Thread Jagan Teki
Look like PLL PMS_P offset value varies between platforms that have Samsung DSIM IP. However, there is no clear evidence for it as both Exynos and i.MX 8M Mini Application Processor Reference Manual is still referring the PMS_P offset as 13. The offset 13 is not working for i.MX8M Mini SoCs but t

  1   2   3   4   >