Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-20 Thread Hans Verkuil
On 21/12/2022 10:24, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Hi, > > These add new pixel formats for Renesas V3U and V4H SoCs. > > As the display pipeline is split between DRM and V4L2 components, this > series touches both subsystems. I'm sending all these together to > simplify revie

Re: [RFC PATCH] drm/simpledrm: Allow physical width and height configuration via DT

2023-01-20 Thread Janne Grunau
Hej, adding devicet...@vger.kernel.org and as...@lists.linux.dev to cc:, the former for the obvious devictree/bindings related questions, asahi for the prospect of supporting high DPI displays during early boot and in u-boot. On 2023-01-18 18:48:17 +, Rayyan Ansari wrote: > Hello, > The fol

[PATCH v2 10/13] mtd: spi-nor: Add stacked memories support in spi-nor

2023-01-20 Thread Amit Kumar Mahapatra
Each flash that is connected in stacked mode should have a separate parameter structure. So, the flash parameter member(*params) of the spi_nor structure is changed to an array (*params[2]). The array is used to store the parameters of each flash connected in stacked configuration. The current imp

[PATCH v2 04/13] iio: imu: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

[PATCH v2 00/13] spi: Add support for stacked/parallel memories

2023-01-20 Thread Amit Kumar Mahapatra
This patch is in the continuation to the discussions which happened on 'commit f89504300e94 ("spi: Stacked/parallel memories bindings")' for adding dt-binding support for stacked/parallel memories. This patch series updated the spi-nor, spi core and the spi drivers to add stacked and parallel memo

[PATCH v2 06/13] staging: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-20 Thread Tomi Valkeinen
On 17/01/2023 18:11, Geert Uytterhoeven wrote: Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: rcar_du_crtc.c does a soc_device_match() in rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and if so, apply a WA. We will need another H3 ES1 check in the followi

[PATCH v2 09/13] mtd: spi-nor: Add APIs to set/get nor->params

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi-nor would require the *params member of struct spi_nor to be an array. To make the transition smoother introduced spi_nor_get_params() & spi_nor_set_params() APIs to get & set nor->params, added a new local variable (struct spi_nor_flash_parameter *params) to hold the ret

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-20 Thread Tomi Valkeinen
On 19/01/2023 11:40, Laurent Pinchart wrote: Hi Tomi, On Thu, Jan 19, 2023 at 11:17:58AM +0200, Tomi Valkeinen wrote: On 18/01/2023 23:38, Laurent Pinchart wrote: On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: On H3 ES1 two bits in DPLLCR are used to select the DU input dot c

Re: [PATCH 5/6] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:38, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:53PM +0200, Tomi Valkeinen wrote: On H3 ES1 two bits in DPLLCR are used to select the DU input dot clock s/ES1/ES1.x/ Same below. Ok. But I do wonder, is there a difference? What's

[PATCH 1/3] drm/rockchip: lvds: add rk3568 support

2023-01-20 Thread Alibek Omarov
One of the ports of RK3568 can be configured as LVDS, re-using the DSI DPHY Signed-off-by: Alibek Omarov --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 144 +-- drivers/gpu/drm/rockchip/rockchip_lvds.h | 10 ++ 2 files changed, 147 insertions(+), 7 deletions(-) diff --git a

[PATCH 2/3] arm64: dts: rockchip: rk356x: add LVDS bindings

2023-01-20 Thread Alibek Omarov
Exposes ports for VOP2 and for panel Tested-by: Alexander Sverdlin Link: https://patchwork.kernel.org/project/linux-rockchip/patch/20220923160115.2946615-3-a1ba.oma...@gmail.com/#25097661 Signed-off-by: Alibek Omarov --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 25 1

[PATCH v2 03/13] net: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

[PATCH 0/3] drm/rockchip: lvds: add support for rk356x

2023-01-20 Thread Alibek Omarov
Hi all, This series adds support for the LVDS controller on the Rockchip RK3566 and RK3568. First patch adds the support in rockchip-lvds.c driver, setting all the needed GRF registers. Second patch adds device tree bindings, and third patch adds a note in the documentation. LVDS controller on rk

[PATCH 3/3] dt-bindings: display: rockchip-lvds: add compatible string for RK3568

2023-01-20 Thread Alibek Omarov
RK3568 SoCs have a single LVDS output, that use PHY shared by two display pipelines: LVDS and MIPI DSI. Signed-off-by: Alibek Omarov --- .../devicetree/bindings/display/rockchip/rockchip-lvds.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

Re: [PATCH 6/6] drm: rcar-du: Stop accessing non-existant registers on gen4

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:54, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:54PM +0200, Tomi Valkeinen wrote: The following registers do not exist on gen4, so we should not write them: DEF6Rm, DEF8Rm, ESCRn, OTARn. I think DEF7Rm should also be skipped. With

[PATCH v2 05/13] mtd: devices: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

[PATCH v2 07/13] platform/x86: serial-multi-instantiate: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

Re: [PATCH 2/6] drm: rcar-du: lvds: Add reset control

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:06, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:50PM +0200, Tomi Valkeinen wrote: From: Koji Matsuoka Reset LVDS using the reset control as CPG reset/release is required in H/W manual sequence. s@H/W@the hardware@ Signed-off-by

[PATCH v2 12/13] mtd: spi-nor: Add parallel memories support in spi-nor

2023-01-20 Thread Amit Kumar Mahapatra
The current implementation assumes that a maximum of two flashes are connected in parallel mode. The QSPI controller splits the data evenly between both the flashes so, both the flashes that are connected in parallel mode should be identical. During each operation SPI-NOR sets 0th bit for CS0 & 1st

[PATCH v2 08/13] spi: Add stacked and parallel memories support in SPI core

2023-01-20 Thread Amit Kumar Mahapatra
For supporting multiple CS the SPI device need to be aware of all the CS values. So, the "chip_select" member in the spi_device structure is now an array that holds all the CS values. spi_device structure now has a "cs_index_mask" member. This acts as an index to the chip_select array. If nth bit

[PATCH v2 11/13] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver

2023-01-20 Thread Amit Kumar Mahapatra
GQSPI supports two chip select CS0 & CS1. Update the driver to assert/de-assert the appropriate chip select as per the bits set in qspi->cs_index_mask. Signed-off-by: Amit Kumar Mahapatra --- drivers/spi/spi-zynqmp-gqspi.c | 21 + 1 file changed, 13 insertions(+), 8 deletions

[PATCH v2 13/13] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver

2023-01-20 Thread Amit Kumar Mahapatra
During GQSPI driver probe set ctlr->multi-cs-cap for enabling multi CS capability of the controller. In parallel mode the controller can either split the data between both the flash or can send the same data to both the flashes, this is determined by the STRIPE bit. While sending commands to the fl

[PATCH] drm/nouveau: Fix bug in buffer relocs for Nouveau

2023-01-20 Thread Tanmay Bhushan
dma_resv_wait_timeout returns greater than zero on success as opposed to ttm_bo_wait_ctx. As a result of that relocs will fail and give failure even when it was a success. Signed-off-by: Tanmay Bhushan <0070472...@gmail.com> --- drivers/gpu/drm/nouveau/nouveau_gem.c | 3 +-- 1 file changed, 1 ins

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:19, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:52PM +0200, Tomi Valkeinen wrote: rcar_du_crtc.c does a soc_device_match() in rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and s/ES1/ES1.x/ Same below. if so

Re: [PATCH 3/6] drm: rcar-du: Fix LVDS stop sequence

2023-01-20 Thread Tomi Valkeinen
On 18/01/2023 23:12, Laurent Pinchart wrote: Hi Tomi, Thank you for the patch. On Tue, Jan 17, 2023 at 03:51:51PM +0200, Tomi Valkeinen wrote: From: Koji Matsuoka According to H/W manual, LVDCR0 register must be cleared bit by bit when s@H/W@the hardware/ disabling LVDS. I don't like t

[PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/set the spi->chip_select

Re: [PATCH 2/6] drm: rcar-du: lvds: Add reset control

2023-01-20 Thread Tomi Valkeinen
On 17/01/2023 18:04, Geert Uytterhoeven wrote: Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: From: Koji Matsuoka Reset LVDS using the reset control as CPG reset/release is required in H/W manual sequence. Signed-off-by: Koji Matsuoka Signed-off-by: LUU HOAI [tomi.valkeine

[PATCH v2 01/13] spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod

2023-01-20 Thread Amit Kumar Mahapatra
Supporting multi-cs in spi core and spi controller drivers would require the chip_select & cs_gpiod members of struct spi_device to be an array. But changing the type of these members to array would break the spi driver functionality. To make the transition smoother introduced four new APIs to get/

Re: [PATCH] drm/radeon: Fix screen corruption (v2)

2023-01-20 Thread Krylov Michael
On Thu, 15 Dec 2022 07:07:33 -0500 Luben Tuikov wrote: > On 2022-12-15 06:53, Robin Murphy wrote: > > On 2022-12-15 11:40, Luben Tuikov wrote: > >> On 2022-12-15 06:27, Christian König wrote: > >>> Am 15.12.22 um 11:19 schrieb Luben Tuikov: > On 2022-12-15 04:46, Christian König wrote: > >>>

Re: [PATCH 1/2] dt-bindings: panel: Add compatible for Anbernic RG353V-V2 panel

2023-01-20 Thread Krzysztof Kozlowski
On 20/01/2023 00:04, Chris Morgan wrote: > From: Chris Morgan > > The Anbernic RG353V-V2 panel is a 5 inch 640x480 MIPI-DSI LCD panel. > It's based on the ST7703 LCD controller just like rocktech,jh057n00900. > It's used in a 2nd revision of the Anbernic RG353V handheld gaming > device. Like the

Re: [PATCH 3/3] dt-bindings: display: rockchip-lvds: add compatible string for RK3568

2023-01-20 Thread Krzysztof Kozlowski
On 19/01/2023 19:48, Alibek Omarov wrote: > RK3568 SoCs have a single LVDS output, that use PHY shared by two display > pipelines: LVDS and MIPI DSI. > > Signed-off-by: Alibek Omarov Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

RE: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion

2023-01-20 Thread Gupta, Anshuman
> -Original Message- > From: Intel-gfx On Behalf Of Alan > Previn > Sent: Friday, January 20, 2023 1:20 AM > To: intel-...@lists.freedesktop.org > Cc: v...@freedesktop.org; dri-devel@lists.freedesktop.org; Teres Alexis, > Alan Previn ; Vivi, Rodrigo > > Subject: [Intel-gfx] [PATCH 1/1]

Re: [RESEND][PATCH] MAINTAINERS: Add Sumit Semwal and Yongqin Liu as reviwers for kirin DRM driver

2023-01-20 Thread Thomas Zimmermann
Am 20.01.23 um 07:09 schrieb John Stultz: I no longer have access to the HiKey boards, so while I'm happy to review code, I wanted to add Sumit and Yongqin to the reviewers list so they would get CC'ed on future changes and would be able to have a chance to validate and provide Tested-by: tags

Re: [PATCH 1/2] dt-bindings: panel: Add compatible for Anbernic RG353V-V2 panel

2023-01-20 Thread Guido Günther
Hi, On Thu, Jan 19, 2023 at 05:04:14PM -0600, Chris Morgan wrote: > From: Chris Morgan > > The Anbernic RG353V-V2 panel is a 5 inch 640x480 MIPI-DSI LCD panel. > It's based on the ST7703 LCD controller just like rocktech,jh057n00900. > It's used in a 2nd revision of the Anbernic RG353V handheld g

Re: [PATCH 2/2] drm/panel: st7703: Add support for Anbernic RG353V-V2 panel

2023-01-20 Thread Guido Günther
Hi, On Thu, Jan 19, 2023 at 05:04:15PM -0600, Chris Morgan wrote: > From: Chris Morgan > > The Anbernic RG353V-V2 is a 5 inch panel used in a new revision of the > Anbernic RG353V handheld gaming device. Add support for it. > > Unfortunately it appears this controller is not able to support 120h

Re: [PATCH] drm: override detected status for connectors which are forced on

2023-01-20 Thread Michael Rodin
Hi Maxime, thank you for your feedback! On Thu, Dec 22, 2022 at 06:40:54PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote: > > The detected status of a connector should be ignored when a connector is > > forced as hinted in the commit d50ba256b

Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion

2023-01-20 Thread Jani Nikula
On Thu, 19 Jan 2023, Alan Previn wrote: > The Driver-FLR flow may inadvertently exit early before the full > completion of the re-init of the internal HW state if we only poll > GU_DEBUG Bit31 (polling for it to toggle from 0 -> 1). Instead > we need a two-step completion wait-for-completion flow

Re: [PATCH 1/3] drm/rockchip: lvds: add rk3568 support

2023-01-20 Thread Sascha Hauer
On Thu, Jan 19, 2023 at 09:48:03PM +0300, Alibek Omarov wrote: > One of the ports of RK3568 can be configured as LVDS, re-using the DSI DPHY > > Signed-off-by: Alibek Omarov > --- > drivers/gpu/drm/rockchip/rockchip_lvds.c | 144 +-- > drivers/gpu/drm/rockchip/rockchip_lvds.h

[PATCH][next] accel/ivpu: Fix spelling mistake "tansition" -> "transition"

2023-01-20 Thread Colin Ian King
There are spelling mistakes in two ivpu_err error messages. Fix them. Signed-off-by: Colin Ian King --- drivers/accel/ivpu/ivpu_hw_mtl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/accel/ivpu/ivpu_hw_mtl.c b/drivers/accel/ivpu/ivpu_hw_mtl.c index b59b1f472b40.

Re: [PATCH 1/8] iommu: Add a gfp parameter to iommu_map()

2023-01-20 Thread Joerg Roedel
On Fri, Jan 06, 2023 at 01:24:11PM -0400, Jason Gunthorpe wrote: > I think it is just better to follow kernel convention and have > allocation functions include the GFP because it is a clear signal to > the user that there is an allocation hidden inside the API. The whole > point of gfp is not to h

Re: [PATCH 1/3] drm/rockchip: lvds: add rk3568 support

2023-01-20 Thread s.ha...@pengutronix.de
On Fri, Jan 20, 2023 at 09:31:43AM +, Sverdlin, Alexander wrote: > Hello Sascha, > > On Fri, 2023-01-20 at 10:16 +0100, Sascha Hauer wrote: > > > +   /* Enable LVDS mode */ > > > +   return regmap_update_bits(lvds->grf, RK3568_GRF_VO_CON2, > > > + RK3568

Re: [PATCH][next] accel/ivpu: Fix spelling mistake "tansition" -> "transition"

2023-01-20 Thread Stanislaw Gruszka
On Fri, Jan 20, 2023 at 09:28:42AM +, Colin Ian King wrote: > There are spelling mistakes in two ivpu_err error messages. Fix them. > > Signed-off-by: Colin Ian King Reviewed-by: Stanislaw Gruszka > --- > drivers/accel/ivpu/ivpu_hw_mtl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI

2023-01-20 Thread Boris Brezillon
On Thu, 19 Jan 2023 04:58:48 + Matthew Brost wrote: > > For the ops structures the drm_gpuva_manager allocates for reporting the > > split/merge steps back to the driver I have ideas to entirely avoid > > allocations, which also is a good thing in respect of Christians feedback > > regarding

Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Krzysztof Kozlowski
On 20/01/2023 10:47, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > --- > Changes in v2: > - Remove "items" between "compatible" and "const: kinetic,ktz8866". > - Change "additionalProperties" to "unevaluatedProperties". > > Changes i

Re: [PATCH drm-next 13/14] drm/nouveau: implement new VM_BIND UAPI

2023-01-20 Thread Boris Brezillon
On Thu, 19 Jan 2023 16:38:06 + Matthew Brost wrote: > On Thu, Jan 19, 2023 at 04:36:43PM +0100, Danilo Krummrich wrote: > > On 1/19/23 05:58, Matthew Brost wrote: > > > On Thu, Jan 19, 2023 at 04:44:23AM +0100, Danilo Krummrich wrote: > > > > On 1/18/23 21:37, Thomas Hellström (Intel) wro

[PATCH 0/2] drm/tegra: handle implicit scanout modifiers

2023-01-20 Thread Diogo Ivo
Hello! This patch series adds support for correctly displaying tiled framebuffers when no modifiers are reported by userspace. Patch 1 adds the sector_layout parameter to the SET/GET_TILING IOCTLs so that userspace can set this field appropriately. Patch 2 adds handling of the case where the buf

[PATCH 2/2] drm/tegra: add scanout support for implicit tiling parameters

2023-01-20 Thread Diogo Ivo
When importing buffers from the GPU to scan out, it may happen that the buffer object has non-trivial tiling parameters, which currently go by undetected. This leads to the framebuffer being read and displayed in the wrong order. Explicitly check for this case and reconstruct the adequate modifier

[PATCH 1/2] drm/tegra: add sector layout to SET/GET_TILING IOCTLs

2023-01-20 Thread Diogo Ivo
Commit 7b6f846785f4 ("drm/tegra: Support sector layout on Tegra194") updated struct tegra_bo_tiling with a new field conveying information about the sector layout of the buffer object. Update the SET/GET_TILING IOCTLs with this field so that userspace can set it appropriately. Signed-off-by: Diogo

Re: [PATCH] drm/tegra: sor: Remove redundant error logging

2023-01-20 Thread Deepak R Varma
On Tue, Dec 20, 2022 at 02:27:50AM +0530, Deepak R Varma wrote: > On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote: > > Hello, > May I please request a review and feedback on this patch proposal? > > Also, I was able to build the changes for ARM arch verified using modinfo > tegr-dr

Re: [PATCH v3 2/3] iommu/sound: Use component_match_add_of helper

2023-01-20 Thread AngeloGioacchino Del Regno
Il 19/01/23 20:10, Sean Anderson ha scritto: Convert users of component_match_add_release with component_release_of and component_compare_of to component_match_add_of. Signed-off-by: Sean Anderson Acked-by: Mark Brown Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v3 3/3] drm: Convert users of drm_of_component_match_add to component_match_add_of

2023-01-20 Thread AngeloGioacchino Del Regno
Il 19/01/23 20:10, Sean Anderson ha scritto: Every user of this function either uses component_compare_of or something equivalent. Most of them immediately put the device node as well. Convert these users to component_match_add_of and remove drm_of_component_match_add. Signed-off-by: Sean Anders

Re: [Intel-gfx] [PATCH] drm/i915/selftest: fix intel_selftest_modify_policy argument types

2023-01-20 Thread Andi Shyti
Hi Arnd, On Tue, Jan 17, 2023 at 05:37:29PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The definition of intel_selftest_modify_policy() does not match the > declaration, as gcc-13 points out: > > drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c:29:5: error: > conflicting typ

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-20 Thread Diogo Ivo
On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > As a quick check can you try changing > > > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_targ

[PATCH v2 1/2] backlight: pwm_bl: Configure pwm only once per backlight toggle

2023-01-20 Thread Uwe Kleine-König
When the function pwm_backlight_update_status() was called with brightness > 0, pwm_get_state() was called twice (once directly and once in compute_duty_cycle). Also pwm_apply_state() was called twice (once in pwm_backlight_power_on() and once directly). Optimize this to do both calls only once.

[PATCH v2 0/2] backlight: pwm_bl: Two PWM releated changes

2023-01-20 Thread Uwe Kleine-König
Hello, here comes the promised v2 of this series. Implicit v1 is available at https://lore.kernel.org/dri-devel/20230109204758.610400-1-u.kleine-koe...@pengutronix.de . Changes since (implicit) v1 all due to feedback by Daniel Thompson: - Update changelogs - Still disable PWM if there is an en

[PATCH v2 2/2] backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state

2023-01-20 Thread Uwe Kleine-König
Most but not all PWMs drive the PWM pin to its inactive state when disabled. However if there is no enable_gpio and no regulator the PWM must drive the inactive state to actually disable the backlight. So keep the PWM on in this case. Note that to determine if there is a regulator some effort is

Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-20 Thread Fabio Estevam
Hi Jagan, On Thu, Jan 19, 2023 at 2:59 PM Jagan Teki wrote: > There are two patch series prior to this need to apply. > > https://patchwork.kernel.org/project/dri-devel/patch/20221212145745.15387-1-ja...@amarulasolutions.com/ > https://patchwork.kernel.org/project/dri-devel/cover/20221212182923.

[PATCH] drm/bridge: panel: Set orientation on panel_bridge connector

2023-01-20 Thread John Keeping
Commit 15b9ca1641f0 ("drm: Config orientation property if panel provides it") added a helper to set the panel panel orientation early but only connected this for drm_bridge_connector, which constructs a panel bridge with DRM_BRIDGE_ATTACH_NO_CONNECTOR and creates the connector itself. When the DRM

[PATCH 2/3] drm/fb-helper: Check fb_deferred_io_init() return value

2023-01-20 Thread Javier Martinez Canillas
The fb_deferred_io_init() can fail and return an errno code but currently there is no check for its return value. Fix that and propagate to errno to the caller in the case of a failure. Fixes: d536540f304c ("drm/fb-helper: Add generic fbdev emulation .fb_probe function") Signed-off-by: Javier Ma

[PATCH 1/3] fbdev: Remove unused struct fb_deferred_io .first_io field

2023-01-20 Thread Javier Martinez Canillas
This optional callback was added in the commit 1f45f9dbb392 ("fb_defio: add first_io callback") but it was never used by a driver. Let's remove it since it's unlikely that will be used after a decade that was added. Signed-off-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c

[PATCH 0/3] Fixes and cleanup for DRM fbdev emulation and deferred I/O

2023-01-20 Thread Javier Martinez Canillas
Hello, This patch series contains two fixes and a cleanup for things that I noticed while debugging a regression in the fbdev emulation for a DRM driver. The first two patches are trivial and shoulnd't be controversial, the third patch is less trivial, but it has been already reviewed by Thomas a

[PATCH 3/3] drm/fb-helper: Use a per-driver FB deferred I/O handler

2023-01-20 Thread Javier Martinez Canillas
The DRM fbdev emulation layer sets the struct fb_info .fbdefio field to a struct fb_deferred_io pointer, that is shared across all drivers that use the generic drm_fbdev_generic_setup() helper function. It is a problem because the fbdev core deferred I/O logic assumes that the struct fb_deferred_i

Re: [PATCH 1/3] fbdev: Remove unused struct fb_deferred_io .first_io field

2023-01-20 Thread Thomas Zimmermann
Am 20.01.23 um 13:08 schrieb Javier Martinez Canillas: This optional callback was added in the commit 1f45f9dbb392 ("fb_defio: add first_io callback") but it was never used by a driver. Let's remove it since it's unlikely that will be used after a decade that was added. Signed-off-by: Javier M

Re: [PATCH 2/3] drm/fb-helper: Check fb_deferred_io_init() return value

2023-01-20 Thread Thomas Zimmermann
Am 20.01.23 um 13:08 schrieb Javier Martinez Canillas: The fb_deferred_io_init() can fail and return an errno code but currently there is no check for its return value. Fix that and propagate to errno to the caller in the case of a failure. Fixes: d536540f304c ("drm/fb-helper: Add generic fbd

[PATCH linux-next 2/3] habanalabs: Fix list of /sys/class/habanalabs/hl/status

2023-01-20 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warnings when merging accel tree: Documentation/ABI/testing/sysfs-driver-habanalabs:201: ERROR: Unexpected indentation. Documentation/ABI/testing/sysfs-driver-habanalabs:201: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/ABI

[PATCH linux-next 0/3] Documentation fixes for linux-next (Jan 20)

2023-01-20 Thread Bagas Sanjaya
Here are fixes for recent htmldocs warnings reported in linux-next. Each patches can be picked up separately if ACKed. Bagas Sanjaya (3): Documentation: accel: escape wildcard in special file path habanalabs: Fix list of /sys/class/habanalabs/hl/status kvm: x86/pmu: Add blank line separator

[PATCH linux-next 1/3] Documentation: accel: escape wildcard in special file path

2023-01-20 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warning then merging accel tree: Documentation/accel/introduction.rst:72: WARNING: Inline emphasis start-string without end-string. Sphinx confuses the file wildcards with inline emphasis (italics), hence the warning. Fix the warning by escaping wildcards. Li

[PATCH linux-next 3/3] kvm: x86/pmu: Add blank line separator before KVM_CAP_PMU_EVENT_MASKED_EVENTS code path list

2023-01-20 Thread Bagas Sanjaya
Stephen Rothwell reported htmldocs warning when merging kvm-x86 tree: Documentation/virt/kvm/api.rst:5070: ERROR: Unexpected indentation. Fix the warning by adding a blank line separator before KVM_CAP_PMU_EVENT_MASKED_EVENTS code path list to determine guest access. Link: https://lore.kernel.o

Re: [PATCH v8 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Krzysztof Kozlowski
On 20/01/2023 13:38, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-20 Thread Jagan Teki
Hi Fabio, On Fri, Jan 20, 2023 at 5:36 PM Fabio Estevam wrote: > > Hi Jagan, > > On Thu, Jan 19, 2023 at 2:59 PM Jagan Teki wrote: > > > There are two patch series prior to this need to apply. > > > > https://patchwork.kernel.org/project/dri-devel/patch/20221212145745.15387-1-ja...@amarulasoluti

Re: [PATCH linux-next 1/3] Documentation: accel: escape wildcard in special file path

2023-01-20 Thread Jeffrey Hugo
On 1/20/2023 5:35 AM, Bagas Sanjaya wrote: Stephen Rothwell reported htmldocs warning then merging accel tree: Documentation/accel/introduction.rst:72: WARNING: Inline emphasis start-string without end-string. Sphinx confuses the file wildcards with inline emphasis (italics), hence the warning

Re: [PATCH v2 2/2] backlight: pwm_bl: Don't rely on a disabled PWM emiting inactive state

2023-01-20 Thread Daniel Thompson
On Fri, Jan 20, 2023 at 01:00:18PM +0100, Uwe Kleine-König wrote: > Most but not all PWMs drive the PWM pin to its inactive state when > disabled. However if there is no enable_gpio and no regulator the PWM > must drive the inactive state to actually disable the backlight. > > So keep the PWM on in

Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-20 Thread Marek Vasut
On 1/20/23 15:41, Jagan Teki wrote: Hi Fabio, Hello all, On Fri, Jan 20, 2023 at 5:36 PM Fabio Estevam wrote: Hi Jagan, On Thu, Jan 19, 2023 at 2:59 PM Jagan Teki wrote: There are two patch series prior to this need to apply. https://patchwork.kernel.org/project/dri-devel/patch/202212

Re: pr-tracker-bot for drm subsystem?

2023-01-20 Thread Konstantin Ryabitsev
On Fri, Jan 20, 2023 at 09:09:18AM +0200, Jani Nikula wrote: > > Konstantin? Sorry, I didn't mean to scholz you around. The pr-tracker-bot is very much a bespoke solution for Linus, so adapting it to other subsystems is not very trivial, which is why I've been sitting on this request without any

Re: [PATCH 2/2] drm/panel: st7703: Add support for Anbernic RG353V-V2 panel

2023-01-20 Thread Chris Morgan
On Fri, Jan 20, 2023 at 10:06:48AM +0100, Guido Günther wrote: > Hi, > On Thu, Jan 19, 2023 at 05:04:15PM -0600, Chris Morgan wrote: > > From: Chris Morgan > > > > The Anbernic RG353V-V2 is a 5 inch panel used in a new revision of the > > Anbernic RG353V handheld gaming device. Add support for it

Re: [PATCH v7 1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-20 Thread Daniel Thompson
On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu > [...] > > diff --git > a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml > b/Documentation/devicetree/bindings/leds/backlight/k

Re: [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-01-20 Thread Sean Paul
On Thu, Jan 19, 2023 at 11:37:52AM +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 20:30, Mark Yacoub wrote: > > From: Sean Paul > > > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > > drivers can use it. No functional changes, just cleaned up some of the > > code when

Re: [PATCH v3 3/3] drm: Convert users of drm_of_component_match_add to component_match_add_of

2023-01-20 Thread Liviu Dudau
On Thu, Jan 19, 2023 at 02:10:39PM -0500, Sean Anderson wrote: > Every user of this function either uses component_compare_of or > something equivalent. Most of them immediately put the device node as > well. Convert these users to component_match_add_of and remove > drm_of_component_match_add. >

[PATCH] drm: exynos: Make g2d_open() and g2d_close() static

2023-01-20 Thread Benjamin Gaignard
Fix "no previous prototype" warning when compiling with W=1 by making the functions static like the ones above them. Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-- 1 file changed, 2 i

Re: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-01-20 Thread Sean Paul
On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote: > On 18/01/2023 20:30, Mark Yacoub wrote: > > From: Sean Paul > > > > This patch adds the register ranges required for HDCP key injection and > > Do not use "This commit/patch". > https://elixir.bootlin.com/linux/v5.17.1/source

Re: [PATCH v2 2/7] drm: rcar-du: lvds: Add runtime PM

2023-01-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:04AM +0200, Tomi Valkeinen wrote: > Add simple runtime PM suspend and resume functionality. I think you need to depend on PM in Kconfig. That's not a compile-time dependency but a runtime-dependency, with runtime PM support the susp

Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: > Reset LVDS using the reset control as CPG reset/release is required in > the hardware manual sequence. > > Based on a BSP patch from Koji Matsuoka . > > Signed-off-by: Tomi Valkeinen > --- > dr

Re: [PATCH v2 4/7] drm: rcar-du: lvds: Fix stop sequence

2023-01-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:06AM +0200, Tomi Valkeinen wrote: > From: Koji Matsuoka > > According to hardware manual, LVDCR0 register must be cleared bit by bit > when disabling LVDS. > > Signed-off-by: Koji Matsuoka > Signed-off-by: LUU HOAI > [tomi.valke

Re: [PATCH v2 7/7] drm: rcar-du: Stop accessing non-existant registers on gen4

2023-01-20 Thread Laurent Pinchart
On Fri, Jan 20, 2023 at 10:50:09AM +0200, Tomi Valkeinen wrote: > The following registers do not exist on gen4, so we should not write > them: DEF6Rm, DEF7Rm, DEF8Rm, ESCRn, OTARn. > > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c

Re: [PATCH v2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-20 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Wed, Jan 18, 2023 at 01:39:05AM +0200, Dmitry Baryshkov wrote: > There are two flags attemting to guard connector polling: > poll_enabled and poll_running. While poll_enabled semantics is clearly > defined and fully adhered (mark that drm_kms_helper_poll_ini

Re: [Intel-gfx] [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion

2023-01-20 Thread Teres Alexis, Alan Previn
On Fri, 2023-01-20 at 08:27 +, Gupta, Anshuman wrote: > > > > -Original Message- > > From: Intel-gfx On Behalf Of Alan > > Previn > > Sent: Friday, January 20, 2023 1:20 AM > > To: intel-...@lists.freedesktop.org > > Cc: v...@freedesktop.org; dri-devel@lists.freedesktop.org; Teres Al

[PATCH 0/8] GuC oriented print macros

2023-01-20 Thread Michal Wajdeczko
This is a follow up series for existing commit 67804e48b494 ("drm/i915/gt: Start adding module oriented dmesg output") that was focusing just on the GT. Now extend changes to uc/ folder and focus on the GuC. Cc: Tvrtko Ursulin Cc: John Harrison Michal Wajdeczko (8): drm/i915/guc: Add GuC

[PATCH 1/8] drm/i915/guc: Add GuC oriented print macros

2023-01-20 Thread Michal Wajdeczko
While we do have GT oriented print macros, add few more GuC specific to have common look and feel across all messages related to the GuC and to avoid chasing the gt pointer. We will use these macros shortly in upcoming patches. Signed-off-by: Michal Wajdeczko Cc: Tvrtko Ursulin Cc: John Harriso

[PATCH 2/8] drm/i915/guc: Update GuC messages in intel_guc.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c | 31 +- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/dri

[PATCH 4/8] drm/i915/guc: Update GuC messages in intel_guc_ct.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/d

[PATCH 8/8] drm/i915/guc: Update GT/GuC messages in intel_uc.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 74 +-- 1 file changed, 36 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/driv

[PATCH 6/8] drm/i915/guc: Update GuC messages in intel_guc_log.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 35 +++--- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b

[PATCH 7/8] drm/i915/guc: Update GuC messages in intel_guc_submission.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 60 --- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submissi

[PATCH 3/8] drm/i915/guc: Update GuC messages in intel_guc_ads.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/

[PATCH 5/8] drm/i915/guc: Update GuC messages in intel_guc_fw.c

2023-01-20 Thread Michal Wajdeczko
Use new macros to have common prefix that also include GT#. Signed-off-by: Michal Wajdeczko Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c b/drivers/

Re: [PATCH 1/1] drm/i915/gsc: Fix the Driver-FLR completion

2023-01-20 Thread Teres Alexis, Alan Previn
Thanks for reviewing - sounds good - will fix those comments up as per your recommendation. On Fri, 2023-01-20 at 11:14 +0200, Jani Nikula wrote: > On Thu, 19 Jan 2023, Alan Previn wrote: > > The Driver-FLR flow may inadvertently exit early before the full > > completion of the re-init of the in

Re: [PATCH v2 6/7] drm: rcar-du: Fix setting a reserved bit in DPLLCR

2023-01-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Fri, Jan 20, 2023 at 10:50:08AM +0200, Tomi Valkeinen wrote: > On H3 ES1.x two bits in DPLLCR are used to select the DU input dot clock > source. These are bits 20 and 21 for DU2, and bits 22 and 23 for DU1. On > non-ES1.x, only the higher bits are used (bits

Re: [PATCH v2 3/7] drm: rcar-du: lvsd: Add reset control

2023-01-20 Thread Laurent Pinchart
On Fri, Jan 20, 2023 at 06:18:07PM +0200, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. Another small comment: in the commit message, s/lvsd/lvds/ > On Fri, Jan 20, 2023 at 10:50:05AM +0200, Tomi Valkeinen wrote: > > Reset LVDS using the reset control as CPG reset/release is re

Re: [PATCH v2 1/2] backlight: pwm_bl: Configure pwm only once per backlight toggle

2023-01-20 Thread Lee Jones
On Fri, 20 Jan 2023, Uwe Kleine-König wrote: > When the function pwm_backlight_update_status() was called with > brightness > 0, pwm_get_state() was called twice (once directly and once > in compute_duty_cycle). Also pwm_apply_state() was called twice (once in > pwm_backlight_power_on() and once d

  1   2   3   >