Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-17 Thread Johan Hovold
On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > > On 13/01/2023 06:10, Bjorn Andersson wrote: > > > > Invoking drm_bridge_hpd_notify() on a drm_bridge with a HPD

Re: [PATCH] drm/ttm: Include to fix MIPS build

2023-01-17 Thread Thomas Zimmermann
Hi Am 16.01.23 um 15:40 schrieb Christian König: Am 16.01.23 um 13:13 schrieb Thomas Zimmermann: I'd add a Fixes tag, but don't know the commit when this was introduced. Mhm, that code is 10+ years old. My educated guess is that we somehow pulled in vmap/vunmap through a header which was now

Re: [PATCH 7/8] iommu/intel: Support the gfp argument to the map_pages op

2023-01-17 Thread Baolu Lu
On 2023/1/17 11:38, Tian, Kevin wrote: From: Jason Gunthorpe Sent: Saturday, January 7, 2023 12:43 AM @@ -2368,7 +2372,7 @@ static int iommu_domain_identity_map(struct dmar_domain *domain, return __domain_mapping(domain, first_vpfn, first_vpfn, last_vpfn

Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

2023-01-17 Thread Thomas Zimmermann
Hi Am 16.01.23 um 19:37 schrieb Alex Deucher: On Mon, Jan 16, 2023 at 11:20 AM Jani Nikula wrote: On Mon, 16 Jan 2023, Thomas Zimmermann wrote: A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies. Where pos

Re: [PATCH 00/22] drm: Remove includes for drm_crtc_helper.h

2023-01-17 Thread Thomas Zimmermann
Hi Am 16.01.23 um 21:47 schrieb Sam Ravnborg: Hi Thomas. On Mon, Jan 16, 2023 at 02:12:13PM +0100, Thomas Zimmermann wrote: A lot of source files include drm_crtc_helper.h for its contained include statements. This leads to excessive compile-time dependencies. Where possible, remove the inclu

Re: [PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Das, Nirmoy
On 1/16/2023 7:49 PM, Andi Shyti wrote: Hi Nirmoy, On Fri, Jan 13, 2023 at 01:00:53PM +0100, Nirmoy Das wrote: From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp

Re: [PATCH 8/8] iommu/s390: Push the gfp parameter to the kmem_cache_alloc()'s

2023-01-17 Thread Niklas Schnelle
On Fri, 2023-01-06 at 12:42 -0400, Jason Gunthorpe wrote: > dma_alloc_cpu_table() and dma_alloc_page_table() are eventually called by > iommufd through s390_iommu_map_pages() and it should not be forced to > atomic. Thread the gfp parameter through the call chain starting from > s390_iommu_map_page

Re: [PATCH] drm/connector: fix a kernel-doc bad line warning

2023-01-17 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v6 0/7] New DRM accel driver for Intel VPU

2023-01-17 Thread Jacek Lawrynowicz
Hi, This patchset contains a new Linux* Kernel Driver for Intel® VPUs. VPU stands for Versatile Processing Unit and it is an AI inference accelerator integrated with Intel non-server CPUs starting from 14th generation. VPU enables efficient execution of Deep Learning applications like object dete

[PATCH v6 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-17 Thread Jacek Lawrynowicz
ver); + +MODULE_AUTHOR("Intel Corporation"); +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_LICENSE("GPL and additional rights"); +MODULE_VERSION(DRIVER_VERSION_STR); diff --git a/drivers/accel/ivpu/ivpu_drv.h b/drivers/accel/ivpu/ivpu_drv.h new file mode 100644 index 0..d0b006893b1

[PATCH v6 3/7] accel/ivpu: Add GEM buffer object management

2023-01-17 Thread Jacek Lawrynowicz
Adds four types of GEM-based BOs for the VPU: - shmem - internal - prime All types are implemented as struct ivpu_bo, based on struct drm_gem_object. VPU address is allocated when buffer is created except for imported prime buffers that allocate it in BO_INFO IOCTL due to missing file_priv a

[PATCH v6 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-17 Thread Jacek Lawrynowicz
The IPC driver is used to send and receive messages to/from firmware running on the VPU. The only supported IPC message format is Job Submission Model (JSM) defined in vpu_jsm_api.h header. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynsk

[PATCH v6 2/7] accel/ivpu: Add Intel VPU MMU support

2023-01-17 Thread Jacek Lawrynowicz
_ON(&vdev->drm, !xa_empty(&vdev->context_xa)); xa_destroy(&vdev->context_xa); diff --git a/drivers/accel/ivpu/ivpu_drv.h b/drivers/accel/ivpu/ivpu_drv.h index d0b006893b1ce..b9ce66f406968 100644 --- a/drivers/accel/ivpu/ivpu_drv.h +++ b/drivers/accel/ivpu/ivpu_drv.h @@ -15

[PATCH v6 5/7] accel/ivpu: Implement firmware parsing and booting

2023-01-17 Thread Jacek Lawrynowicz
Read, parse and boot VPU firmware image. Co-developed-by: Andrzej Kacprowski Signed-off-by: Andrzej Kacprowski Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Oded Gabbay Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/

[PATCH v6 7/7] accel/ivpu: Add PM support

2023-01-17 Thread Jacek Lawrynowicz
- Implement cold and warm firmware boot flows - Add hang recovery support - Add runtime power management support Co-developed-by: Krystian Pradzynski Signed-off-by: Krystian Pradzynski Signed-off-by: Jacek Lawrynowicz Reviewed-by: Jeffrey Hugo --- drivers/accel/ivpu/Makefile | 3

[PATCH v6 6/7] accel/ivpu: Add command buffer submission logic

2023-01-17 Thread Jacek Lawrynowicz
Each of the user contexts has two command queues, one for compute engine and one for the copy engine. Command queues are allocated and registered in the device when the first job (command buffer) is submitted from the user space to the VPU device. The userspace provides a list of GEM buffer object

Re: [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

2023-01-17 Thread Lukas Wunner
On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: > Several lastclose helpers call vga_switcheroo_process_delayed_switch(). > It's better to call the helper from drm_lastclose() after the kernel > client's screen has been restored. This way, all drivers can benefit > without having

Re: [RFC PATCH 0/4] dt-bindings: Introduce dual-link panels & panel-vendors

2023-01-17 Thread Aradhya Bhatia
Hi Laurent, Thank you for taking a look at this! On 16-Jan-23 15:00, Laurent Pinchart wrote: Hi Aradhya, On Tue, Jan 03, 2023 at 12:16:11PM +0530, Aradhya Bhatia wrote: Hi all, Microtips Technology Solutions USA, and Lincoln Technology Solutions are 2 display panel vendors, and the first 2 p

RE: [PATCH] dt-bindings: display: bridge: renesas,rzg2l-mipi-dsi: Document RZ/V2L support

2023-01-17 Thread Biju Das
Hi All, Gentle ping. It is acked by Krzysztof Kozlowski and Reviewed by Geert. It is blocking for accepting SoC dtsi patches[1] through renesas-soc tree [1] https://lore.kernel.org/all/20221122213529.2103849-1-biju.das...@bp.renesas.com Cheers, Biju > -Original Message- > From: Biju

Re: [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

2023-01-17 Thread Thomas Zimmermann
Hi Am 17.01.23 um 10:44 schrieb Lukas Wunner: On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: Several lastclose helpers call vga_switcheroo_process_delayed_switch(). It's better to call the helper from drm_lastclose() after the kernel client's screen has been restored. This w

Re: [PATCH v11 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2023-01-17 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Tue, Jan 03, 2023 at 03:49:51PM +0530, Rahul T R wrote: > Add support for wrapper settings for DSI bridge on j721e. Also enable > DPI0 > > --- --- > | ---| |--- | > | DSS | DPI2 |->| DP

[PATCH 1/1] drm/bridge: sii902x: Use dev_err_probe

2023-01-17 Thread Alexander Stein
This helps figuring out why the device probe is deferred. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/sii902x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index d212ff7f7a87..f4a8f227c41b

Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros

2023-01-17 Thread Alexandre TORGUE
Hi Laurent On 1/14/23 16:36, Laurent Pinchart wrote: Hugues, Maxime, Alexandre, could one of you take this patch in your tree for v6.3 ? The two patches that it depends on have both been merged in v6.2. Yes sure. Cheers Alex On Thu, Jun 16, 2022 at 01:14:10AM +0300, Laurent Pinchart wrote:

[PATCH 1/2] drm: fsl-dcu: Use dev_err_probe

2023-01-17 Thread Alexander Stein
fsl_dcu_drm_modeset_init can return -EPROBE_DEFER, so use dev_err_probe to remove an invalid error message and add it to deferral description. Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH 2/2] drm: fsl-dcu: enable PIXCLK on LS1021A

2023-01-17 Thread Alexander Stein
From: Matthias Schiffer The PIXCLK needs to be enabled in SCFG before accessing certain DCU registers, or the access will hang. Signed-off-by: Matthias Schiffer Signed-off-by: Alexander Stein --- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 14

Re: [PATCH 1/1] drm/bridge: sii902x: Use dev_err_probe

2023-01-17 Thread Andrzej Hajda
On 17.01.2023 11:59, Alexander Stein wrote: This helps figuring out why the device probe is deferred. Signed-off-by: Alexander Stein --- drivers/gpu/drm/bridge/sii902x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/dr

Re: [PATCH v11 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml

2023-01-17 Thread Andrzej Hajda
On 03.01.2023 11:19, Rahul T R wrote: Convert cdns,dsi.txt binding to yaml format Signed-off-by: Rahul T R Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [PATCH v11 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

2023-01-17 Thread Andrzej Hajda
On 03.01.2023 11:19, Rahul T R wrote: Add compatible to support dsi bridge on j721e Signed-off-by: Rahul T R Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Andrzej Hajda Regards Andrzej --- .../bindings/display/bridge/cdns,dsi.yaml | 25 ++-

Re: [PATCH v11 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2023-01-17 Thread Andrzej Hajda
On 03.01.2023 11:19, Rahul T R wrote: Move the cadence dsi bridge under drm/bridge/cadence directory, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Andrzej Hajda Regards Andrzej --- drivers/

Re: [PATCH v11 4/5] drm/bridge: cdns-dsi: Create a header file

2023-01-17 Thread Andrzej Hajda
On 03.01.2023 11:19, Rahul T R wrote: Create a header file for cdns dsi and move structure definations to prepare for adding j721e wrapper support Signed-off-by: Rahul T R Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart Reviewed-by: Andrzej Hajda Regards Andrzej

Re: [PATCH v11 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2023-01-17 Thread Andrzej Hajda
On 03.01.2023 11:19, Rahul T R wrote: Add support for wrapper settings for DSI bridge on j721e. Also enable DPI0 --- --- | ---| |--- | | DSS | DPI2 |->| DPI0 | DSI Wrapper | | ---| |--- |

[PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Nirmoy Das
Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Signed-off-by: Nirmoy Das --- include/drm/drm_print.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/drm/d

[PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-01-17 Thread Nirmoy Das
Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause dmesg spamming. Use ratelimit api to reduce log rate. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 Cc: Matthew Auld Reviewed-by: Matthew Auld Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Andrzej Hajda
On 17.01.2023 12:53, Nirmoy Das wrote: Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld Signed-off-by: Nirmoy Das Reviewed-by: Andrzej Hajda Regards Andrzej --- in

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-01-17 Thread Andrzej Hajda
On 17.01.2023 12:53, Nirmoy Das wrote: Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause dmesg spamming. Use ratelimit api to reduce log rate. References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 Cc: Matthew Auld Reviewed-by: Matthew Auld Signed-off-by: Nirmoy Da

Re: [PATCH v3 6/6] ARM: dts: stm32: Use new media bus type macros

2023-01-17 Thread Alexandre TORGUE
Hi Laurent On 6/16/22 00:14, Laurent Pinchart wrote: Now that a header exists with macros for the media interface bus-type values, replace hardcoding numerical constants with the corresponding macros in the DT sources. Signed-off-by: Laurent Pinchart Applied on stm32-next. Thanks. Alex

Re: [PATCH v3 1/2] drm/panel: Add driver for the AUO A030JTN01 TFT LCD

2023-01-17 Thread Paul Cercueil
Hi Christophe, Le mardi 20 décembre 2022 à 13:01 +0100, Christophe Branchereau a écrit : > Add driver for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit > interface. > > Signed-off-by: Christophe Branchereau > Signed-off-b

Re: [PATCH v2 20/20] jump_label: RFC - tolerate toggled state

2023-01-17 Thread Peter Zijlstra
On Fri, Jan 13, 2023 at 12:30:16PM -0700, Jim Cromie wrote: > __jump_label_patch currently will "crash the box" if it finds a > jump_entry not as expected. ISTM this overly harsh; it doesn't > distinguish between "alternate/opposite" state, and truly > "insane/corrupted". > > The "opposite" (but

[PATCH v2] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Nirmoy Das
From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. v2: add another missing "goto out_wf"(Andi). Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp") Cc: Andi Shyti Reviewed-by: Matthew Auld Reviewed-by: Andrzej Hajd

Re: [PATCH v11 0/5] Add support for CDNS DSI J721E wrapper

2023-01-17 Thread Tomi Valkeinen
Hi, On 03/01/2023 12:19, Rahul T R wrote: Following series of patches adds supports for CDNS DSI bridge on j721e. v11: - Wrap commmit messages at 72 chars - Fix the order in Kconfig and Makefile - Clean up the includes, move macros and some headers to .c file - Add missing forward decla

[PATCH] drm/ttm: fix some minor kerneldoc issues

2023-01-17 Thread Christian König
Pointed out by the kernel test robot while merging ttm_bo_api.h and ttm_bo_driver.h. Signed-off-by: Christian König Reported-by: kernel test robot --- drivers/gpu/drm/ttm/ttm_bo_util.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_u

Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Acer Aspire 4810T

2023-01-17 Thread Rafael J. Wysocki
On Fri, Jan 13, 2023 at 12:41 PM Hans de Goede wrote: > > The Acer Aspire 4810T predates Windows 8, so it defaults to using > acpi_video# for backlight control, but this is non functional on > this model. > > Add a DMI quirk to use the native backlight interface which does > work properly. > > Sig

Re: [PATCH] drm/ttm: fix some minor kerneldoc issues

2023-01-17 Thread Das, Nirmoy
Reviewed-by: Nirmoy Das On 1/17/2023 1:33 PM, Christian König wrote: Pointed out by the kernel test robot while merging ttm_bo_api.h and ttm_bo_driver.h. Signed-off-by: Christian König Reported-by: kernel test robot --- drivers/gpu/drm/ttm/ttm_bo_util.c | 13 ++--- 1 file changed,

Re: [PATCH 7/8] iommu/intel: Support the gfp argument to the map_pages op

2023-01-17 Thread Jason Gunthorpe
On Tue, Jan 17, 2023 at 03:38:51AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Saturday, January 7, 2023 12:43 AM > > > > @@ -2368,7 +2372,7 @@ static int iommu_domain_identity_map(struct > > dmar_domain *domain, > > > > return __domain_mapping(domain, first_vpfn, > >

Re: [PATCH 6/8] iommu/intel: Add a gfp parameter to alloc_pgtable_page()

2023-01-17 Thread Jason Gunthorpe
On Tue, Jan 17, 2023 at 03:35:08AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Saturday, January 7, 2023 12:43 AM > > > > @@ -2676,7 +2676,7 @@ static int copy_context_table(struct intel_iommu > > *iommu, > > if (!old_ce) > > goto

Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-17 Thread Laurent Pinchart
Hi Tomi, (CC'ing Mauro and Hans) On Tue, Jan 10, 2023 at 04:25:37PM +0200, Tomi Valkeinen wrote: > On 26/12/2022 16:56, Laurent Pinchart wrote: > > Hi Tomi, > > > > (CC'ing Daniel and Dave) > > > > On Wed, Dec 21, 2022 at 11:24:41AM +0200, Tomi Valkeinen wrote: > >> From: Tomi Valkeinen > >> >

Re: linux-next: duplicate patch in the kspp tree

2023-01-17 Thread Karol Herbst
On Tue, Jan 17, 2023 at 5:02 AM Stephen Rothwell wrote: > > Hi all, > > The following commit is also in the drm-misc tree as a different commit > (but the same patch): > > 06b19f46455c ("drm/nouveau/fb/ga102: Replace zero-length array of trailing > structs with flex-array") > which branch? Bec

Re: [Intel-gfx] [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Andi Shyti
Hi, can any of the DRM maintainers please check and eventually ack this patch? On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vett

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Ratelimit debug log in vm_fault_ttm

2023-01-17 Thread Andi Shyti
Hi Nirmoy, On Tue, Jan 17, 2023 at 12:53:50PM +0100, Nirmoy Das wrote: > Test like i915_gem_mman_live_selftests/igt_mmap_migrate can cause > dmesg spamming. Use ratelimit api to reduce log rate. > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/7038 > Cc: Matthew Auld > > Review

Re: [PATCH v2] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Andi Shyti
Hi Nirmoy, On Tue, Jan 17, 2023 at 01:32:34PM +0100, Nirmoy Das wrote: > From: Chris Wilson > > Make sure that upon error after we have acquired the wakeref we do > release it again. > > v2: add another missing "goto out_wf"(Andi). > > Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime

Re: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-17 Thread Daniel Thompson
On Tue, Jan 17, 2023 at 09:47:41PM +0800, Jianhua Lu wrote: > Add support for Kinetic KTZ8866 backlight, which is used in > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > downstream implementation [1]. > [1] > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/driv

[bug report] habanalabs: add debugfs support

2023-01-17 Thread Dan Carpenter
Hello Oded Gabbay, The patch c216477363a3: "habanalabs: add debugfs support" from Feb 16, 2019, leads to the following Smatch static checker warning: drivers/accel/habanalabs/common/debugfs.c:272 vm_show() warn: sleeping in atomic context drivers/accel/habanalabs/common/debugfs.c

Re: [PATCH v4 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2023-01-17 Thread Daniel Thompson
On Tue, Jan 17, 2023 at 09:47:42PM +0800, Jianhua Lu wrote: > Add Kinetic KTZ8866 backlight binding documentation. > > Signed-off-by: Jianhua Lu Might be a good idea to take a look at this bit of the docs because the patchset is not in the right order (I.5): https://docs.kernel.org/devicetree/bin

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Guilherme G. Piccoli
On 16/01/2023 23:33, Limonciello, Mario wrote: > [...] > > For debugging these type of problems, I think an effective debugging > tactic would have been to mask the IP block (amdgpu.ip_block_mask). Thank you, it worked indeed - nice suggestion! Though I see two problems with that: first, I'm no

Re: [PATCH v4 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2023-01-17 Thread Daniel Thompson
On Tue, Jan 17, 2023 at 10:12:18PM +0800, Jianhua Lu wrote: > On Tue, Jan 17, 2023 at 02:04:05PM +, Daniel Thompson wrote: > > On Tue, Jan 17, 2023 at 09:47:41PM +0800, Jianhua Lu wrote: > > > Add support for Kinetic KTZ8866 backlight, which is used in > > > Xiaomi tablet, Mi Pad 5 series. This

Re: [PATCH v3 2/3] drm/amdgpu: Remove redundant framebuffer format check

2023-01-17 Thread Maíra Canal
Hi Simon, On 1/13/23 14:06, Simon Ser wrote: Hm, unfortunately I think we need to keep the check in amdgpu for the same reason as i915: amdgpu will pick a modifier if user-space didn't supply one on GFX9+. I wonder if that also applies to vmwgfx? Maybe that would be a reason to have the check i

Re: [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Sam Ravnborg
Hi Nirmoy On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: > Add a function for ratelimitted debug print. > > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Reviewed-by: Matthew Auld > Signed-off-by: Nirmoy Das Thanks

Re: [PATCH v3 8/8] arm64: tegra: Add simple framebuffer on Jetson Xavier NX

2023-01-17 Thread Thomas Zimmermann
Hi Am 17.11.22 um 19:40 schrieb Thierry Reding: From: Thierry Reding Add the framebuffer carveout reserved memory node as well as a simple- framebuffer node that is used to bind to the framebuffer that the bootloader has set up. I don't know about the current status of this patchset, but fee

Re: [PATCH 1/2] drm/print: Add drm_dbg_ratelimited

2023-01-17 Thread Das, Nirmoy
Hi Sam, On 1/17/2023 3:49 PM, Sam Ravnborg wrote: Hi Nirmoy On Tue, Jan 17, 2023 at 12:53:49PM +0100, Nirmoy Das wrote: Add a function for ratelimitted debug print. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Matthew Auld

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 9:33 AM Guilherme G. Piccoli wrote: > > On 16/01/2023 23:33, Limonciello, Mario wrote: > > [...] > > > > For debugging these type of problems, I think an effective debugging > > tactic would have been to mask the IP block (amdgpu.ip_block_mask). > > Thank you, it worked ind

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #25 from Rainer Fiebig (j...@mailbox.org) --- (In reply to Alex Deucher from comment #23) > I'll just revert it. It is more important for kernels with the the > drm_buddy changes. Would the following be equivalent to what you intende

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #26 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Rainer Fiebig from comment #25) > (In reply to Alex Deucher from comment #23) > > I'll just revert it. It is more important for kernels with the the > > drm_buddy changes.

Re: [PATCH 2/6] drm: rcar-du: lvds: Add reset control

2023-01-17 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: > From: Koji Matsuoka > > Reset LVDS using the reset control as CPG reset/release is required in > H/W manual sequence. > > Signed-off-by: Koji Matsuoka > Signed-off-by: LUU HOAI > [tomi.valkeinen: Rewrite the patch description] >

Re: [RFC 04/12] drm/cgroup: Track clients per owning process

2023-01-17 Thread Stanislaw Gruszka
Hi On Thu, Jan 12, 2023 at 04:56:01PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > To enable propagation of settings from the cgroup drm controller to drm we > need to start tracking which processes own which drm clients. > > Implement that by tracking the struct pid pointer of the o

Re: [PATCH v2] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-17 Thread Das, Nirmoy
|Reviewed-by: Nirmoy Das | On 1/17/2023 1:32 PM, Nirmoy Das wrote: From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. v2: add another missing "goto out_wf"(Andi). Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp")

Re: [PATCH 4/6] drm: rcar-du: Add quirk for H3 ES1 pclk WA

2023-01-17 Thread Geert Uytterhoeven
Hi Tomi, On Tue, Jan 17, 2023 at 2:54 PM Tomi Valkeinen wrote: > rcar_du_crtc.c does a soc_device_match() in > rcar_du_crtc_set_display_timing() to find out if the SoC is H3 ES1, and > if so, apply a WA. > > We will need another H3 ES1 check in the following patch, so rather than > adding more so

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Dec 22, 2022 at 4:29 PM Matthew Brost wrote: > Hello, > > This is a submission for Xe, a new driver for Intel GPUs that supports both > integrated and discrete platforms starting with Tiger Lake (first platform > with > Intel Xe Architecture). The intention of this new driver is to have a

[PATCH 0/3] Allow composer fallbacks for color features

2023-01-17 Thread Kalyan Thota
This series will enable color features on sc7280 target which has primary panel as eDP The series removes dspp allocation based on encoder type and allows the datapath reservation even if dspps are not available. The series also adds a check to fail the composition during atomic check , if col

[PATCH 1/3] drm/msm/disp/dpu1: allow reservation even if dspps are not available.

2023-01-17 Thread Kalyan Thota
if any topology requests for dspps and catalogue doesn't have the allocation, avoid failing the reservation. This can pave way to build logic allowing composer fallbacks for all the color features that are handled in dspp. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c |

[PATCH 2/3] drm/msm/disp/dpu1: allow dspp selection for all the interfaces

2023-01-17 Thread Kalyan Thota
Allow dspps to be populated as a requirement for all the encoder types it need not be just DSI. If for any encoder the dspp allocation doesn't go through then there can be an option to fallback for color features. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 +

[PATCH 3/3] drm/msm/disp/dpu1: fail atomic check if color feature is requested with no dspp

2023-01-17 Thread Kalyan Thota
Fail atomic check if any color feature is requested with no dspps allocated in the datapath so that composer can offload those features. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/d

RE: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Tuesday, January 17, 2023 09:11 > To: Guilherme G. Piccoli > Cc: Limonciello, Mario ; Liu, Leo > ; amd-...@lists.freedesktop.org; Jiang, Sonny > ; ker...@gpiccoli.net; Pan, Xinhui > ; dri-devel@lists.freedesktop.org; Lazar, Lij

Re: [RFC 04/12] drm/cgroup: Track clients per owning process

2023-01-17 Thread Tvrtko Ursulin
On 17/01/2023 16:03, Stanislaw Gruszka wrote: Hi On Thu, Jan 12, 2023 at 04:56:01PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin To enable propagation of settings from the cgroup drm controller to drm we need to start tracking which processes own which drm clients. Implement that by t

Re: [PATCH 3/3] drm/amdgpu/vcn: Add parameter to force (en/dis)abling indirect SRAM mode

2023-01-17 Thread Guilherme G. Piccoli
On 17/01/2023 13:24, Limonciello, Mario wrote: > [...] >>> Though I see two problems with that: first, I'm not sure what's the >>> impact in the GPU functioning when I disable some IP block. >>> > > It depends on the individual block what the impact is. For example > if you don't have VCN, then y

Re: [PATCH 1/3] drm/msm/disp/dpu1: allow reservation even if dspps are not available.

2023-01-17 Thread Dmitry Baryshkov
On 17/01/2023 18:21, Kalyan Thota wrote: if any topology requests for dspps and catalogue doesn't have the allocation, avoid failing the reservation. This can pave way to build logic allowing composer fallbacks for all the color features that are handled in dspp. Signed-off-by: Kalyan Thota --

[PATCH] drm/i915/selftest: fix intel_selftest_modify_policy argument types

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The definition of intel_selftest_modify_policy() does not match the declaration, as gcc-13 points out: drivers/gpu/drm/i915/selftests/intel_scheduler_helpers.c:29:5: error: conflicting types for 'intel_selftest_modify_policy' due to enum/integer mismatch; have 'int(struct i

[PATCH] nouveau: fix nv50_wndw_new_() prototype

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann gcc-13 complains about a mismatched function declaration: drivers/gpu/drm/nouveau/dispnv50/wndw.c:696:1: error: conflicting types for 'nv50_wndw_new_' due to enum/integer mismatch; have 'int(const struct nv50_wndw_func *, struct drm_device *, enum drm_plane_type, const cha

Re: [PATCH 1/3] drm/msm/disp/dpu1: allow reservation even if dspps are not available.

2023-01-17 Thread Dmitry Baryshkov
On 17/01/2023 18:35, Dmitry Baryshkov wrote: On 17/01/2023 18:21, Kalyan Thota wrote: if any topology requests for dspps and catalogue doesn't have the allocation, avoid failing the reservation. This can pave way to build logic allowing composer fallbacks for all the color features that are han

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Jan 12, 2023 at 11:17 AM Matthew Brost wrote: > On Thu, Jan 12, 2023 at 10:54:25AM +0100, Lucas De Marchi wrote: > > On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote: > > > On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 22:21, Ma

Re: [PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2023-01-17 Thread Mauro Carvalho Chehab
Em Tue, 17 Jan 2023 15:38:25 +0200 Laurent Pinchart escreveu: > Hi Tomi, > > (CC'ing Mauro and Hans) > > On Tue, Jan 10, 2023 at 04:25:37PM +0200, Tomi Valkeinen wrote: > > On 26/12/2022 16:56, Laurent Pinchart wrote: > > > Hi Tomi, > > > > > > (CC'ing Daniel and Dave) > > > > > > On Wed, D

[PATCH] drm/panfrost: fix GENERIC_ATOMIC64 dependency

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann On ARMv5 and earlier, a randconfig build can still run into WARNING: unmet direct dependencies detected for IOMMU_IO_PGTABLE_LPAE Depends on [n]: IOMMU_SUPPORT [=y] && (ARM [=y] || ARM64 || COMPILE_TEST [=y]) && !GENERIC_ATOMIC64 [=y] Selected by [y]: - DRM_PANFROST [=

[linux-next:master] BUILD REGRESSION 9ce08dd7ea24253aac5fd2519f9aea27dfb390c9

2023-01-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9ce08dd7ea24253aac5fd2519f9aea27dfb390c9 Add linux-next specific files for 20230117 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301100332.4eaki4d1-...@intel.com https

[PATCH] vc4: fix build failure in vc4_dsi_dev_probe()

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The bridge->of_node field is defined inside of an #ifdef, which results in a build failure when compile-testing the vc4_dsi driver without CONFIG_OF: drivers/gpu/drm/vc4/vc4_dsi.c: In function 'vc4_dsi_dev_probe': drivers/gpu/drm/vc4/vc4_dsi.c:1822:20: error: 'struct drm_brid

[PATCH] drm: panel: visionox: add backlight dependency

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The newly added driver uses the backlight subsystem but is missing the corresponding Kconfig dependency: arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-vtdr6130.o: in function `visionox_vtdr6130_probe': panel-visionox-vtdr6130.c:(.text+0xdee): undefined reference

Re: [PATCH 2/3] drm/msm/disp/dpu1: allow dspp selection for all the interfaces

2023-01-17 Thread Dmitry Baryshkov
On 17/01/2023 18:21, Kalyan Thota wrote: Allow dspps to be populated as a requirement for all the encoder types it need not be just DSI. If for any encoder the dspp allocation doesn't go through then there can be an option to fallback for color features. Signed-off-by: Kalyan Thota --- driver

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #27 from Rainer Fiebig (j...@mailbox.org) --- (In reply to Alex Deucher from comment #26) > (In reply to Rainer Fiebig from comment #25) > > (In reply to Alex Deucher from comment #23) > > > I'll just revert it. It is more important f

Re: [PATCH V10 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-17 Thread Maxime Ripard
Hi, On Thu, Jan 12, 2023 at 11:53:55AM -0600, Chris Morgan wrote: > From: Chris Morgan > > Add helper function to find DSI host for devices where DSI panel is not > a minor of a DSI bus (such as the Samsung AMS495QA01 panel or the > official Raspberry Pi touchscreen display). > > Signed-off-by:

Re: (subset) [PATCH] drm/atomic-helper: fix kernel-doc problems

2023-01-17 Thread Maxime Ripard
On Mon, 16 Jan 2023 23:02:16 -0800, Randy Dunlap wrote: > Fix a kernel-doc warning and other kernel-doc formatting for > drm_atomic_helper_connect_tv_check(). > > drivers/gpu/drm/drm_atomic_state_helper.c:560: warning: Cannot understand * > @drm_atomic_helper_connector_tv_check: Validate an anal

Re: (subset) [PATCH] drm/connector: fix a kernel-doc bad line warning

2023-01-17 Thread Maxime Ripard
On Mon, 16 Jan 2023 23:02:24 -0800, Randy Dunlap wrote: > Building the kernel documentation causes this warning 7 times. > Fix it by adding a " *" line instead of a blank line. > > drivers/gpu/drm/drm_connector.c:1849: warning: bad line: > > Applied to drm/drm-misc (drm-misc-next). Thanks! Max

Re: (subset) [PATCH] vc4: fix build failure in vc4_dsi_dev_probe()

2023-01-17 Thread Maxime Ripard
On Tue, 17 Jan 2023 17:52:51 +0100, Arnd Bergmann wrote: > The bridge->of_node field is defined inside of an #ifdef, which > results in a build failure when compile-testing the vc4_dsi driver > without CONFIG_OF: > > drivers/gpu/drm/vc4/vc4_dsi.c: In function 'vc4_dsi_dev_probe': > drivers/gpu/drm

[PATCH] [v2] drm/amd/display: fix dp_retrieve_lttpr_cap return code

2023-01-17 Thread Arnd Bergmann
From: Arnd Bergmann The dp_retrieve_lttpr_cap() return type changed from 'bool' to 'enum dc_status', so now the early 'return' uses the wrong type: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap': drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_l

[PATCH] drm/msm/dp: Remove INIT_SETUP delay

2023-01-17 Thread Bjorn Andersson
During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP event is generated, but with a delay of 100 units. This delay existed to circumvent bug in the QMP combo PHY driver, where if the DP part was powered up before USB, the common properties would not be properly initialized - and

[PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Nirmoy Das
Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_d

[PATCH 2/2] drm_print: Remove deprecated DRM_DEBUG_KMS_RATELIMITED()

2023-01-17 Thread Nirmoy Das
There are no current users of DRM_DEBUG_KMS_RATELIMITED() so remove it. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: Sam Ravnborg Signed-off-by: Nirmoy Das --- include/drm/drm_print.h | 3 --- 1 file changed, 3 deletions(-) diff --g

[PATCH] accel: Add .mmap to DRM_ACCEL_FOPS

2023-01-17 Thread Jeffrey Hugo
In reviewing the ivpu driver, DEFINE_DRM_ACCEL_FOPS could have been used if DRM_ACCEL_FOPS defined .mmap to be drm_gem_mmap. Lets add that since accel drivers are a variant of drm drivers, modern drm drivers are expected to use GEM, and mmap() is a common operation that is expected to be heavily u

Re: [PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Alex Deucher
On Tue, Jan 17, 2023 at 12:45 PM Nirmoy Das wrote: > > Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() > with proper APIs. > > Cc: Alex Deucher > Cc: Christian König > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5 ++--- > 1 file changed, 2 ins

Re: [PATCH 1/2] drm/radeon: Do not use deprecated drm log API

2023-01-17 Thread Das, Nirmoy
On 1/17/2023 6:48 PM, Alex Deucher wrote: On Tue, Jan 17, 2023 at 12:45 PM Nirmoy Das wrote: Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR() with proper APIs. Cc: Alex Deucher Cc: Christian König Signed-off-by: Nirmoy Das --- drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5

[PATCH 2/2] drm/i915: Fix a memory leak with reused mmap_offset

2023-01-17 Thread Nirmoy Das
drm_vma_node_allow() and drm_vma_node_revoke() should be called in balanced pairs. We call drm_vma_node_allow() once per-file everytime a user calls mmap_offset, but only call drm_vma_node_revoke once per-file on each mmap_offset. As the mmap_offset is reused by the client, the per-file vm_count ma

[PATCH 1/2] drm/drm_vma_manager: Add drm_vma_node_allow_once()

2023-01-17 Thread Nirmoy Das
Currently there is no easy way for a drm driver to safely check and allow drm_vma_offset_node for a drm file just once. Allow drm drivers to call non-refcounted version of drm_vma_node_allow() so that a driver doesn't need to keep track of each drm_vma_node_allow() to call subsequent drm_vma_node_r

[PATCH v2 1/2] drm/amdgpu/vcn: Adjust firmware names indentation

2023-01-17 Thread Guilherme G. Piccoli
This is an incredibly trivial fix, just for the sake of "aesthetical" organization of the defines. Some were space based, most were tab based and there was a lack of "alignment", now it's all the same and aligned. Cc: James Zhu Cc: Lazar Lijo Cc: Leo Liu Cc: Mario Limonciello Cc: Sonny Jiang

  1   2   3   >