Re: [PATCH 20/22] media: remove sh_vou

2023-01-13 Thread Laurent Pinchart
Hi Christoph, Thank you for the patch. On Fri, Jan 13, 2023 at 07:23:37AM +0100, Christoph Hellwig wrote: > Now that arch/sh is removed this driver is dead code. > > Signed-off-by: Christoph Hellwig > --- > drivers/media/platform/renesas/Kconfig |9 - > drivers/media/platform/renesas/Make

Re: [PATCH v2] drm/i915: Fix CFI violations in gt_sysfs

2023-01-13 Thread Jocelyn Falempe
On 12/01/2023 16:56, Nathan Chancellor wrote: Hi Jocelyn, On Thu, Jan 12, 2023 at 11:08:17AM +0100, Jocelyn Falempe wrote: This patch does also solve a kernel crash when reading /sys/class/drm/card1/gt/gt0/* on a skylake machine: https://bugzilla.redhat.com/show_bug.cgi?id=2154880 Interesting

Re: [PATCH 2/6] drm/amdkfd: Implement DMA buf fd export from KFD

2023-01-13 Thread Chen, Xiaogang
Reviewed-by: Xiaogang Chen Regards Xiaogang On 1/11/2023 7:31 PM, Felix Kuehling wrote: Exports a DMA buf fd of a given KFD buffer handle. This is intended for being able to import KFD BOs into GEM contexts to leverage the amdgpu_bo_va API for more flexible virtual address mappings. It will

Re: [PATCH 3/6] drm/amdkfd: Improve amdgpu_vm_handle_moved

2023-01-13 Thread Chen, Xiaogang
Acked-by: Xiaogang Chen Regards Xiaogang On 1/11/2023 7:31 PM, Felix Kuehling wrote: Let amdgpu_vm_handle_moved update all BO VA mappings of BOs reserved by the caller. This will be useful for handling extra BO VA mappings in KFD VMs that are managed through the render node API. Signed-off-by

Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-13 Thread Pin-yen Lin
Hi Rob, On Fri, Jan 13, 2023 at 6:44 AM Rob Herring wrote: > > On Wed, Jan 11, 2023 at 10:21 PM Pin-yen Lin wrote: > > > > > > This series introduces bindings for anx7625/it6505 to register Type-C > > mode-switch in their output endpoints, and use data-lanes property to > > describe the pin conn

Re: [PATCH 4/6] drm/amdgpu: Attach eviction fence on alloc

2023-01-13 Thread Chen, Xiaogang
Reviewed-by: Xiaogang Chen Regards Xiaogang On 1/11/2023 7:31 PM, Felix Kuehling wrote: Instead of attaching the eviction fence when a KFD BO is first mapped, attach it when it is allocated or imported. This in preparation to allow KFD BOs to be mapped using the render node API. Signed-off-b

Re: [PATCH 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-01-13 Thread Jani Nikula
On Fri, 13 Jan 2023, Arun R Murthy wrote: > Enable SDP error detection configuration, this will set CRC16 in > 128b/132b link layer. > For DISPLAY13 a hardware bit31 in register VIDEO_DIP_CTL is added to > enable/disable SDP CRC applicable for DP2.0 only, but the default value > of this bit will e

Re: [PATCH 01/22] gpu/drm: remove the shmobile drm driver

2023-01-13 Thread Geert Uytterhoeven
On Fri, Jan 13, 2023 at 8:55 AM Laurent Pinchart wrote: > On Fri, Jan 13, 2023 at 09:46:49AM +0200, Laurent Pinchart wrote: > > On Fri, Jan 13, 2023 at 07:23:18AM +0100, Christoph Hellwig wrote: > > > This driver depends on ARM && ARCH_SHMOBILE, but ARCH_SHMOBILE can only be > > > set for each/sh,

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-13 Thread Pin-yen Lin
Hi Jani, Thanks for the review. On Thu, Jan 12, 2023 at 4:37 PM Jani Nikula wrote: > > On Thu, 12 Jan 2023, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices. > > > > The helper regist

[PATCH v2] drm/msm/dpu: add hw revision 410

2023-01-13 Thread Richard Acayan
The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1.0. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Link: https://android.googlesource.com/kernel/msm/+/368478b0ae76566927a2769a2bf24dfe7f38bb78/arc

Re: [RFC PATCH] drm/dsi-mipi: Fix byte order of DCS set/get brightness

2023-01-13 Thread Richard Acayan
On Thu, Jan 12, 2023 at 11:18:48PM -0500, Richard Acayan wrote: > From: Daniel Mentz > > The MIPI DCS specification demands that brightness values are sent in > big endian byte order. It also states that one parameter (i.e. one byte) > shall be sent/received for 8 bit wide values, and two paramete

[PATCH] drm/msm/dpu: add hw revision 410

2023-01-13 Thread Richard Acayan
The Snapdragon 670 uses similar clocks (with one frequency added) to the Snapdragon 845 but reports DPU revision 4.1.0. Add support for this DPU with configuration from the Pixel 3a downstream kernel. Link: https://android.googlesource.com/kernel/msm/+/368478b0ae76566927a2769a2bf24dfe7f38bb78/arc

Re: [PATCH] drm/msm/dpu: add hw revision 410

2023-01-13 Thread Richard Acayan
On Thu, Jan 12, 2023 at 08:54:20PM -0500, Richard Acayan wrote: > The Snapdragon 670 uses similar clocks (with one frequency added) to the > Snapdragon 845 but reports DPU revision 4.1.0. Add support for this DPU > with configuration from the Pixel 3a downstream kernel. > > Link: > https://android

[PATCH] amdgpu: Avoid building on UML

2023-01-13 Thread Peter Foley
The amdgpu driver tries to use fields not supported by UML's cpuinfo struct. Disable the driver when targeting UML to avoid tripping up allyesconfig. e.g. ../drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c: In function ‘intel_core_rkl_chk’: ../drivers/gpu/drm/amd/amdgpu/../pm/powerp

Re: remove arch/sh

2023-01-13 Thread John Paul Adrian Glaubitz
Hello! On 1/13/23 07:23, Christoph Hellwig wrote: arch/sh has been a long drag because it supports a lot of SOCs, and most of them haven't even been converted to device tree infrastructure. These SOCs are generally obsolete as well, and all of the support has been barely maintained for almost 1

[RFC PATCH] drm/dsi-mipi: Fix byte order of DCS set/get brightness

2023-01-13 Thread Richard Acayan
From: Daniel Mentz The MIPI DCS specification demands that brightness values are sent in big endian byte order. It also states that one parameter (i.e. one byte) shall be sent/received for 8 bit wide values, and two parameters shall be used for values that are between 9 and 16 bits wide. Fixes:

Re: [PATCH v5 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:34, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> VPU stands for Versatile Processing Unit and it's a CPU-integrated >> inference accelerator for Computer Vision and Deep Learning >> applications. >> >> The VPU device consist of following components: >

Re: remove arch/sh

2023-01-13 Thread Geert Uytterhoeven
On Fri, Jan 13, 2023 at 9:10 AM John Paul Adrian Glaubitz wrote: > On 1/13/23 07:23, Christoph Hellwig wrote: > > arch/sh has been a long drag because it supports a lot of SOCs, and most > > of them haven't even been converted to device tree infrastructure. These > > SOCs are generally obsolete a

Re: [PATCH 10/22] input: remove sh_keysc

2023-01-13 Thread Geert Uytterhoeven
On Fri, Jan 13, 2023 at 7:24 AM Christoph Hellwig wrote: > Now that arch/sh is removed this driver is dead code. > > Signed-off-by: Christoph Hellwig > --- > drivers/input/keyboard/Kconfig| 10 - > drivers/input/keyboard/Makefile | 1 - > drivers/input/keyboard/sh_keysc.c | 334

Re: [PATCH 11/22] mtd/nand: remove sh_flctl

2023-01-13 Thread Geert Uytterhoeven
On Fri, Jan 13, 2023 at 7:24 AM Christoph Hellwig wrote: > Now that arch/sh is removed this driver is dead code. > > Signed-off-by: Christoph Hellwig > --- > drivers/mtd/nand/raw/Kconfig|8 - > drivers/mtd/nand/raw/Makefile |1 - > drivers/mtd/nand/raw/sh_flctl.c | 1234 ---

Re: [PATCH v5 3/7] accel/ivpu: Add GEM buffer object management

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:52, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> Adds four types of GEM-based BOs for the VPU: >>    - shmem >>    - userptr >>    - internal >>    - prime >> >> All types are implemented as struct ivpu_bo, based on >> struct drm_gem_object. VPU addre

Re: [PATCH v5 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-13 Thread Dmitry Baryshkov
On 12/01/2023 23:50, Rob Herring wrote: On Wed, Jan 11, 2023 at 11:35:53PM +0100, Marijn Suijten wrote: On 2023-01-12 00:31:33, Dmitry Baryshkov wrote: On 12/01/2023 00:29, Marijn Suijten wrote: On 2023-01-10 06:40:27, Dmitry Baryshkov wrote: On 09/01/2023 09:49, Marijn Suijten wrote: On 202

[PATCH v6 02/11] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml

2023-01-13 Thread Dmitry Baryshkov
Add platform-specific compatible entries to the qcom,mdp5.yaml to allow distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/qcom,mdp5.yaml | 17 - .../bindings/display/msm/qcom,mdss.yaml | 6 +- 2 files chang

[PATCH v6 00/11] dt-bindings: display/msm: rework MDP5 and MDSS schema

2023-01-13 Thread Dmitry Baryshkov
Krzysztof asked me to merge all pending MDSS/MDP5/DPU patches to a single series to ease review and to let one to see the whole picture. This combines three series: MDP5 schema conversion, mdss/mdp renaming and addition of the "core" clock to the MDSS device node. Changes since v5: - Merged in th

[PATCH v6 05/11] dt-bindings: display/msm: rename mdp nodes to display-controller

2023-01-13 Thread Dmitry Baryshkov
Follow the 'generic names' rule and rename mdp nodes to display-controller. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/dpu-common.yaml | 8 .../devicetree/bindings/display/msm/qcom,mdp5.yaml| 3 +++ .../devicetree/bindings/display/msm/qcom,mdss

[PATCH v6 03/11] dt-bindings: display/msm: add core clock to the mdss bindings

2023-01-13 Thread Dmitry Baryshkov
Add (optional) core clock to the mdss bindings to let the MDSS driver access harware registers before MDP driver probes. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/qcom,mdss.yaml | 34 ++- 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/Docu

[PATCH v6 07/11] arm64: dts: qcom: add SoC specific compat strings to mdp5 nodes

2023-01-13 Thread Dmitry Baryshkov
Add SoC-specific compat string to the MDP5 device nodes to ease distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +- arch/arm64/boot/

[PATCH v6 06/11] ARM: dts: qcom-msm8974: add SoC specific compat string to mdp5 node

2023-01-13 Thread Dmitry Baryshkov
Add SoC-specific compat string to the MDP5 device node to ease distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boo

[PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-13 Thread Dmitry Baryshkov
Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema: - MSM8996 has additional "iommu" clock, define it separately - Add new properties used on some of platforms: - interconnects, interconnect-names - iommus - power-domains - operating-points-v2, opp-table

[PATCH v6 04/11] dt-bindings: display/msm: rename mdss nodes to display-subsystem

2023-01-13 Thread Dmitry Baryshkov
Follow the 'generic names' rule and rename mdss nodes to display-subsystem. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/mdss-common.yaml | 8 .../devicetree/bindings/display/msm/qcom,mdss.yaml| 5 - 2 files changed, 12 insertions(+), 1 deleti

[PATCH v6 08/11] arm64: dts: qcom: rename mdss nodes to display-subsystem

2023-01-13 Thread Dmitry Baryshkov
Follow the schema change and rename mdss nodes to generic name 'display-subsystem'. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sc7180.dtsi

[PATCH v6 10/11] arm64: dts: qcom: rename mdp nodes to display-controller

2023-01-13 Thread Dmitry Baryshkov
Follow the schema change and rename mdp nodes to generic name 'display-controller'. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm630.dtsi

[PATCH v6 09/11] ARM: dts: qcom-msm8974: rename mdss node to display-subsystem

2023-01-13 Thread Dmitry Baryshkov
Follow the schema change and rename mdss node to generic name 'display-subsystem'. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dts

[PATCH v6 11/11] ARM: dts: qcom: rename mdp nodes to display-controller

2023-01-13 Thread Dmitry Baryshkov
Follow the schema change and rename mdp nodes to generic name 'display-controller'. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-apq8064.dtsi | 2 +- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/qcom-ap

Re: [PATCH v5 4/7] accel/ivpu: Add IPC driver and JSM messages

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 19:18, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> The IPC driver is used to send and receive messages to/from firmware >> running on the VPU. >> >> The only supported IPC message format is Job Submission Model (JSM) >> defined in vpu_jsm_api.h header.

Re: [PATCH 13/22] pinctrl: remove renesas sh controllers

2023-01-13 Thread Geert Uytterhoeven
Hi Christoph, On Fri, 13 Jan 2023, Christoph Hellwig wrote: Now that arch/sh is removed these drivers are dead code. Signed-off-by: Christoph Hellwig Thanks for your patch! --- a/drivers/pinctrl/renesas/Kconfig +++ b/drivers/pinctrl/renesas/Kconfig @@ -255,57 +243,10 @@ config PINC

Re: [PATCH 16/22] spi: remove spi-sh-sci

2023-01-13 Thread Geert Uytterhoeven
On Fri, Jan 13, 2023 at 7:24 AM Christoph Hellwig wrote: > Now that arch/sh is removed this driver is dead code. > > Signed-off-by: Christoph Hellwig > --- > drivers/spi/Kconfig | 7 -- > drivers/spi/Makefile | 1 - > drivers/spi/spi-sh-sci.c | 197 --

Re: [PATCH 19/22] fbdev: remove sh7760fb

2023-01-13 Thread Geert Uytterhoeven
Hi Christoph, On Fri, Jan 13, 2023 at 7:25 AM Christoph Hellwig wrote: > Now that arch/sh is removed this driver is dead code. > > Signed-off-by: Christoph Hellwig Thanks for your patch! > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -1861,7 +1861,7 @@ config FB_W

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-13 Thread Dmitry Baryshkov
On 13/01/2023 06:23, Dmitry Baryshkov wrote: On 13/01/2023 06:10, Bjorn Andersson wrote: Invoking drm_bridge_hpd_notify() on a drm_bridge with a HPD-enabled bridge_connector ends up in drm_bridge_connector_hpd_cb() calling drm_kms_helper_hotplug_event(), which assumes that the associated drm_dev

Re: [PATCH 02/22] usb: remove the dead USB_OHCI_SH option

2023-01-13 Thread Geert Uytterhoeven
Hi Christoph, On Fri, Jan 13, 2023 at 7:23 AM Christoph Hellwig wrote: > USB_OHCI_SH is a dummy option that never builds any code, remove it. > > Signed-off-by: Christoph Hellwig Thanks for your patch! Nice catch! > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -548,17 +

Re: [PATCH 20/22] media: remove sh_vou

2023-01-13 Thread Hans Verkuil
On 13/01/2023 09:01, Laurent Pinchart wrote: > Hi Christoph, > > Thank you for the patch. > > On Fri, Jan 13, 2023 at 07:23:37AM +0100, Christoph Hellwig wrote: >> Now that arch/sh is removed this driver is dead code. >> >> Signed-off-by: Christoph Hellwig >> --- >> drivers/media/platform/renes

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Allow error capture of a pending request

2023-01-13 Thread Tvrtko Ursulin
On 12/01/2023 20:46, John Harrison wrote: On 1/12/2023 02:06, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the b

[Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU)

2023-01-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216917 --- Comment #11 from The Linux kernel's regression tracker (Thorsten Leemhuis) (regressi...@leemhuis.info) --- Just for the record, if someone cares or lands here some time in the future: There is another report about hibernation problems with r

Re: [Intel-gfx] [PATCH 3/4] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-13 Thread Tvrtko Ursulin
On 12/01/2023 20:59, John Harrison wrote: On 1/12/2023 02:15, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing

Re: [PATCH v10 3/9] drm/display: Add Type-C switch helpers

2023-01-13 Thread Heikki Krogerus
Hi, On Thu, Jan 12, 2023 at 12:20:58PM +0800, Pin-yen Lin wrote: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "data-lane

Re: [PATCH] drm/nouveau: Remove support for legacy contexts/buffers

2023-01-13 Thread Thomas Zimmermann
Am 13.01.23 um 01:07 schrieb Karol Herbst: On Thu, Jan 12, 2023 at 2:39 PM Thomas Zimmermann wrote: Remove nouveau's support for legacy contexts and buffers. It was required by libdrm earlier than 2.4.33, released in March 2012. A previous attempt in 2013 to remove the functionality [1] had

Re: [RESEND PATCH linux-next v2 00/10] drm: Remove some obsolete drivers(tdfx, mga, i810, savage, r128, sis, via)

2023-01-13 Thread Thomas Zimmermann
Merged into drm-misc-next. Thanks a lot. Am 03.12.22 um 11:22 schrieb Cai Huoqing: Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy (UMS) DRM drivers") marked these drivers obsolete 7 years ago. And the mesa UMD of these drm drivers already in deprecated list in the link: https://docs.me

Re: [PATCH v5 0/7] New DRM accel driver for Intel VPU

2023-01-13 Thread Jacek Lawrynowicz
Hi, On 12.01.2023 18:10, Jeffrey Hugo wrote: > On 1/9/2023 5:23 AM, Jacek Lawrynowicz wrote: >> Hi, >> >> This patchset contains a new Linux* Kernel Driver for Intel® VPUs. >> >> VPU stands for Versatile Processing Unit and it is an AI inference >> accelerator >> integrated with Intel non-server

Re: [PATCH 1/2] drm/ttm: Check ttm_debugfs_root before creating files under it

2023-01-13 Thread Christian König
Am 13.01.23 um 06:34 schrieb Ma Jun: Check the ttm_debugfs_root before creating files under it. If the ttm_debugfs_root is NULL, all the files created for ttm/ will be placed in the /sys/kerne/debug/ but not /sys/kernel/debug/ttm/ Well NAK for upstreaming. Why should ttm_debugfs_root be NULL he

Re: [PATCH 2/2] drm/ttm: Use debugfs_remove_recursive to remove ttm directory

2023-01-13 Thread Christian König
Am 13.01.23 um 06:34 schrieb Ma Jun: Use debugfs_remove_recursive to remove the /sys/kernel/debug/ttm directory for better compatibility. Becuase debugfs_remove fails on older kernel. Again NAK for upstreaming. The upstream kernel is made for the newest kernel version and should not contain a

Re: [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-13 Thread Jani Nikula
On Fri, 13 Jan 2023, Dmitry Baryshkov wrote: > On Fri, 13 Jan 2023 at 09:12, Laurentiu Palcu > wrote: >> >> Hi Dmitry, >> >> On Thu, Jan 12, 2023 at 05:42:47PM +0200, Dmitry Baryshkov wrote: >> > There are two flags attemting to guard connector polling: >> > poll_enabled and poll_running. While p

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Allow error capture without a request

2023-01-13 Thread Tvrtko Ursulin
On 12/01/2023 20:40, John Harrison wrote: On 1/12/2023 02:01, Tvrtko Ursulin wrote: On 12/01/2023 02:53, john.c.harri...@intel.com wrote: From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hun

Re: remove arch/sh

2023-01-13 Thread John Paul Adrian Glaubitz
Hi Geert! On 1/13/23 09:26, Geert Uytterhoeven wrote: Indeed. The main issue is not the lack of people sending patches and fixes, but those patches never being applied by the maintainers. Perhaps someone is willing to stand up to take over maintainership? I actually would be willing to do it

[PATCH] drm/vmwgfx: Fix uninitialized return variables

2023-01-13 Thread Dan Carpenter
This code accidentally returns the wrong variable (which is uninitialized). It should return ret. Fixes: a309c7194e8a ("drm/vmwgfx: Remove rcu locks from user resources") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2

Re: [PATCH 11/22] mtd/nand: remove sh_flctl

2023-01-13 Thread Arnd Bergmann
On Fri, Jan 13, 2023, at 09:30, Geert Uytterhoeven wrote: > On Fri, Jan 13, 2023 at 7:24 AM Christoph Hellwig wrote: >> Now that arch/sh is removed this driver is dead code. > > FTR, this hardware block is also present on the ARM-based > SH-Mobile AG5 and R-Mobile A1 SoCs. > Again, no DT support.

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-13 Thread Jani Nikula
Cc: intel-gfx, drm maintainers Please have the courtesy of Cc'ing us for changes impacting us, and maybe try to involve us earlier instead of surprising us like this. Looks like this has been debugged for at least three months, and the huge revert at this point is going to set us back with what'

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-13 Thread Daniel Vetter
On Fri, Jan 13, 2023 at 12:16:57PM +0200, Jani Nikula wrote: > > Cc: intel-gfx, drm maintainers > > Please have the courtesy of Cc'ing us for changes impacting us, and > maybe try to involve us earlier instead of surprising us like > this. Looks like this has been debugged for at least three mont

Re: [PATCH 0/5] drm: Do not include unnecessarily

2023-01-13 Thread Maxime Ripard
On Mon, Jan 09, 2023 at 11:12:38AM +0100, Thomas Zimmermann wrote: > Remove unnecessary include statements for . I recently > changed this header and had to rebuild a good part of DRM. So avoid > this by removing the dependency. > > Some source files require the OF or backlight headers. Include th

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-13 Thread Juha-Pekka Heikkila
On 12.1.2023 20.28, Ville Syrjälä wrote: On Mon, Dec 26, 2022 at 10:53:24PM -0700, Drew Davenport wrote: The error message suggests that the height of the src rect must be at least 1. Reject source with height of 0. Signed-off-by: Drew Davenport --- I was investigating some divide-by-zero cra

[PATCH v2 0/3] Check for valid framebuffer's format

2023-01-13 Thread Maíra Canal
This series is a follow-up of the [1] in which I introduced a check for valid formats on drm_gem_fb_create(). During the discussion, I realized that would be a better idea to put the check inside framebuffer_check() so that it wouldn't be needed to hit any driver-specific code path when the check f

[PATCH v2 1/3] drm/framebuffer: Check for valid formats

2023-01-13 Thread Maíra Canal
Currently, framebuffer_check() doesn't check if the pixel format is supported, which can lead to the acceptance of invalid pixel formats e.g. the acceptance of invalid modifiers. Therefore, add a check for valid formats on framebuffer_check(), so that the ADDFB2 IOCTL rejects calls with invalid for

[PATCH v2 2/3] drm/amdgpu: Remove redundant framebuffer format check

2023-01-13 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on amdgpu's inside helpers. Therefore, remove the redundant framebuffer format check from the amdgpu_display_gem_fb_verify_and_init() function, letting framebuffer_check() perform the fr

[PATCH v2 3/3] drm/vmwgfx: Remove redundant framebuffer format check

2023-01-13 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on vmwgfx's inside helpers. Therefore, remove the redundant framebuffer format check from the vmw_kms_new_framebuffer_surface() and vmw_kms_new_framebuffer_bo() functions, letting frameb

[PATCH] ACPI: video: Add backlight=native DMI quirk for Acer Aspire 4810T

2023-01-13 Thread Hans de Goede
The Acer Aspire 4810T predates Windows 8, so it defaults to using acpi_video# for backlight control, but this is non functional on this model. Add a DMI quirk to use the native backlight interface which does work properly. Signed-off-by: Hans de Goede --- drivers/acpi/video_detect.c | 8 +++

[PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Nirmoy Das
From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. Signed-off-by: Chris Wilson Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/g

Re: [PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Matthew Auld
On 13/01/2023 11:49, Nirmoy Das wrote: From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. Signed-off-by: Chris Wilson Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld

[PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Nirmoy Das
From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. Fixes: 027c38b4121e ("drm/i915/selftests: Grab the runtime pm in shrink_thp") Reviewed-by: Matthew Auld Signed-off-by: Chris Wilson Signed-off-by: Nirmoy Das Cc: # v6.0+ --- drivers/gpu/d

Re: [PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Das, Nirmoy
Thanks Matt, I missed the Fixes tag so resent it with fixes and Cc to stable. On 1/13/2023 12:51 PM, Matthew Auld wrote: On 13/01/2023 11:49, Nirmoy Das wrote: From: Chris Wilson Make sure that upon error after we have acquired the wakeref we do release it again. Signed-off-by: Chris Wilson

Re: [PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Matthew Auld
On 13/01/2023 12:02, Das, Nirmoy wrote: Thanks Matt, I missed the Fixes tag so resent it with fixes and Cc to stable. I don't think kernel selftests are really stable material. AFAIK it's not something normal users care about. On 1/13/2023 12:51 PM, Matthew Auld wrote: On 13/01/2023 11:49

Re: [PATCH] drm/i915/selftests: Unwind hugepages to drop wakeref on error

2023-01-13 Thread Das, Nirmoy
On 1/13/2023 1:05 PM, Matthew Auld wrote: On 13/01/2023 12:02, Das, Nirmoy wrote: Thanks Matt, I missed the Fixes tag so resent it with fixes and Cc to stable. I don't think kernel selftests are really stable material. AFAIK it's not something normal users care about. True, in that case

Re: [PATCH 0/5] drm: Do not include unnecessarily

2023-01-13 Thread Thomas Zimmermann
Am 13.01.23 um 11:36 schrieb Maxime Ripard: On Mon, Jan 09, 2023 at 11:12:38AM +0100, Thomas Zimmermann wrote: Remove unnecessary include statements for . I recently changed this header and had to rebuild a good part of DRM. So avoid this by removing the dependency. Some source files require

Re: [PATCH v2 1/3] drm/framebuffer: Check for valid formats

2023-01-13 Thread Ville Syrjälä
On Fri, Jan 13, 2023 at 08:27:42AM -0300, Maíra Canal wrote: > Currently, framebuffer_check() doesn't check if the pixel format is > supported, which can lead to the acceptance of invalid pixel formats > e.g. the acceptance of invalid modifiers. Therefore, add a check for > valid formats on framebu

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-13 Thread Linux kernel regression tracking (Thorsten Leemhuis)
[CCing Daniel] On 05.01.23 13:28, Thorsten Leemhuis wrote: > [adding Karol and Lyude to the list of recipients] > > On 28.12.22 15:49, Diogo Ivo wrote: >> Hello, >> >> Commit 2541626cfb79 breaks GM20B probe with >> the following kernel log: > Just wondering: is anyone looking on this? The report

Re: [git pull] drm fixes for 6.2-rc4

2023-01-13 Thread pr-tracker-bot
The pull request you sent on Fri, 13 Jan 2023 15:15:17 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-01-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ff5ebafd51ecc01014f1db510299eede60faf22a Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH 06/22] watchdog: remove the shwdt driver

2023-01-13 Thread Guenter Roeck
On 1/12/23 22:23, Christoph Hellwig wrote: Now that arch/sh is removed this driver is dead code. Signed-off-by: Christoph Hellwig Acked-by: Guenter Roeck --- .../watchdog/watchdog-parameters.rst | 12 - drivers/watchdog/Kconfig | 20 - drivers/watchdog/M

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Connect root sysfs entries to GT0

2023-01-13 Thread Tvrtko Ursulin
On 13/01/2023 03:15, Dixit, Ashutosh wrote: On Thu, 12 Jan 2023 18:27:52 -0800, Vinay Belgaumkar wrote: Reading current root sysfs entries gives a min/max of all GTs. Updating this so we return default (GT0) values when root level sysfs entries are accessed, instead of min/max for the card. T

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-13 Thread Sam Ravnborg
Hi Stephen, On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote: > Quoting Sam Ravnborg (2023-01-07 12:28:41) > > > > > For this case we could ask ourself if the display needs to enter sleep > > mode right before we disable the regulator. But if the regulator is > > fixed, so the disable

Re: [PATCH v7, 5/7] media: mediatek: vcodec: Different codec using different capture format

2023-01-13 Thread Nícolas F . R . A . Prado
On Fri, Jan 13, 2023 at 03:25:46AM +, Yunfei Dong (董云飞) wrote: > Hi Nicolas, > > Thanks for your information. > On Thu, 2023-01-12 at 15:58 -0500, Nícolas F. R. A. Prado wrote: > > On Wed, May 18, 2022 at 08:30:02PM +0800, Yunfei Dong wrote: > > > Vp8 need to use MM21, but vp9 and h264 need to

Re: [PATCH v2 01/10] drm: Include where needed

2023-01-13 Thread Sam Ravnborg
Hi Thomas, On Wed, Jan 11, 2023 at 02:01:57PM +0100, Thomas Zimmermann wrote: > Include in source files that need it. Some of > DRM's source code gets the backlight header via drm_crtc_helper.h > and , which can leed to unnecessary recompilation. If > possible, do not include drm_crtc_helper.h any

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-13 Thread Sam Ravnborg
Hi Ville, On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > Include in source files that need it. Some of DRM's > > source code gets OF header via drm_crtc_helper.h and , > > which can leed to unnecessary recompi

Re: [PATCH v2 05/10] drm/panel: Do not include

2023-01-13 Thread Sam Ravnborg
On Wed, Jan 11, 2023 at 02:02:01PM +0100, Thomas Zimmermann wrote: > Remove unnecessary include statements for . No functional > changes. Include where the driver got the header file via > . > > Signed-off-by: Thomas Zimmermann Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-ilit

Re: [PATCH v2 00/10] drm: Do not include unnecessarily

2023-01-13 Thread Sam Ravnborg
Hi Thomas. On Wed, Jan 11, 2023 at 02:01:56PM +0100, Thomas Zimmermann wrote: > Remove unnecessary include statements for . I recently > changed this header and had to rebuild a good part of DRM. So avoid > this by removing the dependency. > > Several files include via drm_fb_helper.h. So in v2 I

Re: [PATCH] drm/panel: st7703: Avoid full proxy f_ops for st7703 debug attributes

2023-01-13 Thread Sam Ravnborg
On Wed, Jan 11, 2023 at 01:53:34AM +0530, Deepak R Varma wrote: > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > function adds the overhead of introducing a proxy file operation > functions to wrap the original read/write inside file removal protection > functions. This adds s

Re: remove arch/sh

2023-01-13 Thread Rob Herring
On Fri, Jan 13, 2023 at 07:23:17AM +0100, Christoph Hellwig wrote: > Hi all, > > arch/sh has been a long drag because it supports a lot of SOCs, and most > of them haven't even been converted to device tree infrastructure. These > SOCs are generally obsolete as well, and all of the support has be

Re: [PATCH 2/2] drm/vc4: replace obj lookup steps with drm_gem_objects_lookup

2023-01-13 Thread André Almeida
Hi Maíra, Thank you for your patch, it really simplifies the code. I think it's OK as it is, so I'll give my     Reviewed-by: André Almeida for this series. But I would also like to notice that VC4 had some extra DRM_ log functions that the DRM version hasn't, so I think they would be a goo

Re: [PATCH v6 04/11] dt-bindings: display/msm: rename mdss nodes to display-subsystem

2023-01-13 Thread Rob Herring
On Fri, 13 Jan 2023 10:37:13 +0200, Dmitry Baryshkov wrote: > Follow the 'generic names' rule and rename mdss nodes to > display-subsystem. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/mdss-common.yaml | 8 > .../devicetree/bindings/display/msm/

Re: [PATCH v6 01/11] dt-bindings: display/msm: convert MDP5 schema to YAML format

2023-01-13 Thread Rob Herring
On Fri, 13 Jan 2023 10:37:10 +0200, Dmitry Baryshkov wrote: > Convert the mdp5.txt into the yaml format. Changes to the existing (txt) > schema: > - MSM8996 has additional "iommu" clock, define it separately > - Add new properties used on some of platforms: >- interconnects, interconnect-n

Re: [PATCH v2 01/10] drm: Include where needed

2023-01-13 Thread Thomas Zimmermann
Hi Am 13.01.23 um 16:09 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 11, 2023 at 02:01:57PM +0100, Thomas Zimmermann wrote: Include in source files that need it. Some of DRM's source code gets the backlight header via drm_crtc_helper.h and , which can leed to unnecessary recompilation. If poss

[PATCH] drm/vc4: bo: Fix unused variable warning

2023-01-13 Thread Maxime Ripard
Commit 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog") removed the only user of the ret variable, but didn't remove the variable itself leading to a unused variable warning. Remove that variable. Reported-by: Stephen Rothwell Fixes: 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init me

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-13 Thread Ville Syrjälä
On Fri, Jan 13, 2023 at 04:11:48PM +0100, Sam Ravnborg wrote: > Hi Ville, > On Wed, Jan 11, 2023 at 06:08:42PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > > > Include in source files that need it. Some of DRM's > > > source code gets OF head

Re: [PATCH] drm/vc4: bo: Fix unused variable warning

2023-01-13 Thread Maíra Canal
On 1/13/23 12:46, Maxime Ripard wrote: Commit 07a2975c65f2 ("drm/vc4: bo: Fix drmm_mutex_init memory hog") removed the only user of the ret variable, but didn't remove the s/user/use variable itself leading to a unused variable warning. Remove that variable. Reported-by: Stephen Rothwell F

Re: [PATCH 04/22] sound: remove sound/sh

2023-01-13 Thread Takashi Iwai
On Fri, 13 Jan 2023 07:23:21 +0100, Christoph Hellwig wrote: > > Now that arch/sh is removed these drivers are dead code. > > Signed-off-by: Christoph Hellwig Supposed you take in your tree: Acked-by: Takashi Iwai thanks, Takashi > --- > sound/Kconfig | 2 - > sound/Makefile

Re: [PATCH] backlight: ili922x: fix kernel-doc warnings

2023-01-13 Thread Daniel Thompson
On Thu, Jan 12, 2023 at 10:41:08PM -0800, Randy Dunlap wrote: > Convert comments for START_BYTE() and CHECK_FREQ_REG() macros into > kernel-doc notation to avoid these kernel-doc warnings: > > drivers/video/backlight/ili922x.c:85: warning: This comment starts with > '/**', but isn't a kernel-doc c

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-13 Thread Harry Wentland
On 1/13/23 05:25, Daniel Vetter wrote: > On Fri, Jan 13, 2023 at 12:16:57PM +0200, Jani Nikula wrote: >> >> Cc: intel-gfx, drm maintainers >> >> Please have the courtesy of Cc'ing us for changes impacting us, and >> maybe try to involve us earlier instead of surprising us like >> this. Looks lik

Re: [PATCH] backlight: sky81452: fix sky81452_bl_platform_data kernel-doc

2023-01-13 Thread Daniel Thompson
On Thu, Jan 12, 2023 at 10:41:18PM -0800, Randy Dunlap wrote: > Correct the struct name and add a short struct description to fix the > kernel-doc notation. > > Prevents this kernel-doc warning: > drivers/video/backlight/sky81452-backlight.c:64: warning: expecting prototype > for struct sky81452_p

[PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-01-13 Thread Harry Wentland
This patchset enables the DP and HDMI infoframe properties in amdgpu. The first two patches are not completely related to the rest. The first patch allows for HDR_OUTPUT_METADATA with EOTFs that are unknown in the kernel. The second one prints a connector's max_bpc as part of the atomic state deb

[PATCH v2 01/21] drm/display: Don't block HDR_OUTPUT_METADATA on unknown EOTF

2023-01-13 Thread Harry Wentland
The EDID of an HDR display defines EOTFs that are supported by the display and can be set in the HDR metadata infoframe. Userspace is expected to read the EDID and set an appropriate HDR_OUTPUT_METADATA. In drm_parse_hdr_metadata_block the kernel reads the supported EOTFs from the EDID and stores

[PATCH v2 02/21] drm/connector: print max_requested_bpc in state debugfs

2023-01-13 Thread Harry Wentland
This is useful to understand the bpc defaults and support of a driver. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: Jani Nikula Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.fre

[PATCH v2 10/21] drm/amd/display: Signal mode_changed if colorspace changed

2023-01-13 Thread Harry Wentland
We need to signal mode_changed to make sure we update the output colorspace. v2: No need to call drm_hdmi_avi_infoframe_colorimetry as DC does its own infoframe packing. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Vill

[PATCH v2 13/21] drm/amd/display: Add support for explicit BT601_YCC

2023-01-13 Thread Harry Wentland
We use this by default but if userspace passes this explicitly we should respect it. Signed-off-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-By: Joshua Ashton

  1   2   >