Re: [PATCH 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-01-11 Thread Thomas Zimmermann
Hi Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson Copy Intel's "Broadcast RGB" property semantics to add manual override of the HDMI pixel range for monitors that don't abide by the content of the AVI Infoframe. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --

Re: [PATCH 4/9] drm/vc4: hdmi: Rename full range helper

2023-01-11 Thread Thomas Zimmermann
Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson The VC4 HDMI driver has a helper function to figure out whether full range or limited range RGB is being used called vc4_hdmi_is_full_range_rgb(). We'll need it to support other colorspaces, so let's rename it to vc4_hdmi_is_fu

Re: [PATCH 2/9] drm/vc4: hdmi: Constify container_of wrappers

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Thomas Zimmermann wrote: > Hi > > Am 07.12.22 um 17:07 schrieb Maxime Ripard: >> None of our wrappers around container_of to access our objects from the >> DRM object pointer actually modify the latter. >> >> Let's make them const. >> >> Signed-off-by: Maxime Ripard > > Per

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-11 Thread Maíra Canal
On 1/11/23 10:28, Ville Syrjälä wrote: On Mon, Jan 02, 2023 at 03:20:06PM +0100, Thomas Zimmermann wrote: Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@kms_addfb_basic@addfb25-bad-mo

Re: [Intel-gfx] [PATCH 2/2] drm/ttm: replace busy placement with flags

2023-01-11 Thread Christian König
Am 11.01.23 um 14:03 schrieb Matthew Auld: On Wed, 11 Jan 2023 at 11:43, Christian König wrote: Instead of a list of separate busy placement add flags which indicate that a placement should only be used when there is room or if we need to evict. Signed-off-by: Christian König --- drivers/gp

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-11 Thread Mark Brown
drm_bridge.c:1257 > drm_bridge_hpd_enable+0x8c/0x94 [drm] > full log at: > > https://storage.kernelci.org/next/master/next-20230111/arm64/defconfig/gcc-10/lab-broonie/baseline-meson-gxl-s905x-libretech-cc.txt > and links to other logs at: > > https://linux.kernelci.org/t

Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-11 Thread Deepak R Varma
On Wed, Jan 11, 2023 at 05:02:02AM -0500, Rodrigo Vivi wrote: > On Tue, Jan 10, 2023 at 01:49:57PM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > function adds the overhead

Re: [PATCH v2 01/16] of: device: make of_device_uevent_modalias() take a const device *

2023-01-11 Thread Rob Herring
On Wed, Jan 11, 2023 at 5:30 AM Greg Kroah-Hartman wrote: > > of_device_uevent_modalias() does not modify the device pointer passed to > it, so mark it constant. In order to properly do this, a number of > busses need to have a modalias function added as they were attempting to > just point to of

Re: [PATCH] dt-bindings: msm/dsi: Don't require vcca-supply on 14nm PHY

2023-01-11 Thread Rob Herring
On Wed, Nov 30, 2022 at 7:58 AM Konrad Dybcio wrote: > > On some SoCs (hello SM6115) vcca-supply is not wired to any smd-rpm > or rpmh regulator, but instead powered by the VDD_MX line, which is > voted for in the DSI ctrl node. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/b

Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 08:23:49PM +0530, Deepak R Varma wrote: > On Wed, Jan 11, 2023 at 05:02:02AM -0500, Rodrigo Vivi wrote: > > On Tue, Jan 10, 2023 at 01:49:57PM -0500, Rodrigo Vivi wrote: > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > > Using DEFINE_SIMPLE_ATTRIBU

Re: [PATCH 5/9] drm/vc4: hdmi: Rework the CSC matrices organization

2023-01-11 Thread Thomas Zimmermann
Hi Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson The CSC matrices were stored as separate matrix for each colorspace, and if we wanted a limited or full RGB output. This created some gaps in our support and we would not always pick the relevant matrix. Let's rework our dat

Re: [PATCH v2 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-11 Thread Deepak R Varma
On Tue, Jan 10, 2023 at 01:52:05PM -0500, Rodrigo Vivi wrote: > On Tue, Jan 10, 2023 at 11:45:40PM +0530, Deepak R Varma wrote: > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > function adds the overhead of introducing a proxy file operation > > functions to wrap the origi

Re: [PATCH 1/2] drm/atomic: Allow vblank-enabled + self-refresh "disable"

2023-01-11 Thread Ville Syrjälä
On Fri, Jan 06, 2023 at 09:30:56PM +0100, Daniel Vetter wrote: > On Fri, Jan 06, 2023 at 11:33:06AM -0800, Brian Norris wrote: > > On Fri, Jan 06, 2023 at 07:17:53PM +0100, Daniel Vetter wrote: > > > - fake vblanks with hrtimer, because on most hw when you turn off the crtc > > > the vblanks are

Re: [PATCH 6/9] drm/vc4: hdmi: Swap CSC matrix channels for YUV444

2023-01-11 Thread Thomas Zimmermann
Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson YUV444 requires the matrix coefficients to be programmed in a different way than the other formats. Let's add a function to program it properly. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard Reviewed-by: Thomas

Re: [RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2023-01-11 Thread Dmitry Baryshkov
On 11/01/2023 10:44, Marijn Suijten wrote: On 2023-01-09 12:32:18, Abhinav Kumar wrote: On 12/7/2022 4:08 PM, Dmitry Baryshkov wrote: +struct msm_mdss_data { +    u32 ubwc_version; +    u32 ubwc_swizzle; +    u32 ubwc_static; +    u32 highest_bank_bit; +    u32 macrotile_mode; +}; This mag

Re: [PATCH 7/9] drm/vc4: hdmi: Add a function to retrieve the CSC matrix

2023-01-11 Thread Thomas Zimmermann
Hi Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson The CSC matrix to use depends on the output format, its range and the colorspace. Since we're going to add more colorspaces, let's move the CSC matrix retrieval to a function. Signed-off-by: Dave Stevenson Signed-off-by: Ma

Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-11 Thread Deepak R Varma
On Wed, Jan 11, 2023 at 10:00:11AM -0500, Rodrigo Vivi wrote: > > > Actually, could you please address the checkpatch issues before we can > > > push? > > > Sorry about that, but just noticed now when I was going to push the other > > > ones. > > > > Hello Rodrigo, > > The checkpatch warning is

Re: [PATCH 8/9] drm/vc4: hdmi: Add BT.601 Support

2023-01-11 Thread Thomas Zimmermann
Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson Even though we report that we support the BT601 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT601 ones. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard Reviewed-by: Thomas Zimme

Re: [PATCH 9/9] drm/vc4: hdmi: Add BT.2020 Support

2023-01-11 Thread Thomas Zimmermann
Am 07.12.22 um 17:07 schrieb Maxime Ripard: From: Dave Stevenson Even though we report that we support the BT.2020 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT.2020 ones. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard Reviewed-by: Thomas Z

Re: [PATCH] drm/amd/display: Fix set scaling doesn's work

2023-01-11 Thread Harry Wentland
On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote: > > > On 11/22/22 06:20, hongao wrote: >> [Why] >> Setting scaling does not correctly update CRTC state. As a result >> dc stream state's src (composition area) && dest (addressable area) >> was not calculated as expected. This causes set scaling d

Re: [Intel-gfx] [PATCH 2/2] drm/ttm: replace busy placement with flags

2023-01-11 Thread Matthew Auld
On Wed, 11 Jan 2023 at 14:43, Christian König wrote: > > Am 11.01.23 um 14:03 schrieb Matthew Auld: > > On Wed, 11 Jan 2023 at 11:43, Christian König > > wrote: > >> Instead of a list of separate busy placement add flags which indicate > >> that a placement should only be used when there is room

Re: [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 08:46:00PM +0530, Deepak R Varma wrote: > On Wed, Jan 11, 2023 at 10:00:11AM -0500, Rodrigo Vivi wrote: > > > > Actually, could you please address the checkpatch issues before we can > > > > push? > > > > Sorry about that, but just noticed now when I was going to push the

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > From: Aravind Iddamsetty > > During module load not all the punit transaction have completed > and we might end up timing out, as shown by the following > warning: > >i915 :4d:00.0: drm_WARN_ON_ONCE(timeout_base_ms > 3) > > W

Re: [PATCH v2 01/16] of: device: make of_device_uevent_modalias() take a const device *

2023-01-11 Thread Greg Kroah-Hartman
On Wed, Jan 11, 2023 at 08:54:04AM -0600, Rob Herring wrote: > On Wed, Jan 11, 2023 at 5:30 AM Greg Kroah-Hartman > wrote: > > > > of_device_uevent_modalias() does not modify the device pointer passed to > > it, so mark it constant. In order to properly do this, a number of > > busses need to hav

Re: [PATCH] drm/msm/gpu: Fix potential double-free

2023-01-11 Thread Rob Clark
On Tue, Jan 10, 2023 at 1:29 PM Rob Clark wrote: > > From: Rob Clark > > If userspace was calling the MSM_SET_PARAM ioctl on multiple threads to > set the COMM or CMDLINE param, it could trigger a race causing the > previous value to be kfree'd multiple times. Fix this by serializing on > the gp

Re: [PATCH v2 01/16] of: device: make of_device_uevent_modalias() take a const device *

2023-01-11 Thread Dmitry Baryshkov
On 11/01/2023 17:26, Greg Kroah-Hartman wrote: On Wed, Jan 11, 2023 at 08:54:04AM -0600, Rob Herring wrote: On Wed, Jan 11, 2023 at 5:30 AM Greg Kroah-Hartman wrote: of_device_uevent_modalias() does not modify the device pointer passed to it, so mark it constant. In order to properly do this

Re: [PATCH v2 12/13] drm/bridge: lt9611: stop filtering modes via the table

2023-01-11 Thread Dmitry Baryshkov
On 11/01/2023 12:57, Neil Armstrong wrote: On 08/01/2023 17:56, Dmitry Baryshkov wrote: The lt9611 bridge can support different modes, it makes no sense to list them in the table. Drop the table and check the number of interfaces using the fixed value. Signed-off-by: Dmitry Baryshkov ---   dri

[PATCH] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-11 Thread Thomas Zimmermann
Set the framebuffer info for drivers that support VGA switcheroo. Only affects the amdgpu driver, which uses VGA switcheroo and generic fbdev emulation. For other drivers, this does nothing. Amdgpu's lastclose helper called vga_switcheroo_process_delayed_switch(). But as amdgpu uses generic fbdev

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: > On Wed, 11 Jan 2023, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the following > > warning: > > Root cause? >

[PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-11 Thread Daniel Vetter
It's just open coded and matches. Note that Thomas said that his version apparently failed for some reason, but hey maybe we should try again. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.org ---

[PATCH 03/11] drm/aperture: Remove primary argument

2023-01-11 Thread Daniel Vetter
Only really pci devices have a business setting this - it's for figuring out whether the legacy vga stuff should be nuked too. And with the preceeding two patches those are all using the pci version of this. Which means for all other callers primary == false and we can remove it now. Signed-off-b

[PATCH 04/11] video/aperture: use generic code to figure out the vga default device

2023-01-11 Thread Daniel Vetter
Since vgaarb has been promoted to be a core piece of the pci subsystem we don't have to open code random guesses anymore, we actually know this in a platform agnostic way, and there's no need for an x86 specific hack. See also 1d38fe6ee6a8 ("PCI/VGA: Move vgaarb to drivers/pci") This should not re

[PATCH 02/11] drm/gma500: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-11 Thread Daniel Vetter
This one nukes all framebuffers, which is a bit much. In reality gma500 is igpu and never shipped with anything discrete, so there should not be any difference. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 07/11] fbdev/radeon: use pci aperture helpers

2023-01-11 Thread Daniel Vetter
It's not exactly the same since the open coded version doesn't set primary correctly. But that's a bugfix, so shouldn't hurt really. Signed-off-by: Daniel Vetter Cc: Benjamin Herrenschmidt Cc: linux-fb...@vger.kernel.org --- drivers/video/fbdev/aty/radeon_base.c | 10 +- 1 file changed,

[PATCH 06/11] staging/lynxfb: Use pci aperture helper

2023-01-11 Thread Daniel Vetter
It exists! Note that since this is an exact copy, there shouldn't be any functional difference here. Signed-off-by: Daniel Vetter Cc: Sudip Mukherjee Cc: Teddy Wang Cc: linux-fb...@vger.kernel.org --- drivers/staging/sm750fb/sm750.c | 16 +--- 1 file changed, 1 insertion(+), 15 del

[PATCH 08/11] fbdev/hyperv: use pci aperture helpers

2023-01-11 Thread Daniel Vetter
Again this just gets setting the primary parameter right, which might help in some case (but then I guess the hyperv display isn't vga compatible, I have no idea). It's more consistent for sure. Signed-off-by: Daniel Vetter Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Wei Liu Cc: Dexuan Cui C

[PATCH 09/11] video/aperture: Move vga handling to pci function

2023-01-11 Thread Daniel Vetter
A few reasons for this: - It's really the only one where this matters. I tried looking around, and I didn't find any non-pci vga-compatible controllers for x86 (since that's the only platform where we had this until a few patches ago), where a driver participating in the aperture claim dan

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Andi Shyti
Hi Rodrigo, On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > From: Aravind Iddamsetty > > > > During module load not all the punit transaction have completed > > and we might end up timing out, as shown by the followi

[PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga

2023-01-11 Thread Daniel Vetter
Otherwise it's bit silly, and we might throw out the driver for the screen the user is actually looking at. I haven't found a bug report for this case yet, but we did get bug reports for the analog case where we're throwing out the efifb driver. References: https://bugzilla.kernel.org/show_bug.cgi

[PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Daniel Vetter
This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs"), where we remove the sysfb when loading a driver for an unrelated pci device, resulting in the user loosing their efifb console or similar. Note that in practice this only

[PATCH 10/11] video/aperture: Drop primary argument

2023-01-11 Thread Daniel Vetter
With the preceeding patches it's become defunct. Also I'm about to add a different boolean argument, so it's better to keep the confusion down to the absolute minimum. Signed-off-by: Daniel Vetter Cc: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Helge Deller Cc: linux-fb...@vger.kernel.o

[linux-next:master] BUILD REGRESSION c9e9cdd8bdcc3e1ea330d49ea587ec71884dd0f5

2023-01-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: c9e9cdd8bdcc3e1ea330d49ea587ec71884dd0f5 Add linux-next specific files for 20230111 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/20230803.2ypwa4gk-...@intel.com Error

Re: [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: It's just open coded and matches. Note that Thomas said that his version apparently failed for some reason, but hey maybe we should try again. I'll give this patch a test tomorrow. Best regards Thomas Signed-off-by: Daniel Vetter Cc: Dave Ai

Re: [PATCH 03/11] drm/aperture: Remove primary argument

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: Only really pci devices have a business setting this - it's for figuring out whether the legacy vga stuff should be nuked too. And with the preceeding two patches those are all using the pci version of this. Which means for all other callers primar

[PATCH v3 0/2] drm/i915: Avoid full proxy f_ops debug attributes

2023-01-11 Thread Deepak R Varma
This patch series proposes to replace a combination of DEFINE_SIMPLE_ATTRIBUTE() + debugfs_create_file() by a combination of DEFINE_DEBUGFS_ATTRIBUTE() + debugfs_create_file_unsafe(). The change reduced overhead in terms of managing the full proxy f_ops at runtime. The patches 1 & 2 covers for the

[PATCH v3 1/2] drm/i915/display: Avoid full proxy f_ops for DRRS debug attributes

2023-01-11 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

[PATCH v3 2/2] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-11 Thread Deepak R Varma
Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() function adds the overhead of introducing a proxy file operation functions to wrap the original read/write inside file removal protection functions. This adds significant overhead in terms of introducing and managing the proxy facto

Re: [PATCH 04/11] video/aperture: use generic code to figure out the vga default device

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: Since vgaarb has been promoted to be a core piece of the pci subsystem we don't have to open code random guesses anymore, we actually know this in a platform agnostic way, and there's no need for an x86 specific hack. See also 1d38fe6ee6a8 ("PCI/VGA

Re: [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: Otherwise it's bit silly, and we might throw out the driver for the screen the user is actually looking at. I haven't found a bug report for this case yet, but we did get bug reports for the analog case where we're throwing out the efifb driver. Re

Re: [PATCH 06/11] staging/lynxfb: Use pci aperture helper

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: It exists! Note that since this is an exact copy, there shouldn't be any functional difference here. Signed-off-by: Daniel Vetter Cc: Sudip Mukherjee Cc: Teddy Wang Cc: linux-fb...@vger.kernel.org --- drivers/staging/sm750fb/sm750.c | 16 +

Re: [PATCH v2 03/10] drm: Don't include in drm_crtc_helper.h

2023-01-11 Thread Ville Syrjälä
On Wed, Jan 11, 2023 at 02:01:59PM +0100, Thomas Zimmermann wrote: > Including in drm_crtc_helper.h is not required. Remove > the include statement and avoid rebuilding DRM whenever the fbdev > header changes. > > Signed-off-by: Thomas Zimmermann > --- > include/drm/drm_crtc_helper.h | 2 -- >

Re: [PATCH v2 06/10] drm: Define enum mode_set_atomic in drm_modeset_helper_tables.h

2023-01-11 Thread Ville Syrjälä
On Wed, Jan 11, 2023 at 02:02:02PM +0100, Thomas Zimmermann wrote: > Define enum mode_set_atomic next to the only interface that uses > the type. This will allow for removing several include statements > for drm_fb_helper.h. No functional changes. > > Signed-off-by: Thomas Zimmermann Reviewed-by

Re: [PATCH 10/11] video/aperture: Drop primary argument

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: With the preceeding patches it's become defunct. Also I'm about to add a different boolean argument, so it's better to keep the confusion down to the absolute minimum. OK, maybe my earlier comments about the use of 'primary' in some function call

Re: [PATCH v2 02/10] drm: Include where needed

2023-01-11 Thread Ville Syrjälä
On Wed, Jan 11, 2023 at 02:01:58PM +0100, Thomas Zimmermann wrote: > Include in source files that need it. Some of DRM's > source code gets OF header via drm_crtc_helper.h and , > which can leed to unnecessary recompilation. > > In drm_modes.c, add a comment on the reason for still including > .

Re: [PATCH] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 04:38:13PM +0100, Thomas Zimmermann wrote: > Set the framebuffer info for drivers that support VGA switcheroo. Only > affects the amdgpu driver, which uses VGA switcheroo and generic fbdev > emulation. For other drivers, this does nothing. > > Amdgpu's lastclose helper call

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:41 schrieb Daniel Vetter: This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable sysfb device registration when removing conflicting FBs"), where we remove the sysfb when loading a driver for an unrelated pci device, resulting in the user loosing their efifb con

[PATCH v9 0/4] drm/panel: Add Magnachip D53E6EA8966 Panel Controller

2023-01-11 Thread Chris Morgan
From: Chris Morgan Add the Magnachip D53E6EA8966 panel IC controller for display panels such as the Samsung AMS495QA01 panel as found on the Anbernic RG503. This panel uses DSI to receive video signals, but 3-wire SPI to receive command signals using DBI. Changes since V8: - Set "placeholder" d

[PATCH v9 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-11 Thread Chris Morgan
From: Chris Morgan Add helper function to find DSI host for devices where DSI panel is not a minor of a DSI bus (such as the Samsung AMS495QA01 panel or the official Raspberry Pi touchscreen display). Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk --- drivers/gpu/drm/drm_of.c | 70

[PATCH v9 2/4] dt-bindings: display: panel: Add Samsung AMS495QA01

2023-01-11 Thread Chris Morgan
From: Chris Morgan Add documentation for Samsung AMS495QA01 panel (with Magnachip D53E6EA8966 controller IC). Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk Reviewed-by: Rob Herring --- .../display/panel/samsung,ams495qa01.yaml | 57 +++ 1 file changed, 57 ins

[PATCH v9 4/4] arm64: dts: rockchip: add display to RG503

2023-01-11 Thread Chris Morgan
From: Chris Morgan Add Samsung AMS495QA01 panel to RG503. Signed-off-by: Chris Morgan Signed-off-by: Maya Matuszczyk --- .../dts/rockchip/rk3566-anbernic-rg503.dts| 55 +++ 1 file changed, 55 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg503.dt

[PATCH v9 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver

2023-01-11 Thread Chris Morgan
From: Chris Morgan Support Magnachip D53E6EA8966 based panels such as the Samsung AMS495QA01 panel as found on the Anbernic RG503. Note this driver supports only the AMS495QA01 today which receives video signals via DSI, however it receives commands via 3-wire SPI using DBI. Signed-off-by: Chris

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 05:20:00PM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable > > sysfb device registration when removing conflicting FBs"), where we > > remove the sysfb when loading

Re: [PATCH v2] drm/mediatek: Add support for AR30 and BA30

2023-01-11 Thread AngeloGioacchino Del Regno
Il 10/01/23 21:47, Justin Green ha scritto: Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. Tested using "modetest -P" on an MT8195. Signed-off-by: Justin Green Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v9 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-11 Thread Maxime Ripard
Hi, On Wed, Jan 11, 2023 at 10:30:09AM -0600, Chris Morgan wrote: > From: Chris Morgan > > Add helper function to find DSI host for devices where DSI panel is not > a minor of a DSI bus (such as the Samsung AMS495QA01 panel or the > official Raspberry Pi touchscreen display). > > Signed-off-by:

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Jani Nikula
On Wed, 11 Jan 2023, Andi Shyti wrote: > On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: >> On Wed, 11 Jan 2023, Andi Shyti wrote: >> > From: Aravind Iddamsetty >> > >> > During module load not all the punit transaction have completed >> > and we might end up timing out, as shown by

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Javier Martinez Canillas
On 1/11/23 17:20, Thomas Zimmermann wrote: [...] >> >> diff --git a/drivers/video/aperture.c b/drivers/video/aperture.c >> index ba565515480d..a1821d369bb1 100644 >> --- a/drivers/video/aperture.c >> +++ b/drivers/video/aperture.c >> @@ -321,15 +321,16 @@ int aperture_remove_conflicting_pci_devic

Re: [PATCH 04/11] video/aperture: use generic code to figure out the vga default device

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 04:59:30PM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > Since vgaarb has been promoted to be a core piece of the pci subsystem > > we don't have to open code random guesses anymore, we actually know > > this in a platform agnostic

Re: [PATCH 05/11] video/aperture: Only kick vgacon when the pdev is decoding vga

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 05:03:02PM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > Otherwise it's bit silly, and we might throw out the driver for the > > screen the user is actually looking at. I haven't found a bug report > > for this case yet, but we did

Re: [PATCH 11/11] video/aperture: Only remove sysfb on the default vga pci device

2023-01-11 Thread Javier Martinez Canillas
Hello Daniel, On 1/11/23 16:41, Daniel Vetter wrote: > This fixes a regression introduced by ee7a69aa38d8 ("fbdev: Disable > sysfb device registration when removing conflicting FBs"), where we > remove the sysfb when loading a driver for an unrelated pci device, > resulting in the user loosing the

Re: [PATCH 5/9] drm/vc4: hdmi: Rework the CSC matrices organization

2023-01-11 Thread Dave Stevenson
Hi Thomas Thanks for the review On Wed, 11 Jan 2023 at 15:03, Thomas Zimmermann wrote: > > Hi > > Am 07.12.22 um 17:07 schrieb Maxime Ripard: > > From: Dave Stevenson > > > > The CSC matrices were stored as separate matrix for each colorspace, and > > if we wanted a limited or full RGB output.

Re: [PATCH 01/11] drm/ast: Use drm_aperture_remove_conflicting_pci_framebuffers

2023-01-11 Thread Daniel Vetter
On Wed, Jan 11, 2023 at 04:48:39PM +0100, Thomas Zimmermann wrote: > Hi > > Am 11.01.23 um 16:41 schrieb Daniel Vetter: > > It's just open coded and matches. > > > > Note that Thomas said that his version apparently failed for some > > reason, but hey maybe we should try again. > > I'll give thi

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2023-01-11 Thread Sean Christopherson
On Thu, Aug 18, 2022, Christian König wrote: > Am 18.08.22 um 01:13 schrieb Dmitry Osipenko: > > On 8/18/22 01:57, Dmitry Osipenko wrote: > > > On 8/15/22 18:54, Dmitry Osipenko wrote: > > > > On 8/15/22 17:57, Dmitry Osipenko wrote: > > > > > On 8/15/22 16:53, Christian König wrote: > > > > > > Am

Re: [Intel-gfx] [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-11 Thread Rodrigo Vivi
On Wed, Jan 11, 2023 at 04:39:36PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Wed, Jan 11, 2023 at 10:25:56AM -0500, Rodrigo Vivi wrote: > > On Wed, Jan 11, 2023 at 11:44:47AM +0100, Andi Shyti wrote: > > > From: Aravind Iddamsetty > > > > > > During module load not all the punit transaction

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2023-01-11 Thread Sean Christopherson
On Tue, Sep 06, 2022, Daniel Vetter wrote: > On Tue, Sep 06, 2022 at 10:01:47PM +0200, Daniel Vetter wrote: > > On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > > > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > > > Higher order pages allocated using alloc_pages() aren't refcou

Re: [PATCH] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-11 Thread Alex Deucher
On Wed, Jan 11, 2023 at 10:38 AM Thomas Zimmermann wrote: > > Set the framebuffer info for drivers that support VGA switcheroo. Only > affects the amdgpu driver, which uses VGA switcheroo and generic fbdev > emulation. For other drivers, this does nothing. > > Amdgpu's lastclose helper called vga_

Re: [PATCH v9 1/4] drm: of: Add drm_of_get_dsi_bus helper function

2023-01-11 Thread Chris Morgan
On Wed, Jan 11, 2023 at 05:39:26PM +0100, Maxime Ripard wrote: > Hi, > > On Wed, Jan 11, 2023 at 10:30:09AM -0600, Chris Morgan wrote: > > From: Chris Morgan > > > > Add helper function to find DSI host for devices where DSI panel is not > > a minor of a DSI bus (such as the Samsung AMS495QA01 p

[PATCH 02/13] drm/debugfs: Create helper to create debugfs files from list

2023-01-11 Thread Maíra Canal
Create a helper to encapsulate the code that creates a new debugfs file from a linked list related to an object. Moreover, the helper also provides more flexibily on the type of the object. Signed-off-by: Maíra Canal --- drivers/gpu/drm/drm_debugfs.c | 22 -- 1 file changed,

[PATCH 01/13] drm/debugfs: Create helper to add debugfs files to device's list

2023-01-11 Thread Maíra Canal
Create a helper to encapsulate the code that adds a new debugfs file to a linked list related to a object. Moreover, the helper also provides more flexibily on the type of the object, allowing to use the helper for other types of drm_debugfs_entry. Signed-off-by: Maíra Canal --- drivers/gpu/drm/

[PATCH 04/13] drm/debugfs: Create a debugfs infrastructure for encoders

2023-01-11 Thread Maíra Canal
Introduce the ability to add DRM debugfs files to a list managed by the encoder and, during drm_encoder_register_all(), all added files will be created at once. Moreover, introduce some typesafety as struct drm_debugfs_encoder_entry holds a drm_encoder instead of a drm_device. So, the drivers can

[PATCH 00/13] drm/debugfs: Create a debugfs infrastructure for kms objects

2023-01-11 Thread Maíra Canal
This series introduces the initial structure to improve the support of kms objects by the DRM debugfs [1]. Currently, we can create debugfs files at late-register hooks with the function drm_debugfs_add_file() through the functionality implemented by the function drm_debugfs_late_register(), which

[PATCH 03/13] drm/debugfs: Create a debugfs infrastructure for connectors

2023-01-11 Thread Maíra Canal
Introduce the ability to add DRM debugfs files to a list managed by the connector and, during drm_connector_register(), all added files will be created at once. Moreover, introduce some typesafety as struct drm_debugfs_connector_entry holds a drm_connector instead of a drm_device. So, the drivers

[PATCH 05/13] drm/debugfs: Create a debugfs infrastructure for CRTC

2023-01-11 Thread Maíra Canal
Introduce the ability to add DRM debugfs files to a list managed by the crtc and, during drm_crtc_register_all(), all added files will be created at once. Moreover, introduce some typesafety as struct drm_debugfs_crtc_entry holds a drm_crtc instead of a drm_device. So, the drivers can get a crtc o

[PATCH 06/13] drm/vc4: Split variable instantiation of vc4_debugfs_regset32()

2023-01-11 Thread Maíra Canal
Considering that there are multiple ways to instantiate a drm_debugfs_entry, as kms object's debugfs entries were introduced, split vc4_debugfs_regset32() into two functions: one to deal with the drm_printer and the other to instantiate the proper variables. Signed-off-by: Maíra Canal --- driver

[PATCH 08/13] drm/vc4: Use the crtc's debugfs infrastructure

2023-01-11 Thread Maíra Canal
Replace the use of drm_debugfs_add_files() with the new drm_debugfs_crtc_add_files() function, which centers the debugfs files management on the drm_crtc instead of drm_device. Using this function on late register callbacks is more adequate as the callback passes a drm_crtc as parameter. Signed-of

[PATCH 09/13] drm/sti: Use the crtc's debugfs infrastructure

2023-01-11 Thread Maíra Canal
Replace the use of drm_debugfs_add_files() with the new drm_debugfs_crtc_add_files() function, which centers the debugfs files management on the drm_crtc instead of drm_device. Using this function on late register callbacks is more adequate as the callback passes a drm_crtc as parameter. Signed-of

[PATCH 12/13] drm/debugfs: Remove the debugfs late register function

2023-01-11 Thread Maíra Canal
With the new debugfs infrastructure for kms objects, there is no need to have a late register helper for debugfs, as the late register debugfs function was only created because drm_debugfs_init() is not able to create debugfs files for modeset components, as they are registered after the primary an

[PATCH 10/13] drm/sti: Use the connectors' debugfs infrastructure

2023-01-11 Thread Maíra Canal
Replace the use of drm_debugfs_add_files() with the new drm_debugfs_connector_add_files() function, which centers the debugfs files management on the drm_connector instead of drm_device. Using this function on late register callbacks is more adequate as the callback passes a drm_connector as parame

[PATCH 07/13] drm/vc4: Use the encoders' debugfs infrastructure

2023-01-11 Thread Maíra Canal
Replace the use of drm_debugfs_add_files() with the new drm_debugfs_encoder_add_files() function, which centers the debugfs files management on the drm_encoder instead of drm_device. Using this function on late register callbacks is more adequate as the callback passes a drm_encoder as parameter.

[PATCH 11/13] drm/sti: Use the encoders' debugfs infrastructure

2023-01-11 Thread Maíra Canal
Replace the use of drm_debugfs_add_files() with the new drm_debugfs_encoder_add_files() function, which centers the debugfs files management on the drm_encoder instead of drm_device. Using this function on late register callbacks is more adequate as the callback passes a drm_encoder as parameter.

[PATCH 13/13] drm/todo: Update the debugfs clean up task

2023-01-11 Thread Maíra Canal
The structs drm_debugfs_connector_entry, drm_debugfs_encoder_entry, and drm_debugfs_crtc_entry introduced a debugfs infrastruture that made it possible to remove late-register debugfs. So, update the debugfs clean up task to include the advances for the kms objects and point out possible improvemen

Re: [PATCH] drm/fb-helper: Set framebuffer for vga-switcheroo clients

2023-01-11 Thread Thomas Zimmermann
Hi Am 11.01.23 um 16:38 schrieb Thomas Zimmermann: Set the framebuffer info for drivers that support VGA switcheroo. Only affects the amdgpu driver, which uses VGA switcheroo and generic fbdev emulation. For other drivers, this does nothing. Amdgpu's lastclose helper called vga_switcheroo_proce

[PATCH] drm/ttm: Fix a regression causing kernel oops'es

2023-01-11 Thread Zack Rusin
From: Zack Rusin The branch is explicitly taken if ttm == NULL which means that to avoid a null pointer reference the ttm object can not be used inside. Switch back to dst_mem to avoid kernel oops'es. This fixes kernel oops'es with any buffer objects which don't have ttm_tt, e.g. with vram based

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Matthew Brost
On Wed, Jan 11, 2023 at 09:09:45AM +, Tvrtko Ursulin wrote: > > On 11/01/2023 01:13, Matthew Brost wrote: > > On Tue, Jan 10, 2023 at 04:39:00PM +, Matthew Brost wrote: > > > On Tue, Jan 10, 2023 at 11:28:08AM +, Tvrtko Ursulin wrote: > > > > > > > > > > > > On 09/01/2023 17:27, Jaso

Re: [PATCH v2 00/13] drm/panel: Make panel drivers use existing DSI write macros

2023-01-11 Thread Javier Martinez Canillas
On 1/7/23 20:18, Javier Martinez Canillas wrote: > Hello, > > This series contains cleanups for DRM panel drivers that define their own > DSI write macros instead of using what's already in . > > This is a v2 that addresses issues pointed out by Sam Ravnborg in the v1: > > https://lore.kernel.or

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Matthew Brost
On Wed, Jan 11, 2023 at 09:17:01AM +, Tvrtko Ursulin wrote: > > On 10/01/2023 19:01, Matthew Brost wrote: > > On Tue, Jan 10, 2023 at 04:50:55PM +, Tvrtko Ursulin wrote: > > > > > > On 10/01/2023 15:55, Matthew Brost wrote: > > > > On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin

[PATCH] drm/amd/display: fix possible buffer overflow relating to secure display

2023-01-11 Thread Hamza Mahfooz
It is possible that adev->dm.dc->caps.max_links is greater than AMDGPU_MAX_CRTCS. So, to not potentially access unallocated memory use adev->mode_info.num_crtc to do the bounds check instead of adev->dm.dc->caps.max_links. Fixes: 278b2b5ba2f2 ("drm/amd/display: Implement multiple secure display")

Re: [Intel-gfx] [PATCH] drm/i915/display: Check source height is > 0

2023-01-11 Thread Drew Davenport
On Tue, Dec 27, 2022 at 05:55:17PM +, Teres Alexis, Alan Previn wrote: > Is there a better place for this check higher up the intel specific > atomic-check? (so the check won't be skl specific - i notice that > intel_adjusted_rate is also called by > ilk_foo as well and non-backend-specific f

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread John Harrison
On 1/11/2023 10:07, Matthew Brost wrote: On Wed, Jan 11, 2023 at 09:17:01AM +, Tvrtko Ursulin wrote: On 10/01/2023 19:01, Matthew Brost wrote: On Tue, Jan 10, 2023 at 04:50:55PM +, Tvrtko Ursulin wrote: On 10/01/2023 15:55, Matthew Brost wrote: On Tue, Jan 10, 2023 at 12:19:35PM +

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Matthew Brost
On Wed, Jan 11, 2023 at 10:52:54AM -0800, John Harrison wrote: > On 1/11/2023 10:07, Matthew Brost wrote: > > On Wed, Jan 11, 2023 at 09:17:01AM +, Tvrtko Ursulin wrote: > > > On 10/01/2023 19:01, Matthew Brost wrote: > > > > On Tue, Jan 10, 2023 at 04:50:55PM +, Tvrtko Ursulin wrote: > > >

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Matthew Brost
On Wed, Jan 11, 2023 at 08:50:37AM +, Tvrtko Ursulin wrote: > > On 10/01/2023 14:08, Jason Ekstrand wrote: > > On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin > > mailto:tvrtko.ursu...@linux.intel.com>> > > wrote: > > > > > > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > > > [s

  1   2   3   >