Patch "drm/plane-helper: Add the missing declaration of drm_atomic_state" has been added to the 6.1-stable tree

2023-01-10 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/plane-helper: Add the missing declaration of drm_atomic_state to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patc

Re: [PATCH v3] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Andrzej Hajda
On 09.01.2023 13:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2: * DG2 needs to be covered too. (Matt) v3: * Full version check for Gen12 to avoid catching all future platforms. (Matt) Signed-off-by:

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-01-10 Thread Neil Armstrong
On 09/01/2023 23:00, Marek Szyprowski wrote: devm_regulator_get_enable_optional() function returns 0 on success, so use it for the check if function succeded instead of the -ENODEV value. Fixes: 429e87063661 ("drm/meson: dw-hdmi: Use devm_regulator_*get_enable*()") Signed-off-by: Marek Szyprowsk

Re: [PATCH] drm/msm/dpu: disable DSC blocks for SM8350

2023-01-10 Thread Dmitry Baryshkov
On Mon, 09 Jan 2023 23:43:09 +0200, Dmitry Baryshkov wrote: > SM8350 has newer version of DSC blocks, which are not supported by the > driver yet. Remove them for now until these blocks are supported by the > driver. > > Applied, thanks! [1/1] drm/msm/dpu: disable DSC blocks for SM8350

Re: [PATCH] drm/meson: dw-hdmi: Fix devm_regulator_*get_enable*() conversion

2023-01-10 Thread Neil Armstrong
Hi, On Mon, 09 Jan 2023 23:00:33 +0100, Marek Szyprowski wrote: > devm_regulator_get_enable_optional() function returns 0 on success, so > use it for the check if function succeded instead of the -ENODEV value. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-mi

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Boris Brezillon
Hi Daniel, On Mon, 9 Jan 2023 21:40:21 +0100 Daniel Vetter wrote: > On Mon, Jan 09, 2023 at 06:17:48PM +0100, Boris Brezillon wrote: > > Hi Jason, > > > > On Mon, 9 Jan 2023 09:45:09 -0600 > > Jason Ekstrand wrote: > > > > > On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost > > > wrote: > > >

Re: [PATCH 1/4] memcg: Track exported dma-buffers

2023-01-10 Thread Michal Hocko
On Mon 09-01-23 21:38:04, T.J. Mercier wrote: > When a buffer is exported to userspace, use memcg to attribute the > buffer to the allocating cgroup until all buffer references are > released. > > Unlike the dmabuf sysfs stats implementation, this memcg accounting > avoids contention over the kern

Re: [RESEND PATCH] drm/mediatek: Add support for AR30 and BA30

2023-01-10 Thread AngeloGioacchino Del Regno
Il 09/01/23 19:26, Justin Green ha scritto: Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. Tested using "modetest -P" on an MT8195. Signed-off-by: Justin Green Hello Justin, this commit does not apply against next-20230110 because of your own AFBC suppor

Re: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()

2023-01-10 Thread Uwe Kleine-König
Hello, I fatfingered my git tooling and got the author of this patch wrong. My intention is that the author is Uwe Kleine-König and not my other self with my private email address. Tell me if I should resend to simplify patch application. Best regards Uwe -- Pengutronix e.K.

Re: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
Hello Uwe, On 1/10/23 10:06, Uwe Kleine-König wrote: > Hello, > > I fatfingered my git tooling and got the author of this patch wrong. My > intention is that the author is > > Uwe Kleine-König > That's what I thought but good to have a confirmation from you. > and not my other self wit

Re: [PATCH v3] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Tvrtko Ursulin
On 10/01/2023 08:23, Andrzej Hajda wrote: On 09.01.2023 13:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2:   * DG2 needs to be covered too. (Matt) v3:   * Full version check for Gen12 to avoid catching all

[PATCH] drm/mediatek: include missing headers

2023-01-10 Thread Miles Chen
Fix the follow sparse warnings by adding missing headers: drivers/gpu/drm/mediatek/mtk_cec.c:251:24: sparse: warning: symbol 'mtk_cec_driver' was not declared. Should it be static? drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:221:24: sparse: warning: symbol 'mtk_disp_ccorr_driver' was not declared.

Re: [PATCH v2 2/3] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time

2023-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/23 06:54, xinlei@mediatek.com ha scritto: From: Xinlei Lee Since the panel spec stipulates that the time from lcm_reset to DSI to send the initial code should be greater than 6ms and less than 40ms, so reduce the delay before sending the initial code and avoid panel exceptions. P

Re: [PATCH v2 3/3] drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence

2023-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/23 06:54, xinlei@mediatek.com ha scritto: From: Xinlei Lee For "boe,tv105wum-nw0" this special panel, it is stipulated in the panel spec that MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high. Signed-off-by: Xinlei Lee --- drivers/gpu/drm/panel/panel-boe

Re: [PATCH] drm/mxsfb: improve clk handling for axi clk

2023-01-10 Thread Javier Martinez Canillas
Hello Uwe, On 7/20/20 17:32, Uwe Kleine-König wrote: > Ignoring errors from devm_clk_get() is wrong. To handle not all platforms > having an axi clk use devm_clk_get_optional() instead and do proper error > handling. > > Also the clk API handles NULL as a dummy clk (which is also returned by > de

Re: [PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2023-01-10 Thread Gerd Hoffmann
On Fri, Jan 06, 2023 at 10:35:15AM +0100, Daniel Vetter wrote: > On Fri, Jan 06, 2023 at 09:56:40AM +0100, Gerd Hoffmann wrote: > > On Thu, Nov 17, 2022 at 05:30:54PM -0800, Vivek Kasireddy wrote: > > > Setting this property will allow the userspace to look for new modes or > > > position info when

Re: [PATCH v1 1/2] drm/virtio: Attach and set suggested_x/y properties for the connector

2023-01-10 Thread Gerd Hoffmann
Hi, > +static void virtio_gpu_update_output_position(struct virtio_gpu_output > *output) > +{ > + struct drm_connector *connector = &output->conn; > + struct drm_device *dev = connector->dev; > + > + drm_object_property_set_value(&connector->base, > + dev->mode_config.su

Re: [PATCH] drm/mediatek: include missing headers

2023-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/23 10:16, Miles Chen ha scritto: Fix the follow sparse warnings by adding missing headers: drivers/gpu/drm/mediatek/mtk_cec.c:251:24: sparse: warning: symbol 'mtk_cec_driver' was not declared. Should it be static? drivers/gpu/drm/mediatek/mtk_disp_ccorr.c:221:24: sparse: warning: symbo

Re: [PATCH] drm/mediatek: stop using 0 as NULL pointer

2023-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/23 04:12, Miles Chen ha scritto: Use NULL for NULL pointer to fix the following sparse warning: drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain integer as NULL pointer Signed-off-by: Miles Chen Please add the appropriate tag... Fixes: 3df64d7b0a4f ("drm/

Re: [PATCH] drm/virtio: Fix GEM handle creation UAF

2023-01-10 Thread Dmitry Osipenko
On 1/10/23 04:47, Rob Clark wrote: > On Mon, Jan 9, 2023 at 3:28 PM Dmitry Osipenko > wrote: >> >> On 12/17/22 02:33, Rob Clark wrote: >>> From: Rob Clark >>> >>> Userspace can guess the handle value and try to race GEM object creation >>> with handle close, resulting in a use-after-free if we de

Re: [PATCH v3] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Andrzej Hajda
On 10.01.2023 10:16, Tvrtko Ursulin wrote: On 10/01/2023 08:23, Andrzej Hajda wrote: On 09.01.2023 13:24, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2:   * DG2 needs to be covered too. (Matt) v3:   * Full

Re: [PATCH v2 RESEND] adreno: Shutdown the GPU properly

2023-01-10 Thread Ricardo Ribalda
On Mon, 9 Jan 2023 at 23:25, Joel Fernandes (Google) wrote: > > During kexec on ARM device, we notice that device_shutdown() only calls > pm_runtime_force_suspend() while shutting down the GPU. This means the GPU > kthread is still running and further, there maybe active submits. > > This causes a

Re: [bug report] habanalabs: Timestamps buffers registration

2023-01-10 Thread Dan Carpenter
On Mon, Jan 09, 2023 at 03:07:33PM +, Farah Kassabri wrote: > > 2171 { > > 2172 struct hl_ts_buff *ts_buff = NULL; > > 2173 u32 size, num_elements; > > 2174 void *p; > > 2175 > > 2176 num_elements = *(u32 *)args; > > > > This business of

Re: [PATCH] drm/mxsfb: improve clk handling for axi clk

2023-01-10 Thread Javier Martinez Canillas
On 1/10/23 10:26, Javier Martinez Canillas wrote: > Hello Uwe, > > On 7/20/20 17:32, Uwe Kleine-König wrote: >> Ignoring errors from devm_clk_get() is wrong. To handle not all platforms >> having an axi clk use devm_clk_get_optional() instead and do proper error >> handling. >> >> Also the clk API

Re: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards, Javier Martinez Canillas C

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-10 Thread Lee Jones
On Mon, 09 Jan 2023, Sam Ravnborg wrote: > Hi Daniel. > > On Mon, Jan 09, 2023 at 11:06:35AM +, Daniel Thompson wrote: > > On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission > > Endpoint wrote: > > > From: Sam Ravnborg > > > > > > With all users gone remove the depreca

Re: [PATCH 039/606] drm/i2c/sil164: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards

Re: [PATCH 040/606] drm/i2c/tda9950: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > -- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards,

Re: [PATCH 041/606] drm/i2c/tda998x: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards

Re: [PATCH 042/606] drm/panel: olimex-lcd-olinuxino: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards

Re: [PATCH 043/606] drm/panel: raspberrypi-touchscreen: Convert to i2c's .probe_new()

2023-01-10 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks! -- Best regards

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-10 Thread Geert Uytterhoeven
On Tue, Jan 10, 2023 at 8:07 AM Laurentiu Palcu wrote: > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > > It looks like there are some issues with this patchset... :/ I just > > > fetched the drm-tip and, with these patches inc

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/gt: Start adding module oriented dmesg output

2023-01-10 Thread Andi Shyti
Hi John, [...] > +#define gt_WARN_ON(_gt, _condition) \ > + gt_WARN(_gt, _condition, "%s", "gt_WARN_ON(" __stringify(_condition) > ")") > + > +#define gt_WARN_ON_ONCE(_gt, _condition) \ > + gt_WARN_ONCE(_gt, _condition, "%s", "gt_WARN_ONCE(" > __stringify(_condition) ")") > + > +#define

Re: [PATCH] drm/mxsfb: improve clk handling for axi clk

2023-01-10 Thread Marek Vasut
On 1/10/23 11:06, Javier Martinez Canillas wrote: On 1/10/23 10:26, Javier Martinez Canillas wrote: Hello Uwe, On 7/20/20 17:32, Uwe Kleine-König wrote: Ignoring errors from devm_clk_get() is wrong. To handle not all platforms having an axi clk use devm_clk_get_optional() instead and do proper

Re: [PATCH][next] habanalabs: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Stanislaw Gruszka
On Mon, Jan 09, 2023 at 07:39:47PM -0600, Gustavo A. R. Silva wrote: > Zero-length arrays are deprecated[1] and we are moving towards > adopting C99 flexible-array members instead. So, replace zero-length > arrays in a couple of structures with flex-array members. > > This helps with the ongoing e

Re: [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2023-01-10 Thread Javier Martinez Canillas
On 12/19/22 09:49, Javier Martinez Canillas wrote: > Hello Uwe, > > On 12/19/22 09:36, Uwe Kleine-König wrote: >> While working on a drm driver that doesn't need the i2c algobit stuff I >> noticed that DRM selects this code even though only 8 drivers actually use >> it. While also only some driver

Re: [PATCH] MAINTAINERS: drm/hisilicon: Drop Chen Feng

2023-01-10 Thread Javier Martinez Canillas
On 12/19/22 10:04, Javier Martinez Canillas wrote: > On 12/19/22 09:53, Uwe Kleine-König wrote: >> The listed address doesn't work any more: >> >> puck.c...@hisilicon.com >> host mx5.hisilicon.com [124.71.93.234] >> SMTP error from remote mail server after RCPT >> TO:: >> 551 5.1.1 :

[RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andrzej Hajda
This patch tries to show usability of __xchg helper. It is not intended to be merged, but I can convert it to proper patchset if necessary. There are many more places where __xchg can be used. This demo shows the most spectacular cases IMHO: - previous value is returned from function, - temporary

Re: [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andy Shevchenko
On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: > This patch tries to show usability of __xchg helper. > It is not intended to be merged, but I can convert > it to proper patchset if necessary. > > There are many more places where __xchg can be used. > This demo shows the most spect

Re: [PATCH] drm/vc4: dsi: Drop unused i2c include

2023-01-10 Thread Javier Martinez Canillas
On 12/19/22 09:49, Javier Martinez Canillas wrote: > On 12/19/22 09:40, Uwe Kleine-König wrote: >> The driver doesn't make use of any symbol provided by . So >> drop the include. >> >> Signed-off-by: Uwe Kleine-König >> --- > > Reviewed-by: Javier Martinez Canillas > I've pushed this to drm-mi

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Tvrtko Ursulin
On 09/01/2023 17:27, Jason Ekstrand wrote: [snip] >>> AFAICT it proposes to have 1:1 between *userspace* created contexts (per >>> context _and_ engine) and drm_sched. I am not sure avoiding invasive changes >>> to the shared code is in the spirit of the overall idea a

[PATCH v4] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. v2: * DG2 needs to be covered too. (Matt) v3: * Full version check for Gen12 to avoid catching all future platforms. (Matt) v4: * Be totally explicit on the Gen12 branch. (Andrzej) Signed

Re: [Intel-gfx] [PATCH v3 1/1] drm/i915/gt: Start adding module oriented dmesg output

2023-01-10 Thread Tvrtko Ursulin
On 09/01/2023 23:48, john.c.harri...@intel.com wrote: From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of

Re: [PATCH] doc: add dma-buf IOCTL code to table

2023-01-10 Thread Simon Ser
On Tuesday, November 29th, 2022 at 10:56, Christian König wrote: > Should I also push this? I can push to drm-misc-next, but is that the suitable repo?

Re: [PATCH 1/7] drm/atomic: log drm_atomic_replace_property_blob_from_id() errors

2023-01-10 Thread Simon Ser
Ping

Re: [PATCH] doc: add dma-buf IOCTL code to table

2023-01-10 Thread Christian König
Am 10.01.23 um 12:49 schrieb Simon Ser: On Tuesday, November 29th, 2022 at 10:56, Christian König wrote: Should I also push this? I can push to drm-misc-next, but is that the suitable repo? I think so, unless you think that this is a necessary bug fix which should be backported. Christi

Re: [PATCH] doc: add dma-buf IOCTL code to table

2023-01-10 Thread Simon Ser
On Tuesday, January 10th, 2023 at 12:53, Christian König wrote: > Am 10.01.23 um 12:49 schrieb Simon Ser: > > > On Tuesday, November 29th, 2022 at 10:56, Christian König > > christian.koe...@amd.com wrote: > > > > > Should I also push this? > > > I can push to drm-misc-next, but is that the s

Re: [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-10 Thread Matthew Auld
On 07/01/2023 15:15, Arunpravin Paneer Selvam wrote: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we are sorting each order list entries in as

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Tvrtko Ursulin
On 10/01/2023 11:28, Tvrtko Ursulin wrote: On 09/01/2023 17:27, Jason Ekstrand wrote: [snip] >>> AFAICT it proposes to have 1:1 between *userspace* created     contexts (per >>> context _and_ engine) and drm_sched. I am not sure avoiding     invasive changes >>> to the share

Re: [PATCH v5 0/3] Add PinePhone Pro display support

2023-01-10 Thread Linus Walleij
On Tue, Jan 3, 2023 at 12:07 AM Javier Martinez Canillas wrote: > This series adds support for the display present in the PinePhone Pro. > > Patch #1 adds a devicetree binding schema for panels based on the Himax > HX8394 controller, such as the HSD060BHW4 720x1440 TFT LCD panel present > in the

Re: [RFC PATCH 00/20] Initial Xe driver submission

2023-01-10 Thread Boris Brezillon
+Frank, who's also working on the pvr uAPI. Hi, On Thu, 22 Dec 2022 14:21:07 -0800 Matthew Brost wrote: > The code has been organized such that we have all patches that touch areas > outside of drm/xe first for review, and then the actual new driver in a > separate > commit. The code which is

[PATCH v2] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-10 Thread Thomas Zimmermann
Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") converted nouveau to generic fbdev emulation. The driver's internal implementation later got accidentally restored during a merge commit. Remove the file from the driver. No functional changes. v2: * point Fixes tag to me

Re: [PATCH v5 0/3] Add PinePhone Pro display support

2023-01-10 Thread Javier Martinez Canillas
Hello Linus, On 1/10/23 13:30, Linus Walleij wrote: > On Tue, Jan 3, 2023 at 12:07 AM Javier Martinez Canillas > wrote: > >> This series adds support for the display present in the PinePhone Pro. >> >> Patch #1 adds a devicetree binding schema for panels based on the Himax >> HX8394 controller,

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andrzej Hajda
On 10.01.2023 12:07, Andy Shevchenko wrote: On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: This patch tries to show usability of __xchg helper. It is not intended to be merged, but I can convert it to proper patchset if necessary. There are many more places where __xchg can be u

Re: [PATCH v2] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-10 Thread Javier Martinez Canillas
Hello Thomas, On 1/10/23 13:35, Thomas Zimmermann wrote: > Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") > converted nouveau to generic fbdev emulation. The driver's internal > implementation later got accidentally restored during a merge commit. > Remove the file from the d

Re: [PATCH v2] drm/nouveau: Remove file nouveau_fbcon.c

2023-01-10 Thread Thomas Zimmermann
Am 10.01.23 um 13:49 schrieb Javier Martinez Canillas: Hello Thomas, On 1/10/23 13:35, Thomas Zimmermann wrote: Commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") converted nouveau to generic fbdev emulation. The driver's internal implementation later got accidentally restor

Re: [RFC 3/3] drm: Update file owner during use

2023-01-10 Thread Tvrtko Ursulin
On 06/01/2023 18:00, Daniel Vetter wrote: On Fri, Jan 06, 2023 at 03:53:13PM +0100, Christian König wrote: Am 06.01.23 um 11:53 schrieb Daniel Vetter: On Fri, Jan 06, 2023 at 11:32:17AM +0100, Christian König wrote: Am 05.01.23 um 13:32 schrieb Daniel Vetter: [SNIP] For the case of an mast

Re: [PATCH][next] habanalabs: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Oded Gabbay
On Tue, Jan 10, 2023 at 12:46 PM Stanislaw Gruszka wrote: > > On Mon, Jan 09, 2023 at 07:39:47PM -0600, Gustavo A. R. Silva wrote: > > Zero-length arrays are deprecated[1] and we are moving towards > > adopting C99 flexible-array members instead. So, replace zero-length > > arrays in a couple of s

Re: [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Rafael J. Wysocki
On Monday, January 9, 2023 9:57:21 PM CET Hans de Goede wrote: > The Dell Latitude E6430 both with and without the optional NVidia dGPU > has a bug in its ACPI tables which is causing Linux to assign the wrong > ACPI fwnode / companion to the pci_device for the i915 iGPU. > > Specifically under th

Re: [Intel-gfx] [RFC DO NOT MERGE] treewide: use __xchg in most obvious places

2023-01-10 Thread Andy Shevchenko
On Tue, Jan 10, 2023 at 01:46:37PM +0100, Andrzej Hajda wrote: > On 10.01.2023 12:07, Andy Shevchenko wrote: > > On Tue, Jan 10, 2023 at 11:53:06AM +0100, Andrzej Hajda wrote: ... > > > + return __xchg(&p_chain->p_prod_elem, > > > + (void *)(((u8 *)p_chain->p_prod_elem) + > > > p_c

Re: [PATCH v3 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-10 Thread Rob Herring
On Mon, Jan 9, 2023 at 8:30 AM Rob Herring wrote: > > > On Mon, 09 Jan 2023 11:15:19 +0100, Neil Armstrong wrote: > > Document the MDSS hardware found on the Qualcomm SM8550 platform. > > > > Reviewed-by: Krzysztof Kozlowski > > Signed-off-by: Neil Armstrong > > --- > > .../bindings/display/msm

Re: [PATCH 2/2] drm/debugfs: add descriptions to struct parameters

2023-01-10 Thread Maíra Canal
On 1/5/23 16:30, Maíra Canal wrote: The structs drm_debugfs_info and drm_debugfs_entry don't have descriptions for their parameters, which is causing the following warnings: include/drm/drm_debugfs.h:93: warning: Function parameter or member 'name' not described in 'drm_debugfs_info' include/drm

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Jason Ekstrand
On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > [snip] > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > contexts (per > > >>> context _and_ engine) and drm_sched. I am

Re: [PATCH v3 0/3] Add generic framebuffer support to EFI earlycon driver

2023-01-10 Thread Ard Biesheuvel
On Wed, 28 Dec 2022 at 15:04, Andy Shevchenko wrote: > > On Fri, Dec 23, 2022 at 03:42:33PM +0100, Ard Biesheuvel wrote: > > (cc Andy) > > I believe there are two reasons I'm Cc'ed now: > - the Cc was forgotten. because I remember reviewing some parts > of this contribution > - this conflicts (t

Re: [PATCH v3 0/3] Add generic framebuffer support to EFI earlycon driver

2023-01-10 Thread Ard Biesheuvel
On Fri, 23 Dec 2022 at 15:58, Markuss Broks wrote: > > Hi Ard, > > On 12/23/22 16:42, Ard Biesheuvel wrote: > > (cc Andy) > > > > > > On Wed, 21 Dec 2022 at 11:54, Markuss Broks wrote: > >> Make the EFI earlycon driver be suitable for any linear framebuffers. > >> This should be helpful for early

Re: [PATCH v5 3/7] accel/ivpu: Add GEM buffer object management

2023-01-10 Thread Oded Gabbay
On Mon, Jan 9, 2023 at 2:24 PM Jacek Lawrynowicz wrote: > > Adds four types of GEM-based BOs for the VPU: > - shmem > - userptr > - internal > - prime > > All types are implemented as struct ivpu_bo, based on > struct drm_gem_object. VPU address is allocated when buffer is created > except

Re: [PATCH 1/2] drm/imx/dcss: Drop if blocks with always false condition

2023-01-10 Thread Laurentiu Palcu
Hi, On Fri, Dec 30, 2022 at 02:00:24PM +0100, Uwe Kleine-König wrote: > dcss_drv_platform_remove() is only called for a device after > dcss_drv_platform_probe() returned 0. In that case dev_set_drvdata() was > called with a non-NULL value and so dev_get_drvdata() won't return NULL. > > Signed-off

Re: [PATCH 2/2] drm/imx/dcss: Don't call dev_set_drvdata(..., NULL);

2023-01-10 Thread Laurentiu Palcu
Hi, On Fri, Dec 30, 2022 at 02:00:25PM +0100, Uwe Kleine-König wrote: > The driver core takes care about removing driver data, so this can be > dropped from the driver. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thanks, laurentiu > --- > driver

Re: [PATCH v6 00/10] drm: Remove usage of deprecated DRM_* macros

2023-01-10 Thread Simon Ser
I pushed the last 3 patches to drm-misc-next.

[PATCH 1/2] drm: Add DRM-managed alloc_workqueue() and alloc_ordered_workqueue()

2023-01-10 Thread Jiasheng Jiang
Add drmm_alloc_workqueue() and drmm_alloc_ordered_workqueue(), the helpers that provide managed workqueue cleanup. The workqueue will be destroyed with the final reference of the DRM device. Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/drm_managed.c | 66 +++

Re: [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-10 Thread Arunpravin Paneer Selvam
Hi Matthew, On 1/10/2023 5:32 PM, Matthew Auld wrote: On 07/01/2023 15:15, Arunpravin Paneer Selvam wrote: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The a

Re: [PATCH v3 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-10 Thread Dmitry Baryshkov
On 10/01/2023 15:54, Rob Herring wrote: On Mon, Jan 9, 2023 at 8:30 AM Rob Herring wrote: On Mon, 09 Jan 2023 11:15:19 +0100, Neil Armstrong wrote: Document the MDSS hardware found on the Qualcomm SM8550 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bi

Re: [PATCH] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Hans de Goede
Hi Rafael, On 1/10/23 14:33, Rafael J. Wysocki wrote: > On Monday, January 9, 2023 9:57:21 PM CET Hans de Goede wrote: >> The Dell Latitude E6430 both with and without the optional NVidia dGPU >> has a bug in its ACPI tables which is causing Linux to assign the wrong >> ACPI fwnode / companion to

[PATCH 2/2] drm/i915: Replace alloc*workqueue with DRM helpers

2023-01-10 Thread Jiasheng Jiang
Replace alloc*workqueue with DRM helpers in order to avoid memory leak. Moreover, check the return value since the workqueue may be NULL and cause NULL pointer dereference. Fixes: c26a058680dc ("drm/i915: Use a high priority wq for nonblocking plane updates") Fixes: 757fffcfdffb ("drm/i915: Put a

[PATCH v2] ACPI: Fix selecting the wrong ACPI fwnode for the iGPU on some Dell laptops

2023-01-10 Thread Hans de Goede
The Dell Latitude E6430 both with and without the optional NVidia dGPU has a bug in its ACPI tables which is causing Linux to assign the wrong ACPI fwnode / companion to the pci_device for the i915 iGPU. Specifically under the PCI root bridge there are these 2 ACPI Device()s : Scope (_SB.PCI0)

Re: [PATCH v2 RESEND] adreno: Shutdown the GPU properly

2023-01-10 Thread Rob Clark
On Mon, Jan 9, 2023 at 2:25 PM Joel Fernandes (Google) wrote: > > During kexec on ARM device, we notice that device_shutdown() only calls > pm_runtime_force_suspend() while shutting down the GPU. This means the GPU > kthread is still running and further, there maybe active submits. > > This causes

Re: [PATCH v5 5/7] accel/ivpu: Implement firmware parsing and booting

2023-01-10 Thread Oded Gabbay
On Mon, Jan 9, 2023 at 2:24 PM Jacek Lawrynowicz wrote: > > Read, parse and boot VPU firmware image. > > Co-developed-by: Andrzej Kacprowski > Signed-off-by: Andrzej Kacprowski > Co-developed-by: Krystian Pradzynski > Signed-off-by: Krystian Pradzynski > Signed-off-by: Jacek Lawrynowicz > ---

Re: [PATCH] drm/i915: Add missing check and destroy for alloc_workqueue

2023-01-10 Thread Jiasheng Jiang
On Sat, Jan 07, 2023 at 02:29:22AM +0800, Daniel Vetter wrote: >On Fri, Jan 06, 2023 at 05:09:34PM +0800, Jiasheng Jiang wrote: >> Add checks for the return value of alloc_workqueue and >> alloc_ordered_workqueue as they may return NULL pointer and cause NULL >> pointer dereference. >> Moreover, de

Re: [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-10 Thread Matthew Auld
On 10/01/2023 12:02, Matthew Auld wrote: On 07/01/2023 15:15, Arunpravin Paneer Selvam wrote: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we

Re: [PATCH] drm/amd/display: No need for Null pointer check before kfree

2023-01-10 Thread Rodrigo Siqueira Jordao
On 12/27/22 13:39, Deepak R Varma wrote: kfree() & vfree() internally performs NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin wrote: > > On 10/01/2023 11:28, Tvrtko Ursulin wrote: > > > > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > > > [snip] > > > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > >     contexts (per > > >

Re: [PATCH] drm/amd/display: Fix set scaling doesn's work

2023-01-10 Thread Rodrigo Siqueira Jordao
On 11/22/22 06:20, hongao wrote: [Why] Setting scaling does not correctly update CRTC state. As a result dc stream state's src (composition area) && dest (addressable area) was not calculated as expected. This causes set scaling doesn's work. [How] Correctly update CRTC state when setting sca

Re: [PATCH v4] drm/i915: Do not cover all future platforms in TLB invalidation

2023-01-10 Thread Matt Roper
On Tue, Jan 10, 2023 at 11:35:33AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Revert to the original explicit approach and document the reasoning > behind it. > > v2: > * DG2 needs to be covered too. (Matt) > > v3: > * Full version check for Gen12 to avoid catching all future pla

next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Naresh Kamboju
[ please ignore this email if this regression already reported ] Today's Linux next tag next-20230110 boot passes with defconfig but boot fails with defconfig + kselftest merge config on arm64 devices and qemu-arm64. Reported-by: Linux Kernel Functional Testing We are bisecting this pr

Re: [PATCH 1/2] backlight: pwm_bl: configure pwm only once per backlight toggle

2023-01-10 Thread Daniel Thompson
On Mon, Jan 09, 2023 at 09:47:57PM +0100, Uwe Kleine-König wrote: > When the function pwm_backlight_update_status() was called with > brightness > 0, pwm_get_state() was called twice (once directly and once > in compute_duty_cycle). Also pwm_apply_state() was called twice (once in > pwm_backlight_p

Re: [PATCH 2/2] backlight: pwm_bl: Don't disable the PWM to disable the backlight

2023-01-10 Thread Daniel Thompson
On Mon, Jan 09, 2023 at 09:47:58PM +0100, Uwe Kleine-König wrote: > Most but not all PWMs drive the PWM pin to its inactive state when > disabled. Rely on the lowlevel PWM implementation to implement > duty_cycle = 0 in an energy efficient way and don't disable the PWM. I'm a little worried about

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-10 Thread Dmitry Baryshkov
On 10/01/2023 08:57, Laurentiu Palcu wrote: Hi, On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: Hi, On 09/01/2023 18:21, Laurentiu Palcu wrote: Hi Dmitry, It looks like there are some issues with this patchset... :/ I just fetched the drm-tip and, with these patches include

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Will Deacon
[+ James and Nathan] On Tue, Jan 10, 2023 at 09:44:40PM +0530, Naresh Kamboju wrote: > [ please ignore this email if this regression already reported ] > > Today's Linux next tag next-20230110 boot passes with defconfig but > boot fails with > defconfig + kselftest merge con

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Matthew Brost
On Tue, Jan 10, 2023 at 11:28:08AM +, Tvrtko Ursulin wrote: > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > [snip] > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > contexts (per > > >>> context _and_ engine) and drm_sched. I am not sure avoiding >

[linux-next:master] BUILD REGRESSION 435bf71af3a0aa8067f3b87ff9febf68b564dbb6

2023-01-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 435bf71af3a0aa8067f3b87ff9febf68b564dbb6 Add linux-next specific files for 20230110 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202301102024.acwvrffq-...@intel.com Error

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Arnd Bergmann
On Tue, Jan 10, 2023, at 17:14, Naresh Kamboju wrote: > [ please ignore this email if this regression already reported ] > > Today's Linux next tag next-20230110 boot passes with defconfig but > boot fails with > defconfig + kselftest merge config on arm64 devices and qemu-ar

[PATCH][next] drm/i915/guc: Replace zero-length arrays with flexible-array members

2023-01-10 Thread Gustavo A. R. Silva
Zero-length arrays are deprecated[1] and we are moving towards adopting C99 flexible-array members, instead. So, replace zero-length arrays in a couple of structures (three, actually) with flex-array members. This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() an

Re: next-20230110: arm64: defconfig+kselftest config boot failed - Unable to handle kernel paging request at virtual address fffffffffffffff8

2023-01-10 Thread Mark Brown
On Tue, Jan 10, 2023 at 04:32:59PM +, Will Deacon wrote: > On Tue, Jan 10, 2023 at 09:44:40PM +0530, Naresh Kamboju wrote: > > GOOD: next-20230109 (defconfig + kselftests configs) > > BAD: next-20230110 (defconfig + kselftests configs) > I couldn't find a kselfte

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Tvrtko Ursulin
On 10/01/2023 15:55, Matthew Brost wrote: On Tue, Jan 10, 2023 at 12:19:35PM +, Tvrtko Ursulin wrote: On 10/01/2023 11:28, Tvrtko Ursulin wrote: On 09/01/2023 17:27, Jason Ekstrand wrote: [snip] >>> AFAICT it proposes to have 1:1 between *userspace* created     contexts (per

Re: [PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-10 Thread Bjorn Andersson
On Mon, Jan 02, 2023 at 04:18:26PM +0530, Akhil P Oommen wrote: > > This is a rework of [1] using genpd instead of 'reset' framework. > > As per the recommended reset sequence of Adreno gpu, we should ensure that > gpucc-cx-gdsc has collapsed at hardware to reset gpu's internal hardware > states

Re: (subset) [PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-10 Thread Bjorn Andersson
On Mon, 2 Jan 2023 16:18:26 +0530, Akhil P Oommen wrote: > This is a rework of [1] using genpd instead of 'reset' framework. > > As per the recommended reset sequence of Adreno gpu, we should ensure that > gpucc-cx-gdsc has collapsed at hardware to reset gpu's internal hardware > states. > Becaus

Re: [PATCH 1/2] backlight: pwm_bl: configure pwm only once per backlight toggle

2023-01-10 Thread Uwe Kleine-König
Hello Daniel, On Tue, Jan 10, 2023 at 04:17:16PM +, Daniel Thompson wrote: > On Mon, Jan 09, 2023 at 09:47:57PM +0100, Uwe Kleine-König wrote: > > When the function pwm_backlight_update_status() was called with > > brightness > 0, pwm_get_state() was called twice (once directly and once > > in

Re: [PATCH 2/2] backlight: pwm_bl: Don't disable the PWM to disable the backlight

2023-01-10 Thread Uwe Kleine-König
Hello Daniel, On Tue, Jan 10, 2023 at 04:26:14PM +, Daniel Thompson wrote: > On Mon, Jan 09, 2023 at 09:47:58PM +0100, Uwe Kleine-König wrote: > > Most but not all PWMs drive the PWM pin to its inactive state when > > disabled. Rely on the lowlevel PWM implementation to implement > > duty_cycl

Re: [PATCH] drm: Drop ARCH_MULTIPLATFORM from dependencies

2023-01-10 Thread Javier Martinez Canillas
On 12/10/22 10:21, Uwe Kleine-König wrote: > Hello Arnd, > > On Fri, Dec 09, 2022 at 11:53:49PM +0100, Arnd Bergmann wrote: >> On Fri, Dec 9, 2022, at 23:05, Uwe Kleine-König wrote: >>> Some of these dependencies used to be sensible when only a small part of >>> the platforms supported by ARCH=arm

Re: [PATCH 2/2] backlight: pwm_bl: Don't disable the PWM to disable the backlight

2023-01-10 Thread Daniel Thompson
On Tue, Jan 10, 2023 at 06:35:00PM +0100, Uwe Kleine-König wrote: > Hello Daniel, > > On Tue, Jan 10, 2023 at 04:26:14PM +, Daniel Thompson wrote: > > On Mon, Jan 09, 2023 at 09:47:58PM +0100, Uwe Kleine-König wrote: > > > Most but not all PWMs drive the PWM pin to its inactive state when > > >

  1   2   >