Re: [PATCH] fbdev: Replace 0-length array with flexible array

2023-01-09 Thread Helge Deller
On 1/5/23 20:20, Kees Cook wrote: Zero-length arrays are deprecated[1]. Replace struct aperture's "ranges" 0-length array with a flexible array. (How is the size of this array verified?) Detected with GCC 13, using -fstrict-flex-arrays=3: samples/vfio-mdev/mdpy-fb.c: In function 'mdpy_fb_probe':

Re: [PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-09 Thread Helge Deller
On 1/5/23 10:40, xurui wrote: drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] Signed-off-by: xurui applied. Thanks! Helge --- drivers/video/fbdev/g364fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2023-01-09 Thread Thomas Zimmermann
Hi, what's the status here. The patch apparently never made it into our repos? Best regards Thomas Am 07.12.22 um 18:29 schrieb Zack Rusin: From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver cr

Re: [PATCH 1/6] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
On 09/01/2023 00:09, Dmitry Baryshkov wrote: On 06/01/2023 17:41, Krzysztof Kozlowski wrote: On 04/01/2023 10:08, Neil Armstrong wrote: Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong ---   Documentation/d

Re: [PATCH v2 6/8] drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc

2023-01-09 Thread Marijn Suijten
On 2023-01-09 01:31:57, Dmitry Baryshkov wrote: > On 22/12/2022 01:19, Marijn Suijten wrote: > > Downstream calls this num_enc yet the DSC patches introduced a new > > num_dsc struct member, leaving num_enc effectively unused. > > > > Fixes: 7e9cc175b159 ("drm/msm/disp/dpu1: Add support for DSC in

Re: [PATCH v2 4/8] drm/msm/dpu: Disallow unallocated resources to be returned

2023-01-09 Thread Marijn Suijten
On 2023-01-09 01:30:29, Dmitry Baryshkov wrote: > On 09/01/2023 01:28, Dmitry Baryshkov wrote: > > On 22/12/2022 01:19, Marijn Suijten wrote: > >> In the event that the topology requests resources that have not been > >> created by the system (because they are typically not represented in > >> dpu_

Re: [PATCH] drm/msm/dpu: sort entries in the HW catalog

2023-01-09 Thread Marijn Suijten
On 2023-01-08 23:11:13, Dmitry Baryshkov wrote: > Different entries into the catalog were added quite randomly. Enforce > the sorting order of some kind. It is not alphabetic to prevent the > patch from growing uncontrollably. Why not sort these chronologically based on DPU hardware revision in th

Re: [PATCH RFC 1/4] drm/panfrost: Provide a dummy show_fdinfo() implementation

2023-01-09 Thread Boris Brezillon
Hi Daniel, On Thu, 5 Jan 2023 16:31:49 +0100 Daniel Vetter wrote: > On Wed, Jan 04, 2023 at 02:03:05PM +0100, Boris Brezillon wrote: > > Provide a dummy show_fdinfo() implementation exposing drm-driver and > > drm-client-id. More stats will be added soon. > > > > Signed-off-by: Boris Brezillon

Re: [PATCH v8 7/9] dt/bindings: display: bridge: it6505: Add mode-switch support

2023-01-09 Thread Pin-yen Lin
Hi Krzysztof, Thanks for your review. On Sun, Jan 8, 2023 at 10:59 PM Krzysztof Kozlowski wrote: > > On 07/01/2023 11:22, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or

[PATCH v9 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-09 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. The first two patch modifies fwnode_graph_devcon_matches and cros_typec_init_ports to enable the registration of the switches.

[PATCH v9 1/9] device property: Add remote endpoint to devcon matcher

2023-01-09 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices. Th

[PATCH v9 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-09 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v9 3/9] drm/display: Add Type-C switch helpers

2023-01-09 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Device Tree. Signed-off-by: Pin-yen Lin --

[PATCH v9 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-09 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Als

[PATCH v9 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-09 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port endpo

[PATCH v9 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-09 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Signed-off-by: Pin-yen Lin --- (no changes since v7) Changes in v7: - Fixed sty

[PATCH v9 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-01-09 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Signed

[PATCH v9 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-09 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin --- (no changes since v7) Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig

[PATCH v9 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-09 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by: P

[PATCH v2 0/2] drm/panel: add support for the Visionox VTDR6130 AMOLED DSI panel

2023-01-09 Thread Neil Armstrong
Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed streams, but can work in uncompressed video mode since 1080x2400 in RGB888 fits in the 4 DSI lanes bandwidth. While display c

[PATCH v2 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-09 Thread Neil Armstrong
Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MTP board. By default the the panel is configured to work with DSI compressed streams, but can work in uncompressed video mode since 1080x2400 in RGB888 fits in the 4 DSI lanes bandwidth. While display c

[PATCH v2 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

2023-01-09 Thread Neil Armstrong
Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. Signed-off-by: Neil Armstrong Reviewed-by: Sam Ravnborg Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/panel/visionox,vtdr6130.yaml | 53 ++ 1 file changed, 53 insertions(+) diff --git a/Docum

Re: [PATCH v2 4/8] drm/msm/dpu: Disallow unallocated resources to be returned

2023-01-09 Thread Dmitry Baryshkov
On Mon, 9 Jan 2023 at 10:24, Marijn Suijten wrote: > > On 2023-01-09 01:30:29, Dmitry Baryshkov wrote: > > On 09/01/2023 01:28, Dmitry Baryshkov wrote: > > > On 22/12/2022 01:19, Marijn Suijten wrote: > > >> In the event that the topology requests resources that have not been > > >> created by the

Re: [PATCH v2 6/8] drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc

2023-01-09 Thread Dmitry Baryshkov
On Mon, 9 Jan 2023 at 10:21, Marijn Suijten wrote: > > On 2023-01-09 01:31:57, Dmitry Baryshkov wrote: > > On 22/12/2022 01:19, Marijn Suijten wrote: > > > Downstream calls this num_enc yet the DSC patches introduced a new > > > num_dsc struct member, leaving num_enc effectively unused. > > > > >

Re: [PATCH v2] drm/msm/dsi: Add missing check for alloc_ordered_workqueue

2023-01-09 Thread Dmitry Baryshkov
On Mon, 9 Jan 2023 at 04:51, Jiasheng Jiang wrote: > > Add check for the return value of alloc_ordered_workqueue as it may return > NULL pointer and cause NULL pointer dereference. > Moreover, change the "goto fail" into "return ret" and drop the "fail" > label since they are the same. > > Signed-

Re: [RFC] TTM shrinking revisited

2023-01-09 Thread Thomas Hellström
Hi, Christian, Thanks for the feedback. Some additional inline comments and questions: On 1/4/23 11:31, Christian König wrote: Am 30.12.22 um 12:11 schrieb Thomas Hellström: Hi, Christian, others. I'm starting to take a look at the TTM shrinker again. We'll probably be needing it at least for

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Jani Nikula
On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > The atmel_lcdfb had code to save/restore power state. > This is not needed so drop it. > > Introduce backlight_is_brightness() to make logic simpler. backlight_is_brightness? BR, Jani. > > Signed-off

RE: [PATCH v6 00/19] Add RZ/G2L Display support

2023-01-09 Thread Biju Das
Hi Laurent and DRM folks, Gentle ping for review. Cheers, Biju > -Original Message- > From: Biju Das > Sent: 23 November 2022 17:29 > To: David Airlie ; Daniel Vetter ; Rob > Herring ; Krzysztof Kozlowski > Cc: Biju Das ; Laurent Pinchart > ; dri- > de...@lists.freedesktop.org; devicet

Re: [PATCH 1/2] drm/debugfs: use octal permissions instead of symbolic permissions

2023-01-09 Thread Jani Nikula
On Thu, 05 Jan 2023, Maíra Canal wrote: > Currently, debugfs functions are using symbolic macros as permission > bits, but checkpatch reinforces permission bits in the octal form, as > they are more readable and easier to understand [1]. > > Therefore, use octal permission bits in all debugfs func

Re: [PATCH] drm/msm/dpu: sort entries in the HW catalog

2023-01-09 Thread Dmitry Baryshkov
On Mon, 9 Jan 2023 at 10:34, Marijn Suijten wrote: > > On 2023-01-08 23:11:13, Dmitry Baryshkov wrote: > > Different entries into the catalog were added quite randomly. Enforce > > the sorting order of some kind. It is not alphabetic to prevent the > > patch from growing uncontrollably. > > Why no

Re: [PATCH RFC v7 08/23] dept: Apply sdt_might_sleep_strong() to PG_{locked,writeback} wait

2023-01-09 Thread Sergey Shtylyov
On 1/9/23 6:33 AM, Byungchul Park wrote: > Makes Dept able to track dependencies by PG_{locked,writeback} waits. > > Signed-off-by: Byungchul Park > --- > mm/filemap.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/mm/filemap.c b/mm/filemap.c > index c4d4ace..b013a5b 100

[PATCH v2 0/7] drm/msm: add support for SM8550

2023-01-09 Thread Neil Armstrong
This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is based on the SM8450 display support serie at [1]. In order to work, the following patchsets are required: - PM8550 LDO fix at [2] - DISPCC driver at [3] + the DT changes. [1] https://lore.kernel.org/all/20

[PATCH v2 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v2 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

[PATCH v2 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Neil Armstrong
Document the DPU hardware found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + 1 file changed, 134 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-dpu.yaml b

[PATCH v2 7/7] drm/msm/dsi: add support for DSI 2.7.0

2023-01-09 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

[PATCH v2 4/7] drm/msm/dpu: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/

[PATCH v2 5/7] drm/msm: mdss: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index f9ef5085041d..02646e4bb4c

[PATCH v2 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Neil Armstrong
Document the MDSS hardware found on the Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 1 file changed, 331 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8550-mdss.yaml

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-09 Thread Michel Dänzer
On 1/5/23 16:16, Yi Xie wrote: > On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: >> >> Ah ok. For next time around, copy a link to the comment you want, e.g. >> >> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5830#note_582477 >> >> The 3 dots menu on each comments has an option t

Re: [PATCH v2 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
On 09/01/2023 10:26, Neil Armstrong wrote: SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +-

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread Jani Nikula
On Fri, 06 Jan 2023, John Harrison wrote: > On 12/6/2022 03:06, Tvrtko Ursulin wrote: >> On 05/12/2022 18:44, Michal Wajdeczko wrote: >>> On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] > Random meaningless (to me) message that is appa

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2023-01-09 Thread Tvrtko Ursulin
On 06/01/2023 18:57, John Harrison wrote: On 12/6/2022 03:06, Tvrtko Ursulin wrote: On 05/12/2022 18:44, Michal Wajdeczko wrote: On 05.12.2022 14:16, Tvrtko Ursulin wrote: On 02/12/2022 20:14, John Harrison wrote: [snip] Random meaningless (to me) message that is apparently a display thing

Re: [PATCH v2 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 10:26, Neil Armstrong wrote: > Document the SM8550 DSI PHY which is very close from the 7nm > and 5nm DSI PHYs found in earlier platforms. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 10:26, Neil Armstrong wrote: > Document the DPU hardware found on the Qualcomm SM8550 platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 > + > 1 file changed, 134 insertions(+) Reviewed-by: Krzysztof

Re: [PATCH v9 1/9] device property: Add remote endpoint to devcon matcher

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > From: Prashant Malani > > When searching the device graph for device matches, check the > remote-endpoint itself for a match. > > Some drivers register devices for individual endpoints. This allows > the matcher code to evaluate those for a ma

Re: [PATCH v2 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 10:26, Neil Armstrong wrote: > Document the MDSS hardware found on the Qualcomm SM8550 platform. > > Signed-off-by: Neil Armstrong > --- > .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 > + > 1 file changed, 331 insertions(+) > Reviewed-by: Krzysz

Re: [PATCH v9 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > From: Prashant Malani > > When using OF graph, the fw_devlink code will create links between the > individual port driver (cros-ec-typec here) and the parent device for > a Type-C switch (like mode-switch). Since the mode-switch will in turn >

Re: [PATCH v9 4/9] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > Analogix 7625 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by introduc

Re: [PATCH] dt-bindings: display/msm: gpu: add rbcpr clock

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 06:44, Dmitry Baryshkov wrote: > Describe the RBCPR clock used on msm8996 (A530), MSM8998 (A540) and > SDM630/660 (A508/A512). > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 2 ++ Acked-by: Krzysztof Kozlowski Best regards,

Re: [PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-09 Thread Geert Uytterhoeven
Hi Xurui, On Thu, Jan 5, 2023 at 10:45 AM xurui wrote: > drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of > different size [-Werror=int-to-pointer-cast] > > Signed-off-by: xurui Thanks for your patch! > --- a/drivers/video/fbdev/g364fb.c > +++ b/drivers/video/fbdev/g

Re: [PATCH v2 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Dmitry Baryshkov
On Mon, 9 Jan 2023 at 11:38, Neil Armstrong wrote: > > On 09/01/2023 10:26, Neil Armstrong wrote: > > SM8550 use a 4nm DSI PHYs, which share register definitions > > with 7nm DSI PHYs. Rather than duplicating the driver, handle > > 4nm variant inside the common 5+7nm driver. > > > > Signed-off-by:

Re: [PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-09 Thread Geert Uytterhoeven
This time with the new linux-mips mailing list address... On Mon, Jan 9, 2023 at 11:01 AM Geert Uytterhoeven wrote: > > Hi Xurui, > > On Thu, Jan 5, 2023 at 10:45 AM xurui wrote: > > drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of > > different size [-Werror=int-to-po

Re: [PATCH v9 3/9] drm/display: Add Type-C switch helpers

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "data-lanes" properties

Re: [PATCH v9 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > The output port endpoints can be connected to USB-C connectors. > Running drm_of_find_panel_or_bridge() with such endpoints leads to > a continuous return value of -EPROBE_DEFER, even though there is > no panel present. > > To avoid this, check

[PATCH 0/5] drm: Do not include unnecessarily

2023-01-09 Thread Thomas Zimmermann
Remove unnecessary include statements for . I recently changed this header and had to rebuild a good part of DRM. So avoid this by removing the dependency. Some source files require the OF or backlight headers. Include those instead. Thomas Zimmermann (5): drm: Include where needed drm: Don'

[PATCH 1/5] drm: Include where needed

2023-01-09 Thread Thomas Zimmermann
Include in source files that need it. Some of DRM's source code gets the backlight header via drm_crtc_helper.h and , which can leed to unnecessary recompilation. If possible, do not include drm_crtc_helper.h any longer. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp

[PATCH 2/5] drm: Don't include linux/fb.h in drm_crtc_helper.h

2023-01-09 Thread Thomas Zimmermann
Including in drm_crtc_helper.h is not required. Remove the include statement and avoid rebuilding DRM whenever the fbdev header changes. Signed-off-by: Thomas Zimmermann --- include/drm/drm_crtc_helper.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/drm_crtc_helper.h b/includ

[PATCH 4/5] drm/panel: Do not include

2023-01-09 Thread Thomas Zimmermann
Remove unnecessary include statements for . No functional changes. Include where the driver got the header file via . Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 1 - drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1 - drivers/gpu/drm/pa

[PATCH 3/5] drm/amdgpu: Do not include

2023-01-09 Thread Thomas Zimmermann
Remove unnecessary include statements for . No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmg

[PATCH 5/5] drm: Include in drm_modes.c

2023-01-09 Thread Thomas Zimmermann
Include in drm_modes.c for of_property_read_u32(). Until now, the OF header got included via . Also comment on the reason for still including . The header file is still required to get KHZ2PICOS(). The macro is part of the UAPI headers, so it cannot be moved to a less prominent location. Signed-

Re: [PATCH] drm: Alloc high address for drm buddy topdown flag

2023-01-09 Thread Christian König
Am 07.01.23 um 16:15 schrieb Arunpravin Paneer Selvam: As we are observing low numbers in viewperf graphics benchmark, we are strictly not allowing the top down flag enabled allocations to steal the memory space from cpu visible region. The approach is, we are sorting each order list entries in

[PATCH v3 0/7] drm/msm: add support for SM8550

2023-01-09 Thread Neil Armstrong
This adds support for the MDSS/DPU/DSI on the Qualcomm SM8550 platform. This patchset is based on the SM8450 display support serie at [1]. In order to work, the following patchsets are required: - PM8550 LDO fix at [2] - DISPCC driver at [3] + the DT changes. [1] https://lore.kernel.org/all/20

[PATCH v3 1/7] dt-bindings: display/msm: document the SM8550 DSI PHY

2023-01-09 Thread Neil Armstrong
Document the SM8550 DSI PHY which is very close from the 7nm and 5nm DSI PHYs found in earlier platforms. Acked-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentat

[PATCH v3 2/7] dt-bindings: display/msm: document DPU on SM8550

2023-01-09 Thread Neil Armstrong
Document the DPU hardware found on the Qualcomm SM8550 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-dpu.yaml | 134 + 1 file changed, 134 insertions(+) diff --git a/Documentation/devicetree/bindings/d

[PATCH v3 6/7] drm/msm/dsi: add support for DSI-PHY on SM8550

2023-01-09 Thread Neil Armstrong
SM8550 use a 4nm DSI PHYs, which share register definitions with 7nm DSI PHYs. Rather than duplicating the driver, handle 4nm variant inside the common 5+7nm driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/Kconfig | 4 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c |

[PATCH v3 3/7] dt-bindings: display/msm: document MDSS on SM8550

2023-01-09 Thread Neil Armstrong
Document the MDSS hardware found on the Qualcomm SM8550 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Neil Armstrong --- .../bindings/display/msm/qcom,sm8550-mdss.yaml | 331 + 1 file changed, 331 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v3 7/7] drm/msm/dsi: add support for DSI 2.7.0

2023-01-09 Thread Neil Armstrong
Add support for DSI 2.7.0 (block used on sm8550). Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 16 drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c

[PATCH v3 4/7] drm/msm/dpu: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add definitions for the display hardware used on Qualcomm SM8550 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Neil Armstrong --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 197 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + drivers/gpu/drm/msm/

[PATCH v3 5/7] drm/msm: mdss: add support for SM8550

2023-01-09 Thread Neil Armstrong
Add support for the MDSS block on SM8550 platform. Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index f9ef5085041d..02646e4bb4c

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH RESEND 2/4] backlight: arcxcnn: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 05:48:53PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH RESEND 3/4] backlight: ipaq_micro: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 05:48:54PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH RFC 1/4] drm/panfrost: Provide a dummy show_fdinfo() implementation

2023-01-09 Thread Daniel Vetter
On Mon, 9 Jan 2023 at 09:34, Boris Brezillon wrote: > > Hi Daniel, > > On Thu, 5 Jan 2023 16:31:49 +0100 > Daniel Vetter wrote: > > > On Wed, Jan 04, 2023 at 02:03:05PM +0100, Boris Brezillon wrote: > > > Provide a dummy show_fdinfo() implementation exposing drm-driver and > > > drm-client-id. Mo

Re: [PATCH RESEND 4/4] backlight: tosa: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 05:48:55PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH] dt-bindings: display/msm: qcom, sdm845-mdss: document the DP device

2023-01-09 Thread Krzysztof Kozlowski
On 09/01/2023 05:54, Dmitry Baryshkov wrote: > Document the DP controller added to the sdm845 display subsystem. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Krzysztof Kozlow

Re: [GIT PULL] fbdev fixes for v6.2-rc3

2023-01-09 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 11:22, Daniel Vetter wrote: > > On Thu, 5 Jan 2023 at 09:14, Helge Deller wrote: > > > > Hi Linus, > > > > please pull the fbdev driver updates for 6.2-rc3, to receive > > fixes for matroxfb, offb, omapfb and fbmem. > > > > Thanks, > > Helge > > > > > > > > The followin

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 06:43:36PM +0100, Daniel Vetter wrote: > On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > > Instead of retrieving the backlight brightness in struct > > backlight_properties manually, and then checking whether the backlight > > should be on at all, use backlig

Re: [PATCH 1/5] drm: Include where needed

2023-01-09 Thread Christian König
Am 09.01.23 um 11:12 schrieb Thomas Zimmermann: Include in source files that need it. Some of DRM's source code gets the backlight header via drm_crtc_helper.h and , which can leed to unnecessary recompilation. If possible, do not include drm_crtc_helper.h any longer. Signed-off-by: Thomas Zimm

Re: [PATCH 3/5] drm/amdgpu: Do not include

2023-01-09 Thread Christian König
Am 09.01.23 um 11:12 schrieb Thomas Zimmermann: Remove unnecessary include statements for . No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 - drivers/gpu/drm/amd/pm/powerplay/hwmgr

Re: [PATCH 08/15] drm/vc4: hvs: Ignore atomic_flush if we're disabled

2023-01-09 Thread Dave Stevenson
Hi Maxime On Wed, 7 Dec 2022 at 11:55, Maxime Ripard wrote: > > atomic_flush will be called for each CRTC even if they aren't enabled. > > The whole code we have there will thus run without a properly affected > channel, which can then result in all sorts of weird behaviour. > > Signed-off-by: Ma

Re: [PATCH RFC 1/4] drm/panfrost: Provide a dummy show_fdinfo() implementation

2023-01-09 Thread Boris Brezillon
On Mon, 9 Jan 2023 11:17:49 +0100 Daniel Vetter wrote: > On Mon, 9 Jan 2023 at 09:34, Boris Brezillon > wrote: > > > > Hi Daniel, > > > > On Thu, 5 Jan 2023 16:31:49 +0100 > > Daniel Vetter wrote: > > > > > On Wed, Jan 04, 2023 at 02:03:05PM +0100, Boris Brezillon wrote: > > > > Provide a d

[PATCH 0/5] Check for valid framebuffer's format

2023-01-09 Thread Maíra Canal
This series is a follow-up of [1] in which I introduced a check for valid formats on drm_gem_fb_create(). During the discussion, I realized that would be a better idea to put the check inside framebuffer_check() so that it wouldn't be needed to hit any driver-specific code path when the check fails

[PATCH 1/5] drm/framebuffer: Check for valid formats

2023-01-09 Thread Maíra Canal
Currently, framebuffer_check() doesn't check if the pixel format is supported, which can lead to the acceptance of invalid pixel formats e.g. the acceptance of invalid modifiers. Therefore, add a check for valid formats on framebuffer_check(), so that the ADDFB2 IOCTL rejects calls with invalid for

[PATCH 2/5] drm/amdgpu: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on amdgpu's inside helpers. Therefore, remove the redundant framebuffer format check from the amdgpu_display_gem_fb_verify_and_init() function, letting framebuffer_check() perform the fr

[PATCH 3/5] drm/i915: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on i915's inside helpers. Therefore, remove the redundant framebuffer format check from the intel_framebuffer_init() function, letting framebuffer_check() perform the framebuffer validat

[PATCH 4/5] drm/vmwgfx: Remove redundant framebuffer format check

2023-01-09 Thread Maíra Canal
Now that framebuffer_check() verifies that the format is properly supported, there is no need to check it again on vmwgfx's inside helpers. Therefore, remove the redundant framebuffer format check from the vmw_kms_new_framebuffer_surface() and vmw_kms_new_framebuffer_bo() functions, letting frameb

[PATCH 5/5] drm/plane: Unexport drm_any_plane_has_format()

2023-01-09 Thread Maíra Canal
As the format validation is being dealt with exclusively inside framebuffer_check(), there is no need to export the drm_any_plane_has_format() symbol. Therefore, unexport the drm_any_plane_has_format() symbol, reinforcing that format validation is being dealt with by the DRM API. Signed-off-by: M

Re: [PATCH 13/15] backlight: omap1: Use backlight helpers

2023-01-09 Thread Daniel Thompson
On Sat, Jan 07, 2023 at 07:26:27PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > Rework backlight handling to avoid access to the deprecated > backlight_properties.fb_blank member. > > The rework includes removal of get_brightness() operation, > because there was

Re: [PATCH 14/15] backlight: tosa: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Stephen Kitt > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness()

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-09 Thread Daniel Thompson
On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > With all users gone remove the deprecated fb_blank member in > backlight_properties. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Revie

Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-09 Thread Andy Shevchenko
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > Avoiding direct access to backlight_properties.props. > > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only

Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()

2023-01-09 Thread Andy Shevchenko
On Sat, Jan 07, 2023 at 07:26:24PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > Avoiding direct access to backlight_properties.props. > > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only

Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-09 Thread Daniel Thompson
On Sun, Jan 08, 2023 at 09:29:43PM +0100, Sam Ravnborg wrote: > Hi Stephen, > > On Sun, Jan 08, 2023 at 08:28:17PM +0100, Stephen Kitt wrote: > > On Sat, 07 Jan 2023 19:26:23 +0100, Sam Ravnborg via B4 Submission Endpoint > > wrote: > > > > > From: Sam Ravnborg > > > > > > Avoiding direct access

Re: [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time

2023-01-09 Thread AngeloGioacchino Del Regno
Il 06/01/23 04:05, xinlei@mediatek.com ha scritto: From: Xinlei Lee Since the panel spec stipulates that the time from lcm_reset to DSI to send the initial code should be greater than 6ms and less than 40ms, so reduce the delay before sending the initial code and avoid panel exceptions. Fi

Re: [PATCH 1/2] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd

2023-01-09 Thread AngeloGioacchino Del Regno
Il 06/01/23 04:05, xinlei@mediatek.com ha scritto: From: Xinlei Lee According to Figure 16 Turnaround Procedure on page 36 in [1], you can see the status of LP-00 -> LP10 -> LP11. This state can correspond to the state of DSI from LP00 -> LP11 in mtk_dsi_lane_ready function in mtk_dsi.c. L

Re: [PATCH v9 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > relevant port are available in Device Tree. Configure the crosspoint ^ ports > switch based on the entered alternate mode for a specific Type-C > connector. Yo

Re: [PATCH 2/2] drm/debugfs: add descriptions to struct parameters

2023-01-09 Thread Maíra Canal
On 1/6/23 17:19, Daniel Vetter wrote: On Thu, Jan 05, 2023 at 04:30:39PM -0300, Maíra Canal wrote: The structs drm_debugfs_info and drm_debugfs_entry don't have descriptions for their parameters, which is causing the following warnings: include/drm/drm_debugfs.h:93: warning: Function parameter

Re: [PATCH v9 3/9] drm/display: Add Type-C switch helpers

2023-01-09 Thread Chen-Yu Tsai
On Mon, Jan 9, 2023 at 6:10 PM Chen-Yu Tsai wrote: > > On Mon, Jan 9, 2023 at 4:41 PM Pin-yen Lin wrote: > > > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output between two downstream devices. > > > > The helper registers USB Type-C mode

Re: [PATCH v9 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-09 Thread AngeloGioacchino Del Regno
Il 09/01/23 09:41, Pin-yen Lin ha scritto: Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno

  1   2   3   4   >