Re: [PATCH 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-05 Thread Heiko Carstens
On Wed, Jan 04, 2023 at 12:54:18PM -0700, Nathan Chancellor wrote: > Hi all, ... > This series has seen my personal test framework, which tests several different > configurations and architectures, with LLVM tip of tree (16.0.0). I have done > defconfig, allmodconfig, and allnoconfig builds for arm

Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup

2023-01-05 Thread Greg KH
On Wed, Jan 04, 2023 at 08:05:57PM +0200, Dragos-Marian Panait wrote: > > On 04.01.2023 16:48, Greg KH wrote: > > On Wed, Jan 04, 2023 at 09:35:03AM -0500, Alex Deucher wrote: > > > On Wed, Jan 4, 2023 at 8:23 AM Christian König > > > wrote: > > > > Am 04.01.23 um 13:41 schrieb Greg KH: > > > >

[PATCH] drm/vc4: Start console with 32 bpp / 24 depth

2023-01-05 Thread Thomas Zimmermann
Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4-drm gpu: [drm] No compatible format found -

Re: [PATCH] drm/i915/fbc: Avoid full proxy f_ops for FBC debug attributes

2023-01-05 Thread Julia Lawall
> Hi Julia, thanks for helping here. > > So, my question is why this > > make coccicheck M=drivers/gpu/drm/i915/ MODE=context > COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > didn't catch this chunck: > > - debugfs_create_file("i915_fbc_false_color", 0644, parent,

[GIT PULL] fbdev fixes for v6.2-rc3

2023-01-05 Thread Helge Deller
Hi Linus, please pull the fbdev driver updates for 6.2-rc3, to receive fixes for matroxfb, offb, omapfb and fbmem. Thanks, Helge The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2: Linux 6.2-rc1 (2022-12-25 13:41:39 -0800) are available in the Git repository at

Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth

2023-01-05 Thread Thomas Zimmermann
Am 05.01.23 um 09:07 schrieb Thomas Zimmermann: Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error message vc4-drm gpu: [drm] bpp/depth value of 16/24 not supported vc4

Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth

2023-01-05 Thread Maxime Ripard
Hi, On Thu, Jan 05, 2023 at 09:07:34AM +0100, Thomas Zimmermann wrote: > Invoke the generic console emulation with a 32 bits per pixel. The > preferred color depth is 24, so the current value of 16 bpp is too > small. This results in the following error message > > vc4-drm gpu: [drm] bpp/depth va

Re: [PATCH] drm/vc4: Start console with 32 bpp / 24 depth

2023-01-05 Thread Thomas Zimmermann
Hi Am 05.01.23 um 09:36 schrieb Maxime Ripard: Hi, On Thu, Jan 05, 2023 at 09:07:34AM +0100, Thomas Zimmermann wrote: Invoke the generic console emulation with a 32 bits per pixel. The preferred color depth is 24, so the current value of 16 bpp is too small. This results in the following error

Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver

2023-01-05 Thread Neil Armstrong
Hi, On 04/01/2023 19:25, Rayyan Ansari wrote: Hello, I am not a maintainer, but I thought I might give a few comments. Any comment is always welcome ! On 03/01/2023 14:22, Neil Armstrong wrote: Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel found on the Qualcomm SM8550 MT

[PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-05 Thread xurui
drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] Signed-off-by: xurui --- drivers/video/fbdev/g364fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/

[PATCH] fbdev/g364fb: Fix a compilation issue

2023-01-05 Thread xurui
drivers/video/fbdev/g364fb.c:202:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] Signed-off-by: xurui --- drivers/video/fbdev/g364fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/

[PATCH v4] arch: rename all internal names __xchg to __arch_xchg

2023-01-05 Thread Andrzej Hajda
__xchg will be used for non-atomic xchg macro. Signed-off-by: Andrzej Hajda Reviewed-by: Arnd Bergmann --- v2: squashed all arch patches into one v3: fixed alpha/xchg_local, thx to l...@intel.com v4: adjusted indentation (Heiko) --- arch/alpha/include/asm/cmpxchg.h | 10 +- arch/arc

Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

2023-01-05 Thread Neil Armstrong
On 03/01/2023 18:57, Sam Ravnborg wrote: Hi Neil, On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote: Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings. Signed-off-by: Neil Armstrong --- .../bindings/display/panel/visionox,vtdr6130.yaml | 53 +++

Re: [PATCH 3/6] drm/msm/dpu: add support for SM8550

2023-01-05 Thread neil . armstrong
On 04/01/2023 18:48, Dmitry Baryshkov wrote: On Wed, 4 Jan 2023 at 12:08, Neil Armstrong wrote: On 04/01/2023 10:45, Dmitry Baryshkov wrote: On 04/01/2023 11:08, Neil Armstrong wrote: Add definitions for the display hardware used on Qualcomm SM8550 platform. Signed-off-by: Neil Armstrong -

Re: [PULL] drm-misc-fixes

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 08:49:09AM +0100, Maxime Ripard wrote: > Hi Dave, Daniel, > > Here's this week drm-misc-fixes PR > > Maxime > > drm-misc-fixes-2023-01-05: > Several fixes to fix the error path of dma_buf_export, add a missing > structure declaration resulting in a compiler warning, fix t

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-05 Thread Daniel Vetter
Hi Helge On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > On 12/30/22 07:35, Hang Zhang wrote: > > In do_fb_ioctl(), user specified "fb_info" can be freed in the callee > > fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> > > con2fb_release_oldinfo(), this free operation is protected by >

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-05 Thread Maíra Canal
On 1/4/23 18:17, Daniel Vetter wrote: The documentation for struct drm_minor already states this, but that's not always that easy to find. Also due to historical reasons we still have the minor-centric (like drm_debugfs_create_files), but since this is now getting fixed we can put a few more poi

Re: [GIT PULL] fbdev fixes for v6.2-rc3

2023-01-05 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 09:14, Helge Deller wrote: > > Hi Linus, > > please pull the fbdev driver updates for 6.2-rc3, to receive > fixes for matroxfb, offb, omapfb and fbmem. > > Thanks, > Helge > > > > The following changes since commit 1b929c02afd37871d5afb9d498426f83432e71c2: > > Linux 6.

Re: [PATCH v10 00/18] drm: Add Samsung MIPI DSIM bridge

2023-01-05 Thread Jagan Teki
On Wed, Dec 14, 2022 at 6:29 PM Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8M Mini/Nano/Plus. > > Patch 0001 - 0004: adding devm_drm_of_dsi_get_bridge > >

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-05 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 11:21, Daniel Vetter wrote: > > Hi Helge > > On Mon, 2 Jan 2023 at 16:28, Helge Deller wrote: > > > > On 12/30/22 07:35, Hang Zhang wrote: > > > In do_fb_ioctl(), user specified "fb_info" can be freed in the callee > > > fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> >

Re: [GIT PULL] fbdev fixes for v6.2-rc3

2023-01-05 Thread Helge Deller
On 1/5/23 11:22, Daniel Vetter wrote: On Thu, 5 Jan 2023 at 09:14, Helge Deller wrote: Hi Linus, please pull the fbdev driver updates for 6.2-rc3, to receive fixes for matroxfb, offb, omapfb and fbmem. Thanks, Helge The following changes since commit 1b929c02afd37871d5afb9d498426f8343

Re: [GIT PULL] fbdev fixes for v6.2-rc3

2023-01-05 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 11:31, Helge Deller wrote: > > On 1/5/23 11:22, Daniel Vetter wrote: > > On Thu, 5 Jan 2023 at 09:14, Helge Deller wrote: > >> > >> Hi Linus, > >> > >> please pull the fbdev driver updates for 6.2-rc3, to receive > >> fixes for matroxfb, offb, omapfb and fbmem. > >> > >> Tha

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Simon Ser
On Thursday, January 5th, 2023 at 06:23, Yi Xie wrote: > Some libraries including Mesa and virglrenderer require a render node to > fully function. By adding a render node to vkms those libraries will > work properly, supporting use cases like running crosvm with virgl GPU > support via llvmpipe

[GIT PULL - v2] fbdev fixes for v6.2-rc3

2023-01-05 Thread Helge Deller
Hi Linus, please pull the fbdev driver updates for 6.2-rc3, to receive small fixes for matroxfb, offb and omapfb. This is the v2 pull request, in which I dropped one fbmem patch for which Daniel had some concerns... Thanks, Helge The following changes since commit 1b929c02afd37871d5afb9d4

Re: [RFC PATCH v3 0/3] Support for Solid Fill Planes

2023-01-05 Thread Daniel Vetter
On Wed, Jan 04, 2023 at 03:40:33PM -0800, Jessica Zhang wrote: > Introduce and add support for a solid_fill property. When the solid_fill > property is set, and the framebuffer is set to NULL, memory fetch will be > disabled. > > In addition, loosen the NULL FB checks within the atomic commit call

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 02:23:25PM +0900, Yi Xie wrote: > Some libraries including Mesa and virglrenderer require a render node to > fully function. By adding a render node to vkms those libraries will > work properly, supporting use cases like running crosvm with virgl GPU > support via llvmpipe o

[PATCH] drm: msm: Fix error check return value of irq_of_parse_and_map()

2023-01-05 Thread Zhen Ni
The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Signed-off-by: Zhen Ni --- drivers/gpu/drm/msm/dsi/dsi_host.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d

Re: [pull] amdgpu, amdkfd drm-fixes-6.2

2023-01-05 Thread Daniel Vetter
On Wed, Jan 04, 2023 at 10:38:39PM -0500, Alex Deucher wrote: > Hi Dave, Daniel, > > Fixes for 6.2. > > The following changes since commit c8de526215fdab9f2dd0d9675582cf9f1391a919: > > Merge tag 'drm-misc-next-fixes-2023-01-03' of > git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2

Re: Try to address the DMA-buf coherency problem

2023-01-05 Thread Daniel Vetter
On Fri, Dec 02, 2022 at 04:27:08PM +0100, Christian König wrote: > Am 30.11.22 um 11:30 schrieb Daniel Vetter: > > On Fri, Nov 25, 2022 at 11:40:04AM -0500, Nicolas Dufresne wrote: > > > Le mercredi 23 novembre 2022 à 17:33 +0100, Daniel Vetter a écrit : > > > > On Wed, Nov 23, 2022 at 10:33:38AM +

Re: [Linaro-mm-sig] Re: Try to address the DMA-buf coherency problem

2023-01-05 Thread Daniel Vetter
On Fri, Dec 09, 2022 at 12:07:49PM -0500, Alex Deucher wrote: > On Fri, Dec 9, 2022 at 4:32 AM Pekka Paalanen wrote: > > > > On Fri, 9 Dec 2022 17:26:06 +0900 > > Tomasz Figa wrote: > > > > > On Mon, Dec 5, 2022 at 5:29 PM Christian König > > > wrote: > > > > > > > > Hi Tomasz, > > > > > > > >

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Daniel Vetter
On Fri, Dec 16, 2022 at 04:52:14PM +0100, Alexander Potapenko wrote: > On Fri, Dec 16, 2022 at 3:03 PM Tetsuo Handa > wrote: > > > > On 2022/12/15 18:36, Geert Uytterhoeven wrote: > > > The next line is: > > > > > > scr_memsetw(save, erase, array3_size(logo_lines, new_cols, 2)); > > > > >

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-05 Thread Melissa Wen
On 01/04, Daniel Vetter wrote: > The documentation for struct drm_minor already states this, but that's > not always that easy to find. > > Also due to historical reasons we still have the minor-centric (like > drm_debugfs_create_files), but since this is now getting fixed we can > put a few more

Re: [PATCH] drm/fourcc: Document open source user waiver

2023-01-05 Thread Daniel Vetter
Thanks for all the acks, added them all and applied the patch. -Daniel On Fri, Dec 02, 2022 at 02:14:03AM +0100, Bas Nieuwenhuizen wrote: > Acked-by: Bas Nieuwenhuizen > > On Thu, Dec 1, 2022 at 8:47 PM Jason Ekstrand wrote: > > > > Acked-by: Jason Ekstrand > > > > On Thu, Dec 1, 2022 at 4:22

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2023-01-05 Thread Daniel Vetter
On Thu, 8 Dec 2022 at 05:54, Alex Deucher wrote: > > On Wed, Nov 30, 2022 at 6:11 AM Daniel Vetter wrote: > > > > On Fri, Nov 25, 2022 at 02:52:01PM -0300, André Almeida wrote: > > > This patchset adds a udev event for DRM device's resets. > > > > > > Userspace apps can trigger GPU resets by misu

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-05 Thread Rodrigo Vivi
On Wed, Jan 04, 2023 at 10:17:54PM +0100, Daniel Vetter wrote: > The documentation for struct drm_minor already states this, but that's > not always that easy to find. > > Also due to historical reasons we still have the minor-centric (like > drm_debugfs_create_files), but since this is now gettin

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-05 Thread Thorsten Leemhuis
[adding Karol and Lyude to the list of recipients] Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. On 28.12.22 15:49, Diogo Ivo wrote: > Hello, > > Commit 2541626cfb79 breaks GM20B probe with > the following kernel log: Just won

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-05 Thread Dmitry Baryshkov
On 04/01/2023 11:05, Neil Armstrong wrote: On 04/01/2023 08:29, Tomi Valkeinen wrote: On 28/12/2022 23:58, Dmitry Baryshkov wrote: On 02/11/2022 20:06, Dmitry Baryshkov wrote:  From all the drivers using drm_bridge_connector only iMX/dcss and OMAP DRM driver do a proper work of calling drm_bri

Re: [RFC 3/3] drm: Update file owner during use

2023-01-05 Thread Daniel Vetter
On Fri, Dec 02, 2022 at 10:01:01AM +0100, Christian König wrote: > Am 01.12.22 um 12:09 schrieb Tvrtko Ursulin: > > > > On 30/11/2022 14:18, Daniel Vetter wrote: > > > On Wed, Nov 30, 2022 at 01:34:07PM +, Tvrtko Ursulin wrote: > > > > From: Tvrtko Ursulin > > > > > > > > With the typical mo

Re: [PATCH v2 0/6] drm/gud: Use the shadow plane helper

2023-01-05 Thread Daniel Vetter
On Thu, Dec 01, 2022 at 02:32:15PM +, Mark Brown wrote: > On Thu, Dec 01, 2022 at 03:27:32PM +0100, Vlastimil Babka wrote: > > > I usually do that with git send-email and a custom --cc-cmd script, but > > additionally it sends the cover letter also to everyone that's on any > > individual patc

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-05 Thread Jani Nikula
On Wed, 04 Jan 2023, Daniel Vetter wrote: > The documentation for struct drm_minor already states this, but that's > not always that easy to find. > > Also due to historical reasons we still have the minor-centric (like > drm_debugfs_create_files), but since this is now getting fixed we can > put

Re: [RESEND PATCH linux-next v2 00/10] drm: Remove some obsolete drivers(tdfx, mga, i810, savage, r128, sis, via)

2023-01-05 Thread Daniel Vetter
On Thu, Dec 08, 2022 at 08:42:07PM +0800, Cai Huoqing wrote: > On 03 12月 22 18:22:51, Cai Huoqing wrote: > > Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy (UMS) DRM drivers") > > marked these drivers obsolete 7 years ago. > > And the mesa UMD of these drm drivers already in deprecated li

Re: [PATCH v4 1/7] drm/debugfs: create device-centered debugfs functions

2023-01-05 Thread Jani Nikula
On Mon, 19 Dec 2022, Maíra Canal wrote: > @@ -230,6 +247,12 @@ int drm_debugfs_init(struct drm_minor *minor, int > minor_id, > if (dev->driver->debugfs_init) > dev->driver->debugfs_init(minor); > > + list_for_each_entry_safe(entry, tmp, &dev->debugfs_list, list) { > +

Re: [PATCH 2/2] drm_print: fix stale macro-name in comment

2023-01-05 Thread Daniel Vetter
On Mon, Dec 05, 2022 at 09:10:05AM -0700, Jim Cromie wrote: > Cited commit uses stale macro name, fix this, and explain better. > > When DRM_USE_DYNAMIC_DEBUG=y, DYNDBG_CLASSMAP_DEFINE() maps DRM_UT_* > onto BITs in drm.debug. This still uses enum drm_debug_category, but > it is somewhat indirect

Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT

2023-01-05 Thread Daniel Vetter
On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > From: Rob Clark > > In cases where implicit sync is used, it is still useful (for things > like sub-allocation, etc) to allow userspace to opt-out of implicit > sync on per-BO basis. > > Signed-off-by: Rob Clark > --- > drivers/gpu/d

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
> This doesn't sound like a good idea to me. Devices without render > capabilities should not fake it. > > User-space (e.g. wlroots) relies on "no render node" to enable > software rendering (Pixman instead of GL). We have virtgpu driver that exports a render node even when virgl is not supported.

Re: [PATCH v4 1/7] accel/ivpu: Introduce a new DRM driver for Intel VPU

2023-01-05 Thread Daniel Vetter
On Thu, Dec 08, 2022 at 12:07:27PM +0100, Jacek Lawrynowicz wrote: > +static const struct drm_driver driver = { > + .driver_features = DRIVER_GEM | DRIVER_COMPUTE_ACCEL, So I was wondering whether this is a bright idea, and whether we shouldn't just go ahead and infuse more meaning into accel

Re: Driver for CFAF240320X0-020T display

2023-01-05 Thread Fabio Estevam
Hi Noralf, On Fri, Dec 16, 2022 at 9:30 AM Noralf Trønnes wrote: > There is a DRM driver that can be used with all of these controllers: > drivers/gpu/drm/tiny/panel-mipi-dbi.c. It uses a firmware file for the > init commands. > > Binding: > Documentation/devicetree/bindings/display/panel/panel-

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2023-01-05 Thread Daniel Vetter
On Tue, Dec 13, 2022 at 07:17:41PM +0100, Christian König wrote: > Am 13.12.22 um 18:09 schrieb Daniel Vetter: > > On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > > > Hi Christian, > > > > > > On Fri, 9 Dec 2022 at 12:45, Christian König > > > wrote: > > > > The init order and res

Re: [RESEND PATCH linux-next v2 00/10] drm: Remove some obsolete drivers(tdfx, mga, i810, savage, r128, sis, via)

2023-01-05 Thread Thomas Zimmermann
Hi Am 05.01.23 um 13:40 schrieb Daniel Vetter: On Thu, Dec 08, 2022 at 08:42:07PM +0800, Cai Huoqing wrote: On 03 12月 22 18:22:51, Cai Huoqing wrote: Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy (UMS) DRM drivers") marked these drivers obsolete 7 years ago. And the mesa UMD of thes

Re: [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread Daniel Vetter
On Mon, Dec 12, 2022 at 09:38:12AM +, David Laight wrote: > From: Andrzej Hajda > > Sent: 09 December 2022 15:49 > > > > The pattern of setting variable with new value and returning old > > one is very common in kernel. Usually atomicity of the operation > > is not required, so xchg seems to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2023-01-05 Thread Tvrtko Ursulin
On 04/01/2023 17:41, Matt Roper wrote: On Wed, Jan 04, 2023 at 10:08:29AM +, Tvrtko Ursulin wrote: On 03/01/2023 19:57, Matt Roper wrote: On Mon, Dec 19, 2022 at 05:10:02PM +0100, Andrzej Hajda wrote: On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for se

Re: [PATCH v9 08/15] drm/bridge: add psr support for panel bridge callbacks

2023-01-05 Thread Daniel Vetter
On Wed, Dec 14, 2022 at 03:35:45PM +0530, Vinod Polimera wrote: > This change will handle the psr entry exit cases in the panel > bridge atomic callback functions. For example, the panel power > should not turn off if the panel is entering psr. > > Signed-off-by: Sankeerth Billakanti > Signed-off

Re: [PATCH v9 08/15] drm/bridge: add psr support for panel bridge callbacks

2023-01-05 Thread Dmitry Baryshkov
On 05/01/2023 15:11, Daniel Vetter wrote: On Wed, Dec 14, 2022 at 03:35:45PM +0530, Vinod Polimera wrote: This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by:

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Tetsuo Handa
On 2023/01/05 20:54, Daniel Vetter wrote: >>> . Plain memset() in arch/x86/include/asm/string_64.h is redirected to >>> __msan_memset() >>> but memsetXX() are not redirected to __msan_memsetXX(). That is, memory >>> initialization >>> via memsetXX() results in KMSAN's shadow memory being not upda

Re: [PATCH v6 20/45] drm/amd: Parse both v1 and v2 TA microcode headers using same function

2023-01-05 Thread Lazar, Lijo
On 1/5/2023 9:12 AM, Mario Limonciello wrote: Several IP versions duplicate code and can't use the common helpers. Move this code into a single function so that the helpers can be used. Reviewed-by: Alex Deucher Signed-off-by: Mario Limonciello --- v5->v6: * Rebase on earlier patches ---

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 10:17:24PM +0900, Tetsuo Handa wrote: > On 2023/01/05 20:54, Daniel Vetter wrote: > >>> . Plain memset() in arch/x86/include/asm/string_64.h is redirected to > >>> __msan_memset() > >>> but memsetXX() are not redirected to __msan_memsetXX(). That is, memory > >>> initializ

[PATCH v7 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-01-05 Thread Pin-yen Lin
This series introduces bindings for anx7625/it6505 to register Type-C mode-switch in their output endpoints, and use data-lanes property to describe the pin connections. The first two patch modifies fwnode_graph_devcon_matches and cros_typec_init_ports to enable the registration of the switches.

[PATCH v7 1/9] device property: Add remote endpoint to devcon matcher

2023-01-05 Thread Pin-yen Lin
From: Prashant Malani When searching the device graph for device matches, check the remote-endpoint itself for a match. Some drivers register devices for individual endpoints. This allows the matcher code to evaluate those for a match too, instead of only looking at the remote parent devices. Th

[PATCH v7 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-05 Thread Pin-yen Lin
From: Prashant Malani When using OF graph, the fw_devlink code will create links between the individual port driver (cros-ec-typec here) and the parent device for a Type-C switch (like mode-switch). Since the mode-switch will in turn have the usb-c-connector (i.e the child of the port driver) as

[PATCH v7 3/9] drm/display: Add Type-C switch helpers

2023-01-05 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "data-lanes" properties are available in Device Tree. Signed-off-by: Pin-yen Lin --

[PATCH v7 4/9] dt-bindings: drm/bridge: anx7625: Add mode-switch support

2023-01-05 Thread Pin-yen Lin
Analogix 7625 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Als

[PATCH v7 5/9] drm/bridge: anx7625: Check for Type-C during panel registration

2023-01-05 Thread Pin-yen Lin
The output port endpoints can be connected to USB-C connectors. Running drm_of_find_panel_or_bridge() with such endpoints leads to a continuous return value of -EPROBE_DEFER, even though there is no panel present. To avoid this, check for the existence of a "mode-switch" property in the port endpo

[PATCH v7 6/9] drm/bridge: anx7625: Register Type C mode switches

2023-01-05 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the crosspoint switch based on the entered alternate mode for a specific Type-C connector. Signed-off-by: Pin-yen Lin --- Changes in v7: - Fixed style issues in anx7625 dr

[PATCH v7 7/9] dt/bindings: drm/bridge: it6505: Add mode-switch support

2023-01-05 Thread Pin-yen Lin
ITE IT6505 can be used in systems to switch the DP traffic between two downstreams, which can be USB Type-C DisplayPort alternate mode lane or regular DisplayPort output ports. Update the binding to accommodate this usage by introducing a data-lanes and a mode-switch property on endpoints. Signed

[PATCH v7 8/9] drm/bridge: it6505: Fix Kconfig indentation

2023-01-05 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin --- Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridg

[PATCH v7 9/9] drm/bridge: it6505: Register Type C mode switches

2023-01-05 Thread Pin-yen Lin
Register USB Type-C mode switches when the "mode-switch" property and relevant port are available in Device Tree. Configure the "lane_swap" state based on the entered alternate mode for a specific Type-C connector, which ends up updating the lane swap registers of the it6505 chip. Signed-off-by: P

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread Jani Nikula
On Thu, 05 Jan 2023, Daniel Vetter wrote: > On Mon, Dec 12, 2022 at 09:38:12AM +, David Laight wrote: >> From: Andrzej Hajda >> > Sent: 09 December 2022 15:49 >> > >> > The pattern of setting variable with new value and returning old >> > one is very common in kernel. Usually atomicity of th

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2023-01-05 Thread Tvrtko Ursulin
Okay to sum it up below with some final notes.. On 04/01/2023 19:34, Matt Roper wrote: On Wed, Jan 04, 2023 at 09:58:13AM +, Tvrtko Ursulin wrote: On 23/12/2022 18:28, Lucas De Marchi wrote: On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De

Re: [PATCH] drm: document better that drivers shouldn't use drm_minor directly

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 02:39:21PM +0200, Jani Nikula wrote: > On Wed, 04 Jan 2023, Daniel Vetter wrote: > > The documentation for struct drm_minor already states this, but that's > > not always that easy to find. > > > > Also due to historical reasons we still have the minor-centric (like > > drm

RE: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread David Laight
From: Jani Nikula > Sent: 05 January 2023 13:28 > > On Thu, 05 Jan 2023, Daniel Vetter wrote: > > On Mon, Dec 12, 2022 at 09:38:12AM +, David Laight wrote: > >> From: Andrzej Hajda > >> > Sent: 09 December 2022 15:49 > >> > > >> > The pattern of setting variable with new value and returning

dri-devel@lists.freedesktop.org

2023-01-05 Thread Arnd Bergmann
From: Arnd Bergmann Most of the legacy PXA board files were marked as unused in linux-5.19 and can get removed in linux-6.3. There is support for pxa250/pxa270/pxa300 using devicetree already, which supports a number of boards, but progress on converting the remaining ones has stalled over the pa

[PATCH 22/27] fbdev: remove tmiofb driver

2023-01-05 Thread Arnd Bergmann
From: Arnd Bergmann With the TMIO MFD support removed, the framebuffer driver can be removed as well. Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/Kconfig | 22 - drivers/video/fbdev/Makefile |

[PATCH 23/27] fbdev: remove w100fb driver

2023-01-05 Thread Arnd Bergmann
From: Arnd Bergmann The w100fb was used on various PXA based pocketpc machines, all of which are now removed, so remove this dirver sd well. Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Arnd Bergmann --- drivers/video/fbdev/Kconfig | 1

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > This doesn't sound like a good idea to me. Devices without render > > capabilities should not fake it. > > > > User-space (e.g. wlroots) relies on "no render node" to enable > > software rendering (Pixman instead of GL). > > We have virtg

Re: Driver for CFAF240320X0-020T display

2023-01-05 Thread Noralf Trønnes
On 1/5/23 13:57, Fabio Estevam wrote: > Hi Noralf, > > On Fri, Dec 16, 2022 at 9:30 AM Noralf Trønnes wrote: > >> There is a DRM driver that can be used with all of these controllers: >> drivers/gpu/drm/tiny/panel-mipi-dbi.c. It uses a firmware file for the >> init commands. >> >> Binding: >>

Re: [PATCH v3 4/7] drm/imx/dcss: stop using drm_bridge_connector_en/disable_hpd()

2023-01-05 Thread Neil Armstrong
On 02/11/2022 19:07, Dmitry Baryshkov wrote: The functionality of drm_bridge_connector_enable_hpd() and drm_bridge_connector_disable_hpd() is provided automatically by the drm_kms_poll helpers. Stop calling these functions manually. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/imx/dcss

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > This doesn't sound like a good idea to me. Devices without render > > > capabilities should not fake it. > > > > > > User-space (e.g. wlroots) relies on "no render node" to enable

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-05 Thread Neil Armstrong
Hi, On Wed, 02 Nov 2022 21:06:58 +0300, Dmitry Baryshkov wrote: > From all the drivers using drm_bridge_connector only iMX/dcss and OMAP > DRM driver do a proper work of calling > drm_bridge_connector_en/disable_hpd() in right places. Rather than > teaching each and every driver how to properly ha

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 01:34:33PM +, David Laight wrote: > From: Jani Nikula > > Sent: 05 January 2023 13:28 > > > > On Thu, 05 Jan 2023, Daniel Vetter wrote: > > > On Mon, Dec 12, 2022 at 09:38:12AM +, David Laight wrote: > > >> From: Andrzej Hajda > > >> > Sent: 09 December 2022 15:49

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > > This doesn't sound like a good idea to me. Devices without render > > > > capabilities should not fake it. > > > >

Re: [PATCH 12/14] drm/amd/display: Do not add '-mhard-float' to dml_ccflags for clang

2023-01-05 Thread Alex Deucher
On Wed, Jan 4, 2023 at 2:55 PM Nathan Chancellor wrote: > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > warns: > > clang-16: error: argument unused during compilation: '-mhard-float' > [-Werror,-Wunused-command-line-argument] > > Similar to commit 84edc2eff827 ("selfte

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread Tvrtko Ursulin
On 05/01/2023 13:34, David Laight wrote: From: Jani Nikula Sent: 05 January 2023 13:28 On Thu, 05 Jan 2023, Daniel Vetter wrote: On Mon, Dec 12, 2022 at 09:38:12AM +, David Laight wrote: From: Andrzej Hajda Sent: 09 December 2022 15:49 The pattern of setting variable with new value

Re: [PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

2023-01-05 Thread Daniel Vetter
On Tue, Dec 20, 2022 at 08:24:18AM +0100, Thomas Zimmermann wrote: > Hi > > Am 19.12.22 um 19:31 schrieb Uwe Kleine-König: > > There is a local variable that contains dev->driver. Make use of it > > instead of "open coding" it. > > > > Signed-off-by: Uwe Kleine-König > > Added to drm-misc-next.

Re: [PATCH] drm: Add orientation quirk for Lenovo ideapad D330-10IGL

2023-01-05 Thread Daniel Vetter
On Tue, Dec 20, 2022 at 03:58:26PM -0500, Patrick Thompson wrote: > Panel is 800x1280 but mounted on a detachable form factor sideways. > > Signed-off-by: Patrick Thompson Applied to drm-misc-fixes, thanks for your patch. -Daniel > --- > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++

RE: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread David Laight
From: Daniel Vetter > Sent: 05 January 2023 14:13 ... > > > So here we are, with Andrzej looking to add the common helper. And the > > > same concerns crop up. What should it be called to make it clear that > > > it's not atomic? Is that possible? > > > > old_value = read_write(variable, new_value)

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2023-01-05 Thread Sebastian Wick
On Fri, Dec 23, 2022 at 8:10 PM Harry Wentland wrote: > > > > On 12/14/22 04:01, Pekka Paalanen wrote: > > On Tue, 13 Dec 2022 18:20:59 +0100 > > Michel Dänzer wrote: > > > >> On 12/12/22 19:21, Harry Wentland wrote: > >>> This will let us pass kms_hdr.bpc_switch. > >>> > >>> I don't see any good

Re: [PATCH v2 0/8] drm/msm: DSC Electric Boogaloo for sm8[12]50

2023-01-05 Thread Daniel Vetter
On Thu, Dec 22, 2022 at 12:19:35AM +0100, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CT

Re: [RFC PATCH v2 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-05 Thread Sebastian Wick
On Wed, Jan 4, 2023 at 2:10 AM Jessica Zhang wrote: > > > > On 12/22/2022 7:12 PM, Dmitry Baryshkov wrote: > > On 23/12/2022 00:14, Jessica Zhang wrote: > >> Initialize and use the color_fill properties for planes in DPU driver. In > >> addition, relax framebuffer requirements within atomic commit

Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT

2023-01-05 Thread Daniel Vetter
On Thu, 5 Jan 2023 at 15:51, Rob Clark wrote: > > On Thu, Jan 5, 2023 at 4:49 AM Daniel Vetter wrote: > > > > On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > > > From: Rob Clark > > > > > > In cases where implicit sync is used, it is still useful (for things > > > like sub-allocatio

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2023-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2023 at 02:41:43PM +, David Laight wrote: > From: Daniel Vetter > > Sent: 05 January 2023 14:13 > ... > > > > So here we are, with Andrzej looking to add the common helper. And the > > > > same concerns crop up. What should it be called to make it clear that > > > > it's not ato

Re: (subset) [PATCH] drm/bridge: panel: Prevent ERR_PTR Dereference

2023-01-05 Thread Maxime Ripard
On Mon, 02 Jan 2023 13:01:23 +0100, Maxime Ripard wrote: > Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to > drm_panel") introduced an access to the bridge pointer in the > devm_drm_panel_bridge_add_typed() function. > > However, due to the unusual ERR_PTR check when getting that p

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Yi Xie
On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: > > On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xie wrote: > > > > > This doesn't sound like a good idea to me. Device

Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT

2023-01-05 Thread Rob Clark
On Thu, Jan 5, 2023 at 4:49 AM Daniel Vetter wrote: > > On Tue, Dec 06, 2022 at 11:21:23AM -0800, Rob Clark wrote: > > From: Rob Clark > > > > In cases where implicit sync is used, it is still useful (for things > > like sub-allocation, etc) to allow userspace to opt-out of implicit > > sync on p

next: arm64: ERROR: modpost: "kunit_running" [drivers/gpu/drm/vc4/vc4.ko] undefined!

2023-01-05 Thread Naresh Kamboju
** [/builds/linux/scripts/Makefile.modpost:137: Module.symvers] Error 1 make[2]: Target '__modpost' not remade because of errors. make[1]: *** [/builds/linux/Makefile:1967: modpost] Error 2 build log: --- https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230105/testrun

Re: [PATCH] drm/gem: Check for valid formats

2023-01-05 Thread Daniel Vetter
On Tue, Jan 03, 2023 at 02:16:30PM +0100, Thomas Zimmermann wrote: > Hi, > > thanks for the follow-up patch. > > Am 03.01.23 um 13:53 schrieb Maíra Canal: > > Currently, drm_gem_fb_create() doesn't check if the pixel format is > > supported, which can lead to the acceptance of invalid pixel forma

Re: [PATCH] drm/gem: Check for valid formats

2023-01-05 Thread Daniel Vetter
On Tue, Jan 03, 2023 at 09:53:23AM -0300, Maíra Canal wrote: > Currently, drm_gem_fb_create() doesn't check if the pixel format is > supported, which can lead to the acceptance of invalid pixel formats > e.g. the acceptance of invalid modifiers. Therefore, add a check for > valid formats on drm_gem

Re: [PATCH v2] drm/gem: Check for valid formats

2023-01-05 Thread Daniel Vetter
On Tue, Jan 03, 2023 at 03:12:15PM +0100, Thomas Zimmermann wrote: > > > Am 03.01.23 um 14:59 schrieb Maíra Canal: > > Currently, drm_gem_fb_create() doesn't check if the pixel format is > > supported, which can lead to the acceptance of invalid pixel formats > > e.g. the acceptance of invalid mo

Re: [PATCH RFC 1/4] drm/panfrost: Provide a dummy show_fdinfo() implementation

2023-01-05 Thread Daniel Vetter
On Wed, Jan 04, 2023 at 02:03:05PM +0100, Boris Brezillon wrote: > Provide a dummy show_fdinfo() implementation exposing drm-driver and > drm-client-id. More stats will be added soon. > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 17 - > 1 f

Re: [PATCH v7 2/9] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-01-05 Thread Andy Shevchenko
On Thu, Jan 05, 2023 at 09:24:50PM +0800, Pin-yen Lin wrote: > From: Prashant Malani > > When using OF graph, the fw_devlink code will create links between the > individual port driver (cros-ec-typec here) and the parent device for > a Type-C switch (like mode-switch). Since the mode-switch will

Re: [PATCH] drm/vkms: Add a DRM render node to vkms

2023-01-05 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 12:16:07AM +0900, Yi Xie wrote: > On Thu, Jan 5, 2023 at 11:16 PM Daniel Vetter wrote: > > > > On Thu, Jan 05, 2023 at 11:10:23PM +0900, Yi Xie wrote: > > > On Thu, Jan 5, 2023 at 10:48 PM Daniel Vetter wrote: > > > > > > > > On Thu, Jan 05, 2023 at 09:52:26PM +0900, Yi Xi

  1   2   3   >