Re: [RFC PATCH 00/20] Initial Xe driver submission

2023-01-02 Thread Thomas Zimmermann
Hi Am 22.12.22 um 23:21 schrieb Matthew Brost: Hello, This is a submission for Xe, a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake (first platform with Intel Xe Architecture). The intention of this new driver is to have a fresh base to w

Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

2023-01-02 Thread Johan Hovold
On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote: > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote: > > > > The actual name is R133NW4K-R0. > > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry") > > Signed-off-by: Abel Vesa > > --- > > > > Assuming the

Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry

2023-01-02 Thread Johan Hovold
On Sat, Dec 31, 2022 at 04:27:21PM +0200, Abel Vesa wrote: > Add an eDP panel entry for IVO M133NW4J. > > Due to lack of documentation, use the delay_200_500_p2e100 timings like > some other IVO entries for now. > > Signed-off-by: Abel Vesa > --- > > Assuming the information from here is correc

Re: [PATCH v2] arch: rename all internal names __xchg to __arch_xchg

2023-01-02 Thread Geert Uytterhoeven
On Thu, Dec 29, 2022 at 12:34 PM Andrzej Hajda wrote: > __xchg will be used for non-atomic xchg macro. > > Signed-off-by: Andrzej Hajda > Reviewed-by: Arnd Bergmann Acked-by: Geert Uytterhoeven [m68k] Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2023-01-02 Thread Dmitry Osipenko
On 1/1/23 21:29, youling257 wrote: > Linux 6.2-rc1 has memory leak on amdgpu, git bisect bad commit is > "drm/scheduler: rework entity flush, kill and fini". > git bisect start > # status: waiting for both good and bad commits > # good: [eb7081409f94a9a8608593d0fb63a1aa3d6f95d8] Linux 6.1-rc6 > gi

Re: [RFC PATCH 1/7] drm/msm/dpu: Remove unused INTF0 interrupt mask from sm6115/qcm2290

2023-01-02 Thread Konrad Dybcio
On 31.12.2022 22:50, Marijn Suijten wrote: > Neither of these SoCs has INTF0, they only have a DSI interface on index > 1. Stop enabling an interrupt that can't fire. Double space. Reviewed-by: Konrad Dybcio Konrad > > Fixes: 3581b7062cec ("drm/msm/disp/dpu1: add support for display on SM611

Re: [RFC PATCH 3/7] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-01-02 Thread Konrad Dybcio
On 31.12.2022 22:52, Marijn Suijten wrote: > On 2022-12-31 22:50:02, Marijn Suijten wrote: >> Since hardware revision 5.0.0 the TE configuration moved out of the >> PINGPONG block into the INTF block, including vsync source selection >> that was previously part of MDP top. Writing to the MDP_VS

Re: [PATCH v3 01/21] dt-bindings: display: tegra: add Tegra20 VIP

2023-01-02 Thread Krzysztof Kozlowski
On 29/12/2022 14:31, Luca Ceresoli wrote: > VIP is the parallel video capture component within the video input > subsystem of Tegra20 (and other Tegra chips, apparently). > > Signed-off-by: Luca Ceresoli > > --- > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 0/4] Add PinePhone Pro display support

2023-01-02 Thread Javier Martinez Canillas
Hello Pavel, On 1/1/23 22:21, Pavel Machek wrote: > Hi! > >> This series add support for the display present in the PinePhone Pro. >> >> Patch #1 adds a driver for panels using the Himax HX8394 panel controller, >> such as the HSD060BHW4 720x1440 TFT LCD panel present in the PinePhone Pro. >> >>

Re: [PATCH v4 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2023-01-02 Thread Akhil P Oommen
On 12/29/2022 12:13 AM, Bjorn Andersson wrote: > On Wed, Dec 21, 2022 at 10:43:59PM +0530, Akhil P Oommen wrote: >> From: Ulf Hansson >> >> Some genpd providers doesn't ensure that it has turned off at hardware. >> This is fine until the consumer really requires during some special >> scenarios th

Re: [PATCH] drm/meson: Reduce the FIFO lines held when AFBC is not used

2023-01-02 Thread Neil Armstrong
Hi, On Mon, 19 Dec 2022 09:43:05 +0100, Carlo Caione wrote: > Having a bigger number of FIFO lines held after vsync is only useful to > SoCs using AFBC to give time to the AFBC decoder to be reset, configured > and enabled again. > > For SoCs not using AFBC this, on the contrary, is causing on so

Re: [PATCH v2 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2023-01-02 Thread Thomas Zimmermann
Hi Am 21.12.22 um 21:07 schrieb Maíra Canal: On 12/20/22 13:11, Thomas Zimmermann wrote: Add dedicated helper to convert from XRGB to ARGB. Sets all alpha bits to make pixels fully opaque. v2: * use cpubuf_to_le32() * type fixes Signed-off-by: Thomas Zimmermann Review

Re: [PATCH v2 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2023-01-02 Thread Thomas Zimmermann
Hi Am 23.12.22 um 13:44 schrieb José Expósito: Hi Thomas, Compiling this patch with sparse enabled (you can do it from the KUnit tests adding "--make_options C=2") throws a warning: drm_format_helper.c:614:27: warning: incorrect type in assignment (different base types) drm_format_helper.c:61

[PATCH v2] drm/msm/adreno: Make adreno quirks not overwrite each other

2023-01-02 Thread Konrad Dybcio
So far the adreno quirks have all been assigned with an OR operator, which is problematic, because they were assigned consecutive integer values, which makes checking them with an AND operator kind of no bueno.. Switch to using BIT(n) so that only the quirks that the programmer chose are taken int

Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

2023-01-02 Thread Neil Armstrong
Hi, On Mon, 19 Dec 2022 10:02:36 +0100, Carlo Caione wrote: > This patchset is trying to fix problems seen on S905X boards when interfacing > with an ILI9486 equipped SPI panel. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] drm/tiny: ili9486

Re: [RFC PATCH 1/7] drm/msm/dpu: Remove unused INTF0 interrupt mask from sm6115/qcm2290

2023-01-02 Thread Marijn Suijten
On 2023-01-02 10:29:03, Konrad Dybcio wrote: > > > On 31.12.2022 22:50, Marijn Suijten wrote: > > Neither of these SoCs has INTF0, they only have a DSI interface on index > > 1. Stop enabling an interrupt that can't fire. > Double space. In case you hadn't noticed I'm employing this habit for q

Re: [RFC PATCH 3/7] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-01-02 Thread Marijn Suijten
On 2023-01-02 10:30:58, Konrad Dybcio wrote: > > > On 31.12.2022 22:52, Marijn Suijten wrote: > > On 2022-12-31 22:50:02, Marijn Suijten wrote: > >> Since hardware revision 5.0.0 the TE configuration moved out of the > >> PINGPONG block into the INTF block, including vsync source selection > >> t

[PATCH v10 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2023-01-02 Thread Rahul T R
Move the cadence dsi bridge under drm/bridge/cadence directory, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/Kconfig| 11 --- drivers/gpu/drm/bridge/Makefile | 1

[PATCH v10 1/5] dt-bindings: display: bridge: Convert cdns, dsi.txt to yaml

2023-01-02 Thread Rahul T R
Convert cdns,dsi.txt binding to yaml format Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.txt | 112 - .../bindings/display/bridge/cdns,dsi.yaml | 157 ++ 2 files changed, 157 insertions(+), 112 deletions(-) dele

[PATCH v10 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2023-01-02 Thread Rahul T R
Add support for wrapper settings for DSI bridge on j721e. Also enable DPI0 --- --- | ---| |--- | | DSS | DPI2 |->| DPI0 | DSI Wrapper | | ---| |--- | --- --

[PATCH v10 4/5] drm/bridge: cdns-dsi: Create a header file

2023-01-02 Thread Rahul T R
Create a header file for cdns dsi and move register offsets and structure to header, to prepare for adding j721e wrapper support Signed-off-by: Rahul T R Reviewed-by: Tomi Valkeinen --- .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 446 + .../gpu/drm/bridge/cadence/cdns-dsi-co

[PATCH v10 2/5] dt-bindings: display: bridge: cdns, dsi: Add compatible for dsi on j721e

2023-01-02 Thread Rahul T R
Add compatible to support dsi bridge on j721e Signed-off-by: Rahul T R Reviewed-by: Rob Herring --- .../bindings/display/bridge/cdns,dsi.yaml | 25 ++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yam

Re: [RFC PATCH 3/7] drm/msm/dpu: Disable MDP vsync source selection on DPU 5.0.0 and above

2023-01-02 Thread Konrad Dybcio
On 2.01.2023 11:18, Marijn Suijten wrote: > On 2023-01-02 10:30:58, Konrad Dybcio wrote: >> >> >> On 31.12.2022 22:52, Marijn Suijten wrote: >>> On 2022-12-31 22:50:02, Marijn Suijten wrote: Since hardware revision 5.0.0 the TE configuration moved out of the PINGPONG block into the INT

Re: [RFC PATCH 2/7] drm/msm/dpu: Disable pingpong TE on DPU 5.0.0 and above

2023-01-02 Thread Marijn Suijten
On 2023-01-01 06:28:23, Dmitry Baryshkov wrote: > On 31/12/2022 23:50, Marijn Suijten wrote: > > Since hardware revision 5.0.0 the TE configuration moved out of the > > PINGPONG block into the INTF block. Writing these registers has no > > effect, and is omitted downstream via the DPU/SDE_PINGPONG

[PATCH v10 0/5] Add support for CDNS DSI J721E wrapper

2023-01-02 Thread Rahul T R
Following series of patches adds supports for CDNS DSI bridge on j721e. v10: - Rebased to v6.2-rc1 - Accumulated the Reviewed-by acks v9: - Fixed below based on review comments in v8 - Added more info on wrapper in the commit message - Fixed the description in Kconfig - Fixed the formatting

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

Re: [PATCH v4 1/2] drm/tiny: ili9486: Enable driver module autoloading

2023-01-02 Thread Thomas Zimmermann
Hi Am 19.12.22 um 10:02 schrieb Carlo Caione: SPI devices use the spi_device_id for module autoloading even on systems using device tree. Add the spi_device_id entry to enable autoloading for the 3.5inch RPi Display (rpi-lcd-35 and piscreen). Reviewed-by: Neil Armstrong Signed-off-by: Carlo C

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

Re: [RFC PATCH 5/7] drm/msm/dpu: Document and enable TEAR interrupts on DSI interfaces

2023-01-02 Thread Marijn Suijten
On 2023-01-01 15:12:35, Dmitry Baryshkov wrote: > On 31/12/2022 23:50, Marijn Suijten wrote: > > > > -#define INTF_BLK(_name, _id, _base, _type, _ctrl_id, _progfetch, > > _features, _reg, _underrun_bit, _vsync_bit) \ > > +#define INTF_BLK(_name, _id, _base, _len, _type, _ctrl_id, _progfetch, > >

Re: (subset) [PATCH v6 0/8] Support for the NPU in Vim3

2023-01-02 Thread Neil Armstrong
Hi, On Fri, 2 Dec 2022 12:52:12 +0100, Tomeu Vizoso wrote: > This series adds support for the Verisilicon VIPNano-QI NPU in the A311D > as in the VIM3 board. > > The IP is very closely based on previous Vivante GPUs, so the etnaviv > kernel driver works basically unchanged. > > The userspace par

Re: (subset) [PATCH] drm/vc4: drop all currently held locks if deadlock happens

2023-01-02 Thread Maxime Ripard
On Thu, 29 Dec 2022 16:46:38 -0300, Maíra Canal wrote: > If vc4_hdmi_reset_link() returns -EDEADLK, it means that a deadlock > happened in the locking context. This situation should be addressed by > dropping all currently held locks and block until the contended lock > becomes available. Currently

Re: (subset) [PATCH] drm/bridge: panel: Set pre_enable_prev_first from drmm_panel_bridge_add

2023-01-02 Thread Maxime Ripard
On Thu, 22 Dec 2022 18:52:13 +, Dave Stevenson wrote: > Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel") > added code to copy prepare_prev_first from drm_panel to pre_enable_prev_first > in drm_bridge when called through devm_panel_bridge_add, but > missed drmm_panel_

[PATCH v5 0/5] Improve GPU reset sequence for Adreno GPU

2023-01-02 Thread Akhil P Oommen
This is a rework of [1] using genpd instead of 'reset' framework. As per the recommended reset sequence of Adreno gpu, we should ensure that gpucc-cx-gdsc has collapsed at hardware to reset gpu's internal hardware states. Because this gdsc is implemented as 'votable', gdsc driver doesn't poll an

[PATCH v5 1/5] PM: domains: Allow a genpd consumer to require a synced power off

2023-01-02 Thread Akhil P Oommen
From: Ulf Hansson Some genpd providers doesn't ensure that it has turned off at hardware. This is fine until the consumer really requires during some special scenarios that the power domain collapse at hardware before it is turned ON again. An example is the reset sequence of Adreno GPU which re

[PATCH v5 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2023-01-02 Thread Akhil P Oommen
Add support for the newly added 'synced_poweroff' genpd flag. This allows some clients (like adreno gpu driver) to request gdsc driver to ensure a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. Signed-off-by: Akhil P Oommen Reviewed-by: Ulf Hansson --- (no changes since v3) Chang

[PATCH v5 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2023-01-02 Thread Akhil P Oommen
When a device has multiple power domains, dev->power_domain is left empty during probe. That didn't cause any issue so far because we are freeloading on smmu driver's vote on cx gdsc. Instead of that, create a device_link between cx genpd device and gmu device to keep a vote from gpu driver. Befor

[PATCH v5 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2023-01-02 Thread Akhil P Oommen
Remove the unused 'reset' interface which was supposed to help to ensure that cx gdsc has collapsed during gpu recovery. This is was not enabled so far due to missing gpucc driver support. Similar functionality using genpd framework will be implemented in the upcoming patch. This effectively rever

[PATCH v5 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2023-01-02 Thread Akhil P Oommen
As per the recommended recovery sequence of adreno gpu, cx gdsc should collapse at hardware before it is turned back ON. This helps to clear out the stale states in hardware before it is reinitialized. Use the genpd notifier along with the newly introduced dev_pm_genpd_synced_poweroff() api to ensu

Re: [Freedreno] [PATCH v2] drm/msm/adreno: Make adreno quirks not overwrite each other

2023-01-02 Thread Akhil P Oommen
On 1/2/2023 3:32 PM, Konrad Dybcio wrote: > So far the adreno quirks have all been assigned with an OR operator, > which is problematic, because they were assigned consecutive integer > values, which makes checking them with an AND operator kind of no bueno.. > > Switch to using BIT(n) so that only

Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support

2023-01-02 Thread Ondřej Jirman
Hello Javier, On Sat, Dec 31, 2022 at 04:29:49PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your feedback. > > On 12/30/22 16:37, Ondřej Jirman wrote: > > [...] > > >> &i2c0 { > >>clock-frequency = <40>; > >>i2c-scl-rising-time-ns = <168>; > >> @@

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Ondřej Jirman
Hello Javier, On Sat, Dec 31, 2022 at 04:15:24PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > Thanks a lot for your comments. > > On 12/30/22 16:40, Ondřej Jirman wrote: > > Hi Javier, > > > > On Fri, Dec 30, 2022 at 12:31:52PM +0100, Javier Martinez Canillas wrote: > >> From: Kam

Re: [RFC PATCH 6/7] drm/msm/dpu: Implement tearcheck support on INTF block

2023-01-02 Thread Marijn Suijten
On 2023-01-01 15:32:11, Dmitry Baryshkov wrote: > On 31/12/2022 23:50, Marijn Suijten wrote: > > Since DPU 5.0.0 the TEARCHECK registers and interrupts moved out of the > > PINGPONG block and into the INTF. Implement the necessary callbacks in > > the INTF block, and use these callbacks together w

[PATCH v3 00/13] drm: Fix color-format selection in fbdev emulation

2023-01-02 Thread Thomas Zimmermann
Fix the selection of the fbdev emulation's color format and make XRGB the only emulated color format. Resolves the blank screen in cases where video= specifies an unsupported color format. Also resolves the issues around current format-conversion helpers. Version 2 of the patchset fixes the fo

[PATCH v3 01/13] firmware/sysfb: Fix EFI/VESA format selection

2023-01-02 Thread Thomas Zimmermann
Select color format for EFI/VESA firmware scanout buffer from the number of bits per pixel and the position of the individual color components. Fixes the selected format for the buffer in several odd cases. For example, XRGB1555 has been reported as ARGB1555 because of the different use of depth an

[PATCH v3 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2023-01-02 Thread Thomas Zimmermann
Add dedicated helper to convert from XRGB to ARGB. Sets all alpha bits to make pixels fully opaque. v3: * use __le32 for destination buffer (Jose, kernel test robot) v2: * use cpubuf_to_le32() * type fixes Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Marti

[PATCH v3 04/13] drm/format-helper: Store RGB565 in little-endian order

2023-01-02 Thread Thomas Zimmermann
Fix to-RGB565 conversion helpers to store the result in little- endian byte order. Update test cases as well. Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal Reviewed-by: José Expósito --- drivers/gpu/drm/drm_format_helper.c | 9 + .../gpu/drm/tests/drm_format_help

[PATCH v3 02/13] drm/format-helper: Comment on RGB888 byte order

2023-01-02 Thread Thomas Zimmermann
RGB888 is different than the other formats as most of its pixels are unaligned and therefore helper functions do not use endianness conversion helpers. Comment on this in the source code. Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal Reviewed-by: José Expósito --- drivers/gpu/drm/d

[PATCH v3 03/13] drm/format-helper: Fix test-input format conversion

2023-01-02 Thread Thomas Zimmermann
Convert test input for format helpers from host byte order to little-endian order. The current code does it the other way around, but there's no effective difference to the result. Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal Reviewed-by: José Expósito --- .../gpu/drm/tests/drm_fo

[PATCH v3 05/13] drm/format-helper: Type fixes in format-helper tests

2023-01-02 Thread Thomas Zimmermann
Change the source-buffer type of le32buf_to_cpu() to __le32* to reflect endianness. Result buffers are converted to local endianness, so instantiate them from regular u8 or u32 types. Signed-off-by: Thomas Zimmermann Reviewed-by: Maíra Canal Reviewed-by: José Expósito --- drivers/gpu/drm/tests

[PATCH v3 09/13] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2023-01-02 Thread Thomas Zimmermann
Add conversion from XRGB to XRGB1555, ARGB1555 and RGBA5551, which are the formats currently supported by the simplefb infrastructure. The new helpers allow the output of XRGB framebuffers to firmware scanout buffers in one of the 15-bit formats. v3: * use __le* for destination buf

[PATCH v3 08/13] drm/format-helper: Add conversion from XRGB8888 to ARGB2101010

2023-01-02 Thread Thomas Zimmermann
Add dedicated helper to convert from XRGB to ARGB2101010. Sets all alpha bits to make pixels fully opaque. v2: * set correct format in struct drm_framebuffer (Javier) * use cpubuf_to_le32() * type fixes Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Can

[PATCH v3 06/13] drm/format-helper: Flip src/dst-format branches in blit helper

2023-01-02 Thread Thomas Zimmermann
Upcoming changes to the format conversion will mostly blit from XRGB to some other format. So put the source format in blit's outer branches to make the code more readable. For cases where a format only changes its endianness, such as XRGB565, introduce dedicated branches that handle this for a

[PATCH v3 10/13] drm/fh-helper: Split fbdev single-probe helper

2023-01-02 Thread Thomas Zimmermann
Split the single-probe helper's implementation into multiple functions and get locking and overallocation out of the way of the surface setup. Simplifies later changes to the setup code. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_fb_helper.c |

[PATCH v3 12/13] drm/format-helper: Simplify drm_fb_build_fourcc_list()

2023-01-02 Thread Thomas Zimmermann
The DRM helper drm_fb_build_fourcc_list() creates a list of color formats for primary planes of the generic drivers. Simplify the helper: - It used to mix and filter native and emulated formats as provided by the driver. Now the only emulated format is XRGB, which is required as fallbac

[PATCH v3 11/13] drm/fb-helper: Fix single-probe color-format selection

2023-01-02 Thread Thomas Zimmermann
Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for compatibility with the driver. If none is supported, use the driver-provided default. This guarantees that the console is always available in any color format at least. Until now, the

[PATCH v3 13/13] drm/format-helper: Remove unnecessary conversion helpers

2023-01-02 Thread Thomas Zimmermann
Drivers only emulate XRGB framebuffers. Remove all conversion helpers that do not use XRGB as their source format. Also remove some special cases for alpha formats in the blit helper. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/drm_format_h

Re: [RFC PATCH 00/20] Initial Xe driver submission

2023-01-02 Thread Jani Nikula
On Mon, 02 Jan 2023, Thomas Zimmermann wrote: > Hi > > Am 22.12.22 um 23:21 schrieb Matthew Brost: >> Hello, >> >> This is a submission for Xe, a new driver for Intel GPUs that supports both >> integrated and discrete platforms starting with Tiger Lake (first platform >> with >> Intel Xe Archite

[PATCH] drm/bridge: panel: Prevent ERR_PTR Dereference

2023-01-02 Thread Maxime Ripard
Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel") introduced an access to the bridge pointer in the devm_drm_panel_bridge_add_typed() function. However, due to the unusual ERR_PTR check when getting that pointer, the pointer access is done even though the pointer might be

Re: [PATCH] drm/bridge: panel: Prevent ERR_PTR Dereference

2023-01-02 Thread Laurent Pinchart
Hi Maxime, Thank you for the patch. On Mon, Jan 02, 2023 at 01:01:23PM +0100, Maxime Ripard wrote: > Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to > drm_panel") introduced an access to the bridge pointer in the > devm_drm_panel_bridge_add_typed() function. > > However, due to t

Re: [PATCH] drm/bridge: panel: Prevent ERR_PTR Dereference

2023-01-02 Thread Andrzej Hajda
On 02.01.2023 13:01, Maxime Ripard wrote: Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel") introduced an access to the bridge pointer in the devm_drm_panel_bridge_add_typed() function. However, due to the unusual ERR_PTR check when getting that pointer, the pointer

[PATCH 0/2] drm/vc4: Improve drm_gem_object handling

2023-01-02 Thread Maíra Canal
Currently, the array of BOs that are lookup up at the start of exec is being instantiated as drm_gem_dma_object, which is not needed and makes it difficult to use the drm_gem_objects_lookup() helper. Therefore, replace drm_gem_dma_object for drm_gem_object and then replace obj lookup steps with drm

[PATCH 2/2] drm/vc4: replace obj lookup steps with drm_gem_objects_lookup

2023-01-02 Thread Maíra Canal
As vc4_cl_lookup_bos() performs the same steps as drm_gem_objects_lookup(), replace the open-coded implementation in vc4 to simply use the DRM function. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_gem.c | 43 ++- 1 file changed, 2 insertions(+), 41 dele

[PATCH 1/2] drm/vc4: replace drm_gem_dma_object for drm_gem_object in vc4_exec_info

2023-01-02 Thread Maíra Canal
The array of BOs that are lookup up at the start of exec doesn't need to be instantiated as drm_gem_dma_object, as it doesn't benefit from its attributes. So, simplify the code by replacing the array of drm_gem_dma_object for an array of drm_gem_object in the struct vc4_exec_info. Suggested-by: Me

Re: [PATCH v10 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml

2023-01-02 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:38PM +0530, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > Reviewed-by: Rob Herring > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 - > .../bindings/display

Re: [PATCH v10 2/5] dt-bindings: display: bridge: cdns,dsi: Add compatible for dsi on j721e

2023-01-02 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:39PM +0530, Rahul T R wrote: > Add compatible to support dsi bridge on j721e > > Signed-off-by: Rahul T R > Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart > --- > .../bindings/display/bridge/cdns,dsi.yaml | 25 +++

Re: [PATCH v10 3/5] drm/bridge: cdns-dsi: Move to drm/bridge/cadence

2023-01-02 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:40PM +0530, Rahul T R wrote: > Move the cadence dsi bridge under drm/bridge/cadence > directory, to prepare for adding j721e wrapper > support > > Signed-off-by: Rahul T R > Reviewed-by: Tomi Valkeinen > --- > drivers/gpu/drm/br

Re: [Intel-gfx] [PATCH] drm/i915: Use "%zu" to format size_t

2023-01-02 Thread Gwan-gyeong Mun
Nirmoy, thanks for fixing it Reviewed-by: Gwan-gyeong Mun On 12/30/22 8:35 PM, Nirmoy Das wrote: Switch to %zu for printing size_t which will fix compilation warning for 32-bit build. Reported-by: kernel test robot Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_shmem.c |

Re: [PATCH v10 4/5] drm/bridge: cdns-dsi: Create a header file

2023-01-02 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:41PM +0530, Rahul T R wrote: > Create a header file for cdns dsi and move > register offsets and structure to header, > to prepare for adding j721e wrapper support You don't have to wrap lines at 43 characters, you can go all the w

Re: [PATCH v10 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2023-01-02 Thread Laurent Pinchart
Hi Rahul, Thank you for the patch. On Mon, Jan 02, 2023 at 03:39:42PM +0530, Rahul T R wrote: > Add support for wrapper settings for DSI bridge on > j721e. Also enable DPI0 > > --- --- > | ---| |--- | > | DSS | DPI2 |->| DP

Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Add internal display support

2023-01-02 Thread Javier Martinez Canillas
Hello Ondřej, On 1/2/23 11:57, Ondřej Jirman wrote: [...] >> >> You tell me, it is your patch :) I just cherry-picked this from your tree: > > I have other patches to goodix driver that do power off the touch sensor chip > during sleep, so that it doesn't consume excessinve amounts of power whe

Re: [PATCH v3 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2023-01-02 Thread Guillaume Ranquet
On Mon, 26 Dec 2022 06:18, CK Hu (胡俊光) wrote: >Hi, Guillaume: > >On Fri, 2022-11-04 at 15:09 +0100, Guillaume Ranquet wrote: >> Add mt8195 SoC bindings for hdmi and hdmi-ddc >> >> On mt8195 the ddc i2c controller is part of the hdmi IP block and >> thus has no >> specific register range, power dom

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Javier Martinez Canillas
Hello Ondřej, On 1/2/23 11:59, Ondřej Jirman wrote: [...] >> Yes, because as you said were debug printks. Feel free to propose adding the >> debug printks if you consider useful for normal usage and not just for devel >> purposes. > > I already did, and used them do debug and fix the issues. Th

Re: [Intel-gfx] [PATCH v2] drm/i915: dell wyse 3040 shutdown fix

2023-01-02 Thread Alexey Lukyachuk
On Tue, 27 Dec 2022 20:40:03 +0300 Alexey Lukyachuk wrote: > On Tue, 27 Dec 2022 11:39:25 -0500 > Rodrigo Vivi wrote: > > > On Sun, Dec 25, 2022 at 09:55:08PM +0300, Alexey Lukyanchuk wrote: > > > dell wyse 3040 doesn't peform poweroff properly, but instead remains in > > > turned power on sta

[PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Maíra Canal
Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@kms_addfb_basic@addfb25-bad-modifier to fail, as vc4 accepts to create a framebuffer with an invalid modifier. Therefore, check for valid formats before creating framebuffers on vc4 and

Re: [RFC PATCH 2/7] drm/msm/dpu: Disable pingpong TE on DPU 5.0.0 and above

2023-01-02 Thread Dmitry Baryshkov
On 02/01/2023 12:25, Marijn Suijten wrote: On 2023-01-01 06:28:23, Dmitry Baryshkov wrote: On 31/12/2022 23:50, Marijn Suijten wrote: Since hardware revision 5.0.0 the TE configuration moved out of the PINGPONG block into the INTF block. Writing these registers has no effect, and is omitted do

[PATCH] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB

2023-01-02 Thread Paul Menzel
Commit 62d89a7d49af ("video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen") accidently decreases the maximum memory size for the Matrox G200eW (102b:0532) from 8 MB to 1 MB by missing one zero. This caused the driver initialization to fail with the messages b

[PATCH v2] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB

2023-01-02 Thread Paul Menzel
Commit 62d89a7d49af ("video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen") accidently decreases the maximum memory size for the Matrox G200eW (102b:0532) from 8 MB to 1 MB by missing one zero. This caused the driver initialization to fail with the messages b

Problems with delivery to dal...@libc.org (was: [PATCH v2] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB)

2023-01-02 Thread Paul Menzel
[Cc: Back to dal...@libc.org] Dear Linux folks, Please ignore version 2. Am 02.01.23 um 15:02 schrieb Paul Menzel: […] --- Update Rich’s address. I should have read the undelivered message better: ``` : host brightrain.aerifal.cx[216.12.86.13] said: 550-Message blocked for policy r

Re: [PATCH v3 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2023-01-02 Thread AngeloGioacchino Del Regno
Il 02/01/23 14:38, Guillaume Ranquet ha scritto: On Mon, 26 Dec 2022 06:18, CK Hu (胡俊光) wrote: Hi, Guillaume: On Fri, 2022-11-04 at 15:09 +0100, Guillaume Ranquet wrote: Add mt8195 SoC bindings for hdmi and hdmi-ddc On mt8195 the ddc i2c controller is part of the hdmi IP block and thus has n

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2023-01-02 Thread youling 257
which patch? 2023-01-02 17:24 GMT+08:00, Dmitry Osipenko : > On 1/1/23 21:29, youling257 wrote: >> Linux 6.2-rc1 has memory leak on amdgpu, git bisect bad commit is >> "drm/scheduler: rework entity flush, kill and fini". >> git bisect start >> # status: waiting for both good and bad commits >> # g

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Thomas Zimmermann
Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@kms_addfb_basic@addfb25-bad-modifier to fail, as vc4 accepts to create a framebuffer with an invalid modifier. Therefore, check for valid

Re: [Intel-gfx] [PATCH] drm/i915: Use "%zu" to format size_t

2023-01-02 Thread Andi Shyti
On Fri, Dec 30, 2022 at 07:35:00PM +0100, Nirmoy Das wrote: > Switch to %zu for printing size_t which will > fix compilation warning for 32-bit build. > > Reported-by: kernel test robot > Signed-off-by: Nirmoy Das Reviewed-by: Andi Shyti Andi > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Maíra Canal
Hi, On 1/2/23 11:20, Thomas Zimmermann wrote: Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@kms_addfb_basic@addfb25-bad-modifier to fail, as vc4 accepts to create a framebuffer with

Re: [PATCH] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB

2023-01-02 Thread Helge Deller
On 1/2/23 14:57, Paul Menzel wrote: Commit 62d89a7d49af ("video: fbdev: matroxfb: set maxvram of vbG200eW to the same as vbG200 to avoid black screen") accidently decreases the maximum memory size for the Matrox G200eW (102b:0532) from 8 MB to 1 MB by missing one zero. This caused the driver init

Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

2023-01-02 Thread Steev Klimaszewski
On 1/2/23 2:21 AM, Johan Hovold wrote: On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote: On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote: The actual name is R133NW4K-R0. Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry") Signed-off-by: Abel Vesa ---

Re: [PATCH v2] drm/virtio: Spiff out cmd queue/response traces

2023-01-02 Thread Dmitry Osipenko
On 11/30/22 03:08, Rob Clark wrote: > From: Rob Clark > > Add a sequence # for more easily matching up cmd/resp, and the # of free > slots in the virtqueue to more easily see starvation issues. > > v2: Fix handling of string fields as well > > Signed-off-by: Rob Clark > Reviewed-by: Dmitry Osi

Re: [PATCH] drm/virtio: Fix memory leak in virtio_gpu_object_create()

2023-01-02 Thread Dmitry Osipenko
On 11/9/22 12:19, Xiu Jianfeng wrote: > The virtio_gpu_object_shmem_init() will alloc memory and save it in > @ents, so when virtio_gpu_array_alloc() fails, this memory should be > freed, this patch fixes it. > > Fixes: e7fef0923303 ("drm/virtio: Simplify error handling of > virtio_gpu_object_cre

Re: [PATCH v1] drm/scheduler: Fix lockup in drm_sched_entity_kill()

2023-01-02 Thread Dmitry Osipenko
On 11/23/22 03:13, Dmitry Osipenko wrote: > The drm_sched_entity_kill() is invoked twice by drm_sched_entity_destroy() > while userspace process is exiting or being killed. First time it's invoked > when sched entity is flushed and second time when entity is released. This > causes a lockup within

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2023-01-02 Thread Dmitry Osipenko
On 1/2/23 17:17, youling 257 wrote: > which patch? https://patchwork.freedesktop.org/patch/512652/ I applied it to next-fixes -- Best regards, Dmitry

Re: [PATCH v3 02/12] dt-bindings: display: mediatek: add MT8195 hdmi bindings

2023-01-02 Thread Guillaume Ranquet
On Mon, 02 Jan 2023 15:14, AngeloGioacchino Del Regno wrote: >Il 02/01/23 14:38, Guillaume Ranquet ha scritto: >> On Mon, 26 Dec 2022 06:18, CK Hu (胡俊光) wrote: >>> Hi, Guillaume: >>> >>> On Fri, 2022-11-04 at 15:09 +0100, Guillaume Ranquet wrote: Add mt8195 SoC bindings for hdmi and hdmi-ddc

Re: [PATCH v4 2/4] drm: panel: Add Himax HX8394 panel controller driver

2023-01-02 Thread Ondřej Jirman
On Mon, Jan 02, 2023 at 02:51:42PM +0100, Javier Martinez Canillas wrote: > Hello Ondřej, > > [...] > > My goal was to have some initial support in mainline even if there could be > some > issues. IMO it is better to use upstream as a baseline and attempt to support > the > PPP incrementally. >

Re: [PATCH v5 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2023-01-02 Thread Philipp Zabel
On Mon, Jan 02, 2023 at 04:18:30PM +0530, Akhil P Oommen wrote: > Remove the unused 'reset' interface which was supposed to help to ensure > that cx gdsc has collapsed during gpu recovery. This is was not enabled > so far due to missing gpucc driver support. Similar functionality using > genpd fram

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Thomas Zimmermann
Hi Am 02.01.23 um 15:29 schrieb Maíra Canal: Hi, On 1/2/23 11:20, Thomas Zimmermann wrote: Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@kms_addfb_basic@addfb25-bad-modifier to fai

Re: [PATCH] fbmem: prevent potential use-after-free issues with console_lock()

2023-01-02 Thread Helge Deller
On 12/30/22 07:35, Hang Zhang wrote: In do_fb_ioctl(), user specified "fb_info" can be freed in the callee fbcon_get_con2fb_map_ioctl() -> set_con2fb_map() -> con2fb_release_oldinfo(), this free operation is protected by console_lock() in fbcon_set_con2fb_map_ioctl(), it also results in the chang

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Maíra Canal
On 1/2/23 12:21, Thomas Zimmermann wrote: Hi Am 02.01.23 um 15:29 schrieb Maíra Canal: Hi, On 1/2/23 11:20, Thomas Zimmermann wrote: Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a framebuffer, which is triggering the IGT test igt@

Re: [PATCH v3 05/11] drm/amd: Request SDMA microcode during IP discovery

2023-01-02 Thread Christian König
Am 30.12.22 um 06:21 schrieb Mario Limonciello: If SDMA microcode is not available during early init, the firmware framebuffer will have already been released and the screen will freeze. Move the request from SDMA microcode into the IP discovery phase so that if it's not available, IP discove

Re: [PATCH] drm/vc4: Check for valid formats

2023-01-02 Thread Thomas Zimmermann
Hi Am 02.01.23 um 16:39 schrieb Maíra Canal: On 1/2/23 12:21, Thomas Zimmermann wrote: Hi Am 02.01.23 um 15:29 schrieb Maíra Canal: Hi, On 1/2/23 11:20, Thomas Zimmermann wrote: Hi Am 02.01.23 um 14:57 schrieb Maíra Canal: Currently, vc4 is not checking valid formats before creating a fra

[PATCH 1/2] drm/msm/dpu: remove dpu_encoder_virt_ops

2023-01-02 Thread Dmitry Baryshkov
Struct dpu_encoder_virt_ops is used to provide several callbacks to the phys_enc backends. However these ops are static and are not supposed to change in the foreseeble future. Drop the indirection and call corresponding functions directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH 2/2] drm/msm/dpu: remove CRTC frame event callback registration

2023-01-02 Thread Dmitry Baryshkov
The frame event callback is always set to dpu_crtc_frame_event_cb() (or to NULL) and the data is always either the CRTC itself or NULL (correpondingly). Thus drop the event callback registration, call the dpu_crtc_frame_event_cb() directly and gate on the dpu_enc->crtc assigned using dpu_encoder_as

Re: [RFC PATCH 6/7] drm/msm/dpu: Implement tearcheck support on INTF block

2023-01-02 Thread Dmitry Baryshkov
On 02/01/2023 13:06, Marijn Suijten wrote: On 2023-01-01 15:32:11, Dmitry Baryshkov wrote: On 31/12/2022 23:50, Marijn Suijten wrote: Since DPU 5.0.0 the TEARCHECK registers and interrupts moved out of the PINGPONG block and into the INTF. Implement the necessary callbacks in the INTF block, a

  1   2   >