Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-19 Thread Jacek Lawrynowicz
Hi, On 18.12.2022 11:23, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> Adds four types of GEM-based BOs for the VPU: >> - shmem >> - userptr >> - internal >> - prime >> >> All types are implemented as struct ivpu_bo, based on >> struct drm_gem_object. V

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Zheng Wang
Hi Zhi, Thanks again for your reply and clear explaination about the function. I still have some doubt about the fix. Here is a invoke chain : ppgtt_populate_spt ->ppgtt_populate_shadow_entry ->split_2MB_gtt_entry As far as I'm concerned, when something error happens in DMA mapping, which wi

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Wang, Zhi A
On 12/19/2022 9:57 AM, Zheng Wang wrote: > Hi Zhi, > > Thanks again for your reply and clear explaination about the function. > I still have some doubt about the fix. Here is a invoke chain : > ppgtt_populate_spt >->ppgtt_populate_shadow_entry > ->split_2MB_gtt_entry > As far as I'm conce

Re: DRM scheduler & amdgpu splats followed by GPU hang

2022-12-19 Thread Christian König
Hi Michel, yeah that's a known issue. I'm already working on that, looks like I've just forgotten to add a dma_fence_get() somewhere. Going to send around a bug fix later today. Thanks for the report, Christian. Am 17.12.22 um 13:12 schrieb Michel Dänzer: With the drm-next-2022-12-13 change

Re: [PATCH v6] drm: Optimise for continuous memory allocation

2022-12-19 Thread Christian König
Am 18.12.22 um 07:57 schrieb xinhui pan: Optimise a little when continuous memory request fails. There are memory holes and continuous memory request usually fails when order is too big. Currently buddy only look for exactly order memory for such request. Now we can try again to look for several

[PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2022-12-19 Thread Uwe Kleine-König
While working on a drm driver that doesn't need the i2c algobit stuff I noticed that DRM selects this code even though only 8 drivers actually use it. While also only some drivers use i2c, keep the select for I2C for the next cleanup patch. Still prepare this already by also selecting I2C for the i

[PATCH] drm/vc4: dsi: Drop unused i2c include

2022-12-19 Thread Uwe Kleine-König
The driver doesn't make use of any symbol provided by . So drop the include. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/vc4/vc4_dsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index 878e05d79e81..08e95c1d4a04 100644

Re: [PATCH v3] drm: Only select I2C_ALGOBIT for drivers that actually need it

2022-12-19 Thread Javier Martinez Canillas
Hello Uwe, On 12/19/22 09:36, Uwe Kleine-König wrote: > While working on a drm driver that doesn't need the i2c algobit stuff I > noticed that DRM selects this code even though only 8 drivers actually use > it. While also only some drivers use i2c, keep the select for I2C for the > next cleanup pa

Re: [PATCH] drm/vc4: dsi: Drop unused i2c include

2022-12-19 Thread Javier Martinez Canillas
On 12/19/22 09:40, Uwe Kleine-König wrote: > The driver doesn't make use of any symbol provided by . So > drop the include. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

[PATCH] MAINTAINERS: drm/hisilicon: Drop Chen Feng

2022-12-19 Thread Uwe Kleine-König
The listed address doesn't work any more: puck.c...@hisilicon.com host mx5.hisilicon.com [124.71.93.234] SMTP error from remote mail server after RCPT TO:: 551 5.1.1 : Recipient address rejected: Failed recipient validation check.: host 127.0.0.1[127.0.0.1] said: 554 5.7.1 re

Re: [PATCH] MAINTAINERS: drm/hisilicon: Drop Chen Feng

2022-12-19 Thread Javier Martinez Canillas
On 12/19/22 09:53, Uwe Kleine-König wrote: > The listed address doesn't work any more: > > puck.c...@hisilicon.com > host mx5.hisilicon.com [124.71.93.234] > SMTP error from remote mail server after RCPT > TO:: > 551 5.1.1 : Recipient address rejected: > Failed recipient validat

Re: [PATCH 5/9] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2022-12-19 Thread José Expósito
Hi Thomas, Thanks for CCing me. There are some issues with this helpers on big endian architectures, you can run the test on big endian with this command: $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \ --arch=powerpc --cross_compile=powerpc64-linux-gnu- drm_format

Re: [Intel-gfx] [PATCH v3] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Zheng Wang
Wang, Zhi A 于2022年12月19日周一 16:22写道: > > I think it is a case-by-case thing. For example: > > The current scenario in this function looks like below: > > caller pass spt a > function > alloc spt b > something error > free spt a > return error > > The problem is: the

Re: [PATCH v3 2/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-12-19 Thread Philipp Zabel
On Fr, 2022-12-16 at 22:00 +0100, Uwe Kleine-König wrote: > Hallo Philipp, > > On Fri, Dec 16, 2022 at 07:05:13PM +0100, Philipp Zabel wrote: > > On Fr, 2022-12-16 at 18:50 +0100, Uwe Kleine-König wrote: > > > From: Marian Cichy > > > > > > Add support for the LCD Controller found on i.MX21 and

Re: [PATCH v3 2/2] drm/imx/lcdc: Implement DRM driver for imx21

2022-12-19 Thread Philipp Zabel
On Fr, 2022-12-16 at 18:50 +0100, Uwe Kleine-König wrote: [...] > +static int imx_lcdc_pipe_check(struct drm_simple_display_pipe *pipe, > +struct drm_plane_state *plane_state, > +struct drm_crtc_state *crtc_state) > +{ > + const struct drm

[PATCH 0/2] TLB invalidation cleanup

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin First patch to make the platform check not catch all due current lack of automated testing. Second patch to consolidate the code a bit and move invariant setup at engine init time. Don't think I want to merge this one until some test coverage can be had. Tvrtko Ursulin (2):

[PATCH 1/2] drm/i915: Do not cover all future platforms in TLB invalidation

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 13 - 1 file changed, 12 insertions(+), 1 de

[PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of invariant platform and engine checks during each

[PATCH] drm/i915/mtl: implement wa 14015076503

2022-12-19 Thread Daniele Ceraolo Spurio
The WA states that before doing a GSC engine reset we need to alert the GSC FW and then wait for 200ms for the FW to get ready for it. The GuC will take care of this for engine reset, but i915 is still responsible for the full GT reset scenario. Given that we do full GT resets in the resume paths

Re: [PATCH 5/9] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2022-12-19 Thread Thomas Zimmermann
Hi Am 19.12.22 um 10:23 schrieb José Expósito: Hi Thomas, Thanks for CCing me. There are some issues with this helpers on big endian architectures, you can run the test on big endian with this command: $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \ --arch=pow

Re: [PATCH] drm/meson: Reduce the FIFO lines held when AFBC is not used

2022-12-19 Thread Martin Blumenstingl
Hi Carlo, On Mon, Dec 19, 2022 at 9:43 AM Carlo Caione wrote: > > Having a bigger number of FIFO lines held after vsync is only useful to > SoCs using AFBC to give time to the AFBC decoder to be reset, configured > and enabled again. > > For SoCs not using AFBC this, on the contrary, is causing o

Re: [PATCH v2] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Krzysztof Kozlowski
On 17/12/2022 16:23, Johan Jonker wrote: > Convert rockchip-lvds.txt to YAML. > > Changed: > Add power-domains property. > Requirements between PX30 and RK3288 > > Signed-off-by: Johan Jonker > --- > > Changed V2: > Fix title > --- > .../display/rockchip/rockchip-lvds.txt| 92 --

[PATCH v4 1/7] drm/debugfs: create device-centered debugfs functions

2022-12-19 Thread Maíra Canal
Introduce the ability to track requests for the addition of DRM debugfs files at any time and have them added all at once during drm_dev_register(). Drivers can add DRM debugfs files to a device-managed list and, during drm_dev_register(), all added files will be created at once. Now, the drivers

[PATCH v4 0/7] Introduce debugfs device-centered functions

2022-12-19 Thread Maíra Canal
This series introduces the initial structure to make DRM debugfs more device-centered and it is the first step to drop the drm_driver->debugfs_init hooks in the future [1]. Currently, DRM debugfs files are created using drm_debugfs_create_files() on request. The first patch of this series makes it

[PATCH v4 3/7] drm/debugfs: create debugfs late register functions

2022-12-19 Thread Maíra Canal
Although the device-centered debugfs functions can track requests for the addition of DRM debugfs files at any time and have them added all at once during drm_dev_register(), they are not able to create debugfs files for modeset components, as they are registered after the primary and the render dr

[PATCH v4 2/7] drm: use new debugfs device-centered functions on DRM core files

2022-12-19 Thread Maíra Canal
Replace the use of drm_debugfs_create_files() with the new drm_debugfs_add_files() function in all DRM core files, centering the debugfs files management on the drm_device instead of drm_minor. Reviewed-by: Maxime Ripard Signed-off-by: Maíra Canal --- drivers/gpu/drm/drm_atomic.c | 11

[PATCH v4 6/7] drm/vkms: use new debugfs device-centered functions

2022-12-19 Thread Maíra Canal
Replace the use of drm_debugfs_create_files() with the new drm_debugfs_add_files() function, which centers the debugfs files management on the drm_device instead of drm_minor. Moreover, remove the debugfs_init hook and add the debugfs files directly on vkms_create(), before drm_dev_register(). Sig

[PATCH v4 4/7] drm/vc4: use new debugfs device-centered functions

2022-12-19 Thread Maíra Canal
Currently, vc4 has its own debugfs infrastructure that adds the debugfs files on drm_dev_register(). With the introduction of the new debugfs, functions, replace the vc4 debugfs structure with the DRM debugfs device-centered function, drm_debugfs_add_file(). Moreover, remove the explicit error han

[PATCH v4 5/7] drm/v3d: use new debugfs device-centered functions

2022-12-19 Thread Maíra Canal
Replace the use of drm_debugfs_create_files() with the new drm_debugfs_add_files() function, which centers the debugfs files management on the drm_device instead of drm_minor. Signed-off-by: Maíra Canal --- drivers/gpu/drm/v3d/v3d_debugfs.c | 22 ++ 1 file changed, 10 inserti

[PATCH v4 7/7] drm/todo: update the debugfs clean up task

2022-12-19 Thread Maíra Canal
The structs drm_debugfs_info and drm_debugfs_entry introduced a new debugfs structure to DRM, centered on drm_device instead of drm_minor. Therefore, remove the tasks related to create a new device-centered debugfs structure and add a new task to replace the use of drm_debugfs_create_files() for th

[PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort order and restyl

Re: [RFC PATCH 0/4] Add RGB ttl connection on rockchip phy

2022-12-19 Thread Michael Nazzareno Trimarchi
Hi all On Sun, Oct 2, 2022 at 8:45 AM Michael Trimarchi wrote: > > The rockchip phy can be convigured in ttl mode. The phy is shared > between lvds, dsi, ttl. The configuration that now I'm able to support > has the display output on some set of pins on standard vop output > and a set of pins usi

[PATCH v4] [PATCH v4] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by undoing the mapping of DMA address and freeing sub_spt. Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M h

Re: [PATCH v4 0/7] Introduce debugfs device-centered functions

2022-12-19 Thread Melissa Wen
On 12/19, Maíra Canal wrote: > This series introduces the initial structure to make DRM debugfs more > device-centered and it is the first step to drop the > drm_driver->debugfs_init hooks in the future [1]. > > Currently, DRM debugfs files are created using drm_debugfs_create_files() > on request

[RESEND PATCH v4] drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

2022-12-19 Thread Zheng Wang
If intel_gvt_dma_map_guest_page failed, it will call ppgtt_invalidate_spt, which will finally free the spt. But the caller does not notice that, it will free spt again in error path. Fix this by undoing the mapping of DMA address and freeing sub_spt. Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M h

Re: [PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Krzysztof Kozlowski
On 19/12/2022 13:32, Johan Jonker wrote: > Convert rockchip-lvds.txt to YAML. > > Changed: > Add power-domains property. > Requirements between PX30 and RK3288 > > Signed-off-by: Johan Jonker > --- > > Changed V3: > Filename matching compatible style > Drop "Regulator phandle for " >

Re: [PATCH v4 2/7] accel/ivpu: Add Intel VPU MMU support

2022-12-19 Thread Jacek Lawrynowicz
Hi, On 18.12.2022 10:13, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows the creation of multiple virtual address spaces for >> the device and map noncontinuous host memory (there is no dedicated

Re: [PATCH v2] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Rob Herring
On Sat, 17 Dec 2022 16:23:53 +0100, Johan Jonker wrote: > Convert rockchip-lvds.txt to YAML. > > Changed: > Add power-domains property. > Requirements between PX30 and RK3288 > > Signed-off-by: Johan Jonker > --- > > Changed V2: > Fix title > --- > .../display/rockchip/rockchip-lvds.tx

Re: [PATCH] drm/meson: Reduce the FIFO lines held when AFBC is not used

2022-12-19 Thread Neil Armstrong
On 19/12/2022 12:00, Martin Blumenstingl wrote: Hi Carlo, On Mon, Dec 19, 2022 at 9:43 AM Carlo Caione wrote: Having a bigger number of FIFO lines held after vsync is only useful to SoCs using AFBC to give time to the AFBC decoder to be reset, configured and enabled again. For SoCs not using

Re: [PATCH v4 0/2] Make ILI9486 driver working with 16-bits SPI controllers

2022-12-19 Thread Neil Armstrong
Hi Kamlesh, On 19/12/2022 10:02, Carlo Caione wrote: This patchset is trying to fix problems seen on S905X boards when interfacing with an ILI9486 equipped SPI panel. I fully reviewed both patches, but I'd like a review from the maintainer, can you have a look ? Thanks, Neil To: Kamlesh Gu

Re: [PATCH] drm/panfrost: Fix GEM handle creation UAF

2022-12-19 Thread Steven Price
On 16/12/2022 23:33, Rob Clark wrote: > From: Rob Clark > > Relying on an unreturned handle to hold a reference to an object we > dereference is not safe. Userspace can guess the handle and race us > by closing the handle from another thread. The _create_with_handle() > that returns an object p

[PATCH] drm/panfrost: Fix GEM handle creation ref-counting

2022-12-19 Thread Steven Price
panfrost_gem_create_with_handle() previously returned a BO but with the only reference being from the handle, which user space could in theory guess and release, causing a use-after-free. Additionally if the call to panfrost_gem_mapping_get() in panfrost_ioctl_create_bo() failed then a(nother) refe

[PATCH] drm/amd/display: Remove the unused function dmub_outbox_irq_info_funcs

2022-12-19 Thread Jiapeng Chong
The function dmub_outbox_irq_info_funcs is defined in the irq_service_dcn201.c file, but not called elsewhere, so remove this unused function. drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn201/irq_service_dcn201.c:139:43: warning: unused variable 'dmub_outbox_irq_info_funcs'. Link: https://bug

Re: [PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
On 12/19/22 14:04, Krzysztof Kozlowski wrote: > On 19/12/2022 13:32, Johan Jonker wrote: >> Convert rockchip-lvds.txt to YAML. >> >> Changed: >> Add power-domains property. >> Requirements between PX30 and RK3288 >> >> Signed-off-by: Johan Jonker >> --- >> >> Changed V3: >> Filename match

Re: [PATCH] drm: Replace DRM_INFO() with pr_info()

2022-12-19 Thread Thomas Zimmermann
Hi Am 19.12.22 um 15:23 schrieb Siddh Raman Pant: Line 536 of drm_print.h says DRM_INFO() is deprecated in favor of pr_info(). That's a misleading comment. DRM_INFO() is deprecated for drm_info(). pr_info() et al is only to be used of you don't have a dev pointer. Best regards Thomas Sig

Re: [PATCH v2 6/7] drm: rcar-du: Bump V3U to gen 4

2022-12-19 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-12-19 14:01:38) > V3U is actually gen 4 IP, like in V4H. Bumb up V3U gen in the s/Bumb/bump/ Reviewed-by: Kieran Bingham > rcar_du_r8a779a0_info. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- > 1 file changed, 1 insertion

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not cover all future platforms in TLB invalidation

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda Reviewed-by: Andrzej Hajda Regards Andrzej ---

[PATCH 02/18] Revert "fbcon: don't lose the console font across generic->chip driver switch"

2022-12-19 Thread Thomas Zimmermann
This reverts commit ae1287865f5361fa138d4d3b1b6277908b54eac9. Always free the console font when deinitializing the framebuffer console. Subsequent framebuffer consoles will then use the default font. Rely on userspace to load any user-configured font for these consoles. Commit ae1287865f53 ("fbco

[PATCH 04/18] drm/i915: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in i915. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/display/intel_fbdev.c | 7 --- 1 file changed, 7 deletions(-) diff --g

[PATCH 08/18] fbdev/hyperv-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in hyperv-fb. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/hyperv_fb.c | 17 ++--- 1 file changed, 6 insertions(+), 11

[PATCH 05/18] drm/radeon: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in radeon. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/radeon/radeon_fb.c | 4 1 file changed, 4 deletions(-) diff --git a/driv

[PATCH 11/18] fbdev/efifb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 24 +++

[PATCH 18/18] drm/fbdev: Remove aperture handling and FBINFO_MISC_FIRMWARE

2022-12-19 Thread Thomas Zimmermann
There are no users left of struct fb_info.apertures and the flag FBINFO_MISC_FIRMWARE. Remove both and the aperture-ownership code in the fbdev core. All code for aperture ownership is now located in the fbdev drivers. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbmem.c | 33

[PATCH 00/18] drm, fbdev: Remove apertures structure and FBINFO_MISC_FIRMWARE

2022-12-19 Thread Thomas Zimmermann
Remove struct fb_info.apertures and FBINFO_MISC_FIRMWARE from fbdev and handle the aperture ownership without involving the fbdev core. The apertures field in struct fb_info is a remnant from earlier ownership management for framebuffer apertures. When fbdev core code still handled ownership of th

[PATCH 14/18] fbdev/simplefb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/simplefb.c | 19

[PATCH 15/18] fbdev/vesafb: Remove trailing whitespaces

2022-12-19 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vesafb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c index 929d4775cb4b..47ce244e4bb8 100644 --- a/driv

[PATCH 03/18] drm/gma500: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in gma500. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/gma500/framebuffer.c | 5 - 1 file changed, 5 deletions(-) diff --git a/d

[PATCH 01/18] fbcon: Remove trailing whitespaces

2022-12-19 Thread Thomas Zimmermann
Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/fbcon.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index c0143d38df83..50

[PATCH 16/18] fbdev/vesafb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vesafb.c | 27 ++

[PATCH 07/18] fbdev/clps711x-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in clps711x-fb. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/clps711x-fb.c | 10 +- 1 file changed, 1 insertion(+), 9 dele

[PATCH 06/18] drm/fb-helper: Do not allocate unused apertures structure

2022-12-19 Thread Thomas Zimmermann
The apertures field in struct fb_info is not used by DRM drivers. Do not allocate it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/d

[PATCH 09/18] vfio-mdev/mdpy-fb: Do not set struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Generic fbdev drivers use the apertures field in struct fb_info to control ownership of the framebuffer memory and graphics device. Do not set the values in mdpy-fb. Signed-off-by: Thomas Zimmermann --- samples/vfio-mdev/mdpy-fb.c | 8 1 file changed, 8 deletions(-) diff --git a/sample

[PATCH 17/18] fbdev/vga16fb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/vga16fb.c | 15 +

[PATCH 12/18] fbdev/offb: Allocate struct offb_par with framebuffer_alloc()

2022-12-19 Thread Thomas Zimmermann
Move the palette array into struct offb_par and allocate both via framebuffer_alloc(), as intended by fbdev. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/offb.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbde

[PATCH 10/18] fbdev/efifb: Add struct efifb_par for driver data

2022-12-19 Thread Thomas Zimmermann
The efifb_par structure holds the palette for efifb. It will also be useful for storing the device's aperture range. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/efifb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/driv

[PATCH 13/18] fbdev/offb: Do not use struct fb_info.apertures

2022-12-19 Thread Thomas Zimmermann
Acquire ownership of the firmware scanout buffer by calling Linux' aperture helpers. Remove the use of struct fb_info.apertures and do not set FBINFO_MISC_FIRMWARE; both of which previously configured buffer ownership. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/offb.c | 20

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-19 Thread Andrzej Hajda
On 19.12.2022 11:13, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the corresponding code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise

Re: [PATCH v3 10/11] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-12-19 Thread Robert Foss
On Mon, 5 Dec 2022 at 17:44, Dmitry Baryshkov wrote: > > On 05/12/2022 18:37, Robert Foss wrote: > > Enable the display subsystem and the dsi0 output for > > the sm8350-hdk board. > > > > Signed-off-by: Robert Foss > > --- > > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++

Re: [PATCH] drm: Replace DRM_INFO() with pr_info()

2022-12-19 Thread Thomas Zimmermann
Hi Am 19.12.22 um 16:34 schrieb Siddh Raman Pant: On Mon, 19 Dec 2022 20:27:45 +0530, Thomas Zimmermann wrote: Hi Am 19.12.22 um 15:23 schrieb Siddh Raman Pant: Line 536 of drm_print.h says DRM_INFO() is deprecated in favor of pr_info(). That's a misleading comment. DRM_INFO() is deprecated

Re: [PATCH v3 08/11] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-12-19 Thread Robert Foss
On Mon, 5 Dec 2022 at 20:19, Georgi Djakov wrote: > > Hi Robert, > > On 5.12.22 18:37, Robert Foss wrote: > > Use two interconnect cells in order to optionally > > support a path tag. > > > > Signed-off-by: Robert Foss > > Reviewed-by: Konrad Dybcio > > --- > > arch/arm64/boot/dts/qcom/sm8350.

Re: [PATCH v3 05/11] drm/msm: Add support for SM8350

2022-12-19 Thread Robert Foss
On Thu, 8 Dec 2022 at 00:50, Dmitry Baryshkov wrote: > > On 05/12/2022 18:37, Robert Foss wrote: > > Add compatibles string, "qcom,sm8350-mdss", for the multimedia display > > subsystem unit used on Qualcomm SM8350 platform. > > > > Signed-off-by: Robert Foss > > --- > > drivers/gpu/drm/msm/msm

[PATCH v4 1/5] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort order and restyl

[PATCH v4 2/5] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-19 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker --- .../devicetree/bindings/soc/rockchip/grf.yaml | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/s

[PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml

2022-12-19 Thread Johan Jonker
On Rockchip rk3399 a port node with one endpoint can be connected to a USB Type-C connector node. Add a port node to the phy-rockchip-inno-usb2.yaml file. Signed-off-by: Johan Jonker --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v4 4/5] ARM: dts: rockchip: rk3288: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 487b0e

[PATCH v4 5/5] arm64: dts: rockchip: px30: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/roc

Re: [PATCH] drm/panfrost: Fix GEM handle creation ref-counting

2022-12-19 Thread Rob Clark
On Mon, Dec 19, 2022 at 6:02 AM Steven Price wrote: > > panfrost_gem_create_with_handle() previously returned a BO but with the > only reference being from the handle, which user space could in theory > guess and release, causing a use-after-free. Additionally if the call to > panfrost_gem_mapping

[PATCH] drm/drv: Make use of local variable driver in drm_dev_register()

2022-12-19 Thread Uwe Kleine-König
There is a local variable that contains dev->driver. Make use of it instead of "open coding" it. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 203bf

Re: [PATCH v2 1/7] media: Add 2-10-10-10 RGB formats

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:33PM +0200, Tomi Valkeinen wrote: > Add XBGR2101010, ABGR2101010 and BGRA1010102 formats. > > Signed-off-by: Tomi Valkeinen > --- > .../userspace-api/media/v4l/pixfmt-rgb.rst| 194 ++ > drivers/media/v4l2-core/

[PATCH v3 0/2] Add support for the orisetech ota5601

2022-12-19 Thread Christophe Branchereau
Changes since v2: - Documented the registers to the best of my knowledge - Used macros for on/off panel registers - Added SPI id_table (non-requested change, fixes a warning in dmesg) --- Changes since v1: - fixed the dt-bindings maintainer email adress - dropped backlight, port, power-supply

[PATCH v3 2/2] dt-bindings: display/panel: Add the Focaltech gpt3

2022-12-19 Thread Christophe Branchereau
Add bindings for the Forcaltech gpt3, which is a 640x480 3.0" 4:3 IPS LCD Panel found in the YLM/Anbernic RG300X handheld. Signed-off-by: Christophe Branchereau Reviewed-by: Krzysztof Kozlowski --- .../display/panel/focaltech,gpt3.yaml | 56 +++ 1 file changed, 56 insert

[PATCH v3 1/2] drm/panel: add the orisetech ota5601a

2022-12-19 Thread Christophe Branchereau
Add the orisetech ota5601a ic driver For now it only supports the focaltech gpt3 3" 640x480 ips panel found in the ylm rg300x handheld. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu

Re: [PATCH v2 2/7] media: Add Y210, Y212 and Y216 formats

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:34PM +0200, Tomi Valkeinen wrote: > Add Y210, Y212 and Y216 formats. > > Signed-off-by: Tomi Valkeinen > --- > .../media/v4l/pixfmt-packed-yuv.rst | 44 +++ > drivers/media/v4l2-core/v4l2-ioctl.c

Re: [PATCH] drm/fsl-dcu: Remove redundant error logging

2022-12-19 Thread Deepak R Varma
On Sun, Dec 11, 2022 at 03:57:47PM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Thank you, ./drv > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its ret

Re: [PATCH] drm/sprd: remove redundant error logging

2022-12-19 Thread Deepak R Varma
On Sun, Dec 11, 2022 at 07:25:08PM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Thank you, ./drv > A call to platform_get_irq() already prints an error on failure within > its own implementation. So printing another error based on its ret

Re: [PATCH] drm/tegra: sor: Remove redundant error logging

2022-12-19 Thread Deepak R Varma
On Mon, Dec 12, 2022 at 10:44:55AM +0530, Deepak R Varma wrote: Hello, May I please request a review and feedback on this patch proposal? Also, I was able to build the changes for ARM arch verified using modinfo tegr-drm.ko command. Thank you, ./drv > A call to platform_get_irq() already prin

Re: [PATCH v2 3/7] media: renesas: vsp1: Change V3U to be gen4

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:35PM +0200, Tomi Valkeinen wrote: > V3U is actually gen4, not gen3. The same IP is also used in the > (not-yet-supported) V4H. > > Change VI6_IP_VERSION_MODEL_VSPD_V3U to VI6_IP_VERSION_MODEL_VSPD_GEN4, > to represent the model corr

Re: [PATCH v2 4/7] media: renesas: vsp1: Add V4H SoC version

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:36PM +0200, Tomi Valkeinen wrote: > Add VI6_IP_VERSION_SOC_V4H so that we can identify V4H SoC. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 + > 1

Re: [PATCH v2 5/7] media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:37PM +0200, Tomi Valkeinen wrote: > Add new pixel formats: XBGR2101010, ABGR2101010, BGRA1010102 and Y210. > > Signed-off-by: Tomi Valkeinen > --- > .../media/platform/renesas/vsp1/vsp1_pipe.c | 15 ++ > .../media/platform/r

Re: [PATCH v2 6/7] drm: rcar-du: Bump V3U to gen 4

2022-12-19 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:38PM +0200, Tomi Valkeinen wrote: > V3U is actually gen 4 IP, like in V4H. Bumb up V3U gen in the > rcar_du_r8a779a0_info. With the typo reporting by Kieran fixed, Conditionally-Reviewed-by: Laurent Pinchart > Signed-off-by: Tom

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-19 Thread Laurent Pinchart
Hi Tomi, (CC'ing Sakari and Hans) Thank you for the patch. On Mon, Dec 19, 2022 at 04:01:39PM +0200, Tomi Valkeinen wrote: > Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010 and Y210. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 24

[PATCH AUTOSEL 6.1 10/16] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 96d845a67b7e406cfed7880a724c8ca6121e022e ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 6.1 11/16] drm/sti: Fix return type of sti_{dvo, hda, hdmi}_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 0ad811cc08a937d875cbad0149c1bab17f84ba05 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 5.15 7/9] drm/sti: Fix return type of sti_{dvo, hda, hdmi}_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 0ad811cc08a937d875cbad0149c1bab17f84ba05 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 6.0 11/16] drm/sti: Fix return type of sti_{dvo, hda, hdmi}_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 0ad811cc08a937d875cbad0149c1bab17f84ba05 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 5.10 2/5] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 96d845a67b7e406cfed7880a724c8ca6121e022e ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 6.0 10/16] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 96d845a67b7e406cfed7880a724c8ca6121e022e ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 5.10 3/5] drm/sti: Fix return type of sti_{dvo, hda, hdmi}_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 0ad811cc08a937d875cbad0149c1bab17f84ba05 ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 5.15 6/9] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 96d845a67b7e406cfed7880a724c8ca6121e022e ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

[PATCH AUTOSEL 4.14 1/3] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-12-19 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit 96d845a67b7e406cfed7880a724c8ca6121e022e ] With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), indirect call targets are validated against the expected function pointer prototype to make sure the call target is valid to help mitigate ROP

  1   2   >