[PATCH 1/2] drm/panel: Add driver for the AUO A030JTN01 TFT LCD

2022-12-13 Thread Christophe Branchereau
Add driver for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit interface. Signed-off-by: Christophe Branchereau Signed-off-by: Paul Cercueil --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Make

[PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01

2022-12-13 Thread Christophe Branchereau
Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit interface. Signed-off-by: Christophe Branchereau Signed-off-by: Paul Cercueil --- .../bindings/display/panel/auo,a030jtn01.yaml | 57 +++ 1 file

[PATCH 1/2] drm/panel: add the orisetech ota5601a

2022-12-13 Thread Christophe Branchereau
Add the orisetech ota5601a ic driver For now it only supports the focaltech gpt3 3" 640x480 ips panel found in the ylm rg300x handheld. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu

[PATCH 2/2] dt-bindings: display/panel: Add the focaltech gpt3

2022-12-13 Thread Christophe Branchereau
Add bindings for the focaltech gpt3, which is a 640x480 3.0" 4:3 IPS LCD Panel found in the YLM/Anbernic RG300X handheld. Signed-off-by: Christophe Branchereau --- .../display/panel/focaltech,gpt3.yaml | 59 +++ 1 file changed, 59 insertions(+) create mode 100644 Docume

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Szyprowski
On 12.12.2022 16:33, Jagan Teki wrote: > On Mon, Dec 12, 2022 at 8:52 PM Marek Szyprowski > wrote: >> On 12.12.2022 09:43, Marek Szyprowski wrote: >>> On 12.12.2022 09:32, Jagan Teki wrote: On Mon, Dec 12, 2022 at 1:56 PM Marek Szyprowski wrote: > Hi Jagan, > > On 09.12.20

Re: [PATCH v2] drm/etnaviv: Remove redundant dev_err()

2022-12-13 Thread Kang Minchul
2022년 12월 12일 (월) 오후 3:14, Kang Minchul 님이 작성: > > Function dev_err() is redundant because platform_get_irq() > already prints an error. > > Signed-off-by: Kang Minchul > --- > Changes in v2: > - Removed unnecessary braces. > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 +--- > 1 file changed, 1

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2022-12-13 Thread Andrzej Hajda
On 09.12.2022 18:16, Arnd Bergmann wrote: On Fri, Dec 9, 2022, at 16:48, Andrzej Hajda wrote: The pattern of setting variable with new value and returning old one is very common in kernel. Usually atomicity of the operation is not required, so xchg seems to be suboptimal and confusing in such ca

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2022-12-13 Thread Arnd Bergmann
On Tue, Dec 13, 2022, at 10:28, Andrzej Hajda wrote: > On 09.12.2022 18:16, Arnd Bergmann wrote: >> name for the backing of arch_xchg() or arch_xchg_relaxed(), >> maybe we can instead rename those to __arch_xchg() and use the >> __xchg() name for the new non-atomic version? > > I will try, but even

[PATCH] drm/i915/gt: Modify mismatched function name

2022-12-13 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3442 Reported-by: Abaci Robot Signed-off-by: Ji

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2022-12-13 Thread Andrzej Hajda
On 09.12.2022 19:56, Andy Shevchenko wrote: On Fri, Dec 09, 2022 at 04:48:39PM +0100, Andrzej Hajda wrote: The pattern of setting variable with new value and returning old one is very common in kernel. Usually atomicity of the operation is not required, so xchg seems to be suboptimal and confusi

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-13 Thread Jani Nikula
On Mon, 12 Dec 2022, Harry Wentland wrote: > Drivers might not support all colorspaces defined in > dp_colorspaces and hdmi_colorspaces. This results in > undefined behavior when userspace is setting an > unsupported colorspace. > > Allow drivers to pass the list of supported colorspaces > when cr

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-13 Thread Pekka Paalanen
On Mon, 12 Dec 2022 13:21:27 -0500 Harry Wentland wrote: > Drivers might not support all colorspaces defined in > dp_colorspaces and hdmi_colorspaces. This results in > undefined behavior when userspace is setting an > unsupported colorspace. > > Allow drivers to pass the list of supported color

Re: [Intel-gfx] [PATCH 1/5] linux/minmax.h: add non-atomic version of xchg

2022-12-13 Thread Andy Shevchenko
On Tue, Dec 13, 2022 at 11:09:12AM +0100, Andrzej Hajda wrote: > On 09.12.2022 19:56, Andy Shevchenko wrote: > > On Fri, Dec 09, 2022 at 04:48:39PM +0100, Andrzej Hajda wrote: ... > > > I hope there will be place for such tiny helper in kernel. > > > Quick cocci analyze shows there is probably fe

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-13 Thread Pekka Paalanen
Sorry, hand slipped on keyboard and sent out a draft of this email too early. On Mon, 12 Dec 2022 13:21:27 -0500 Harry Wentland wrote: > Drivers might not support all colorspaces defined in > dp_colorspaces and hdmi_colorspaces. This results in > undefined behavior when userspace is setting an

Re: [PATCH 14/16] drm/amd/display: Add debugfs for testing output colorspace

2022-12-13 Thread Pekka Paalanen
On Mon, 12 Dec 2022 13:21:35 -0500 Harry Wentland wrote: > In order to IGT test colorspace we'll want to print > the currently enabled colorspace on a stream. We add > a new debugfs to do so, using the same scheme as > current bpc reporting. > > This might also come in handy when debugging displ

Re: [PATCH 04/16] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2022-12-13 Thread Pekka Paalanen
On Mon, 12 Dec 2022 13:21:25 -0500 Harry Wentland wrote: > This allows us to use strongly typed arguments. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: dri-devel@list

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
Hi Marek, On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski wrote: > > On 12.12.2022 16:33, Jagan Teki wrote: > > On Mon, Dec 12, 2022 at 8:52 PM Marek Szyprowski > wrote: > > On 12.12.2022 09:43, Marek Szyprowski wrote: > > On 12.12.2022 09:32, Jagan Teki wrote: > > On Mon, Dec 12, 2022 at 1:56

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Fabio Estevam
Hi Jagan, On Tue, Dec 13, 2022 at 7:40 AM Jagan Teki wrote: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 Please preserve the authorship of the patches. This one is from Marek Vasut: https://gitlab.com/openedev/kernel/-/commit/e244fa552402caebcf48cd6710fd387429f7f680 but in yo

RE: [Intel-gfx] [PATCH] drm/i915/gt: Modify mismatched function name

2022-12-13 Thread Upadhyay, Tejas
Indeed looks like miss. Thanks for the patch. Reviewed-by: Tejas Upadhyay > -Original Message- > From: Intel-gfx On Behalf Of > Jiapeng Chong > Sent: Tuesday, December 13, 2022 3:22 PM > To: jani.nik...@linux.intel.com > Cc: Jiapeng Chong ; intel- > g...@lists.freedesktop.org; Abaci Rob

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-13 Thread Pekka Paalanen
On Mon, 12 Dec 2022 13:21:37 -0500 Harry Wentland wrote: > This will let us pass kms_hdr.bpc_switch. > > I don't see any good reasons why we still need to > limit bpc to 8 bpc and doing so is problematic when > we enable HDR. > > If I remember correctly there might have been some > displays out

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
Hi Fabio, On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: > > Hi Jagan, > > On Tue, Dec 13, 2022 at 7:40 AM Jagan Teki wrote: > > > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 > > Please preserve the authorship of the patches. > > This one is from Marek Vasut: > https://gitl

Re: [PATCH 1/1] crypto: ccp - Allocate TEE ring and cmd buffer using DMA APIs

2022-12-13 Thread Rijo Thomas
On 12/12/2022 9:13 PM, Tom Lendacky wrote: > On 12/12/22 05:21, Rijo Thomas wrote: >> On 12/10/2022 2:31 AM, Tom Lendacky wrote: >>> On 12/6/22 06:30, Rijo Thomas wrote: For AMD Secure Processor (ASP) to map and access TEE ring buffer, the ring buffer address sent by host to ASP must b

Re: linux-next: manual merge of the fbdev tree with the drm tree

2022-12-13 Thread Helge Deller
On 12/13/22 01:16, Stephen Rothwell wrote: Today's linux-next merge of the fbdev tree got a conflict in: drivers/video/fbdev/Kconfig between commit: c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers") from the drm tree and commit: 225e095bbd3a ("fbdev: offb: make offb dr

[PATCH v2] crypto: ccp - Allocate TEE ring and cmd buffer using DMA APIs

2022-12-13 Thread Rijo Thomas
For AMD Secure Processor (ASP) to map and access TEE ring buffer, the ring buffer address sent by host to ASP must be a real physical address and the pages must be physically contiguous. In a virtualized environment though, when the driver is running in a guest VM, the pages allocated by __get_fre

[PATCH v4 8/7] accel/ivpu: Add depend on !UML to Kconfig

2022-12-13 Thread Stanislaw Gruszka
VPU is integrated x86_64 device and the driver utilizes various CPU architecture specific functions that don't exits on ARCH=um, so disable build on UML. Reported-by: kernel test robot Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Bug 216805] New: external monitor not working since 6.1 (amdgpu: update_mst_stream_alloc_table, regression from 6.0))

2022-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216805 Bug ID: 216805 Summary: external monitor not working since 6.1 (amdgpu: update_mst_stream_alloc_table, regression from 6.0)) Product: Drivers Version: 2.5 Kernel Version: 6.1

[PATCH] drm/i915/selftests: Remove hardcoded value with a macro

2022-12-13 Thread Nirmoy Das
Use MI_USE_GGTT instead of hardcoded value. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c b/drivers/gpu/drm/i915/gem/selftests/i915

Re: [PATCH v9 23/23] drm/i915/vm_bind: Support capture of persistent mappings

2022-12-13 Thread Matthew Auld
On 12/12/2022 23:15, Niranjana Vishwanathapura wrote: Support dump capture of persistent mappings upon user request. Capture of a mapping is requested with the VM_BIND ioctl and processed during the GPU error handling, thus not adding any additional latency to the submission path. A list of per

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Jiasheng Jiang
Thanks, I found my mistake and I will submit a v2. > And how did you find this potential problem? What tool did you use and > why did you not follow the documentation for properly describing the > tool? I used a tool I wrote myself to find it, which is unpublished. Therefore, I think it is okay

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Szyprowski
Hi, On 13.12.2022 11:40, Jagan Teki wrote: > On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski > wrote: >> On 12.12.2022 16:33, Jagan Teki wrote: >> >> On Mon, Dec 12, 2022 at 8:52 PM Marek Szyprowski >> wrote: >> >> On 12.12.2022 09:43, Marek Szyprowski wrote: >> >> On 12.12.2022 09:32, Jagan Te

[PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Jiasheng Jiang
Add the check for the return value of dma_alloc_coherent in order to avoid NULL pointer dereference. Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Add "goto err;" when allocation fails. --- drivers/usb/gadget/udc/as

[PATCH 1/2] drm/i915: fix TLB invalidation for Gen12.50 video and compute engines

2022-12-13 Thread Tvrtko Ursulin
From: Andrzej Hajda In case of Gen12.50 video and compute engines, TLB_INV registers are masked - to modify one bit, corresponding bit in upper half of the register must be enabled, otherwise nothing happens. Fixes: 77fa9efc16a9 ("drm/i915/xehp: Create separate reg definitions for new MCR regis

[PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-13 Thread Tvrtko Ursulin
From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of invariant platform and engine checks during each

Re: [PATCH] drm/i915/selftests: Remove hardcoded value with a macro

2022-12-13 Thread Matthew Auld
On 13/12/2022 12:00, Nirmoy Das wrote: Use MI_USE_GGTT instead of hardcoded value. Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld

Re: [PATCH 2/2] dt-bindings: display/panel: Add the focaltech gpt3

2022-12-13 Thread Krzysztof Kozlowski
On 13/12/2022 09:42, Christophe Branchereau wrote: > Add bindings for the focaltech gpt3, which is a 640x480 3.0" 4:3 > IPS LCD Panel found in the YLM/Anbernic RG300X handheld. > > Signed-off-by: Christophe Branchereau > --- > .../display/panel/focaltech,gpt3.yaml | 59 ++

Re: [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Krzysztof Kozlowski
On 13/12/2022 00:41, Abhinav Kumar wrote: >>> >>> besides, i think i have to sent the whole series patches include this >>> one to address your new comments on other patch. >>> >>> is this correct? >> >> No. Please fix your system first, validate your patches and send them >> afterwards. You can no

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Vasut
On 12/13/22 11:53, Jagan Teki wrote: Hi Fabio, Hi, On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: Hi Jagan, On Tue, Dec 13, 2022 at 7:40 AM Jagan Teki wrote: https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v10 Please preserve the authorship of the patches. This one is

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
On Tue, Dec 13, 2022 at 6:44 PM Marek Vasut wrote: > > On 12/13/22 11:53, Jagan Teki wrote: > > Hi Fabio, > > Hi, > > > On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: > >> > >> Hi Jagan, > >> > >> On Tue, Dec 13, 2022 at 7:40 AM Jagan Teki > >> wrote: > >> > >>> https://gitlab.com/openede

Re: [PATCH] drm/i915/gt: Reset twice

2022-12-13 Thread Vivi, Rodrigo
On Tue, 2022-12-13 at 00:08 +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Mon, Dec 12, 2022 at 11:55:10AM -0500, Rodrigo Vivi wrote: > > On Mon, Dec 12, 2022 at 05:13:38PM +0100, Andi Shyti wrote: > > > From: Chris Wilson > > > > > > After applying an engine reset, on some platforms like > > > J

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Vasut
On 12/13/22 14:18, Jagan Teki wrote: On Tue, Dec 13, 2022 at 6:44 PM Marek Vasut wrote: On 12/13/22 11:53, Jagan Teki wrote: Hi Fabio, Hi, On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: Hi Jagan, On Tue, Dec 13, 2022 at 7:40 AM Jagan Teki wrote: https://gitlab.com/openedev/ke

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
On Tue, Dec 13, 2022 at 6:51 PM Marek Vasut wrote: > > On 12/13/22 14:18, Jagan Teki wrote: > > On Tue, Dec 13, 2022 at 6:44 PM Marek Vasut wrote: > >> > >> On 12/13/22 11:53, Jagan Teki wrote: > >>> Hi Fabio, > >> > >> Hi, > >> > >>> On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: > >

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Vasut
On 12/13/22 14:26, Jagan Teki wrote: On Tue, Dec 13, 2022 at 6:51 PM Marek Vasut wrote: On 12/13/22 14:18, Jagan Teki wrote: On Tue, Dec 13, 2022 at 6:44 PM Marek Vasut wrote: On 12/13/22 11:53, Jagan Teki wrote: Hi Fabio, Hi, On Tue, Dec 13, 2022 at 4:17 PM Fabio Estevam wrote: Hi

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
On Tue, Dec 13, 2022 at 5:50 PM Marek Szyprowski wrote: > > Hi, > > On 13.12.2022 11:40, Jagan Teki wrote: > > On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski > > wrote: > >> On 12.12.2022 16:33, Jagan Teki wrote: > >> > >> On Mon, Dec 12, 2022 at 8:52 PM Marek Szyprowski > >> wrote: > >> > >>

Re: [PATCH v2] drm/i915/hwconfig: Remove comment block

2022-12-13 Thread Vivi, Rodrigo
On Tue, 2022-12-13 at 13:50 +0800, Jiapeng Chong wrote: > No functional modification involved. > > drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c:112: warning: > expecting prototype for intel_guc_hwconfig_init(). Prototype was for > guc_hwconfig_init() instead. Thank you for the patch and for a

Re: [PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01

2022-12-13 Thread Rob Herring
On Tue, 13 Dec 2022 09:10:34 +0100, Christophe Branchereau wrote: > Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit > interface. > > Signed-off-by: Christophe Branchereau > Signed-off-by: Paul Cercueil > -

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Szyprowski
On 13.12.2022 13:20, Marek Szyprowski wrote: > On 13.12.2022 11:40, Jagan Teki wrote: >> On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski >> wrote: >>> On 12.12.2022 16:33, Jagan Teki wrote: >>> >>> On Mon, Dec 12, 2022 at 8:52 PM Marek Szyprowski >>> wrote: >>> >>> On 12.12.2022 09:43, Marek Szy

Re: [PATCH] drm/i915/selftests: Remove hardcoded value with a macro

2022-12-13 Thread Andrzej Hajda
On 13.12.2022 13:00, Nirmoy Das wrote: Use MI_USE_GGTT instead of hardcoded value. Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_coherenc

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
On Tue, Dec 13, 2022 at 7:31 PM Marek Szyprowski wrote: > > On 13.12.2022 13:20, Marek Szyprowski wrote: > > On 13.12.2022 11:40, Jagan Teki wrote: > >> On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski > >> wrote: > >>> On 12.12.2022 16:33, Jagan Teki wrote: > >>> > >>> On Mon, Dec 12, 2022 at 8:

Re: [PATCH 1/3] dt-bindings: display/msm: Add SM8150 MDSS & DPU

2022-12-13 Thread Rob Herring
On Mon, 12 Dec 2022 10:33:12 +0100, Konrad Dybcio wrote: > Add bindings for the display hardware on SM8150. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm8150-dpu.yaml | 92 + > .../display/msm/qcom,sm8150-mdss.yaml | 330 ++ > 2 files ch

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread 俞家鑫

Re: [PATCH 2/2] dt-bindings: display/panel: Add AUO A030JTN01

2022-12-13 Thread Rob Herring
On Tue, Dec 13, 2022 at 07:46:32AM -0600, Rob Herring wrote: > > On Tue, 13 Dec 2022 09:10:34 +0100, Christophe Branchereau wrote: > > Add binding for the AUO A030JTN01 panel, which is a 320x480 3.0" 4:3 > > 24-bit TFT LCD panel with non-square pixels and a delta-RGB 8-bit > > interface. > > > >

Re: [PATCH] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Greg KH
On Tue, Dec 13, 2022 at 08:15:20PM +0800, Jiasheng Jiang wrote: > Thanks, I found my mistake and I will submit a v2. > > > And how did you find this potential problem? What tool did you use and > > why did you not follow the documentation for properly describing the > > tool? > > I used a tool I

Re: [PATCH v2] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-13 Thread Greg KH
On Tue, Dec 13, 2022 at 08:21:16PM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent > in order to avoid NULL pointer dereference. > > Fixes: 055276c13205 ("usb: gadget: add Aspeed ast2600 udc driver") > Signed-off-by: Jiasheng Jiang Again, please prove that

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-13 Thread Andrzej Hajda
On 13.12.2022 13:39, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine itself, and by doing so minimise the amount of inv

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Szyprowski
On 13.12.2022 15:18, Jagan Teki wrote: > On Tue, Dec 13, 2022 at 7:31 PM Marek Szyprowski > wrote: >> On 13.12.2022 13:20, Marek Szyprowski wrote: >>> On 13.12.2022 11:40, Jagan Teki wrote: On Tue, Dec 13, 2022 at 2:28 PM Marek Szyprowski wrote: > On 12.12.2022 16:33, Jagan Teki wro

[PATCH v1] drm/bridge: lt9611: Fix PLL being unable to lock

2022-12-13 Thread Robert Foss
This fixes PLL being unable to lock, and is derived from an equivalent downstream commit. Available LT9611 documentation does not list this register, neither does LT9611UXC (which is a different chip). This commit has been confirmed to fix HDMI output on DragonBoard 845c. Suggested-by: Amit Pund

Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-13 Thread Bjorn Andersson
On Fri, Dec 09, 2022 at 11:35:23AM +0100, Johan Hovold wrote: > On Wed, Dec 07, 2022 at 02:00:11PM -0800, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > > and link it together with the backlight control. > > > > S

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Jagan Teki
On Tue, Dec 13, 2022 at 8:24 PM Marek Szyprowski wrote: > > On 13.12.2022 15:18, Jagan Teki wrote: > > On Tue, Dec 13, 2022 at 7:31 PM Marek Szyprowski > > wrote: > >> On 13.12.2022 13:20, Marek Szyprowski wrote: > >>> On 13.12.2022 11:40, Jagan Teki wrote: > On Tue, Dec 13, 2022 at 2:28 PM

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Consolidate TLB invalidation flow

2022-12-13 Thread Tvrtko Ursulin
On 13/12/2022 14:52, Andrzej Hajda wrote: On 13.12.2022 13:39, Tvrtko Ursulin wrote: From: Tvrtko Ursulin As the logic for selecting the register and corresponsing values grew, the code become a bit unsightly. Consolidate by storing the required values at engine init time in the engine its

Re: [PATCH 4/7] drm/msm/a6xx: Add support for A650 speed binning

2022-12-13 Thread Doug Anderson
Hi, On Mon, Dec 12, 2022 at 4:24 PM Konrad Dybcio wrote: > > Add support for matching QFPROM fuse values to get the correct speed bin > on A650 (SM8250) GPUs. > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 17 + > 1 file changed, 17 insertions(+

Re: [PATCH 4/7] drm/msm/a6xx: Add support for A650 speed binning

2022-12-13 Thread Konrad Dybcio
On 13.12.2022 16:23, Doug Anderson wrote: > Hi, > > On Mon, Dec 12, 2022 at 4:24 PM Konrad Dybcio > wrote: >> >> Add support for matching QFPROM fuse values to get the correct speed bin >> on A650 (SM8250) GPUs. >> >> Signed-off-by: Konrad Dybcio >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gp

Re: [PATCH v9 10/18] drm: bridge: samsung-dsim: Init exynos host for first DSI transfer

2022-12-13 Thread Marek Szyprowski
On 13.12.2022 16:15, Jagan Teki wrote: > On Tue, Dec 13, 2022 at 8:24 PM Marek Szyprowski > wrote: >> On 13.12.2022 15:18, Jagan Teki wrote: >>> On Tue, Dec 13, 2022 at 7:31 PM Marek Szyprowski >>> wrote: On 13.12.2022 13:20, Marek Szyprowski wrote: > On 13.12.2022 11:40, Jagan Teki wrot

Re: [PATCH] drm/bridge: it6505: Add caching for EDID

2022-12-13 Thread Robert Foss
On Tue, 15 Nov 2022 at 12:27, Pin-yen Lin wrote: > > Add caching when EDID is read, and invalidate the cache until the > bridge detects HPD low or sink count changes on HPD_IRQ. > > It takes 1.2s for IT6505 bridge to read a 3-block EDID, and skipping > one EDID read would be a notable difference o

Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-13 Thread Johan Hovold
On Tue, Dec 13, 2022 at 07:10:14AM -0800, Bjorn Andersson wrote: > On Fri, Dec 09, 2022 at 11:35:23AM +0100, Johan Hovold wrote: > > > + edp_reg_en: edp-reg-en-state { > > > + pins = "gpio25"; > > > + function = "gpio"; > > > + output-enable; > > > > 'output-enable' is no

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-13 Thread Harry Wentland
On 12/13/22 05:23, Pekka Paalanen wrote: > On Mon, 12 Dec 2022 13:21:27 -0500 > Harry Wentland wrote: > >> Drivers might not support all colorspaces defined in >> dp_colorspaces and hdmi_colorspaces. This results in >> undefined behavior when userspace is setting an >> unsupported colorspace.

Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 02:23:32PM +, Jiaxin Yu (俞家鑫) wrote: > On Mon, 2022-12-05 at 12:07 +, Mark Brown wrote: > > On Mon, Dec 05, 2022 at 09:34:17AM +, Jiaxin Yu (俞家鑫) wrote: > > No, I mean that if you want to control the enable and disable of the > > output path you should implement

Re: [PATCH 06/16] drm/connector: Allow drivers to pass list of supported colorspaces

2022-12-13 Thread Harry Wentland
On 12/13/22 05:34, Pekka Paalanen wrote: > Sorry, hand slipped on keyboard and sent out a draft of this email too > early. > > > On Mon, 12 Dec 2022 13:21:27 -0500 > Harry Wentland wrote: > >> Drivers might not support all colorspaces defined in >> dp_colorspaces and hdmi_colorspaces. This r

Re: [PATCH 04/16] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2022-12-13 Thread Harry Wentland
On 12/13/22 05:39, Pekka Paalanen wrote: > On Mon, 12 Dec 2022 13:21:25 -0500 > Harry Wentland wrote: > >> This allows us to use strongly typed arguments. >> >> Signed-off-by: Harry Wentland >> Cc: Pekka Paalanen >> Cc: Sebastian Wick >> Cc: vitaly.pros...@amd.com >> Cc: Uma Shankar >> Cc:

Re: [PATCH v1] drm/bridge: lt9611: Fix PLL being unable to lock

2022-12-13 Thread Amit Pundir
On Tue, 13 Dec 2022 at 20:33, Robert Foss wrote: > > This fixes PLL being unable to lock, and is derived from an equivalent > downstream commit. > > Available LT9611 documentation does not list this register, neither does > LT9611UXC (which is a different chip). > > This commit has been confirmed

Re: renesas/master bisection: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked on rk3399-gru-kevin

2022-12-13 Thread Mark Brown
On Tue, Dec 13, 2022 at 05:56:30AM -0800, KernelCI bot wrote: The KernelCI bisection bot found regressions in at least two KMS tests in the Renesas tree on rk3399-gru-kevin just after the Renesas tree merged up mainline: igt-kms-rockchip.kms_vblank.pipe-A-wait-forked igt-kms-rockchip.kms_v

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Daniel Vetter
On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: > Hi Christian, > > On Fri, 9 Dec 2022 at 12:45, Christian König > wrote: > > > > The init order and resulting error handling in dma_buf_export > > was pretty messy. > > > > Subordinate objects like the file and the sysfs kernel object

[PATCH] drm: panel-orientation-quirks: Add quirks for One XPlayer handheld variants

2022-12-13 Thread Matthew Anderson
We have more handhelds in the One XPLAYER lineup now that needs support added to the orientation-quirks. By adding more native resolution checks and the one unique BIOS variant available we add support to most devices. Signed-off-by: Matthew Anderson --- .../gpu/drm/drm_panel_orientation_quirk

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-13 Thread Michel Dänzer
On 12/12/22 19:21, Harry Wentland wrote: > This will let us pass kms_hdr.bpc_switch. > > I don't see any good reasons why we still need to > limit bpc to 8 bpc and doing so is problematic when > we enable HDR. > > If I remember correctly there might have been some > displays out there where the a

Re: [Freedreno] [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Abhinav Kumar
On 12/13/2022 5:13 AM, Krzysztof Kozlowski wrote: On 13/12/2022 00:41, Abhinav Kumar wrote: besides, i think i have to sent the whole series patches include this one to address your new comments on other patch. is this correct? No. Please fix your system first, validate your patches and s

Re: [Linaro-mm-sig] Re: [PATCH] dma-buf: fix dma_buf_export init order v2

2022-12-13 Thread Christian König
Am 13.12.22 um 18:09 schrieb Daniel Vetter: On Sat, Dec 10, 2022 at 08:43:47AM +0530, Sumit Semwal wrote: Hi Christian, On Fri, 9 Dec 2022 at 12:45, Christian König wrote: The init order and resulting error handling in dma_buf_export was pretty messy. Subordinate objects like the file and th

Re: [Freedreno] [PATCH v11 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Krzysztof Kozlowski
On 13/12/2022 18:31, Abhinav Kumar wrote: > > > On 12/13/2022 5:13 AM, Krzysztof Kozlowski wrote: >> On 13/12/2022 00:41, Abhinav Kumar wrote: > > besides, i think i have to sent the whole series patches include this > one to address your new comments on other patch. > > is th

[PATCH 1/9] firmware/sysfb: Fix EFI/VESA format selection

2022-12-13 Thread Thomas Zimmermann
Select color format for EFI/VESA firmware scanout buffer from the number of bits per pixel and the position of the individual color components. Fixes the selected format for the buffer in several odd cases. For example, XRGB1555 has been reported as ARGB1555 because of the different use of depth an

[PATCH 4/9] drm/format-helper: Add conversion from XRGB8888 to ARGB2101010

2022-12-13 Thread Thomas Zimmermann
Add dedicated helper to convert from XRGB to ARGB2101010. Sets all alpha bits to make pixels fully opaque. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 58 - .../gpu/drm/tests/drm_format_helper_test.c| 63 +++ includ

[PATCH 0/9] drm: Fix color-format selection in fbdev emulation

2022-12-13 Thread Thomas Zimmermann
Fix the selection of the fbdev emulation's color format and make XRGB the only emulated color format. Resolves the blank screen in cases where video= specifies an unsupported color format. Also resolves the issues around current format-conversion helpers. DRM drivers usually pick a default for

[PATCH 2/9] drm/format-helper: Flip src/dst-format branches in blit helper

2022-12-13 Thread Thomas Zimmermann
Upcoming changes to the format conversion will mostly blit from XRGB to some other format. So put the source format in blit's outer branches to make the code more readable. For cases where a format only changes its endianness, such as XRGB565, introduce dedicated branches that handle this for a

[PATCH 5/9] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2022-12-13 Thread Thomas Zimmermann
Add conversion from XRGB to XRGB1555, ARGB1555 and RGBA5551, which are the formats currently supported by the simplefb infrastructure. The new helpers allow the output of XRGB framebuffers to firmware scanout buffers in one of the 15-bit formats. Signed-off-by: Thomas Zimmermann --- driv

[PATCH 6/9] drm/fh-helper: Split fbdev single-probe helper

2022-12-13 Thread Thomas Zimmermann
Split the single-probe helper's implementation into multiple functions and get locking and overallocation out of the way of the surface setup. Simplifies later changes to the setup code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 116

[PATCH 8/9] drm/format-helper: Simplify drm_fb_build_fourcc_list()

2022-12-13 Thread Thomas Zimmermann
The DRM helper drm_fb_build_fourcc_list() creates a list of color formats for primary planes of the generic drivers. Simplify the helper: - It used to mix and filter native and emulated formats as provided by the driver. Now the only emulated format is XRGB, which is required as fallbac

[PATCH 7/9] drm/fb-helper: Fix single-probe color-format selection

2022-12-13 Thread Thomas Zimmermann
Fix the color-format selection of the single-probe helper. Go through all user-specified values and test each for compatibility with the driver. If none is supported, use the driver-provided default. This guarantees that the console is always available in any color format at least. Until now, the

[PATCH 3/9] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2022-12-13 Thread Thomas Zimmermann
Add dedicated helper to convert from XRGB to ARGB. Sets all alpha bits to make pixels fully opaque. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 53 +++- .../gpu/drm/tests/drm_format_helper_test.c| 63 +++ include/dr

[PATCH 9/9] drm/format-helper: Remove unnecessary conversion helpers

2022-12-13 Thread Thomas Zimmermann
Drivers only emulate XRGB framebuffers. Remove all conversion helpers that do not use XRGB as their source format. Also remove some special cases for alpha formats in the blit helper. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 75 --

Re: [git pull] drm for 6.2-rc1

2022-12-13 Thread Linus Torvalds
On Mon, Dec 12, 2022 at 6:56 PM Dave Airlie wrote: > > There are a bunch of conflicts, one in amdgpu is a bit nasty, I've > cc'ed Christian/Alex to make sure they know to check whatever > resolution you find. The one I have is what we have in drm-tip tree. Hmm. My merge resolution is slightly dif

Re: [git pull] drm for 6.2-rc1

2022-12-13 Thread pr-tracker-bot
The pull request you sent on Tue, 13 Dec 2022 12:56:25 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-12-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a594533df0f6ca391da003f43d53b336a2d23ffa Thank you! -- Deet-doot-dot, I am a bot. https://ko

[Bug 216806] New: [Raven Ridge] console disappears after framebuffer device loads

2022-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216806 Bug ID: 216806 Summary: [Raven Ridge] console disappears after framebuffer device loads Product: Drivers Version: 2.5 Kernel Version: 6.0.8 Hardware: AMD

[Bug 216806] [Raven Ridge] console disappears after framebuffer device loads

2022-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216806 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[Bug 216805] external monitor not working since 6.1 (amdgpu: update_mst_stream_alloc_table, regression from 6.0))

2022-12-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216805 kolAflash (kolafl...@kolahilft.de) changed: What|Removed |Added Hardware|All |AMD -- You may repl

Re: [PATCH] drm/msm/dpu: Add check for pstates

2022-12-13 Thread Abhinav Kumar
On 12/6/2022 12:02 AM, Jiasheng Jiang wrote: As kzalloc may fail and return NULL pointer, it should be better to check pstates in order to avoid the NULL pointer dereference. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Jiasheng Jiang Once again, your lines are wr

Re: [PATCH] drm/msm/dpu: check for null return of devm_kzalloc() in dpu_writeback_init()

2022-12-13 Thread Abhinav Kumar
On 11/18/2022 9:55 PM, Hui Tang wrote: Because of the possilble failure of devm_kzalloc(), dpu_wb_conn might be NULL and will cause null pointer derefrence later. derefrence --> dereference Therefore, it might be better to check it and directly return -ENOMEM. Fixes: 77b001acdcfe ("drm/msm

[PATCH v12 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2022-12-13 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (5): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint dt-bindings: msm/dp: add data-lanes and link-frequencies property drm/msm/dp: parser da

[PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-13 Thread Kuogee Hsieh
Add both data-lanes and link-frequencies property into endpoint Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link rate to symbol rate -- deprecation of old data-lanes property Changes in v8: -- correct Bjorn mail address to kernel.org Changes in v10: -- add menu item t

[PATCH v12 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-13 Thread Kuogee Hsieh
Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out endpoint as well. The last frequency specified at link-frequencies will be the max link rate supported by DP. Changes in v5: -- revert changes at sc7180.dtsi and sc7280.dtsi -- add &dp_out

[PATCH v12 3/5] drm/msm/dp: parser data-lanes as property of dp_out endpoint

2022-12-13 Thread Kuogee Hsieh
Add capability to parser data-lanes as property of dp_out endpoint. Also retain the original capability to parser data-lanes as property of mdss_dp node to handle legacy case. Changes in v6: -- first patch after split parser patch into two Changes in v7: -- check "data-lanes" from endpoint first

[PATCH v12 5/5] drm/msm/dp: add support of max dp link rate

2022-12-13 Thread Kuogee Hsieh
By default, HBR2 (5.4G) is the max link link be supported. This patch uses the actual limit specified by DT and removes the artificial limitation to 5.4 Gbps. Supporting HBR3 is a consequence of that. Changes in v2: -- add max link rate from dtsi Changes in v3: -- parser max_data_lanes and max_dp

[PATCH v12 4/5] drm/msm/dp: parser link-frequencies as property of dp_out endpoint

2022-12-13 Thread Kuogee Hsieh
Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint. Changes in v6: -- second patch after split parser patch into two patches Changes in v7: -- without checking cnt against DP_MAX_NUM_DP_LANES to retrieve link rate Changes in v9: --

Re: [PATCH v2 01/12] dt-bindings: display: msm: Rename mdss node name in example

2022-12-13 Thread Abhinav Kumar
On 12/1/2022 11:54 AM, Dmitry Baryshkov wrote: On 30/11/2022 22:09, Adam Skladowski wrote: Follow other YAMLs and replace mdss name into display-subystem. Signed-off-by: Adam Skladowski Reviewed-by: Dmitry Baryshkov Going to add two fixes tags here as we are touching two chipsets: Fix

  1   2   >