Re: [PATCH v2 01/21] dt-bindings: display: tegra: add Tegra20 VIP

2022-12-02 Thread Luca Ceresoli
Hello Rob, Thanks for your review. On Thu, 1 Dec 2022 17:19:36 -0600 Rob Herring wrote: > On Mon, Nov 28, 2022 at 04:23:16PM +0100, Luca Ceresoli wrote: > > VIP is the parallel video capture component within the video input > > subsystem of Tegra20 (and other Tegra chips, apparently). > > > >

Re: [PATCH v2 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example

2022-12-02 Thread Luca Ceresoli
Hello Rob, On Thu, 1 Dec 2022 17:16:36 -0600 Rob Herring wrote: > On Mon, Nov 28, 2022 at 04:23:17PM +0100, Luca Ceresoli wrote: > > The Tegra20 VI peripheral can receive parallel input from the VIP parallel > > input module. Add it to the allowed properties and augment the existing > > nvidia,t

[PATCH] drm: kirin: Fix missing clk_disable_unprepare in ade_power_up()

2022-12-02 Thread Shang XiaoJing
The clk_disable_unprepare() should be called in the error handling of ade_power_up(). So as reset_control_assert(). Fixes: 783ad972c9a0 ("drm/hisilicon: Add crtc driver for ADE") Signed-off-by: Shang XiaoJing --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 3 +++ 1 file changed, 3 insertio

Re: [RFC 1/3] drm: Replace DRM_DEBUG with drm_dbg_core in file and ioctl handling

2022-12-02 Thread Christian König
Am 30.11.22 um 14:34 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin Replace the deprecated macro with the per-device one. Signed-off-by: Tvrtko Ursulin Acked-by: Christian König --- drivers/gpu/drm/drm_file.c | 21 +++-- drivers/gpu/drm/drm_ioc32.c | 13 +++--

Re: [PATCH] [RFC] drm/etnaviv: Disable softpin

2022-12-02 Thread Lucas Stach
Am Freitag, dem 02.12.2022 um 00:21 +0100 schrieb Marek Vasut: > Currently softpin suffers from assorted race conditions exposed by newer > versions of mesa 22.2.y and 22.3.y . Those races are difficult to fix in > older kernel versions due to massive amount of backports necessary to do > so. Disab

Re: [RFC 3/3] drm: Update file owner during use

2022-12-02 Thread Christian König
Am 01.12.22 um 12:09 schrieb Tvrtko Ursulin: On 30/11/2022 14:18, Daniel Vetter wrote: On Wed, Nov 30, 2022 at 01:34:07PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin With the typical model where the display server opends the file descriptor and then hands it over to the client we wer

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Remove frontbuffer tracking from gem.

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 22:03, Zanoni, Paulo R wrote: Hi I was given a link to https://patchwork.freedesktop.org/series/111494/ but can't seem to find it on the mailing list, so I'll reply here. On Thu, 2022-08-25 at 08:46 +0200, Maarten Lankhorst wrote: Frontbuffer tracking in gem is used in old driv

[PATCH v3 1/2] drm/etnaviv: update hardware headers from rnndb

2022-12-02 Thread Lucas Stach
Update the state HI header from the rnndb commit 640a009e7e66 ("rnndb: fix AXI1_TOTAL_REQUEST_COUNT"). Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/state_hi.xml.h | 86 +- 1 file changed, 70 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/st

[PATCH v3 2/2] drm/etnaviv: print MMU exception cause

2022-12-02 Thread Lucas Stach
From: Christian Gmeiner The MMU tells us the fault status. While the raw register value is already printed, it's a bit more user friendly to translate the fault reasons into human readable format. Signed-off-by: Christian Gmeiner Signed-off-by: Lucas Stach --- drivers/gpu/drm/etnaviv/etnaviv_

Re: [PATCH v3 2/2] drm/etnaviv: print MMU exception cause

2022-12-02 Thread Philipp Zabel
On Fri, Dec 02, 2022 at 10:19:29AM +0100, Lucas Stach wrote: > From: Christian Gmeiner > > The MMU tells us the fault status. While the raw register value is > already printed, it's a bit more user friendly to translate the > fault reasons into human readable format. > > Signed-off-by: Christian

Re: [PATCH 1/2] drm/etnaviv: split fence lock

2022-12-02 Thread Philipp Zabel
On Thu, Dec 01, 2022 at 06:48:45PM +0100, Lucas Stach wrote: > The fence lock currently protects two distinct things. It protects the fence > IDR from concurrent inserts and removes and also keeps drm_sched_job_arm and > drm_sched_entity_push_job in one atomic section to guarantee the fence seqno >

Re: [PATCH 2/2] drm/etnaviv: convert user fence tracking to XArray

2022-12-02 Thread Philipp Zabel
On Thu, Dec 01, 2022 at 06:48:46PM +0100, Lucas Stach wrote: > This simplifies the driver code a bit, as XArray already provides > internal locking. IDRs are implemented using XArrays anyways, so > this drops one level of unneeded abstraction. > > Signed-off-by: Lucas Stach Reviewed-by: Philipp

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Tvrtko Ursulin
On 01/12/2022 20:39, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_m

Re: [PATCH] [RFC] drm/etnaviv: Disable softpin

2022-12-02 Thread Marek Vasut
On 12/2/22 09:59, Lucas Stach wrote: Am Freitag, dem 02.12.2022 um 00:21 +0100 schrieb Marek Vasut: Currently softpin suffers from assorted race conditions exposed by newer versions of mesa 22.2.y and 22.3.y . Those races are difficult to fix in older kernel versions due to massive amount of bac

[PATCH v5 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-02 Thread Tomi Valkeinen
Add clocks related to display which are needed to get the DSI output working. Extracted from Renesas BSP tree. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- drivers/clk/renesas/r8a779g0-cpg-mssr.c | 9 + 1 file changed, 9 insertions(+) di

[PATCH v5 4/7] arm64: dts: renesas: r8a779g0: Add display related nodes

2022-12-02 Thread Tomi Valkeinen
Add DT nodes for components needed to get the DSI output working: - FCPv - VSPd - DU - DSI Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 130 ++ 1 file

Re: [PATCH v2 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-02 Thread Tomi Valkeinen
Hi, On 30/11/2022 21:18, Geert Uytterhoeven wrote: Hi Tomi, On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen wrote: Add clocks related to display which are needed to get the DSI output working. Extracted from Renesas BSP tree. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Review

[PATCH v5 0/7] Renesas V4H DSI & DP output support

2022-12-02 Thread Tomi Valkeinen
From: Tomi Valkeinen Hi, These add support for DSI on V4H SoC (r8a779g0) and DP for Whitehawk board. I'm sending the full series for clarity. Changes to v4: - Changes in "clk: renesas: r8a779g0: Add display related clocks": * Fix formatting * Use R8A779G0_CLK_VIOBUSD2 as the s

[PATCH v5 7/7] drm: rcar-du: dsi: Add r8A779g0 support

2022-12-02 Thread Tomi Valkeinen
Add DSI support for r8a779g0. The main differences to r8a779a0 are in the PLL and PHTW setups. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 497 ++- drivers/gpu/drm/rcar-du/rcar_mipi_dsi_regs.h | 6 +- 2 files c

Re: Screen corruption using radeon kernel driver

2022-12-02 Thread Mikhail Krylov
On Thu, Dec 01, 2022 at 02:00:58PM +, Robin Murphy wrote: > On 2022-11-30 19:59, Mikhail Krylov wrote: > > On Wed, Nov 30, 2022 at 11:07:32AM -0500, Alex Deucher wrote: > > > On Wed, Nov 30, 2022 at 10:42 AM Robin Murphy > > > wrote: > > > > > > > > On 2022-11-30 14:28, Alex Deucher wrote: >

Re: [PATCH v2 3/7] clk: renesas: r8a779g0: Add display related clocks

2022-12-02 Thread Tomi Valkeinen
Hi Geert, Laurent, On 30/11/2022 21:18, Geert Uytterhoeven wrote: Hi Tomi, On Wed, Nov 23, 2022 at 8:00 AM Tomi Valkeinen wrote: Add clocks related to display which are needed to get the DSI output working. Extracted from Renesas BSP tree. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran

Re: [PATCH v5 1/2] drm/fourcc: Add Synaptics VideoSmart tiled modifiers

2022-12-02 Thread Randy Li
Sent from my iPad > On Dec 1, 2022, at 5:39 PM, Daniel Vetter wrote: > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > >> On Thu, Dec 01, 2022 at 12:49:16AM +0800, Randy Li wrote: >> >> >> Se

[PATCH v5 1/7] dt-bindings: display: renesas, du: Provide bindings for r8a779g0

2022-12-02 Thread Tomi Valkeinen
Extend the Renesas DU display bindings to support the r8a779g0 V4H. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/renesas,du.yaml | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v5 6/7] drm: rcar-du: Add r8a779g0 support

2022-12-02 Thread Tomi Valkeinen
Add support for DU on r8a779g0, which is identical to DU on r8a779a0. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++ drivers/gpu/drm/rcar-du/rcar_du_group.c | 2 +- 2 files change

RE: [PATCH v2 01/11] pwm: Make .get_state() callback return an error code

2022-12-02 Thread nobuhiro1.iwamatsu
> -Original Message- > From: Uwe Kleine-König > Sent: Thursday, December 1, 2022 12:22 AM > To: Thierry Reding > Cc: Conor Dooley ; Linus Walleij > ; Bartosz Golaszewski ; Douglas > Anderson ; Pavel Machek ; > Claudiu Beznea ; Nicolas Ferre > ; Alexandre Belloni > ; Ray Jui ; Scott > Bran

[PATCH v5 5/7] arm64: dts: renesas: white-hawk-cpu: Add DP output support

2022-12-02 Thread Tomi Valkeinen
Add DT nodes needed for the mini DP connector. The DP is driven by sn65dsi86, which in turn gets the pixel data from the SoC via DSI. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- .../dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 94 +

[PATCH v5 2/7] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-12-02 Thread Tomi Valkeinen
Extend the Renesas DSI display bindings to support the r8a779g0 V4H. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml | 3 ++- 1 file changed, 2 insertions(+

Re: [PATCH] [RFC] drm/etnaviv: Disable softpin

2022-12-02 Thread Lucas Stach
Am Freitag, dem 02.12.2022 um 11:20 +0100 schrieb Marek Vasut: > On 12/2/22 09:59, Lucas Stach wrote: > > Am Freitag, dem 02.12.2022 um 00:21 +0100 schrieb Marek Vasut: > > > Currently softpin suffers from assorted race conditions exposed by newer > > > versions of mesa 22.2.y and 22.3.y . Those ra

Re: [PATCH v2 10/12] arm64: dts: qcom: sm6115: Add i2c/spi nodes

2022-12-02 Thread Konrad Dybcio
On 30.11.2022 21:09, Adam Skladowski wrote: > Add I2C/SPI nodes for SM6115. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm6115.dtsi | 290 +++ > 1 file changed, 290 insertions(+) > > diff --git a/arch/arm64/b

Re: [PATCH v2 12/12] arm64: dts: qcom: sm6115: Add smmu fallback to qcom generic compatible

2022-12-02 Thread Konrad Dybcio
On 30.11.2022 21:09, Adam Skladowski wrote: > Add fallback to generic qcom mmu-500 implementation. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-02 Thread Marek Szyprowski
Hi, Sorry for delay, I was on a sick leave last 2 weeks. On 28.11.2022 15:43, Jagan Teki wrote: > ,On Sat, Nov 26, 2022 at 3:44 AM Marek Vasut wrote: >> On 11/23/22 21:09, Jagan Teki wrote: >>> On Sat, Nov 19, 2022 at 7:45 PM Marek Vasut wrote: On 11/17/22 14:04, Marek Szyprowski wrote: >>

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Andi Shyti
Hi Tvrtko, On Fri, Dec 02, 2022 at 10:20:11AM +, Tvrtko Ursulin wrote: > > On 01/12/2022 20:39, Andi Shyti wrote: > > From: Chris Wilson > > > > Introduce the concept of padding the i915_vma with guard pages before > > and after. The major consequence is that all ordinary uses of i915_vma >

Re: [PATCH 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-12-02 Thread Thomas Zimmermann
Hi Am 25.11.22 um 18:39 schrieb Noralf Trønnes: Den 21.11.2022 11.45, skrev Thomas Zimmermann: Move the vmap/vunmap blocks from the inner fb_dirty helpers into the MIPI DBI update helpers. The function calls can result in waiting and/or processing overhead. Reduce the penalties by executing t

Re: [PATCH v2 02/21] dt-bindings: display: tegra: vi: add 'vip' property and example

2022-12-02 Thread Krzysztof Kozlowski
On 02/12/2022 09:11, Luca Ceresoli wrote: > Hello Rob, > > On Thu, 1 Dec 2022 17:16:36 -0600 > Rob Herring wrote: > >> On Mon, Nov 28, 2022 at 04:23:17PM +0100, Luca Ceresoli wrote: >>> The Tegra20 VI peripheral can receive parallel input from the VIP parallel >>> input module. Add it to the all

Re: [PATCH 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-12-02 Thread Thomas Zimmermann
You use drm_gem_fb_vmap() in the other places but here you access the object directly (and in the next hunk), but again not so important since it goes away in a later patch. I'll update this patch to use drm_gem_fb_vmap() consistently. And after looking at the impact and churn, I rather go

[PATCH v6 0/8] Support for the NPU in Vim3

2022-12-02 Thread Tomeu Vizoso
Hi, This series adds support for the Verisilicon VIPNano-QI NPU in the A311D as in the VIM3 board. The IP is very closely based on previous Vivante GPUs, so the etnaviv kernel driver works basically unchanged. The userspace part of the driver is being reviewed at: https://gitlab.freedesktop.org

[PATCH v6 5/8] drm/etnaviv: Add nn_core_count to chip feature struct

2022-12-02 Thread Tomeu Vizoso
We will use these for differentiating between GPUs and NPUs, as the downstream driver does. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 3 +++ drivers/gpu/drm/etnaviv/etnaviv_hwdb.c | 4 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etna

[PATCH v6 6/8] drm/etnaviv: Warn when probing on NPUs

2022-12-02 Thread Tomeu Vizoso
Userspace is still not making full use of the hardware, so we don't know yet if changes to the UAPI won't be needed. Warn about it. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c

[PATCH v6 7/8] drm/etnaviv: add HWDB entry for VIPNano-QI.7120.0055

2022-12-02 Thread Tomeu Vizoso
This is a compute-only module marketed towards AI and vision acceleration. This particular version can be found on the Amlogic A311D SoC. The feature bits are taken from the Khadas downstream kernel driver 6.4.4.3.310723AAA. Signed-off-by: Tomeu Vizoso --- drivers/gpu/drm/etnaviv/etnaviv_hwdb.c

[RESEND PATCH linux-next 1/2] MAINTAINERS: Remove some obsolete drm drivers(tdfx, mga, i810, savage, r128, sis)

2022-12-02 Thread Cai Huoqing
Commit 399516ab0fee ("MAINTAINERS: Add a bunch of legacy (UMS) DRM drivers") marked these drivers obsolete 7 years ago. And the mesa UMD of these drm drivers already in deprecated list in the link: https://docs.mesa3d.org/systems.html 3dfx Glide-->driver/gpu/drm/tdfx Matrox-->driver/gpu/drm/mga In

Re: [PATCH 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-12-02 Thread Noralf Trønnes
Den 02.12.2022 12.27, skrev Thomas Zimmermann: > Hi > > Am 25.11.22 um 18:39 schrieb Noralf Trønnes: >> >> >> Den 21.11.2022 11.45, skrev Thomas Zimmermann: >>> Move the vmap/vunmap blocks from the inner fb_dirty helpers into the >>> MIPI DBI update helpers. The function calls can result in wai

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-02 Thread Marek Vasut
On 12/2/22 11:52, Marek Szyprowski wrote: Hi, Sorry for delay, I was on a sick leave last 2 weeks. On 28.11.2022 15:43, Jagan Teki wrote: ,On Sat, Nov 26, 2022 at 3:44 AM Marek Vasut wrote: On 11/23/22 21:09, Jagan Teki wrote: On Sat, Nov 19, 2022 at 7:45 PM Marek Vasut wrote: On 11/17/22

Re: [PATCH 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-12-02 Thread Noralf Trønnes
Den 02.12.2022 12.50, skrev Thomas Zimmermann: > >>> >>> You use drm_gem_fb_vmap() in the other places but here you access the >>> object directly (and in the next hunk), but again not so important since >>> it goes away in a later patch. >> >> I'll update this patch to use drm_gem_fb_vmap() co

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Introduce guard pages to i915_vma

2022-12-02 Thread Tvrtko Ursulin
On 02/12/2022 11:11, Andi Shyti wrote: Hi Tvrtko, On Fri, Dec 02, 2022 at 10:20:11AM +, Tvrtko Ursulin wrote: On 01/12/2022 20:39, Andi Shyti wrote: From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all or

[PATCH v2 2/8] drm/ili9225: Call MIPI DBI mode_valid helper

2022-12-02 Thread Thomas Zimmermann
MIPI DBI drivers validate each mode against their native resolution. Add this test to ili9225. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/tiny/ili9225.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tin

[PATCH v2 1/8] drm/simple-kms: Remove drm_gem_simple_display_pipe_prepare_fb()

2022-12-02 Thread Thomas Zimmermann
The helper drm_gem_simple_display_pipe_prepare_fb() is simple-KMS' default implementation for prepare_fb. Remove the call from drivers that set it explicitly. Then inline the helper into the only caller within simple-kms helpers. No functional changes. Simple-KMS drivers that implement the prepare

[PATCH v2 0/8] drm/mipi-dbi: Convert to shadow-plane helpers

2022-12-02 Thread Thomas Zimmermann
Convert the MIPI-DBI-based drivers to shadow-plane helpers. The drivers vmap/vunmap GEM buffer memory during the atomic commit. Shadow-plane helpers automate this process. Patches 1 to 4 prepare the MIPI code for the change and simplify the rest of the patchset. Patches 5 to 7 rework the vmap cod

[PATCH v2 7/8] drm/mipi-dbi: Use shadow-plane mappings

2022-12-02 Thread Thomas Zimmermann
Use the buffer mappings provided by shadow-plane helpers. As the mappings are established while the commit can still fail, errors are now reported correctly to callers. v2: * use shadow-plane state directly (Noralf) Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Tested-by:

[PATCH v2 4/8] drm/mipi-dbi: Initialize default driver functions with macro

2022-12-02 Thread Thomas Zimmermann
Introduce DRM_MIPI_DBI_SIMPLE_DISPLAY_PIPE_FUNCS to initialize MIPI-DBI helpers to default values and convert drivers. The prepare_fb function set by some drivers is called implicitly by simple-kms helpers, so leave it out. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Tested-by:

[PATCH v2 3/8] drm/st7586: Call MIPI DBI mode_valid helper

2022-12-02 Thread Thomas Zimmermann
MIPI DBI drivers validate each mode against their native resolution. Add this test to st7586. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/tiny/st7586.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/s

[PATCH v2 5/8] drm/mipi-dbi: Prepare framebuffer copy operation in pipe-update helpers

2022-12-02 Thread Thomas Zimmermann
Move the vmap/vunmap blocks from the inner fb_dirty helpers into the MIPI DBI update helpers. The function calls can result in waiting and/or processing overhead. Reduce the penalties by executing the functions once in the outer-most function of the pipe update. This change also prepares for MIPI

[PATCH v2 8/8] drm/mipi-dbi: Move drm_dev_{enter, exit}() out from fb_dirty functions

2022-12-02 Thread Thomas Zimmermann
Call drm_dev_enter() and drm_dev_exit() in the outer-most callbacks of the modesetting pipeline. If drm_dev_enter() fails, the driver can thus avoid unnecessary work. Signed-off-by: Thomas Zimmermann Reviewed-by: Noralf Trønnes Tested-by: Javier Martinez Canillas Tested-by: Noralf Trønnes # dr

[PATCH v2 6/8] drm/mipi-dbi: Support shadow-plane state

2022-12-02 Thread Thomas Zimmermann
Implement MIPI DBI planes with struct drm_shadow_plane_state, so that the respective drivers can use the vmap'ed GEM-buffer memory. Implement state helpers, the {begin,end}_fb_access helpers and wire up everything. With this commit, MIPI DBI drivers can access the GEM object's memory that is provi

Re: [PATCH v1 0/2] ASoC/tda998x: Fix reporting of nonexistent capture streams

2022-12-02 Thread Russell King (Oracle)
On Wed, Nov 30, 2022 at 06:46:42PM +, Mark Brown wrote: > The recently added pcm-test selftest has pointed out that systems with > the tda998x driver end up advertising that they support capture when in > reality as far as I can see the tda998x devices are transmit only. The > DAIs registered

[PATCH 0/2] vkms: Add support for multiple connectors

2022-12-02 Thread Marius Vlad
With multiple outputs available we can perform management of outputs at a more granular level, such that we're able to turn off or on, several outputs at a time, or combinations that arise from doing that. The Weston project use VKMS when running its test suite in CI, and we have now uses cases w

[PATCH 1/2] vkms: Pass the correct bitmask for possible crtcs

2022-12-02 Thread Marius Vlad
In preparation of having multiple outputs/virtual connectors we need to able to chose the correct encoder/connectors/crtc combination so pass also the index as a bitmask as possible crtcs for the encoder. Signed-off-by: Marius Vlad --- drivers/gpu/drm/vkms/vkms_output.c | 2 +- 1 file changed, 1

[PATCH 2/2] vkms: Add support for multiple connectors

2022-12-02 Thread Marius Vlad
This patch adds support for creating multiple virtual connectors, in case one would need it. Use module parameters to specify how many, defaulting to just one, allocating from the start, a maximum of 4 possible outputs. This is of particular importance when testing out the DRM backend in composito

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/mtl: Add hardware-level lock for steering

2022-12-02 Thread Balasubramani Vivekanandan
On 28.11.2022 15:30, Matt Roper wrote: > Starting with MTL, the driver needs to not only protect the steering > control register from simultaneous software accesses, but also protect > against races with hardware/firmware agents. The hardware provides a > dedicated locking mechanism to support thi

[PATCH v3 0/5] DSI host and peripheral initialisation ordering

2022-12-02 Thread Dave Stevenson
Hi All Changes from v2 (sorry it's taken me a while to get around to these): - Added Sam's patches to drop drm_bridge_chain functions - Renamed upstream to previously (Sam) - Moved copying of panel->prepare_prev_first to bridge->pre_enable_prev_first from drm_panel_bridge_add_typed to devm_drm_p

[PATCH v3 3/5] drm/bridge: Introduce pre_enable_prev_first to alter bridge init order

2022-12-02 Thread Dave Stevenson
DSI sink devices typically want the DSI host powered up and configured before they are powered up. pre_enable is the place this would normally happen, but they are called in reverse order from panel/connector towards the encoder, which is the "wrong" order. Add a new flag pre_enable_prev_first tha

[PATCH v3 2/5] drm/bridge: Drop unused drm_bridge_chain functions

2022-12-02 Thread Dave Stevenson
From: Sam Ravnborg The drm_bridge_chain_{pre_enable,enable,disable,post_disable} has no users left and we have atomic variants that should be used. Drop them so they do not gain new users. Adjust a few comments to avoid references to the dropped functions. Signed-off-by: Sam Ravnborg Reviewed-

[PATCH v3 4/5] drm/panel: Add prepare_prev_first flag to drm_panel

2022-12-02 Thread Dave Stevenson
Mapping to the drm_bridge flag pre_enable_prev_first, add a new flag prepare_prev_first to drm_panel to allow the panel driver to request that the upstream bridge should be pre_enabled before the panel prepare. Signed-off-by: Dave Stevenson Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/brid

[PATCH v3 5/5] drm/bridge: Document the expected behaviour of DSI host controllers

2022-12-02 Thread Dave Stevenson
The exact behaviour of DSI host controllers is not specified, therefore define it. Signed-off-by: Dave Stevenson Reviewed-by: Laurent Pinchart --- Documentation/gpu/drm-kms-helpers.rst | 7 + drivers/gpu/drm/drm_bridge.c | 39 +++ 2 files changed, 46 insert

[PATCH v3 1/5] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2022-12-02 Thread Dave Stevenson
From: Sam Ravnborg The atomic variants of enable/disable in drm_bridge_funcs are the preferred operations - introduce these. The ps8640 driver used the non-atomic variants of the drm_bridge_chain_pre_enable/ drm_bridge_chain_post_disable - convert these to the atomic variants. v2: - Init sta

Re: [PATCH v8 06/14] drm: bridge: samsung-dsim: Handle proper DSI host initialization

2022-12-02 Thread Dave Stevenson
Hi Marek On Fri, 2 Dec 2022 at 12:21, Marek Vasut wrote: > > On 12/2/22 11:52, Marek Szyprowski wrote: > > Hi, > > > > Sorry for delay, I was on a sick leave last 2 weeks. > > > > On 28.11.2022 15:43, Jagan Teki wrote: > >> ,On Sat, Nov 26, 2022 at 3:44 AM Marek Vasut wrote: > >>> On 11/23/22 21

Re: Try to address the DMA-buf coherency problem

2022-12-02 Thread Christian König
Am 30.11.22 um 11:30 schrieb Daniel Vetter: On Fri, Nov 25, 2022 at 11:40:04AM -0500, Nicolas Dufresne wrote: Le mercredi 23 novembre 2022 à 17:33 +0100, Daniel Vetter a écrit : On Wed, Nov 23, 2022 at 10:33:38AM +0200, Pekka Paalanen wrote: On Tue, 22 Nov 2022 18:33:59 +0100 Christian König

Re: [PATCH] drm/imx: ipuv3-plane: Fix overlay plane width

2022-12-02 Thread Lucas Stach
Am Dienstag, dem 08.11.2022 um 15:14 +0100 schrieb Philipp Zabel: > ipu_src_rect_width() was introduced to support odd screen resolutions > such as 1366x768 by internally rounding up primary plane width to a > multiple of 8 and compensating with reduced horizontal blanking. > This also caused overl

[pull] amdgpu, amdkfd drm-next-6.2

2022-12-02 Thread Alex Deucher
Hi Dave, Daniel, Last pull for 6.2. Support for some new GC 11.x variants and preemption support for GC 9.x. The rest is bug fixes. The following changes since commit 10d2d1fc05f03ee1626b60761a3425622767513e: drm/amdgpu: Partially revert "drm/amdgpu: update drm_display_info correctly when t

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Rodrigo Vivi
On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > Starting with MTL, there will be two GT-tiles, a render and media > tile. PXP as a service for supporting workloads with protected > contexts and protected buffers can be subscribed by process > workloads on any tile. However, depending

[PATCH] Revert "drm/sched: Use parent fence instead of finished"

2022-12-02 Thread Arvind Yadav
This reverts commit e4dc45b1848bc6bcac31eb1b4ccdd7f6718b3c86. This is causing instability on Linus' desktop, and Observed System hung when running MesaGL benchmark or VK CTS runs. netconsole got me the following oops: [ 1234.778760] BUG: kernel NULL pointer dereference, address:

Re: [PATCH] drm: tidss: Fix pixel format definition

2022-12-02 Thread Andrew Davis
On 12/1/22 6:18 PM, Randolph Sapp wrote: There was a long-standing bug from a typo that created 2 ARGB1555 and ABGR1555 pixel format entries. Weston 10 has a sanity check that alerted me to this issue. According to the Supported Pixel Data formats table we have the later entries should have been

Re: [PATCH] drm: kirin: Fix missing clk_disable_unprepare in ade_power_up()

2022-12-02 Thread John Stultz
On Fri, Dec 2, 2022 at 12:22 AM Shang XiaoJing wrote: > > The clk_disable_unprepare() should be called in the error handling of > ade_power_up(). So as reset_control_assert(). > > Fixes: 783ad972c9a0 ("drm/hisilicon: Add crtc driver for ADE") > Signed-off-by: Shang XiaoJing Looks reasonable to m

Re: [PATCH 1/3] drm/i915: place selftest preparation on a separate function

2022-12-02 Thread kernel test robot
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip drm/drm-next drm-misc/drm-misc-next linus/master v6.1-rc7 next-20221202] [If your patch is applied to the

Re: [PATCH] drm/i915/guc: enable GuC GGTT invalidation from the start

2022-12-02 Thread John Harrison
On 11/10/2022 09:58, Daniele Ceraolo Spurio wrote: Invalidating the GuC TLBs while GuC is not loaded does not have negative consequences, so if we're starting the driver with GuC enabled we can use the GGTT invalidation function from the get-go, iinstead of switching to it when we initialize the

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Teres Alexis, Alan Previn
On Fri, 2022-12-02 at 11:22 -0500, Vivi, Rodrigo wrote: > On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > > Starting with MTL, there will be two GT-tiles, a render and media > > tile. PXP as a service for supporting workloads with protected > > contexts and protected buffers can be

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-12-02 Thread John Harrison
On 12/1/2022 04:01, Tvrtko Ursulin wrote: On 01/12/2022 11:56, Michal Wajdeczko wrote: On 01.12.2022 01:41, John Harrison wrote: On 11/23/2022 12:45, Michal Wajdeczko wrote: On 23.11.2022 02:25, John Harrison wrote: On 11/22/2022 09:54, Michal Wajdeczko wrote: On 18.11.2022 02:58, john.c.har

[linux-next:master] BUILD REGRESSION 5be860bfc73408bc1a8af9167955e480ecebba84

2022-12-02 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 5be860bfc73408bc1a8af9167955e480ecebba84 Add linux-next specific files for 20221202 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211041320.coq8eelj-...@intel.com https

Re: [Intel-gfx] [PATCH v7 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Vivi, Rodrigo
On Fri, 2022-12-02 at 19:21 +, Teres Alexis, Alan Previn wrote: > > > On Fri, 2022-12-02 at 11:22 -0500, Vivi, Rodrigo wrote: > > On Thu, Dec 01, 2022 at 05:14:07PM -0800, Alan Previn wrote: > > > Starting with MTL, there will be two GT-tiles, a render and media > > > tile. PXP as a service f

[PATCH] drm/i915/mtl: Check full IP version when applying hw steering semaphore

2022-12-02 Thread Matt Roper
When determining whether the platform has a hardware-level steering semaphore (i.e., MTL and beyond), we need to use GRAPHICS_VER_FULL() to compare the full version rather than just the major version number returned by GRAPHICS_VER(). Reported-by: kernel test robot Fixes: 3100240bf846 ("drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Check full IP version when applying hw steering semaphore

2022-12-02 Thread Rodrigo Vivi
On Fri, Dec 02, 2022 at 02:35:28PM -0800, Matt Roper wrote: > When determining whether the platform has a hardware-level steering > semaphore (i.e., MTL and beyond), we need to use GRAPHICS_VER_FULL() to > compare the full version rather than just the major version number > returned by GRAPHICS_VER

[PATCH v8 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-02 Thread Alan Previn
Starting with MTL, there will be two GT-tiles, a render and media tile. PXP as a service for supporting workloads with protected contexts and protected buffers can be subscribed by process workloads on any tile. However, depending on the platform, only one of the tiles is used for control events pe

Re: [PATCH V4 1/3] dt-bindings: display: panel: Add Samsung AMS495QA01

2022-12-02 Thread Linus Walleij
Hi Chris, thanks for your patch! On Tue, Nov 29, 2022 at 6:29 PM Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan > Signed-off-by: Maya Matuszczyk > + reset-gpios: true Can you add a description saying that th

Re: [git pull] drm fixes for 6.1-rc8

2022-12-02 Thread pr-tracker-bot
The pull request you sent on Fri, 2 Dec 2022 11:44:43 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-12-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c290db013742e98fe5b64073bc2dd8c8a2ac9e4c Thank you! -- Deet-doot-dot, I am a bot. https://ko